Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Wed, 21 Sep 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi Alan, > > On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: > > This is a lot better.  No more I/O errors. > > > > We still have irregular suspends and resumes, but that's to be  > >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Ulf, On Wed, 2016-09-21 at 13:17 +0200, Ulf Hansson wrote: > > I am pretty sure the memstick driver causes additional access to the > usb device without first calling pm_runtime_get_sync(). To eliminate > those cases from causing the issues,

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 21 September 2016 at 13:10, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi Alan, > > On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: >> This is a lot better. No more I/O errors. >> >> We still have irregular suspends and resumes,

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Alan, On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: > This is a lot better.  No more I/O errors. > > We still have irregular suspends and resumes, but that's to be  > expected.  More worrying are the spontaneous disconnects.  They don't 

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Tue, 2016-09-20 at 11:43 -0400, Alan Stern wrote: > > Yes. But that'd also mean to write that value upon every suspend/resume > cycle > > because the rtsx usb driver still declares support for autosuspend. > > Should that be dropped ? > > No,

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Tue, 20 Sep 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hello Alan, > > On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: > > This is a lot better.  No more I/O errors. > > > > We still have irregular suspends and resumes, but that's to be  > >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, On Tue, 2016-09-20 at 10:16 -0400, Alan Stern wrote: > This is a lot better.  No more I/O errors. > > We still have irregular suspends and resumes, but that's to be  > expected.  More worrying are the spontaneous disconnects.  They

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 2016-09-19 at 13:48 -0400, Alan Stern wrote: > > This ought to help.  Ritesh, please apply this patch on top of the  > two earlier ones and let's see what happens. > > Alan Stern > > Please find the logs at the following links. On this

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Mon, 19 Sep 2016, Ulf Hansson wrote: > On 18 September 2016 at 03:42, Alan Stern wrote: > > Well, this is pretty clear: > > > > Sep 17 15:55:52 learner kernel: CPU: 1 PID: 535 Comm: rtsx_usb_ms_1 > > Tainted: G U 4.8.0-rc6ulf1alan1+ #19 > > Sep 17

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 18 September 2016 at 03:42, Alan Stern wrote: > On Sat, 17 Sep 2016, Ritesh Raj Sarraf wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> Hello Alan, >> >> >> On Fri, 2016-09-16 at 17:40 -0400, Alan Stern wrote: >> > We're still getting runtime

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Sat, 17 Sep 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hello Alan, > > > On Fri, 2016-09-16 at 17:40 -0400, Alan Stern wrote: > > We're still getting runtime suspends, but now at 2-second intervals.    > > This is partly because the driver isn't

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, On Fri, 2016-09-16 at 17:40 -0400, Alan Stern wrote: > We're still getting runtime suspends, but now at 2-second intervals.    > This is partly because the driver isn't calling > pm_runtime_mark_last_busy(), but there may be more to

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Fri, 16 Sep 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hello Ulf and Alan, > > On Thu, 2016-09-15 at 10:16 -0400, Alan Stern wrote: > > > --- > > >  drivers/mmc/host/rtsx_usb_sdmmc.c | 2 ++ > > >  1 file changed, 2 insertions(+) > > >  > > > diff

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Ulf and Alan, On Thu, 2016-09-15 at 10:16 -0400, Alan Stern wrote: > > --- > >  drivers/mmc/host/rtsx_usb_sdmmc.c | 2 ++ > >  1 file changed, 2 insertions(+) > >  > > diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c > >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Thu, 15 Sep 2016, Ulf Hansson wrote: > > The situation isn't any better. At the start of the trace, > > the device is in runtime suspend but there are many attempts to > > communicate with it, all of which fail. > > It's really weird. Have this driver ever worked!? :-) Probably not. Or at

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 14 September 2016 at 17:19, Alan Stern wrote: > On Wed, 14 Sep 2016, Ritesh Raj Sarraf wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> Hello Ulf and Alan, >> >> On Fri, 2016-09-09 at 19:34 +0530, Ritesh Raj Sarraf wrote: >> > For #2, I'm building

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Wed, 14 Sep 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hello Ulf and Alan, > > On Fri, 2016-09-09 at 19:34 +0530, Ritesh Raj Sarraf wrote: > > For #2, I'm building the 4.8-rc5 kernel with the following change. This > > build > > does not include

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Ulf and Alan, On Fri, 2016-09-09 at 19:34 +0530, Ritesh Raj Sarraf wrote: > For #2, I'm building the 4.8-rc5 kernel with the following change. This build > does not include the previous change you had suggested (related to > POWER_CYCLE) > >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Fri, 9 Sep 2016, Ritesh Raj Sarraf wrote: > On Fri, 2016-09-09 at 18:44 +0530, Ritesh Raj Sarraf wrote: > > On Fri, 2016-09-09 at 12:54 +0200, Ulf Hansson wrote: > > > This affects the way the core calls the host driver's ->set_ios() > > > callback. Earlier it was invoked first to do power off

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Fri, 2016-09-09 at 18:44 +0530, Ritesh Raj Sarraf wrote: > On Fri, 2016-09-09 at 12:54 +0200, Ulf Hansson wrote: > > This affects the way the core calls the host driver's ->set_ios() > > callback. Earlier it was invoked first to do power off then

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Fri, 2016-09-09 at 12:54 +0200, Ulf Hansson wrote: > This affects the way the core calls the host driver's ->set_ios() > callback. Earlier it was invoked first to do power off then power up. > With this change it starts with power up instead. > I

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 7 September 2016 at 22:48, Alan Stern wrote: > On Tue, 6 Sep 2016, Ulf Hansson wrote: > >> On 5 September 2016 at 17:58, Alan Stern wrote: >> > On Mon, 5 Sep 2016, Ritesh Raj Sarraf wrote: >> > >> >> -BEGIN PGP SIGNED MESSAGE- >>

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Tue, 6 Sep 2016, Ulf Hansson wrote: > On 5 September 2016 at 17:58, Alan Stern wrote: > > On Mon, 5 Sep 2016, Ritesh Raj Sarraf wrote: > > > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA512 > >> > >> On Sun, 2016-09-04 at 15:46 -0400, Alan Stern wrote: > >> >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Ulf, On Tue, 2016-09-06 at 11:42 +0200, Ulf Hansson wrote: > > By reviewing the code of the rtsx_usb_sdmmc driver, particularly how > it calls pm_runtime_get|put() I am guessing those calls may not be > properly deployed. Perhaps

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 5 September 2016 at 17:58, Alan Stern wrote: > On Mon, 5 Sep 2016, Ritesh Raj Sarraf wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> On Sun, 2016-09-04 at 15:46 -0400, Alan Stern wrote: >> > >> > This is not the problem I was discussing with Ulf.

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Mon, 5 Sep 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On Sun, 2016-09-04 at 15:46 -0400, Alan Stern wrote: > > > > This is not the problem I was discussing with Ulf.  The problem was why > > the device kept going into and out of runtime suspend

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Sun, 2016-09-04 at 15:46 -0400, Alan Stern wrote: > > This is not the problem I was discussing with Ulf.  The problem was why > the device kept going into and out of runtime suspend every three > seconds.  The kernel log above does not say

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Sun, 4 Sep 2016, Ritesh Raj Sarraf wrote: > > This issue has been around with previous kernels too. > > > > > Perhaps you can run a test on a 4.8 rc4 kernel, just to double check. > > > The 4.8 rc4, contains the following fixes in the mmc block layer. > > >  > > > commit 7afafc8a44bf ("block:

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Sun, 2016-09-04 at 17:02 +0530, Ritesh Raj Sarraf wrote: > > Sorry for the delay! We have had some regressions for 4.8 rc1 in the > > mmc block layer. Those problem should be resolved by now. > >  > > By reading from the runtime PM issues you

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, Ulf. Sorry for the delayed reply. Last week was a sickly week for me. On Tue, 2016-08-30 at 10:14 +0200, Ulf Hansson wrote: > On 25 August 2016 at 19:17, Alan Stern wrote: > > Ulf: > > > > Ritesh has

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 25 August 2016 at 19:17, Alan Stern wrote: > Ulf: > > Ritesh has collected logs showing that his Realtek RTS5129 USB card > reader (drivers/mfd/rtsx_usb.c, drivers/mmc/host/rtsx_usb_sdmmc.c) goes > into runtime autosuspend every 3 seconds and then immediately

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, On Fri, 2016-08-26 at 10:14 -0400, Alan Stern wrote: > > [ 8758.487792] usb 1-4: USB disconnect, device number 13 > > [ 8759.711773] usb 1-4: new high-speed USB device number 16 using xhci_hcd > > [ 8759.885543] usb 1-4: New USB device

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Fri, 26 Aug 2016, Ritesh Raj Sarraf wrote: > I was able to reproduce the resets after disabling LPM too. > > [ 5026.849192] systemd[1]: apt-daily.timer: Adding 6h 13min 53.496331s random > time. > [ 5027.078155] systemd[1]: apt-daily.timer: Adding 5h 55min 19.813619s random > time. > [

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, On Thu, 2016-08-25 at 19:04 +0530, Ritesh Raj Sarraf wrote: > > As you mentioned above, there's another aspect to power management  > > besides runtime PM, namely Link Power Management.  Perhaps the device  > > can't handle LPM. > >  >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

Ulf: Ritesh has collected logs showing that his Realtek RTS5129 USB card reader (drivers/mfd/rtsx_usb.c, drivers/mmc/host/rtsx_usb_sdmmc.c) goes into runtime autosuspend every 3 seconds and then immediately resumes. This sounds like something is failing to call pm_runtime_mark_last_busy().

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, On Wed, 2016-08-24 at 10:10 -0400, Alan Stern wrote: > On Wed, 24 Aug 2016, Ritesh Raj Sarraf wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > >  > > On Tue, 2016-08-23 at 15:14 -0400, Alan Stern wrote: > > > Okay,

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Wed, 24 Aug 2016, Ritesh Raj Sarraf wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On Tue, 2016-08-23 at 15:14 -0400, Alan Stern wrote: > > Okay, good.  The "Driver=rtsx_usb" is what I wanted to see.  Something > > funny is going on with that driver -- it claims to support

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, Please find some findings below. On Wed, 2016-08-24 at 15:01 +0530, Ritesh Raj Sarraf wrote: > I have a question though. For power saving, I use Laptop Mode Tools. Based on > power state (AC or BATT), it enables/disables power saving

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Tue, 2016-08-23 at 15:14 -0400, Alan Stern wrote: > Okay, good.  The "Driver=rtsx_usb" is what I wanted to see.  Something > funny is going on with that driver -- it claims to support autosuspend  > but it doesn't ever call usb_mark_last_busy()

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Tue, 23 Aug 2016, Ritesh Raj Sarraf wrote: > This one is after a fresh boot. > > T:  Bus=02 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#=  9 Spd=480  MxCh= 0 > D:  Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=ff MxPS=64 #Cfgs=  1 > P:  Vendor=0bda ProdID=0129 Rev=39.60 > S:  Manufacturer=Generic > S:  

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Tue, 2016-08-23 at 14:21 +0530, Ritesh Raj Sarraf wrote: > In one of yesterday's email, I have shared the output of > /sys/kernel/debug/usb/devices before the bug is triggered. The same I've > pasted > below. > > T:  Bus=01 Lev=01 Prnt=01

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Thank you Alan for confirming the bug. On Mon, 2016-08-22 at 15:09 -0400, Alan Stern wrote: > > https://people.debian.org/~rrs/tmp/usb_1u-usbmon.txt.gz > >  > > https://people.debian.org/~rrs/tmp/dmesg-usbmon.txt > > The usbmon trace shows two

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Mon, 22 Aug 2016, Ritesh Raj Sarraf wrote: > Hello Mathias, > > I finally reproduced the bug. So the linked usbmon log should have it. But > its a > whopping 22 MiB. It seems it takes a couple of hours of the OS running to > trigger the bug. > >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 2016-08-22 at 21:01 +0530, Ritesh Raj Sarraf wrote: > >  > > Even after fresh unload/load, the acutal problematic devid "0bda:0129", does > > not appear. I'll report back again after a fresh reboot. > >  > >

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Dropping Alan from To list. On Mon, 2016-08-22 at 20:09 +0530, Ritesh Raj Sarraf wrote: > On Mon, 2016-08-22 at 18:11 +0530, Ritesh Raj Sarraf wrote: > > > > > > I'll post back again once I have captured the relevant logs. > > > > Thank you for

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 2016-08-22 at 18:11 +0530, Ritesh Raj Sarraf wrote: > > I'll post back again once I have captured the relevant logs. > > Thank you for looking into this. It got more tricky to pick the logs. When the bug is hit, the device vanishes from

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 2016-08-22 at 11:24 +0300, Mathias Nyman wrote: > * A few disconnects, were these real disconnects done by you?: No. Nothing was even plugged into the USB ports. And the resets keep recurring. >   Aug 18 23:55:57 learner kernel: usb 1-4:

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 19.08.2016 13:26, Ritesh Raj Sarraf wrote: Hello Mathia, On Fri, 2016-08-19 at 11:42 +0300, Mathias Nyman wrote: It'd help to know if it really is a bug or something else. Could you add xhci debugging?. The current logs mainly show usb core reporting errors on urbs returned (or timeout)

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I am not sure if the logs ever reached the list. I've uploaded the logs here [1] for convenience. [1] https://people.debian.org/~rrs/tmp/usb-xhci-dmesg.txt.gz On Fri, 2016-08-19 at 15:56 +0530, Ritesh Raj Sarraf wrote: > Hello Mathia, > > On

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

On 18.08.2016 17:33, Ritesh Raj Sarraf wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Mathias, Hi Can you please confirm of the erratic behavior we've discussed so far, on this thread ? It'd help to know if it really is a bug or something else. Could you add xhci

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Fri, 2016-08-12 at 11:48 -0400, Alan Stern wrote: > > These could indicate some sort of problem with the driver for the xHCI > controller.  However, I'm not an expert on xhci-hcd.  Mathias is the > maintainer for that driver. Okay! So I'll wait

xHCI problem? [was Re: Erratic USB device behavior and device loss]

On Fri, 12 Aug 2016, Ritesh Raj Sarraf wrote: > So I booted into Windows 8.1 and tried to access an SDCard over the Card > Reader. > I was able to see the drive and read the content in it. > I did check for relevant messages in the Windows Event Log but couldn't find > anything relevant. > >