Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Wolfgang Mües
Pete, On Dienstag, 24. Juli 2007, Pete Zaitcev wrote: > Please keep in mind that all this discussion about short reads has > nothing to do with your real problem (e.g. the device which used to > reply with a stall stopped to do so, or it continues to reply with a > stall token, but EHCI fails to r

Re: [linux-usb-devel] [PATCH] aio_run_iocb should always retry

2007-07-24 Thread David Brownell
On Tuesday 24 July 2007, Zach Brown wrote: > So, the sad story is that the cancellation support in fs/aio.c is a   > mess.  Before we get lost on those details can we talk about simply   > not allowing cancelation of these usbfs2 aio read requests?  If they   > guarantee forward progress Nope ...

Re: [linux-usb-devel] backport of 2.6.22.1 g_ether to 2.6.16?

2007-07-24 Thread David Brownell
On Tuesday 24 July 2007, Aras Vaichas wrote: > Hello, > > does anyone know of a reason why I wouldn't be able to backport the 2.6.22.1 > drivers/usb/gadget/ether.c to work with a 2.6.16 kernel? Nothing beyond potential minor backport issues; the kernel has changed a bit since then! But I can't

[linux-usb-devel] backport of 2.6.22.1 g_ether to 2.6.16?

2007-07-24 Thread Aras Vaichas
Hello, does anyone know of a reason why I wouldn't be able to backport the 2.6.22.1 drivers/usb/gadget/ether.c to work with a 2.6.16 kernel? Background: We are looking at using MCCI's host-side SAFE driver (and finally moving away from Microsoft's RNDIS solution). To use the MCCI driver we need

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Ron Gage
Alan Stern wrote: > No, I said to look at the "up" _reports_. "report" != "packet". > > For IN transfers (from the device to the host), yes, the transfer data > is displayed in the "up" report. For OUT transfers (host to device) > the transfer data is displayed in the "down" report. For con

Re: [linux-usb-devel] [PATCH] aio_run_iocb should always retry

2007-07-24 Thread Zach Brown
On Jul 24, 2007, at 4:23 PM, Sarah Bailey wrote: > On Tue, Jul 24, 2007 at 03:09:43PM -0700, Zach Brown wrote: >> On Jul 24, 2007, at 1:17 PM, Sarah Sharp wrote: >> >>> When an AIO operation is cancelled >> >> So, the sad story is that the cancellation support in fs/aio.c is a >> mess. Before we

Re: [linux-usb-devel] [PATCH] aio_run_iocb should always retry

2007-07-24 Thread Sarah Bailey
On Tue, Jul 24, 2007 at 03:09:43PM -0700, Zach Brown wrote: > On Jul 24, 2007, at 1:17 PM, Sarah Sharp wrote: > > >When an AIO operation is cancelled > > So, the sad story is that the cancellation support in fs/aio.c is a > mess. Before we get lost on those details can we talk about simply >

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pete Zaitcev
On Tue, 24 Jul 2007 18:18:04 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > > > static int usb_start_wait_urb(struct urb *urb, int timeout, int > > > *actual_length) > > > { > > > - int status = urb->status; > > > retval = usb_submit_urb(urb, GFP_NOIO); > > > > Oh. My. God. > > I'm n

[linux-usb-devel] [PATCH] USB: Fix a bug in usb_start_wait_urb

2007-07-24 Thread Alan Stern
This patch (as941) fixes a bug recently added to the USB synchronous API. The status of a completed URB must be preserved separately across a completion callback. Also, the actual_length value isn't available until after the URB has fully completed. Signed-off-by: Alan Stern <[EMAIL PROTECTED]>

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Pete Zaitcev wrote: > On Tue, 24 Jul 2007 16:46:21 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> > wrote: > > > static int usb_start_wait_urb(struct urb *urb, int timeout, int > > *actual_length) > > { > > - struct completion done; > > + struct api_context ctx; > >

Re: [linux-usb-devel] [PATCH] aio_run_iocb should always retry

2007-07-24 Thread Zach Brown
On Jul 24, 2007, at 1:17 PM, Sarah Sharp wrote: > When an AIO operation is cancelled So, the sad story is that the cancellation support in fs/aio.c is a mess. Before we get lost on those details can we talk about simply not allowing cancelation of these usbfs2 aio read requests? If they

Re: [linux-usb-devel] Bug in EHCI split-interrupt handling

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Pete Zaitcev wrote: > On Tue, 24 Jul 2007 15:44:23 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> > wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=8535 > > > > contains logs suggestive of problems with EHCI split-interrupt > > handling. See in particular comment

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pavel Roskin
On Tue, 2007-07-24 at 13:52 -0700, Pete Zaitcev wrote: > On Tue, 24 Jul 2007 16:28:15 -0400, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > > It turns out usb_control_msg() returns 0 in two cases where it returns > > -EPIPE in Linux 2.6.22. > > This is significant. EPIPE is a "stall", but zero bytes

Re: [linux-usb-devel] Bug in EHCI split-interrupt handling

2007-07-24 Thread Pete Zaitcev
On Tue, 24 Jul 2007 15:44:23 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8535 > > contains logs suggestive of problems with EHCI split-interrupt > handling. See in particular comment #33; the usbmon log in comment #32 > contains a line in

Re: [linux-usb-devel] Fw: [Bugme-new] [Bug 8104] New: kernel floods console with "connect-debounce failed"

2007-07-24 Thread Oliver Neukum
Am Dienstag 24 Juli 2007 schrieb Andrew Morton: > guys, there have been updates to this bug via the bugzilla UI, > at http://bugzilla.kernel.org/show_bug.cgi?id=8104 > Hi, we need to know the oldest kernel that does not work. Please try 2.6.18 and 2.6.19 Regards Oliver

Re: [linux-usb-devel] Fw: [Bugme-new] [Bug 8104] New: kernel floods console with "connect-debounce failed"

2007-07-24 Thread Andrew Morton
guys, there have been updates to this bug via the bugzilla UI, at http://bugzilla.kernel.org/show_bug.cgi?id=8104 - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now S

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pete Zaitcev
On Tue, 24 Jul 2007 16:46:21 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > static int usb_start_wait_urb(struct urb *urb, int timeout, int > *actual_length) > { > - struct completion done; > + struct api_context ctx; > unsigned long expire; > int retval; > - int

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pavel Roskin
On Tue, 2007-07-24 at 16:46 -0400, Alan Stern wrote: > I found the problem. Greg's urb->status conversion was somewhat hasty. > Here's an untested patch to fix it. It's working, thank you!!! -- Regards, Pavel Roskin -

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Pavel Roskin wrote: > However, I think it's wrong to return 0 if more than 0 bytes were > requested. usb_control_msg() is synchronous, and the caller is supposed > to wait for the data. If the function returns and the data is not > there, it should be an error IMHO. No. Th

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pete Zaitcev
On Tue, 24 Jul 2007 16:28:15 -0400, Pavel Roskin <[EMAIL PROTECTED]> wrote: > It turns out usb_control_msg() returns 0 in two cases where it returns > -EPIPE in Linux 2.6.22. This is significant. EPIPE is a "stall", but zero bytes is zero bytes. Normally they do not mix. If a device stalls a requ

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread David Brownell
On Tuesday 24 July 2007, Pavel Roskin wrote: > > The URB_SHORT_NOT_OK flag is not default. I don't remember exactly why. > > I guess you mean that the temporary URB in usb_internal_control_msg() > should use that flag?  That sounds like a good idea, at least on the > surface. No it doesn't. It's

Re: [linux-usb-devel] [PATCH] aio_run_iocb should always retry

2007-07-24 Thread David Brownell
On Tuesday 24 July 2007, Sarah Sharp wrote: > The problem comes when someone calls sys_io_cancel() on a read.  If the > retry function has started before this point, everything is fine. > However, if sys_io_cancel() runs before the retry function, aio_run_iocb > will notice the iocb is cancelled an

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Pavel Roskin wrote: > Hi, Pete! > > On Tue, 2007-07-24 at 13:09 -0700, Pete Zaitcev wrote: > > On Tue, 24 Jul 2007 01:55:26 -0400, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > > > I was able to check that the data buffer remains unchanged even though > > > the data size is no

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pete Zaitcev
On Tue, 24 Jul 2007 16:26:30 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > 2.6.23-rc1 has no apparent problem with control messages in ehci-hcd on > my machine. Is it possible that the device really has sent back 0 > bytes? > > usbmon might help here. I didn't ask Pavel to run usbmon b

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pavel Roskin
Hi, Pete! On Tue, 2007-07-24 at 13:09 -0700, Pete Zaitcev wrote: > On Tue, 24 Jul 2007 01:55:26 -0400, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > I was able to check that the data buffer remains unchanged even though > > the data size is not 0. Actually, the return code is 0, which indicates >

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Pete Zaitcev wrote: > On Tue, 24 Jul 2007 01:55:26 -0400, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > > The driver stopped working after I upgraded from Linux 2.6.22 to Linux > > 2.6.23-rc1. No compile errors or warnings needed to be fixed. > > > I was able to check that th

[linux-usb-devel] [PATCH] aio_run_iocb should always retry

2007-07-24 Thread Sarah Sharp
When an AIO operation is cancelled, the ki_cancel callback can't determine whether the ki_retry callback will ever be called. As a result, it can't correctly determine whether to free resources. This patch changes aio_run_iocb to always call ki_retry. Signed-off-by: Sarah Sharp <[EMAIL PROTECTED]>

Re: [linux-usb-devel] usb_control_msg() reads 0 bytes in Linux 2.6.23-rc1

2007-07-24 Thread Pete Zaitcev
On Tue, 24 Jul 2007 01:55:26 -0400, Pavel Roskin <[EMAIL PROTECTED]> wrote: > The driver stopped working after I upgraded from Linux 2.6.22 to Linux > 2.6.23-rc1. No compile errors or warnings needed to be fixed. > I was able to check that the data buffer remains unchanged even though > the data

[linux-usb-devel] Bug in EHCI split-interrupt handling

2007-07-24 Thread Alan Stern
This bug report: http://bugzilla.kernel.org/show_bug.cgi?id=8535 contains logs suggestive of problems with EHCI split-interrupt handling. See in particular comment #33; the usbmon log in comment #32 contains a line in which a low-speed interrupt URB returns with status equal to 0 and act

[linux-usb-devel] [PATCH] gigaset: clean up urb->status usage

2007-07-24 Thread Tilman Schmidt
From: Tilman Schmidt <[EMAIL PROTECTED]> Make there only be one reference to urb->status per URB callback, and none outside, in preparation for removal of that field. Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]> --- drivers/isdn/gigaset/bas-gigaset.c | 84 +---

[linux-usb-devel] [PATCH] gigaset: remove pointless locking

2007-07-24 Thread Tilman Schmidt
From: Tilman Schmidt <[EMAIL PROTECTED]> Remove pointless taking of spinlock around reading a single pointer-sized or smaller variable. Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]> --- drivers/isdn/gigaset/bas-gigaset.c |9 + drivers/isdn/gigaset/i4l.c | 12 ++

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Ron Gage wrote: > > Don't you remember what I told you a few days ago? The setup packet > > contents in the "down" report are unreliable. You need to look at an > > "up" report. > > > > Alan Stern > > > > > I remember it quite clearly. You told me to look at the "UP" p

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Ron Gage wrote: > I have made the entire SnoopyPro capture file available on my web site: > http://www.rongage.org/xyloc.usblog Consider URB #10 as a good example. The information for the "up" part says that the Setup packet consists of: c2 00 ac 53 00 00 08 00 That's

Re: [linux-usb-devel] [PATCH] Stall control endpoint when file storage class request wValue != 0

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Luis Lloret wrote: > From: Luis Lloret <[EMAIL PROTECTED]> > > This patch makes the File Storage Gadget stall the control endpoint > when a MSC class request is made with wValue != 0. This change makes > some MSC compliance test warnings dissapear. > > Signed-off-by: Luis L

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Ron Gage
Alan: Alan Stern wrote: > On Tue, 24 Jul 2007, Ron Gage wrote: > > >> This is a good one to start with as it is seen literally hundreds of >> times in the trace. >> >> 20in downn/a3.195VENDOR_ENDPOINT- >> URB Header (length: 80) >> SequenceNumber: 20 >> Function: 0019 (V

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Ron Gage wrote: > This is a good one to start with as it is seen literally hundreds of > times in the trace. > > 20in downn/a3.195VENDOR_ENDPOINT- > URB Header (length: 80) > SequenceNumber: 20 > Function: 0019 (VENDOR_ENDPOINT) > PipeHandle:

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Alan Stern
On Tue, 24 Jul 2007, Ron Gage wrote: > Greetings: > > I need some help here. I am trying to develop a driver for an > "EnsureTechnologies Xyloc Model U-1" USB-based security device. It is > basically an RFID receiver and matchbook sized serialized remote - the > RFID receiver detects when th

Re: [linux-usb-devel] 2.6.22+: BUG: sleeping function called from invalid context at /home/jeremy/hg/xen/paravirt/linux/drivers/usb/core/urb.c:524, in_atomic():1, irqs_disabled():0

2007-07-24 Thread Oliver Neukum
> Clearly there's a bug in > drivers/usb/serial/usb-serial.c:usb_serial_put(). It shouldn't call > kref_put() while holding a spinlock. As I was reminded, I polluted the namespace. Here's a better version. Does it fix your problem? Regards Oliver Signed-off-by: Oliver

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Ron Gage
Oliver Neukum wrote: > Am Dienstag 24 Juli 2007 schrieb Ron Gage: > >> Anyhow, the device appears to require a non-standard function code in >> the URB header, code 0019. SnoopyPro (yeah, on Windows) says this >> function code is "Vendor Endpoint". Obviously, there isn't any current >> way

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Ron Gage
Oliver Neukum wrote: > Am Dienstag 24 Juli 2007 schrieb Ron Gage: > >> Anyhow, the device appears to require a non-standard function code in >> the URB header, code 0019. SnoopyPro (yeah, on Windows) says this >> function code is "Vendor Endpoint". Obviously, there isn't any current >> way

Re: [linux-usb-devel] USB Driver help needed

2007-07-24 Thread Oliver Neukum
Am Dienstag 24 Juli 2007 schrieb Ron Gage: > Anyhow, the device appears to require a non-standard function code in > the URB header, code 0019.  SnoopyPro (yeah, on Windows) says this > function code is "Vendor Endpoint".  Obviously, there isn't any current > way to send such a function code wit

[linux-usb-devel] USB Driver help needed

2007-07-24 Thread Ron Gage
Greetings: I need some help here. I am trying to develop a driver for an "EnsureTechnologies Xyloc Model U-1" USB-based security device. It is basically an RFID receiver and matchbook sized serialized remote - the RFID receiver detects when the remote is within range and reports back to the

Re: [linux-usb-devel] [PATCH] usb/atm: fix Kconfig garbage

2007-07-24 Thread Borislav Petkov
On Tue, Jul 24, 2007 at 10:28:55AM +0200, Duncan Sands wrote: > Hi, > > > When entered, the menu point "USB DSL modem support" in menuconfig, path > > [Device Drivers->USB > > Support] shows no entries but "^@" instead. The following fixes it. > > is the problem that there are no entries, or tha

Re: [linux-usb-devel] [PATCH] usb/atm: fix Kconfig garbage

2007-07-24 Thread Duncan Sands
Hi, > When entered, the menu point "USB DSL modem support" in menuconfig, path > [Device Drivers->USB > Support] shows no entries but "^@" instead. The following fixes it. is the problem that there are no entries, or that "^@" is displayed? If there are no entries then presumably you didn't tu

Re: [linux-usb-devel] 2.6.22+: BUG: sleeping function called from invalid context at /home/jeremy/hg/xen/paravirt/linux/drivers/usb/core/urb.c:524, in_atomic():1, irqs_disabled():0

2007-07-24 Thread Oliver Neukum
> Clearly there's a bug in > drivers/usb/serial/usb-serial.c:usb_serial_put(). It shouldn't call > kref_put() while holding a spinlock. Yes, these functions need to sleep. Does this work? Regards Oliver --- --- a/drivers/usb/serial/usb-serial.c 2007-07-23 08:47:35.0

Re: [linux-usb-devel] [PATCH] Stall control endpoint when file storage class request wValue != 0

2007-07-24 Thread Luis Lloret
From: Luis Lloret <[EMAIL PROTECTED]> This patch makes the File Storage Gadget stall the control endpoint when a MSC class request is made with wValue != 0. This change makes some MSC compliance test warnings dissapear. Signed-off-by: Luis Lloret <[EMAIL PROTECTED]> --- Thanks for the explanati

[linux-usb-devel] Please reactivate your Yahoo! Groups email address

2007-07-24 Thread Yahoo!Groups
Dear Yahoo! Groups member, You belong to one or more email groups provided by Yahoo! Groups (groups.yahoo.com). Recently, messages sent to you from Yahoo! Groups have been returned to us as undeliverable. As a result, we have temporarily turned off message delivery to this email address. If