On Sun, 05 Jun 2005 10:21:16 +0300 Kiril Jovchev wrote:
| randy_dunlap wrote:
| > On Sun, 05 Jun 2005 01:52:33 +0300 Kiril Jovchev wrote:
| >
| > That happens. You aren't the first, but there are files and
| > web pages that warn about these things. Have you read/studied
| > these?
| >
| > D
randy_dunlap wrote:
On Sun, 05 Jun 2005 01:52:33 +0300 Kiril Jovchev wrote:
> That happens. You aren't the first, but there are files and
web pages that warn about these things. Have you read/studied
these?
Documentation/SubmittingPatches
Documentation/CodingStyle
http://www.zip.com.au/~ak
On Sun, 05 Jun 2005 01:52:33 +0300 Kiril Jovchev wrote:
| randy_dunlap wrote:
| > On Sun, 05 Jun 2005 01:20:58 +0300 Kiril Jovchev wrote:
| >
| > |
| > | Lets see did I got it right this time.
| >
| > Much closer this time, but there are 3 new/added lines
| > that still uses spaces instead of t
randy_dunlap wrote:
On Sun, 05 Jun 2005 01:20:58 +0300 Kiril Jovchev wrote:
|
| Lets see did I got it right this time.
Much closer this time, but there are 3 new/added lines
that still uses spaces instead of tabs. Marked below.
This is my first patch. Sorry for the huge amount of e-mails.
On Sun, 05 Jun 2005 01:20:58 +0300 Kiril Jovchev wrote:
|
| Lets see did I got it right this time.
Much closer this time, but there are 3 new/added lines
that still uses spaces instead of tabs. Marked below.
| --- linux-2.6.12-rc5/drivers/usb/media/stv680.c 2005-05-25
06:31:20.
randy_dunlap wrote:
The only problem that I see with it now is that it uses
spaces instead of tabs... so it won't apply cleanly,
since the original source uses tabs. That means that either
you used cut-n-paste to put the patch into email (which usually
destroys tabs) or your email client otherw
On Sun, 05 Jun 2005 00:34:07 +0300 Kiril Jovchev wrote:
| randy_dunlap wrote:
| > On Sat, 4 Jun 2005 10:50:57 +0300 Kiril Jovchev wrote:
| >
| > | On 6/3/05, Greg KH <[EMAIL PROTECTED]> wrote:
| > | > On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote:
| > | >
| > | > Please read Docu
randy_dunlap wrote:
On Sat, 4 Jun 2005 10:50:57 +0300 Kiril Jovchev wrote:
| On 6/3/05, Greg KH <[EMAIL PROTECTED]> wrote:
| > On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote:
| >
| > Please read Documentation/Submitting patches for how to do this
| > properly. Your patch was li
On Sat, 4 Jun 2005 10:50:57 +0300 Kiril Jovchev wrote:
| On 6/3/05, Greg KH <[EMAIL PROTECTED]> wrote:
| > On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote:
| >
| > Please read Documentation/Submitting patches for how to do this
| > properly. Your patch was linewrapped, and you didn
On 6/3/05, Greg KH <[EMAIL PROTECTED]> wrote:
> On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote:
>
> Please read Documentation/Submitting patches for how to do this
> properly. Your patch was linewrapped, and you didn't have a good
Using Gmail to send was not probably a good idea.
On Fri, Jun 03, 2005 at 03:37:01PM +0300, Kiril Jovchev wrote:
> Hi,
>
> I have had small discussion about the patch on LKML with Alexey Dobriyan.
> So I have fixed the issues and sending the fixed patch.
> It is attached and pasted at the end of the e-mail. I am not sure what
> is the better way.
Thanks for the comments Alexey.
The whitespaces came from the diff. I the only switch what I have used it -u.
About the VENDOR_ID and PRODUCT_ID, I have looked at the code of
stv680.c that was in 2.6.11.11 and there the variables were casted.
> @@ -1375,9 +1383,14 @@
> (le16_to_cpu(dev
On Thursday 02 June 2005 19:35, Kiril Jovchev wrote:
> So now I'm sending the patch again for 2.6.11.11 kernel what is latest stable.
You're lucky it applies cleanly against 2.6.12-rc5-whatever. ;-)
There is no need to split the patch into two ones. Next time CC
[EMAIL PROTECTED] Add "-p" to you
13 matches
Mail list logo
