Re: [linux-usb-devel] SanDisk SDDR09

2001-04-05 Thread Robert Baruch
Hi William, If you want to use SmartMedia cards which are 32MB or larger, you probably want to use this latest driver! --Rob /* Driver for SanDisk SDDR-09 SmartMedia reader * * $Id: sddr09.c,v 1.16 2001/03/27 22:37:55 groovyjava Exp $ * * SDDR09 driver v0.1: * * First release * * Curr

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-28 Thread Robert Baruch
> This line looks funny: > > srb->request_bufflen > > Shouldn't it be ??? > > srb->request_bufflen = sizeof(mode_page_01)) > Will, No, that's the way it should be. If the size of the buffer that we're going to put the answer into is less than what we need, then retur

RE: [linux-usb-devel] SanDisk SDDR09

2001-03-28 Thread William Robison
Rob: This line looks funny: srb->request_bufflenrequest_bufflen = sizeof(mode_page_01)) (I just got a chance to look at the message, haven't doen the patch yet...) -Willy ___ [EMAIL PROTECTED] To unsubscribe, use the last form field at:

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-27 Thread Robert Baruch
Matthew Dharm wrote: > Rob -- > > Are you sure this is the right patch file? It doesn't look like it > implements the changes you describe... > > Matt For sure... Unless what's in CVS isn't in kernel 2.4.2. This is a patch against the previous version of what's in CVS. It looks funny when i

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-27 Thread Robert Baruch
And here is the change (relative to the previous patch) to the SDDR09 driver which accepts an ALLOW_MEDIUM_REMOVAL command (and does nothing with it except put out a debug message). It's in CVS, and here is the patch. --Rob --- sddr09.c.orig Tue Mar 27 17:28:34 2001 +++ sddr09.cTue

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-27 Thread Matthew Dharm
Rob -- Are you sure this is the right patch file? It doesn't look like it implements the changes you describe... Matt On Tue, Mar 27, 2001 at 05:07:27PM -0500, Robert Baruch wrote: > I updated the SDDR09 driver to dummy up a response for MODE SENSE code > page 0x3F. I also made sure that size

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-27 Thread Robert Baruch
I updated the SDDR09 driver to dummy up a response for MODE SENSE code page 0x3F. I also made sure that sizeof(mode_page_01) returns the proper size; it does. Changes are in the CVS tree, but here is the patch. --Rob --- sddr09.c.orig Tue Mar 27 17:05:41 2001 +++ sddr09.cTue Mar 27

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-27 Thread Robert Baruch
Right, OK, that explains it. I need to modify the driver to respond to a mode sense on page 0x3F as well as 0x01. The SDDR-09 does not respond to MODE SENSE requests at all, so I need to dummy up the proper response. Clearly I have to do the same with ALLOW MEDIUM REMOVAL. --Rob Matthew Dharm

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-27 Thread Matthew Dharm
Hrm... looks like a bug... srb->cmnd[2] & 0x3F == 0x3F, not 0x01. This is probably a leftover from when sd.c used to request page 1, instead of "all pages" -- I changed this when I discovered devices that didn't implement page 1, causing the write-protect test to fail. Requesting all pages is gu

RE: [linux-usb-devel] SanDisk SDDR09

2001-03-26 Thread William Robison
Hey Rob: More information... Here is a clip of the log with debugging enabled: usb-storage: *** thread sleeping. usb-storage: queuecommand() called usb-storage: *** thread awakened. usb-storage: Command MODE_SENSE (6 bytes) usb-storage: 1a 00 3f 00 08

RE: [linux-usb-devel] SanDisk SDDR09

2001-03-26 Thread root
Het Rob: Ah, I see what you mean... sddr09.c attempts to re-do the MODE SENSE command and return appropriate data without touching the reader... Well, let me rebuild with debug messages on and the MODE SENSE supression disabled and get back to you with more details. When I did the patch the

Re: [linux-usb-devel] SanDisk SDDR09

2001-03-26 Thread Robert Baruch
Hi Willy, I'll probably have to investigate the ALLOW MEDIUM REMOVAL command, but the MODE SENSE command is a little puzzling... Can you provide a kernel log of the command that gets sent to the driver? The driver is supposed to handle one MODE SENSE command, but if there are more it should h

[linux-usb-devel] SanDisk SDDR09

2001-03-24 Thread root
Greetings: I hope this is of interest to Matthew Dharm... Playing with a recently arrived SanDisk SDDR09 (box marking SDDR-09-01). It appears that this device does not want to see "ALLOW MEDIUM REMOVAL" or "MODE SENSE". With these commands delivered to the device, a timeout occurs. A