Re: [linux-usb-devel] USBMon for kernel 2.4.20

2004-06-04 Thread Greg KH
On Fri, Jun 04, 2004 at 07:39:53PM +0200, Harald Welte wrote: > > > But AFAIK it is the only freely available usb sniffer available for > > > Linux, and that's why I'm using it. > > > > Hm, I started to add such a functionality to the usbfs code. Right now > > it logs any usbfs control urbs and b

Re: [linux-usb-devel] USBMon for kernel 2.4.20

2004-06-04 Thread Harald Welte
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, Jun 04, 2004 at 09:54:46AM -0700, Greg KH wrote: > On Fri, Jun 04, 2004 at 06:07:49PM +0200, Harald Welte wrote: > > yes, I dislike it, too. But as I'm not the original author and just > > touched somebody else's code - I don't think I should

Re: [linux-usb-devel] USBMon for kernel 2.4.20

2004-06-04 Thread Greg KH
On Fri, Jun 04, 2004 at 06:07:49PM +0200, Harald Welte wrote: > yes, I dislike it, too. But as I'm not the original author and just > touched somebody else's code - I don't think I should change the overall > CodingStyle if I want that patch to get accepted by Dave Harding. You should fix it if y

Re: [linux-usb-devel] USBMon for kernel 2.4.20

2004-06-04 Thread Harald Welte
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, Jun 04, 2004 at 07:45:48AM -0700, Pete Zaitcev wrote: > On Fri, 4 Jun 2004 16:23:19 +0200 > Harald Welte <[EMAIL PROTECTED]> wrote: > > > + dev = (struct usb_device *)(file->private_data); > > + > > + temp_urb1=dev->USBMon_data->USBMon_

Re: [linux-usb-devel] USBMon for kernel 2.4.20

2004-06-04 Thread Pete Zaitcev
On Fri, 4 Jun 2004 16:23:19 +0200 Harald Welte <[EMAIL PROTECTED]> wrote: > + dev = (struct usb_device *)(file->private_data); > + > + temp_urb1=dev->USBMon_data->USBMon_urb_ll_buffered; > + > + wmb(); > + > + dev->USBMon_data->USBMon_urb_ll_buffered=NULL; You need more sema

[linux-usb-devel] USBMon for kernel 2.4.20

2004-06-04 Thread Harald Welte
Hi Dave (and all linux usb developers) I just ported/merged your USBMon for linux 2.4.4 into the 2.4.20 kernel. You might be interested in making this available to other users, patch is attached. Since I'm currently debugging some issues while developing a USB driver, it is likely that I'll port