On Fri, Jan 10, 2003 at 12:36:15PM +0100, Duncan Sands wrote:
> speedtouch: struct sk_buff_head has a spinlock built in, so no need for our own.
Applied, thanks.
greg k-h
---
This SF.NET email is sponsored by:
SourceForge Enterprise Edition
On Fri, Jan 10, 2003 at 11:26:25PM +0100, Oliver Neukum wrote:
> Hi,
>
> this is the obvious fix. Greg, please apply.
Applied, thanks.
greg k-h
---
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Somethi
On Fri, Jan 10, 2003 at 07:43:59PM +0100, Oliver Neukum wrote:
> Hi,
>
> this is the first one. Basically GFP_ATOMIC in interrupt and proper error
> handling in write. This is the simple stuff to motivate myself.
> Greg, please apply.
Applied, thanks.
> - spin_unlock_irqrestore( &ep-
On Fri, Jan 10, 2003 at 11:44:15PM +0100, Oliver Neukum wrote:
> Hi,
>
> the counter has to decremented if the URB cannot be submitted.
> Greg, please apply.
Applied, thanks.
greg k-h
---
This SF.NET email is sponsored by:
SourceForge Enterpr
On Sat, Jan 11, 2003 at 11:39:55AM +0100, Oliver Neukum wrote:
> Currently there's no way to tell an urb executing its completion handler
> from a finished urb. So we wouldn't have to poll, but could wake the task
> doing the unlink from usb_hcd_giveback_urb(). In fact we'd have to.
Then why don't
On Wed, Jan 08, 2003 at 08:01:00AM -0800, Ty Bekiares wrote:
> I managed to get whiteheat driver working on my
> embedded PPC823E platform. I'm communicating on two of
> the ports on the WhiteHeat board. I can run
> full-duplex 45kbps data through one of the ports for
> about 4 hours before I get t
Am Sonntag, 12. Januar 2003 09:11 schrieb Greg KH:
> On Sat, Jan 11, 2003 at 11:39:55AM +0100, Oliver Neukum wrote:
> > Currently there's no way to tell an urb executing its completion handler
> > from a finished urb. So we wouldn't have to poll, but could wake the task
> > doing the unlink from us
Hello Oliver,
On Sunday 12 January 2003 13:18, Oliver Neukum wrote:
> OK, if we are to do this let's do it right and divorce state from
> error reporting.
> As far as I can tell an URB should have four states, with preliminary
> names:
>
> 1 - URB_FREE
> 2 - URB_SUBMITTED
> 3 - URB_COMPLETING
> 4
Hello,
this is the updated auerswald driver on top of 2.4.20. Does anybody wants to
have a look at it for review? I am very shure I have missed something.
best regards
Wolfgang Mües
auerisdn_12012003.tgz
Description: application/tgz
Am Sonntag, 12. Januar 2003 14:01 schrieb Wolfgang Mües:
> Hello Oliver,
>
> On Sunday 12 January 2003 13:18, Oliver Neukum wrote:
> > OK, if we are to do this let's do it right and divorce state from
> > error reporting.
> > As far as I can tell an URB should have four states, with preliminary
> >
Am Sonntag, 12. Januar 2003 14:58 schrieb Wolfgang Mües:
> Hello,
>
> this is the updated auerswald driver on top of 2.4.20. Does anybody wants
> to have a look at it for review? I am very shure I have missed something.
>
> best regards
> Wolfgang Mües
void auerbuf_free(struct auerbuf *bp)
- simpl
As far as I can tell an URB should have four states, with preliminary names:
1 - URB_FREE
Try "IDLE" or something; if it's freed, it's owned by the
memory management code, and usb would never see it.
2 - URB_SUBMITTED
3 - URB_COMPLETING
4 - URB_CANCELED
If there's a CANCELED state it shou
Hello Oliver,
I know I can count on you ;-) Thank you for reviewing.
On Sunday 12 January 2003 16:47, Oliver Neukum wrote:
> void auerbuf_free(struct auerbuf *bp)
> - simply do kfree. It's officially allowed to pass NULL. There's no need
> to burn cycles
OK. I have changed all occurances. I d
Hi,
there are multiple bugs in current (2.5.56) hiddev.c:
1. hiddev_ioctl(): in the big switch(), several cases simply fall through
to the next case. Obviously, the final return 0 is missing.
2. HIDIOCAPPLICATION: hid->collection[i].usage might be negative. This
causes the ioctl() ti retur
Hi,
is there any particular reason why usb_string() tries to ask for the
length of the string first before actually getting the string? tbuf has a
fixed length of 256 anyways, so this just looks like an unnessessary step
to me.
I have one particular USB device which fails miserably with EOVERFLOW
Am Sonntag, 12. Januar 2003 18:41 schrieb David Brownell:
> > As far as I can tell an URB should have four states, with preliminary
> > names:
> >
> > 1 - URB_FREE
>
> Try "IDLE" or something; if it's freed, it's owned by the
> memory management code, and usb would never see it.
OK.
> > 2 - URB_S
> > int auerchain_unlink_urb(struct auerchain *acp, struct urb *urb)
> > + spin_unlock_irqrestore(&acp->lock, flags);
> > + dbg("unlink waiting urb");
> > + urb->status = -ENOENT;
> > + urb->complete(urb);
> > Please no. Don't
Hello Oliver,
> If you feel you need to emulate functionality the core should have, the
> core should have that functionality. So go hence and expand the core :-)
Ideally, yes. But this is a huge job for my limited understanding of usb core
internals. The auerswald driver has started as a sepera
Oliver Neukum wrote:
Am Sonntag, 12. Januar 2003 18:41 schrieb David Brownell:
If there's a CANCELED state it should just be a sub-state
of SUBMITTED ... one where urb->status isn't -EINPROGRESS,
but is -ECONNRESET (async unlink), -ENOENT (synchronous
unlink) or -ESHUTDOWN (cleanup after host co
This patch makes the debug system only print out the valid bytes of a
command. Greg, please apply.
Andries suggested this... while some would think that seeing the extra
bytes might be good, it is kinda noisy.
Matt
# This is a BitKeeper generated patch for the following project:
# Project Name:
| Hi,
On Sun, 12 Jan 2003, Jochen Friedrich wrote:
| is there any particular reason why usb_string() tries to ask for the
| length of the string first before actually getting the string? tbuf has a
| fixed length of 256 anyways, so this just looks like an unnessessary step
| to me.
|
| I have one
Greg,
These two files needed to be touched after the recent changes to
DRIVER_ATTR/driver_attribute structure members in 2.5.56. Personally,
it doesn't look to me like the size parameter should be removed, as now
users will need to hardcode PAGE_SIZE into their functions, rather than
it being pa
Greetings,
I've been testing a variety of VIA VT8235 based motherboards for the past
few weeks and the VIA USB 2.0 support has been guaranteed to hang every
time when using a USB 2.0 Hard Drive (or any other USB 2.0 device for that
matter). There have been minor improvements, including the fact th
On Sun, Jan 12, 2003 at 06:02:37PM -0800, Matthew Dharm wrote:
> This patch makes the debug system only print out the valid bytes of a
> command. Greg, please apply.
Applied, thanks.
greg k-h
---
This SF.NET email is sponsored by:
SourceForge
24 matches
Mail list logo
