Re: [linux-usb-devel] Update: USB "gadget" API [1 of 3]

2003-02-21 Thread David Brownell
Hi, I'd like to start playing with this, can you send out some patches that I can add to my local tree? Or I guess I can pull them from your bk tree, if you don't mind. I'll circulate patches a bit later, after I merge some updates to make that loopback configuration actually do work. That shows

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 10:04:14PM +0100, Thomas Jarosch wrote: > This is a patch against the ftdi_sio 1.3.0 driver + interim patch. > The new driver should be out soon... Can you post it not compressed so we can read it? thanks, greg k-h ---

Re: [linux-usb-devel] Update: USB "gadget" API [1 of 3]

2003-02-21 Thread Greg KH
On Fri, Feb 07, 2003 at 09:21:16AM -0800, David Brownell wrote: > In late November I posted a draft of a "gadget" API, which would > drive the device-side USB controller hardware as more of those > systems grew smart enough to use Linux inside. This is starting to look good, thanks a lot for doing

Re: [linux-usb-devel] Re: [PATCH] USB changes for 2.5.62

2003-02-21 Thread David Brownell
A per-device list is sufficient, and a lot cheaper to maintain. Doing it per-interface would add work to the submit path that's hardly ever needed ... better to have that work delayed until it's actually needed. Then how to implement usb_reset_device() ? In some straightforward manner. Rememberi

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Thomas Jarosch
> > Ahh, now I see :-) Thanks. > > I didn't know about those special thunking handlers > > needed for 64 bit systems. > > > > Is it sufficient to list the new ioctls > > in the ioctl32_handler_table/ioctl_translations table? > > Depending on the data provided, you might have to write a function too

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-21 Thread Johannes Erdfelt
On Fri, Feb 21, 2003, Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Feb 21, 2003 at 05:53:24PM +0100, Duncan Sands wrote: > > > What's the backtrace from the oops? > > > > usb_free_dev+19/3c > > Hm, wonder if the bus has been cleaned up by the shutdown sequence > first. That might cause this. It

[linux-usb-devel] Discussion of problems in usb-skeleton.c

2003-02-21 Thread Alan Stern
I noticed that usb-skeleton.c still has a TODO entry referring to a race involving urb->status, so I took a closer look. Fixing that race will be easy, and I will be happy to submit a patch for it. But there are two other problems, partially related. Is it worthwhile to try to address them all?

[linux-usb-devel] Re: [PATCH] USB speedtouch: use USB dbg macro

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 10:30:59AM +0100, Duncan Sands wrote: > speedtouch.c | 159 --- > 1 files changed, 77 insertions(+), 82 deletions(-) Thanks a lot for doing this, it makes things more uniform across drivers. Applied. greg k-h ---

[linux-usb-devel] Re: [2.5 bkpatch] ipaq.c: add ids for fujitsu loox

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 11:26:03AM +0530, V Ganesh wrote: > hi greg, > the fujitsu loox works with the ipaq driver. ids added. Applied, thanks. greg k-h --- This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. The most co

Re: [linux-usb-devel] Yet another unusual_devs.h member.

2003-02-21 Thread Greg KH
On Fri, Jan 24, 2003 at 06:13:24PM -0500, Pete Zaitcev wrote: > Matt & Greg, > > would you be so kind to take this: Applied, thanks. greg k-h --- This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. The most comprehensive and fl

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Thomas Jarosch
> > But why is it working anyway even though I haven't modified > > any arch//kernel/ioctl32.c handler, > > just the ftdi_sio ioctl() handler? > > Are you using a ppc64 or sparc64 or ia64 or x86-64 machine with a 64 bit > kernel? If not, then yes, it works just fine on 32 bit kernels. Ahh,

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 05:53:24PM +0100, Duncan Sands wrote: > > What's the backtrace from the oops? > > usb_free_dev+19/3c Hm, wonder if the bus has been cleaned up by the shutdown sequence first. That might cause this. greg k-h --- This S

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-21 Thread Duncan Sands
> What's the backtrace from the oops? usb_free_dev+19/3c The rest has gone to join the great penguin in the sky. > Personally I wouldn't trust the reference counting logic in 2.4, it just > doesn't seem right, but I haven't spent the time in looking too deeply > at it, unlike 2.5. I've decided

Re: [linux-usb-devel] Death by usb_dec_dev_use

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 12:34:13PM +0100, Duncan Sands wrote: > I get an oops on shutdown with 2.4.20 (speedtouch driver). Here is what > happens: > > probe method called: I take a reference to the usb device with usb_inc_dev_use > > (machine shutting down - shutdown of usb subsystem) > > disco

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 03:55:14PM +0100, Thomas Jarosch wrote: > > > > No, those macros don't do it. If you have a strong stomach, look at: > > > > arch/sparc64/kernel/ioctl32.c > > > > for just one of the arch specific files that you will have to modify. > > > > Make sure you get them all, or yo

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Thomas Jarosch
> > > No, those macros don't do it. If you have a strong stomach, look at: > > > arch/sparc64/kernel/ioctl32.c > > > for just one of the arch specific files that you will have to modify. > > > Make sure you get them all, or you will have some angry maintainers to > > > deal with... > > > > But th

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Greg KH
On Fri, Feb 21, 2003 at 09:36:31AM +0100, Thomas Jarosch wrote: > > > > Also, you'll need to make the necessary > > > > 64 bit thunking layer if somehow you convince me :) > > > > > > I thought using the _IO macros should do it > > > or did I miss something? > > > > No, those macros don't do it.

[linux-usb-devel] Death by usb_dec_dev_use

2003-02-21 Thread Duncan Sands
I get an oops on shutdown with 2.4.20 (speedtouch driver). Here is what happens: probe method called: I take a reference to the usb device with usb_inc_dev_use (machine shutting down - shutdown of usb subsystem) disconnect called (still have the reference) ...time passes... final driver shut

[linux-usb-devel] [PATCH] USB speedtouch: use USB dbg macro

2003-02-21 Thread Duncan Sands
speedtouch.c | 159 --- 1 files changed, 77 insertions(+), 82 deletions(-) diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c --- a/drivers/usb/misc/speedtouch.c Fri Feb 21 10:25:44 2003 +++ b/drivers/usb/misc/sp

Re: [linux-usb-devel] usb-serial: Custom ioctl

2003-02-21 Thread Thomas Jarosch
> > > > I found Documentation/ioctl-numbers.txt for new-style ioctls. > > > > Currently I'm using 'N' with a range of 20 to 3F. > > > > Before a final release, I'll check if they're still unused. > > > > > > Heh, good luck, I don't think I'll take a patch adding new ioctls > > > without a _very_ g