[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-05 Thread Ben Collins
On Thu, Jun 05, 2003 at 01:20:15AM -0700, Greg KH wrote: On Tue, Jun 03, 2003 at 07:33:52PM -0400, Ben Collins wrote: Greg, if this doesn't apply to your 2.4.x tree, could you please send me an updated tarball of your tree? Applied, minus the BUG_ON() part. Thanks. Do you still want

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
Hm, I just tested this on a keyboard here, and can duplicate it. Ben, it looks like your patch broke something for USB keyboards, any idea? Damn. Surprised I never noticed this. Confirmed even with my 2.4 patches. Give me an hour or so and I'll get you a fix. -- Debian -

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
Hm, I just tested this on a keyboard here, and can duplicate it. Ben, it looks like your patch broke something for USB keyboards, any idea? No idea. I'm using a USB keyboard in conjunction with the patch. Let me try a 2.5.70+bk build tonight to make sure there were no bad interactions

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
Hm, I just tested this on a keyboard here, and can duplicate it. Ben, it looks like your patch broke something for USB keyboards, any idea? My patch alone on 2.4.21-rc4-i386 has working LED's. My patch in your tree that you sent me with 2.4.21-rc6-sparc64 has broken LED's. Veeery

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
On Tue, Jun 03, 2003 at 06:18:13PM -0500, Jordan Breeding wrote: Ben Collins wrote: Hm, I just tested this on a keyboard here, and can duplicate it. Ben, it looks like your patch broke something for USB keyboards, any idea? My patch alone on 2.4.21-rc4-i386 has working LED's. My

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
I've narrowed this down. I'll have a patch shortly. -- Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ Deqo - http://www.deqo.com/ --- This SF.net email is sponsored

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
Ben, it looks like your patch broke something for USB keyboards, any idea? Yep, my patch killed hid-input from scanning HID_OUTPUT_REPORT's. Fixed with this patch for 2.5.70+bk. I'll send one for 2.4.x in a few minutes. --- linux/drivers/usb/input/hid-input.c 3 Jun 2003 02:53:07 -

[linux-usb-devel] Re: [BK PATCH] More USB changes for 2.5.70

2003-06-04 Thread Ben Collins
Greg, if this doesn't apply to your 2.4.x tree, could you please send me an updated tarball of your tree? --- linux/drivers/usb.new/hid-input.c Thu May 22 22:47:00 2003 +++ linux/drivers/usb/hid-input.c Tue Jun 3 20:35:46 2003 @@ -73,8 +73,11 @@ hidinput =

[linux-usb-devel] [PATCH 2.6.15/2.6.16-git] Fix off-by-one for num_values in uref_multi requests

2006-01-30 Thread Ben Collins
Found this when working with a HAPP UGCI device. It has a usage with 7 indexes. I could read them all one at a time, but using a multiref it would only allow me to read the first 6. The patch below fixed it. Signed-off-by: Ben Collins [EMAIL PROTECTED] --- a/drivers/usb/input/hiddev.c +++ b

[linux-usb-devel] [PATCH] Remove duplicate IDs from option card driver

2007-05-16 Thread Ben Collins
Cc: Matthias Urlichs [EMAIL PROTECTED] Cc: linux-usb-devel@lists.sourceforge.net Signed-off-by: Ben Collins [EMAIL PROTECTED] diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 8c3f55b..89f067d 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c

[linux-usb-devel] [PATCH] Remove duplicate ID in ipaq driver

2007-05-16 Thread Ben Collins
Cc: Ganesh Varadarajan [EMAIL PROTECTED] Cc: linux-usb-devel@lists.sourceforge.net Signed-off-by: Ben Collins [EMAIL PROTECTED] diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c index 4df0ec7..7c85be4 100644 --- a/drivers/usb/serial/ipaq.c +++ b/drivers/usb/serial/ipaq.c

Re: [linux-usb-devel] [PATCH] Remove duplicate ID in ipaq driver

2007-05-16 Thread Ben Collins
On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote: /* The first entry is a placeholder for the insmod-specified device */ - { USB_DEVICE(0x049F, 0x0003) }, Is it obvious why this patch is correct? Especially given the comment just before the line you delete, and the code

Re: [linux-usb-devel] [PATCH] Remove duplicate ID in ipaq driver

2007-05-17 Thread Ben Collins
On Thu, 2007-05-17 at 05:43 -0700, Greg KH wrote: On Wed, May 16, 2007 at 05:36:48PM -0400, Ben Collins wrote: On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote: /* The first entry is a placeholder for the insmod-specified device */ - { USB_DEVICE(0x049F, 0x0003

Re: [linux-usb-devel] [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-23 Thread Ben Collins
On Wed, 2007-05-23 at 20:59 -0700, Phil Dibowitz wrote: Ben Collins wrote: Various unusual dev entries accumulated from Ubuntu bug reports. CC: Phil Dibowitz [EMAIL PROTECTED] NACK. Two fixes I'd like to see fixed. +/* SanDisk that has a second LUN for a driver ISO, reported

Re: [linux-usb-devel] [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-24 Thread Ben Collins
On Wed, 2007-05-23 at 21:17 -0700, Phil Dibowitz wrote: Note, I've taken LKML off the CC list anyone interested in this on there is also on linux-usb-devel. I've also added the usb-storage list. See rest of response below. Ben Collins wrote: +/* SanDisk that has a second LUN for a driver

Re: [linux-usb-devel] [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-25 Thread Ben Collins
On Thu, 2007-05-24 at 22:38 -0700, Phil Dibowitz wrote: Ben Collins wrote: I don't like to merge these because it means some other user of some new device can get unintended consequences - but if we don't have access to the data, it's better than nothing. Were you the person who owned