provide any more information or test any patches then please let me know.
Please CC me as I'm not on the list.
Thanks.
--
Daniel Drake (dsd)
http://www.reactivated.net
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http
, usblp-ifnum);
for (p = USBLP_FIRST_PROTOCOL; p = USBLP_LAST_PROTOCOL; p++) {
--
Please CC me as I'm not on the list
--
Daniel Drake (dsd)
http://www.reactivated.net
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven
)
--
Daniel Drake (dsd)
http://www.reactivated.net
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
[EMAIL PROTECTED]
To unsubscribe, use the last form field
CONFIG_USB_DEBUG
+ #define DEBUG
+#else
+ #undef DEBUG
+#endif
+
#include linux/usb.h
#include linux/netdevice.h
--
Daniel Drake (dsd)
http://www.reactivated.net
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek
, usblp-dev);
dbg(present=%d, usblp-present);
- dbg(buf=0x%p, usblp-buf);
+ dbg(buf=0x%p, usblp-readbuf);
dbg(readcount=%d, usblp-readcount);
dbg(ifnum=%d, usblp-ifnum);
for (p = USBLP_FIRST_PROTOCOL; p = USBLP_LAST_PROTOCOL; p++) {
--
Daniel Drake (dsd)
http
-mutex);
--
Daniel Drake (dsd)
http://www.reactivated.net
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
[EMAIL PROTECTED]
To unsubscribe, use the last
kernels.
This patch fixes this.
I had to comment out one line of debug code that I was unable to fix.
Thanks.
--
Daniel Drake (dsd)
http://www.reactivated.net
--- linux-2.6.0-test5/drivers/usb/media/dabusb.c2003-09-09 08:50:01.0
+0100
+++ linux/drivers/usb/media/dabusb.c2003-09-16 21
.
This patch fixes this.
Thanks.
--
Daniel Drake (dsd)
http://www.reactivated.net
--- linux-2.6.0-test5/drivers/usb/media/vicam.c 2003-09-09 08:50:01.0 +0100
+++ linux/drivers/usb/media/vicam.c 2003-09-16 21:44:57.169118912 +0100
@@ -1292,7 +1292,7 @@
interface = intf-altsetting
between 2.4 and 2.6 have changed
quite a bit.
Would the pointer to the next urb be helpful for debugging?
Deleting the line is fine by me, I just left it in there incase somebody wanted to correct it.
Try this patch.
Thanks.
--
Daniel Drake (dsd)
http://www.reactivated.net
Greg KH wrote:
On Tue, Sep
under Documentation/DocBook.
Might also be worth looking at the files in Documentation/usb, but I suspect some of the information there is out of date.
Sorry I can't help you any more, but I don't yet have the knowledge myself.
--
Daniel Drake (dsd)
http://www.reactivated.net
zhihua Li wrote:
Hi,
I
When compiling this driver with WRITE_DEBUG defined (for extra debug output),
gcc outputs warnings for three similar printf statements.
The specifier in each printf statement is not totally correct.
This patch removes these warnings.
Patch attached and also available at
When compiling this driver with WRITE_DEBUG defined (for extra debug output),
gcc outputs warnings for three similar printf statements.
The specifier in each printf statement is not totally correct.
This patch removes these warnings.
Patch attached and also available at
Are you sure this is a kernel bug?
I wasn't aware of any kernel support for this device, and a grep for nike
doesnt return anything in the way of MP3 player support.
These things are most commonly controlled in userspace. For example, my
current MP3 player is controlled by an app named rioutil
on each iteration.
Could somebody test this please? I don't own a jumpshot.
(Although unlikely, it may well be that a normal data transfer requires 10
iterations of that loop, we don't want to bail out too early...)
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux-2.6.9-gentoo-r1/drivers/usb
Hi,
Alan Stern wrote:
On Mon, 20 Dec 2004, Sara Fonseca wrote:
How does the pen drive tells the scsi that it
is empty? ( maybe answering the read command with a sense data BLANK
CHECK?
If you have to respond with a failure, you can use Sense Key = 0x03
(Medium error) with ASC = 0x12 or 0x13
Alan Stern wrote:
This sounds different from what Sara was asking (unless I misunderstood
the question, which is entirely possible). You're asking about what
should be done when there's no media present, not when the media is
present but uninitialized. The answer is simple: report a Medium
Hi Alan/Robert,
I've been working on extending your shuttle_usbat driver to support
flash-based storage devices connected via the USBAT02 chip. I've got working
code here and am nearly ready to submit this for inclusion, but there is one
last problem that I'm trying to address.
The
Alan Stern wrote:
This isn't clear to me. The chip supports multiple protocols on the
device side, and you're assuming that a particular protocol (one
appropriate for flash devices) is the correct one? Whereas the
shuttle_usbat driver assumes ATAPI is correct? Doesn't the USBAT02 chip
Something I wrote in my last mail gave me an idea..
Daniel Drake wrote:
In this case, both the hp8200 and the flash devices use the ATA access
almost entirely (the hp8200 writes to some ISA registers during the init
function, not really sure why..).
The hp8200e init function does this:
730
Alan Stern wrote:
Well, the IDENTIFY PACKET DEVICE command looks relevant. Beyond that, you
need to rely on appropriate packet commands. INQUIRY is implemented as a
packet command; it might be the one you need.
Interesting.. After executing IDENTIFY PACKET DEVICE (0xA1), the flash-usbat02
Alan Stern wrote:
Now you're confusing me. I thought these chips provided a USB-ATA
interface. Here you're talking about ISA registers. But ISA is a
motherboard architecture; it includes a lot more than just ATA. Does this
mean that the chips essentially provide an entire motherboard at the
This Ours Technology device incorrectly reports 100% residue on transferred
data.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux-2.6.10-ck2/drivers/usb/storage/unusual_devs.h.orig 2005-01-07 14:31:02.277027320 +
+++ linux-2.6.10-ck2/drivers/usb/storage/unusual_devs.h 2005-01-07 14
Phil Dibowitz wrote:
Refreshed against my tree, and replacing USB with Ours Technology to
be a bit more clear, I get the following.
I was just following the entry below my addition (looks like a similar disk
with similar problem), which also says just USB. Plus, the device descriptor
Hi Phil,
Phil Dibowitz wrote:
However, before decreeing this device needy of the RESIDUE flag, I'd
like to see the output of usb-storage with verbose debugging mode on.
Can you turn that on and send the output of dmesg?
I wouldn't surprise me if this device needs that, as I just added this
Adds long overdue support for 12 CompactFlash card reader/writers based on the
USBAT02 chip!
See http://usbat2.sourceforge.net
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
diff -urNpX dontdiff linux-2.6.10/drivers/usb/storage/Kconfig linux-dsd/drivers/usb/storage/Kconfig
--- linux-2.6.10
Misc cleanups, a few more annotations, some function name/usage
generalisation, and preparation for addition of support for flash-reader devices.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
diff -urNpX dontdiff linux-2.6.10/drivers/usb/storage/Kconfig linux-dsd/drivers/usb/storage/Kconfig
Adds support for USBAT02-based devices. A few HP cd writers came out with this
chip.
A lot of flash-readers also share these ID numbers: this will be addressed in
the next patch.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
diff -urNpX dontdiff linux-2.6.10/drivers/usb/storage/Kconfig linux
The signature of the Aldi Traveler DC-4300 camera has one bit set incorrectly
and currently don't work at all with Linux.
This patch makes it work :)
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux-2.6.11-rc2/drivers/usb/storage/transport.c.orig 2005-01-29 22:21:17.761827352 +
Alan Stern wrote:
+/* This is for the Aldi Traveler DC-4300 cameras */
+#define US_BULK_CS_ALDI_SIGN 0x43425355 /* Spells out 'USBR' */
It actually spells out 'USBC'.
Hmm, yes, you are right.
I'm beginning to wonder about all these tests for valid signatures. Note
that the code always
Andrew Morton wrote:
Did someone break usb input?
Begin forwarded message:
Date: Sun, 30 Jan 2005 15:45:04 -0500
From: Paul Blazejowski [EMAIL PROTECTED]
To: Andrew Morton [EMAIL PROTECTED]
Cc: LKML linux-kernel@vger.kernel.org
Subject: Re: 2.6.11-rc2-mm2
Here's another one, my USB keyboard is not
the
error-checking capabilities of the signature transfer, while becoming
compatible with (yet more) non-standard devices.
Suggestion from Alan Stern.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux/drivers/usb/storage/transport.c.orig 2005-02-01 16:39:39.527908368 +
+++ linux/drivers/usb
Hi,
If CONFIG_FW_LOADER is not set, the speedtouch driver causes kernel
compilation/linking to fail:
LD .tmp_vmlinux1
drivers/built-in.o(.text+0xcb9b7): In function `speedtch_find_firmware':
: undefined reference to `request_firmware'
drivers/built-in.o(.text+0xcba30): In function
Duncan Sands wrote:
in particular USE_FW_LOADER is used to avoid compiling
speedtch_find_firmware and speedtch_load_firmware, so the errors you're
seeing means that USE_FW_LOADER is defined. It is defined as follows:
Ah, sorry, I overlooked this. It works when CONFIG_FW_LOADER is set to y or n
Hi,
This adds support for the Zire 31 devices to the visor driver. This ID is
already present in Linux 2.6
See:
http://home.t-online.de/home/hburde/linux_zire.html
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux-2.4.30-rc4/drivers/usb/serial/visor.c.orig 2005-04-01 13:36:58.0
Hi,
Matthew Dharm wrote:
This patch is required to fix up the jumpshot driver, and to supress
the 'unneeded entry' message for another device which uses the same
VID/PID/rev for multiple different versions of the device.
= drivers/usb/storage/jumpshot.c 1.34 vs edited =
---
Hi,
I've seen a few reports floating around lately that the sda1 node isn't
getting created on plugin of some usb-storage devices.
In these situations, the sda node appears on plugin, but no partitons (e.g.
sda1) turn up until you do *something* with the sda node.
Even if its as simple as:
Hi,
Alan Stern wrote:
From things I've seen in the past, I'll guess that the device reports No
medium present until it finishes initializing, which might require a few
seconds. Since the usb-storage and other drivers try probing the device
right away, they are forced to assume that there are
Hi,
I'm writing a new usb-storage subdriver to support card readers based on the
Alauda chip.
I've sniffed some data and I am building up an idea of how the thing works. I
have attempted to put pen to paper but I am having trouble sending anything on
the control pipe.
When I plug it in, I
Alan Stern wrote:
Your control message has requesttype set to 0, but the sniffer log shows
it set to 0xc0. That could easily cause a stall. Especially since your 0
value indicates that this is a control-out transfer instead of control-in.
Oops! Thanks for pointing out my silly mistake :)
It
Adding flash-device support to the shuttle_usbat driver in 2.6.11 introduced
the need to detect which type of device we are dealing with: CDRW drive, or
flash media reader.
The detection routine used turned out to not work for HP8200 CDRW users, who
saw their devices being detected as a flash
disk.
This patch (which has been tested on both flash and cdrom) removes some
unnecessary code, moves device detection to much later during
initialization, and introduces a new detection routine which appears to
work.
If acceptable, please include in 2.6.13.
Signed-off-by: Daniel Drake
.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux/drivers/usb/storage/unusual_devs.h.orig 2005-08-31 11:18:10.0 +0100
+++ linux/drivers/usb/storage/unusual_devs.h 2005-08-31 11:47:09.0 +0100
@@ -96,6 +96,13 @@ UNUSUAL_DEV( 0x0436, 0x0005, 0x0100, 0x
US_SC_SCSI
with no problems.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux/drivers/usb/storage/unusual_devs.h.orig 2005-08-31 11:18:10.0 +0100
+++ linux/drivers/usb/storage/unusual_devs.h 2005-08-31 16:36:42.0 +0100
@@ -96,6 +96,14 @@ UNUSUAL_DEV( 0x0436, 0x0005, 0x0100, 0x
US_SC_SCSI
Hi,
I am developing a usb-storage subdriver for a non-standard device which has a
SmartMedia port and an XD media port.
I'm at the stage where I'd like the driver to support both ports
simultaneously, i.e. creating /dev/sda and /dev/sdb, one for each port.
How can I instruct my driver to
Matthew Dharm wrote:
If you set max_lun to 1 and compile with SCSI_MULTI_LUN, are you seeing the
SCSI scan for multiple LUNs?
What your subdriver needs to do is to decode the lun field of the SRB to
decide how to handle the device. As long as SCSI sees responses to INQUIRY
commands with lun=0
recently.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux-2.6.14-rc1/drivers/usb/storage/shuttle_usbat.c 2005-09-13 13:53:17.0 +0100
+++ linux-2.6.14-rc2/drivers/usb/storage/shuttle_usbat.c 2005-09-28 23:30:48.0 +0100
@@ -855,15 +855,15 @@ static int usbat_identify_device
at
transport-selection time, but a sweep of all uses to be consistent
would be in order).
Sorry for the long delay, here is a patch to address this. I also clarified
some ATA/ATAPI wording + function names.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
diff -urNpX dontdiff linux
:
http://linux.bkbits.net:8080/linux-2.6/anno/drivers/usb/storage/[EMAIL
PROTECTED]
http://linux.bkbits.net:8080/linux-2.6/anno/drivers/usb/storage/[EMAIL
PROTECTED]
Phil, please confirm I'm not going crazy :)
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux/drivers/usb/storage
the sddr09 driver which also has to deal with low-level physical block
layout on SmartMedia.
Matt, please review and forward onto Greg if acceptable.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
diff -urNpX dontdiff linux/drivers/usb/storage/alauda.c linux/drivers/usb/storage/alauda.c
--- linux
Hi,
Andrew Morton wrote:
Running 2.6.7-rc2-mm2, I connected up the Sony digital camera.
dmesg says:
From two days ago:
usb 4-2: new full speed USB device using address 2
Initializing USB Mass Storage driver...
scsi2 : SCSI emulation for USB Mass Storage devices
Vendor: Sony Model: Sony DSC
Hi,
Andrew Morton wrote:
Running 2.6.7-rc2-mm2, I connected up the Sony digital camera.
dmesg says:
From two days ago:
usb 4-2: new full speed USB device using address 2
Initializing USB Mass Storage driver...
scsi2 : SCSI emulation for USB Mass Storage devices
Vendor: Sony Model: Sony DSC
Hi,
Matthias Urlichs wrote:
what's supposed to be the replacement for drivers/usb/image/scanner.c?
xsane is supposed to be the replacement. I think I read that scanner.c was
mostly broken in 2.6?
Anyway, this thread (recent, from LKML) has some tips:
Hi,
David Findlay wrote:
Is there a free tool that can take USB logs from windows and replay them at a
slower rate on linux so that you can find out which commands to a device do
what? Thanks,
Take a look at usb-robot:
http://usb-robot.sourceforge.net/
Daniel
Hi,
Chris Carter wrote:
I have tried both kernels 2.4.25 and 2.6.5 and got the same results; and
reaching the end of my tether. I am trying to get a 2.0 Hi-speed
harddisk detected but it fails (regardless of what I do). The usb-disk
is detected properly under Windows (so it is not a hardware
Hi,
Chris Carter wrote:
Thanks for your response. EHCI is loaded automatically by hotplug.
If you enable module unloading, you will be able to use rmmod to unload the
module before you plug a device in. The perhaps more sensible option would be
to remove EHCI support from your kernel.
Daniel
Hi,
Meinhard E. Mayer wrote:
Hope this reaches the right group!
I noticed that in kernels 2.6.3 and 2.6.4 the usb-scanner driver which
was present in 2.6.1 has disappeared and thus my Epson 1260 scanner
(which worked fine until 2.6.1) stopped working.
The scanner driver has been removed from the
if acceptable.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
diff -urNpX dontdiff linux/drivers/usb/storage/alauda.c linux/drivers/usb/storage/alauda.c
--- linux/drivers/usb/storage/alauda.c 1970-01-01 01:00:00.0 +0100
+++ linux/drivers/usb/storage/alauda.c 2005-10-01 16:48:25.0 +0100
Matthew Dharm wrote:
A couple of comments:
1) We'll need to move this to Sim-SCSI framework, when that's merged.
Yep, I'll be happy to do that providing all functionality can be kept.
2) Why use short_pack? Why not cpu_to_le16 instead?
short_pack is meant to simplify the or/shift
the variable on each iteration.
Could somebody test this please? I don't own a jumpshot.
(Although unlikely, it may well be that a normal data transfer requires 10
iterations of that loop, we don't want to bail out too early...)
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux-2.6.9-gentoo-r1
Hi Peter,
Peter Favrholdt wrote:
I have a Kodak USB Picture Card Reader (the uppermost device on this
picture: http://usbat2.sourceforge.net/devices.jpg )
It used to work using 2.6.12 but doesn't work using 2.6.14rc5. In
2.6.14rc5 dmesg reports the Kodak flash reader gets detected as an
Hi,
I'm attempting to get started on a new driver for a fingerprint sensor.
I've sniffed some data but there are a few things in the logs which are
confusing.
The descriptor of the interface I'm working with:
Interface Descriptor:
bLength 9
bDescriptorType
Alan Stern wrote:
I do know that for some strange reason UsbSnoop insists on dumping the
contents of the transfer buffer in both the down and up reports -- in
spite of the fact that the down values are unimportant for IN transfers
and the up values are unimportant for OUT transfers.
This
Peter Favrholdt reported that his Kodak flash device was getting detected as a
CDROM, and he helped me track this down to the fact that the device takes a
long time (approx 440ms!) to reset.
This patch increases the delay to 500ms, which solves the problem.
Signed-off-by: Daniel Drake [EMAIL
Alan Stern wrote:
But the data shown by usbmon is different from the data shown by UsbSnoop!
The Linux data indicates the presence of 3 interfaces whereas the Windows
data indicates just 1. Maybe Windows has filtered the data for you.
Under UsbSnoop I get 4 possible options for what I log-
gerard klaver wrote:
Did you set the configuration, interface and altsetting before the bulk
read command?
Not explicitly, but my driver probe routine checks the interface so this
should be already binded. I based my driver on the structure of others, so I
don't think this is required.
Hi,
I have a MS keyboard which is USB-only and has 3 interfaces:
1. Normal keyboard
2. Extra keys (there are many - volume controls, favourite buttons,
application buttons, ...)
3. Fingerprint reader
I'm trying to get the 2nd interface going with Linux.
It's HID descriptor is:
Daniel Drake wrote:
The lsusb -v output is attached.
Missed it. Here it is.
Bus 002 Device 002: ID 045e:00bb Microsoft Corp.
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level
Alan Stern wrote:
I didn't go through the details of the firmware transfer, but everything
else looked correct. It's not obvious why the device doesn't respond to
your program.
I just found the problem.
I upgraded to amd64 and my driver didn't work at all. Kernel panic
(PCI-DMA: high
the problem and suggesting the solution.
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
--- linux-2.6.15-rc6/drivers/usb/input/hid-core.c.orig 2005-12-29 20:27:32.0 +
+++ linux-2.6.15-rc6/drivers/usb/input/hid-core.c 2005-12-29 20:28:07.0 +
@@ -930,6 +930,7 @@ static void
David Brownell wrote:
However, it's also confusing that the bug doesn't match the downstream
bug that allegedly corresponds to this. In particular, this report
claims the issue appears with 2.6.14-rc4, and the downstream bug
describes older kernels _without_ a patch that addresses a similar
bug
Greg KH wrote:
On Tue, Mar 14, 2006 at 02:25:39PM +1100, Peter Chubb wrote:
Hi Greg,
The changes to the usb/storage/shuttle_usbat.c to accomodate
flash drives appears to have broken CD R/W support.
Sorry it took me so long to report this; I don't use this particular
device very often.
Peter Chubb wrote:
Patch appended.
Thats very intrusive. Please try a more simplistic approach, and send
new logs if it is still detected as a disk :)
Daniel
--- linux/drivers/usb/storage/shuttle_usbat.c.orig 2006-03-14
23:36:57.0 +
+++
Daniel Drake wrote:
--- linux/drivers/usb/storage/shuttle_usbat.c.orig 2006-03-14
23:36:57.0 +
+++ linux/drivers/usb/storage/shuttle_usbat.c 2006-03-14 23:37:18.0
+
@@ -855,6 +855,9 @@ static int usbat_identify_device(struct
return rc;
msleep(500
Peter Chubb wrote:
I figured if we already knew that the device was a disk or flash from
the USB signature, why bother probing?
Sorry, I read over your patch too quickly. It would be nice if it was
that simple. Unfortunately, some of the flash devices are based on the
USBAT chip, and some HP
Peter Chubb wrote:
This patch uses the USB IDs to determine whether to treat an attached
shuttle usbat adapter as connected to a CDROM or a flash device.
unusual_devs.h already has the code to match the exact device that's
attached; use it instead of probing. The patch is bigger than it
might
Peter Chubb wrote:
I don't understand. Are you saying that when a USB device identifies
itself with VendorID 0x3f0 it's sometimes not from HP?
Oh, I didn't realise that these were HP ID's. The original USBAT-based
flash devices must have the same ID as the USBAT2 then. I can't find the
Peter Chubb wrote:
Daniel == Daniel Drake [EMAIL PROTECTED] writes:
Daniel I'd accept a patch to hardcode the detection of HP8200 for the
Daniel HP-id's, but leave the probe in place for the shared ID.
So here is the patch.
Use USB vendor and product IDs to determine whether the attached
Hi Matthieu,
A Gentoo user has reported that the ueagle-driver goes a bit crazy when
no firmware is found - it continually reboots the device and brings the
whole system to a crawl (system is unusable).
Would you mind testing this situation and seeing if you see the same
behaviour?
The
Hi,
Several Gentoo users are reporting that usb-storage devices no longer
work on 2.6.16 with unpowered hubs.
Here's some logs:
hub 2-2:1.0: state 7 ports 3 chg evt 0002
hub 2-2:1.0: port 1, status 0101, change 0001, 12 Mb/s
hub 2-2:1.0: debounce: port 1: total 100ms stable 100ms status
Alan Stern wrote:
The idea is that the kernel now keeps track of USB power budgets. When a
bus-powered device requires more current than its upstream hub is capable
of providing, the kernel will not configure it.
Thanks for the explanation. I wrote a quick patch to make the reasoning
Andrew Morton wrote:
(added linux-usb cc)
Yes, it sounds like we're being non-real-worldly here. This change
apparently broke things. Did it actually fix anything as well?
Gentoo recieved several reports of this. It appears that certain vendors
are worse than others (Verbatim flash drives
). We will work towards supporting more advanced features in the
future (ad-hoc, master mode, 802.11a, ...).
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https
Rami Rosen wrote:
It is mentioned there that these definitions are taken from the ZYDAS
driver and not all of them are relevant for the rewrite driver;
however, it seems to me that
removing them may be thought of.
They are mostly relevant, not all come from the vendor driver directly,
some
Oliver Neukum wrote:
+static int read_mac_addr(struct zd_chip *chip, u8 *mac_addr)
+{
+ static const zd_addr_t addr[2] = { CR_MAC_ADDR_P1, CR_MAC_ADDR_P2 };
+ return _read_mac_addr(chip, mac_addr, (const zd_addr_t *)addr);
+}
Why on the stack?
Technically it's not on the stack
John Que wrote:
I had noticed that the zd1211 driver does call request_irq() in
zd1205_open(),
file zd1205.c;
Look at it in context:
#ifndef HOST_IF_USB
if ((rc = request_irq(dev-irq, zd1205_intr, SA_SHIRQ, dev-name,
dev)) != 0) {
printk(KERN_ERR zd1205:
netif_tx_disable() is what is needed, which
guarantees that no transmissions are active when it returns.
Do you agree that this is a potential race?
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
Index: linux/drivers/usb/net/usbnet.c
David Brownell wrote:
Hmm, most drivers call netif_stop_queue() rather than netif_tx_disable();
a quick conversation with Mr. Grep shows only three uses of the latter.
And with no documentation, it's a bit hard for me to agree (without diving
deeper into the network stack than I have time
Ulrich Kunitz wrote:
Not so fast, because I don't know what to fix.
I am working on it. A couple more mails to Herbert Xu should clarify it,
then I'll post a patch. On first glance I was quite worried that there
are a lot of potential races, but now I think there will only be a few
places.
Oliver Neukum wrote:
+static void disconnect(struct usb_interface *intf)
+{
This is racy. It allows io to disconnected devices. You must take the
lock and set a flag that you test after you've taken the lock elsewhere.
It's been a bit of an adventure, but I'm now fairly confident that only
David Brownell wrote:
So to summarize all that discussion ... no disconnect race in usbnet.
Right?
Yep, unregister_netdev ensures that the case I suggested does not happen.
Daniel
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the
Hi Alan,
A Gentoo bug report has revealed the existence of devices with a
MaxPower value of greater than 500mA. If my understanding is correct,
these devices will always be rejected by the new configuration choosing
code.
The bug report is here:
http://bugs.gentoo.org/137208
How should we
Hi Pete,
I'm diagnosing a mainline driver vs vendor driver issue, and it would be
immensely useful if I could use usbmon to sniff the whole transfer
rather than just the first section. Is this possible?
I'd appreciate any hints for how to increase or remove the limit. I
understand there are
Alan Stern wrote:
Wouldn't it be easy enough to write a user program to send the necessary
command URB via usbfs?
Well, not really. This device does a bad job at emulating a CDROM and I
haven't yet found a way to keep it attached to the system in stable fashion.
When you plug the device in,
Matthew Dharm wrote:
I think that is a better approach than your patch. Perhaps the zd1211rw
driver could know the VID/PID of the fake CD-ROM to attach to it and send
the fake eject command. The usb-storage (and probably ub) would just have
to ignore the device.
Ok, I've handled the zd1211rw
Alan Stern wrote:
In general the idea looks okay to me, but I would change the details in
storage/usb.c. Check for US_FL_IGNORE_DEVICE in the get_device_info()
routine, and make that routine return int instead of void. If the flag is
present you can simply return -ENODEV. Then in
Pete Zaitcev wrote:
Hi, Dmitry:
When we pushed a 2.6.17 rebase for Fedora, one of my users complained that
the wheel on this Wacom reversed the direction. Do you know anything
about it? The patch has some suspicious parts:
It may be unrelated, but there was a similar Gentoo bug recently:
Alan Stern wrote:
I have an usb HP cd-writer plus 8200. It is not working properly with
usb-storage (linux 2.6.17.1 righ now, but does'nt work with eny 2.6 kernel,
udev 0.97), and is identified by the system as a hard disk (sda) insted of a
removable cd device (sr0).
This is fixed in
Martin Williges wrote:
--- usblp.c.orig2006-11-29 22:57:37.0 +0100
+++ usblp.c 2006-12-22 12:08:00.0 +0100
@@ -217,6 +217,7 @@ static const struct quirk_printer_struct
Your mailer has mangled tabs into whitespace. Also, your patch needs to
be applicable with -p1
=3040
Based on a patch from sergiom
Signed-off-by: Daniel Drake [EMAIL PROTECTED]
Index: linux/sound/usb/usbquirks.h
===
--- linux.orig/sound/usb/usbquirks.h
+++ linux/sound/usb/usbquirks.h
@@ -40,6 +40,21 @@
.bInterfaceClass
From: Matthew Davidson [EMAIL PROTECTED]
The Sitecom WL-117 is another driverless ZD1211 device where the virtual
windows driver CD must be ejected before the WLAN device appears.
zd1211rw takes care of the ejecting, but usb-storage must be told not to claim
the device.
Signed-off-by: Daniel
1 - 100 of 102 matches
Mail list logo
