[linux-usb-devel] [2.6 patch] usbat_check_status(): fix check-after-use

2007-07-30 Thread Adrian Bunk
The Coverity checker spotted that we have already oops'ed if us was NULL. Since us can't be NULL in the only caller this patch removes the NULL check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.23-rc1-mm1/drivers/usb/storage/shuttle_usbat.c.old 2007-07-30 16:56

[linux-usb-devel] [-mm patch] USB: make dev_attr_authorized_default static

2007-07-29 Thread Adrian Bunk
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote: ... Changes since 2.6.22-rc6-mm1: ... +gregkh-usb-usb-add-the-concept-of-default-authorization-to-usb-hosts.patch ... USB tree updates ... dev_attr_authorized_default can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[linux-usb-devel] [2.6 patch] drivers/usb/serial/sierra.c: make 3 functions static

2007-07-29 Thread Adrian Bunk
This patch makes three needlessly global functions static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/usb/serial/sierra.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1/drivers/usb/serial/sierra.c.old2007-07-26 21:52

Re: [linux-usb-devel] [PATCH] usb/atm: fix Kconfig garbage

2007-07-23 Thread Adrian Bunk
On Mon, Jul 23, 2007 at 08:56:04AM +0200, Borislav Petkov wrote: Hi there, I don't know whether this is the proper Kconfig-way to fix this but it works ok here. When entered, the menu point USB DSL modem support in menuconfig, path [Device Drivers-USB Support] shows no entries

[linux-usb-devel] usb_serial_suspend(): buggy(?) code

2007-07-22 Thread Adrian Bunk
Commit ec22559e0b7a05283a3413bda5d177e42c950e23 added the following function to drivers/usb/serial/usb-serial.c: -- snip -- ... int usb_serial_suspend(struct usb_interface *intf, pm_message_t message) { struct usb_serial *serial = usb_get_intfdata(intf); struct usb_serial_port

[linux-usb-devel] [1/3] 2.6.21-rc7: known regressions (v2)

2007-04-26 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

Re: [linux-usb-devel] [1/3] 2.6.21-rc7: known regressions (v2)

2007-04-24 Thread Adrian Bunk
On Tue, Apr 24, 2007 at 05:14:28PM -0700, Greg KH wrote: On Tue, Apr 24, 2007 at 11:32:53AM +0200, Wolfgang Erig wrote: On Mon, Apr 23, 2007 at 03:18:19PM -0700, Greg KH wrote: On Mon, Apr 23, 2007 at 11:48:47PM +0200, Adrian Bunk wrote: This email lists some known regressions in Linus

Re: [linux-usb-devel] [1/3] 2.6.21-rc7: known regressions (v2)

2007-04-24 Thread Adrian Bunk
On Tue, Apr 24, 2007 at 05:51:11PM -0700, Greg KH wrote: On Wed, Apr 25, 2007 at 02:29:58AM +0200, Adrian Bunk wrote: On Tue, Apr 24, 2007 at 05:14:28PM -0700, Greg KH wrote: On Tue, Apr 24, 2007 at 11:32:53AM +0200, Wolfgang Erig wrote: On Mon, Apr 23, 2007 at 03:18:19PM -0700, Greg KH

[linux-usb-devel] [1/2] 2.6.21-rc7: known regressions

2007-04-16 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

[linux-usb-devel] [2/3] 2.6.21-rc6: known regressions

2007-04-14 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

Re: [linux-usb-devel] [2/3] 2.6.21-rc6: known regressions

2007-04-14 Thread Adrian Bunk
On Sat, Apr 14, 2007 at 12:37:42PM -0400, Alan Stern wrote: On Sat, 14 Apr 2007, Adrian Bunk wrote: Subject: USB: iPod doesn't work (CONFIG_USB_SUSPEND) References : http://lkml.org/lkml/2007/3/21/320 Submitter : Tino Keitel [EMAIL PROTECTED] Caused-By : Marcelo Tosatti [EMAIL

[linux-usb-devel] [2/4] 2.6.21-rc5: known regressions (v2)

2007-03-31 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

[linux-usb-devel] [3/5] 2.6.21-rc5: known regressions

2007-03-27 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

[linux-usb-devel] [5/5] 2.6.21-rc4: known regressions (v2)

2007-03-24 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

Re: [linux-usb-devel] possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-23 Thread Adrian Bunk
On Thu, Mar 22, 2007 at 10:46:53PM +0100, Tino Keitel wrote: On Thu, Mar 22, 2007 at 14:29:11 -0700, David Brownell wrote: On Thursday 22 March 2007 12:54 pm, Tino Keitel wrote: On Thu, Mar 22, 2007 at 15:40:40 -0400, Alan Stern wrote: _Something_ is generating those

[linux-usb-devel] 2.6.21-rc4: known regressions with patches available

2007-03-20 Thread Adrian Bunk
Let's not bore people running -rc kernels with regressions that have patches available - let's get this patches into the tree for giving them the pure exciting experience of the many unfixed regressions. This email lists some known regressions in Linus' tree compared to 2.6.20 with patches

Re: [linux-usb-devel] 2.6.21-rc4: pl2303 disconnect oops

2007-03-19 Thread Adrian Bunk
On Mon, Mar 19, 2007 at 08:41:33AM +0200, Meelis Roos wrote: I was using my laptop as the serial console of another computer with pl2303 usb-to-serial cable. minicom was running but I do not remember whether the other end was connected or was already disconnected. Anyway, I unplugged the

[linux-usb-devel] drivers/usb/misc/iowarrior.c: NULL dereference

2007-03-19 Thread Adrian Bunk
The Coverity checker spotted the following NULL dereference: -- snip -- ... static ssize_t iowarrior_write(struct file *file, const char __user *user_buffer, size_t count, loff_t *ppos) { ... if (!int_out_urb) {

[linux-usb-devel] [2.6 patch] drivers/usb/input/gtco.c: fix a use-before-check

2007-03-19 Thread Adrian Bunk
NULL checks should be before the first dereference. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.21-rc3-mm2/drivers/usb/input/gtco.c.old 2007-03-19 09:29:44.0 +0100 +++ linux-2.6.21-rc3-mm2/drivers/usb/input/gtco.c 2007-03-19

[linux-usb-devel] [6/6] 2.6.21-rc4: known regressions

2007-03-19 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

[linux-usb-devel] 2.6.21-rc3: known regressions with patches

2007-03-15 Thread Adrian Bunk
This email lists known regressions in Linus' tree compared to 2.6.20 with patches available. If possible, the patches should be included in 2.6.21-rc4 for reducing the number of known regressiond in -rc4 a little bit. If you find your name in the Cc header, you are either submitter of one of

[linux-usb-devel] [1/6] 2.6.21-rc3: known regressions

2007-03-13 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

Re: [linux-usb-devel] 2.6.21rc3: usb 2-2: pl2303 converter now attached to ttyUSB44

2007-03-12 Thread Adrian Bunk
On Wed, Mar 07, 2007 at 10:22:04AM +0100, Arkadiusz Miskiewicz wrote: 2.6.21rc3 from today git, thinkpad z60m, pl2303 usb-rs232 adapter and: [ 84.087080] usb 2-2: new full speed USB device using uhci_hcd and address 3 [ 84.232615] usb 2-2: configuration #1 chosen from 1 choice [

Re: [linux-usb-devel] 2.6.21-rc2-mm1: drivers/usb/host/ohci-ssb.c doesn't compile

2007-03-05 Thread Adrian Bunk
On Mon, Mar 05, 2007 at 10:26:10AM -0800, Greg KH wrote: On Mon, Mar 05, 2007 at 12:26:45PM +0100, Michael Buesch wrote: On Monday 05 March 2007 11:57, Michael Buesch wrote: CC drivers/usb/host/ohci-hcd.o In file included from

[linux-usb-devel] 2.6.21-rc2-mm1: drivers/usb/host/ohci-ssb.c doesn't compile

2007-03-04 Thread Adrian Bunk
On Fri, Mar 02, 2007 at 03:00:26AM -0800, Andrew Morton wrote: ... Changes since 2.6.20-mm2: ... git-wireless.patch ... git trees ... -- snip -- ... CC drivers/usb/host/ohci-hcd.o In file included from

[linux-usb-devel] [2/6] 2.6.21-rc2: known regressions

2007-03-04 Thread Adrian Bunk
This email lists some known regressions in 2.6.21-rc2 compared to 2.6.20 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] [6/6] 2.6.21-rc2: known regressions

2007-03-04 Thread Adrian Bunk
This email lists some known regressions in 2.6.21-rc2 compared to 2.6.20 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.21-rc1: known regressions (v2) (part 1)

2007-02-27 Thread Adrian Bunk
This email lists some known regressions in 2.6.21-rc1 compared to 2.6.20 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.21-rc1: known regressions (part 1)

2007-02-26 Thread Adrian Bunk
This email lists some known regressions in 2.6.21-rc1 compared to 2.6.20 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

Re: [linux-usb-devel] 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO

2007-02-19 Thread Adrian Bunk
On Sun, Jan 14, 2007 at 06:36:10AM -0800, David Brownell wrote: On Sunday 14 January 2007 1:10 am, Adrian Bunk wrote: -- snip -- Waiting for Tony to submit bugfixes to his driver... Still unfixed as of 2.6.20-mm1. ... CC drivers/usb/misc/ftdi-elan.o /home/bunk/linux/kernel

[linux-usb-devel] [-mm patch] make drivers/usb/misc/iowarrior.c:iowarrior_ids[] static

2007-02-19 Thread Adrian Bunk
On Thu, Feb 15, 2007 at 05:14:08AM -0800, Andrew Morton wrote: ... Changes since 2.6.20-rc6-mm3: ... +gregkh-usb-usb-iowarrior.patch ... USB tree updates ... This patch makes the needlessly global struct iowarrior_ids[] static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux

[linux-usb-devel] drivers/usb/serial/mos7720.c: inconsequent NULL checking

2007-02-06 Thread Adrian Bunk
The Coverity checker noted the following inconsequent NULL checking in drivers/usb/serial/mos7720.c: -- snip -- ... static void mos7720_close(struct usb_serial_port *port, struct file *filp) { ... /* While closing port, shutdown all bulk read, write * * and interrupt read

[linux-usb-devel] 2.6.20-rc7: known regressions (v2) (part 2)

2007-02-03 Thread Adrian Bunk
/164 Submitter : Adrian Bunk [EMAIL PROTECTED] Caused-By : Eric Van Hensbergen [EMAIL PROTECTED] commit da977b2c7eb4d6312f063a7b486f2aad99809710 Handled-By : Adrian Bunk [EMAIL PROTECTED] Patch : http://lkml.org/lkml/2007/2/2/164 Status : patch available

[linux-usb-devel] 2.6.20-rc7: known regressions

2007-02-02 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc7 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc6: known unfixed regressions (v2) (part 1)

2007-01-27 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc6 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc6: known unfixed regressions (part 1)

2007-01-26 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc6 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc5: known unfixed regressions (v3) (part 1)

2007-01-24 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc5: knwon unfixed regressions (v2) (part1)

2007-01-19 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

[linux-usb-devel] 2.6.20-rc5: known regressions with patches (v2)

2007-01-19 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19 with patches available If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any

[linux-usb-devel] 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO

2007-01-14 Thread Adrian Bunk
-- snip -- ... CC drivers/usb/misc/ftdi-elan.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/usb/misc/ftdi-elan.c:2307:1: warning: OHCI_QUIRK_ZFMICRO redefined In file included from /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/usb/misc/ftdi-elan.c:76:

Re: [linux-usb-devel] 2.6.20-rc4: usb somehow broken

2007-01-14 Thread Adrian Bunk
On Sun, Jan 14, 2007 at 10:08:37AM +0100, Prakash Punnoor wrote: Am Donnerstag 11 Januar 2007 18:28 schrieb Oliver Neukum: Am Donnerstag, 11. Januar 2007 18:20 schrieb Prakash Punnoor: Hi, I can't scan anymore. :-( I don't know which rc kernel introduced it, but this are the

[linux-usb-devel] 2.6.20-rc5: known unfixed regressions

2007-01-13 Thread Adrian Bunk
On Fri, Jan 12, 2007 at 02:27:48PM -0500, Linus Torvalds wrote: ... A lot of developers (including me) will be gone next week for Linux.Conf.Au, so you have a week of rest and quiet to test this, and report any problems. Not that there will be any, right? You all behave now! ... This

[linux-usb-devel] 2.6.20-rc5: known regressions with patches

2007-01-13 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19 with patches available. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any

Re: [linux-usb-devel] 2.6.20-rc5: known regressions with patches

2007-01-13 Thread Adrian Bunk
On Sat, Jan 13, 2007 at 07:32:46AM -0800, Roland Dreier wrote: This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19 with patches available. Subject: KVM: guest crash References : http://lkml.org/lkml/2007/1/8/163 Submitter : Roland Dreier [EMAIL PROTECTED]

[linux-usb-devel] 2.6.20-rc4: known unfixed regressions (v3)

2007-01-11 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc4 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc4: known unfixed regressions (v2)

2007-01-09 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc4 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc3: known unfixed regressions (v4)

2007-01-09 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc3: known unfixed regressions (v2)

2007-01-04 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc3: known unfixed regressions (v3)

2007-01-04 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc3: known unfixed regressions

2007-01-02 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.20-rc2: known unfixed regressions (v2)

2007-01-02 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc2 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] drivers/media/video/usbvision/usbvision-video.c: negative array

2006-12-17 Thread Adrian Bunk
index Reply-To: Fcc: =sent-mail The Coverity checker spotted that in usbvision_v4l2_read(), the variable frmx is never assigned any value different from -1, but it's used an an array index in usbvision-frame[frmx]. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly

[linux-usb-devel] [2.6 patch] build the appledisplay driver

2006-11-23 Thread Adrian Bunk
We do already have both the code and a config option, so why not build this driver? ;-) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.19-rc6-mm1/drivers/usb/misc/Makefile.old 2006-11-24 03:19:31.0 +0100 +++ linux-2.6.19-rc6-mm1/drivers/usb/misc/Makefile 2006-11-24

Re: [linux-usb-devel] 2.6.19-rc5: modular USB rebuilds vmlinux?

2006-11-22 Thread Adrian Bunk
On Wed, Nov 22, 2006 at 10:54:54AM -0800, Randy Dunlap wrote: On Wed, 22 Nov 2006 21:45:55 +0300 Andrey Borzenkov wrote: I was under impression that I have fully modular USB. Still: {pts/1}% make -C ~/src/linux-git O=$HOME/build/linux-2.6.19 make: Entering directory

[linux-usb-devel] 2.6.19-rc6: known regressions

2006-11-17 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc6 compared to 2.6.18 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] 2.6.19-rc5: known regressions (v3)

2006-11-15 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc5 compared to 2.6.18 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

Re: [linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference

2006-11-12 Thread Adrian Bunk
On Sat, Nov 11, 2006 at 11:10:17PM -0800, David Brownell wrote: void dev_kfree_skb_any(struct sk_buff *skb) { if (in_irq() || irqs_disabled()) dev_kfree_skb_irq(skb); else dev_kfree_skb(skb); } And the first thing

[linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference

2006-11-11 Thread Adrian Bunk
The Coverity checker spotted the following NULL dereference of skb in drivers/usb/gadget/ether.c: -- snip -- ... static int rx_submit (struct eth_dev *dev, struct usb_request *req, gfp_t gfp_flags) { struct sk_buff *skb; int retval = -ENOMEM; ...

[linux-usb-devel] drivers/usb/serial/aircable.c: inconsequent NULL checking

2006-11-11 Thread Adrian Bunk
The Coverity checker spotted the following in drivers/usb/serial/aircable.c: -- snip -- ... static void aircable_read(void *params) { struct usb_serial_port *port = params; struct aircable_private *priv = usb_get_serial_port_data(port); struct tty_struct *tty;

[linux-usb-devel] drivers/usb/serial/mos7720.c: inconsequent NULL checking

2006-11-11 Thread Adrian Bunk
The Coverity checker noted the following inconsequent NULL checking in drivers/usb/serial/mos7720.c: -- snip -- ... static void mos7720_close(struct usb_serial_port *port, struct file *filp) { ... /* While closing port, shutdown all bulk read, write * * and interrupt read

Re: [linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference

2006-11-11 Thread Adrian Bunk
On Sat, Nov 11, 2006 at 10:35:48PM -0800, David Brownell wrote: On Saturday 11 November 2006 8:06 am, Adrian Bunk wrote: The Coverity checker spotted the following NULL dereference of skb in drivers/usb/gadget/ether.c: I don't see such a dereference. As usual, free(NULL) is legit

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-11-04 Thread Adrian Bunk
On Thu, Nov 02, 2006 at 12:29:12PM -0800, David Brownell wrote: On Wednesday 01 November 2006 11:15 pm, Greg KH wrote: Argh, there were just too many different versions of these patches floating around. Can you resend the final versions please? This should replace BOTH of Randy's

[linux-usb-devel] Linux 2.6.19-rc4: known unfixed regressions (v2)

2006-11-04 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc4 compared to 2.6.18 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[linux-usb-devel] [2.6 patch] USB_RTL8150 must select MII

2006-11-04 Thread Adrian Bunk
On Thu, Nov 02, 2006 at 06:47:15PM -0800, David Brownell wrote: On Thursday 02 November 2006 6:27 pm, Adrian Bunk wrote: It seems to lack the select MII at the USB_RTL8150 option that was in Randy's first patch? I was just addressing the usbnet issues ... that driver doesn't use

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-11-01 Thread Adrian Bunk
On Tue, Oct 31, 2006 at 11:36:52AM -0800, David Brownell wrote: ... depends on MII if MII != n except that Kconfig doesn't comprehend conditionals like that. You can express this in Kconfig: depends MII || MII=n Except that: Warning! Found

[linux-usb-devel] 2.6.19-rc4: known unfixed regressions

2006-10-31 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc4 compared to 2.6.18 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-31 Thread Adrian Bunk
On Tue, Oct 31, 2006 at 10:40:15AM -0700, David Brownell wrote: +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE) +#define HAVE_MII ... This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage (as already described earlier in this thread)? Well, alluded to not

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-29 Thread Adrian Bunk
On Sat, Oct 28, 2006 at 02:10:09PM -0700, David Brownell wrote: On Saturday 28 October 2006 4:21 am, Christoph Hellwig wrote: This is really awkward and against what we do in any other driver. Awkward, yes -- which is why I posted the non-awkward version, which is repeated below. (No

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

2006-10-28 Thread Adrian Bunk
On Wed, Oct 25, 2006 at 04:58:58PM -0700, Randy Dunlap wrote: ... Build tested with CONFIG_MII=y, m, n. ... --- linux-2619-rc3-pv.orig/drivers/usb/net/usbnet.c +++ linux-2619-rc3-pv/drivers/usb/net/usbnet.c @@ -47,6 +47,12 @@ #define DRIVER_VERSION 22-Aug-2005 +#if

[linux-usb-devel] [3/3] 2.6.19-r2: known regressions with patches

2006-10-14 Thread Adrian Bunk
Submitter : Adrian Bunk [EMAIL PROTECTED] Caused-By : Alan Cox [EMAIL PROTECTED] commit 67cc0161ecc9ebee6eba4af6cbfdba028090b1b9 Handled-By : Adrian Bunk [EMAIL PROTECTED] Patch : http://lkml.org/lkml/2006/10/11/9 Status : patch available Subject: ueagle-atm Oops

[linux-usb-devel] 2.6.19-rc1: known regressions (v3)

2006-10-10 Thread Adrian Bunk
] Status : suggested workaround for 2.6.19: deactivate MSI in snd-intel-hda by default Subject: DVB frontend selection causes compile errors References : http://lkml.org/lkml/2006/10/8/244 Submitter : Adrian Bunk [EMAIL PROTECTED] Caused-By : Andrew de Quincey [EMAIL PROTECTED

[linux-usb-devel] 2.6.19-rc1: known regressions (v2)

2006-10-08 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc1 compared to 2.6.18 that are not yet fixed Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you was declared guilty for a breakage or

[linux-usb-devel] [2.6 patch] drivers/usb/misc/ftdi-elan.c: remove dead code

2006-10-08 Thread Adrian Bunk
The Coverity checker spotted this obviously dead code. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6/drivers/usb/misc/ftdi-elan.c.old 2006-10-09 00:22:57.0 +0200 +++ linux-2.6/drivers/usb/misc/ftdi-elan.c 2006-10-09 00:24:39.0 +0200 @@ -513,8 +513,6

[linux-usb-devel] [RFC: 2.6 patch] drivers/usb/serial/mos7840.c: remove dead code

2006-10-08 Thread Adrian Bunk
The Coverity checker spotted this dead code. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/usb/serial/mos7840.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) --- linux-2.6/drivers/usb/serial/mos7840.c.old 2006-10-09 00:31:41.0 +0200 +++ linux-2.6

[linux-usb-devel] [2.6 patch] drivers/usb/serial/mos7840.c: fix a check-after-dereference

2006-10-08 Thread Adrian Bunk
This patch fixes an obvious check-after-dereference spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6/drivers/usb/serial/mos7840.c.old 2006-10-09 00:35:49.0 +0200 +++ linux-2.6/drivers/usb/serial/mos7840.c 2006-10-09 00:36:28.0

[linux-usb-devel] [2.6 patch] drivers/usb/input/hid-core.c: fix duplicate USB_DEVICE_ID_GTCO_404

2006-09-04 Thread Adrian Bunk
of the previous definition ... -- snip -- This patch fixes this cut'n'paste error. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.18-rc5-mm1/drivers/usb/input/hid-core.c.old 2006-09-03 21:00:25.0 +0200 +++ linux-2.6.18-rc5-mm1/drivers/usb/input/hid-core.c 2006-09-03 21:00

[linux-usb-devel] [-mm patch] make drivers/usb/core/driver.c:usb_device_match() static

2006-09-04 Thread Adrian Bunk
usb_device_match() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 22 Aug 2006 - 15 Aug 2006 --- linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c.old 2006-07-14 23:29:20.0 +0200 +++ linux-2.6.18-rc1-mm2-full/drivers/usb

[linux-usb-devel] [-mm patch] make drivers/usb/core/driver.c:usb_device_match() static

2006-08-22 Thread Adrian Bunk
usb_device_match() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 15 Aug 2006 --- linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c.old 2006-07-14 23:29:20.0 +0200 +++ linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c

[linux-usb-devel] drivers/usb/misc/cypress_cy7c63.c: NULL dereference

2006-08-14 Thread Adrian Bunk
The Coverity Checker spotted the following obvious NULL dereference: -- snip -- ... static int cypress_probe(struct usb_interface *interface, const struct usb_device_id *id) { ... if (dev == NULL) { dev_err(dev-udev-dev, Out of memory!\n);

[linux-usb-devel] [-mm patch] make drivers/usb/core/driver.c:usb_device_match() static

2006-08-14 Thread Adrian Bunk
usb_device_match() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c.old 2006-07-14 23:29:20.0 +0200 +++ linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c 2006-07-14 23:29:51.0 +0200 @@ -471,7

[linux-usb-devel] [2.6 patch] fix the USB_GADGET_DUMMY_HCD dependencies

2006-07-30 Thread Adrian Bunk
If USB=m, USB_GADGET=y, the option USB_GADGET_DUMMY_HCD mustn't be offered since selecting it results in a compile error. This patch fixes kernel Bugzilla #6534 reported by Toralf Förster. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.18-rc2-mm1-full/drivers/usb/gadget/Kconfig.old

[linux-usb-devel] [RFC: -mm patch] drivers/usb/core/driver.c: make 2 functions static

2006-07-14 Thread Adrian Bunk
This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/usb/core/driver.c |4 ++-- drivers/usb/core/usb.h|2 -- 2 files changed, 2 insertions(+), 4 deletions(-) --- linux-2.6.18-rc1-mm2-full/drivers/usb/core/usb.h.old

[linux-usb-devel] [-mm patch] make drivers/usb/misc/cy7c63.c:vendor_command() static

2006-06-21 Thread Adrian Bunk
On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote: ... Changes since 2.6.17-rc6-mm2: ... +gregkh-usb-usb-new-driver-for-cypress-cy7c63xxx-mirco-controllers.patch ... USB tree updates ... This patch makes the needlessly global vendor_command() static. Signed-off-by: Adrian Bunk

[linux-usb-devel] Re: [2.6 Patch] isdn4linux: Siemens Gigaset base driver: fix disconnect handling

2006-04-20 Thread Adrian Bunk
On Thu, Apr 20, 2006 at 08:21:20AM -0700, Randy.Dunlap wrote: On Thu, 20 Apr 2006 14:07:11 +0200 Tilman Schmidt wrote: On 20.04.2006 09:11, Andrew Morton wrote: Tilman Schmidt [EMAIL PROTECTED] wrote: This patch fixes a possible Oops in the Siemens Gigaset base driver when the

[linux-usb-devel] [2.6 patch] drivers/usb/misc/sisusbvga/: possible cleanups

2006-04-15 Thread Adrian Bunk
() - sisusb_init.c: SiSUSB_GetModeID() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 19 Jan 2006 drivers/usb/misc/sisusbvga/sisusb.c| 35 +++-- drivers/usb/misc/sisusbvga/sisusb_con.c| 24 +- drivers/usb/misc/sisusbvga

[linux-usb-devel] [RFC: 2.6 patch] drivers/usb/core/: remove unused exports

2006-04-04 Thread Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's: - hub.c: usb_set_device_state - usb.c: usb_alloc_dev - usb.c: usb_disconnect Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/usb/core/hub.c |1 - drivers/usb/core/usb.c |2 -- 2 files changed, 3 deletions(-) --- linux

[linux-usb-devel] [2.6 patch] drivers/usb/host/pci-quirks.c: proper prototypes

2006-03-25 Thread Adrian Bunk
This patch adds a header file with proper prototypes for two functions in drivers/usb/host/pci-quirks.c. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/usb/host/pci-quirks.c |1 + drivers/usb/host/pci-quirks.h |7 +++ drivers/usb/host/uhci-hcd.c |4 +--- 3 files

[linux-usb-devel] [2.6 patch] usb/input/keyspan_remote.c: don't use an uninitialized variable

2006-03-25 Thread Adrian Bunk
gcc reported the following: -- snip -- ... CC drivers/usb/input/keyspan_remote.o drivers/usb/input/keyspan_remote.c: In function 'keyspan_irq_recv': drivers/usb/input/keyspan_remote.c:186: warning: 'message.toggle' may be used uninitialized in this function ... -- snip -- gcc is

[linux-usb-devel] Re: [2.6 patch] usb/input/keyspan_remote.c: don't use an uninitialized variable

2006-03-25 Thread Adrian Bunk
On Sat, Mar 25, 2006 at 06:12:14PM +0100, Adrian Bunk wrote: ... Signed-off-by: Darren Jenkins [EMAIL PROTECTED] ... Cut'n'paste error of the year... Darren Jenkins was in no way involved with this patch, this should have been: Signed-off-by: Adrian Bunk [EMAIL PROTECTED] cu Adrian

[linux-usb-devel] 2.6.16-rc: saa7134 + usb-storage = freeze

2006-03-15 Thread Adrian Bunk
My computer always freezes after a few minutes with the following workload: - watching TV with xawtv - backup to an external USB disk using backup2l As long as I'm not doing both at the same time there are no problems. Freeze means: - X is completely frozen - TV sound continues to be correctly

Re: [linux-usb-devel] 2.6.16-rc: saa7134 + usb-storage = freeze

2006-03-15 Thread Adrian Bunk
On Wed, Mar 15, 2006 at 09:18:17PM +0100, Duncan Sands wrote: My computer always freezes after a few minutes with the following workload: - watching TV with xawtv bttv? overlay or grabdisplay? What motherboard? - saa7134 - overlay - Asus A7V600-X Ciao, cu Adrian -- Is

[linux-usb-devel] Re: [usb-storage] Re: [v4l-dvb-maintainer] 2.6.16-rc: saa7134 + u sb-storage = freeze

2006-03-15 Thread Adrian Bunk
On Wed, Mar 15, 2006 at 06:44:21PM -0500, Alan Cox wrote: On Wed, Mar 15, 2006 at 03:24:40PM -0600, Ballentine, Casey wrote: I would bet we could add the vt8235 to the list of broken chipsets as well, if it's not already there. My company has completely Works for me 8) A lot of this

[linux-usb-devel] Re: [v4l-dvb-maintainer] 2.6.16-rc: saa7134 + usb-storage = freeze

2006-03-15 Thread Adrian Bunk
On Wed, Mar 15, 2006 at 05:27:28PM -0300, Mauro Carvalho Chehab wrote: Adrian, hmm... VIA vt8237... We have several similar reports with current VIA chipsets (KT800 and KT880) and PCI2PCI transfers (Overlay mode in xawtv). Would you please download the latest Mercurial development tree

[linux-usb-devel] 2.6.16-rc6: known regressions

2006-03-13 Thread Adrian Bunk
This email lists some known regressions in 2.6.16-rc6 compared to 2.6.15. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you was declared guilty for a breakage or I'm considering you in any other

[linux-usb-devel] [2.6 patch] drivers/usb/media/vicam.c: fix a NULL pointer dereference

2006-03-10 Thread Adrian Bunk
This patch fixes a NULL pointer dereference spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.16-rc5-mm3-full/drivers/usb/media/vicam.c.old 2006-03-10 20:54:17.0 +0100 +++ linux-2.6.16-rc5-mm3-full/drivers/usb/media/vicam.c 2006-03-10 20

[linux-usb-devel] 2.6.16-rc5-mm1: USB compile errors

2006-03-03 Thread Adrian Bunk
On Tue, Feb 28, 2006 at 04:24:39AM -0800, Andrew Morton wrote: ... Changes since 2.6.16-rc4-mm2: ... +gregkh-usb-usb-reduce-syslog-clutter.patch USB tree update ... This patch causes tons of comile errors like the following in non-modular drivers: -- snip -- ... CC

[linux-usb-devel] 2.6.16-rc5: known regressions

2006-02-27 Thread Adrian Bunk
This email lists some known regressions in 2.6.16-rc5 compared to 2.6.15. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you was declared guilty for a breakage or I'm considering you in any other

[linux-usb-devel] Re: Linux 2.6.16-rc3

2006-02-13 Thread Adrian Bunk
On Sun, Feb 12, 2006 at 07:05:20PM -0800, Andrew Morton wrote: ... - Various reports similar to http://bugzilla.kernel.org/show_bug.cgi?id=6011, seemingly related to USB PCI quirk handling. ... This bug contains a patch. What is the status of this patch? cu Adrian -- Is there

[linux-usb-devel] [2.6 patch] drivers/usb/misc/sisusbvga/: possible cleanups

2006-01-18 Thread Adrian Bunk
() - sisusb_init.c: SiSUSB_GetModeID() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/usb/misc/sisusbvga/sisusb.c| 35 +++-- drivers/usb/misc/sisusbvga/sisusb_con.c| 24 +- drivers/usb/misc/sisusbvga/sisusb_init.c |4 +- drivers/usb/misc/sisusbvga

[linux-usb-devel] [2.6 patch] remove unused tmp_buf_sem's

2006-01-14 Thread Adrian Bunk
(tmp_buf_sem); ... There are even more of them... Patch below. cu Adrian -- snip -- tmp_buf_sem sems to be a common name for something completely unused... Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/ia64/hp/sim/simserial.c |1 - arch/ppc/4xx_io/serial_sicc.c |1

  1   2   >