[PATCH] USB: serial: ftdi_sio: Add support for CBUS GPIO

2018-08-01 Thread Loic Poulain
Some FTDI devices like FTX or FT232R support CBUS Bit Bang mode on CBUS pins, allowing host to control them via simple USB control transfers. To make use of a CBUS pin in Bit Bang mode, the pin must be configured to I/O mode in the FTDI EEPROM. This mode perfectly coexists with regular USB to

Re: [PATCH] USB: serial: ftdi_sio: Add support for CBUS GPIO

2018-08-01 Thread Andy Shevchenko
On Wed, Aug 1, 2018 at 6:46 PM, Loic Poulain wrote: > Some FTDI devices like FTX or FT232R support CBUS Bit Bang mode on CBUS > pins, allowing host to control them via simple USB control transfers. > To make use of a CBUS pin in Bit Bang mode, the pin must be configured > to I/O mode in the FTDI

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-08-01 Thread Vincent Pelletier
Hello, Bo He, CC'ed, found a regression introduced in my patch, discussed in this thread, and submitted a patch: Subject: [PATCH] fix panic at pwq_activate_delayed_work. Date: Wed, 1 Aug 2018 10:14:38 + Message-ID: On Fri, 29 Jun 2018 09:32:43 +0300, Felipe Balbi wrote: > Hmm,

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-01 Thread Felipe Balbi
Hi, First of all, not receiving your mails through the mailing list. Can you check that you're not being blocked for some reason? You may wanna send trace data compressed with gzip or xz. On Wed, Aug 1, 2018 at 2:27 AM Thinh Nguyen wrote: > On 7/30/2018 11:58 PM, Felipe Balbi wrote: > > Thinh

Re: [PATCH 1/8] usb: gadget: uvc: configfs: Don't wrap groups unnecessarily

2018-08-01 Thread Kieran Bingham
Hi Laurent, Thank you for the patch, On 01/08/18 01:29, Laurent Pinchart wrote: > Various configfs groups (represented by config_group) as wrapped in /as wrapped/are wrapped/ > structures that they're the only member of. This allows adding other > data fields to groups, but is unnecessarily

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-01 Thread Felipe Balbi
Hi, Felipe Balbi writes: >> This is an issue, but it's not the same one. >> >> irq/16-dwc3-5032 [003] d...65.404194: dwc3_complete_trb: >> ep1out: trb 890522d5 buf b8d6d000 size 0 ctrl 3b56446c >> (hlCS:Sc:isoc-first) >> > > So this is chained to the next one,

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-01 Thread Felipe Balbi
Felipe Balbi writes: > Hi, > > Felipe Balbi writes: > > > >>> This is an issue, but it's not the same one. >>> >>> irq/16-dwc3-5032 [003] d...65.404194: dwc3_complete_trb: >>> ep1out: trb 890522d5 buf b8d6d000 size 0 ctrl 3b56446c >>> (hlCS:Sc:isoc-first) >>> >> >> So

Re: [PATCH 2/8] usb: gadget: uvc: configfs: Add section header comments

2018-08-01 Thread Kieran Bingham
Hi Laurent, A trivial but nice improvement. On 01/08/18 01:29, Laurent Pinchart wrote: > The UVC configfs implementation is large and difficult to navigate. Add > a bit more air to the code to make it easier to read. > > Signed-off-by: Laurent Pinchart Acked-by: Kieran Bingham > --- >

Re: [PATCH 3/8] usb: gadget: uvc: configfs: Allocate groups dynamically

2018-08-01 Thread Kieran Bingham
Hi Laurent, Thank you for the patch, On 01/08/18 01:29, Laurent Pinchart wrote: > The UVC configfs implementation creates all groups as global static > variables. This prevents creationg of multiple UVC function instances, /creationg/creation/ > as they would all require their own configfs

Re: [PATCH 4/8] usb: gadget: uvc: configfs: Add interface number attributes

2018-08-01 Thread Kieran Bingham
Hi Laurent, Thank you for the patch, On 01/08/18 01:29, Laurent Pinchart wrote: > The video control and video streaming interface numbers are needed in > the UVC gadget userspace stack to reply to UVC requests. They are > hardcoded to fixed values at the moment, preventing configurations with >

Re: [PATCH 6/8] usb: gadget: uvc: configfs: Document the bFormatIndex attribute

2018-08-01 Thread Kieran Bingham
Hi Laurent, On 01/08/18 01:29, Laurent Pinchart wrote: > Document for the bFormatIndex attribute of the format descriptors is > missing. Add it. It might be missing, but only just since the previous patch. Perhaps this should squash into [5/8] ? > Signed-off-by: Laurent Pinchart > --- >

Re: fusb302 type-c chip driver supply cutting out

2018-08-01 Thread Tim Harvey
On Tue, Jul 31, 2018 at 2:22 AM Adam Thomson wrote: > > On 27 July 2018 17:41, Tim Harvey wrote: > > Adding Guenter to the thread. > > > Greetings, > > > > I have a custom design with a Fairchild FUSB302 Type-C chip driver > > that I'm testing with Linux 4.17 and a BTI AC-60TC 60W charger. For >

Re: [PATCH 4/8] usb: gadget: uvc: configfs: Add interface number attributes

2018-08-01 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 1 August 2018 13:07:20 EEST Kieran Bingham wrote: > On 01/08/18 01:29, Laurent Pinchart wrote: > > The video control and video streaming interface numbers are needed in > > the UVC gadget userspace stack to reply to UVC requests. They are > > hardcoded to fixed values at

RE: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-08-01 Thread He, Bo
Your patch fix the issue BUG: scheduling while atomic: BUG: scheduling while atomic: SettingsProvide/3433/0x0104 Preemption disabled at: [] __do_softirq+0x53/0x31b CPU: 1 PID: 3433 Comm: SettingsProvide Tainted: P U ilt-2e5dc0ac-g3f662bf-dirty #8 Call Trace:

re: hello

2018-08-01 Thread Erika@EuropeMillions
-- Congratulations, You Have won SIX HUNDRED AND FIFTY THOUSAND EURO in the monthly Euro/ Google draws on July 1, 2018. reply to fill your claim form. Erika Hermann Online Coordinator Desk038984EU -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH 3/8] usb: gadget: uvc: configfs: Allocate groups dynamically

2018-08-01 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 1 August 2018 12:58:40 EEST Kieran Bingham wrote: > On 01/08/18 01:29, Laurent Pinchart wrote: > > The UVC configfs implementation creates all groups as global static > > variables. This prevents creationg of multiple UVC function instances, > > /creationg/creation/ > >

Re: fusb302 type-c chip driver supply cutting out

2018-08-01 Thread Guenter Roeck
On Wed, Aug 01, 2018 at 11:37:56AM -0700, Tim Harvey wrote: > On Tue, Jul 31, 2018 at 2:22 AM Adam Thomson > wrote: > > > > On 27 July 2018 17:41, Tim Harvey wrote: > > > > Adding Guenter to the thread. > > > > > Greetings, > > > > > > I have a custom design with a Fairchild FUSB302 Type-C chip

Re: [PATCH] USB: serial: ftdi_sio: Add support for CBUS GPIO

2018-08-01 Thread Loic Poulain
Thanks Andy, On 1 August 2018 at 18:08, Andy Shevchenko wrote: > On Wed, Aug 1, 2018 at 6:46 PM, Loic Poulain wrote: >> Some FTDI devices like FTX or FT232R support CBUS Bit Bang mode on CBUS >> pins, allowing host to control them via simple USB control transfers. >> To make use of a CBUS pin

[PATCH v2 4/8] usb: gadget: uvc: configfs: Allocate groups dynamically

2018-08-01 Thread Laurent Pinchart
The UVC configfs implementation creates all groups as global static variables. This prevents creation of multiple UVC function instances, as they would all require their own configfs group instances. Fix this by allocating all groups dynamically. To avoid duplicating code around, extend the

[PATCH v2 6/8] usb: gadget: uvc: configfs: Add bFormatIndex attributes

2018-08-01 Thread Laurent Pinchart
The UVC format description are numbered using the descriptor's bFormatIndex field. The index is used in UVC requests, and is thus needed to handle requests in userspace. Make it dynamically discoverable by exposing it in a bFormatIndex configfs attribute of the uncompressed and mjpeg format config

[PATCH v2 1/8] usb: gadget: uvc: configfs: Don't wrap groups unnecessarily

2018-08-01 Thread Laurent Pinchart
Various configfs groups (represented by config_group) are wrapped in structures that they're the only member of. This allows adding other data fields to groups, but it unnecessarily makes the code more complex. Remove the outer structures and use config_group directly to simplify the code. Groups

[PATCH v2 2/8] usb: gadget: uvc: configfs: Add section header comments

2018-08-01 Thread Laurent Pinchart
The UVC configfs implementation is large and difficult to navigate. Add a bit more air to the code to make it easier to read. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- drivers/usb/gadget/function/uvc_configfs.c | 120 ++--- 1 file changed, 91

[PATCH v2 8/8] usb: gadget: uvc: configfs: Prevent format changes after linking header

2018-08-01 Thread Laurent Pinchart
From: Joel Pepper While checks are in place to avoid attributes and children of a format being manipulated after the format is linked into the streaming header, the linked flag was never actually set, invalidating the protections. Signed-off-by: Joel Pepper ---

[PATCH v2 0/8] usb: gadget: uvc: Improve configfs support

2018-08-01 Thread Laurent Pinchart
Hello, This patch series reworks the UVC gadget function configfs implementation to support multiple UVC functions in a single device and The first two patches simplify the code (01/08) and improve readability (02/08). The series then moves to dynamically allocating all configfs groups to

[PATCH v2 3/8] usb: gadget: uvc: configfs: Drop leaked references to config items

2018-08-01 Thread Laurent Pinchart
Some of the .allow_link() and .drop_link() operations implementations call config_group_find_item() and then leak the reference to the returned item. Fix this by dropping those references where needed. Signed-off-by: Laurent Pinchart --- drivers/usb/gadget/function/uvc_configfs.c | 4 1

[PATCH v2 7/8] usb: gadget: uvc: configfs: Add bFrameIndex attributes

2018-08-01 Thread Laurent Pinchart
From: Joel Pepper - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. - Automatically assign ascending bFrameIndex to each frame in a format. Before all "bFrameindex" attributes were set to "1" with no way to configure the gadget otherwise. This resulted in the host always

[PATCH v2 5/8] usb: gadget: uvc: configfs: Add interface number attributes

2018-08-01 Thread Laurent Pinchart
The video control and video streaming interface numbers are needed in the UVC gadget userspace stack to reply to UVC requests. They are hardcoded to fixed values at the moment, preventing configurations with multiple functions. To fix this, make them dynamically discoverable by userspace through

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-01 Thread Thinh Nguyen
On 8/1/2018 6:26 PM, Thinh Nguyen wrote: > Hi Felipe, > > > On 8/1/2018 1:33 AM, Felipe Balbi wrote: >> Felipe Balbi writes: >> >>> Hi, >>> >>> Felipe Balbi writes: >>> >>> >>> > This is an issue, but it's not the same one. > > irq/16-dwc3-5032 [003] d...65.404194:

Re: [PATCH 2/3] usb: dwc3: gadget: Don't skip updating remaining data

2018-08-01 Thread Thinh Nguyen
Hi Felipe, On 8/1/2018 1:33 AM, Felipe Balbi wrote: > Felipe Balbi writes: > >> Hi, >> >> Felipe Balbi writes: >> >> >> This is an issue, but it's not the same one. irq/16-dwc3-5032 [003] d...65.404194: dwc3_complete_trb: ep1out: trb 890522d5 buf

[PATCH] usb: ehci-sh: convert to SPDX identifiers

2018-08-01 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto --- include/linux/platform_data/ehci-sh.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/include/linux/platform_data/ehci-sh.h b/include/linux/platform_data/ehci-sh.h index 5c15a73..d8397df 100644