'radiob_array_table' and 'radiob_arraylen' is not used after setting its value.
It is safe to remove the unused variable.
Signed-off-by: zhong jiang
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wirele
int_type is not used after setting its value. It is safe to remove
the unused variable.
Signed-off-by: zhong jiang
---
drivers/net/wireless/marvell/libertas/if_spi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/marvell/libertas/if_spi.c
b/drivers/n
new_flags is not used after setting its value. It is safe to remove
the unused variable.
Signed-off-by: zhong jiang
---
drivers/net/wireless/ath/ath9k/ar9003_mci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mci.c
b/drivers/net/wi
From: Yan-Hsuan Chuang
cfg80211_sta_opmode_change_notify needs a gfp_t flag to hint the nl80211
stack when allocating new skb, but it is called under tasklet context
here with GFP_KERNEL and kernel will yield a warning about it.
Fixes: ff84e7bfe176 ("mac80211: Add support to notify ht/vht opmode
On Mon, 2018-10-22 at 07:51 +, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c: In function
> 'halbtc_leave_lps':
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:295:21: warning:
> variable 'p
On Mon, 2018-10-22 at 22:47 +0200, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 1 +
> 1 file chang
On 7/6/18 2:29 PM, Johannes Berg wrote:
> Hi Gustavo,
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> You dropped the remark saying you didn't review them, but did you?
>
I'll add it in v2.
>> case NL80211_CHAN_WI
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Warning level 3 was used: -Wimplicit-fallthrough=3
This code was not tested and GCC 7.2.0 was used to compile it.
Signed-off-by: Gustavo A. R. Silva
---
Changes in v2:
- Explicity menti
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ralink/rt2x00/rt61pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl882
Introduce dfs support in mt76x0e driver and unlock radar channels
Signed-off-by: Lorenzo Bianconi
---
.../net/wireless/mediatek/mt76/mt76x0/main.c | 11 +--
.../net/wireless/mediatek/mt76/mt76x0/phy.c | 4 +++
.../net/wireless/mediatek/mt76/mt76x02_dfs.c | 31 +--
.../ne
Introduce {sw,hw} dfs detector to mt76x0e driver in order to
properly unlock radar frequencies
This series is based on top of 'unify drv_bss_info_changed
between mt76x0 and mt76x2' one:
https://patchwork.kernel.org/cover/10650357/
Lorenzo Bianconi (2):
mt76: move dfs support in mt76x02-lib modul
Move mt76x2 DFS support in mt76x02-lib module in order to
be reused by mt76x0 driver and unlock DFS frequencies
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/Makefile | 3 +-
.../mt76/{mt76x2/pci_dfs.c => mt76x02_dfs.c} | 135 ++
.../net/wireless/med
On Mon, Oct 22, 2018 at 1:37 PM Gustavo A. R. Silva
wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 201383 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/net/wir
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/carl9170/tx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/carl9170/tx.c
b/drivers/net/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114947 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intersil/prism54/islpci_dev.c | 1 +
1 file changed, 1 insertion(+)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intersil/prism54/isl_ioctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/intersil/prism54/isl_ioct
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ralink/rt2x00/rt2400pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x0
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/intersil/orinoco/orinoc
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlega
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1056534 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/carl9170/rx.c | 1 +
1 file changed, 1 insertion(+)
diff --git
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1056532 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath9k/ar5008_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 del
In preparation to enabling -Wimplicit-fallthrough, this patchset aims
to mark switch cases where we are expecting to fall through.
Thanks!
Gustavo A. R. Silva (20):
ath6kl: Mark expected switch fall-through
ath9k: mark expected switch fall-through
ath9k: ar9002_phy: mark expected switch fal
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/zydas/zd1201.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/zydas/zd1201.c
b/drivers/net/wireless/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114948 ("Missing break in switch")
Addresses-Coverity-ID: 114949 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ray_cs.c |
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 145198 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4
1 file changed, 4 insertions(+)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ralink/rt2x00/rt2500pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x0
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/marvell/mwifiex/ie.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/marvell/mwifiex/ie.c
b/drivers/n
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114944 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intersil/prism54/isl_38xx.c | 1 +
1 file changed, 1 insertion(+)
di
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 201384 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intel/iwlegacy/common.c | 2 ++
1 file changed, 2 insertions(+)
diff
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1056532 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath9k/hw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/d
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1056532 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath9k/ar9002_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 del
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 201383 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath6kl/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
I was testing on my 4.16 kernel with a bunch of VAPs and I had two configured
for 100 beacon interval, and more at 240. This failed for reasons I figured out
(gcd logic), but even once I tried to configure the vaps for 240 interval they
could not come up. I am thinking maybe it was because I cou
On 10/17/2018 3:37 PM, Johannes Berg wrote:
[...]
Looks mostly good to me, some minor comments below...
> +/**
> + * struct cfg80211_pmsr_ftm_result - FTM result
> + * @failure_reason: if this measurement failed (PMSR status is
> + * %NL80211_PMSR_STATUS_FAILURE), this gives a more precise
>
Add infrastructure for per TID aggregation/retry count configurations
such as retry count and AMPDU aggregation control(disable/enable).
In some scenario reducing the number of retry count for a specific data
traffic can reduce the latency by proceeding with the next packet
instead of retrying the
Introduce NL80211_ATTR_TID_AMPDU_AGGR_CTRL in nl80211_attr_tid_config
to accept TID specific AMPDU aggregation enable/disable configuration
through NL80211_CMD_SET_TID_CONFIG command. TID for which the
aggregation control configuration is to be applied is passed in
NL80211_ATTR_TID attribute. When
Implement drv_set_tid_conf api to allow TID specific
retry count for data frames and aggregation enable/disable
configuration. If the retry_short and/or
retry_long value is default (-1), use the nedev wide retry
configuration for the station. This per-TID configuration
will be applied for all the c
This patch add ops for set_tid_conf to support
station specific retry and aggregation configuration for a TID.
station and configuration parameter(TID, configuration changed
parameter through ieee80211_tid_conf) information will be passed
as an argument for this ops.
Since target accepts one parame
From: Vasanthakumar Thiagarajan
Add a new NL command, NL80211_CMD_SET_TID_CONFIG, for TID specific
configurations such as retry count and AMPDU aggregation
control(disable/enable). These per-TID configurations are passed in
NL80211_ATTR_TID_CONFIG which is a nested attribute of TID configuration.
On 10/22/2018 05:07 AM, Johannes Berg wrote:
On Mon, 2018-10-22 at 14:06 +0200, Johannes Berg wrote:
On Fri, 2018-10-19 at 11:32 -0700, Ben Greear wrote:
I was hoping I could fit it into some existing stat. It is sort of like
retries, so that will be my first attempt.
By investigating an RF
On 10/22/18 4:36 PM, Jes Sorensen wrote:
> On 10/22/18 7:49 AM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, this patchset aims
>> to mark multiple switch cases where we are expecting to fall through.
>>
>> Also, the second patch in this series fixes a missing
On 10/22/18 7:49 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, this patchset aims
> to mark multiple switch cases where we are expecting to fall through.
>
> Also, the second patch in this series fixes a missing break in switch.
Enabling that sounds like a gr
Add missing break statement in order to prevent the code from falling
through to the default case.
Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 +
1 file changed, 1 insertion(+)
diff --gi
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1357355 ("Missing break in switch")
Addresses-Coverity-ID: 1357378 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/realtek/r
In preparation to enabling -Wimplicit-fallthrough, this patchset aims
to mark multiple switch cases where we are expecting to fall through.
Also, the second patch in this series fixes a missing break in switch.
Thanks
Gustavo A. R. Silva (2):
rtl8xxxu: Mark expected switch fall-throughs
rtl8
On Mon, 2018-10-22 at 14:06 +0200, Johannes Berg wrote:
> On Fri, 2018-10-19 at 11:32 -0700, Ben Greear wrote:
> >
> > I was hoping I could fit it into some existing stat. It is sort of like
> > retries, so that will be my first attempt.
> >
> > By investigating an RF sniff, I notice the 9880 at
On Fri, 2018-10-19 at 11:32 -0700, Ben Greear wrote:
>
> I was hoping I could fit it into some existing stat. It is sort of like
> retries, so that will be my first attempt.
>
> By investigating an RF sniff, I notice the 9880 ath10k (with my fw
> and driver, at least), will retransmit about 30%
On 10/22/2018 10:37 AM, Johannes Berg wrote:
On Mon, 2018-10-22 at 10:35 +0200, Johannes Stezenbach wrote:
commit 848e616e66d4592fe9afc40743d3504deb7632b4
Author: Stefan Seyfried
Date: Sun Sep 30 12:53:00 2018 +0200
cfg80211: fix wext-compat memory leak
Hopefully that'll eventually pro
On Mon, 2018-10-22 at 10:35 +0200, Johannes Stezenbach wrote:
> > commit 848e616e66d4592fe9afc40743d3504deb7632b4
> > Author: Stefan Seyfried
> > Date: Sun Sep 30 12:53:00 2018 +0200
> >
> > cfg80211: fix wext-compat memory leak
> >
> > Hopefully that'll eventually propagate to stable.
>
On Mon, Oct 22, 2018 at 10:25:07AM +0200, Johannes Berg wrote:
> On Mon, 2018-10-22 at 10:02 +0200, Johannes Stezenbach wrote:
> >
> > [] sta_set_sinfo+0x634/0x900 [mac80211]
> > [] ieee80211_get_station+0x50/0x70 [mac80211]
> > [<9fd8a7aa>]
On Mon, 2018-10-22 at 10:02 +0200, Johannes Stezenbach wrote:
>
> [] sta_set_sinfo+0x634/0x900 [mac80211]
> [] ieee80211_get_station+0x50/0x70 [mac80211]
> [<9fd8a7aa>] cfg80211_wext_giwrate+0x111/0x2b0 [cfg80211]
> I guess it relates to
> 0
Hi,
I used 4.18.11 for a while and noticed a memleak showing
in slabtop as kmalloc-2048. Then I updated to 4.18.16
and enabled kmemleak, it dumps this:
unreferenced object 0xa10a5cc49800 (size 2048):
comm "conky", pid 2734, jiffies 4295635396 (age 454.650s)
hex dump (first 32 bytes):
Hi Ben,
Just a quick reaction:
I guess the choice should mainly depend on the mean airtime to transmit a
frame, not on the final throughput, since it is a shared half-duplex media?
Retransmission is fine up to the point it does not take more airtime than a
lower MCS?
Jean-Pierre
> -Messa
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c: In function
'halbtc_leave_lps':
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:295:21: warning:
variable 'ppsc' set but not used [-Wunused-but-set-variable]
drivers/net/w
55 matches
Mail list logo
