Re: [PATCH v3] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler

On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote: > Change the config packet format used in handle_set_wfi_drv_handler() > to align the host driver with the new format used in the wilc firmware. So does this break devices with "old" firmware? Where is the "new" firmware? What is

Re: [PATCH] staging: wilc1000: Update handler assignment logic

On Fri, Apr 07, 2017 at 05:24:05PM +0530, Aditya Shankar wrote: > With this update, the host driver is consistent with the > implementation on the firmware side with respect to obtaining > the driver handler for all modes. > With this new format, the calls to set the wilc operation mode > is

Re: [PATCH V4 1/2] firmware: add more flexible request_firmware_async function

On Thu, Mar 16, 2017 at 02:55:09PM +0100, Rafał Miłecki wrote: > On 02/23/2017 07:30 PM, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > So far we got only one function for loading firmware asynchronously: > > request_firmware_nowait. It didn't allow much customization of

Re: [PATCH V4 1/2] firmware: add more flexible request_firmware_async function

On Thu, Mar 16, 2017 at 10:57:00AM +0100, Rafał Miłecki wrote: > On 23 February 2017 at 19:30, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > So far we got only one function for loading firmware asynchronously: > > request_firmware_nowait. It didn't

Re: [PATCH] staging: wilc1000: remove unnecessary local array

On Thu, Feb 09, 2017 at 02:48:39PM +0100, Franck Demathieu wrote: > It fixes the following warning reported by sparse: > > drivers/staging/wilc1000/linux_wlan.c:67:33: warning: too long > initializer-string for array of char(no space for nul char) > > Signed-off-by: Franck Demathieu

Re: [PATCHv2] ath10k: fix boot failure in UTF mode/testmode

On Mon, Jan 30, 2017 at 02:15:58PM +0530, c_tr...@qti.qualcomm.com wrote: > From: Tamizh chelvam > > Rx filter reset and the dynamic tx switch mode (EXT_RESOURCE_CFG) > configuration are causing the following errors when UTF firmware > is loaded to the target. > >

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote: > On 12/05/2016 03:34 PM, Dan Carpenter wrote: > > On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: > > > --- > > > wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > > +++ > > >

Re: [PATCH] staging: rtl8712: Free memory and return failure when kmalloc fails

On Thu, Oct 20, 2016 at 12:29:33PM +0530, Souptick Joarder wrote: > This patch is added to free memory and return failure when kmalloc fails I'm sorry, but I can not parse that sentance. Can you rephrase this a bit better? What exactly are you doing here? > > Signed-off-by: Souptick joarder

Re: [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

On Fri, Sep 30, 2016 at 07:35:17PM -0400, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > The generic disable_rf() function clears bits 22 and 23 in > REG_RX_WAIT_CCA, however we did not re-enable them again in > rtl8723b_enable_rf() > > This resolves the

Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface"

On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote: > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread > with workqueue for host interface") > > This commit breaks wilc1000 driver init. A crash was seen > everytime the wlan interface was brought up and wilc device

Re: staging: wilc1000: kernel Oops while opening the device

On Mon, Sep 26, 2016 at 05:17:37AM +, aditya.shan...@microchip.com wrote: > On Friday 23 September 2016 08:37 PM, Greg KH wrote: > > On Fri, Sep 23, 2016 at 01:17:08PM +, aditya.shan...@microchip.com > > wrote: > >> On Thursday 22 September 2016 06:04 PM, Ganes

Re: staging: wilc1000: kernel Oops while opening the device

On Fri, Sep 23, 2016 at 01:17:08PM +, aditya.shan...@microchip.com wrote: > On Thursday 22 September 2016 06:04 PM, Ganesh Krishna - I00112 wrote: > >> -Original Message- > >> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > >> Sent: Monday, September 19, 2016 7:12 PM >

Re: [PATCH 2/4] carl9170: fix debugfs crashes

On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote: > Ben Greear reported: > > I see lots of instability as soon as I load up the carl9710 NIC. > > My application is going to be poking at it's debugfs files... > > > > BUG: KASAN: slab-out-of-bounds in

Re: [PATCH 2/4] carl9170: fix debugfs crashes

On Mon, Sep 19, 2016 at 10:12:08PM +0200, Christian Lamparter wrote: > On Sunday, September 18, 2016 6:44:08 PM CEST Greg KH wrote: > > On Sun, Sep 18, 2016 at 02:49:33PM +0200, Christian Lamparter wrote: > > > On Sunday, September 18, 2016 12:14:55 PM CEST Greg KH wrote: >

Re: [PATCH 2/4] carl9170: fix debugfs crashes

On Sun, Sep 18, 2016 at 02:49:33PM +0200, Christian Lamparter wrote: > On Sunday, September 18, 2016 12:14:55 PM CEST Greg KH wrote: > > On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote: > > > Greg KH <gre...@linuxfoundation.org> writes: > > > > >

Re: [PATCH 2/4] carl9170: fix debugfs crashes

On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote: > Greg KH <gre...@linuxfoundation.org> writes: > > > On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote: > >> Ben Greear reported: > >> > I see lots of instability as soon a

Re: [PATCH 2/4] carl9170: fix debugfs crashes

On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote: > Ben Greear reported: > > I see lots of instability as soon as I load up the carl9710 NIC. > > My application is going to be poking at it's debugfs files... > > > > BUG: KASAN: slab-out-of-bounds in

Re: [PATCH - FYI - do not apply] staging: Remove rtl8723au driver

On Sat, Sep 10, 2016 at 08:25:33AM -0400, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Hi, > > I sent Greg the full version of this patch, removing the old rtl8723au > driver. I didn't want to spam the list with a 2M+ patch so this is the > summary version.

Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test

On Wed, Aug 31, 2016 at 09:32:56PM +0200, Matthias Beyer wrote: > Pinging here as nobody responded yet. > > Maybe this was overlooked. Nope, it was only a week, staging patches are at the bottom of my queue, please give me time to get to them, I process them usually ever few weeks... thanks,

Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533: pointless test ?

On Mon, Aug 22, 2016 at 03:07:44PM +0100, David Binderman wrote: > Hello there, > > linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]: > (style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always > true > > Source code is > > if

Re: [PATCH] Staging: rtl8723au: rtw_xmit: Fixed operators spacing style issues

On Tue, Aug 02, 2016 at 08:05:30PM +0200, Shiva Kerdel wrote: > Fixed spaces around operators to fix their coding style issues. > > Signed-off-by: Shiva Kerdel > --- > drivers/staging/rtl8723au/core/rtw_xmit.c | 24 > 1 file changed, 12 insertions(+), 12

Re: [PATCH v2 2/2] staging: wilc1000: fix error values in wilc_debugfs_init()

On Thu, Jun 23, 2016 at 01:36:18PM +0100, Luis de Bethencourt wrote: > If there was an error, returning -EINVAL is more appropriate than -1. > > Signed-off-by: Luis de Bethencourt > Reviewed-by: Julian Calaby > --- >

Re: [PATCH] fix infoleak in ioctl_cfg80211

On Tue, May 03, 2016 at 06:11:46PM -0400, Kangjie Lu wrote: > "mac" is an array allocated in stack without being initialized, > and will be sent out via "nla_put". The dump_station() is supposed > to initialize the mac address; otherwise, sensitive data in kernel > stack will be leaked. To fix

Re: [PATCH 525/525] Staging: Wilc1000: Fixed coding style ether_addr_copy

On Thu, Apr 07, 2016 at 03:07:15PM +0530, Shyam Saini wrote: > Fixed following warning detected by checkpatch.pl: > warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addressesare > __aligned(2) > > Signed-off-by: Shyam Saini > --- >

Re: [PATCH] Ensure that comments adhere to coding standard

On Sun, Apr 03, 2016 at 02:18:46PM -0400, mohammed.bil...@gmail.com wrote: > From: Mohammed Billoo > > Files in wilc1000 were modified to ensure that comments > adhere to standard specified by Documentation/CodingStyle > > Signed-off-by: Mohammed Billoo

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Sat, Mar 26, 2016 at 03:07:18PM -0300, Till Kamppeter wrote: > >If there's anything else I need to do here, becides try to find a > >co-mentor, please let me know. > > > > I am grateful if you could enter as co-mentor, especially if there is any > kernel project now which has only one mentor.

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Sat, Mar 26, 2016 at 11:25:32AM -0300, Till Kamppeter wrote: > Can you give me a list of all the other proposals which you considered not > worthwhile (and where we do not need to wait for another mentor's opinion) > so that I can mark them ignored? Please mark these as "ignored" because they

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Sat, Mar 26, 2016 at 11:25:32AM -0300, Till Kamppeter wrote: > On 03/26/2016 11:15 AM, Greg KH wrote: > >>Which one? > > > >This one: > > > > https://summerofcode.withgoogle.com/dashboard/organization/6564234674569216/proposal/6320691074826240/ >

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Fri, Mar 25, 2016 at 09:39:49PM -0300, Till Kamppeter wrote: > On 03/25/2016 09:18 PM, Greg KH wrote: > >On Fri, Mar 25, 2016 at 09:00:27PM -0300, Till Kamppeter wrote: > >>Sorry, seems that star and ignore can only be set by org admins. So please > >>click &quo

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Fri, Mar 25, 2016 at 09:00:27PM -0300, Till Kamppeter wrote: > On 03/25/2016 08:56 PM, Till Kamppeter wrote: > >I am taking care of the 5 OpenPrinting proposals, please take care of > >all the others, mark with IGNORE what you for sure do not want to mentor > >and mark with a star what you want

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Fri, Mar 25, 2016 at 08:56:58PM -0300, Till Kamppeter wrote: > On 03/25/2016 04:49 AM, Evgeny Novikov wrote: > >This student suggested two proposals that aren't good and likely the student > >isn't going to improve them. So I suggest to ignore them if Greg doesn't > >mind: > >Sandhya - IIO

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Fri, Mar 25, 2016 at 07:58:47PM -0300, Till Kamppeter wrote: > On 03/25/2016 02:23 PM, Greg KH wrote: > >I didn't see anywhere to "star" an application, > >why do some have that mark and others do not? > > You can click the start in the list of applicatio

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

On Fri, Mar 25, 2016 at 10:49:34AM +0300, Evgeny Novikov wrote: > Hi, > > I see briefly all proposals and suggest the following. > > Ignore definitely trash proposals for which we even can't expect anything > good: > ABHISHEK KUMAR SINGH - AUTOMATIC GUN FIRING USING ULTRASONIC RADAR - >

Re: Google Summer of Code 2016 - Many new applications

On Thu, Mar 24, 2016 at 02:39:55PM -0300, Till Kamppeter wrote: > Hi, > > tomorrow the student application period will end. Up to now we got 22 > applications, where many lokk interesting and some really strange. > > Most are for the kernel, many for LSB, and I had also some luck getting 3 > for

Re: rtl8xxxu 4.4.5(from f23): I get a panic adding a new device to the driver

On Thu, Mar 17, 2016 at 09:01:25PM +0100, poma wrote: > On 17.03.2016 19:02, Jes Sorensen wrote: > > Jes Sorensen writes: > >> Xose Vazquez Perez writes: > >>> Hi, > >>> > >>> If I do: > >>> # echo "0bda 8176" >

Re: [PATCH] ath10k: fix debugfs pktlog_filter write

On Thu, Mar 10, 2016 at 02:48:58PM +0530, ako...@qti.qualcomm.com wrote: > From: Anilkumar Kolli > > It is observed that, we are disabling the packet log if we write same > value to the pktlog_filter for the second time. Always enable pktlogs > on non zero filter. > >

Re: [PATCH 1/4] staging: wilc1000: move WILC_MULTICAST_TABLE_SIZE define to wilc_wlan_if.h file

On Fri, Feb 19, 2016 at 06:57:42PM +0900, Leo Kim wrote: > From: Chris Park > > This patch moves WILC_MULTICAST_TABLE_SIZE define to wilc_wlan_if.h file. > This define is used to three files(host_interface.c,host_interface.h, > linux_wlan.c) these files already include

Re: [PATCH 1/6] staging: wilc1000: removes wilc_dbg()

On Fri, Feb 19, 2016 at 05:37:07PM +0900, Leo Kim wrote: > This patch removes wilc_dbg function because it's not any more. > > Signed-off-by: Leo Kim > --- > drivers/staging/wilc1000/linux_wlan.c | 4 > drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 -- >

Re: [PATCH V2 01/24] staging: wilc1000: wilc_wlan.c: removes PRINT_ER

On Thu, Feb 18, 2016 at 08:30:01PM +0900, Leo Kim wrote: > This patches removes PRINT_ER that is unnecessary debug logs. > > Signed-off-by: Leo Kim > --- > drivers/staging/wilc1000/wilc_wlan.c | 2 -- > 1 file changed, 2 deletions(-) What changed in this series from v1? Why

Re: whitespace error in some of commits

On Tue, Feb 16, 2016 at 03:47:00PM +0900, Tony Cho wrote: > Hi Janani, > > I can find the whitespace errors in your commits which is already accepted in > staging-testing branch. Ick, my fault, I should have caught them before they were merged, sorry about that. > The commit number is

Re: [PATCH RESEND 40/70] staging: wilc1000: wilc_wlan.c: replaces PRINT_ER with netdev_err

On Thu, Feb 04, 2016 at 06:24:01PM +0900, Glen Lee wrote: > From: Leo Kim > > This patches replaces PRINT_ER with netdev_err. No, that's not what this patch does :( > Removes unnecessary debug logs as well. That's what this patch does. Please be more careful. I'm not

Re: [PATCH 5/8] staging: wilc1000: fix return type of wilc_send_config_pkt

On Fri, Feb 05, 2016 at 10:35:15AM +0900, Chaehyun Lim wrote: > wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return > value of wilc_wlan_cfg_get or wilc_wlan_cfg_set. > It is better to use int type to represent linux standard error code. > > Signed-off-by: Chaehyun Lim

Re: [PATCH] staging: wilc1000: Fix compilation error when CONFIG_PM disabled

On Fri, Feb 05, 2016 at 02:40:27PM +0900, Glen Lee wrote: > Commit 73584a40d748 ("staging: wilc1000: add ops resuem/suspend/wakeup in > cfg80211") causes following compilation error. This patch fixes this by > using suspend/resume under CONFIG_PM. > >

Re: [PATCH 05/12] staging: wilc1000: wilc_parse_network_info(): renames function variables

On Thu, Jan 28, 2016 at 04:13:39PM +0900, Leo Kim wrote: > This patch renames to avoid camelcase, changes follow are: > - pu8MsgBuffer to msg_buffer > - ppstrNetworkInfo to ret_network_info > > Signed-off-by: Leo Kim > --- > drivers/staging/wilc1000/coreconfigurator.c | 16

Re: [PATCH v2 1/2] staging: wilc1000: fix always return 0 error

On Thu, Dec 31, 2015 at 12:19:25AM +0530, Souptick Joarder wrote: > HI Glen, > > On Thu, Dec 24, 2015 at 11:32 AM, Glen Lee wrote: > > This patch fixes a bug that return always 0 so it fails every time. > > > > Fixes: c1af9db78950 ("staging: wilc1000: call linux_sdio_init

Re: [PATCH 1/7] staging: wilc1000: wilc_wfi_cfgoperations.c: replaces PRINT_ER with netdev_err

On Mon, Feb 01, 2016 at 11:11:19AM +0900, Leo Kim wrote: > This patches replaces PRINT_ER with netdev_err. > Removes unnecessary debug logs as well. > > Signed-off-by: Leo Kim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 86 > --- > 1 file

Re: [PATCH V2 15/26] staging: wilc1000: wilc_set_wfi_drv_handler: add mac index

On Mon, Jan 25, 2016 at 04:35:19PM +0900, Glen Lee wrote: > Firmware supports sta/ap concurrency so mac index will be passed to wilc. > Remove wilc_set_wfi_drv_handler in scan and connect functions, and call > the function in ndo_open which is wilc_mac_open. > WID_SET_DRV_HANDLER value has been

Re: [PATCH 1/6] staging: wilc1000: fix warnings for line over 80 characters

On Fri, Jan 29, 2016 at 03:51:33PM +0900, Leo Kim wrote: > From: Chris Park > > This patch fixes warnings reported by checkpatch.pl > for line over 80 characters > > Signed-off-by: Chris Park > Signed-off-by: Leo Kim This series

Re: [PATCH 04/13] staging: wilc1000: rename hWILCWFIDrv of wilc_priv structure

On Wed, Jan 27, 2016 at 11:50:28AM +0900, Glen Lee wrote: > From: Leo Kim > > This patch renames hWILCWFIDrv pointer variable of wilc_priv structure > to hif_drv to avoid camelcase. > > Signed-off-by: Leo Kim > Signed-off-by: Glen Lee

Re: [PATCH 01/26] staging: wilc1000: removes function 'wilc_dealloc_network_info()'

On Tue, Feb 02, 2016 at 09:02:11PM +0900, Leo Kim wrote: > This patch removes function 'wilc_dealloc_network_info()'. > Does not need this function which only free memory. > Therefore, this function is removed and changed directly with kfree. > > Signed-off-by: Leo Kim This

Re: Move wlan-ng out of staging?

On Thu, Jan 28, 2016 at 10:28:38AM +1100, Julian Calaby wrote: > Hi Greg, > > On Thu, Jan 28, 2016 at 10:07 AM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote: > >> Hi Glen, > >> > >>

Re: Move wlan-ng out of staging?

On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote: > Hi Glen, > > On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo wrote: > > Dan Carpenter writes: > > > >> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote: > >>> Hi All, >

Re: [PATCH V2 00/26] use unified firmware and add ops in cfg

On Mon, Jan 25, 2016 at 03:15:31PM +0200, Kalle Valo wrote: > Glen Lee writes: > > > This patch series contains > > > > * support suspend and resume functionality > > > > * use a

Re: [PATCH V2 00/26] use unified firmware and add ops in cfg

On Tue, Jan 26, 2016 at 11:44:30AM +0900, glen lee wrote: > > > On 2016년 01월 26일 02:21, Greg KH wrote: > >On Mon, Jan 25, 2016 at 03:15:31PM +0200, Kalle Valo wrote: > >>Glen Lee <glen@atmel.com> writes: > >> > >>>This patch series conta

Re: [PATCH 3/26] staging: rtl8192e: Replace uses of obsolete blkcipher and hash

On Sun, Jan 24, 2016 at 09:16:26PM +0800, Herbert Xu wrote: > The interfaces blkcipher and hash are obsolete. This patch replaces > them with skcipher and ahash respectively. > > Signed-off-by: Herbert Xu > --- > > drivers/staging/rtl8192e/rtllib_crypt_tkip.c |

Re: [PATCH 6/26] staging: rtl8192u: Use skcipher and ahash

On Sun, Jan 24, 2016 at 09:16:57PM +0800, Herbert Xu wrote: > This patch replaces uses of blkcipher with skcipher, and the long > obsolete hash interface with ahash. > > Signed-off-by: Herbert Xu > --- > >

Re: [PATCH 04/26] staging: wilc1000: add sdio resume/suspend

On Fri, Jan 22, 2016 at 05:10:39PM +0900, glen lee wrote: > > On 2016년 01월 22일 16:44, Dan Carpenter wrote: > >You should be running checkpatch.pl on your patches. > > It's my mistake. I will run checkpatch.pl on the patch series. > Thank you your advise. Please do so and resend this series,

Re: [PATCH RESEND 03/46] staging: wilc1000: rename index to tcp_pending_ack_idx

On Mon, Dec 21, 2015 at 02:18:07PM +0900, Glen Lee wrote: > This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since > this name could be confused index of txq_entry_t. It is index of tcp pending > ack. > > It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da You didn't

Re: [PATCH 1/4] staging: wilc1000: remove define COMPLEMENT_BOOT

On Thu, Nov 19, 2015 at 11:05:58AM +0900, Glen Lee wrote: > This patch removes define COMPLEMENT_BOOT in Makefile. The feature was removed > by the following commit but the define was not removed. So remove completely. > > b46d68825c2d3af70ad18b53dfed6516e393b7fa Please fix this up and resend

Re: [PATCH] staging: wilc1000: fix bug in sdio/spi

On Thu, Nov 12, 2015 at 11:35:26AM +0900, Glen Lee wrote: > sdio_init and wilc_spi_init always return error, so it fails everytime. > Fix this by removing else statement. > > This fixes c1af9db78950a778ec18343c5c5a6d4cfbf58a61, > bacd388547f55eb415ce266c8723cc6f1281a25d Please fix up how these

Re: [PATCH] staging: wilc1000: remove new line around else and braces

On Sun, Nov 08, 2015 at 09:18:48PM +0200, Panayiotis Tembriotis wrote: > Remove excess new line characters as suggested by checkpatch.pl: > ERROR: else should follow close brace '}' > ERROR: that open brace { should be on the previous line > > Signed-off-by: Panayiotis Tembriotis

Re: [PATCH 1/1] staging: Fix bitshifts by wrong offsets in wilc1000/host_interface.c

On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote: > struct set_multicast uses (implicitly) sizeof(bool) to determine how many > bytes to copy in > Handle_SetMulticastFilter. Since that is implementation defined, it triggered > sparse to > rightfully complain about shifting a

Re: [PATCH 3/4] staging: wilc1000: Fix typo in linux_wlan.c

On Mon, Nov 23, 2015 at 10:41:19PM +0900, Masanari Iida wrote: > This patch fix some spelling typo in wilc1000.c. > > Signed-off-by: Masanari Iida > Acked-by: Randy Dunlap > --- > drivers/staging/wilc1000/linux_wlan.c | 16 > 1

Re: [PATCH 2/5] staging: wilc1000: remove unneeded function

On Thu, Nov 26, 2015 at 02:04:00PM +0900, Glen Lee wrote: > wilc_spi_init in linux_wlan_spi.c is unneeded. It just return true. Rename > _wilc_spi_init in wlan_spi.c to wilc_spi_init. > > Signed-off-by: Glen Lee Series did not apply :( -- To unsubscribe from this list: send

Re: [PATCH 3/6] staging: wilc1000: wilc_wlan.c: remove hif_func of wilc_wlan_dev_t

On Fri, Nov 20, 2015 at 04:56:33PM +0900, Glen Lee wrote: > hif_func of wilc_wlan_dev_t is duplicate because we have same struct > wilc_hif_func ops of struct wilc which is available in wilc_wlan.c. > Rename ops of struct wilc with hif_func and remove hif_func of > wilc_wlan_dev_t, > and use

Re: [PATCH 1/3] staging: wilc1000: move perInterface_wlan_t to wilc_vif

On Fri, Nov 27, 2015 at 03:50:31PM +0900, Glen Lee wrote: > perInterface_wlan_t and wilc_vif are all about interface control informations. > We will combine those two structures and maintain as one network interface > control information. > Move all the members of perInterface_wlan_t to wilc_vif

Re: [PATCH 1/4] staging: wilc1000: linux_wlan_spi.c: return linux error value

On Wed, Nov 25, 2015 at 06:35:26PM +0900, Glen Lee wrote: > return linux error value instead of 0 or 1 and use -EINVAL. Related codes > also changed together. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/linux_wlan_spi.c | 14 +++--- >

Re: [PATCH 01/10] staging: wilc1000: sdio/spi: use device print api instead of custom one

On Mon, Nov 23, 2015 at 06:47:59PM +0900, Glen Lee wrote: > This patch use device print api instead of driver defined print. Remove > varialbe dPrint as well. String "[wilc sdio]" and "[wilc spi]" are also > removed > from all the print statment if exist because it shows which device the message

Re: [PATCH 01/12] staging: wilc1000: pass vif to hostIFthread

On Mon, Dec 14, 2015 at 02:46:52PM +0900, Glen Lee wrote: > We will pass vif, which is currently being used as net_device, instead of > hif_dev. This is the first step to use index of vif to pass to the driver. > Add new argument vif to all the functions that send message to hostIFthread > and >

Re: [PATCH 3/4] staging: wilc1000: rename index to tcp_pending_ack_idx

On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote: > > > On 2015년 11월 19일 15:23, Dan Carpenter wrote: > >On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote: > >>This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx > >>since > >>this name could be confused index

Re: patch "ath10k: drop probe responses when too many are queued" added to staging-testing

On Sat, Nov 07, 2015 at 10:43:52AM +0200, Kalle Valo wrote: > Hi Greg, > > writes: > > > This is a note to let you know that I've just added the patch titled > > > > ath10k: drop probe responses when too many are queued > > > > to my staging git tree which can be

Re: [PATCH 01/26] staging: wilc1000: separate hif_sdio and hif_spi into different module

On Fri, Nov 06, 2015 at 02:45:22PM -0800, Greg KH wrote: > On Fri, Nov 06, 2015 at 06:39:58PM +0900, Glen Lee wrote: > > hif_sdio and hif_spi objects are compiled all the time even though one of > > SPI > > or SDIO is selected. This patch separates hif_sdio and hif_sp

Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error

On Sat, Nov 07, 2015 at 03:29:23AM +0530, Punit Vara wrote: > This patch is to the linux_wlan.c file that fixes declaration of *wilc > to remove following error while building it. > > make drivers/staging/wilc1000/linux_wlan.o > drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘wilc’

Re: [PATCH 01/26] staging: wilc1000: separate hif_sdio and hif_spi into different module

On Fri, Nov 06, 2015 at 06:39:58PM +0900, Glen Lee wrote: > hif_sdio and hif_spi objects are compiled all the time even though one of SPI > or SDIO is selected. This patch separates hif_sdio and hif_spi into different > modules using ifdef define. > After rework SPI and SDIO modules with only one

Re: [PATCH V2 03/17] staging: wilc1000: wilc_wlan_cfg_get: add argument struct net_device

On Fri, Oct 30, 2015 at 06:47:09PM +0900, Glen Lee wrote: > Adds argument struct net_device and use netdev private data member wilc > instead of g_linux_wlan, pass dev to the functions as well. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/coreconfigurator.c |

Re: [PATCH V2 04/17] staging: wilc1000: wilc_wlan_cfg_set: add argument struct net_device

On Fri, Oct 30, 2015 at 06:47:10PM +0900, Glen Lee wrote: > This patch adds new argument net_device and use netdev private data member > wilc instead of g_linux_wlan, pass dev to the functions also. > > Signed-off-by: Glen Lee > --- >

Re: [PATCH RESEND 12/12] staging: wilc1000: add argument wilc and use it instead of g_linux_wlan

On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote: > This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52 > , and use it instead of g_linux_wlan. Pass wilc to the functions as well. > The void type wilc will be changed with struct wilc when SDIO and SPI > modules are

Re: [PATCH V2 01/12] staging: wilc1000: fix return type of host_int_del_beacon

On Fri, Oct 30, 2015 at 08:17:37AM +0900, Chaehyun Lim wrote: > This patch changes return type of host_int_del_beacon from s32 to int. > The result variable gets return value from wilc_mq_send that has return > type of int. It should be changed return type of this function as well > as data type

Re: [PATCH 1/5] staging: wilc1000: change enum variable name with lower case

On Tue, Nov 03, 2015 at 04:20:58PM +0900, Glen Lee wrote: > This patch changes WID_TYPE with wid_type which is preferred style. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/coreconfigurator.h | 2 +- > drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- > 2

Re: [PATCH RESEND 11/12] staging: wilc1000: rename os_context to wilc

On Thu, Oct 29, 2015 at 12:18:51PM +0900, Glen Lee wrote: > This patch rename os_context to wilc because it is used as struct wilc and > move os_private from struct wilc_wlan_os_context_t to struct wilc_wlan_inp_t. > Finally, delete wilc_wlan_os_context_t. > > Signed-off-by: Glen Lee

Re: [PATCH V2 02/17] staging: wilc1000: send_config_pkt: add argument struct net_device

On Fri, Oct 30, 2015 at 06:47:08PM +0900, Glen Lee wrote: > This patch adds new argument struct net_device and pass dev to the function > as well. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/coreconfigurator.c | 3 +- >

Re: [PATCH 01/38] staging: wilc1000: rename pu8IPAddr of fuction Handle_set_IPAddress

On Mon, Nov 02, 2015 at 05:50:44PM +0900, Glen Lee wrote: > From: Leo Kim > > This patch renames pu8IPAddr of fuction Handle_set_IPAddress to ip_addr > to avoid CamelCase naming convention. > > Signed-off-by: Leo Kim > Signed-off-by: Glen Lee

Re: [PATCH V2 04/17] staging: wilc1000: wilc_wlan_cfg_set: add argument struct net_device

On Thu, Nov 05, 2015 at 10:39:59AM +0900, glen lee wrote: > >>+int wilc_wlan_cfg_set(struct net_device *dev, int start, u32 wid, u8 > >>*buffer, > >>+ u32 buffer_size, int commit, u32 drvHandler) > >> { > >>wilc_wlan_dev_t *p = _wlan; > >>u32 offset; > >>int ret_size;

Re: [PATCH RESEND 12/12] staging: wilc1000: add argument wilc and use it instead of g_linux_wlan

On Thu, Nov 05, 2015 at 11:22:47AM +0900, glen lee wrote: > > On 2015년 11월 05일 05:41, Greg KH wrote: > >On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote: > >>This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52 > >>, and use it inst

Re: [PATCH] Revert "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

On Tue, Nov 03, 2015 at 07:05:11PM +0900, Glen Lee wrote: > The addresses are not properly aglined for using ether_addr_copy function. > I revert this as author agree to drop this patch. > > This reverts commit d4622f68db8095dd54179e3134e97812727f6b89. > --- >

Re: [PATCH 04/12] staging: wilc1000: wilc_wlan_txq_add_mgmt_pkt: add new argument dev

On Wed, Oct 28, 2015 at 04:48:20PM +0900, Glen Lee wrote: > This patch adds new argument struct net_device *dev and pass argument > struct net_device to the function. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/linux_mon.c | 2 +- >

Re: [PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()

On Tue, Oct 27, 2015 at 10:51:39PM +0530, Punit Vara wrote: > This patch is to the host_interface.c that fixes up following > warning by checkpatch: > > -prefer eth_broadcast_addr() over memset() > > Signed-off-by: Punit Vara > --- >

Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

On Mon, Oct 26, 2015 at 11:08:43AM +0900, glen lee wrote: > > > On 2015년 10월 25일 10:29, Greg KH wrote: > >On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: > >>Use netdev private member wilc instead of g_linux_wlan and Change argument > >>

Re: [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()

On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote: > This patch is to the host_interface.c that fixes up following > warning by checkpatch.pl: > > -Prefer eth_broadcast_addr() over memset() > > Signed-off-by: Punit Vara > --- >

Re: [PATCH] staging: wilc1000: return -ENOMEM when kmalloc failed

On Thu, Oct 22, 2015 at 12:07:36AM +0100, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify that > a buffer allocation failed. > > Fixes smatch warning and similars: > drivers/staging/wilc1000/host_interface.c:1782 Handle_Key() warn: > returning

Re: [PATCH 01/19] staging/wilc1000: remove unused functions

On Wed, Oct 21, 2015 at 12:47:20AM +0200, Arnd Bergmann wrote: > A number of symbols in the wilc1000 driver are completely unused > and can be removed. > This includes two variables that are only written but not read. > > Signed-off-by: Arnd Bergmann Due to other patches that

Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: > Use netdev private member wilc instead of g_linux_wlan and Change argument > wilc > with dev in the function request_threaded_irq to pass back to handler > the function isr_uh_routine. > > Signed-off-by: Glen Lee >

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

On Mon, Oct 26, 2015 at 01:29:42AM +0530, punit vara wrote: > On Mon, Oct 26, 2015 at 1:01 AM, punit vara <punitv...@gmail.com> wrote: > > On Mon, Oct 26, 2015 at 12:42 AM, Greg KH <gre...@linuxfoundation.org> > > wrote: > >> On Sun, Oct 25, 2015 a

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote: > This patch is to the wilc_wfi_cfgoperations.c file that fixes up > following error reported by coccicheck: > > ERROR: reference preceded by free on line 1219 > > For (params->seq_len) <= 0 memory is already freed when >

Re: [PATCH 2/3] Staging: wilc1000: Remove comparision of field address to NULL

On Sun, Oct 25, 2015 at 04:01:24AM +0530, Punit Vara wrote: > This is patch to the linux_wlan file that fixes up following error > reported by coccicheck : > > ERROR: test of a variable/field address > > Signed-off-by: Punit Vara > --- >

Re: [PATCH 3.10-3.18] Driver, staging rtl8712, add support for sitecom WLA2100

On Sun, Oct 18, 2015 at 07:58:30PM +0200, Frans van de Wiel wrote: > The staging driver rtl8712 lacks support for dongles based on sitecom > WLA2100. > The current driver doesn't contain the usb id for this device, this patch > add it. > > reported by: Frans van de Wiel >

Re: [PATCH V2] staging: wilc1000: wilc_msgqueue.c : remove the goto ERRORHANDER

On Wed, Oct 14, 2015 at 05:52:55PM +0900, Tony Cho wrote: > > > On 2015년 10월 14일 17:32, Mike Rapoport wrote: > >On Wed, Oct 14, 2015 at 02:55:43PM +0900, Tony Cho wrote: > >>From: Leo Kim > >> > >>This patch removes goto ERRORHANDER and the result variable in wilc_mq_send. >

Re: [PATCH V2 01/40] staging: wilc1000: rename ssidLen of struct join_bss_param

On Fri, Oct 16, 2015 at 01:37:31PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch renames ssidLen of struct join_bss_param to ssid_len > to avoid CamelCase naming convention. > > Signed-off-by: Leo Kim > Signed-off-by: Tony Cho

Re: [PATCH 35/40] staging: wilc1000: rename variable s32Error

On Thu, Oct 15, 2015 at 01:25:16PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch renames variable s32Error to result > to avoid CamelCase naming convention. > > Signed-off-by: Leo Kim > Signed-off-by: Tony Cho > --- >

Re: [PATCH 03/16] staging: wilc1000: rename g_linux_wlan to wl

On Wed, Oct 14, 2015 at 08:46:31PM +0900, Tony Cho wrote: > This patch renames g_linux_wlan to wl. Why? What's wrong with g_linux_wlan? You will need to delete this entire variable soon anyway, might as well leave it alone until then. thanks, greg k-h -- To unsubscribe from this list: send

<    1   2   3   4   >