[PATCH 070/113] rtl8xxxu: Setup RX aggregation

From: Jes Sorensen <jes.soren...@redhat.com> This initializes RX DMA aggregation on 8723bu. We should do this for all parts eventually, and also init TX aggregation. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8x

[PATCH 089/113] rtl8xxxu: Handle 40 byte TX descriptors for rtl8723bu

From: Jes Sorensen <jes.soren...@redhat.com> Note the descriptor checksum is still only calculated over the initial 32 bytes of the descriptor, ignoring the last 8 bytes of the descriptor. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxx

[PATCH 083/113] rtl8xxxu: Bump TX power arrays to handle larger channel groups

From: Jes Sorensen <jes.soren...@redhat.com> Newer generation chips have more channels groups. In order to carry the larger arrays in common structures, bump the array sizes to match. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl

[PATCH 093/113] rtl8xxxu: Set the correct TX descriptor bits for agg and break on 8723b

From: Jes Sorensen <jes.soren...@redhat.com> Fixup victim of the relocated bits for AGG_ENABLE/AGG_BREAK in the 40 byte TX descriptor Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 19 --- 1 file

[PATCH 041/113] rtl8xxxu: rtl8192eu: Map out EFUSE TX power area

-by: Jakub Sitnicki <jsitni...@gmail.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 10 -- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 22 +- 2 files changed, 17 insertions(+), 15 de

[PATCH 033/113] rtl8xxxu: Do not overwrite rtl8xxxu_debug for untested chips

From: Jes Sorensen <jes.soren...@redhat.com> Fix a silly bug where the debug level was overwritten rather than amended for untested chips. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 ins

[PATCH 039/113] rtl8xxxu: Do LC calibration before IQK calibration

From: Jes Sorensen <jes.soren...@redhat.com> This matches the flow of the vendor driver for newer hardware, and doesn't seem to cause issues for the older parts. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++-- 1

[PATCH 106/113] rtl8xxxu: convert rtl8723bu_init_bt() into rtl8723b_enable_rf()

From: Jes Sorensen <jes.soren...@redhat.com> rtl8723bu_init_bt() is effectively the function enabling RF, so name it appropriately. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 11 +-- drivers/net/wireless/real

[PATCH 011/113] rtl8xxxu: Init REG_HIMR[01] for 8192eu parts

From: Jes Sorensen <jes.soren...@redhat.com> The newer generation chips have different interrupt registers. Initialize this correct registers on 8192eu. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 3 +++ drivers/

[PATCH 040/113] rtl8xxxu: Remove backing up certain registers, which was never used

From: Jes Sorensen <jes.soren...@redhat.com> This was inspired by the vendor driver, but in the end never used for anything. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 14 -- drivers/net/wireless/real

[PATCH 036/113] rtl8xxxu: Add a couple of new register definitions

From: Jes Sorensen <jes.soren...@redhat.com> This adds some additional register definitions for 8723bu, as well as a bit define for USB RXDMA aggregation in REG_RXDMA_AGG_PG_TH. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxx

[PATCH 017/113] rtl8xxxu: Add rtl8723bu_radioa_1t_init_table

From: Jes Sorensen <jes.soren...@redhat.com> Add 8723bu 1T radio init table. The vendor driver indicates that some registers need special treatment for TFBGA90, TFBGA80, and TFBGA79 packaging. However the vendor driver never actually checks the package type, so just stick to default value

[PATCH 110/113] rtl8xxxu: Flush FIFO before powering down devices

From: Jes Sorensen <jes.soren...@redhat.com> This should help when reloading the driver for 8723bu devices Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 34 ++ .../net/wireless/realtek/rtl8xxxu/rtl

[PATCH 035/113] rtl8xxxu: Make rtl8xxxu_add_path_on() use device specific init values

From: Jes Sorensen <jes.soren...@redhat.com> rtl8192cu/rtl8188cu/rtl8723au use the same values, but 8723bu and 8192eu have their own. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 24 +--- drivers/

[PATCH 034/113] rtl8xxxu: Use correct formatting type to print sizeof()

From: Jes Sorensen <jes.soren...@redhat.com> Usual gcc i386 issue reported by kbuildbot Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wire

[PATCH 109/113] rtl8xxxu: Implement device specific power_off function

From: Jes Sorensen <jes.soren...@redhat.com> Implment 8723bu specific device power down, and make power_off() a fileops function. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 98 +- drivers/

[PATCH 006/113] rtl8xxxu: Add rtl8xxxu_auto_llt_table()

From: Jes Sorensen <jes.soren...@redhat.com> Newer chips can auto load the LLT table, it is no longer necessary to build it manually in the driver. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 33 +++

[PATCH 004/113] rtl8xxxu: Add rtl8192eu_nic.bin to the MODULE_FIRMWARE list

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/real

[PATCH 003/113] rtl8xxxu: Use 1024 byte block loads for 8192eu firmware

From: Jes Sorensen <jes.soren...@redhat.com> The rtl8192eu can handle 1024 byte block writes, unlike it's predecessors (8192cu/8188cu). Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 insertion(+)

Re: alfa awus036nhr v2 and module rtl8xxxu

Larry Finger <larry.fin...@lwfinger.net> writes: > On 02/28/2016 05:01 PM, Jes Sorensen wrote: >> Larry Finger <larry.fin...@lwfinger.net> writes: >>> On 02/10/2016 06:01 AM, dsadsa sadsad wrote: >>>> So do i have to patch and recompile or not? >>>

Re: [PATCH 03/28] rtl8xxxu: If fw running in RAM, reset the 8051 before trying to download a new one

Kalle Valo <kv...@codeaurora.org> writes: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> > > No empty commit logs, please. And this patch even has a to

Re: [PATCH] staging: rtl8723au: use list_first_entry*

; drivers/staging/rtl8723au/core/rtw_xmit.c | 26 +--- > 2 files changed, 22 insertions(+), 53 deletions(-) This looks fine to me. When these changes gets large, it may be better to break them down into multiple patches as it's easier to debug if there is a bug somewhere. Acked-by: J

Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning

Geliang Tang <geliangt...@163.com> writes: > On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote: >> kbuild test robot <l...@intel.com> writes: >> > All errors (new ones prefixed by >>): >> > >> >drivers/staging/rtl8723au/core/rtw_

Re: [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*()

kbuild test robot writes: > Hi Geliang, > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.5-rc4 next-20160217] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: >

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

Julian Calaby writes: > Hi Geliang, > > On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang wrote: >> This patch cleans whitespaces and blank lines surrounding >> list_for_each_entry*(). > > It does a lot more than this, including: > - Removing some

Re: [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes

Changes in v2: > - drop the coding style fixing in v1. > --- > drivers/staging/rtl8723au/core/rtw_recv.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) I assume this requires patch 1/3 applied first? Acked-by: Jes Sorensen <jes.soren...@redhat.com> > >

Re: [PATCH v3 1/3] staging: rtl8723au: use list_for_each_entry*()

Geliang Tang writes: > Use list_for_each_entry*() instead of list_for_each*() to simplify > the code. > > Signed-off-by: Geliang Tang > --- > Changes in v3: > - split it into three patches. > Changes in v2: > - drop the coding style fixing in v1. > ---

Re: alfa awus036nhr v2 and module rtl8xxxu

Jes Sorensen <jes.soren...@redhat.com> writes: > Larry Finger <larry.fin...@lwfinger.net> writes: >> On 02/04/2016 10:45 AM, Jes Sorensen wrote: >>> Drunk Cat <natserv...@gmail.com> writes: >>>> problem: it does not connect to any wifi netw

Re: alfa awus036nhr v2 and module rtl8xxxu

Larry Finger <larry.fin...@lwfinger.net> writes: > On 02/09/2016 03:00 PM, Jes Sorensen wrote: >> Jes Sorensen <jes.soren...@redhat.com> writes: >>> Larry Finger <larry.fin...@lwfinger.net> writes: >>>> I can confirm what Drunk Cat sees. There

Re: alfa awus036nhr v2 and module rtl8xxxu

Drunk Cat writes: > problem: it does not connect to any wifi network you can see the time out on > dmesg > > >>lsusb > > Bus 002 Device 007: ID 0bda:817f Realtek Semiconductor Corp. RTL8188RU > 802.11n WLAN Adapter > >>iwconfig > wlp0s20u1 IEEE 802.11bgn ESSID:off/any

Re: alfa awus036nhr v2 and module rtl8xxxu

Larry Finger <larry.fin...@lwfinger.net> writes: > On 02/04/2016 10:45 AM, Jes Sorensen wrote: >> Drunk Cat <natserv...@gmail.com> writes: >>> problem: it does not connect to any wifi network you can see the time out on >>> dmesg >>> >>> &g

[PATCH 25/28] rtl8xxxu: Remove unused len/cnt variables from rtl8xxxu_rx_complete()

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/

[PATCH 16/28] rtl8xxxu: Fix cosmetics to quiet down checkpatch police

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/

[PATCH 18/28] rtl8xxxu: Document REG_RXFLTMAP registers

From: Bruno Randolf <b...@einfach.org> Add comments describing how REG_RXFLTMAP0, REG_RXFLTMAP1 and REG_RXFLTMAP2 work. Signed-off-by: Bruno Randolf <b...@einfach.org> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- .../net/wireless/realtek/rtl8xxxu/rtl

[PATCH 14/28] rtl8xxxu: Remove unused clutter for handling recursive calls to rtl8xxxu_init_device()

From: Jes Sorensen <jes.soren...@redhat.com> This was a leftover from the vendor driver that was never utilized. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 12 +--- drivers/net/wireless/realtek/rtl8xxxu/rtl

[PATCH 26/28] rtl8xxxu: Do not mask RF registers to 6 bits

From: Jes Sorensen <jes.soren...@redhat.com> Newer chips have RF registers beyond the original 0x3f address. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/

[PATCH 27/28] rtl8xxxu: Make device_init kludge 8723au only

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/r

[PATCH 21/28] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

reception based on the association state. Signed-off-by: Bruno Randolf <b...@einfach.org> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/

[PATCH 28/28] rtl8xxxu: Add missing bit define for REG_APS_FSMCO

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h b/drivers/net/wire

[PATCH 19/28] rtl8xxxu: Remove duplicate USB ID

From: Jes Sorensen <jes.soren...@redhat.com> Reported-by: Xose Vazquez Perez <xose.vazq...@gmail.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ne

[PATCH 07/28] rtl8xxxu: Add more RCR bits

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xx

[PATCH 09/28] rtl8xxxu: Check return value of kmemdup()

From: Tobias Klauser <tklau...@distanz.ch> In rtl8xxxu_load_firmware() check the return value of kmemdup() and error out with -ENOMEM in case of NULL to prevent a NULL pointer dereference. Signed-off-by: Tobias Klauser <tklau...@distanz.ch> Signed-off-by: Jes Sorensen <jes.sore

[PATCH 11/28] rtl8xxxu: Add definitions for antenna selection registers for 8723BU

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h b/drivers/

[PATCH 00/28] rtl8xxxu updates and fixes

From: Jes Sorensen <jes.soren...@redhat.com> Hi, Please find included a smaller patchset for the rtl8xxxu driver. It includes fixes from Bruno Randolf for monitor mode support, Jakub Sitnicki (I have a few more patches pending from Jakub), and Tobias Klauser. It also includes a few

[PATCH 06/28] rtl8xxxu: Add REG_TX_REPORT_* defines

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h b/drivers/net/wire

[PATCH 02/28] rtl8xxxu: rtl8xxxu_download_firmware(): Cosmetic cleanups

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/r

[PATCH 03/28] rtl8xxxu: If fw running in RAM, reset the 8051 before trying to download a new one

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/r

[PATCH 05/28] rtl8xxxu: Define SYS_CFG_SW_OFFLOAD_EN

From: Jes Sorensen <jes.soren...@redhat.com> This is needed for chips with IOL support. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/real

[PATCH 12/28] rtl8xxxu: Add mbox extension register definitions for 8723B

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h b/drivers/

[PATCH 04/28] rtl8xxxu: Add RQPN_[NE]PQ_SHIFT values

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h b/drivers/net/wire

[PATCH 10/28] rtl8xxxu: Implement rtl8xxxu_reset_8051()

From: Jes Sorensen <jes.soren...@redhat.com> We need to reset the 8051 in order for it to launch the fw on the rtl8192eu. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 38 1 file changed, 2

[PATCH 20/28] rtl8xxxu: Fix 80 character per line issue

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b

[PATCH 13/28] rtl8xxxu: Add REG_OFDM0_RX_D_SYNC_PATH definitions

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h b/drivers/

[PATCH 08/28] rtl8xxxu: Fix typo in Kconfig help text

From: Tobias Klauser <tklau...@distanz.ch> Fix spelling of "benefits". Signed-off-by: Tobias Klauser <tklau...@distanz.ch> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/Kconfig | 2 +- 1 file changed, 1 insertion(+

[PATCH 23/28] rtl8xxxu: Set correct bit to reset MCU IO wrapper

From: Jes Sorensen <jes.soren...@redhat.com> All chips, except for 8812 require BIT(0) for resetting the MCU IO wrapper. 8723b requires a more complicated reset sequence, so it will need a custom reset function. Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/

[PATCH 01/28] rtl8xxxu: Minor cleanup to rtl8xxxu_download_firmware()

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/

[PATCH 15/28] rtl8xxxu: Use REG_EFUSE_TEST register only on multifunctional devices

From: Jakub Sitnicki <jsitni...@gmail.com> rtl8192cu driver doesn't read/write the REG_EFUSE_TEST register. Neither does the rtl8188eu driver. Do it only for multifunc devices RTL8723AU/RTL8723BU. Signed-off-by: Jakub Sitnicki <jsitni...@gmail.com> Signed-off-by: Jes Sorense

[PATCH 24/28] rtl8xxxu: Remove unused mgmt variable from rtl8xxxu_rx_complete()

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/real

[PATCH 22/28] rtl8xxxu: rtl8xxxu_set_linktype(): Be consistent aboutregister size REG_MSR

From: Jes Sorensen <jes.soren...@redhat.com> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/

[PATCH 17/28] rtl8xxxu: Enable monitor mode by handling filters

ed-off-by: Bruno Randolf <b...@einfach.org> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 56 +++- 1 file changed, 45 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxx

Re: [PATCH v2] staging: rtl8723au: use list_for_each_entry*()

Geliang Tang writes: > Use list_for_each_entry*() instead of list_for_each*() to simplify > the code. > > Signed-off-by: Geliang Tang > --- > Changes in v2: > - drop the coding style fixing in v1. > --- > drivers/staging/rtl8723au/core/rtw_ap.c

rtl8xxxu updates - inital rtl8723bu/rtl8192eu support

Hi, For anyone interested in the rtl8xxxu driver, then I just pushed code which can handle rtl8723bu and rtl8192eu into the repository. In particular the rtl8192eu support is still very experimental. It's all in the rtl8xxxu-nextgen branch for now. Cheers, Jes -- To unsubscribe from this list:

Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

Joe Perches <j...@perches.com> writes: > On Sun, 2016-01-31 at 09:36 -0500, Jes Sorensen wrote: >> Rakhi Sharma <rakhish1...@gmail.com> writes: >> > Fixed the space and brace coding style error. >> > ERROR: space required before that '=' >> > ERROR:

Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

Joe Perches <j...@perches.com> writes: > On Mon, 2016-02-01 at 07:29 -0500, Jes Sorensen wrote: >> Joe Perches <j...@perches.com> writes: > [] >> > so this could be transformed into something like: >> > >> > int rtw_get_bit_value_from_ieee_va

Re: [PATCH] staging: rtl8723au: use list_for_each_entry*()

Geliang Tang writes: > Use list_for_each_entry*() instead of list_for_each*() to simplify > the code. Fix coding style by the way. > > Signed-off-by: Geliang Tang > --- > drivers/staging/rtl8723au/core/rtw_ap.c | 166 > --

Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

Rakhi Sharma writes: > Fixed the space and brace coding style error. > ERROR: space required before that '=' > ERROR: that open brace { should be on the previous line. > > Signed-off-by: Rakhi Sharma > --- >

Re: [PATCH v2] staging: rtl8723au: Fixes unnecessary return warning

Bhaktipriya Shridhar writes: > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. > WARNING: void function return statements are not generally useful > > Signed-off-by: Bhaktipriya Shridhar > --- > Changes in v2: >- Removed the

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Bhaktipriya Shridhar writes: > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. > WARNING: void function return statements are not generally useful > > Signed-off-by: Bhaktipriya Shridhar > --- >

Re: [PATCH] staging: rtl8723au: use %pM and %ph formatting

8723au/core/rtw_recv.c | 32 > +- > .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 24 > drivers/staging/rtl8723au/hal/usb_halinit.c| 6 ++-- > 3 files changed, 15 insertions(+), 47 deletions(-) Looks fine to me. Acked-by: Jes Sorensen

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

Julian Calaby writes: > Hi Sven, > > On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote: >> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> index 1662c03c..57f5941 100644 >> ---

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

Sven Dziadek writes: > Remove byte order conversions. > Conversion is already done in usb_ops_linux.c when accessing usb port. > The deleted lines convert to little-endian and then call FillH2CCmd to > convert back. Additionally, they are applied to wrong types and > process

Re: [PATCH] enable setting MAC address for r8723au

Daniel Lenski <dlen...@gmail.com> writes: > On Wed, Dec 23, 2015 at 3:18 AM, Jes Sorensen <jes.soren...@redhat.com> wrote: >> Daniel Lenski <dlen...@gmail.com> writes: >> In addition, do *not* overwrite the eeprompriv.mac_addr - that struct is >> a cle

Re: [PATCH] enable setting MAC address for r8723au

Daniel Lenski writes: > On Mon, Dec 21, 2015 at 9:53 AM, Larry Finger > wrote: >> On 12/20/2015 08:28 PM, Dan Lenski wrote: >>> >>> Signed-off-by: Dan Lenski >> >> >> The commit message should be in this patch rather than in the

Re: [PATCH] staging: rtl8723au: change parameter type in rtl8723a_set_rssi_cmd declaration

drivengro...@gmail.com writes: > From: Anatoly Stepanov > > Previosly the function had the following prototype: > int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u8 *param) > > My suggestion here is to modify the prototype this way: > int

Re: [PATCH] staging: rtl8723au: use proper typecast in assignment

Anatoly Stepanov writes: > This resolves the following Sparse warning: > "incorrect type in assignment (different base types)" > > Signed-off-by: Anatoly Stepanov > --- > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +- > 1 file changed, 1

Re: [PATCH v7] Add new mac80211 driver mwlwifi.

David Lin writes: > This patch provides the mwlwifi driver for Marvell 8863, 8864 and 8897 > chipsets. > This driver was developed as part of the openwrt.org project to support > Linksys WRT1900AC and is maintained on https://github.com/kaloz/mwlwifi. > > The mwlwifi driver

Re: [PATCH] rtl8xxxu: rtl8192eu: Map out EFUSE TX power area

Jakub Sitnicki writes: > TX power values are laid out differently in EFUSE found in RTL8192EU & > RTL8188EU devices. TX power indices and differences for each RF path > are not interleaved (A, B, A, B), as in other chips, but follow one > another (A, B, C, D). > >

Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

Larry Finger <larry.fin...@lwfinger.net> writes: > On 10/23/2015 03:31 PM, Jes Sorensen wrote: >> Bruno Randolf <b...@einfach.org> writes: >>> On 10/22/2015 02:42 PM, Jes Sorensen wrote: >>>> Making things work against random kernel versions of

Re: [RFC 08/16] rtl8xxxu: Extract TX power fields from struct rtl8xxu_priv

Jakub Sitnicki <jsitni...@gmail.com> writes: > On Wed, Oct 21, 2015 at 03:58 AM CEST, Jes Sorensen > <jes.soren...@redhat.com> wrote: >> Jakub Sitnicki <jsitni...@gmail.com> writes: >>> Signed-off-by: Jakub Sitnicki <jsitni...@gmail.com> >&

Re: [RFC 16/16] rtl8xxxu: rtl8188eu: Implement parse_efuse()

Jakub Sitnicki <jsitni...@gmail.com> writes: > On Wed, Oct 21, 2015 at 04:15 AM CEST, Jes Sorensen > <jes.soren...@redhat.com> wrote: >> Jakub Sitnicki <jsitni...@gmail.com> writes: >>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h >

Re: [PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation

n: curly braces intended? > > Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> > --- > drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jes Sorensen <jes.soren...@redhat.com> > > diff --git a/dr

Re: [RFC 05/16] rtl8xxxu: Unbreak a user-visible string

Jakub Sitnicki <jsitni...@gmail.com> writes: > On Wed, Oct 21, 2015 at 03:46 AM CEST, Jes Sorensen > <jes.soren...@redhat.com> wrote: >> Jakub Sitnicki <jsitni...@gmail.com> writes: >>> Signed-off-by: Jakub Sitnicki <jsitni...@gmail.com> >&

Re: overlap of devices in rtl8xxxu and rtl8192cu

Xose Vazquez Perez <xose.vazq...@gmail.com> writes: > Kalle Valo wrote: > >>> From: Jes Sorensen <jes.soren...@redhat.com> >>> >>> This is an alternate driver for a number of Realtek WiFi USB devices, >>> including RTL8723AU, RTL8188CU, RTL818

Re: staging/rtl8723au should be removed

Larry Finger writes: > On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote: >> Hi, >> >> Support for RTL8723AU devices was added to >> wireless-drivers-next.git recently: >> https://marc.info/?l=linux-wireless=144541406318463 >> commit: >>

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

Xose Vazquez Perez <xose.vazq...@gmail.com> writes: > Jes Sorensen wrote: > >> This is an alternate driver for a number of Realtek WiFi USB devices, >> including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU. >> It was written from scratch util

Re: overlap of devices in rtl8xxxu and rtl8192cu

Kalle Valo writes: > Kalle Valo writes: > >> Like I said earlier in rtl8xxxu review, I don't want to have two drivers >> supporting the same device. So either rtl8xxxu or rtlwifi supports the >> devices above, not both. And to my knowledge rtl8xxxu is

Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

Bruno Randolf <b...@einfach.org> writes: > On 10/22/2015 02:42 PM, Jes Sorensen wrote: >> Making things work against random kernel versions of OpenWRT is not >> particularly "credible". If the driver needs hacks to work with older >> kernels, then they sh

Re: overlap of devices in rtl8xxxu and rtl8192cu

Kalle Valo <kv...@codeaurora.org> writes: > Jes Sorensen <jes.soren...@redhat.com> writes: > >> Xose Vazquez Perez <xose.vazq...@gmail.com> writes: >>> >>> There is overlap of devices between rtl8xxxu and rtl8192cu: >>> USB_VE

Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

Bruno Randolf <b...@einfach.org> writes: > On 10/22/2015 02:10 PM, Jes Sorensen wrote: >>>> Thanks - I am not 100% convinced about this one. I don't think we should >>>> tell the firmware to pass up data frames before we have negotiated the >>>> con

Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

Bruno Randolf <b...@thinktube.com> writes: > On 10/22/2015 12:13 AM, Jes Sorensen wrote: >> Bruno Randolf <b...@einfach.org> writes: >>> mac80211 documentation says, the ieee80211_ops.start callback "must turn on >>> frame reception (for possibly en

Re: [PATCH] rtl8xxxu: Enable data frame reception in rtl8xxxu_start

Bruno Randolf writes: > mac80211 documentation says, the ieee80211_ops.start callback "must turn on > frame reception (for possibly enabled monitor interfaces.)". If not a single > monitor interface does not receive data frames. > > Similarly we should not change the data

Re: [RFC 01/16] rtl8xxxu: Treat REG_9346CR as an 8-bit wide register

Jakub Sitnicki writes: > rtl8723au driver treats REG_9346CR register as either 8- or 16-bit wide, > while rtl8192cu driver treats it as 8-bit wide, and so does rtl8188eu > driver. Use the lowest common denominator strategy. > > Signed-off-by: Jakub Sitnicki

Re: [RFC 02/16] rtl8xxxu: Use REG_EFUSE_TEST register only on multifunctional devices

Jakub Sitnicki writes: > rtl8192cu driver doesn't read/write the REG_EFUSE_TEST register. > Neither does the rtl8188eu driver. Do it only for RTL8192CU-based > devices. > > Signed-off-by: Jakub Sitnicki > --- >

Re: [RFC 00/16] rtl8xxxu: eFUSE parsing for RTL8188EU chips

Jakub Sitnicki writes: > Hi Jes, > > I'm posting this patch set to show in what direction the work is > going. Hopefully any changes (e.g. renames) which you wouldn't see > fit for this driver can be identified early this way. > > The work is nowhere near the end. These

Re: [RFC 04/16] rtl8xxxu: Skip disabled efuse words early

Jakub Sitnicki writes: > Avoid a negative conditional and an extra level of indentation in the > bigger part of the loop body. > > Signed-off-by: Jakub Sitnicki > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 28 > +++- >

Re: [RFC 03/16] rtl8xxxu: Don't check for illegal offset when reading from efuse

Jakub Sitnicki writes: > It is enough to check for either illegal offset or illegal map address > because map address is a value derived from an offset: > > map_addr = offset * 8 > EFUSE_MAP_LEN_8723A = EFUSE_MAX_SECTION_8723A * 8 > > Leave just the check for an illegal

Re: [RFC 08/16] rtl8xxxu: Extract TX power fields from struct rtl8xxu_priv

Jakub Sitnicki writes: > Signed-off-by: Jakub Sitnicki > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 95 > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 30 > 2 files changed, 66 insertions(+), 59

Re: [RFC 16/16] rtl8xxxu: rtl8188eu: Implement parse_efuse()

Jakub Sitnicki writes: > As opposed to the vendor driver (rtl8188eu), extract from efuse only > these TX power values that are going to be of use later on. > > Signed-off-by: Jakub Sitnicki > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 35

Re: [RFC 05/16] rtl8xxxu: Unbreak a user-visible string

Jakub Sitnicki writes: > Signed-off-by: Jakub Sitnicki > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c >

Re: [RFC 06/16] rtl8xxxu: rtl8723au: Introduce a pointer to efuse

Jakub Sitnicki writes: > Signed-off-by: Jakub Sitnicki > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 26 > +--- > 1 file changed, 14 insertions(+), 12 deletions(-) This cleans up the code nicely - so I applied both of

<    1   2   3   4   5   6   7   >