Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-19 Thread Andres Rodriguez
On 2018-03-13 12:38 PM, Luis R. Rodriguez wrote: On Tue, Mar 13, 2018 at 03:39:23PM +0200, Kalle Valo wrote: "Luis R. Rodriguez" writes: On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: On 3/11/2018 5:05 PM, Andres Rodriguez wrote: Your patch series

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-14 Thread Kalle Valo
Arend van Spriel writes: > On 3/13/2018 5:46 PM, Kalle Valo wrote: >> "Luis R. Rodriguez" writes: >> >>> On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: "Luis R. Rodriguez" writes: >> +/** >> + *

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-14 Thread Arend van Spriel
On 3/13/2018 5:46 PM, Kalle Valo wrote: "Luis R. Rodriguez" writes: On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: "Luis R. Rodriguez" writes: +/** + * request_firmware_optional: - request for an optional fw module + * @firmware_p:

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-13 Thread Kalle Valo
"Luis R. Rodriguez" writes: > On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: >> "Luis R. Rodriguez" writes: >> >> >> +/** >> >> + * request_firmware_optional: - request for an optional fw module >> >> + * @firmware_p: pointer to firmware image

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-13 Thread Luis R. Rodriguez
On Tue, Mar 13, 2018 at 03:16:34PM +0200, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > >> +/** > >> + * request_firmware_optional: - request for an optional fw module > >> + * @firmware_p: pointer to firmware image > >> + * @name: name of firmware file > >> + * @device:

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-13 Thread Luis R. Rodriguez
On Tue, Mar 13, 2018 at 03:39:23PM +0200, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > > On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: > >> On 3/11/2018 5:05 PM, Andres Rodriguez wrote: > >> > > Your patch series then should also have the driver

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-13 Thread Kalle Valo
"Luis R. Rodriguez" writes: > On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: >> On 3/11/2018 5:05 PM, Andres Rodriguez wrote: >> > > Your patch series then should also have the driver callers who you >> > > want to modify to use this new API. Collect from

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-13 Thread Kalle Valo
Arend van Spriel writes: > On 3/11/2018 5:05 PM, Andres Rodriguez wrote: >>> Your patch series then should also have the driver callers who you >>> want to modify to use this new API. Collect from the 802.11 folks the >>> other drivers which I think they wanted

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-13 Thread Kalle Valo
"Luis R. Rodriguez" writes: >> +/** >> + * request_firmware_optional: - request for an optional fw module >> + * @firmware_p: pointer to firmware image >> + * @name: name of firmware file >> + * @device: device for which firmware is being loaded >> + * >> + * This function is

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: > On 3/11/2018 5:05 PM, Andres Rodriguez wrote: > > > Your patch series then should also have the driver callers who you > > > want to modify to use this new API. Collect from the 802.11 folks the > > > other drivers which I think

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-11 Thread Arend van Spriel
On 3/11/2018 5:05 PM, Andres Rodriguez wrote: Your patch series then should also have the driver callers who you want to modify to use this new API. Collect from the 802.11 folks the other drivers which I think they wanted changed as well. Arend, Kalle, would love to hear your feedback. I am

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-11 Thread Andres Rodriguez
Hi Luis, Thanks for all your feedback, greatly appreciated. On 2018-03-10 09:40 AM, Luis R. Rodriguez wrote: On Sat, Mar 10, 2018 at 6:35 AM, Luis R. Rodriguez wrote: You also I take it have users in mind? I'd like to see at least one user of the API or this fixing a

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-10 Thread Luis R. Rodriguez
First, thanks for your patch! On Fri, Mar 9, 2018 at 3:09 PM, Andres Rodriguez wrote: > Currently the firmware loader only exposes one silent path for querying > optional firmware, and that is request_firmware_direct(). This function > also disables the usermodehelper