Re: pull-request: wireless-drivers-next 2016-09-29

From: Kalle Valo Date: Wed, 05 Oct 2016 07:50:39 +0300 > net-next still fails to compile for me. I verified that these two > patches fix it but I don't see them in net-next yet. Pablo please get those fixes to me as soon as possible.

Re: pull-request: wireless-drivers-next 2016-09-29

Aaron Conole writes: > David Miller writes: > >> From: Kalle Valo >> Date: Thu, 29 Sep 2016 19:57:28 +0300 >> > ... >>> Or actually I had one problem. While doing a test merge I noticed that >>> net-next fails to compile for me,

[PATCH 3/3] mac80211: multicast to unicast conversion

This patch adds support for sending multicast data packets with ARP, IPv4 and IPv6 payload (possible 802.1q tagged) as 802.11 unicast frames to all stations. IEEE 802.11 multicast has well known issues, among them: 1. packets are not acked and hence not retransmitted, resulting in decreased

[PATCH 2/3] mac80211: filter multicast data packets on AP / AP_VLAN

This patch adds filtering for multicast data packets on AP_VLAN interfaces that have no authorized station connected and changes filtering on AP interfaces to not count stations assigned to AP_VLAN interfaces. This saves airtime and avoids waking up other stations currently authorized in this

[PATCH 1/3] mac80211: remove unnecessary num_mcast_sta user

Checking for num_mcast_sta in __ieee80211_request_smps_ap() is unnecessary, as sta list will be empty in this case anyway, so list_for_each_entry(sta, ...) will exit immediately. Signed-off-by: Michael Braun --- net/mac80211/cfg.c | 7 --- 1 file changed, 7

Re: [PATCH v8] Add new mac80211 driver mwlwifi.

David Lin writes: > PATCH v8 changes since PATCH v7: > > - Used scnprintf() to replace sprintf() for debugfs output messages to avoid > overwriting buffer boundary. > - Used mutex to replace spinlock for the protection of firmware command. > - Used NL80211_BAND_ instead of

[PATCH 3/3] mac80211: multicast to unicast conversion

This patch adds support for sending multicast data packets with ARP, IPv4 and IPv6 payload (possible 802.1q tagged) as 802.11 unicast frames to all stations. IEEE 802.11 multicast has well known issues, among them: 1. packets are not acked and hence not retransmitted, resulting in decreased

[PATCH 2/3] mac80211: filter multicast data packets on AP / AP_VLAN

This patch adds filtering for multicast data packets on AP_VLAN interfaces that have no authorized station connected and changes filtering on AP interfaces to not count stations assigned to AP_VLAN interfaces. This saves airtime and avoids waking up other stations currently authorized in this

[PATCH 1/3] mac80211: remove unnecessary num_mcast_sta user

Checking for num_mcast_sta in __ieee80211_request_smps_ap() is unnecessary, as sta list will be empty in this case anyway, so list_for_each_entry(sta, ...) will exit immediately. Signed-off-by: Michael Braun --- net/mac80211/cfg.c | 7 --- 1 file changed, 7

Re: BCM43602 firmware reports multiple BRCMF_E_DEAUTH

On 09/28/2015 11:00 AM, Rafał Miłecki wrote: I'm using recent brcmfmac and brcmfmac43602-pcie.ap.bin that currently sits in linux-firmware.git. In OpenWrt we have hostapd with a feature of banning STAs. It works in a quite simple way. Whenever hostapd gets NL80211_CMD_NEW_STATION for STA that

[PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

From: Xinming Hu card->adapter gets initialized during device registration. As it's not cleared, we may end up accessing invalid memory in some corner cases. This patch fixes the problem. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar

[PATCH v2 2/2] mwifiex: check hw_status in suspend and resume handlers

From: Xinming Hu We have observed a kernel crash when system immediately suspends after booting. There is a race between suspend and driver initialization paths. This patch adds hw_status checks to fix the problem Signed-off-by: Xinming Hu Signed-off-by:

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

Hello, On 04/10/2016 17:46:44 CEST, Kalle Valo wrote: "Vittorio Gambaletta (VittGam)" writes: If generic entries are positioned above specific ones, then the former will be matched first and used instead of the latter. Cc: Cc:

Re: bcmdhd: Strange Power Save messages

On Tue, Oct 4, 2016 at 3:37 PM, Krishna Chaitanya wrote: > On Tue, Oct 4, 2016 at 5:09 PM, Gucea Doru wrote: >> On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel >>> wrote: On 29-09-16 13:32, Gucea Doru

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

> * pass both for IBSS mode (I think) two more aspects for IBSS 1. the PSK is shared by all stations, so a passive attacker on any authenticated station in range will be able to derive it, right? 2. iff at all the source mac might be used for access control so a TA==SA A-AMSDU filter

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

Hi, On Tue, Oct 04, 2016 at 10:38:24PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > card->adapter gets initialized during device registration. > As it's not cleared, we may end up accessing invalid memory > in some corner cases. This patch fixes the problem. > >

Re: [PATCH v2 2/2] mwifiex: check hw_status in suspend and resume handlers

Hi, On Tue, Oct 04, 2016 at 10:38:25PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > We have observed a kernel crash when system immediately suspends > after booting. There is a race between suspend and driver > initialization paths. > This patch adds hw_status checks

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

> Obviously, now that I think about it, your patch also would break > client mode since it would refuse to accept any A-MSDU with SA != TA, > which is highly unlikely in most cases, since traffic doesn't usually > originate from the AP. I still don't think my patch would break anything here, as

Re: [PATCH 1/8] mwifiex: prevent register accesses after host is sleeping

Hi, On Wed, Sep 28, 2016 at 06:18:21PM +0530, Amitkumar Karwar wrote: > Following is mwifiex driver-firmware host sleep handshake. > It involves three threads. suspend handler, interrupt handler, interrupt > processing in main work queue. > > 1) Enter suspend handler > 2) Download HS_CFG command

Re: [2/8] mwifiex: report error to PCIe for suspend failure

On Wed, Sep 28, 2016 at 06:18:22PM +0530, Amitkumar Karwar wrote: > When host_sleep_config command fails, we should return an error to > PCIe, instead of continuing (and possibly panicking, when we try to keep > processing a timed-out ioctl after we return "successfully" from > suspend). > >

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

> > First of all - there's nothing specific to "AP interfaces", which > > you say in the subject, as far as I can tell? That should be > > removed? > > > > > > > > > if (unlikely(ta && > > > +  (iftype == NL80211_IFTYPE_AP || > > > +   iftype ==

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

On Tue, 2016-10-04 at 10:29 +0200, Johannes Berg wrote: > > IEEE 802.11-2012 8.3.2.2 contains the note "NOTE—It is possible to > > have different DA and SA parameter values in A-MSDU subframe > > headers of the same A-MSDU as long as they all map to the same > > Address 1 and Address 2 parameter

Re: nl80211 fine timing measurement support

> If raw results are mainly used for analysis algorithms how about > providing raw measurement data through debugfs. May even consider > adding rtt calculation in cfg80211/mac80211 for drivers that choose > to provide raw measurement data and still only report final RTT in > nl80211 api. > I

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

Sorry - needed some time to think through this thread again. > I think it is a moot point as far as this change goes:  Regardless of > whether the NIC should or not, it _does_.  So, mis-reporting it up > the stack only hides the issue and does not even give the user a clue > that on-the-air

Re: [PATCH] mac80211: fix CMD_FRAME for AP_VLAN

On Mon, 2016-10-03 at 13:31 +0200, M. Braun wrote: > Am 03.10.2016 um 13:03 schrieb M. Braun: > > > > because the in ieee80211_mgmt_tx the > > ups, that was the patch itself. > > I think I carried it over from ieee80211_add_key, that does > > > > > > >    if (mac_addr) { > >  

Re: 802.11ad chip

On 10/3/2016 8:13 AM, Vikram wrote: > Hi, > > I want to purchase a 802.11ad chip which works with wil6210 linux > driver on latest stable kernel 4.7.4. I want to test some 802.11ad > WiGig functionalities. > > Please suggest me as to which one to buy. > > Regards, > Vikram > Acer has a few

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

> The main goal of this was to see if we can reduce actual driver > implementation size and maybe even more so to prepare for 802.11ax > changes (i.e., see what we are doing currently for configuring HT/VHT > in a way that could be done better). Fair enough. > Looking at the current in-tree

[PATCH 2/2] ath10k: Remove extraneous error message in tx alloc

From: Mohammed Shafi Shajakhan Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan ---

Re: [v2] mwifiex: report wakeup for wowlan

Rajat Jain writes: > Hello Kalie, > > On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo wrote: >> Rajat Jain wrote: >>> Enable notifying wakeup source to the PM core in case of >>> a wake on wireless LAN event. >>> >>> Signed-off-by:

Re: bcmdhd: Strange Power Save messages

On Tue, Oct 4, 2016 at 5:09 PM, Gucea Doru wrote: > On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel >> wrote: >>> >>> >>> On 29-09-16 13:32, Gucea Doru wrote: On Tue, Sep 27, 2016 at 12:03 PM, Gucea Doru wrote:

[PATCH 0/2] ath10k: Trivial cleanup in HTT tx buffer allocation

From: Mohammed Shafi Shajakhan Pre-requisite cleanup changes for one time tx buffer allocation to avoid contigous DMA tx buffer allocation failure for tx (thanks Vasanth) for long hour stress testing with continuous wifi down/up with multiple vaps in low memory

[PATCH 1/2] ath10k: clean up HTT tx buffer allocation and free

From: Mohammed Shafi Shajakhan cleanup 'ath10k_htt_tx_alloc' by introducing the API's 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and re-use them whereever needed Signed-off-by: Mohammed Shafi Shajakhan ---

[PATCH] mac80211: remove unnecessary mesh check

From: Johannes Berg sta_info_get_bss() is equivalent to sta_info_get() in the mesh case, since sta->sdata->bss will be NULL (it's only set for AP/AP_VLAN interfaces.) Thus, the mesh check here isn't actually needed - remove it. Signed-off-by: Johannes Berg

Re: [PATCH RESEND v3] mwifiex: parse device tree node for PCIe

On Thu, Sep 29, 2016 at 10:09:43PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > This patch derives device tree node from pcie bus layer framework. > Device tree bindings file has been renamed(marvell-sd8xxx.txt -> > marvell-8xxx.txt) to accomodate PCIe changes. > >

Re: bcmdhd: Strange Power Save messages

On Sat, Oct 1, 2016 at 2:52 PM, Arend van Spriel > wrote: >> >> >> On 29-09-16 13:32, Gucea Doru wrote: >>> On Tue, Sep 27, 2016 at 12:03 PM, Gucea Doru wrote: What is the decision triggering the exit from the PS mode immediately

[PATCH 2/2] mwifiex: check hw_status in suspend and resume handlers

From: Xinming Hu We have observed a kernel crash when system immediately suspends after booting. There is a race between suspend and driver initialization paths. This patch adds hw_status checks to fix the problem Signed-off-by: Xinming Hu Signed-off-by:

[PATCH 1/2] mwifiex: reset card->adapter during device unregister

From: Xinming Hu card->adapter gets initialized during device registration. As it's not cleared, we may end up accessing invalid memory in some corner cases. This patch fixes the problem. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar

Re: ath10k: Provide provision to get Transmit Power Control stats for 10.4

c_mke...@qti.qualcomm.com wrote: > From: Maharaja Kennadyrajan > > This patch helps to get the TPC stats for 10.4 fw variants. > > Signed-off-by: Maharaja Kennadyrajan Patch applied to ath-next branch of ath.git, thanks. ac86aa5755db

Re: pull-request: mac80211-next 2016-10-04

From: Johannes Berg Date: Tue, 4 Oct 2016 09:31:28 +0200 > Here's a version with the conflicts resolved - had to jigger some > code around, but it's all described in the merge commit message. > > Let me know if there's any problem. Pulled, thanks for resolving this.

Re: ath10k: add cc_wraparound type for QCA9888 and QCA9884

ako...@qti.qualcomm.com wrote: > From: Anilkumar Kolli > > During offchannel scan, iw survey dump shows wrong values. > Fix this by assigning cycle counter wranarround type for > QCA9888 and QCA9884, they share same config with QCA4019. > > Signed-off-by: Anilkumar

Re: [1/2] ath: export alpha2 helper

Bartosz Markowski wrote: > From: Michal Kazior > > This will be helpful for drivers that can acquire > alpha2 regulatory codes. > > Signed-off-by: Michal Kazior > Signed-off-by: Bartosz Markowski

Re: [2/4] ath10k: implement offset_tsf ieee80211_op

"Pedersen, Thomas" wrote: > Current set_tsf is implemented in terms of TSF_INCREMENT > only. Instead support new WMI command TSF_DECREMENT and > export these through offset_tsf. Advantage is we get > more accurate TSF adjustments, and don't calculate wrong > offset in case

Re: ath10k: Cleanup calling ath10k_htt_rx_h_unchain

On Tue, Oct 04, 2016 at 05:30:17PM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > 'ath10k_htt_rx_h_unchain' is need to be called only if the return > > value from

[PATCH 7/8] rtlwifi: rtl8192c: Remove address of Free Software Foundation

Since this driver was added to the kernel, the checkpatch script was modified to request that the address of the FSF not be included. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 4

[PATCH 2/8] rtlwifi: rtl8192se: Remove address of Free Software Foundation

Since this driver was added to the kernel, the checkpatch script was modified to request that the address of the FSF not be included. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192se/def.h | 4

[PATCH 4/8] rtlwifi: rtl8192cu: Remove address of Free Software Foundation

Since this driver was added to the kernel, the checkpatch script was modified to request that the address of the FSF not be included. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/def.h | 4

[PATCH 3/8] rtlwifi: rtl8192ce: Remove address of Free Software Foundation

Since this driver was added to the kernel, the checkpatch script was modified to request that the address of the FSF not be included. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192ce/def.h | 4

[PATCH 1/8] rtlwifi: rtl8192de: Remove address of Free Software Foundation

Since this driver was added to the kernel, the checkpatch script was modified to request that the address of the FSF not be included. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/def.h | 4

[PATCH 5/8] rtlwifi: rtl8723ae: Remove address of Free Software Foundation

Since this driver was added to the kernel, the checkpatch script was modified to request that the address of the FSF not be included. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.h | 4

[PATCH 6/8] rtlwifi: rtl8188ee: Remove address of Free Software Foundation

Since this driver was added to the kernel, the checkpatch script was modified to request that the address of the FSF not be included. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.h | 4

[PATCH 0/8] Remove address of Free Software Foundation

A number of these drivers were submitted to the kernel before checkpatch.pl was modified to state that that the address of the FSF should not be included. This set of patches remove this information from the sources. Signed-off-by: Larry Finger Larry Finger (8):

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

Am 04.10.2016 um 23:57 schrieb M. Braun: >> * pass both for IBSS mode (I think) > > two more aspects for IBSS > > 1. the PSK is shared by all stations, so a passive attacker on any >authenticated station in range will be able to derive it, right? > 2. iff at all the source mac might be used

[PATCH v2] ath10k: Cleanup calling ath10k_htt_rx_h_unchain

From: Mohammed Shafi Shajakhan 'ath10k_htt_rx_h_unchain' needs to be called only if the return value from 'ath10k_htt_rx_amsdu_pop' is 1('chained msdu's'), this change makes it more explicit and avoids doing a skb_peek, fetching rx descriptor pointer, checking rx msdu

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

"Vittorio Gambaletta (VittGam)" writes: > If generic entries are positioned above specific ones, then the > former will be matched first and used instead of the latter. > > Cc: > Cc: > Cc:

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

On Tue, Oct 04, 2016 at 03:25:51PM +0200, Johannes Berg wrote: > > ath6kl: > > Use cfg80211_get_chandef_type(>chandef) != NL80211_CHAN_NO_HT > > to determine whether HT is enabled. No VHT support. HT-required case > > not covered. No parsing of HT/VHT IEs used. > > Hmm. Wouldn't the supported

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

On 10/04/2016 02:32 AM, Johannes Berg wrote: Sorry - needed some time to think through this thread again. I think it is a moot point as far as this change goes: Regardless of whether the NIC should or not, it _does_. So, mis-reporting it up the stack only hides the issue and does not even

Re: [v3,3/3] mt76: add driver code for MT76x2e

Felix Fietkau wrote: > From: Felix Fietkau > > This is a 2x2 PCIe 802.11ac chipset by MediaTek > > Signed-off-by: Felix Fietkau A summary of what feature work would be nice to have. Also if there's something notable which is not working it's

Re: [v3,3/3] mt76: add driver code for MT76x2e

Felix Fietkau wrote: > From: Felix Fietkau > > This is a 2x2 PCIe 802.11ac chipset by MediaTek > > Signed-off-by: Felix Fietkau I already asked this in v2, but what about firmware images? Will they be available from linux-firmware.git? --

Re: [PATCH 2/3] mac80211: multicast to unicast conversion

On Tue, 2016-10-04 at 06:36 +0200, M. Braun wrote: > Am 30.09.2016 um 09:29 schrieb Johannes Berg: > > > > > > > > +static ssize_t ieee80211_if_fmt_unicast( > > > + const struct ieee80211_sub_if_data *sdata, char *buf, > > > int > > > buflen) > > > > That's a very ... unusual way to break the