Re: [RFC v4 06/21] ath10k: sdio support

"Valo, Kalle" <kv...@qca.qualcomm.com> writes: > Erik Stromdahl <erik.stromd...@gmail.com> writes: > >> sdio/mailbox HIF implementation. >> >> Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> > > I'm looking at

Re: [RFC v4 06/21] ath10k: sdio support

Erik Stromdahl writes: > sdio/mailbox HIF implementation. > > Signed-off-by: Erik Stromdahl I'm looking at this more carefully now and noticed this: > +static int ath10k_sdio_bmi_credits(struct ath10k *ar) > +{ > + int ret; > + u32

Re: ath6kl: Remove old 802.11a-only channels

Rostyslav Khudolii writes: > Following our conversation ("AR6003 5.2GHz AP on channel 38") on the > mailing list, sending a patch which removes channels 34/38/42/46 from > ath6kl driver. No attachments, please. The best is to use 'git send-email' to submit patches. Also

Re: [OpenWrt-Devel] ATH10K VLAN firmware issue

voncken writes: > Do you know if the firmware team planned to fix the VLAN issue on ath10k > firmware? I reported it forward only this week. -- Kalle Valo

Re: [RFC v3 0/8] ath10k sdio support

Erik Stromdahl writes: > Ok, I'll do another round of checkpatch before I submit anything. > I couldn't find the script you mentioned though (ath10k-check). Did you check the link I gave you:

Re: [RFC v3 0/8] ath10k sdio support

Erik Stromdahl writes: > I just noticed that Ryan Hsu submitted two patches containing similar > functionality to what I have in my tree on github. They have not been > integrated in the ath master yet, but they have been added to master-pending. > > Below are the

Re: [RFC v3 0/8] ath10k sdio support

Kalle Valo writes: > Erik Stromdahl writes: > >> I was actually about to email you about this. >> >> I have made a few more updates to the sdio code so I think it would be >> best if I could submit a new series of patches based on this code

Re: [RFC v3 0/8] ath10k sdio support

Erik Stromdahl writes: > I was actually about to email you about this. > > I have made a few more updates to the sdio code so I think it would be > best if I could submit a new series of patches based on this code (v4). > > Then you can tweak it (v5). > > It is only

Re: [RFC v3 0/8] ath10k sdio support

Hej, Erik Stromdahl writes: > This is the third version of the sdio RFC patch series. > The actual sdio code (patch 6) has been subject to a massive overhaul, > mainly as a result of Kalle's review comments. > It no longer has any strong resemblance of the original

Re: [PATCH v3] ath10k: add support for controlling tx power to a station

kbuild test robot writes: > Hi Ashok, > > [auto build test ERROR on v4.9-rc8] > [cannot apply to ath6kl/ath-next next-20170210] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails

Kalle Valo writes: > BTW, just curious but why do you have "during rmmod" in the title? I > think I was able to reproduce this crash by removing all firmware files > and didn't use rmmod at all. Nevermind, I was blind again. It was my script which calls rmmod and I

Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails

Mohammed Shafi Shajakhan writes: > the change suggested by you helps, and the device probe, scan > is successful as well. Still good to have this change part of your > basic sanity and regression testing ! Sure. I was sort of expecting that you would send v4 but I

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Ben Greear <gree...@candelatech.com> writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd <adr...@freebsd.org> writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv"

Re: [PATCH v2] ath10k: add support for controlling tx power to a station

kbuild test robot writes: > Hi Ashok, > > [auto build test WARNING on ath6kl/ath-next] > [also build test WARNING on v4.10-rc6 next-20170131] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: [PATCH v2 01/13] wil6210: add sysfs file for FTM calibration

Lior David <li...@codeaurora.org> writes: > On 1/19/2017 3:14 PM, Arend Van Spriel wrote: >> On 19-1-2017 13:36, Lior David wrote: >>> On 1/19/2017 2:24 PM, Valo, Kalle wrote: >>>> Maya Erez <qca_me...@qca.qualcomm.com> writes: >>>&

Re: Searching new home for ath[59]k-devel mailing lists

Kalle Valo writes: > (dropping ath5k-devel and ath9k-devel, I assume they are closed now) > > "Michael Renzmann" writes: > >> Kalle Valo wrote: >>> So feel free to close both of the lists and thanks for the heads up. >> >> Ok. I will send a

Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails

Kalle Valo writes: > Mohammed Shafi Shajakhan writes: > >> From: Mohammed Shafi Shajakhan >> >> This fixes the below crash when ath10k probe firmware fails, >> NAPI polling tries to access a rx ring resource which

Re: [PATCH v3] ath10k: Fix crash during rmmod when probe firmware fails

Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > This fixes the below crash when ath10k probe firmware fails, > NAPI polling tries to access a rx ring resource which was never > allocated, fix this by disabling NAPI

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

Joe Perches <j...@perches.com> writes: > On Tue, 2017-01-24 at 05:18 +0000, Valo, Kalle wrote: >> Joe Perches <j...@perches.com> writes: >> >> > On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: >> > > use dma_zalloc_coh

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

Joe Perches writes: > On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: >> use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). > [] >> diff --git a/drivers/net/wireless/ath/ath10k/pci.c >> b/drivers/net/wireless/ath/ath10k/pci.c > [] >> @@ -896,7

Re: [RFC v3 0/8] ath10k sdio support

Erik Stromdahl writes: > This is the third version of the sdio RFC patch series. > The actual sdio code (patch 6) has been subject to a massive overhaul, > mainly as a result of Kalle's review comments. > It no longer has any strong resemblance of the original ath6kl

Re: [PATCH v2 01/13] wil6210: add sysfs file for FTM calibration

Maya Erez writes: > From: Lior David > > In fine timing measurements, the calculation is affected by > 2 parts: timing of packets over the air, which is platform > independent, and platform-specific delays, which are dependent > on things

Re: [PATCH 1/3] rsi: Renamed the file rsi_91x_pkt.c to rsi_91x_hal.c

Kalle Valo writes: > Prameela Rani Garnepudi writes: > >> Can you please review these patches. You slipped through these patches >> and reviewing resent patches. Is there a specific reason? > > As you are new, your patches just

Re: [1/2] ath10k: add accounting for the extended peer statistics

Christian Lamparter writes: > Hello Shafi and Kalle, > > On Tuesday, January 3, 2017 10:58:27 AM CET Mohammed Shafi Shajakhan wrote: >> On Fri, Dec 30, 2016 at 03:35:10PM +0100, Christian Lamparter wrote: >> > On Thu, Dec 29, 2016 at 3:11 PM, Kalle Valo

Re: [1/2] ath10k: add accounting for the extended peer statistics

Christian Lamparter writes: > On Thu, Dec 29, 2016 at 3:11 PM, Kalle Valo wrote: >> Christian Lamparter wrote: >>> The 10.4 firmware adds extended peer information to the >>> firmware's statistics payload. This

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

Gabriel C <nix.or@gmail.com> writes: > On 18.12.2016 21:14, Paul E. McKenney wrote: >> On Sun, Dec 18, 2016 at 07:57:42PM +0000, Valo, Kalle wrote: >>> Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> writes: >>> >>>> A patch for

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

Tobias Klausmann writes: > A patch for this is already floating on the ML for a while now latest: > (ath9k: do not return early to fix rcu unlocking) It's here: https://patchwork.kernel.org/patch/9472709/ > Hopefully Kalle will include it in one of his

Re: [RFC v2 11/11] ath10k: Added sdio support

Erik Stromdahl writes: > Initial HIF sdio/mailbox implementation. > > Signed-off-by: Erik Stromdahl I know most of this coming from ath6kl but I think we should still improve the code. Lots of comments will follow, don't get scared :) >

Re: [RFC v2 06/11] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB

Erik Stromdahl writes: > Signed-off-by: Erik Stromdahl > --- > drivers/net/wireless/ath/ath10k/htc.h |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath10k/htc.h >

Re: [RFC v2 11/11] ath10k: Added sdio support

Erik Stromdahl writes: > Initial HIF sdio/mailbox implementation. > > Signed-off-by: Erik Stromdahl > --- > drivers/net/wireless/ath/ath10k/Kconfig |6 + > drivers/net/wireless/ath/ath10k/Makefile |3 + >

Re: [PATCH v2 0/7] ath9k: EEPROM swapping improvements

Martin Blumenstingl writes: > There are two types of swapping the EEPROM data in the ath9k driver. > Before this series one type of swapping could not be used without the > other. > > The first type of swapping looks at the "magic bytes" at the start of > the

Re: [RFC v2 05/11] ath10k: htc: refactorization

Michal Kazior writes: >> I have made a few updates since I submitted the original RFC and created >> a repo on github: >> >> https://github.com/erstrom/linux-ath >> >> I have a bunch of branches that are all based on the tags on the ath master. >> >> As of this moment

Re: [RFC v2 05/11] ath10k: htc: refactorization

Erik Stromdahl writes: > I have made a few updates since I submitted the original RFC and created > a repo on github: > > https://github.com/erstrom/linux-ath > > I have a bunch of branches that are all based on the tags on the ath master. > > As of this moment the

Re: [RFC v2 05/11] ath10k: htc: refactorization

Michal Kazior <michal.kaz...@tieto.com> writes: > On 13 December 2016 at 14:44, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Erik Stromdahl <erik.stromd...@gmail.com> writes: >> >>> Code refactorization: >>> >>>

Re: [RFC v2 05/11] ath10k: htc: refactorization

Erik Stromdahl writes: > Code refactorization: > > Moved the code for ep 0 in ath10k_htc_rx_completion_handler > to ath10k_htc_control_rx_complete. > > This eases the implementation of SDIO/mbox significantly since > the ep_rx_complete cb is invoked directly from the

Re: [RFC v2 11/11] ath10k: Added sdio support

Erik Stromdahl writes: > Initial HIF sdio/mailbox implementation. > > Signed-off-by: Erik Stromdahl While testing this I noticed few new warnings: drivers/net/wireless/ath/ath10k/sdio.c: In function ath10k_sdio_probe:

Re: [PATCH v2 0/7] ath9k: EEPROM swapping improvements

Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: > Hello Kalle, > > On Fri, Nov 25, 2016 at 4:06 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Kalle Valo <kv...@codeaurora.org> writes: >> >>> Martin Blumenst

Re: [PATCH] ath10k: free host-mem with DMA_BIRECTIONAL flag.

gree...@candelatech.com writes: > From: Ben Greear > > Hopefully this fixes the problem reported by Kalle: > > Noticed this in my log, but I don't have time to investigate this in > detail right now: > > [ 413.795346] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Hi Dave, Andy Gross <andy.gr...@linaro.org> writes: > On 1 December 2016 at 04:17, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Kalle Valo <kv...@qca.qualcomm.com> writes: >> >>> It found the same problem. Interestingly I'm also building x86 with 32

Re: ath10k: wmi-alloc-chunk should use DMA_BIDIRECTIONAL.

gree...@candelatech.com writes: > From: Ben Greear > > These memory chunks are often used as 'swap' by the NIC, > so it will be both reading and writing to these areas. > > This seems to fix errors like this on my x86-64 machine: > > kernel: DMAR: DMAR:[DMA Write]

Re: ath10k: Fix soft lockup during firmware crash/hw-restart

Mohammed Shafi Shajakhan writes: > On Tue, Nov 29, 2016 at 10:16:50AM -0800, Ben Greear wrote: >> Is this something for stable? And if so, how far back should it be applied? > > @Kalle, > > [shafi] kindly suggest. If i am not wrong this is only needed for 4.9 Correct,

Re: [PATCH v2] ath10k: Fix soft lockup during firmware crash/hw-restart

Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > During firmware crash (or) user requested manual restart > the system gets into a soft lock up state because of the > below root cause. > > During user requested hardware

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Kalle Valo <kv...@qca.qualcomm.com> writes: > Kalle Valo <kv...@qca.qualcomm.com> writes: > >> "Valo, Kalle" <kv...@qca.qualcomm.com> writes: >> >>> Bjorn Andersson <bjorn.anders...@linaro.org> writes: >>> >>&

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Kalle Valo <kv...@qca.qualcomm.com> writes: > "Valo, Kalle" <kv...@qca.qualcomm.com> writes: > >> Bjorn Andersson <bjorn.anders...@linaro.org> writes: >> >>> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: >>> >>>> Bj

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

"Valo, Kalle" <kv...@qca.qualcomm.com> writes: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > >> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: >> >>> Bjorn Andersson <bjorn.anders...@linaro.org> wrote: >>> &g

Re: [PATCH 2/3] ath9k: export configurable parameters of PTA

miaoq...@codeaurora.org writes: > From: Miaoqing Pan > > Export time_extend, pritority_time, first_slot_time, wl_active_time > and wl_qc_time those PTA(aka slotted mode) configurable parameters, > allow user to change/debug the timing easily. > > Also set wl_active_time

Re: [PATCH 1/3] ath9k: Add a module parameter to set btcoex duty cycle

miaoq...@codeaurora.org writes: > From: Miaoqing Pan > > btcoex duty cyle allows user to balance the performance > between WLAN and BT. > > Signed-off-by: Miaoqing Pan [...] > --- a/drivers/net/wireless/ath/ath9k/init.c > +++

Re: [PATCH v2] ath9k: Introduce airtime fairness scheduling between stations

(The make-wifi-fast list is annoying as it always spams me when it's on CC, so dropped it.) Toke Høiland-Jørgensen writes: > This reworks the ath9k driver to schedule transmissions to connected > stations in a way that enforces airtime fairness between them. It > accomplishes this

Re: [PATCH v2 0/7] ath9k: EEPROM swapping improvements

Kalle Valo writes: > Martin Blumenstingl writes: > >> There are two types of swapping the EEPROM data in the ath9k driver. >> Before this series one type of swapping could not be used without the >> other. >> >> The first type of

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Bjorn Andersson writes: > On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: > >> Bjorn Andersson wrote: >> > The correct include file for getting errno constants and ERR_PTR() is >> > linux/err.h, rather than linux/errno.h, so fix the

Re: [RFC 1/2] ath9k: work around AR_CFG 0xdeadbeef chip hang

Sven Eckelmann writes: > From: Simon Wunderlich > > QCA 802.11n chips (especially AR9330/AR9340) sometimes end up in a state in > which a read of AR_CFG always returns 0xdeadbeef. This should not happen > when when the power_mode of

Re: [RFC 02/12] ath10k: htc: rx trailer lookahead support

Erik Stromdahl writes: > On 11/15/2016 10:57 AM, Michal Kazior wrote: >> On 14 November 2016 at 17:33, Erik Stromdahl >> wrote: >>> The RX trailer parsing is now capable of parsing lookahead reports. >>> This is needed by SDIO/mbox. >> >>

Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

"Vittorio Gambaletta (VittGam)" <linux-wirel...@vittgam.net> writes: > Hello, > > On 12/10/2016 17:01:08 CEST, Valo, Kalle wrote: > >> So to tell the full story I'll change the commit log to something like >> below. Does it look ok to you? > >

Re: [OpenWrt-Devel] ATH10K VLAN firmware issue

Bruno Antunes <baantu...@gmail.com> writes: > On 7 November 2016 at 18:06, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Bruno Antunes <baantu...@gmail.com> writes: >> >>> On 4 November 2016 at 21:17, Valo, Kalle <kv...@qca.qualcomm.com> wrote: &

Re: [PATCH 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom, ath10k.txt

(Adding devicetree list) writes: > From: Tamizh chelvam > > There two things done in this patch. > > 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. > 2) 'wlan_btcoex_gpio' is used to fill wlan priority pin number for

Re: [RFC 10/12] ath10k: Added QCA65XX hw definition

Michal Kazior writes: > On 14 November 2016 at 17:33, Erik Stromdahl wrote: >> Signed-off-by: Erik Stromdahl >> --- >> drivers/net/wireless/ath/ath10k/hw.h |1 + >> 1 file changed, 1 insertion(+) >> >> diff --git

Re: [RFC 09/12] ath10k: Mailbox address definitions

Michal Kazior writes: > On 14 November 2016 at 17:33, Erik Stromdahl wrote: >> Address definitions for SDIO/mbox based chipsets. >> >> Signed-off-by: Erik Stromdahl >> --- >> drivers/net/wireless/ath/ath10k/hw.h |

Re: [RFC 05/12] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB

Michal Kazior writes: > On 14 November 2016 at 17:33, Erik Stromdahl wrote: >> Signed-off-by: Erik Stromdahl >> --- >> drivers/net/wireless/ath/ath10k/htc.h |2 ++ >> 1 file changed, 2 insertions(+) >> >> diff

Re: [v5] ath9k: Switch to using mac80211 intermediate software queues.

Toke Høiland-Jørgensen writes: > Tim Shepard writes: > >>> While at it, could you also add to the commit log some info how awesome this >>> patch is from user's point of view and how it helps. For example, before and >>> and after numbers and other results. >>

Re: ATH10K VLAN firmware issue

Bruno Antunes <baantu...@gmail.com> writes: > On 4 November 2016 at 21:17, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Bruno Antunes <baantu...@gmail.com> writes: >> >>> Old thread but I think the issue is still present. >>> >>&

Re: ATH10K VLAN firmware issue

Bruno Antunes writes: > Old thread but I think the issue is still present. > > I'm running a setup with VLANs with WDS and ath10k cards. > > To make it work both cards must be loaded in rawmode, AP > and Sta, and with no security. > > I'm using a OpenWrt trunk r49941 and the

Re: [PATCH 09/10] iwlwifi: mvm: operate in dqa mode

Kalle Valo writes: >> Since we've been working on this for so long and already use the term >> DQA broadly, we thought it wouldn't be necessary to explain more when >> we are finally enabling it by default. But of course I can change that >> if you prefer. > > I guessed I

Re: [RFC 0/5] ath6kl: non WMI data service support

(Adding ath10k list) Erik Stromdahl <erik.stromd...@gmail.com> writes: > On 10/14/2016 09:34 AM, Valo, Kalle wrote: >> Erik Stromdahl <erik.stromd...@gmail.com> writes: >> >>> This patch series is intended to prepare the ath6kl driver >>> for newer c

Re: [RFC 0/5] ath6kl: non WMI data service support

(Adding ath10k list to CC) Erik Stromdahl writes: >> Exactly what I was thinking. When I saw terms like "HTT" and "unified >> WMI" my first thought was that is this actually an ath10k based design? >> The product numbers really don't give any indication what driver >>

Re: [PATCH v2 2/2] ath10k: add VHT160 support

Kalle Valo writes: > From: Sebastian Gottschall > > This patch adds full VHT160 support for QCA9984 chipsets Tested on Netgear > R7800. 80+80 is possible, but disabled so far since it seems to contain > glitches like missing vht station flags

Re: [RFC 0/5] ath6kl: non WMI data service support

Steve deRosier writes: > Hi Eric, > > On Thu, Oct 13, 2016 at 9:39 AM, Erik Stromdahl > wrote: >> This patch series is intended to prepare the ath6kl driver >> for newer chipsets that doesn't use the current WMI data >> endpoints for data traffic.

Re: [PATCH v2] ath10k: Cleanup calling ath10k_htt_rx_h_unchain

Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > 'ath10k_htt_rx_h_unchain' needs to be called only if the return > value from 'ath10k_htt_rx_amsdu_pop' is 1('chained msdu's'), this > change makes it more explicit and

Re: [PATCH] rsi: update in vap_capabilities frame to device

Kalle Valo writes: > Prameela Rani Garnepudi writes: > >> added vap status(add/delete) field in vap capabilities frame to device >> added sending vap capabilites frame(with vap status 'delete') in remove >> interface >> >> Signed-off-by: Prameela

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

Yeoh Chun-Yeow writes: >> My understanding is that 10.2 branch does not have this feature, >> unfortunately. >> > > Alright, noted. > > Is QCA988X going to have firmware 10.4 support? I wish it would have but I don't know the current status. -- Kalle Valo

Re: QCA9887 Firmware Memory Usage

David Hutchison writes: > I am using a Mikrotik hAP AC Lite which has a QCA9887 radio. It > appears to be working; however ath10k ( or the qca9887 firmware ) is > utilizing 15 - 20mb of memory. I applied the kfree(caldata) patch, to > insure there is no memory leak. > >

Re: [v2,1/2] ath10k: clean up HTT tx buffer allocation and free

Mohammed Shafi Shajakhan writes: > Hi Kalle, > > On Tue, Oct 11, 2016 at 01:36:22PM +0200, Kalle Valo wrote: >> Mohammed Shafi Shajakhan wrote: >> > From: Mohammed Shafi Shajakhan >> > >> > cleanup

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

writes: > From: Anilkumar Kolli > > Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' > event, Firmware sends one HTT event for every four PPDUs. > HTT payload has success pkts/bytes, failed pkts/bytes, retry > pkts/bytes and rate

Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4

Yeoh Chun-Yeow writes: > On Fri, Oct 7, 2016 at 10:58 PM, wrote: >> From: Anilkumar Kolli >> >> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' >> event, Firmware sends one HTT event for every four

Re: [PATCH v2] ath10k: cache calibration data when the core is stopped

Marty Faltesek writes: > ath10k: cache calibration data when the core is stopped > > Caching calibration data allows it to be accessed when the > device is not active. > > Signed-off-by: Marty Faltesek Thanks, I'll now send v3. -- Kalle Valo

Re: [PATCH v2] ath10k: cache calibration data when the core is stopped

Marty Faltesek writes: > Caching calibration data allows it to be accessed when the > device is not active. > > --- Signed-off-by missing. Can you send it as a reply to this message and I'll add it to v3? > drivers/net/wireless/ath/ath10k/core.h | 1 + >

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

Marty Faltesek <mfalte...@google.com> writes: > On Mon, Oct 3, 2016 at 3:46 AM, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Marty Faltesek <mfalte...@google.com> writes: >> >>> Caching calibration data allows it to be accessed when the >>>

Re: [PATCH 2/2] ath10k: add platform regulatory domain support

Bartosz Markowski <bartosz.markow...@tieto.com> writes: > On 14 September 2016 at 09:06, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> >> Bartosz Markowski <bartosz.markow...@tieto.com> writes: >> >> > On 12 September 2016 at 1

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

Marty Faltesek writes: > Caching calibration data allows it to be accessed when the > device is not active. > > Signed-off-by: Marty Faltesek [...] > +int > +ath10k_cal_data_alloc(struct ath10k *ar, void **buf) > +{ [...] > +

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

Marty Faltesek writes: > Caching calibration data allows it to be accessed when the > device is not active. > > Signed-off-by: Marty Faltesek No comma in the title, please. What tree did you use as the baseline? This doesn't seem to apply to

Re: [PATCH] ath10k: Fix spinlock use in coverage class hack

Benjamin Berg writes: > ath10k_hw_qca988x_set_coverage_class needs to hold both conf_mutex and > the data_lock spin lock for parts of the function. However, data_lock > is only needed while storing the coverage_class to store the value that > the card is configured to.

Re: [PATCH] ath10k: fix debug cal data file

Nikolay Martynov writes: > It got broken by 0b8e3c4ca29fe2c0efd3d41a76e34a657b9f17a4 > > Signed-off-by: Nikolay Martynov Good catch, I'll queue this to 4.9. There was one checkpatch warning I fixed: drivers/net/wireless/ath/ath10k/debug.c:1477:

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

Ben Greear <gree...@candelatech.com> writes: > On 09/14/2016 07:06 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear <gree...@candelatech.com> >>> >>> Using debugfs. More convenient than module options >

Re: [PATCH v2 15/21] ath10k: support CT firmware flag.

Ben Greear <gree...@candelatech.com> writes: > On 09/14/2016 07:30 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear <gree...@candelatech.com> >>> >>> Add placeholder so CT firmware can more easily co-exist with

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

Ben Greear <gree...@candelatech.com> writes: > On 09/14/2016 07:19 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear <gree...@candelatech.com> >>> >>> Helps keep messages off of (serial) console when >&g

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

Ben Greear <gree...@candelatech.com> writes: > On 09/14/2016 07:18 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear <gree...@candelatech.com> >>> >>> This allows user-space tools to decode debug-

Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

Ben Greear <gree...@candelatech.com> writes: > On 09/14/2016 07:12 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear <gree...@candelatech.com> >>> >>> There are not many of these messages producted by the >&g

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

Ben Greear <gree...@candelatech.com> writes: > On 09/14/2016 07:07 AM, Valo, Kalle wrote: >> gree...@candelatech.com writes: >> >>> From: Ben Greear <gree...@candelatech.com> >>> >>> When firmware crashes, stack can continue to send pack

Re: [PATCH v2 12/21] ath10k: Support up to 64 vdevs.

gree...@candelatech.com writes: > From: Ben Greear > > The (1 << x) - 1 trick won't work when you > are trying to fill up all 64 bits, so add special > case for that. > > And, move the limits to the per-nic structure instead > of per-driver to allow better dynamic use of

Re: [PATCH v2 19/21] ath10k: Enable adhoc mode for CT firmware.

gree...@candelatech.com writes: > From: Ben Greear > > CT firmware can support IBSS mode, so allow users to configure this. > > Signed-off-by: Ben Greear > --- > drivers/net/wireless/ath/ath10k/mac.c | 5 + > 1 file changed, 5 insertions(+)

Re: [PATCH v2 15/21] ath10k: support CT firmware flag.

gree...@candelatech.com writes: > From: Ben Greear > > Add placeholder so CT firmware can more easily co-exist with upstream > kernel. CT firmware should be backwards compatible with existing kernels, > but it also has many new features. Subsequent patches, if

Re: [PATCH v2 11/21] ath10k: add fw-powerup-fail to ethtool stats.

gree...@candelatech.com writes: > From: Ben Greear > > This gives user-space a normal-ish way to detect that > firmware has failed to start and that a reboot is > probably required. > > Signed-off-by: Ben Greear > --- >

Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG

gree...@candelatech.com writes: > From: Ben Greear > > Helps keep messages off of (serial) console when > that is desired. > > Signed-off-by: Ben Greear Isn't /proc/sys/kernel/print exactly for this purpose? At least I recall using it. --

Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.

gree...@candelatech.com writes: > From: Ben Greear > > This allows user-space tools to decode debug-log > messages by parsing dmesg or /var/log/messages. > > Signed-off-by: Ben Greear Don't tracing points already provide the same information?

Re: [PATCH v2 08/21] ath10k: make firmware text debug messages more verbose.

gree...@candelatech.com writes: > From: Ben Greear > > There are not many of these messages producted by the > firmware, but they are generally fairly useful, so print > them at info level. > > Signed-off-by: Ben Greear > --- >

Re: [PATCH v2 04/21] ath10k: rate-limit packet tx errors

gree...@candelatech.com writes: > From: Ben Greear > > When firmware crashes, stack can continue to send packets > for a bit, and existing code was spamming logs. > > So, rate-limit the error message for tx failures. > > Signed-off-by: Ben Greear

Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime.

gree...@candelatech.com writes: > From: Ben Greear > > Using debugfs. More convenient than module options > in some cases. > > Signed-off-by: Ben Greear > --- > drivers/net/wireless/ath/ath10k/debug.c | 62 > +

Re: [PATCH] ath10k: Add missing CONFIG_ATH10K_DEBUGFS check

Benjamin Berg writes: > The patch "ath10k: allow setting coverage class" was missing a check for > CONFIG_ATH10K_DEBUGFS so it would try to use non-existing struct elements > in some configurations. Fix this by adding the appropriate ifdef. > > Signed-off-by: Benjamin

Re: [PATCH 2/2] ath10k: add platform regulatory domain support

Bartosz Markowski <bartosz.markow...@tieto.com> writes: > On 12 September 2016 at 17:35, Valo, Kalle <kv...@qca.qualcomm.com> wrote: > >> > +#ifdef CONFIG_ACPI >> > +#define WRD_METHOD "WRDD" >> > +#define WRDD_WIFI (0x07) >> > + &

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

Joe Perches writes: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches [...] > ---

  1   2   3   >