Re: [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats.

On 12/05/2016 09:28 AM, Felix Fietkau wrote: On 2016-12-05 16:01, Ben Greear wrote: On 12/05/2016 06:53 AM, Johannes Berg wrote: Unless I screwed up, this patch also returns an average. Oops, sorry. I missed the whole mac_div() indirection thing. I'm not super convinced anyway though -

[PATCH v2 1/2] mac80211: Return avg sig, rx, tx values in ethtool stats.

From: Ben Greear For non-station devices. This gives at least some useful summary in some cases (especially when we know AP has only one station attached, for instance). Signed-off-by: Ben Greear --- v2: Remove commented out pr_err code,

[PATCH v2 2/2] mac80211: Show pending txqlen in debugfs.

From: Ben Greear Could be useful for debugging memory consumption issues, and perhaps power-save as well. Signed-off-by: Ben Greear --- v2: Use more appropriate length, add comment to explain magic numbers. net/mac80211/debugfs.c | 27

wil6210: Low level RF sector API + Wrong Rx Sector Information

Dear Maya and Lior, 1. Regarding the patch for adding new APIs for low level RF sector in wil6210 driver, is it only intended for special firmware or it can support the available firmware which comes with the ACER Laptop and TP-Link AD7200 Router? 2. In the reported debug information in the

Re: [PATCH 02/14] rtlwifi: Fix programing CAM content sequence.

On Thu, Dec 01, 2016 at 07:48:21PM -0600, Larry Finger wrote: > From: Ping-Ke Shih > > There is a potential race condition when the control byte of a CAM > entry is written first. Write in reverse order to correct the condition. > > Signed-off-by: Ping-Ke Shih

Re: [PATCH 05/14] rtlwifi: Add TX report and disable key will wait until report acked.

On Thu, Dec 01, 2016 at 07:48:24PM -0600, Larry Finger wrote: > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > index 2d48ccd..0f9d9f0 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > +++

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: > --- > wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > +++ > wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > @@ -27,6 +27,29 @@ > > #include

Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

On 12/05/2016 05:38 AM, Dan Carpenter wrote: On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: From: Ping-Ke Shih The btcoexist routines for the RTL8192EE have been extensively rewritten. This patch does a million things and is totally unreviewable. The

Re: [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats.

On 2016-12-05 16:01, Ben Greear wrote: > > > On 12/05/2016 06:53 AM, Johannes Berg wrote: >> >>> Unless I screwed up, this patch also returns an average. >> >> Oops, sorry. I missed the whole mac_div() indirection thing. >> >> I'm not super convinced anyway though - all of this data already is

RE: ath10k firmware crashes in mesh mode on QCA9880

>> Applied the patch and tried with 10.2.4.70.54 firmware and it still crashes: >> [ 142.438377] ath10k_pci :01:00.0: firmware crashed! (uuid >> a5499582-e220-46d2-9359-0b44219f69ea) >> [ 142.447512] ath10k_pci :01:00.0: qca988x hw2.0 target 0x4100016c >> chip_id 0x043202ff sub

Re: ath10k firmware crashes in mesh mode on QCA9880

Applied the patch and tried with 10.2.4.70.54 firmware and it still crashes: [ 142.438377] ath10k_pci :01:00.0: firmware crashed! (uuid a5499582-e220-46d2-9359-0b44219f69ea) [ 142.447512] ath10k_pci :01:00.0: qca988x hw2.0 target 0x4100016c chip_id 0x043202ff sub : [

[PATCH 130/130] Fixed to checkpatch errors.

Hello, Fixed to checkpatch errors. ERROR: net/wireless/util.c:1787: ERROR: that open brace { should be on the previous line ERROR: net/wireless/util.c:1792: ERROR: that open brace { should be on the previous line Signed-off-by: Ozgur Karatas --- net/wireless/util.c

Re: [PATCH 1/3] ath10k: Ensure there are no stale ar->txqs entries.

On 12/05/2016 12:50 AM, Michal Kazior wrote: On 2 December 2016 at 01:24, Ben Greear wrote: On 12/01/2016 02:52 PM, Ben Greear wrote: On 08/19/2016 06:34 AM, Ben Greear wrote: On 08/18/2016 11:59 PM, Michal Kazior wrote: On 19 August 2016 at 03:26,

Re: [PATCH] RFC: Universal scan proposal

Hi Johannes, On Mon, Dec 5, 2016 at 6:28 AM, Johannes Berg wrote: > Hi Dmitry, > > Sorry I didn't respond earlier. > >>Currently we have sched scan with possibility of various >> intervals. We would like to extend it to support also >> different types of scan. > >

Re: [PATCH] mac80211: Remove invalid flag operations in mesh TSF synchronization

On Fri, Dec 2, 2016 at 10:59 PM, Masashi Honma wrote: > On 2016/12/03 06:13, Bob Copeland wrote: >> >> On Fri, Dec 02, 2016 at 12:07:18PM -0800, Thomas Pedersen wrote: > > > # Rejected by linux wireless ML. This is resubmission. > > thomas and Bob, Thanks for comments. >

[PATCH] ath10k: free host-mem with DMA_BIRECTIONAL flag.

From: Ben Greear Hopefully this fixes the problem reported by Kalle: Noticed this in my log, but I don't have time to investigate this in detail right now: [ 413.795346] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready [ 414.158755] IPv6: ADDRCONF(NETDEV_CHANGE):

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

fwiw, I'm facing the same kinds of cleanup problems with my port of (oct 2015) ath10k to freebsd. The oct 2015 ath10k tree doesn't have the firmware per-txq/tid/peer feedback stuff in it, so this hasn't yet bitten me, but there rest of the races have - mostly surrounding handling pending TX

[PATCH 1/2] ath10k: add accounting for the extended peer statistics

The 10.4 firmware adds extended peer information to the firmware's statistics payload. This additional info is stored as a separate data field and the elements are stored in their own "peers_extd" list. These elements can pile up in the same way as the peer information elements. This is because

[PATCH 2/2] ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats()

ath10k_wmi_tlv_op_pull_fw_stats() uses tb = ath10k_wmi_tlv_parse_alloc(...) function, which allocates memory. If any of the three error-paths are taken, this tb needs to be freed. Signed-off-by: Christian Lamparter --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 12

[PATCH] mac80211: fix rx-rate report when rate is invalid.

From: Ben Greear This fixes obtaining the rate info via sta_set_sinfo when the rx rate is invalid (for instance, on IBSS interface that has received no frames from one of its peers). Signed-off-by: Ben Greear --- net/mac80211/sta_info.c | 8

Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

On Mon, Dec 05, 2016 at 11:17:28AM -0600, Larry Finger wrote: > On 12/05/2016 05:38 AM, Dan Carpenter wrote: > >On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: > >>From: Ping-Ke Shih > >> > >>The btcoexist routines for the RTL8192EE have been extensively

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On 12/05/2016 03:34 PM, Dan Carpenter wrote: On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: --- wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h +++ wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h @@

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote: > On 12/05/2016 03:34 PM, Dan Carpenter wrote: > > On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: > > > --- > > > wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h > > > +++ > > >

Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

On Mon, 2016-12-05 at 09:32 -0600, Denis Kenzior wrote: > To what purpose?  That's like saying that maybe a socket should be > kept open in case an application crashes. That socket would be useless, so no, that's not comparable at all. It's more like saying the disk should be unmounted once

Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: > From: Ping-Ke Shih > > The btcoexist routines for the RTL8192EE have been extensively rewritten. > This patch does a million things and is totally unreviewable. The patch description doesn't say what patch

Re: adm80211: add checks for dma mapping errors

Alexey Khoroshilov wrote: > The driver does not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Patch

Re: ath10k: wmi-alloc-chunk should use DMA_BIDIRECTIONAL.

gree...@candelatech.com writes: > From: Ben Greear > > These memory chunks are often used as 'swap' by the NIC, > so it will be both reading and writing to these areas. > > This seems to fix errors like this on my x86-64 machine: > > kernel: DMAR: DMAR:[DMA Write]

Re: mwifiex: clean up some messy indenting

Dan Carpenter wrote: > These lines were indented one tab extra. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > index f5dffdf..fdc6cc2

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Hi Dave, Andy Gross writes: > On 1 December 2016 at 04:17, Valo, Kalle wrote: >> Kalle Valo writes: >> >>> It found the same problem. Interestingly I'm also building x86 with 32 >>> bit, maybe it's related? >>> >>> tree:

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

On 2 December 2016 at 03:29, wrote: > From: Ben Greear > > This appears to fix a problem where ath10k firmware would crash, > mac80211 would start re-adding interfaces to the driver, but the > iterate-active-interfaces logic would then try to

Re: [PATCH 1/3] ath10k: Ensure there are no stale ar->txqs entries.

On 2 December 2016 at 01:24, Ben Greear wrote: > On 12/01/2016 02:52 PM, Ben Greear wrote: >> >> On 08/19/2016 06:34 AM, Ben Greear wrote: >>> >>> >>> >>> On 08/18/2016 11:59 PM, Michal Kazior wrote: On 19 August 2016 at 03:26, wrote:

Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

On Fri, 2016-12-02 at 21:56 +0100, Andrew Zaborowski wrote: > Disconnect or deauthenticate when the owning socket is closed if this > flag has been supplied to CMD_CONNECT, CMD_AUTHENTICATE or > CMD_ASSOCIATE. Huh. That I think needs a lot more commit log to justify this code - why do you think

Re: [PATCH 2/2] mac80211: put upper bound on txqi queue length.

On Tue, 2016-11-29 at 10:05 -0800, gree...@candelatech.com wrote: > From: Ben Greear > > This fixes OOM when using pktgen to drive a wifi station at more than > the station can transmit.  pktgen uses ndo_start_xmit instead of > going > through the queue layer, so it will

Re: [PATCH] mac80211: Suppress NEW_PEER_CANDIDATE event if no room

On Wed, 2016-11-30 at 09:06 +0900, Masashi Honma wrote: > Previously, kernel sends NEW_PEER_CANDIDATE event to user land even > if the found peer does not have any room to accept other peer. This > causes continuous connection trials. Thanks, applied. johannes

Re: [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats.

On Tue, 2016-11-29 at 10:07 -0800, gree...@candelatech.com wrote: > From: Ben Greear > > For non-station devices.  This gives at least some useful > summary in some cases (especially when we know AP has only one > station attached, for instance). I never saw the point

Re: [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats.

> Unless I screwed up, this patch also returns an average. Oops, sorry. I missed the whole mac_div() indirection thing. I'm not super convinced anyway though - all of this data already is available in a much more reliable fashion, even trackable when stations are removed (all data gets sent in

Re: [PATCH 1/2] mac80211: Show pending txqlen in debugfs.

On 12/05/2016 06:54 AM, Johannes Berg wrote: On Mon, 2016-12-05 at 06:47 -0800, Ben Greear wrote: On 12/05/2016 05:59 AM, Johannes Berg wrote: +static ssize_t misc_read(struct file *file, char __user *user_buf, +size_t count, loff_t *ppos) +{ + struct

Re: [PATCH] mac80211: fix Tx BA session stuck issue during sw scanning

> > The premise seems fairly reasonable, although I'm a little worried > > that if so much new traffic is coming in we never finish the scan > > suspend? Actually, the queues are still stopped, so it's only > > management frames that can come in, so that should be ok? > > > > Actually it will

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

On Mon, 2016-12-05 at 06:57 -0800, Ben Greear wrote: > I think clearing sdata-in-driver would fix the ath10k problem, at > least, but I was afraid it would break something else in mac80211 or > maybe in other thick firmware drivers. It's pretty much an internal thing - not sure what it'd break.

Re: [PATCH 2/2] mac80211: put upper bound on txqi queue length.

On 5 December 2016 at 14:56, Johannes Berg wrote: > On Tue, 2016-11-29 at 10:05 -0800, gree...@candelatech.com wrote: >> From: Ben Greear >> >> This fixes OOM when using pktgen to drive a wifi station at more than >> the station can transmit.

Re: [PATCH] RFC: Universal scan proposal

Hi Dmitry, Sorry I didn't respond earlier. >    Currently we have sched scan with possibility of various > intervals. We would like to extend it to support also > different types of scan. "Different types of scan" is a bit misleading though, isn't it? I mean, mostly they differ in the reporting

Re: [PATCH 1/4] cfg80211: Add support to enable or disable btcoex

On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote: > From: Tamizh chelvam > > This patch adds support to enable or disable btcoex by > adding NL80211_ATTR_WIPHY_BTCOEX_ENABLE attribute in > NL80211_CMD_SET_WIPHY command. By default BTCOEX disabled in

Re: [PATCH 1/2] mac80211: Show pending txqlen in debugfs.

On 12/05/2016 05:59 AM, Johannes Berg wrote: +static ssize_t misc_read(struct file *file, char __user *user_buf, +size_t count, loff_t *ppos) +{ + struct ieee80211_local *local = file->private_data; + size_t bufsz = 1000; + char *buf = kzalloc(bufsz,

Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX

On Tue, 2016-11-08 at 18:45 +0530, c_tr...@qti.qualcomm.com wrote: >  > + * struct cfg80211_btcoex_priority - BTCOEX support frame type > + * > + * This structure defines the driver supporting frame types for > BTCOEX > + * > + * @wlan_be_preferred: best effort frames preferred over bt traffic > +

Re: [PATCH 1/2] mac80211: Show pending txqlen in debugfs.

On Mon, 2016-12-05 at 06:47 -0800, Ben Greear wrote: > > On 12/05/2016 05:59 AM, Johannes Berg wrote: > > > > +static ssize_t misc_read(struct file *file, char __user *user_buf, > > > > > > +  size_t count, loff_t *ppos) > > > +{ > > > + struct ieee80211_local *local =

Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

Hi Johannes, On 12/05/2016 07:51 AM, Johannes Berg wrote: On Fri, 2016-12-02 at 21:56 +0100, Andrew Zaborowski wrote: Disconnect or deauthenticate when the owning socket is closed if this flag has been supplied to CMD_CONNECT, CMD_AUTHENTICATE or CMD_ASSOCIATE. Huh. That I think needs a lot

Re: [PATCH 2/2] net: rfkill: Add rfkill-any LED trigger

> Thanks, these are obviously all valid concerns.  Sorry for being > sloppy > with the ifdefs.  If I get positive feedback on the proposed feature > itself, all these issues (and the warning pointed out in the other > message) will be resolved in v2. Looks fine, please do that. johannes

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

On Mon, 2016-12-05 at 09:13 +0100, Michal Kazior wrote: > On 2 December 2016 at 03:29,   wrote: > > > > From: Ben Greear > > > > This appears to fix a problem where ath10k firmware would crash, > > mac80211 would start re-adding interfaces to

Re: [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats.

On 12/05/2016 06:08 AM, Johannes Berg wrote: On Tue, 2016-11-29 at 10:07 -0800, gree...@candelatech.com wrote: From: Ben Greear For non-station devices. This gives at least some useful summary in some cases (especially when we know AP has only one station attached,

Re: [PATCH 1/2] mac80211: Show pending txqlen in debugfs.

+static ssize_t misc_read(struct file *file, char __user *user_buf, > +  size_t count, loff_t *ppos) > +{ > + struct ieee80211_local *local = file->private_data; > + size_t bufsz = 1000; > + char *buf = kzalloc(bufsz, GFP_KERNEL); You need at most 

Re: [PATCH 1/2] mac80211: do not iterate active interfaces when in re-configure

On 12/05/2016 07:00 AM, Johannes Berg wrote: On Mon, 2016-12-05 at 06:57 -0800, Ben Greear wrote: I think clearing sdata-in-driver would fix the ath10k problem, at least, but I was afraid it would break something else in mac80211 or maybe in other thick firmware drivers. It's pretty much

Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

Hi Johannes, On 12/05/2016 09:14 AM, Johannes Berg wrote: Well, no, that'd only work with an open connection :) Actually, it also works fairly easily for when firmware has 4-way- handshake offload, which will be coming to a kernel near you soon. Great, but still not applicable for all

Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

Hi Johannes, On 12/05/2016 08:58 AM, Johannes Berg wrote: Detecting it is easy, sure. But I'm a bit lost on how you propose to 'use' it. The connection is active up until the next rekey event. If rekey offloading is supported, then this might never involve user space. But if it isn't

Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

> > Well, no, that'd only work with an open connection :) Actually, it also works fairly easily for when firmware has 4-way- handshake offload, which will be coming to a kernel near you soon. > And even that is questionable in my mind for some of the more > advanced cases. Well, at least in

Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

Hi Johannes, >>> Well, no, that'd only work with an open connection :) > > Actually, it also works fairly easily for when firmware has 4-way- > handshake offload, which will be coming to a kernel near you soon. > >> And even that is questionable in my mind for some of the more >> advanced

Re: [PATCH] mac80211: fix Tx BA session stuck issue during sw scanning

On Mon, Dec 5, 2016 at 10:57 PM, Johannes Berg wrote: >> > The premise seems fairly reasonable, although I'm a little worried >> > that if so much new traffic is coming in we never finish the scan >> > suspend? Actually, the queues are still stopped, so it's only >> >