Re: [Linux-zigbee-devel] [PATCH] drivers/ieee802154/at86rf230: Add Automatic retransmit form the extended mode

2013-03-13 Thread Wolf-Bastian Pöttner
Am 14.03.2013 um 00:27 schrieb Sascha Herrmann : Ack support is something that's been on my radar to add, but haven't had > time. Maybe you have time to do this properly, by making a new netlink item to turn acking on and off and pushing it through iz. >>> I would like to see ACK s

Re: [Linux-zigbee-devel] [PATCH] drivers/ieee802154/at86rf230: Add Automatic retransmit form the extended mode

2013-03-13 Thread Sascha Herrmann
>>> Ack support is something that's been on my radar to add, but haven't had >>> time. Maybe you have time to do this properly, by making a new netlink >>> item to turn acking on and off and pushing it through iz. >> I would like to see ACK support, too. But I think, it should implemented >> in th

Re: [Linux-zigbee-devel] [PATCH] drivers/ieee802154/at86rf230: Add Automatic retransmit form the extended mode

2013-03-13 Thread Alan Ott
On 03/13/2013 06:19 PM, Sascha Herrmann wrote: >> Ack support is something that's been on my radar to add, but haven't had >> time. Maybe you have time to do this properly, by making a new netlink >> item to turn acking on and off and pushing it through iz. > I would like to see ACK support, too. B

Re: [Linux-zigbee-devel] [PATCH] drivers/ieee802154/at86rf230: Add Automatic retransmit form the extended mode

2013-03-13 Thread Sascha Herrmann
> Ack support is something that's been on my radar to add, but haven't had > time. Maybe you have time to do this properly, by making a new netlink > item to turn acking on and off and pushing it through iz. I would like to see ACK support, too. But I think, it should implemented in the mac layer

Re: [Linux-zigbee-devel] [PATCH 2/3] at86rf230: add irq type configuration option

2013-03-13 Thread Alan Ott
On 03/13/2013 05:55 PM, Sascha Herrmann wrote: >>> I don't know if this patch is necessary. I think Alan told about this >>> some days ago. In my case I setting my irq_type with a device_tree and I >>> know other boards, which are not using a device_tree, do the same in the >>> boardspecific code f

Re: [Linux-zigbee-devel] [PATCH 2/3] at86rf230: add irq type configuration option

2013-03-13 Thread Sascha Herrmann
>> I don't know if this patch is necessary. I think Alan told about this >> some days ago. In my case I setting my irq_type with a device_tree and I >> know other boards, which are not using a device_tree, do the same in the >> boardspecific code file in arch/arm/**/*_board.c. > > The at86rf230 s

Re: [Linux-zigbee-devel] [PATCH] ieee802154: pass destination address in dgram_sendmsg

2013-03-13 Thread Alan Ott
On 03/13/2013 03:57 AM, Wolf-Bastian Pöttner wrote: > This patch lets dgram_sendmsg determine the destination address > based on if the socket has been connect()ed before. If so, the > address passed to connect() is used. Otherwise, the address > passed to sendto() is used as destination. This con

Re: [Linux-zigbee-devel] [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset

2013-03-13 Thread Alan Ott
On 03/13/2013 10:40 AM, Wolf-Bastian Pöttner wrote: > Nope. The patch fixes a problem in code that is not in mainline yet. However, > people on the linux-zigbee mailing list found it a good idea to commit this > change to mainline to avoid the problem from arising. > > I see, you disagree. Neverm

Re: [Linux-zigbee-devel] [PATCH] drivers/ieee802154/at86rf230: Add Automatic retransmit form the extended mode

2013-03-13 Thread Alan Ott
On 03/13/2013 03:45 AM, Wolf-Bastian Pöttner wrote: > Implement the filter function to update short address, pan id and ieee > address on change. Allowing for hardware address filtering needed for > auto ACK. Switch state machine to use auto ACK states for rx. > > This will handle CSMA/CA for us as

Re: [Linux-zigbee-devel] [PATCH] Allow to set PAN ID, short address and channel manually.

2013-03-13 Thread Alan Ott
On 03/13/2013 03:25 AM, Wolf-Bastian Pöttner wrote: > This allows setting up a network without a PAN > coordinator. Necessary if you want to be compatible > with the contiki implementation. > > Signed-off-by: Stefan Schmidt > --- > src/iz-mac.c | 91 > +++

Re: [Linux-zigbee-devel] [PATCH] ieee802154: pass destination address in dgram_sendmsg

2013-03-13 Thread Alan Ott
On 03/13/2013 04:03 AM, Alexander Smirnov wrote: > if you have several patches for the same topic - please send them once > in one patch-set, do not annoy other developers by updating their > mailbox once per 15 minutes. Hi Alex, While this is normally good advice, I think in this case he's ok, s

Re: [Linux-zigbee-devel] [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset

2013-03-13 Thread Wolf-Bastian Pöttner
Hi! Nope. The patch fixes a problem in code that is not in mainline yet. However, people on the linux-zigbee mailing list found it a good idea to commit this change to mainline to avoid the problem from arising. I see, you disagree. Nevermind. ;) Bastian -- Wolf-Bastian Pöttner Institu

Re: [Linux-zigbee-devel] [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset

2013-03-13 Thread David Miller
From: Wolf-Bastian Pöttner Date: Wed, 13 Mar 2013 08:50:54 +0100 > offset has to be initialized, otherwise the *first* fragment will > be discarded and reassembly cannot happen. > > Reviewed-by: Alan Ott 'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset) succeeds, in which case it

Re: [Linux-zigbee-devel] [PATCH 2/3] at86rf230: add irq type configuration option

2013-03-13 Thread Alexander Aring
Hi, On Tue, Mar 12, 2013 at 09:24:13PM -0400, Alan Ott wrote: > On 03/12/2013 07:36 PM, Alexander Aring wrote: > > I don't know if this patch is necessary. I think Alan told about this > > some days ago. In my case I setting my irq_type with a device_tree and I > > know other boards, which are not

Re: [Linux-zigbee-devel] [PATCH] ieee802154: pass destination address in dgram_sendmsg

2013-03-13 Thread Alexander Smirnov
Dear Wolf-Bastian, if you have several patches for the same topic - please send them once in one patch-set, do not annoy other developers by updating their mailbox once per 15 minutes. Alex 2013/3/13 Wolf-Bastian Pöttner : > This patch lets dgram_sendmsg determine the destination address > based

[Linux-zigbee-devel] [PATCH] ieee802154: pass destination address in dgram_sendmsg

2013-03-13 Thread Wolf-Bastian Pöttner
This patch lets dgram_sendmsg determine the destination address based on if the socket has been connect()ed before. If so, the address passed to connect() is used. Otherwise, the address passed to sendto() is used as destination. Signed-off-by: Wolf-Bastian Pöttner --- net/ieee802154/dgram.c |

[Linux-zigbee-devel] [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset

2013-03-13 Thread Wolf-Bastian Pöttner
offset has to be initialized, otherwise the *first* fragment will be discarded and reassembly cannot happen. Reviewed-by: Alan Ott --- net/ieee802154/6lowpan.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index ed3d

[Linux-zigbee-devel] [PATCH] drivers/ieee802154/at86rf230: Add Automatic retransmit form the extended mode

2013-03-13 Thread Wolf-Bastian Pöttner
Implement the filter function to update short address, pan id and ieee address on change. Allowing for hardware address filtering needed for auto ACK. Switch state machine to use auto ACK states for rx. This will handle CSMA/CA for us as well as re-sending frames when no ack comes in timely. The

[Linux-zigbee-devel] [PATCH] Allow to set PAN ID, short address and channel manually.

2013-03-13 Thread Wolf-Bastian Pöttner
This allows setting up a network without a PAN coordinator. Necessary if you want to be compatible with the contiki implementation. Signed-off-by: Stefan Schmidt --- src/iz-mac.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a/

Re: [Linux-zigbee-devel] 6lowpan: strange addressing?

2013-03-13 Thread Wolf-Bastian Pöttner
Hi Alan, Am 12.03.2013 um 22:00 schrieb Alan Ott : > On 03/05/2013 10:48 AM, Wolf-Bastian Pöttner wrote: >> That means: the stack is using my 6lowpan address as sender (and receiver) >> in the IEEE 802.15.4 packets. > > Looking closely at my captures, I see this as well. 6lowpan.c (line 611, >