Re: [Linux-zigbee-devel] [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly

2012-10-23 Thread Jan Ceuleers
On 10/23/2012 06:09 AM, Tony Cheneau wrote: > #define lowpan_is_iid_16_bit_compressable(a) \ > a)->s6_addr16[4]) == 0) && \ > - (((a)->s6_addr16[5]) == 0) && \ > - (((a)->s6_addr16[6]) == 0) && \ > - a)->s6_addr[14]) & 0x80) == 0)) > +

Re: [Linux-zigbee-devel] [PATCH net-next 05/15] 6lowpan: use short IEEE 802.15.4 addresses for broadcast destination

2012-10-23 Thread Jan Ceuleers
On 10/23/2012 06:09 AM, Tony Cheneau wrote: > It is intended that the IEEE 802.15.4 standard uses the 0x short address > (2 > bytes) for message broadcasting. > > Signed-off-by: Tony Cheneau > --- > net/ieee802154/6lowpan.c | 21 + > 1 files changed, 13 insertions(+),

Re: [Linux-zigbee-devel] [PATCH net-next 11/15] 6lowpan: modify udp compression/uncompression to match the standard

2012-10-23 Thread Jan Ceuleers
On 10/23/2012 06:09 AM, Tony Cheneau wrote: > The previous code would just compress the UDP header and send the compressed > UDP header along with the uncompressed one. > > Signed-off-by: Tony Cheneau > --- > net/ieee802154/6lowpan.c | 36 +--- > 1 files changed

Re: [Linux-zigbee-devel] [PATCH net-next 06/15] 6lowpan: fix first fragment (FRAG1) handling

2012-10-23 Thread Jan Ceuleers
On 10/23/2012 06:09 AM, Tony Cheneau wrote: > The first fragment, FRAG1, must contain some payload according to the > specs. However, as it is currently written, the first fragment will > remain empty and only contain the 6lowpan headers. > > This patch also extract the transport layer information

Re: [Linux-zigbee-devel] [PATCH net-next 02/15] 6lowpan: next header is not properly set upon decompression of a UDP header.

2012-10-23 Thread Jan Ceuleers
On 10/23/2012 06:09 AM, Tony Cheneau wrote: > This causes a drop of the UDP packet. > > Signed-off-by: Tony Cheneau > --- > net/ieee802154/6lowpan.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > index 6d42

Re: [Linux-zigbee-devel] [PATCH net-next 06/15] 6lowpan: fix first fragment (FRAG1) handling

2012-10-23 Thread Eric Dumazet
On Tue, 2012-10-23 at 16:50 +0200, Tony Cheneau wrote: > > > > + hlen = (type == LOWPAN_DISPATCH_FRAG1 ? LOWPAN_FRAG1_HEAD_SIZE : > > + LOWPAN_FRAGN_HEAD_SIZE); > > > > So the L for LOWPAN_FRAGN_HEAD_SIZE should be underneath the t for > > type. > Will do as well. By the way parens a

Re: [Linux-zigbee-devel] [PATCH net-next 06/15] 6lowpan: fix first fragment (FRAG1) handling

2012-10-23 Thread Tony Cheneau
Hello Jan, Thank you for all your comments. See my answer inline. Le 23.10.2012 09:19, Jan Ceuleers a écrit : > On 10/23/2012 06:09 AM, Tony Cheneau wrote: >> The first fragment, FRAG1, must contain some payload according to >> the >> specs. However, as it is currently written, the first fragmen

Re: [Linux-zigbee-devel] [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly

2012-10-23 Thread Tony Cheneau
Hello David, Le 23.10.2012 08:49, David Miller a écrit : [...] > > It's really demoralizing to sit down to read a large 15 entry > patch series and this is the first thing I see: > >> /* >> - * check whether we can compress the IID to 16 bits, >> - * it's possible for unicast adresses with first

Re: [Linux-zigbee-devel] Stack on Beaglebone

2012-10-23 Thread João Paulo Bodanese
Hello, My objective is to build my own application over the 802.15.4. So, i think i will need the basic functionality. Now, i have running a kernel 3.2 on the BeagleBone, and i started to merge the 802.15.4 code from linux-3.7-rc1 to the 3.2. But, i have some doubts. In the 3.2 doesn't have the fi