Re: [Linux-zigbee-devel] [PATCH 0/3] Patches to 6lowpan.c to fix link-local address uncompression

2013-07-12 Thread Alexander Aring
Hi Ralph and Werner, On Thu, Jul 11, 2013 at 02:55:49PM +, Ralph Droms (rdroms) wrote: > > On Jul 8, 2013, at 1:24 PM 7/8/13, Werner Almesberger > wrote: > > > Ralph Droms wrote: > >> These patches fix link-local address uncompression, for both source > >> and destination addresses. > > >

Re: [Linux-zigbee-devel] [PATCH 0/3] Patches to 6lowpan.c to fix link-local address uncompression

2013-07-12 Thread Ralph Droms (rdroms)
On Jul 12, 2013, at 6:37 AM, "Alexander Aring" wrote: > Hi Ralph and Werner, > > On Thu, Jul 11, 2013 at 02:55:49PM +, Ralph Droms (rdroms) wrote: >> >> On Jul 8, 2013, at 1:24 PM 7/8/13, Werner Almesberger >> wrote: >> >>> Ralph Droms wrote: These patches fix link-local address u

Re: [Linux-zigbee-devel] [PATCH 0/3] Patches to 6lowpan.c to fix link-local address uncompression

2013-07-12 Thread Alexander Aring
Hi Ralph, On Fri, Jul 12, 2013 at 11:00:56AM +, Ralph Droms (rdroms) wrote: > > > On Jul 12, 2013, at 6:37 AM, "Alexander Aring" wrote: > > > Hi Ralph and Werner, > > > > On Thu, Jul 11, 2013 at 02:55:49PM +, Ralph Droms (rdroms) wrote: > >> > >> On Jul 8, 2013, at 1:24 PM 7/8/13, We

[Linux-zigbee-devel] [PATCH 5/5] 6lowpan: remove setting some memory regions to zero

2013-07-12 Thread Alexander Aring
While we can assume that the memory is already be zero, we can drop some memsets while parsing. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index c138443..572fa7c 10

[Linux-zigbee-devel] [PATCH 0/5] Small fixes improvements

2013-07-12 Thread Alexander Aring
Some small fixes and improvements. If this patchstack seems to be okay, I will send this to net mailinglist. So please review. :-) Alexander Aring (5): 6lowpan: fix small comment issue 6lowpan: fix return value with comment operator 6lowpan: use _saddr and _daddr instead of skb data 6lowp

[Linux-zigbee-devel] [PATCH 3/5] 6lowpan: use _saddr and _daddr instead of skb data

2013-07-12 Thread Alexander Aring
Pointers _saddr and _daddr points to source and destination address. Use this for a link-layer compression to get these addresses. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ie

[Linux-zigbee-devel] [PATCH 1/5] 6lowpan: fix small comment issue

2013-07-12 Thread Alexander Aring
Fix a little comment issue. Number 2 is 10 in bits and 1 is 01. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 3b9d5f2..c92f317 100644 --- a/net/ieee8021

[Linux-zigbee-devel] [PATCH 4/5] 6lowpan: init 6lowpan header and ipv6hdr to zero

2013-07-12 Thread Alexander Aring
When we set it to zero, we can assume that the memory is already zero while parsing. Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index ec4bf29..c138443 1006

[Linux-zigbee-devel] [PATCH 2/5] 6lowpan: fix return value with comment operator

2013-07-12 Thread Alexander Aring
Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index c92f317..4f35d9a 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -819,7 +819,8 @@ low

Re: [Linux-zigbee-devel] [PATCH 3/5] 6lowpan: use _saddr and _daddr instead of skb data

2013-07-12 Thread Ralph Droms (rdroms)
On Jul 12, 2013, at 7:33 AM 7/12/13, Alexander Aring wrote: > Pointers _saddr and _daddr points to source and destination address. > Use this for a link-layer compression to get these addresses. > > Signed-off-by: Alexander Aring > --- > net/ieee802154/6lowpan.c | 4 ++-- > 1 file changed, 2 i

Re: [Linux-zigbee-devel] [PATCH 0/3] Patches to 6lowpan.c to fix link-local address uncompression

2013-07-12 Thread Ralph Droms (rdroms)
On Jul 12, 2013, at 7:11 AM 7/12/13, Alexander Aring wrote: > Hi Ralph, > > On Fri, Jul 12, 2013 at 11:00:56AM +, Ralph Droms (rdroms) wrote: >> >> >> On Jul 12, 2013, at 6:37 AM, "Alexander Aring" wrote: >> >>> Hi Ralph and Werner, >>> >>> On Thu, Jul 11, 2013 at 02:55:49PM +, Ra

Re: [Linux-zigbee-devel] [PATCH 0/3] Patches to 6lowpan.c to fix link-local address uncompression

2013-07-12 Thread Ralph Droms (rdroms)
Alexander - I've attached a copy of 6lowpan.c that includes fixes for the fragmentation offset computation and for decompression of link-local addresses in a fragmented datagram. You should look at the code carefully because I'm not absolutely sure this code is exactly what I had running at one