From: Sergey Lapin
Date: Sat, 13 Jun 2009 14:57:54 +0400
> On Fri, Jun 12, 2009 at 03:59:20PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap
>>
>> menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154.
>> If the IEEE802154 symbol is 'm', the bool becomes 'y'.
>> This all
From: Dmitry Eremin-Solenikov
Date: Mon, 27 Jul 2009 18:08:12 +0400
>
> Please pull 3 small updates for IEEE 802.15.4 code (documentation and headers
> move).
>
> The following changes since commit 72dccb01e8632aa5ffe58070003d0fa19d007116:
> Eric Dumazet (1):
> bnx2: Update vlan_feat
From: Dmitry Eremin-Solenikov
Date: Tue, 4 Aug 2009 02:51:37 +0400
> Please pull several minor fixes for the IEEE 802.15.4 stack.
No.
Removing an unused macro IS NOT A BUG FIX!
Marking a variable 'const' IS NOT A BUG FIX!
And therefore it is absolutely, positively, not appropriate for
2.6.31
From: Dmitry Eremin-Solenikov
Date: Tue, 4 Aug 2009 12:51:48 +0400
> Will you pull the serie if I'll remove those two patches? Documentation
> fix isn't that important, however I'd really ask to pull the remaining
> two patches.
Yes.
-
From: Dmitry Eremin-Solenikov
Date: Tue, 4 Aug 2009 18:48:10 +0400
> On Tue, Aug 04, 2009 at 05:58:10AM -0700, David Miller wrote:
>> From: Dmitry Eremin-Solenikov
>> Date: Tue, 4 Aug 2009 12:51:48 +0400
>>
>> > Will you pull the serie if I'll remove those
From: Dmitry Eremin-Solenikov
Date: Wed, 5 Aug 2009 11:28:16 +0400
> Provide dummt get/setsockopt implementations to stop these
> syscalls from oopsing on our sockets.
>
> Signed-off-by: Dmitry Eremin-Solenikov
See "sock_no_getsockopt()" and "sock_no_setsockopt()" which are
provided specifica
From: Dmitry Eremin-Solenikov
Date: Thu, 6 Aug 2009 01:41:39 +0400
> On Wed, Aug 05, 2009 at 12:17:14PM -0700, David Miller wrote:
>> From: Dmitry Eremin-Solenikov
>> Date: Wed, 5 Aug 2009 11:28:16 +0400
>>
>> > Provide dummt get/setsockopt implementations to
From: Dmitry Eremin-Solenikov
Date: Wed, 5 Aug 2009 11:28:17 +0400
> Signed-off-by: Dmitry Eremin-Solenikov
What are you generating these patches against?
> @@ -72,5 +72,4 @@ SoftMAC
> We are going to provide intermediate layer implementing IEEE 802.15.4 MAC
> in software. This is currently
From: Dmitry Eremin-Solenikov
Date: Thu, 6 Aug 2009 13:26:17 +0400
> BTW: how should I differentiate my poll requests for net-next-2.6 and
> for net-2.6 ?
Like the rest of the world by indicating the target tree in your
subject lines. As long as it's in those initial [] brackets,
the automated
From: Dmitry Eremin-Solenikov
Date: Thu, 6 Aug 2009 16:26:24 +0400
> git://git.kernel.org/pub/scm/linux/kernel/git/lowpan/lowpan.git for-linus
>
> Dmitry Eremin-Solenikov (2):
> af_ieee802154: fix ioctl processing
> af_ieee802154: provide dummy get/setsockopt
Pulled, thanks.
I'm
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:36 +0400
> IEEE802154_SIOC_ADD_SLAVE was used to allocate 802.15.4 interfaces
> on the top of radio. It's not used anymore, drop it.
>
> Signed-off-by: Dmitry Eremin-Solenikov
Applied to net-next-2.6
--
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:37 +0400
> fix two errors in ioctl processing:
> 1) if the ioctl isn't supported one should return -ENOIOCTLCMD
> 2) don't call ndo_do_ioctl if the device doesn't provide it
>
> Signed-off-by: Dmitry Eremin-Solenikov
This change is alr
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:38 +0400
> Signed-off-by: Dmitry Eremin-Solenikov
Applied to net-next-2.6
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:39 +0400
> Signed-off-by: Dmitry Eremin-Solenikov
Applied to net-next-2.6
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:40 +0400
> Signed-off-by: Dmitry Eremin-Solenikov
Applied to net-next-2.6
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:41 +0400
> Provide dummt get/setsockopt implementations to stop these
> syscalls from oopsing on our sockets.
>
> Signed-off-by: Dmitry Eremin-Solenikov
No need for me to apply this, already in the tree.
--
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:42 +0400
> 1) fix ro->bound protection by socket lock
> 2) make ro->bound bit instead of int
>
> Signed-off-by: Dmitry Eremin-Solenikov
Applied to net-next-2.6
--
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:44 +0400
> Signed-off-by: Dmitry Eremin-Solenikov
Applied to net-next-2.6
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial
From: David Miller
Date: Wed, 12 Aug 2009 20:52:56 -0700 (PDT)
> From: Dmitry Eremin-Solenikov
> Date: Fri, 7 Aug 2009 16:58:44 +0400
>
>> Signed-off-by: Dmitry Eremin-Solenikov
>
> Applied to net-next-2.6
Patch #10 is applied too, I don't have a copy in my inbo
From: Dmitry Eremin-Solenikov
Date: Fri, 7 Aug 2009 16:58:43 +0400
> Signed-off-by: Dmitry Eremin-Solenikov
Applied to net-next-2.6
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial
From: Dmitry Eremin-Solenikov
Date: Thu, 20 Aug 2009 20:13:02 +0400
>
> The following changes since commit 886f9fe68310168358f55028a03553ae154dfeb6:
> David S. Miller (1):
> ppp_generic: Help GCC see that 'flen' is always initialized.
>
> are available in the git repository at:
>
>
From: Dmitry Eremin-Solenikov
Date: Wed, 16 Sep 2009 02:12:58 +0400
> Could you please pull small updates for IEEE 802.15.4 targeted
> into 2.6.32-rcX. Thank you.
I'm only taking bug fixes at this time, some of these changes are
feature patches. You had months before the merge window to get thi
From: Dmitry Eremin-Solenikov
Date: Wed, 16 Sep 2009 17:22:11 +0400
> Hi, David,
>
> Please pull both into net/master and net-next/master (as I'd like
> to submit few patches into net-next/master depending on this).
>
> The following changes since commit 4e36a95e591e9c58dd10bb4103c00993917c27fd
From: Dmitry Eremin-Solenikov
Date: Fri, 13 Nov 2009 00:17:15 +0300
> git://git.kernel.org/pub/scm/linux/kernel/git/lowpan/lowpan.git for-next
Pulled, thanks.
--
Let Crystal Reports handle the reporting - Free Crystal
From: Dmitry Eremin-Solenikov
Date: Wed, 11 Aug 2010 01:31:44 +0400
> Adding David Miller to the discussion, as the net-related stuff maintainer
Better to add net...@vger.kernel.org, so that all the rest of
the world of networking developers can respond when (as is the
case right now) I am
From: Dmitry Eremin-Solenikov
Date: Tue, 14 Jun 2011 00:02:38 +0400
> On 6/12/11, Jesper Juhl wrote:
>> In net/ieee802154/nl-phy.c::ieee802154_nl_fill_phy() I see two small
>> issues.
>> 1) If the allocation of 'buf' fails we may just as well return -EMSGSIZE
>>directly rather than jumping t
From: Dan Carpenter
Date: Tue, 30 Aug 2011 16:45:52 +0300
> Use kfree_skb() to free sbk_buffs.
>
> Signed-off-by: Dan Carpenter
Applied.
--
Doing More with Less: The Next Generation Virtual Desktop
What are the key o
From: Dan Carpenter
Date: Tue, 30 Aug 2011 16:46:40 +0300
> When we kfree(entry) that causes a use-after-free bug so we have to
> use list_for_each_entry_safe() safe here.
>
> Signed-off-by: Dan Carpenter
Applied.
--
From: Dan Carpenter
Date: Tue, 30 Aug 2011 16:51:09 +0300
> We should release the dev_hold() on error before returning here.
>
> Signed-off-by: Dan Carpenter
Applied.
--
Doing More with Less: The Next Generation Virtu
From: Alexander Smirnov
Date: Thu, 1 Sep 2011 16:54:13 +0400
> This patch fixes 2 issues in lowpan_skb_deliver function:
> 1. Check for return status of skb_copy call;
> 2. Use skb_copy with proper GFP flag depending on context.
>
> Signed-off-by: Alexander Smirnov
Applied.
-
From: Alexander Smirnov
Date: Thu, 1 Sep 2011 17:55:15 +0400
> This patch fixes 2 issues in lowpan_skb_deliver function:
> 1. Check for return status of skb_copy call;
> 2. Use skb_copy with proper GFP flag, drop check for non-interrupt
> context.
>
> Signed-off-by: Alexander Smirnov
Just to
From: Alexander Smirnov
Date: Wed, 2 Nov 2011 19:25:20 +0300
> The following patch series adds both major feature and minor fixes.
> Please find detailed description in each of the patches.
Right in the middle of the merge window is not the time to be
submitting new features.
You'll need to rep
From: Alexander Smirnov
Date: Thu, 10 Nov 2011 20:32:58 +0300
> Hello all,
>
> The following patch series adds both major feature and minor fixes.
> Please find detailed description in each of the patches.
>
> Just to summarize current development status:
> By using MAC and PHY layers support f
From: Alexander Smirnov
Date: Wed, 16 Nov 2011 11:42:07 +0300
> 2011/11/16 Dan Carpenter :
>> dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb()
>> in lowpan_fragment_xmit() is a double free.
>>
>> Signed-off-by: Dan Carpenter
...
>
> Acked-by: Alexander Smirnov
Applied, t
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:41 +0300
> +struct ieee802154_hw_addr_filt {
> + u16 pan_id;
> + u16 short_addr;
> + u8 ieee_addr[IEEE802154_ADDR_LEN];
> + u8 pan_coord;
> +};
What is the endianness of pan_id and short_addr objects? You should use
the approp
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:42 +0300
> + phy = wpan_phy_alloc(ALIGN(sizeof(*priv), NETDEV_ALIGN) + priv_size);
WHy make the call sites have to be cognizant of all of these crazy
alignment calculations?
Make wpan_phy_alloc() take care of it, and just pass the minimum
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:43 +0300
> +void ieee802154_rx(struct ieee802154_dev *dev, struct sk_buff *skb, u8 lqi);
> +void ieee802154_rx_irqsafe(struct ieee802154_dev *dev, struct sk_buff *skb,
> + u8 lqi);
Line up the "u8 lqi" argument with the openning pa
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:44 +0300
> +netdev_tx_t mac802154_tx(struct mac802154_priv *priv, struct sk_buff *skb,
> + u8 page, u8 chan);
Line up these arguments on the second line correctly!
If you can't do it properl
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:46 +0300
> + u16 pan_id;
> + u16 short_addr;
Again, endianness of these values, use the proper types and accessors etc.
--
Learn Windows Azure Live! Tuesday,
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:48 +0300
> + res = hw->ops->set_hw_addr_filt(&hw->hw,
> + &hw->hw.hw_filt, nw->changed);
Line up the arguments.
> + pr_debug("%s: failed changed mask %lx\n",
> + __func__, nw->changed);
Get rid
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:49 +0300
> Move ieee802154 netlink policy array definition inside ieee802154 layer.
>
> Signed-off-by: Alexander Smirnov
Then mark the thing static at it's definition, don't just remove all
the externs like this.
---
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:50 +0300
> int rc = -ENOBUFS;
> struct net_device *dev;
> +int type = -EINVAL;
Bad indentation.
Or do you mean to tell me this doesn't look like total garbage and
stand out like a sore thumb on your computer screen?
> +
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:51 +0300
> +struct ieee802154_dev *ieee802154_alloc_device(size_t priv_size,
> + struct ieee802154_ops *ops);
Line up the arguments properly.
> + if (priv->hw->open_count++ == 0) {
> + res = priv->h
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:52 +0300
> + IEEE802154_DEV_MONITOR = 1, /* for compatibility with WireShark */
What's this "compatability" all about? Explain it.
> + dev = alloc_netdev(sizeof(struct mac802154_sub_if_data),
> +
From: Alexander Smirnov
Date: Mon, 19 Dec 2011 19:33:53 +0300
> + unsigned int working:1;
Integer bit fields are troublesome, use a set of flags here, or if this
is likely to be the only set of state use a "bool" type.
> + list_for_each_entry(dp, &priv->fake->list, list)
> +
From: Alexander Smirnov
Date: Mon, 26 Dec 2011 20:02:33 +0300
> +enum ieee802154_hw_addr_filt_flags {
> + IEEE802515_SADDR_CHANGED= 1 << 0,
> + IEEE802515_IEEEADDR_CHANGED = 1 << 1,
> + IEEE802515_PANID_CHANGED= 1 << 2,
> + IEEE802515_PANC_CHANGED = 1 <
From: Alexander Smirnov
Date: Mon, 26 Dec 2011 20:04:07 +0300
> + /*
> + * SoftMAC device is registered and running. One can add
> + * subinterfaces.
> + */
> + unsigned running:1;
I told you to change this to a 'bool' in my previous review of your changes.
I'm pretty muc
From: Danny Kukawka
Date: Wed, 22 Feb 2012 13:36:39 +0100
> Use eth_mac_addr() for .ndo_set_mac_address, remove
> lowpan_set_address since it do currently the same as
> eth_mac_addr(). Additional advantage: eth_mac_addr() already
> checks if the given address is valid
>
> Signed-off-by: Danny Ku
I don't know what you expect to be done with these patches.
If you don't send them to net...@vger.kernel.org then as
far as I'm concerned they don't exist at all and I will not
apply them.
--
Virtualization & Cloud Manag
From: Alexander Smirnov
Date: Tue, 28 Feb 2012 18:00:22 +0300
> Main RX data path implementation between physical and mac layers.
> Both contexts are supported: interrupt (data processed via worker)
> and non-interrupt (data processed directly).
>
> Signed-off-by: Alexander Smirnov
If packets
From: Alexander Smirnov
Date: Tue, 24 Apr 2012 14:51:06 +0400
> the following patch-set contains several fixes/improvements for 6lowpan:
> 1. fix: segmentation fault caused by mlme request
> 2. impr: move frame allocation code to a separate function
> 3. fix: clean up fragments list if module unl
From: Alexander Smirnov
Date: Thu, 26 Apr 2012 13:24:55 +0400
> The following patch set contains several fixes for the 6lowpan holes which
> lead
> to unpredictable module state.
All applied, thanks.
--
Live Security V
From: Alexander Smirnov
Date: Thu, 26 Apr 2012 13:35:49 +0400
> The following patches contains 6lowpan code improvements.
Both applied, thanks.
--
Live Security Virtual Conference
Exclusive live event will cover all the
From: Sasha Levin
Date: Wed, 6 Jun 2012 23:32:02 +0200
> Currently when sending data over datagram, the send function will attempt to
> allocate any size passed on from the userspace.
>
> We should make sure that this size is checked and limited. The maximum size
> of an IP packet seemed like t
From: Sasha Levin
Date: Sun, 10 Jun 2012 13:10:19 +0200
> Currently when sending data over datagram, the send function will attempt to
> allocate any size passed on from the userspace.
>
> We should make sure that this size is checked and limited. The maximum size
> of an IP packet seemed like t
From: Alexander Smirnov
Date: Wed, 27 Jun 2012 10:57:18 +0400
> 2012/6/27 Dan Carpenter :
>> We already unlocked a few lines earlier here, so we can go directly to
>> drop without passing through unlock. This was introduced recently in
>> c5d3687f6c ('6lowpan: read data from skb safely').
>>
>>
From: Sasha Levin
Date: Mon, 2 Jul 2012 13:29:55 +0200
> Currently when sending data over datagram, the send function will attempt to
> allocate any size passed on from the userspace.
>
> We should make sure that this size is checked and limited. We'll limit it
> to the MTU of the device, which
From: Alan Ott
Date: Sat, 1 Sep 2012 11:57:05 -0400
> v3 of this patch changes skb_copy() to skb_clone() in patch #1 at the
> recommendation of Eric Dumazet
>
> Alan Ott (2):
> 6lowpan: Make a copy of skb's delivered to 6lowpan
> 6lowpan: handle NETDEV_UNREGISTER event
All applied to net-n
From: Alan Ott
Date: Sun, 2 Sep 2012 21:44:13 -0400
> Driver for the Microchip MRF24J40 802.15.4 WPAN module.
>
> Signed-off-by: Alan Ott
Applied to net-next, thanks.
--
Live Security Virtual Conference
Exclusive liv
From: Peter Senna Tschudin
Date: Tue, 18 Sep 2012 19:10:43 +0200
> Found by http://coccinelle.lip6.fr/
>
> Signed-off-by: Peter Senna Tschudin
Applied.
--
Live Security Virtual Conference
Exclusive live event will cov
From: Tony Cheneau
Date: Tue, 23 Oct 2012 00:09:43 -0400
> The current test is not RFC6282 compliant. The same issue has been found
> out and fixed in Contiki. This patch is basicaly a port of their fix.
>
> Signed-off-by: Tony Cheneau
It's really demoralizing to sit down to read a large 15 en
From: Alan Ott
Date: Thu, 29 Nov 2012 20:55:44 -0500
> Change the threshold for framentation of a lowpan packet from
> using the MTU size to now use the MTU size minus the checksum length,
> which is added by the hardware. For IEEE 802.15.4, this effectively
> changes it from 127 bytes to 125 byt
From: Alan Ott
Date: Thu, 29 Nov 2012 23:25:10 -0500
> kfree_skb() was not getting called in the case of some failures.
> This was pointed out by Eric Dumazet.
>
> Signed-off-by: Alan Ott
Applied.
--
Keep yourself con
From: Alan Ott
Date: Thu, 29 Nov 2012 23:25:11 -0500
> kfree_skb() indicates failure, which is where this is being used.
>
> Signed-off-by: Alan Ott
Applied.
--
Keep yourself connected to Go Parallel:
TUNE You got it
From: Konstantin Khlebnikov
Date: Fri, 14 Dec 2012 15:03:03 +0400
> mutex_destroy() must be called before wpan_phy_free(), because it puts the
> last
> reference and frees memory. Catched as overwritten poison in kmalloc-2048.
>
> Signed-off-by: Konstantin Khlebnikov
Applied.
---
From: Alexander Aring
Date: Wed, 2 Jan 2013 12:01:10 +0100
> When using nanosleep() in an userspace application we get a
> ratelimit warning
>
> NOHZ: local_softirq_pending 08
>
> for 10 times.
>
> This patch replaces netif_rx() with netif_rx_ni() which has
> to be used from process/softirq c
From: Alan Ott
Date: Wed, 16 Jan 2013 00:43:57 -0500
> + local_skb = skb_copy_expand(skb, NET_SKB_PAD - 1,
> + skb_tailroom(skb), GFP_ATOMIC);
This is not indented properly.
When a function call spans multiple lines, the second and subsequ
From: Alan Ott
Date: Thu, 17 Jan 2013 00:09:48 -0500
> Handle the reception of uncompressed packets (dispatch type = IPv6).
>
> Signed-off-by: Alan Ott
Applied.
--
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js,
From: Alan Ott
Date: Thu, 17 Jan 2013 00:09:47 -0500
> Refactor the handing of the skb's to the individual lowpan devices into a
> function.
>
> Signed-off-by: Alan Ott
Applied.
--
Master HTML5, CSS3, ASP.NET, MVC, AJ
From: YOSHIFUJI Hideaki
Date: Tue, 29 Jan 2013 05:44:29 +0900
> The "Universal/Local" (U/L) bit must be complmented according to RFC4944
> and RFC2464.
>
> Signed-off-by: YOSHIFUJI Hideaki
Applied.
--
Master Visual St
From: Alexander Aring
Date: Tue, 5 Feb 2013 15:25:35 +0100
> Signed-off-by: Alexander Aring
Applied, thanks.
--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and ge
From: Alexander Aring
Date: Tue, 5 Feb 2013 21:23:42 +0100
> In 6lowpan and mac802154 implemenation is a allocated
> temp heap buffer, which can also on the stack.
>
> I hope 100 bytes in 6lowpan are fine.
Series applied to net-next, thanks.
---
From: Lars-Peter Clausen
Date: Fri, 15 Feb 2013 14:03:29 +0100
> There is no need to implement empty suspend/resume callbacks if there is
> nothing
> to do during suspend/resume. The drivers will behave the same with no
> callbacks
> or empty callbacks during suspend/resume.
>
> Signed-off-by:
From: Eric Dumazet
Date: Thu, 07 Mar 2013 14:57:05 -0800
> On Thu, 2013-03-07 at 22:41 +, Ben Hutchings wrote:
>> On Thu, 2013-03-07 at 21:13 +0100, Alexander Aring wrote:
>> > The function addrconf_ifid_eui64 will copy eui into dev->dev_addr.
>> > We need first to manipulate eui[0] before we
From: YOSHIFUJI Hideaki
Date: Sun, 10 Mar 2013 04:11:57 +0900
> Signed-off-by: YOSHIFUJI Hideaki
Applied and queued up for -stable, thanks.
--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
W
From: Wolf-Bastian Pöttner
Date: Wed, 13 Mar 2013 08:50:54 +0100
> offset has to be initialized, otherwise the *first* fragment will
> be discarded and reassembly cannot happen.
>
> Reviewed-by: Alan Ott
'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset)
succeeds, in which case it
From: Alan Ott
Date: Mon, 18 Mar 2013 18:06:39 -0400
> These are fairly straight-forward.
All applied to net-next, thanks.
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download A
From: Tony Cheneau
Date: Mon, 25 Mar 2013 23:59:20 -0400
> This patchset fixes serious bugs within the 6LoWPAN modules. I wrote a script
> (available at [1]) to prove the issues are real. One can try and see that
> without these patches, most of the test fail (e.g. packet dropped by the
> receiv
From: Stefan Schmidt
Date: Tue, 26 Mar 2013 22:41:28 +
> Hello.
>
> Second version. Changes since version 1:
> - Obey 80 chars rules
> - Switch logging mode to vdbg to avoid noise
> - Remove uneeded might_sleep()
>
> Thanks Alan, Werner and Alex for the feedback.
>
> I feel these are ready
From: Tony Cheneau
Date: Wed, 27 Mar 2013 00:09:23 -0400
> Few minor issues were reported by Alexander Aring and Sergei Shtylyov on my
> previous 6lowpan patch set (named "6lowpan: Some more bug fixes").
> Sadly, I didn't had time to address them before the code was merged into
> net-next. These
From: Stefan Schmidt
Date: Wed, 27 Mar 2013 18:52:05 +
> Hello.
>
> On Wed, 2013-03-27 at 00:53, David Miller wrote:
>> From: Stefan Schmidt
>> Date: Tue, 26 Mar 2013 22:41:28 +
>>
>> > Hello.
>> >
>> > Second version. Changes sin
From: Alan Ott
Date: Tue, 02 Apr 2013 21:24:59 -0400
> I like it for a couple of reasons.
> 1. Most supported devices have only single packet output buffer, so
> blocking in the driver is the most straight-forward way to handle it.
> The alternative is to make each driver have a workqueue for xmi
From: Alan Ott
Date: Tue, 02 Apr 2013 21:59:37 -0400
> On 04/02/2013 09:56 PM, David Miller wrote:
>> From: Alan Ott
>> Date: Tue, 02 Apr 2013 21:24:59 -0400
>>
>>> I like it for a couple of reasons.
>>> 1. Most supported devices have only single packe
From: Alan Ott
Date: Tue, 02 Apr 2013 22:25:28 -0400
> The workqueue in mac802154 is only needed because the current mac802154
> xmit() function is designed to be blocking and synchronous.
>
> Prior to my patch (#3/6), that very same workqueue would actually queue
> up packets (without bound). T
From: Alan Ott
Date: Wed, 3 Apr 2013 10:00:54 -0400
> Version 2 of this patch series:
>
> Differences from v1:
>
> 1. Patches previously numbered 5 and 6 were squashed (to become current
> patch #4) at the request of Alexander Smirnov.
>
> 2. Current patch #2 had extraneous braces removed.
>
From: Sascha Herrmann
Date: Thu, 4 Apr 2013 23:02:00 +0200
> In at86rf230_probe() lp was first set to dev->priv and a few lines later
> dev->priv was set to lp again, without changing lp in between. The call
> to ieee802154_unregister_device() before err_irq: was unreachable.
>
> Signed-off-by:
From: Werner Almesberger
Date: Thu, 4 Apr 2013 13:31:46 -0300
> This fixes a kernel oops we get when some linux-zigbee user
> space tools try to invoke unimplemented operations.
>
> The second of the two patches checks whether the respective
> functions are present and returne EOPNOTSUPP if they
From: Alan Ott
Date: Fri, 5 Apr 2013 16:34:51 -0400
> On the MRF24J40, link-layer acknowledgment request and retry must be
> turned on explicitly for each packet. Turn this on in the hardware based
> on the FC_ACK_REQ bit being set in the packet.
>
> Also, now that failure to receive an ACK wi
From: Alan Ott
Date: Fri, 5 Apr 2013 19:03:10 -0400
> Two sections checked whether the current channel != the new channel
> without ever setting the current channel variables.
>
> 1. net/mac802154/tx.c: Prevent set_channel() from getting called every
> time a packet is sent.
>
> 2. net/mac8021
From: Wei Yongjun
Date: Tue, 9 Apr 2013 14:34:44 +0800
> From: Wei Yongjun
>
> module_spi_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Wei Yongjun
Applied.
--
Precog is a nex
From: Sascha Herrmann
Date: Fri, 12 Apr 2013 00:16:13 +0200
> static int at86rf230_hw_init(struct at86rf230_local *lp)
> {
> u8 status;
> - int rc;
> + int rc, irq_pol;
> + struct at86rf230_platform_data *pdata = lp->spi->dev.platform_data;
Please order local variable declara
From: Sascha Herrmann
Date: Mon, 15 Apr 2013 10:33:27 +0200
> Changes to last version: Reordered local variable declarations.
>
> The first patch add the option to configure the irq type of the
> plattform and the device. The second patch changes the irq handling
> when edge type interrupts are
From: Werner Almesberger
Date: Mon, 15 Apr 2013 22:44:19 -0300
> David Miller wrote:
>> I'd like to see some reviews of this patch series, thanks.
>
> Sascha and I discussed the functional aspects of his changes a
> while ago and I'm satisfied with the way he h
From: Werner Almesberger
Date: Tue, 16 Apr 2013 00:16:58 -0300
> David Miller wrote:
>> "Acked-by: Werner ..." is most useful to me.
>
> Hmm, since I don't have any official role (maintainer or such)
> with respect to that driver or the WPAN stack, I think this
From: Sascha Herrmann
Date: Mon, 15 Apr 2013 10:33:27 +0200
> Changes to last version: Reordered local variable declarations.
>
> The first patch add the option to configure the irq type of the
> plattform and the device. The second patch changes the irq handling
> when edge type interrupts are
From: Chen Gang
Date: Tue, 23 Apr 2013 19:24:36 +0800
>
> Need change ~(u8)0 to 0xff, or in mac802154_wpan_xmit(), "u8 chan"
> will never == MAC802154_CHAN_NONE.
>
> The related warning:
> net/mac802154/wpan.c:325:2: warning: comparison is always false
> due to limited range of data type [-
From: Chen Gang
Date: Thu, 25 Apr 2013 16:43:14 +0800
> (the change is for net/mac802154/mac802154.h, and exist in v3.9-rc8)
It exist, but your patch doesn't apply cleanly there, it only applies
cleanly to the -next tree, because other changes have happend to that
file in -next.
---
From: Chen Gang
Date: Thu, 25 Apr 2013 18:49:55 +0800
>
> Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in
> mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not
> succeed.
>
> This bug can be boiled down to ``u8 foo = 0xff; if (foo == ~(u8)0)
> [...] else [...
From: Wolfram Sang
Date: Wed, 10 Jul 2013 16:57:44 +0100
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for setting the default pins. Compile tested only.
>
> Acked-by: Linus Walleij (personally at LCE13)
> Signed-off-by: Wolfram Sa
You're submitting 7 patches, one set is numbered 1-6 and this
one has no number.
What in the world do you want me to do with these patches?
What tree are they targetted at?
Are there dependencies?
What order should I apply them in?
You've given me none of this information, therefore I am toss
1 - 100 of 184 matches
Mail list logo
