Re: [PATCH 09/18] ide: rework PowerMac media-bay support

2008-02-12 Thread Michael Ellerman
On Fri, 2008-02-08 at 01:45 +0100, Bartlomiej Zolnierkiewicz wrote: > Rework PowerMac media-bay support in such way that instead of > un/registering the IDE interface we un/register IDE devices: > > * Add ide_port_scan() helper for probing+registerering devices on a port. > > * Rename ide_port_un

Re: [PATCH] FIx compile of swim3 as module

2008-02-12 Thread Benjamin Herrenschmidt
On Tue, 2008-02-12 at 20:48 -0600, Josh Boyer wrote: > > The current pmac32_defconfig fails to build with the following > error: > > > > Building modules, stage 2. > > ERROR: "check_media_bay" [drivers/block/swim3.ko] undefined! > > WARNING: modpost: Found 23 section mismatch(es). > > To see fu

Re: [PATCH] FIx compile of swim3 as module

2008-02-12 Thread Benjamin Herrenschmidt
On Wed, 2008-02-13 at 13:40 +1100, Tony Breeds wrote: > The current pmac32_defconfig fails to build with the following error: > > Building modules, stage 2. > ERROR: "check_media_bay" [drivers/block/swim3.ko] undefined! > WARNING: modpost: Found 23 section mismatch(es). > To see full details bu

Re: [PATCH] FIx compile of swim3 as module

2008-02-12 Thread Tony Breeds
On Tue, Feb 12, 2008 at 08:48:02PM -0600, Josh Boyer wrote: > Kyle posted a slightly different patch that seemed to still keep > the original intention of ifdefery in tact. I've no idea which is > better, but the three of you might want to compare notes. /me checks Hmm Kyle's seem the leav

Re: [PATCH] FIx compile of swim3 as module

2008-02-12 Thread Josh Boyer
On Wed, 13 Feb 2008 13:40:20 +1100 [EMAIL PROTECTED] (Tony Breeds) wrote: > The current pmac32_defconfig fails to build with the following error: > > Building modules, stage 2. > ERROR: "check_media_bay" [drivers/block/swim3.ko] undefined! > WARNING: modpost: Found 23 section mismatch(es). > To

[PATCH] FIx compile of swim3 as module

2008-02-12 Thread Tony Breeds
The current pmac32_defconfig fails to build with the following error: Building modules, stage 2. ERROR: "check_media_bay" [drivers/block/swim3.ko] undefined! WARNING: modpost: Found 23 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' make[2

Re: Could the DTS experts look at this?

2008-02-12 Thread Grant Likely
On Feb 12, 2008 4:47 PM, Timur Tabi <[EMAIL PROTECTED]> wrote: > David Gibson wrote: > > > I can pretty much guarantee you that someone will find that > > insufficient and want to expand the conditional representation. This > > way madness lies. > > Then let them. We can have version numbers asso

Re: Could the DTS experts look at this?

2008-02-12 Thread Grant Likely
On Feb 12, 2008 4:35 PM, David Gibson <[EMAIL PROTECTED]> wrote: > In fact, in one way of looking at it that's always what happens: the > dtb format is defined for passing hardware information from the > bootloader to the kernel; nothing else. Passing a dtb *into* the > bootloader is just a bootlo

[PATCH rev2] powerpc: Marvell 64x60 EDAC platform devices setup

2008-02-12 Thread Dave Jiang
Creating platform devices (memory controller, sram error registers, cpu error registers, PCI error registers) for Error Detection and Correction (EDAC) driver. The platform devices allow the mv64x60 EDAC driver to detect errors from the memory controller (ECC erorrs), SRAM controller, CPU data pat

Re: Could the DTS experts look at this?

2008-02-12 Thread David Gibson
On Tue, Feb 12, 2008 at 05:47:23PM -0600, Timur Tabi wrote: > David Gibson wrote: > > > I can pretty much guarantee you that someone will find that > > insufficient and want to expand the conditional representation. This > > way madness lies. > > Then let them. We can have version numbers assoc

Re: Could the DTS experts look at this?

2008-02-12 Thread David Gibson
On Tue, Feb 12, 2008 at 05:41:12PM -0600, Timur Tabi wrote: > David Gibson wrote: > > > I'm not sure I'm entirely happy about storing the fragments under a > > special node - but certainly u-boot could do that if it wants. What > > would certainly be ok is to store various fragments as separate b

Re: Could the DTS experts look at this?

2008-02-12 Thread Timur Tabi
David Gibson wrote: > You don't. If your agent takes a dtb, dtb layout and agent must > match. So what I would like to see is a way for the agent to validate the dtb. U-Boot could currently validate the SOC's compatible field. However, if we add a special node that contains rules for modifyi

Re: Could the DTS experts look at this?

2008-02-12 Thread Timur Tabi
David Gibson wrote: > I can pretty much guarantee you that someone will find that > insufficient and want to expand the conditional representation. This > way madness lies. Then let them. We can have version numbers associated with the conditional expressions. If they want to make more comple

Re: Could the DTS experts look at this?

2008-02-12 Thread Timur Tabi
David Gibson wrote: > I'm not sure I'm entirely happy about storing the fragments under a > special node - but certainly u-boot could do that if it wants. What > would certainly be ok is to store various fragments as separate blobs > and fold them together as necessary. Which reminds me, I meant

Re: Could the DTS experts look at this?

2008-02-12 Thread David Gibson
On Tue, Feb 12, 2008 at 01:45:39PM -0600, Timur Tabi wrote: > Grant Likely wrote: [snip] > > That's not a dtb version issue. That is a dtb content issue. > > Technically, that's true, but ... > > > It does > > not warrant changing the dtb version number. > > Then how do you solve the problem o

Re: Could the DTS experts look at this?

2008-02-12 Thread David Gibson
[snip] On Tue, Feb 12, 2008 at 01:08:24PM -0600, Timur Tabi wrote: > Grant Likely wrote: > > On Feb 12, 2008 8:44 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > >> Arnd Bergmann wrote: > > I think it > > is a slippery slope to try and encode conditionals into the structure; > > Perhaps, which is wh

Re: Could the DTS experts look at this?

2008-02-12 Thread David Gibson
On Tue, Feb 12, 2008 at 09:44:39AM -0600, Timur Tabi wrote: > Arnd Bergmann wrote: > > > On Tuesday 12 February 2008, David Gibson wrote: > >> Or to expand. It's relatively easy now to just include multiple nodes > >> in the tree and either delete or nop some of them out conditionally > >> using

Re: Could the DTS experts look at this?

2008-02-12 Thread David Gibson
On Tue, Feb 12, 2008 at 12:51:06PM -0600, Scott Wood wrote: > On Tue, Feb 12, 2008 at 11:36:33AM +1100, David Gibson wrote: > > On Tue, Feb 12, 2008 at 01:21:44AM +0100, Arnd Bergmann wrote: > > > On Tuesday 12 February 2008, David Gibson wrote: > > > > Or to expand.  It's relatively easy now to ju

Re: DTS question - MPC5200b

2008-02-12 Thread David Gibson
On Tue, Feb 12, 2008 at 12:37:07PM -0500, Nick wrote: > Hi, > > I need some help. I am trying to access timer 7 on the MPC5200B > processor. I have the DTS file setup like this Others have addressed the most salient points, but some general corrections for your device tree.. > [EMAIL

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
On Tue, 2008-02-12 at 21:41 +, Alan Cox wrote: > On Wed, 13 Feb 2008 08:04:07 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: > > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > > >

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Alan Cox
On Wed, 13 Feb 2008 08:04:07 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > > - couple of fixes and preparatory patches > > > > > > - rework o

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 February 2008, Benjamin Herrenschmidt wrote: > > On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > > - couple of fixes and preparatory patches > > > > > > - rework of PowerMac media-bay suppor

[PATCH] [RFC] Xilinx: Add generic configuration option to enable all xilinx drivers.

2008-02-12 Thread Stephen Neuendorffer
In the future, this will be used to provide similar configuration for PowerPC and Microblaze. It may also be convenient for those using Xilinx cores as peripherals for external processors, rather than explicitly having a dependance on the processor architecture. Signed-off-by: Stephen Neuendorffe

[PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

2008-02-12 Thread Manish Ahuja
Michael, Fixed. -Manish -- Initial patch for reserving memory in early boot, and freeing it later. If the previous boot had ended with a crash, the reserved memory would contain a copy of the crashed kernel data. Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]> Signed-off-by: Linas Vep

Re: [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas.

2008-02-12 Thread Manish Ahuja
Stephen Rothwell wrote: > Hi Manish, > > On Tue, 12 Feb 2008 01:18:22 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote: >> -static void >> -release_memory_range(unsigned long start_pfn, unsigned long nr_pages) >> +static >> +void release_memory_range(unsigned long start_pfn, unsigned long nr_pages) >

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > - couple of fixes and preparatory patches > > > > - rework of PowerMac media-bay support ([un]register IDE devices instead of > > [un]registering IDE interf

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
On Tue, 2008-02-12 at 12:49 +0100, Gabriel Paubert wrote: > On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote: > > > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > > - couple of fixes and preparatory patches > > > > > > - rework of PowerMac media-b

Re: Could the DTS experts look at this?

2008-02-12 Thread Grant Likely
On Feb 12, 2008 12:45 PM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > > Then use a local version in the data; don't overload the purpose of > > the dtb version. > > I don't know what you mean by that. I'm saying that the dtb version is to describe the binary format of the dtb;

Re: DTS question - MPC5200b

2008-02-12 Thread Grant Likely
On Feb 12, 2008 11:07 AM, Jarno Manninen <[EMAIL PROTECTED]> wrote: > On Tuesday 12 February 2008 19:37:07 Nick wrote: > > > How do I specify the timer based on the cell-index? > > I don't know if that is possible to do in a one call, but maybe using the > approach from mpc52xx_uart might help? > >

Re: Could the DTS experts look at this?

2008-02-12 Thread Timur Tabi
Grant Likely wrote: > Then use a local version in the data; don't overload the purpose of > the dtb version. I don't know what you mean by that. > I don't think it is yet possible to define a reasonable 'standard > manner' for massaging device trees. There are going to be a lot of > experiments

Re: Could the DTS experts look at this?

2008-02-12 Thread Grant Likely
On Feb 12, 2008 12:08 PM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > On Feb 12, 2008 8:44 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > > This requires coordination and > > documentation, but id does not requires special formatting or > > versioning of the device tree blob. > > U

Re: DTS question - MPC5200b

2008-02-12 Thread Jarno Manninen
On Tuesday 12 February 2008 19:37:07 Nick wrote: > How do I specify the timer based on the cell-index? I don't know if that is possible to do in a one call, but maybe using the approach from mpc52xx_uart might help? --clip-- for_each_node_by_type(np, "serial") { if (!of_

Re: Could the DTS experts look at this?

2008-02-12 Thread Scott Wood
Grant Likely wrote: > On Feb 12, 2008 11:52 AM, Scott Wood <[EMAIL PROTECTED]> wrote: >> It'd be nice if we could pass in a flag to tell it not to try to find >> additional consecutive chips in the mapping... It's a shame to have >> probable chips, and still have to know how big they are anyway. >

Re: Could the DTS experts look at this?

2008-02-12 Thread Timur Tabi
Grant Likely wrote: > On Feb 12, 2008 8:44 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: >> Arnd Bergmann wrote: >> >>> On Tuesday 12 February 2008, David Gibson wrote: Or to expand. It's relatively easy now to just include multiple nodes in the tree and either delete or nop some of them out

Re: Could the DTS experts look at this?

2008-02-12 Thread Grant Likely
On Feb 12, 2008 11:52 AM, Scott Wood <[EMAIL PROTECTED]> wrote: > On Mon, Feb 11, 2008 at 07:41:07PM -0500, Sean MacLennan wrote: > > David Gibson wrote: > > > Err.. now I'm doubly confused. Initially I thought you'd need to > > > change the size part of reg somewhere, but your description above j

Re: Could the DTS experts look at this?

2008-02-12 Thread Grant Likely
On Feb 12, 2008 8:44 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Arnd Bergmann wrote: > > > On Tuesday 12 February 2008, David Gibson wrote: > >> Or to expand. It's relatively easy now to just include multiple nodes > >> in the tree and either delete or nop some of them out conditionally > >> usin

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-02-12 Thread Manish Ahuja
As noted, its fixed in patch 4. If its okay for this time, I will prefer to leave it there. -Manish Stephen Rothwell wrote: > Hi Manish, > > Just a small comment. > > On Tue, 12 Feb 2008 01:11:58 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote: >> +/* Is there dump data waiting for us? */ >

Re: Could the DTS experts look at this?

2008-02-12 Thread Scott Wood
On Mon, Feb 11, 2008 at 07:41:07PM -0500, Sean MacLennan wrote: > David Gibson wrote: > > Err.. now I'm doubly confused. Initially I thought you'd need to > > change the size part of reg somewhere, but your description above just > > convinced me you didn't (because you were essentially just shift

Re: Could the DTS experts look at this?

2008-02-12 Thread Scott Wood
On Tue, Feb 12, 2008 at 11:36:33AM +1100, David Gibson wrote: > On Tue, Feb 12, 2008 at 01:21:44AM +0100, Arnd Bergmann wrote: > > On Tuesday 12 February 2008, David Gibson wrote: > > > Or to expand.  It's relatively easy now to just include multiple nodes > > > in the tree and either delete or nop

Re: DTS question - MPC5200b

2008-02-12 Thread Grant Likely
On Feb 12, 2008 10:37 AM, Nick <[EMAIL PROTECTED]> wrote: > Hi, > > I need some help. I am trying to access timer 7 on the MPC5200B > processor. I have the DTS file setup like this > > [EMAIL PROTECTED] {// General Purpose Timer > device_type = "gpt"; > compatibl

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-12 Thread Dave Hansen
On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote: > Drivers like eHEA need memory notifiers in order to > update their internal DMA memory map when memory is added > to or removed from the system. > > Patch for eHEA memory hotplug support that uses these functions: > http://www.spinics.

Re: [PATCH 4/8] pseries: phyp dump: register dump area.

2008-02-12 Thread Manish Ahuja
For now, if we can leave this patch as is, that will be great. That move requires me to work all remaining patches as they apply uncleanly after that. I will bunch those two together functionally next time onwards. Thanks, Manish Stephen Rothwell wrote: > Hi Manish, > >> -/* Is there dum

DTS question - MPC5200b

2008-02-12 Thread Nick
Hi, I need some help. I am trying to access timer 7 on the MPC5200B processor. I have the DTS file setup like this [EMAIL PROTECTED] {// General Purpose Timer device_type = "gpt"; compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt"; cell-index = <7>;

Re: Could the DTS experts look at this?

2008-02-12 Thread Timur Tabi
Arnd Bergmann wrote: > On Tuesday 12 February 2008, David Gibson wrote: >> Or to expand. It's relatively easy now to just include multiple nodes >> in the tree and either delete or nop some of them out conditionally >> using libfdt. Yes, but what better place to store the conditions than in th

Re: libfdt: Add and use a node iteration helper function.

2008-02-12 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > This patch adds an fdt_next_node() function which can be used to > iterate through nodes of the tree while keeping track of depth. This > function is used to simplify the iteration code in a lot of other > functions, and is also exported for use by l

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Gabriel Paubert
On Tue, Feb 12, 2008 at 12:49:05PM +0100, Gabriel Paubert wrote: > On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote: > > > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > > - couple of fixes and preparatory patches > > > > > > - rework of PowerMac m

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Gabriel Paubert
On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: > > - couple of fixes and preparatory patches > > > > - rework of PowerMac media-bay support ([un]register IDE devices instead of > > [un]registering I

Re: [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas.

2008-02-12 Thread Stephen Rothwell
Hi Manish, On Tue, 12 Feb 2008 01:18:22 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote: > > -static void > -release_memory_range(unsigned long start_pfn, unsigned long nr_pages) > +static > +void release_memory_range(unsigned long start_pfn, unsigned long nr_pages) Cosmetic changes like this should

Re: [PATCH 4/8] pseries: phyp dump: register dump area.

2008-02-12 Thread Stephen Rothwell
Hi Manish, > - /* Is there dump data waiting for us? */ > + /* Is there dump data waiting for us? If there isn't, > + * then register a new dump area, and release all of > + * the rest of the reserved ram. > + * > + * The /rtas/ibm,kernel-dump rtas node is present only

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-02-12 Thread Stephen Rothwell
Hi Manish, Just a small comment. On Tue, 12 Feb 2008 01:11:58 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote: > > + /* Is there dump data waiting for us? */ > + rtas = of_find_node_by_path("/rtas"); > + dump_header = of_get_property(rtas, "ibm,kernel-dump", &header_len); You need an of

Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

2008-02-12 Thread Michael Ellerman
On Tue, 2008-02-12 at 01:08 -0600, Manish Ahuja wrote: > Initial patch for reserving memory in early boot, and freeing it later. > If the previous boot had ended with a crash, the reserved memory would contain > a copy of the crashed kernel data. > > Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]