Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-03 Thread Benjamin Herrenschmidt
On Fri, 2012-05-04 at 07:35 +0800, Wang Sheng-Hui wrote: > > No, Only comment the test, you must absolutely leave the > > __hard_irq_disable() call ! That's the whole point of the test, make > > sure we unconditionally disable to see if that fixes the problem, in > > which case that will tell us th

Re: [PATCH 1/1] page_alloc.c: remove argument to pageblock_default_order

2012-05-03 Thread Andrew Morton
On Thu, 3 May 2012 22:45:12 +0530 rajman mekaco wrote: > When CONFIG_HUGETLB_PAGE_SIZE_VARIABLE is not defined, then > pageblock_default_order has an argument to it. > > However, free_area_init_core will call it without any argument > anyway. > > Remove the argument to pageblock_default_order

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-03 Thread Wang Sheng-Hui
On 2012年05月03日 16:09, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-03 at 14:59 +0800, Wang Sheng-Hui wrote: >> On 2012年05月03日 14:33, Wang Sheng-Hui wrote: >>> if (unlikely(irq_happened != PACA_IRQ_HARD_DIS)) __hard_irq_disable(); >> >> I have commented out the 2 lines. > > No, O

Re: [PATCH v16 01/10]USB/ppc4xx: Add Synopsys DWC OTG Register definitions

2012-05-03 Thread Wolfgang Denk
Dear Rupjyoti Sarmah, In message <201205031223.q43cn3ln022...@amcc.com> you wrote: > > Add Synopsys Design Ware core register definitions. Olof Johansson has commented v15 of this patch as follows: > No, just start over from scratch. Just leave the crap driver behind, > use it for reference bu

Re: [PATCH v16 03/10]USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2012-05-03 Thread Alan Cox
O> +void dwc_otg_flush_rx_fifo(struct core_if *core_if) > +{ > + ulong global_regs = core_if->core_global_regs; These are all a bit odd. The register has a given size so they ought to be u32 or u64 etc as appropriate for the register in question, ditto the cache in the structure. > + f

[PATCH v16 01/10]USB/ppc4xx: Add Synopsys DWC OTG Register definitions

2012-05-03 Thread Rupjyoti Sarmah
Add Synopsys Design Ware core register definitions. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc/regs.h | 1326 1 files changed, 1326 insertions(+),

[PATCH v16 02/10]USB/ppc4xx-Add-Synopsys-DWC-OTG-driver-framework

2012-05-03 Thread Rupjyoti Sarmah
Platform probing is in apmppc.c. Driver parameter and parameter checking are in param.c. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc/apmppc.c | 350 ++ d

[PATCH v16 10/10]USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

2012-05-03 Thread Rupjyoti Sarmah
Enable gadget support Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/gadget/Kconfig| 11 +++ drivers/usb/gadget/gadget_chips.h |9 - 2 files changed, 19 insertions(+), 1 delet

[PATCH v16 09/10]USB/ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2012-05-03 Thread Rupjyoti Sarmah
Add Synopsys DesignWare HS USB OTG driver kernel configuration. Synopsys OTG driver may operate in host only, device only, or OTG mode. The driver also allows user configure the core to use its internal DMA or Slave (PIO) mode. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri Sign

[PATCH v16 07/10]USB/ppc4xx: Add Synopsys DWC OTG PCD function

2012-05-03 Thread Rupjyoti Sarmah
The PCD is responsible for translating requests from the gadget driver to appropriate actions on the DWC OTG controller. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc/pcd.c | 1817

[PATCH v16 06/10]USB/ppc4xx: Add Synopsys DWC OTG HCD queue function

2012-05-03 Thread Rupjyoti Sarmah
Implements functions to manage Queue Heads and Queue Transfer Descriptors of DWC USB OTG Controller. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc/hcd_queue.c | 696 ++

[PATCH v16 05/10]USB/ppc4xx: Add Synopsys DWC OTG HCD interrupt function

2012-05-03 Thread Rupjyoti Sarmah
FImplements DWC OTG USB HCD interrupt service routine. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc/hcd_intr.c | 1472 1 files changed, 1472 insertions(+)

RE: [PATCH] powerpc/windfarm: don't pass const strings to snprintf

2012-05-03 Thread David Laight
> --- a/drivers/macintosh/windfarm_smu_sat.c > +++ b/drivers/macintosh/windfarm_smu_sat.c > @@ -287,7 +287,7 @@ static int wf_sat_probe(struct i2c_client *client, > sens->sat = sat; > sens->sens.ops = &wf_sat_ops; > sens->sens.name = (char *) (sens + 1);

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-03 Thread Benjamin Herrenschmidt
On Thu, 2012-05-03 at 14:59 +0800, Wang Sheng-Hui wrote: > On 2012年05月03日 14:33, Wang Sheng-Hui wrote: > > if (unlikely(irq_happened != PACA_IRQ_HARD_DIS)) > >>__hard_irq_disable(); > > I have commented out the 2 lines. No, Only comment the test, you must absolutely leave the __hard_i