Re: [PATCH] powerpc: Add support to access the flash on SLOF based systems

2009-01-12 Thread Milton Miller
On Jan 10, 2009, at 1:50 PM, Adrian Reber wrote: On Sat, Jan 10, 2009 at 11:52:56AM -0600, Milton Miller wrote: On Sun Jan 11 at 02:31:22 EST in 2009, Adrian Reber wrote: This adds support for a simple character device to access the flash for SLOF based systems like the PowerStation, QS2x

Re: [PATCH] powerpc: Add support to access the flash on SLOF based systems

2009-01-10 Thread Milton Miller
On Sun Jan 11 at 02:31:22 EST in 2009, Adrian Reber wrote: This adds support for a simple character device to access the flash for SLOF based systems like the PowerStation, QS2x and PXCAB. In the SLOF git there is a user space program with which the content of the flash for SLOF based systems

[PATCH 0/5] hvc_console updates was Re: [BUG] hvc_console WARN() on current upstream

2009-01-08 Thread Milton Miller
Alan Cox wrote: Benjamin Herrenschmidt wrote: Seems that we are in interrupt, doing hvc_poll, which does tty_flip_buffer_push Which means that someone has tty-low_latency set and is calling tty_flip_buffer_push in an IRQ. That has never been allowed or safe, and now it hurts ;) /** *

[PATCH 3/4] hvc_console: free_irq only if request_irq was successful

2009-01-08 Thread Milton Miller
Only call free_irq if we marked the request_irq has having succeeded instead of whenever the the sub-driver identified the interrupt to use. Signed-off-by: Milton Miller milt...@bga.com --- Appears to be a bugfix but might use a bit of time in -next. This code was created in 2.6.28 to allow s390

[PATCH 2/4] hvc_console: use kzalloc

2009-01-08 Thread Milton Miller
Replace kmalloc + memset with kzalloc. Signed-off-by: Milton Miller milt...@bga.com Index: work.git/drivers/char/hvc_console.c === --- work.git.orig/drivers/char/hvc_console.c2009-01-08 04:24:10.0 -0600 +++ work.git

[PATCH 4/4] hvc_console: comment mb and make it an smp_ one

2009-01-08 Thread Milton Miller
I remember some history on this barrier. There was a race between open via /dev/console and the tty being fully setup. Its also why there is a temporary variable and the global is assigned at the end of the function. Signed-off-by: Milton Miller milt...@bga.com Index: work.git/drivers/char

[PATCH 1/4] hvc_console: do not set low_latency

2009-01-08 Thread Milton Miller
hvc_console is setting low_latency unconditionally, but some clients are interrupt driven and will call hvc_poll from irq context. This will cause tty_flip_buffer_push to be called from irq context, and it very clearly states it must not be called from IRQ when low_latency is specified. Looking

[PATCH 4/4] powerpc: numa: avoid possible reference beyond property length in find_min_common_depth

2009-01-08 Thread Milton Miller
find_min_common_depth was checking the property length incorrectly. The value is in bytes not cells, and it is using the second entry. Signed-off-By: Milton Miller milt...@bga.com --- I'm not aware of any trees that are broken in this way, so backport not likely needed but easy to apply. Index

[PATCH 3/4] powerpc: remove redundant find_cpu_node

2009-01-08 Thread Milton Miller
use of_get_cpu_node, which is a superset of numa.c's find_cpu_node in a less restrictive section (text vs cpuinit). Signed-off-by: Milton Miller milt...@bga.com Index: work.git/arch/powerpc/mm/numa.c === --- work.git.orig/arch

[PATCH 1/4] powerpc: move hose_list and pci_address_to_pio to pci-common

2009-01-08 Thread Milton Miller
removal Signed-off-by: Milton Miller milt...@bga.com --- I was looking at uses of hose_list when I ran across this almost common function. I haven't looked where the exported function might be used. Index: work.git/arch/powerpc/kernel/pci-common.c

[PATCH 2/4] powerpc: remove write only variable

2009-01-08 Thread Milton Miller
Since we never hotplug add an isa bus, we never need to set primary. Delete this write-only variable. Signed-off-by: Milton Miller milt...@bga.com --- The reference to primary was removed in during a code move 92eb4602 (v2.6.16) when dlpar for p5ioc was tested. Index: work.git/arch/powerpc

[PATCH kexec-tools v2] ppc64: always check number of ranges when adding them

2009-01-08 Thread Milton Miller
make the idom always call realloc_memory_ranges when filling a range entry kexec was core dumping after using 5 exclude_range pairs when only 3 were allocated. also delcare realloc_memory_ranges to take void. Signed-off-by: Milton Miller milt...@bga.com --- v2: compare variable j not i

Re: [PATCH kexec-tools 1/5] ppc64: always check number of ranges when adding

2009-01-07 Thread Milton Miller
On Jan 6, 2009, at 8:42 PM, Michael Ellerman wrote: On Fri, 2009-01-02 at 15:04 -0600, Milton Miller wrote: make the idom always call realloc_memory_ranges when filling a range entry @@ -666,6 +674,8 @@ int setup_memory_ranges(unsigned long ke memory_range[j].end

Re: [PATCH] powerpc: check crash_base for relocatable kernel

2009-01-07 Thread Milton Miller
[removed Paul from cc and fixed Mohan's email] On Jan 6, 2009, at 5:44 PM, Michael Ellerman wrote: On Fri, 2009-01-02 at 14:46 -0600, Milton Miller wrote: @@ -94,10 +95,35 @@ void __init reserve_crashkernel(void) KDUMP_KERNELBASE); crashk_res.start

Re: [PATCH] powerpc: use common cpu_die

2009-01-06 Thread Milton Miller
#insert top_post On Jan 5, 2009, at 6:47 PM, Matt Sealey wrote: Milton you're amazing 3 This is going to take a while to test. I have to build a new source rpm and push it to Peter, who is doing some work and I need him to have working config the same as mine. I am build testing the patch

[PATCH] powerpc: use common cpu_die

2009-01-05 Thread Milton Miller
-By: Matt Sealey Signed-off-by: Milton Miller milt...@bga.com --- compile tested on Matt's 2.6.27.7 config, both as given and with POWERMAC rediffed to linus git, applies with offset to 2.6.27.7 Matt please test ... especially sleep on a smp machine Index: work.git/arch/powerpc/kernel/setup_64.c

[PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

2009-01-04 Thread Milton Miller
In-Reply-To: 20090103191359.ga9...@linux.vnet.ibm.com Kamalesh Babulal wrote: config SCSI_IBMVSCSI tristate IBM Virtual SCSI support - depends on PPC_PSERIES || PPC_ISERIES + depends on (PPC_PSERIES || PPC_ISERIES) VIOPATH select SCSI_SRP_ATTRS help

Re: [PATCH] ppc64: Support for relocatable kernel in kexec-tools

2009-01-02 Thread Milton Miller
On Jan 2, 2009, at 8:08 AM, M. Mohan Kumar wrote: Support for relocatable kernel in kexec-tools This patch is based on the patch sent by Milton Miller with the subject [PATCH 1/2 kexec-tools] ppc64: new relocatble kernel activation ABI http://patchwork.ozlabs.org/patch/5378/ Even

[PATCH 0/5 + 2] kexec updates

2009-01-02 Thread Milton Miller
Follwing this mail are 5 patches for kexec userspace and two for the kernel. The first fixes an array overflow and the second updates userspace to the merged 2.6.28 kdump support. The remaining are cleanups and warning fixes, including one for the common code. The two patchs for the kernel are

[no subject]

2009-01-02 Thread Milton Miller
exclude_range pairs when only 3 were allocated. also delcare realloc_memory_ranges to take no arguments. Signed-off-by: Milton Miller milt...@bga.com Index: kexec-tools/kexec/arch/ppc64/kexec-ppc64.c === --- kexec-tools.orig/kexec/arch

[no subject]

2009-01-02 Thread Milton Miller
to the kernel as the c code made a copy of the original flag value. Signed-off-by: Milton Miller milt...@bga.com --- v3: purgatory now copies the flag to the kernel master entrypoint instead of the kernel reading the value copied to 0 with the slave spinloop. rename the local varable

[no subject]

2009-01-02 Thread Milton Miller
* and various pointers change some pointers between char and unsigned char * change args to be vars of the right type instead of casting or copying between types Signed-off-by: Milton Miller milt...@bga.com --- we still need to cast purgatory or we get a signed-ness warning on the pointer Index

[no subject]

2009-01-02 Thread Milton Miller
-off-by: Milton Miller milt...@bga.com --- Index: kexec-tools/kexec/kexec.c === --- kexec-tools.orig/kexec/kexec.c 2009-01-02 02:54:37.0 -0600 +++ kexec-tools/kexec/kexec.c 2009-01-02 02:55:06.0 -0600 @@ -666,7

[PATCH] powerpc: make dummy section a valid note header

2009-01-02 Thread Milton Miller
partition Warning: Elf Note name is not null terminated Instead of using the arbitray value 0xf177 (aka fill), declare a no-name no-description note of type 0. Signed-off-by: Milton Miller milt...@bga.com --- verified on binutils-2.6.17 that the workaround still works (that is we get a phdr that does

[PATCH kexec-tools 1/5] ppc64: always check number of ranges when adding

2009-01-02 Thread Milton Miller
make the idom always call realloc_memory_ranges when filling a range entry kexec was core dumping after using 5 exclude_range pairs when only 3 were allocated. also delcare realloc_memory_ranges to take no arguments. Signed-off-by: Milton Miller milt...@bga.com Index: kexec-tools/kexec/arch

[PATCH kexec-tools 5/5] entry wants to be void *

2009-01-02 Thread Milton Miller
/kexec.c kexec/kexec.c: In function ‘my_load’: kexec/kexec.c:773: warning: assignment makes pointer from integer without a cast Signed-off-by: Milton Miller milt...@bga.com --- Index: kexec-tools/kexec/kexec.c === --- kexec

[PATCH kexec-tools 2/5] ppc64: update kdump for 2.6.28 relocatable kernel

2009-01-02 Thread Milton Miller
in the kernel (after purgatory has run its checksum). To simplfy the purgatory code we can always copy the flag word back to the kernel as the c code made a copy of the original flag value. Signed-off-by: Milton Miller milt...@bga.com --- v3: purgatory now copies the flag to the kernel master entrypoint

[PATCH kexec-tools 4/5] ppc64: cleanups

2009-01-02 Thread Milton Miller
between types Signed-off-by: Milton Miller milt...@bga.com --- we still need to cast purgatory or we get a signed-ness warning on the pointer Index: kexec-tools/kexec/arch/ppc64/fs2dt.c === --- kexec-tools.orig/kexec/arch/ppc64/fs2dt.c

[PATCH kexec-tools 3/5] ppc64: segments may be reordered

2009-01-02 Thread Milton Miller
, the device tree or initrd will fit in a hole below the the kernel. When that happens, the previus code mis-patches purgatory and the kexec fails. Signed-off-by: Milton Miller milt...@bga.com --- The only safe reference is to info-segments[info-nr_segments] kexec/arch/ppc64/kexec-elf-ppc64.c

Re: [PATCH] powerpc 44x: support for 256KB PAGE_SIZE

2008-12-20 Thread Milton Miller
On Dec 19, 2008, at 12:39 AM, Yuri Tikhonov wrote: This patch adds support for 256KB pages on ppc44x-based boards. Hi. A couple of small comments. diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index cd8ff7c..348702c 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig

Re: [PATCH] check for GIQ indicator before calling set-indicator

2008-12-13 Thread Milton Miller
a WARN statement in xics_set_cpu_giq to get better information on failure. Signed-off-by: Nathan Lynch n...@pobox.com Acked-By: Milton Miller milt...@bga.com ... diff --git a/arch/powerpc/platforms/pseries/xics.c b/arch/powerpc/platforms/pseries/xics.c index e190477..37f5986 100644 --- a/arch

Re: [PATCH] powerpc: Remove modpost warning with start_secondary (Modified by Milton Miller)

2008-12-04 Thread Milton Miller
[oops forgot to cc the list] Nathan Lynch wrote at 2008-12-03 17:43:40: Kumar Gala wrote: On Dec 2, 2008, at 11:31 PM, Nathan Lynch wrote: Kumar Gala wrote: WARNING: vmlinux.o(.text+0x2aa): Section mismatch in reference from the variable __secondary_start to the function

Re: badness in xics_set_cpu_giq on JS20 blade

2008-11-25 Thread Milton Miller
On Nov 22, 2008, at 6:26 PM, Nathan Lynch wrote: Milton Miller wrote: On Sat Nov 22 at 14:06:53 EST in 2008, Nathan Lynch wrote: With 2.6.28-rc5 the WARN_ON in xics_set_cpu_giq is triggering on a JS20. I changed it to a WARN to get the actual status returned

Re: [PATCH] powerpc: Better setup of boot page TLB entry

2008-11-25 Thread Milton Miller
On Nov 23, 2008, at 11:01 PM, Kumar Gala wrote: On Nov 22, 2008, at 10:01 PM, Trent Piepho wrote: On Sat, 22 Nov 2008, Milton Miller wrote: On Thu Nov 20 at 06:14:30 EST in 2008, Trent Piepho wrote: - li r7,0 - lis r6,PAGE_OFFSET at h - ori r6,r6,PAGE_OFFSET

Re: [PATCH] [v3] powerpc/4xx: work around CHIP11 errata in a more PAGE_SIZE-friendly way

2008-11-25 Thread Milton Miller
On Nov 24, 2008, at 6:10 PM, Michael Ellerman wrote: On Mon, 2008-11-24 at 14:07 -0600, Hollis Blanchard wrote: On Fri, 2008-11-14 at 16:09 -0600, Hollis Blanchard wrote: If this is all too much, then I'm close to giving up and burning a 64KB page, which requires only ALIGN_DOWN() in the

Re: powerpc: udbg based backend for hvc_console

2008-11-21 Thread Milton Miller
On Nov 20, 2008, at 1:16 PM, Timur Tabi wrote: Milton Miller wrote: Stated differently, if your routine (1) fundamently works one character at a time and (2) is not interrupt driven, and (3) only supports one channel, what avantage is there to an explicit hvc driver? I think it's because

Re: powerpc: udbg based backend for hvc_console

2008-11-21 Thread Milton Miller
On Nov 21, 2008, at 10:13 AM, Timur Tabi wrote: Milton Miller wrote: We want the last console= parameter on the command line to win. So if that implys the last call to add_preferred_console wins, then you have code overriding the command line. Hmm, good point. However, how likely

Re: powerpc: udbg based backend for hvc_console

2008-11-21 Thread Milton Miller
On Nov 20, 2008, at 6:35 PM, David Gibson wrote: On Thu, Nov 20, 2008 at 01:07:11PM -0600, Milton Miller wrote: David Gibson wrote at 2008-11-18 00:28:28: On Mon, Nov 17, 2008 at 01:41:24PM -0600, Timur Tabi wrote: On Thu, Oct 23, 2008 at 9:54 PM, David Gibson [EMAIL PROTECTED] wrote

Re: powerpc: udbg based backend for hvc_console

2008-11-20 Thread Milton Miller
[I'm going to reply to several points in this thread in one reply. I have restored context that was trimmed in later replys when I wanted to speak to.] David Gibson wrote at 2008-11-18 00:28:28: On Mon, Nov 17, 2008 at 01:41:24PM -0600, Timur Tabi wrote: On Thu, Oct 23, 2008 at 9:54 PM,

[BUG] ppc64 relocatable vmlinux builds even with undefined symbols

2008-11-18 Thread Milton Miller
With the additon of -pie to build CONFIG_RELOCATABLE CONFIG_PPC64 kernels, even if a function is undefined we still get a vmlinux, System.map, and other files with no error message. This is with binutils 2.17 as built by debian with 2.6.28-rc5, CONFIG_EMBEDDED=y CONFIG_HOTPLUG=n CONFIG_PCI=y,

[PATCH] ppc32: remove secondary_ti

2008-11-16 Thread Milton Miller
Instead of copying current_set[cpu] to secondary_ti, directly index into current_set by the cpu number like head_64.S. In addition to removing the variable, a slow to respond cpu will not clobber another cpus stack. --- grep found no other reference in arch/powerpc. compile tested but I have

[PATCH] hide attr_smt_snooze_delay reference with CONFIG_PPC64

2008-11-16 Thread Milton Miller
attr_smt_snooze_delay is defined for CONFIG_PPC64, so protect the attribute removal with the same condition. /data/home/miltonm/next.git/arch/powerpc/kernel/sysfs.c: In function ‘unregister_cpu_online’: /data/home/miltonm/next.git/arch/powerpc/kernel/sysfs.c:722: error: ‘attr_smt_snooze_delay’

Re: [PATCH] ppc32: remove secondary_ti

2008-11-16 Thread Milton Miller
On Nov 16, 2008, at 2:26 PM, Benjamin Herrenschmidt wrote: On Sun, 2008-11-16 at 15:43 -0600, Milton Miller wrote: Instead of copying current_set[cpu] to secondary_ti, directly index into current_set by the cpu number like head_64.S. In addition to removing the variable, a slow to respond

Re: Re[2]: [2/2] powerpc: support for 256K pages on PPC 44x

2008-11-14 Thread Milton Miller
On Nov 13, 2008, at 10:32 PM, Yuri Tikhonov wrote: On Tuesday, November 11, 2008 Milton Miller wrote: #ifdef CONFIG_PTE_64BIT typedef unsigned long long pte_basic_t; +#ifdef CONFIG_PPC_256K_PAGES +#define PTE_SHIFT (PAGE_SHIFT - 7) This seems to be missing the comment on how many ptes

Re: [PATCH] [v3] powerpc/4xx: work around CHIP11 errata in a more PAGE_SIZE-friendly way

2008-11-14 Thread Milton Miller
In-Reply-To: [EMAIL PROTECTED] On Fri Nov 14 at 06:54:15 EST in 2008, Hollis Blanchard wrote: On Thu, 2008-11-13 at 07:44 +1100, Benjamin Herrenschmidt wrote: Again, why can't we just stick something in the kernel code that reserves the last page ? It could be in prom.c or it could be called

Re: [PATCH] [v3] powerpc/4xx: work around CHIP11 errata in a more PAGE_SIZE-friendly way

2008-11-14 Thread Milton Miller
Resend with correct reply threading. On Fri Nov 14 at 06:54:15 EST in 2008, Hollis Blanchard wrote: On Thu, 2008-11-13 at 07:44 +1100, Benjamin Herrenschmidt wrote: Again, why can't we just stick something in the kernel code that reserves the last page ? It could be in prom.c or it could be

[patch v3] smp-ipi-names

2008-11-14 Thread Milton Miller
for these simple calls. Originally I left the ipi action array exposed, but then I realized the registration code should be common too. The three users each had their own name array, so I made a fourth to convert all users to use a common one. Signed-off-by: Milton Miller [EMAIL PROTECTED

Re: [2/2] powerpc: support for 256K pages on PPC 44x

2008-11-11 Thread Milton Miller
Sorry for the slow reply, but my shell account is broken and I had to post from home. On Nov 10, 2008, at 10:24 AM, Ilya Yanok wrote: This patch adds support for 256K pages on PPC 44x along with some hacks needed for this. This description is insufficient, it describes neither the hacks nor

Re: [PATCH 14/16 v2] powerpc: expand vs demux ipi actions per message

2008-11-11 Thread Milton Miller
On Nov 5, 2008, at 10:42 PM, Paul Mackerras wrote: Milton Miller writes: With the new generic smp call function helpers, I noticed the code in smp_message_recv was a single function call in many cases. While getting the message number from the ipi data is easy, we can reduce the path length

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-11-11 Thread Milton Miller
On Nov 10, 2008, at 9:22 AM, Mohan Kumar M wrote: Yes, elf_ret_symbol sets the copy in purgatory. But the following code in purgatory (to be introduced) LOADADDR(6,run_at_load) ld 18,0(6) cmpd18,1 bne skip li 7,1 stw 7,92(4)

Re: dtc: Add python source code output

2008-11-11 Thread Milton Miller
On Nov 10, 2008, at 11:00 AM, Jimi Xenidis wrote: On Nov 10, 2008, at 10:11 AM, Milton Miller wrote: On 2008-11-07 at 02:31:40, David Gibson wrote: On Thu, Nov 06, 2008 at 06:55:44PM +1100, Michael Ellerman wrote: This commit adds an output format, which produces python code. When run

Re: [2/2] powerpc: support for 256K pages on PPC 44x

2008-11-10 Thread Milton Miller
On 2008-10-16 at 02:22:32, Ilya Yanok wrote: This patch adds support for 256K pages on PPC 44x along with some hacks needed for this. This description is insufficient, it describes neither the hacks nor why they are required. diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index

Re: [1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures

2008-11-10 Thread Milton Miller
On 2008-10-16 at 02:22:31, Ilya Yanok wrote: I started out looking at the too minimal decription of patch 2/2, and that morphed into talking about both patches. diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 587da5e..9627cfd 100644 --- a/arch/powerpc/Kconfig +++

Re: dtc: Add python source code output

2008-11-10 Thread Milton Miller
On 2008-11-07 at 02:31:40, David Gibson wrote: On Thu, Nov 06, 2008 at 06:55:44PM +1100, Michael Ellerman wrote: This commit adds an output format, which produces python code. When run, the python produces a data structure that can then be inspected in order to do various things. ... I'm not

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-11-07 Thread Milton Miller
On Oct 23, 2008, at 10:15 AM, Mohan Kumar M wrote: Hi Milton, My suggestions: Milton Miller wrote: The __kdump_flag ABI is overly constraining for future development. ... Now that we have eliminated the use of __kdump_flag in favor of the standard is_kdump_kernel(), this flag only controls

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-11-07 Thread Milton Miller
On Oct 22, 2008, at 10:43 PM, Paul Mackerras wrote: Paul Mackerras writes: Milton Miller writes: Move the flag to 0x5c, 1 word before the secondary cpu entry point at 0x60. Use the copy at address 0 not the one in the base kernel image to make it easier on kexec-tools. Why is it easier

Re: [PATCH] powerpc: XICS - fix getting the server number size

2008-10-22 Thread Milton Miller
of xics_update_irq_servers() and into xics_init_IRQ(). yes, PAPR says its on one of the interrupt nodes. I am too tired to decipher if it on the presentation or source. Acked-by: Milton Miller [EMAIL PROTECTED] Also this adds a check for mismatched sizes across the interrupt source controller

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Milton Miller
Matt Sealey wrote: Anton Vorontsov wrote: We don't want to encourage the device_type usage. It isn't used in the code, so we can simply remove it from the dts files. I'm extremely troubled that it is not used in the code, surely device_type is checked as a legacy for Open Firmware

build break CONFIG_SPU_FS=n CONFIG_CBE_THERM=y

2008-10-22 Thread Milton Miller
as of 4792adbac9eb41cea77a45ab76258ea10d411173 CONFIG_SPU_FS=n CONFIG_PPC_CELL=y CONFIG_PPC_CELL_NATIVE=y CONFIG_PPC_IBM_CELL_BLADE=y CONFIG_CBE_RAS=y CONFIG_PPC_IBM_CELL_RESETBUTTON=y CONFIG_CBE_THERM=y rest mostly pseries_defconfig. MODPOST vmlinux.o WARNING: modpost: Found 8 section

[PATCH 1/2 kexec-tools] ppc64: new relocatble kernel activation ABI

2008-10-22 Thread Milton Miller
The updates kexec-tools to match the kernel after the patches kexec exit should not use magic numbers and better flag for running relocatable are applied. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- Still proposed change Index: kexec-tools/purgatory/arch/ppc64/v2wrap.S

[PATCH 2/2 kexec-tools] ppc64: segemments are sorted

2008-10-22 Thread Milton Miller
Every time add_segment is called, the segments are sorted. If the first hole in memory is not big enough for the kernel then something besides the kernel may be at Signed-off-by: Milton Miller [EMAIL PROTECTED] --- Found during custom environment testing with several reserved blocks of memory

[PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-10-22 Thread Milton Miller
in the base kernel image to make it easier on kexec-tools. Initialize it with run0 to say it will run at 0 unless it is set to 1. It only exists if we are relocatable. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- I left it global so it appears that way in System.map, but it would not need to be. I

[PATCH 1/3] powerpc: kexec exit should not use magic numbers

2008-10-22 Thread Milton Miller
directly) if something needs to happen. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- keep the whitespace fix at if(crashing_cpu == -1) Index: next.git/arch/powerpc/include/asm/kdump.h === --- next.git.orig/arch/powerpc/include/asm

Re: [PATCH 2/2 kexec-tools] ppc64: segemments are sorted

2008-10-22 Thread Milton Miller
On Oct 22, 2008, at 3:39 PM, Milton Miller wrote: Every time add_segment is called, the segments are sorted. If the first hole in memory is not big enough for the kernel then something besides the kernel may be at info-segment[0]. --- Found during custom environment testing with several

Re: [PATCH] Support for relocatable kdump kernel

2008-10-21 Thread Milton Miller
On Wed Oct 22 at 14:38:10 EST in 2008, Michael Ellerman wrote: This adds relocatable kernel support for kdump. With this one can use the same regular kernel to capture the kdump. A signature (0xfeed1234) is passed in r6 from panic code to the next kernel through kexec_sequence and purgatory

powerpc: always trim to numa memory to lmb_end_of_DRAM

2008-10-20 Thread Milton Miller
not in the linear mapping and this results in a fatal data reference to the unmapped page. Signed-off-by: Milton Miller [EMAIL PROTECTED] -- X-Patchwork-ID: 19577 Changelog edited. Patch compiled on next-20081017 A previous version of this patch, id 11774, also looked if if iommu=off was specified

powerpc: add static and ifdef prom_strtoul and prom_memparse

2008-10-20 Thread Milton Miller
These functions should have been static, and inspection shows they are no longer used. (We used to parse mem= but now we defer that to early_param, and move the initrd and move the device tree if needed). Signed-off-by: Milton Miller [EMAIL PROTECTED] --- X-Patchwork-ID: 19580 Changelog edited

powerpc: pseries, cell: use cpu_thread_in_core in smp_init for of_spin_map

2008-10-20 Thread Milton Miller
, identical code found for cell. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- X-Patchwork-ID: 19578 Resend of July 11 patch, changelog edited. Patch still applies to next-20081017. Note: We assume the secondary threads are not spinning, but they are actually spinning if we start via kexec. This means

powerpc: find and destroy possible stale kernel added properties

2008-10-20 Thread Milton Miller
. Kexec userspace reads the old property, allocates the new kernel at the old kernel's end, and gets rejected by the overlap check. Search and remove these stale properties before adding the new values. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- X-Patchwork-ID: 19579 tested in July

[PATCH 14/16 v2] powerpc: expand vs demux ipi actions per message

2008-10-20 Thread Milton Miller
for these simple calls. Originally I left the ipi action array exposed, but then I realized the registration code should be common too. The three users each had their own name array, so I made a fourth to convert all users to use a common one. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- v2

powerpc: delete prom_strtoul and prom_memparse

2008-10-20 Thread Milton Miller
These functions should have been static, and inspection shows they are no longer used. (We used to parse mem= but we now defer that to early_param). Signed-off-by: Milton Miller [EMAIL PROTECTED] --- This version removes them Index: next.git/arch/powerpc/kernel/prom_init.c

Re: [1/1] powerpc: Update page in counter for CMM

2008-10-20 Thread Milton Miller
X-Patchwork-Id: 5144 On Mon Oct 20, 2008 near 12:19:21 GMT, Brian King wrote: A new field has been added to the VPA as a method for the client OS to communicate to firmware the number of page ins it is performing when running collaborative memory overcommit. The hypervisor will use this

[PATCH 5/16] xics: change arg type to remove casts

2008-10-10 Thread Milton Miller
The xirr is 32 bits in hardware, but the hypervisor requries the upper bits of the register to be clear on the hcall. By changing the type from signed to unsigned int we can drop masking it back to 32 bits. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc/platforms

[PATCH 8/16] xics: factor out giq set and unset

2008-10-10 Thread Milton Miller
There is a bit of math to calculate the arguments to rtas to join or leave the global interrupt queue, and a warning on failure afterwards. Make a helper for the 3 callers. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc/platforms/pseries/xics.c

[PATCH 13/16] powerpc smp: no need to set_need_resched in resched ipi

2008-10-10 Thread Milton Miller
The code was asking Do we have to do this?, and according to x86 and s390 the answer is no, the scheduler will do it before calling the arch hook. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc/kernel/smp.c

[PATCH 14/16] powerpc mpic: use smp_request_message_ipi

2008-10-10 Thread Milton Miller
mpic has 4 ipis so use the new smp_request_message_ipi to reduce pathlength when reciving an ipi. This has the side effect of using the common ipi names, and also continuing to try request the remaining messages when one fails. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch

[PATCH 16/16] powerpc ps3: use smp_request_message_ipi

2008-10-10 Thread Milton Miller
ps3 has 4 ipis per cpu and can use the new smp_request_message_ipi to reduce path length when receiving an ipi. This has the side effect of setting IRQF_PERCPU. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc/platforms/ps3/smp.c

[PATCH 10/16] xics: make printk formats fit on one line

2008-10-10 Thread Milton Miller
Several printks were broken at word boundaries for line length. Some even referred to old function names. Using __func__ and changing the text slightly for the format allows these printk formats to fit on one line. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc

[PATCH 7/16] xics: initialization cleanups

2008-10-10 Thread Milton Miller
We only need to check the ibm,interrupt-server#-size property once, not once per global server and thread. We can use !CONFIG_SMP cpu masks and hard_smp_processor_id() to avoid an ifdef. Put the node when breaking out of the loop on lpar systems. Signed-off-by: Milton Miller [EMAIL PROTECTED

[PATCH 15/16] powerpc cell: use smp_request_message_ipi

2008-10-10 Thread Milton Miller
the ipi is not used. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc/platforms/cell/interrupt.c === --- next.git.orig/arch/powerpc/platforms/cell/interrupt.c 2008-10-04 23:40:24.0 -0500

[PATCH 00/16] xics and ipi cleanups for 2.6.28

2008-10-10 Thread Milton Miller
The first two patches in this series implememnt a couple of bug fixes for the xics interrupt controller accessed as found in pseries hardware. The next several patches implement some code orginization and cleanups, followed by some changes to reduce code or flag the behavior to generic code. The

[PATCH 14/16] powerpc: expand vs demux ipi actions per message

2008-10-10 Thread Milton Miller
and contents, so I made a fourth style for all users. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- Perhaps we should make the common code look like an ipi action handler and remove this last call? Currently we still have to allocate a stack frame to load the return value. Index: next.git/arch

[PATCH 12/16] powerpc: reduce and comment xics ipi memory barrier

2008-10-10 Thread Milton Miller
A single full sync (mb()) is requrired to order the mmio to the qirr reg with the set or clear of the message word. However, test_and_clear_bit has the effect of smp_mb() and we are not doing any other io from here, so we don't need a mb per bit processed. Signed-off-by: Milton Miller [EMAIL

[PATCH 1/16] powerpc pseries: eoi unmapped xics irqs after disable

2008-10-10 Thread Milton Miller
the console irq later in boot, the console is non-functional because we're receiving no console interrupts. Reported-By: Michael Ellerman Signed-off-by: Milton Miller [EMAIL PROTECTED] --- This version is for 2.6.28 based on benh's next branch. For prior kernels, s/irq_radix_revmap_lookup

[PATCH 4/16] xics: rearrange file to group code by function

2008-10-10 Thread Milton Miller
Now that xics_update_irq_servers is called only from init and hotplug code, it becomes possible to clean up the ordering of functions in the file, grouping them but the interfaces they implement. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- This patch is pure function reordering

[PATCH 6/16] xics: trim includes

2008-10-10 Thread Milton Miller
Trim unneeded includes from xics.c. We don't use signals or gfp flags, we use only OF functions and don't need prom, and the 8259 is now handled by our caller. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- asm/smp.h gives us cpu mask accessors for !CONFIG_SMP, used in the next patch Index

[PATCH 11/16] powerpc: mark xics ipi percpu

2008-10-10 Thread Milton Miller
Its physically per-cpu, and we want the irq layer to treat it that way. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc/platforms/pseries/xics.c === --- next.git.orig/arch/powerpc/platforms/pseries/xics.c

[PATCH 3/16] xics: consolidate ipi message encode and decode

2008-10-10 Thread Milton Miller
. Consolidate the code in xics.c similar to mpic and other interrupt controllers. Also, while making the the array static, the message word doesn't need to be volatile as set_bit and test_clear_bit take care of it for us, and put it under ifdef smp. Signed-off-by: Milton Miller [EMAIL PROTECTED

[PATCH 2/16] xics: update default_server during migrate_irqs_away

2008-10-10 Thread Milton Miller
xics_update_irq_servers only reads device tree information, we can call it before xics_init_host in xics_init_IRQ and then default_server will always be valid when we can reach get_irq_server via the host ops. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- I realized the hard vs soft cpu id as I was writing

[PATCH] powerpc: remove non-dependent load fsl_booke PTE_64BIT

2008-10-10 Thread Milton Miller
-off-by: Milton Miller [EMAIL PROTECTED] --- Kumar, I think this is right from my inspection, please review. Index: next.git/arch/powerpc/kernel/head_fsl_booke.S === --- next.git.orig/arch/powerpc/kernel/head_fsl_booke.S 2008-10-05 02

[PATCH 9/16] powerpc: eoi xics ipi by hand in kexec

2008-10-10 Thread Milton Miller
, but we want to leave interrupt delivery blocked until the next kernel takes action. Since the hardware ipi vector is fixed, its easiest to just do the eoi explicitly. Signed-off-by: Milton Miller [EMAIL PROTECTED] Index: next.git/arch/powerpc/platforms/pseries/xics.c

patches for 2.6.28

2008-10-08 Thread Milton Miller
Ben, Paul Please merge or comment on the following patches for 2.6.28. They were originally posted for 2.6.27 as the merge window was opening and got lost in the shuffles. I verified they still applied to Ben's next tree on 10/5, with minor offsets.   powerpc: numa.c: always trim to

Re: [RFC] powerpc/boot: add kernel,end node to the cuboot target

2008-09-30 Thread Milton Miller
On Sep 29, 2008, at 3:04 PM, Sebastian Siewior wrote: * Milton Miller | 2008-09-23 20:24:02 [-0500]: If you have any questions about kdump or what needs to happen, please feel free to contact me I copied most of the 64bit code to parse the device tree without the pci nodes moved

Re: [RFC] powerpc/boot: add kernel,end node to the cuboot target

2008-09-30 Thread Milton Miller
On Sep 30, 2008, at 12:21 PM, Sebastian Siewior wrote: Milton Miller wrote: |load: entry = 0x80053c flags = 0 |nr_segments = 2 |segment[0].buf = 0x1002b8f0 |segment[0].bufsz = 80 |segment[0].mem = (nil) |segment[0].memsz = 1000 |segment[1].buf = 0x4803f008 |segment[1].bufsz = 3a3138

Re: [RFC] powerpc/boot: compare _start against ei.loadsize instead ei.memsize

2008-09-25 Thread Milton Miller
- Original Message Follows - From: Sebastian Siewior [EMAIL PROTECTED] To: Milton Miller [EMAIL PROTECTED] Cc: linuxppc-dev@ozlabs.org, David Gibson [EMAIL PROTECTED], Grant Likely [EMAIL PROTECTED] Subject: Re: [RFC] powerpc/boot: compare _start against ei.loadsize instead ei.memsize Date

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption

2008-09-25 Thread Milton Miller
(I trimmed the cc list for the implementation discussion). On Wed, 24 Sep 2008 11:42:15 -0500 Milton Miller [EMAIL PROTECTED] wrote: On Sep 24, 2008, at 7:30 AM, Sebastien Dugue wrote: Hi Milton, On Wed, 24 Sep 2008 04:58:22 -0500 (CDT) Milton Miller [EMAIL PROTECTED] wrote

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption

2008-09-24 Thread Milton Miller
Jan-Bernd wrote: Ben, can you / your team look into the implementation of the set_irq_type functionality needed for XICS? I'm not volunteering to look at or implement any changes for how xics works with generic irq, but I'm trying to understand what the rt kernel is trying to accomplish with

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption

2008-09-24 Thread Milton Miller
On Sep 24, 2008, at 5:17 AM, Benjamin Herrenschmidt wrote: On Wed, 2008-09-24 at 04:58 -0500, Milton Miller wrote: The per-interrupt mask and unmask calls have to go through RTAS, a single-threaded global context, which in addition to increasing path length will really limit scalability

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption

2008-09-24 Thread Milton Miller
On Sep 24, 2008, at 7:30 AM, Sebastien Dugue wrote: Hi Milton, On Wed, 24 Sep 2008 04:58:22 -0500 (CDT) Milton Miller [EMAIL PROTECTED] wrote: On Mon Sep 15 at 18:04:06 EST in 2008, Sebastien Dugue wrote: When entering the low level handler, level sensitive interrupts are masked, then eio'd

Re: [PATCH HACK] powerpc: quick hack to get a functional eHEA with hardirq preemption

2008-09-24 Thread Milton Miller
On Sep 24, 2008, at 4:16 PM, Benjamin Herrenschmidt wrote: On Wed, 2008-09-24 at 11:42 -0500, Milton Miller wrote: I was trying to understand why the mask and early eoi, but I guess its to handle other more limited interrupt controllers where the interrupts stack in hardware instead

<    1   2   3   4   >