Re: [PATCH v11 09/13] arm64: dts: ls1046a: Add serdes nodes

2023-03-14 Thread Shawn Guo
On Mon, Mar 13, 2023 at 12:11:33PM -0400, Sean Anderson wrote: > This adds nodes for the SerDes devices. They are disabled by default > to prevent any breakage on existing boards. > > Signed-off-by: Sean Anderson The DTS patches look good to me. Let me know if they are ready to be applied.

Re: [PATCH v9 06/10] arm64: dts: ls1046a: Add serdes bindings

2023-01-26 Thread Shawn Guo
On Thu, Jan 26, 2023 at 11:43:26AM -0500, Sean Anderson wrote: > On 1/25/23 18:46, Shawn Guo wrote: > > On Thu, Dec 29, 2022 at 07:01:35PM -0500, Sean Anderson wrote: > >> This adds bindings for the SerDes devices. They are disabled by default > > > > s/bindings/d

Re: [PATCH v9 07/10] arm64: dts: ls1046ardb: Add serdes bindings

2023-01-26 Thread Shawn Guo
On Thu, Jan 26, 2023 at 11:48:53AM -0500, Sean Anderson wrote: > On 1/25/23 18:43, Shawn Guo wrote: > > On Thu, Dec 29, 2022 at 07:01:36PM -0500, Sean Anderson wrote: > >> This adds appropriate bindings for the macs which use the SerDes. The > >> 156.25MHz fixed clo

Re: [PATCH v2 02/10] ARM: dts: ls1021a: add TQ-Systems MBLS102xA device tree

2023-01-26 Thread Shawn Guo
On Fri, Jan 20, 2023 at 02:34:47PM +0100, Alexander Stein wrote: > Add device tree for the MBLS102xA mainboard with TQMLS1021A SoM. > > Signed-off-by: Alexander Stein > --- > Changes in v2: > * Remove unnecessary status = "okay" > * Remove underscore from node names > * Move reg direct below

Re: [PATCH v9 08/10] arm64: dts: ls1088a: Add serdes bindings

2023-01-25 Thread Shawn Guo
On Thu, Dec 29, 2022 at 07:01:37PM -0500, Sean Anderson wrote: > This adds bindings for the SerDes devices. They are disabled by default > to prevent any breakage on existing boards. > > Signed-off-by: Sean Anderson > --- > > (no changes since v4) > > Changes in v4: > - Convert to new bindings

Re: [PATCH v9 06/10] arm64: dts: ls1046a: Add serdes bindings

2023-01-25 Thread Shawn Guo
On Thu, Dec 29, 2022 at 07:01:35PM -0500, Sean Anderson wrote: > This adds bindings for the SerDes devices. They are disabled by default s/bindings/descriptions? The term "bindings" generally means the schema/doc in Documentation/devicetree/bindings/. Shawn > to prevent any breakage on

Re: [PATCH v9 07/10] arm64: dts: ls1046ardb: Add serdes bindings

2023-01-25 Thread Shawn Guo
On Thu, Dec 29, 2022 at 07:01:36PM -0500, Sean Anderson wrote: > This adds appropriate bindings for the macs which use the SerDes. The > 156.25MHz fixed clock is a crystal. The 100MHz clocks (there are > actually 3) come from a Renesas 6V49205B at address 69 on i2c0. There is > no driver for this

Re: [PATCH 07/11] arm64: dts: freescale: Fix pca954x i2c-mux node names

2022-12-31 Thread Shawn Guo
On Fri, Dec 02, 2022 at 05:49:22PM +0100, Geert Uytterhoeven wrote: > "make dtbs_check": > > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtb: pca9547@77: > $nodename:0: 'pca9547@77' does not match '^(i2c-?)?mux' > From schema: >

Re: [PATCH 06/11] ARM: dts: vf610: Fix pca9548 i2c-mux node names

2022-12-31 Thread Shawn Guo
On Fri, Dec 02, 2022 at 05:49:21PM +0100, Geert Uytterhoeven wrote: > "make dtbs_check": > > arch/arm/boot/dts/vf610-zii-dev-rev-b.dtb: tca9548@70: $nodename:0: > 'tca9548@70' does not match '^(i2c-?)?mux' > From schema: > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml

Re: [PATCH 03/11] ARM: dts: imx: Fix pca9547 i2c-mux node name

2022-12-31 Thread Shawn Guo
On Fri, Dec 02, 2022 at 05:49:18PM +0100, Geert Uytterhoeven wrote: > "make dtbs_check": > > arch/arm/boot/dts/imx53-ppd.dtb: i2c-switch@70: $nodename:0: > 'i2c-switch@70' does not match '^(i2c-?)?mux' > From schema: > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml >

Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init()

2022-07-04 Thread Shawn Guo
On Tue, Jun 28, 2022 at 10:02:48PM +0800, Yang Yingliang wrote: > In case of error, of_iomap() returns NULL pointer not ERR_PTR(). > The IS_ERR() test in the return value check should be replaced > with NULL test and return -ENOMEM as error value. > > Fixes: ab4988d6a393 ("soc: fsl: guts: embed

Re: [PATCH RESEND v2 0/7] soc: fsl: guts: cleanups and serial_number support

2022-06-27 Thread Shawn Guo
On Wed, Jun 22, 2022 at 01:03:33PM +0200, Michael Walle wrote: > Am 2022-04-04 11:56, schrieb Michael Walle: > > [Resend because of new development cycle. Shawn, can this series get > > through your tree? Sorry you weren't on CC on the former submissions.] > > > > This series converts the guts

Re: [PATCH v3 2/4] arm64: dts: freescale: reduce the interrup-map-mask

2022-05-04 Thread Shawn Guo
On Wed, Apr 27, 2022 at 09:53:36AM +0200, Michael Walle wrote: > Reduce the interrupt-map-mask of the external interrupt controller to > 0xf to align with the devicetree schema. > > Signed-off-by: Michael Walle Applied, thanks!

Re: [PATCH v3 1/4] ARM: dts: ls1021a: reduce the interrupt-map-mask

2022-05-04 Thread Shawn Guo
On Wed, Apr 27, 2022 at 09:53:35AM +0200, Michael Walle wrote: > Reduce the interrupt-map-mask of the external interrupt controller to > 7 to align with the devicetree schema. > > Signed-off-by: Michael Walle Applied, thanks!

Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-24 Thread Shawn Guo
On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote: > Hi Xiaowei, Hi Shawn, > > > LS1028a implements 2 PCIe 3.0 controllers. > > Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about this patch > anymore :( > > This doesn't work well with the IOMMU, because the

Re: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for dcfg

2019-12-11 Thread Shawn Guo
On Tue, Dec 10, 2019 at 02:34:30AM +, Y.b. Lu wrote: > + Shawn, > > > -Original Message- > > From: Michael Walle > > Sent: Tuesday, December 10, 2019 8:06 AM > > To: Yinbo Zhu > > Cc: Ashish Kumar ; Alexandru Marginean > > ; Alison Wang ; > > Amit Jain (aj) ;

Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support

2019-10-03 Thread Shawn Guo
On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote: > Add support for the LS1028a PCIe controller. > > Signed-off-by: Xiaowei Bao > Signed-off-by: Hou Zhiqiang > --- > v2: > - No change. > v3: > - Reuse the ls2088 driver data structurt. > v4: > - No change. > v5: > - No change. >

Re: [PATCH v2 18/34] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2019-01-10 Thread Shawn Guo
On Thu, Jan 10, 2019 at 10:44:03AM +, Vokáč Michal wrote: ... > > What happened to this? It seems the patch did not hit v5.0-rc1. > > Hi Shawn, > Rob actually asked you a similar question two days ago.. > > https://lkml.org/lkml/2019/1/8/754 Oops, it seems there were some miscommunication

Re: [PATCH v2 18/34] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2019-01-09 Thread Shawn Guo
On Sat, Dec 08, 2018 at 09:58:37AM +0800, Shawn Guo wrote: > On Thu, Dec 06, 2018 at 05:33:13PM -0600, Rob Herring wrote: > > On Wed, Dec 5, 2018 at 8:32 PM Shawn Guo wrote: > > > > > > On Mon, Dec 03, 2018 at 03:32:07PM -0600, Rob Herring wrote: > > > &g

Re: [PATCH v3 06/12] arm: perf/core: use PERF_PMU_CAP_NO_EXCLUDE for exclude incapable PMUs

2018-12-09 Thread Shawn Guo
move the now unnecessary check for exclusion flags. > > Signed-off-by: Andrew Murray > --- > arch/arm/mach-imx/mmdc.c | 9 ++--- For imx mmdc changes: Acked-by: Shawn Guo

Re: [PATCH v2 18/34] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2018-12-07 Thread Shawn Guo
On Thu, Dec 06, 2018 at 05:33:13PM -0600, Rob Herring wrote: > On Wed, Dec 5, 2018 at 8:32 PM Shawn Guo wrote: > > > > On Mon, Dec 03, 2018 at 03:32:07PM -0600, Rob Herring wrote: > > > Convert Freescale SoC bindings to DT schema format using json-schema. > > > &g

Re: [PATCH v2 34/34] dt-bindings: arm: Convert ZTE board/soc bindings to json-schema

2018-12-05 Thread Shawn Guo
On Mon, Dec 03, 2018 at 03:32:23PM -0600, Rob Herring wrote: > Convert ZTE SoC bindings to DT schema format using json-schema. > > Cc: Jun Nie > Cc: Mark Rutland > Cc: linux-arm-ker...@lists.infradead.org > Cc: devicet...@vger.kernel.org > Acked-by: Shawn Guo > Si

Re: [PATCH v2 18/34] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2018-12-05 Thread Shawn Guo
On Mon, Dec 03, 2018 at 03:32:07PM -0600, Rob Herring wrote: > Convert Freescale SoC bindings to DT schema format using json-schema. > > Cc: Shawn Guo > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/arm

Re: [v11 6/7] arm64: dts: ls1046a: add qdma device tree nodes

2018-12-05 Thread Shawn Guo
On Tue, Oct 30, 2018 at 10:36:03AM +0800, Peng Ma wrote: > add the qDMA device tree nodes for LS1046A devices. > > Signed-off-by: Wen He > Signed-off-by: Peng Ma > --- > change in v11: > - no > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 21 + > 1 files

Re: [v11 5/7] arm64: dts: ls1043a: add qdma device tree nodes

2018-12-05 Thread Shawn Guo
On Tue, Oct 30, 2018 at 10:36:02AM +0800, Peng Ma wrote: > add the qDMA device tree nodes for LS1043A devices. > > Signed-off-by: Wen He > Signed-off-by: Peng Ma > --- > change in v11: > - no > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 22 ++ > 1 files

Re: [v11 4/7] arm: dts: ls1021a: add qdma device tree nodes

2018-12-05 Thread Shawn Guo
On Tue, Oct 30, 2018 at 10:36:01AM +0800, Peng Ma wrote: > add the qDMA device tree nodes for LS1021A devices. > > Signed-off-by: Wen He > Signed-off-by: Peng Ma Applied, thanks.

Re: [PATCHv2 2/6] ARM: dts: ls1021a: Add the status property disable PCIe

2018-11-15 Thread Shawn Guo
On Mon, Nov 05, 2018 at 04:46:49PM +0800, Xiaowei Bao wrote: > Add the status property disable the PCIe, the property will be enable > by bootloader. > > Signed-off-by: Xiaowei Bao Applied, thanks.

Re: [PATCHv2 1/6] arm64: dts: Add the status property disable PCIe

2018-11-15 Thread Shawn Guo
On Mon, Nov 05, 2018 at 04:46:48PM +0800, Xiaowei Bao wrote: > From: Bao Xiaowei > > Add the status property disable the PCIe, the property will be enable > by bootloader. > > Signed-off-by: Bao Xiaowei Changed prefix to 'arm64: dts: fsl: ...' and applied the patch. Shawn

Re: [PATCH v7 6/6] arm64: dts: add LX2160ARDB board support

2018-10-31 Thread Shawn Guo
On Mon, Oct 29, 2018 at 08:58:01AM +, Vabhav Sharma wrote: > LX2160A reference design board (RDB) is a high-performance > computing, evaluation, and development platform with LX2160A > SoC. > > Signed-off-by: Priyanka Jain > Signed-off-by: Sriram Dash > Signed-off-by: Vabhav Sharma >

Re: [PATCH v7 5/6] arm64: dts: add QorIQ LX2160A SoC support

2018-10-31 Thread Shawn Guo
On Mon, Oct 29, 2018 at 08:57:54AM +, Vabhav Sharma wrote: > LX2160A SoC is based on Layerscape Chassis Generation 3.2 Architecture. > > LX2160A features an advanced 16 64-bit ARM v8 CortexA72 processor cores > in 8 cluster, CCN508, GICv3,two 64-bit DDR4 memory controller, 8 I2C >

Re: [PATCH 36/36] dt-bindings: arm: Convert ZTE board/soc bindings to json-schema

2018-10-08 Thread Shawn Guo
On Fri, Oct 05, 2018 at 11:58:48AM -0500, Rob Herring wrote: > Convert ZTE SoC bindings to DT schema format using json-schema. > > Cc: Jun Nie > Cc: Baoyou Xie > Cc: Shawn Guo > Cc: Mark Rutland > Cc: linux-arm-ker...@lists.infradead.org > Cc: devicet...@vger.kernel.

Re: [PATCH 22/36] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2018-10-08 Thread Shawn Guo
On Fri, Oct 05, 2018 at 11:58:34AM -0500, Rob Herring wrote: > Convert Freescale SoC bindings to DT schema format using json-schema. > > Cc: Shawn Guo > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/arm

Re: [PATCH 06/36] dt-bindings: arm: zte: Move sysctrl bindings to their own doc

2018-10-08 Thread Shawn Guo
On Fri, Oct 05, 2018 at 11:58:18AM -0500, Rob Herring wrote: > In preparation to convert board-level bindings to json-schema, move > various misc SoC bindings out to their own file. > > Cc: Mark Rutland > Cc: Jun Nie > Cc: Baoyou Xie > Cc: Shawn Guo > Cc: devicet

Re: [PATCH 04/36] dt-bindings: arm: fsl: Move DCFG and SCFG bindings to their own docs

2018-10-08 Thread Shawn Guo
On Fri, Oct 05, 2018 at 11:58:16AM -0500, Rob Herring wrote: > In preparation to convert board-level bindings to json-schema, move > various misc SoC bindings out to their own file. > > Cc: Shawn Guo > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by

Re: [PATCH v4 6/6] arm64: dts: add LX2160ARDB board support

2018-10-08 Thread Shawn Guo
On Thu, Oct 04, 2018 at 06:33:51AM +0530, Vabhav Sharma wrote: > LX2160A reference design board (RDB) is a high-performance > computing, evaluation, and development platform with LX2160A > SoC. > > Signed-off-by: Priyanka Jain > Signed-off-by: Sriram Dash > Signed-off-by: Vabhav Sharma > --- >

Re: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support

2018-10-08 Thread Shawn Guo
On Thu, Oct 04, 2018 at 06:33:50AM +0530, Vabhav Sharma wrote: > LX2160A SoC is based on Layerscape Chassis Generation 3.2 Architecture. > > LX2160A features an advanced 16 64-bit ARM v8 CortexA72 processor cores > in 8 cluster, CCN508, GICv3,two 64-bit DDR4 memory controller, 8 I2C >

Re: [PATCH] fix double ;;s in code

2018-02-24 Thread Shawn Guo
On Sat, Feb 24, 2018 at 09:52:27AM +0100, Pavel Machek wrote: > Hi! > > > > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > > > index 53f7275..cfb42f5 100644 > > > --- a/drivers/soc/imx/gpc.c > > > +++ b/drivers/soc/imx/gpc.c > > > @@ -348,7 +348,7 @@ static int

Re: [PATCH] fix double ;;s in code

2018-02-22 Thread Shawn Guo
Hi Pavel, On Sat, Feb 17, 2018 at 10:19:55PM +0100, Pavel Machek wrote: ... > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > index 53f7275..cfb42f5 100644 > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device

Re: [PATCH] mtd: nand: Rename nand.h into rawnand.h

2017-08-09 Thread Shawn Guo
rawnand.h so we can later create a nand.h header > containing all common structure and function prototypes. > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> > Signed-off-by: Peter Pan <peterpand...@micron.com> ... > arch/arm/mach-imx/mach-qong.c

Re: [PATCH V2 3/5] arm:dt:ls1021a: Add TMU device tree support for LS1021A

2016-10-24 Thread Shawn Guo
On Sun, Oct 09, 2016 at 02:47:04PM +0800, Jia Hongtao wrote: > From: Hongtao Jia > > Also add nodes and properties for thermal management support. > > Signed-off-by: Jia Hongtao For patch #3 ~ #5, I updated the subject prefix a bit and applied. Shawn

Re: [PATCH V2 1/5] powerpc/mpc85xx: Update TMU device tree node for T1040/T1042

2016-10-24 Thread Shawn Guo
On Sun, Oct 09, 2016 at 02:47:02PM +0800, Jia Hongtao wrote: > From: Hongtao Jia > > SoC compatible string and endianness property are added according to the > new bindings. The commit log doesn't seem to match the actual changes. Same for patch 2/5. Shawn > >

Re: [PATCH 0/2] clk: imx6: add kpp clock for i.MX6UL

2016-02-27 Thread Shawn Guo
On Thu, Feb 25, 2016 at 03:56:55PM -0800, Stephen Boyd wrote: > On 01/12, Lothar Waßmann wrote: > > This patchset adds the clock which is necessary to operate the KPP > > unit on i.MX6UL. > > The first patch removes bogus whitespace before TABs in indentation. > > The second patch adds the clock

Re: [PATCH v3 1/2] fsl: Add binding for RCPM

2015-09-24 Thread Shawn Guo
On Thu, Sep 24, 2015 at 04:29:13PM +0800, Dongsheng Wang wrote: > From: Wang Dongsheng > > RCPM is the Run Control and Power Management module performs all > device-level tasks associated with device run control and power > management. > > Add this for freescale

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Shawn Guo
On Tue, Sep 16, 2014 at 07:24:40PM -0700, Nicolin Chen wrote: It's not supported in the clock API or just not implemented in our code? Can we just register a clock without CLK_SET_RATE_PARENT to achieve the purpose? (We are just trying to fix those PRED and PODF dividers when the driver calls

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Shawn Guo
On Tue, Sep 16, 2014 at 11:19:28AM -0700, Nicolin Chen wrote: On Tue, Sep 16, 2014 at 07:46:34PM +0800, Shengjiu Wang wrote: The spdif root clock may be used by other module or defined with CLK_SET_RATE_GATE, so we can't change the clock rate in driver. In this patch remove the clk_set_rate

Re: [PATCH v2 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-24 Thread Shawn Guo
-by: Nicolin Chen nicoleots...@gmail.com Acked-by: Shawn Guo shawn@linaro.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v5] ASoC: fsl_sai: Add clock controls for SAI

2014-04-10 Thread Shawn Guo
just go via IMX tree, since nothing should be broken on sound tree even without dts change? Shawn Signed-off-by: Nicolin Chen guangyu.c...@freescale.com Acked-by: Xiubo Li li.xi...@freescale.com Acked-by: Shawn Guo shawn@linaro.org --- Changelog v5: * Dropped mclk preparing

Re: [PATCH v3 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform

2014-04-09 Thread Shawn Guo
On Fri, Apr 04, 2014 at 06:08:13PM +0800, Nicolin Chen wrote: Since we added fours clock to the DT binding, we should update the current SAI dts/dtsi so as not to break their functions. If so, shouldn't the change be in the same patch as driver change? Shawn Signed-off-by: Nicolin Chen

Re: [PATCH v3 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform

2014-04-09 Thread Shawn Guo
On Fri, Apr 04, 2014 at 06:08:13PM +0800, Nicolin Chen wrote: Since we added fours clock to the DT binding, we should update the current SAI dts/dtsi so as not to break their functions. For the record, you're asking my ACK to have the dts change go via sound tree for not breaking vf610 function

Re: [PATCH v2 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform

2014-04-02 Thread Shawn Guo
On Wed, Apr 02, 2014 at 06:10:20PM +0800, Nicolin Chen wrote: Since we added fours clock to the DT binding, we should update the current SAI dts/dtsi so as not to break their functions. Signed-off-by: Nicolin Chen guangyu.c...@freescale.com --- arch/arm/boot/dts/vf610.dtsi | 6 -- 1

Re: [PATCH 2/3] dts: mpc512x: adjust clock specs for FEC nodes

2014-03-04 Thread Shawn Guo
On Mon, Mar 03, 2014 at 10:22:31AM +0100, Gerhard Sittig wrote: On Mon, Feb 24, 2014 at 11:25 +0100, Gerhard Sittig wrote: a recent FEC binding document update that was motivated by i.MX development revealed that ARM and PowerPC implementations in Linux did not agree on the clock names

Re: [PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-24 Thread Shawn Guo
On Sat, Nov 23, 2013 at 12:31:32AM +0800, Nicolin Chen wrote: Hi all, I'm sorry to push this. But this series has been an orphan for a while. Could any one please receive and foster it? Vinod, I expect you will pick up the series. But otherwise, I can apply it via IMX tree with your

Re: [PATCH 0/2] Add monaural audio support for fsl_ssi.c

2013-11-14 Thread Shawn Guo
On Thu, Nov 14, 2013 at 07:07:08PM +0800, Nicolin Chen wrote: This series of patches need to be applied into one single tree because the second patch depends on the first one. Without it, SSI would playback constant noise to the right channel when playback monaural audio files on i.MX6 Series

Re: [PATCH 0/2] Add monaural audio support for fsl_ssi.c

2013-11-14 Thread Shawn Guo
On Fri, Nov 15, 2013 at 10:59:57AM +0800, Nicolin Chen wrote: Hi Shawn, On Fri, Nov 15, 2013 at 11:02:49AM +0800, Shawn Guo wrote: On Thu, Nov 14, 2013 at 07:07:08PM +0800, Nicolin Chen wrote: This series of patches need to be applied into one single tree because the second patch

Re: [PATCH 1/2] ARM: dts: imx: specify the value of audmux pinctrl instead of 0x80000000

2013-11-14 Thread Shawn Guo
On Thu, Nov 14, 2013 at 07:07:09PM +0800, Nicolin Chen wrote: We must specify the value of audmux pinctrl if we want to use pinctrl_pm(). Thus change bypass value 0x8000 to what we exactly need. This patch also seperately unset PUE bit for TXD so that IOMUX won't pull up/down the pin

Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-06 Thread Shawn Guo
On Wed, Nov 06, 2013 at 03:53:24AM +, Li Xiubo wrote: If there are any comments that say PPC but are not PPC-specific, that should be fixed. Yes, find it. The comments is in sound/soc/fsl/Makefile : +++ # Freescale PowerPC SSI/DMA Platform Support ---

Re: [PATCH v4 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-01 Thread Shawn Guo
: fsl_ssi: Add dual fifo mode support ARM: dts: imx: use dual-fifo sdma script for ssi Vinod, To keep git bisect, the series has to be merged through single tree. Since Mark has ACK-ed patch #3, I think it's easier to merge the series through your tree, so for patch #4: Acked-by: Shawn Guo shawn

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Shawn Guo
On Fri, Nov 01, 2013 at 06:28:05PM +0800, Nicolin Chen wrote: sound/soc/fsl/fsl-sgtl5000-vf610.c | 208 + I just doubt if this file naming is appropriate. Even if we might not have rigor rule for the file names, according to existing ones, they are all

Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes

2013-09-10 Thread Shawn Guo
On Tue, Sep 10, 2013 at 11:56:17AM +0100, Sudeep KarkadaNagesha wrote: So we only need to change all clkdev registration to use cpu0 as dev_id intstead of cpufreq-cpu0.0, something like below. And for imx, it should work even without the changes, because we have device tree lookup ready

Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes

2013-09-09 Thread Shawn Guo
Hi Sudeep, On Mon, Sep 09, 2013 at 10:24:39AM +0100, Sudeep KarkadaNagesha wrote: Hi Shawn, Can you please clarify ? The fix would be as below but I would like to know if setting cpu_dev to get_cpu_device(0) instead of pdev-dev has any impact on other parts of code using cpu_dev ? I'm

Re: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes

2013-09-09 Thread Shawn Guo
On Mon, Sep 09, 2013 at 04:24:18PM +0100, Sudeep KarkadaNagesha wrote: Hi Shawn, Ok. But I am bit suspicious about devm_clk_get(cpu_dev, NULL). I don't understand completely as how the clock are registered(whether with dev_id or with connection_id). As the connection_id of devm_clk_get()

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Shawn Guo
On Mon, Aug 19, 2013 at 10:54:33AM +0100, Mark Rutland wrote: I guess it's better to drop the 'imx6q-spdif' here? That depends: * If the two IP blocks are identical, only the imx35-spdif name is necessary, and we can forget about fsl,imx6q-spdif. * If fsl,imx6q-spdif is a strict

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-15 Thread Shawn Guo
On Thu, Aug 15, 2013 at 10:18:23AM +0800, Nicolin Chen wrote: Hi Stephen, On Wed, Aug 14, 2013 at 09:47:19AM -0600, Stephen Warren wrote: If the clock source name list is different, then it needs a different compatible value, so that each compatible value can specify which clock names

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Shawn Guo
On Wed, Aug 14, 2013 at 01:30:17PM +0800, Nicolin Chen wrote: Hi Shwan, On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote: I do not think we need this general compatible string. Device tree compatible should be specific. So I should just use 'fsl,chip-spdif and list all chip

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Shawn Guo
On Wed, Aug 14, 2013 at 02:34:45PM +0800, Nicolin Chen wrote: On Wed, Aug 14, 2013 at 02:39:33PM +0800, Shawn Guo wrote: We only need to maintain those versions that require different programming model in the list. For example, if S/PDIF on Vybrid is completely compatible with imx6q one

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Shawn Guo
On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen b42...@freescale.com wrote: +Required properties: + + - compatible : Compatible list, contains fsl,chip-spdif. Using general Can't we just use fsl,fsl-spdif instead? +

Re: [PATCH] ASoC: fsl: Set sdma peripheral type directly

2013-07-25 Thread Shawn Guo
...@freescale.com Acked-by: Shawn Guo shawn@linaro.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-12 Thread Shawn Guo
On Fri, Jul 12, 2013 at 07:11:35AM -0500, Timur Tabi wrote: Mark Brown wrote: Yes, that's why I just went ahead - you'd said recently that you'd be out of action for a while and not able to test anything. Yeah, I'd rather you waited until I at least made sure it compiled. Is there any way

Re: [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-11 Thread Shawn Guo
using symmetric_rate. Signed-off-by: Nicolin Chen b42...@freescale.com Acked-by: Shawn Guo shawn@linaro.org --- sound/soc/fsl/fsl_ssi.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 2f2d837

Re: [PATCH v2] can: flexcan: remove HAVE_CAN_FLEXCAN Kconfig symbol

2013-05-17 Thread Shawn Guo
dependency warning found by Arnd Bergmann: warning: (SOC_IMX28 SOC_IMX25 SOC_IMX35 IMX_HAVE_PLATFORM_FLEXCAN SOC_IMX53 SOC_IMX6Q) selects HAVE_CAN_FLEXCAN which has unmet direct dependencies (NET CAN CAN_DEV) Cc: Arnd Bergmann a...@arndb.de Cc: Shawn Guo shawn

Re: [PATCH] can: flexcan: allow compilation on arm and powerpc

2013-05-16 Thread Shawn Guo
Hi Marc, On Thu, May 16, 2013 at 03:42:36PM +0200, Marc Kleine-Budde wrote: This patch removes the Kconfig symbols HAVE_CAN_FLEXCAN and IMX_HAVE_PLATFORM_FLEXCAN from arch/{arm,powerpc} and allowing compilation on all arm and powerpc platforms. I'm generally fine with the approach. But with

Re: [PATCH 2/2] of: use platform_device_add

2013-02-16 Thread Shawn Guo
On Fri, Jan 18, 2013 at 01:40:00AM +, Grant Likely wrote: This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At a minimum this fills in proc/iomem and presumably makes resource tracking and conflict detection work better. However, it has the

Re: [PATCH 2/2] of: use platform_device_add

2013-02-16 Thread Shawn Guo
On Sun, Feb 17, 2013 at 11:03:35AM +0800, Shawn Guo wrote: On Fri, Jan 18, 2013 at 01:40:00AM +, Grant Likely wrote: This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At a minimum this fills in proc/iomem and presumably makes resource

Re: [PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Shawn Guo
peter.c...@freescale.com do I get Acked-by for this one ? Acked-by: Shawn Guo shawn@linaro.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v7 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Shawn Guo
SoB, since I have provided it on v6 of this patch. It will make balbi's life a little bit easier when he applies the patch. So again, Acked-by: Shawn Guo shawn@linaro.org Shawn ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-15 Thread Shawn Guo
On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly.

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-13 Thread Shawn Guo
Balbi, On Fri, Jan 11, 2013 at 02:50:59PM +0200, Felipe Balbi wrote: As I said before, this patch is too big for -rc and is unnecessary considering patch I wrote above. Note that there is no problems in checking if ULPI PHY clk is 60MHz on all arches and, for the workaround, you already have

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-11 Thread Shawn Guo
On Fri, Jan 11, 2013 at 12:56:51PM +0200, Felipe Balbi wrote: Hi, On Fri, Jan 11, 2013 at 05:56:28PM +0800, Peter Chen wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the SoC type, and updates the platform code accordingly. Compile ok at

Re: [PATCH] powerpc: select PPC_CLOCK unconditionally for FSL_SOC

2012-04-04 Thread Shawn Guo
Kumar, Gentle ping ... Regards, Shawn On Fri, Mar 30, 2012 at 01:38:56PM +0800, Shawn Guo wrote: Freescale PowerPC SoCs share a number of IP blocks with Freescale ARM/IMX SoCs, FlexCAN, SSI, FEC, eSDHC, USB, etc. There are some effort consolidating those drivers to make them work for both

Re: [alsa-devel] [PATCH] powerpc: select PPC_CLOCK unconditionally for FSL_SOC

2012-04-04 Thread Shawn Guo
On 4 April 2012 23:00, Kumar Gala ga...@kernel.crashing.org wrote: ... What timeframe are you looking for this to go in? 3.4 or 3.5? 3.5 Thanks, Shawn ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

2012-03-09 Thread Shawn Guo
On Tue, Mar 06, 2012 at 10:33:21PM +, Russell King - ARM Linux wrote: ... drivers/dma/imx-sdma.c | 23 ++-- ... drivers/dma/mxs-dma.c| 23 ++-- Tested-by: Shawn Guo shawn@linaro.org

Re: [PATCH v3 24/25] irq_domain: remove hint when allocating irq numbers

2012-02-15 Thread Shawn Guo
On Wed, Feb 15, 2012 at 01:21:45PM -0700, Grant Likely wrote: On Wed, Feb 15, 2012 at 04:04:28PM +0100, Nicolas Ferre wrote: On 02/07/2012 07:07 PM, Nicolas Ferre : On 01/27/2012 10:36 PM, Grant Likely : The 'hint' used to try and line up irq numbers with hw irq numbers is rather a

Re: [PATCH v3 24/25] irq_domain: remove hint when allocating irq numbers

2012-02-15 Thread Shawn Guo
On Wed, Feb 15, 2012 at 10:32:43PM -0700, Grant Likely wrote: ... That's a bug then. The implementation should work without patch 24. Does this patch fix it? Yes, it fixes the problem for me. Regards, Shawn --- diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index

Re: [PATCH v3 14/25] irq_domain: Remove irq_domain_add_simple()

2012-01-31 Thread Shawn Guo
On Fri, Jan 27, 2012 at 02:36:08PM -0700, Grant Likely wrote: irq_domain_add_simple() was a stop-gap measure until complete irq_domain support was complete. This patch removes the irq_domain_add_simple() interface. v2: Updated to pass in host_data pointer on irq_domain allocation.

Re: [PATCH v3 14/25] irq_domain: Remove irq_domain_add_simple()

2012-01-31 Thread Shawn Guo
On Tue, Jan 31, 2012 at 07:15:26AM -0600, Rob Herring wrote: ... --- a/arch/arm/mach-mx5/imx51-dt.c +++ b/arch/arm/mach-mx5/imx51-dt.c @@ -47,7 +47,7 @@ static const struct of_dev_auxdata imx51_auxdata_lookup[] __initconst = { static int __init imx51_tzic_add_irq_domain(struct

Re: [PATCH 2/2] Kbuild: Use dtc's -d (dependency) option

2012-01-09 Thread Shawn Guo
) to work. Signed-off-by: Stephen Warren swar...@nvidia.com Though I did not look into the patches deeply, I know the problem very well and it annoys me a lot. It's great that we have patches to fix it, so Acked-by: Shawn Guo shawn@linaro.org -- Regards, Shawn

Re: [PATCH v3 0/4] Consolidate sdhci pltfm OF drivers and get them self registered

2011-05-27 Thread Shawn Guo
On Fri, May 27, 2011 at 10:06:50AM +0200, Wolfram Sang wrote: Any chance we can get this series into $NEXT_KERNEL? From the looks, I think it still has problems being a module. Will try to test it today. Sorry. I forgot testing module build. I'm fixing it. -- Regards, Shawn

[PATCH v4 0/4] Consolidate sdhci pltfm OF drivers and get them self registered

2011-05-27 Thread Shawn Guo
to ease reviewing Shawn Guo (4): mmc: sdhci: make sdhci-pltfm device drivers self registered mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data mmc: sdhci: make sdhci-of device drivers self registered mmc: sdhci: merge two sdhci-pltfm.h into one drivers/mmc/host/Kconfig

[PATCH v4 1/4] mmc: sdhci: make sdhci-pltfm device drivers self registered

2011-05-27 Thread Shawn Guo
. Signed-off-by: Shawn Guo shawn@linaro.org Reviewed-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Anton Vorontsov cbouatmai...@gmail.com --- drivers/mmc/host/Kconfig | 29 +++- drivers/mmc/host/Makefile | 14 ++-- drivers/mmc

[PATCH v4 2/4] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data

2011-05-27 Thread Shawn Guo
The patch migrates the use of sdhci_of_host and sdhci_of_data to sdhci_pltfm_host and sdhci_pltfm_data, so that the former pair can be eliminated. Signed-off-by: Shawn Guo shawn@linaro.org Reviewed-by: Grant Likely grant.lik...@secretlab.ca Reviewed-by: Wolfram Sang w.s...@pengutronix.de

[PATCH v4 3/4] mmc: sdhci: make sdhci-of device drivers self registered

2011-05-27 Thread Shawn Guo
common things merged into sdhci-pltfm.c and sdhci-pltfm.h respectively. Signed-off-by: Shawn Guo shawn@linaro.org Acked-by: Anton Vorontsov cbouatmai...@gmail.com Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mmc/host/Kconfig | 13 +-- drivers/mmc/host/Makefile

[PATCH v4 4/4] mmc: sdhci: merge two sdhci-pltfm.h into one

2011-05-27 Thread Shawn Guo
The structure sdhci_pltfm_data is not necessarily to be in a public header like include/linux/mmc/sdhci-pltfm.h, so the patch moves it into drivers/mmc/host/sdhci-pltfm.h and eliminates the former one. Signed-off-by: Shawn Guo shawn@linaro.org Reviewed-by: Grant Likely grant.lik

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-25 Thread Shawn Guo
On Tue, May 24, 2011 at 09:40:54PM +0200, Wolfram Sang wrote: On Thu, May 05, 2011 at 09:22:56PM +0800, Shawn Guo wrote: This patch is to consolidate SDHCI driver for Freescale eSDHC controller found on both MPCxxx and i.MX platforms. It merges sdhci-of-esdhc.c into sdhci-esdhc.c, so

Re: [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx

2011-05-25 Thread Shawn Guo
Hi Uwe, On Wed, May 25, 2011 at 08:46:19AM +0200, Uwe Kleine-König wrote: Hello Shawn, +#ifndef CONFIG_MMC_SDHCI_ESDHC_IMX +#define cpu_is_mx25() (0) +#define cpu_is_mx35() (0) +#define cpu_is_mx51() (0) +#define cpu_is_imx() (0) +#else +#define cpu_is_imx()

[PATCH v3 0/4] Consolidate sdhci pltfm OF drivers and get them self registered

2011-05-25 Thread Shawn Guo
and sdhci_pltfm_unregister * Eliminate variable 'scratch' in .remove hook to make the code look simple * Return ERR_PTR in sdhci_pltfm_init and use IS_ERR/PTR_ERR to check return value in .probe hooks * Correct MODULE_AUTHOR statement * Split esdhc conlidation patch to ease reviewing Shawn Guo (4

[PATCH v3 1/4] mmc: sdhci: make sdhci-pltfm device drivers self registered

2011-05-25 Thread Shawn Guo
. Signed-off-by: Shawn Guo shawn@linaro.org Reviewed-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Anton Vorontsov cbouatmai...@gmail.com --- drivers/mmc/host/Kconfig | 32 drivers/mmc/host/Makefile | 11 +-- drivers/mmc/host

[PATCH v3 3/4] mmc: sdhci: make sdhci-of device drivers self registered

2011-05-25 Thread Shawn Guo
common things merged into sdhci-pltfm.c and sdhci-pltfm.h respectively. Signed-off-by: Shawn Guo shawn@linaro.org Acked-by: Anton Vorontsov cbouatmai...@gmail.com Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mmc/host/Kconfig | 15 +-- drivers/mmc/host/Makefile

[PATCH v3 4/4] mmc: sdhci: merge two sdhci-pltfm.h into one

2011-05-25 Thread Shawn Guo
The structure sdhci_pltfm_data is not necessarily to be in a public header like include/linux/mmc/sdhci-pltfm.h, so the patch moves it into drivers/mmc/host/sdhci-pltfm.h and eliminates the former one. Signed-off-by: Shawn Guo shawn@linaro.org Reviewed-by: Grant Likely grant.lik

[PATCH v3 2/4] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data

2011-05-25 Thread Shawn Guo
The patch migrates the use of sdhci_of_host and sdhci_of_data to sdhci_pltfm_host and sdhci_pltfm_data, so that the former pair can be eliminated. Signed-off-by: Shawn Guo shawn@linaro.org Reviewed-by: Grant Likely grant.lik...@secretlab.ca Reviewed-by: Wolfram Sang w.s...@pengutronix.de

Re: [PATCH v2 0/7] Consolidate sdhci pltfm OF drivers and get them self registered

2011-05-19 Thread Shawn Guo
Hi Wolfram, On Thu, May 19, 2011 at 11:40:46AM +0200, Wolfram Sang wrote: Hi Shawn, Changes since v1: * Rebase on cjb's mmc-next tree Is it maybe possible that you get access to http://opensource.freescale.com/git or another machine? A branch to pull from would be more convenient,

  1   2   >