Re: [PATCH treewide 0/9] Remove obsolete IDE headers

On 8/18/23 01:07, Geert Uytterhoeven wrote: > Hi all, > > This patch series removes all unused headers and > . was still included by 3 PATA > drivers for m68k platforms, but without any real need. > > The first 5 patches have no dependencies. > The last patch depends on the 3 pata

[PATCH treewide 0/9] Remove obsolete IDE headers

Hi all, This patch series removes all unused headers and . was still included by 3 PATA drivers for m68k platforms, but without any real need. The first 5 patches have no dependencies. The last patch depends on the 3 pata patches. Thanks for your comments! Geert Uytterhoeven (9):

Re: [PATCH 00/21] Rid W=1 warnings from IDE

On Mon, Jun 14, 2021 at 10:12:28AM +0100, Lee Jones wrote: > On Mon, 07 Jun 2021, Christoph Hellwig wrote: > > > Please don't touch this code as it is about to be removed entirely. > > Do you have an ETA for this work? I just resent the series.

Re: [PATCH 00/21] Rid W=1 warnings from IDE

On Mon, 07 Jun 2021, Christoph Hellwig wrote: > Please don't touch this code as it is about to be removed entirely. Do you have an ETA for this work? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter |

Re: [PATCH 00/21] Rid W=1 warnings from IDE

Please don't touch this code as it is about to be removed entirely.

[PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe'

Fixes the following W=1 kernel build warning(s): drivers/ide/pmac.c:1418:12: warning: no previous prototype for ‘pmac_ide_probe’ [-Wmissing-prototypes] Cc: "David S. Miller" Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linux-...@vger.kernel.org Cc: li

[PATCH 00/21] Rid W=1 warnings from IDE

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (21): ide: alim15x3: Document alim15x3_init_one()'s 'id' param ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param ide

Re: [PATCH 05/10] MIPS: switch workpad_defconfig from legacy IDE to libata

On Thu, Mar 18, 2021 at 05:57:01AM +0100, Christoph Hellwig wrote: > Use libata instead of the deprecated legacy ide driver in > workpad_defconfig. > > Signed-off-by: Christoph Hellwig > --- > arch/mips/configs/workpad_defconfig | 9 ++--- > 1 file changed, 6 inser

Re: remove the legacy ide driver

Hello Christoph! On 3/18/21 5:56 AM, Christoph Hellwig wrote: > libata mostly covers all hardware supported by the legacy ide driver. > There are three mips drivers that are not supported, but the linux-mips > list could not identify any users of those. There also are two m68k > dri

Re: [PATCH 10/10] ide: remove the legacy ide driver

> i.e. remove all the `ide*' options, possibly more (I haven't checked in > detail). And also Documentation/ide/ide.rst. Also do we have all the necessary `hdparm' features supported in libata nowadays for PATA devices? Maciej

Re: [PATCH 10/10] ide: remove the legacy ide driver

On Thu, 18 Mar 2021, Christoph Hellwig wrote: > The legay ide driver has been replace with libata startin in 2003 and has s/legay/legacy/;s/replace/replaced/;s/startin/startin/ (though I'd say "back in" instead in the latter case). > been scheduled for removal for a whil

Re: remove the legacy ide driver

On Thu, 18 Mar 2021, Christoph Hellwig wrote: > we've been trying to get rid of the legacy ide driver for a while now, > and finally scheduled a removal for 2021, which is three month old now. Hmm, there's still a regression in that pata_legacy unconditionally pokes at random I/

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

Al Viro writes: > ... > > Do you have reports of libata variants of drivers actually tested on > those? PATA_CMD64X works fine on my 164LX for many years, last tested with 5.12-rc3. (with a caveat: in my setup with CF card DMA is broken, but it is broken with BLK_DEV_CMD64X as well).

Re: remove the legacy ide driver

> patch series, relating to ide platform devices in arch/m68k/mac/config.c. > I hope to be able to test this patch before the 5.13 merge window closes. Normally we do not remove drivers for hardware that is still used. So at leat for macide my plan was not to take it away u

Re: remove the legacy ide driver

On Thu, 18 Mar 2021, Christoph Hellwig wrote: > Hi all, > > we've been trying to get rid of the legacy ide driver for a while now, > and finally scheduled a removal for 2021, which is three month old now. > > In general distros and most defconfigs have switched

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

Måns Rullgård writes: > Christoph Hellwig writes: > >> On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: >>> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >>> > Switch the alpha defconfig from the legacy ide driver to libata. >

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

Christoph Hellwig writes: > On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: >> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> > Switch the alpha defconfig from the legacy ide driver to libata. >> >> Umm... I don't have an IDE alp

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

Hi Al! On 3/18/21 6:54 AM, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU module shat themselves),

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: > > Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU modu

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: > Switch the alpha defconfig from the legacy ide driver to libata. Umm... I don't have an IDE alpha box in a usable shape (fans on CPU module shat themselves), and it would take a while to resurrect it, but I remember the

[PATCH 09/10] m68k: use libata instead of the legacy ide driver

Switch the m68 defconfigs from the deprecated ide subsystem to use libata instead. The gayle and buddha and falcon drivers are enabled for libata, while support for the q40 and macide drivers is lost. Signed-off-by: Christoph Hellwig --- arch/m68k/configs/amiga_defconfig | 10 +- arch

[PATCH 05/10] MIPS: switch workpad_defconfig from legacy IDE to libata

Use libata instead of the deprecated legacy ide driver in workpad_defconfig. Signed-off-by: Christoph Hellwig --- arch/mips/configs/workpad_defconfig | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/mips/configs/workpad_defconfig b/arch/mips/configs

remove the legacy ide driver

Hi all, we've been trying to get rid of the legacy ide driver for a while now, and finally scheduled a removal for 2021, which is three month old now. In general distros and most defconfigs have switched to libata long ago, but there are a few exceptions. This series first switches over all

[PATCH 01/10] alpha: use libata instead of the legacy ide driver

Switch the alpha defconfig from the legacy ide driver to libata. Signed-off-by: Christoph Hellwig --- arch/alpha/configs/defconfig | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/alpha/configs/defconfig b/arch/alpha/configs/defconfig index 724c4075df408e

Re: [PATCH] ide: fix warning comparing pointer to 0

On 3/11/21 2:48 AM, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/ide/pmac.c:1680:38-39: WARNING comparing pointer to 0. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/ide/pmac.c | 2 +- > 1 file changed,

[PATCH v2] ide: fix warning comparing pointer to 0

Fix the following coccicheck warning: ./drivers/ide/pmac.c:1680:38-39: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: - Modified if condition. drivers/ide/pmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] ide: fix warning comparing pointer to 0

Fix the following coccicheck warning: ./drivers/ide/pmac.c:1680:38-39: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/ide/pmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index

[PATCH -next] ide/pmac: use DIV_ROUND_UP macro to do calculation

Don't open-code DIV_ROUND_UP() kernel macro. Signed-off-by: Zheng Yongjun --- drivers/ide/pmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index ea0b064b5f56..6c0237af610d 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide

Re: [PATCH] powerpc: switch 85xx defconfigs from legacy ide to libata

On Thu, 24 Sep 2020 06:13:10 +0200, Christoph Hellwig wrote: > Switch the 85xx defconfigs from the soon to be removed legacy ide > driver to libata. Applied to powerpc/next. [1/1] powerpc: switch 85xx defconfigs from legacy ide to libata https://git.kernel.org/pow

[PATCH] powerpc: switch 85xx defconfigs from legacy ide to libata

Switch the 85xx defconfigs from the soon to be removed legacy ide driver to libata. Signed-off-by: Christoph Hellwig --- arch/powerpc/configs/85xx/mpc85xx_cds_defconfig | 6 +++--- arch/powerpc/configs/85xx/tqm8540_defconfig | 6 +++--- arch/powerpc/configs/85xx/tqm8541_defconfig | 6

Re: [PATCH -next] ide: Fix symbol undeclared warnings

David Miller writes: > From: Michael Ellerman > Date: Thu, 17 Sep 2020 22:01:00 +1000 > >> Wang Wensheng writes: >>> Build the object file with `C=2` and get the following warnings: >>> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- >

Re: [PATCH -next] ide: Fix symbol undeclared warnings

From: Michael Ellerman Date: Thu, 17 Sep 2020 22:01:00 +1000 > Wang Wensheng writes: >> Build the object file with `C=2` and get the following warnings: >> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- >> make C=2 drivers/ide/pmac.o ARCH=powerpc64 >&

Re: [PATCH -next] ide: Fix symbol undeclared warnings

Wang Wensheng writes: > Build the object file with `C=2` and get the following warnings: > make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- > make C=2 drivers/ide/pmac.o ARCH=powerpc64 > CROSS_COMPILE=powerpc64-linux-gnu- > > drivers/ide/pmac.c:228:2

[PATCH -next] ide: Fix symbol undeclared warnings

Build the object file with `C=2` and get the following warnings: make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- make C=2 drivers/ide/pmac.o ARCH=powerpc64 CROSS_COMPILE=powerpc64-linux-gnu- drivers/ide/pmac.c:228:23: warning: symbol 'mdma_timings_33' was not declared. Should

[PATCH AUTOSEL 4.4 074/100] ide: remove set but not used variable 'hwif'

From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 4.9 106/141] ide: remove set but not used variable 'hwif'

From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 4.14 140/186] ide: remove set but not used variable 'hwif'

From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 4.19 190/252] ide: remove set but not used variable 'hwif'

From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 5.4 354/459] ide: remove set but not used variable 'hwif'

From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 5.5 414/542] ide: remove set but not used variable 'hwif'

From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

Re: [PATCH] ide: remove set but not used variable 'hwif'

From: Wang Hai Date: Sat, 26 Oct 2019 09:57:38 +0800 > Fix the following gcc warning: > > drivers/ide/pmac.c: In function pmac_ide_setup_device: > drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used > [-Wunused-but-set-variable] > > Fixes: d58b0c39e32f (&

[PATCH] ide: remove set but not used variable 'hwif'

Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/macio: Rework hotplug media bay support") Reported-by: Hulk Robot

Re: Re: Kernel panic when loading the IDE controller driver

this version. In the older kernel, we >>> have the m8260_setup.c source file for our board where the function >>> "io_block_mapping" was used to configure the non-standard IO port address >>> starting at 0xe000 location. This address was passed as the base a

Re: Kernel panic when loading the IDE controller driver

Hi All, I finally got the FLASH controller driver working and it is now successfully reporting the presence of 2GB Flash in the board. I used the new "libata" driver code present in the new kernel source under drivers/ata/. Also did the required additions in the device tree to provide the IO

Re: Kernel panic when loading the IDE controller driver

Hi, > Hopefully there are examples of passing these values through ACPI. Are you suggesting here to look at the ide-acpi.c sourc file available as part of the driver code? In my original post I mentioned that I have modified the ide-generic.c source file to use the IO port addresses and

Re: Kernel panic when loading the IDE controller driver

On Thu, 14 Feb 2019 01:17:11 -0700 (MST) sgosavi1 wrote: > > Maybe look around > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/? > > id=9a0e77f28b50128df0c9e26ae489e44e29a7270a > > >Also look at ide_platform.c. I imagine there must be some way to set it > >up in

Re: Kernel panic when loading the IDE controller driver

rd IO port address starting at 0xe000 location. This address was passed as the base address followed by control address and IRQ number to the ide-core.ko module. In the new kernel we do not have an option to send these addresses and IRQ numbers as arguments to the driver. Instead the ide-generi

Re: Kernel panic when loading the IDE controller driver

> Maybe look around > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/? > id=9a0e77f28b50128df0c9e26ae489e44e29a7270a >Also look at ide_platform.c. I imagine there must be some way to set it >up in your device tree. I have gone through this before and also tried the

Re: Kernel panic when loading the IDE controller driver

is address was passed as the base address followed by control address and IRQ number to the ide-core.ko module. In the new kernel we do not have an option to send these addresses and IRQ numbers as arguments to the driver. Instead the ide-generic.c source file in the new kernel uses the standard IO p

Re: Kernel panic when loading the IDE controller driver

se address followed by control address and IRQ number to the ide-core.ko module. In the new kernel we do not have an option to send these addresses and IRQ numbers as arguments to the driver. Instead the ide-generic.c source file in the new kernel uses the standard IO port values and IRQ values.

Re: Kernel panic when loading the IDE controller driver

Le 13/02/2019 à 13:24, sgosavi1 a écrit : What it the last linux version known to work properly? We have used it successfully in the Linux-2.6.17.6 version. Oh, ok, there's a big gap between the two versions. Why using 4.15.13 which is obsolete instead of using one of the Long Term

Re: Kernel panic when loading the IDE controller driver

> What it the last linux version known to work properly? We have used it successfully in the Linux-2.6.17.6 version. Thanks, Sachin. -- Sent from: http://linuxppc.10917.n7.nabble.com/linuxppc-dev-f3.html

Re: Kernel panic when loading the IDE controller driver

it the last linux version known to work properly ? Christophe I am facing an issue with the generic IDE flash controller driver in the new kernel source where it fails to detect the Flash controller connected to 2GB NAND flash available on the board. We have used non-standard IO port addresses

Kernel panic when loading the IDE controller driver

Hi All, I have been working on porting Linux-4.15.13 kernel on our existing MPC8270 processor board. For this exercise, I have used pq2fads as a reference board, its associated device tree and used cuImage for building the kernel. I am facing an issue with the generic IDE flash controller driver

Re: ide: Use of_node_name_eq for node name comparisons

On Wed, 2018-12-05 at 19:50:25 UTC, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > Cc: "David S. Miller" > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman >

[PATCH AUTOSEL 3.18 10/16] ide: pmac: add of_node_put()

From: Yangtao Li [ Upstream commit a51921c0db3fd26c4ed83dc0ec5d32988fa02aa5 ] use of_node_put() to release the refcount. Signed-off-by: Yangtao Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/ide/pmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH AUTOSEL 4.4 13/23] ide: pmac: add of_node_put()

From: Yangtao Li [ Upstream commit a51921c0db3fd26c4ed83dc0ec5d32988fa02aa5 ] use of_node_put() to release the refcount. Signed-off-by: Yangtao Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/ide/pmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH AUTOSEL 4.9 14/34] ide: pmac: add of_node_put()

From: Yangtao Li [ Upstream commit a51921c0db3fd26c4ed83dc0ec5d32988fa02aa5 ] use of_node_put() to release the refcount. Signed-off-by: Yangtao Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/ide/pmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH AUTOSEL 4.14 16/41] ide: pmac: add of_node_put()

From: Yangtao Li [ Upstream commit a51921c0db3fd26c4ed83dc0ec5d32988fa02aa5 ] use of_node_put() to release the refcount. Signed-off-by: Yangtao Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/ide/pmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH AUTOSEL 4.19 31/73] ide: pmac: add of_node_put()

From: Yangtao Li [ Upstream commit a51921c0db3fd26c4ed83dc0ec5d32988fa02aa5 ] use of_node_put() to release the refcount. Signed-off-by: Yangtao Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/ide/pmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH] ide: Use of_node_name_eq for node name comparisons

org Signed-off-by: Rob Herring --- drivers/ide/pmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index c5b902b86b44..ec46aa84d18d 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide/pmac.c @@ -1045,7 +1045,7 @@ static int pmac_ide_se

[PATCH] ide: pmac: add of_node_put()

use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/ide/pmac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index c5b902b86b44..203ed4adc04a 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide/pmac.c @@ -920,6 +920,7

Re: ide: pmac: Convert to using %pOF instead of full_name

On Tue, 2017-07-18 at 21:43:07 UTC, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc:

Re: [PATCH] ide: pmac: Convert to using %pOF instead of full_name

From: Rob Herring Date: Tue, 18 Jul 2017 16:43:07 -0500 > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring

[PATCH] ide: pmac: Convert to using %pOF instead of full_name

jamin Herrenschmidt <b...@kernel.crashing.org> Cc: Paul Mackerras <pau...@samba.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: linux-...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org --- drivers/ide/pmac.c | 18 +- 1 file changed, 9 insertions(+), 9 deletio

Re: powerpc: disable IDE subsystem in pasemi_defconfig

On Wed, 2016-03-02 at 15:50:23 UTC, Bartlomiej Zolnierkiewicz wrote: > This patch disables deprecated IDE subsystem in pasemi_defconfig > (no IDE host drivers are selected in this config so there is no valid > reason to enable IDE subsystem itself). > > Cc: Olof Johansson

Re: [patch] ide: missing break statement in set_timings_mdma()

From: Dan Carpenter Date: Thu, 14 Jul 2016 13:48:02 +0300 > There was clearly supposed to be a break statement here. Currently we > use the k2 ata timings instead of sh ata ones we intended. Probably no > one has this hardware anymore so it likely doesn't make a

Re: [patch] ide: missing break statement in set_timings_mdma()

d the static checker warning. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> Should probably also: CC: sta...@vger.kernel.org > diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c > index 7f0434f..0c5d3

[patch] ide: missing break statement in set_timings_mdma()

pen...@oracle.com> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index 7f0434f..0c5d3a9 100644 --- a/drivers/ide/pmac.c +++ b/drivers/ide/pmac.c @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, *timings = ((*t

[PATCH] powerpc/85xx: disable IDE subsystem in stx_gp3_defconfig

This patch disables deprecated IDE subsystem in stx_gp3_defconfig (no IDE host drivers are selected in this config so there is no valid reason to enable IDE subsystem itself). Cc: Scott Wood <o...@buserror.net> Cc: Kumar Gala <ga...@kernel.crashing.org> Signed-off-by: Bartlomiej Zo

[PATCH] powerpc: disable IDE subsystem in pasemi_defconfig

This patch disables deprecated IDE subsystem in pasemi_defconfig (no IDE host drivers are selected in this config so there is no valid reason to enable IDE subsystem itself). Cc: Olof Johansson <o...@lixom.net> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> ---

[PATCH] powerpc: disable IDE subsystem in pq2fads_defconfig

This patch disables deprecated IDE subsystem in pq2fads_defconfig (no IDE host drivers are selected in this config so there is no valid reason to enable IDE subsystem itself). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- arch/powerpc/configs/pq2fads_defconfig |

[PATCH] powerpc/85xx: disable IDE subsystem in ksi8560_defconfig

This patch disables deprecated IDE subsystem in ksi8560_defconfig (no IDE host drivers are selected in this config so there is no valid reason to enable IDE subsystem itself). Cc: Scott Wood <o...@buserror.net> Cc: Kumar Gala <ga...@kernel.crashing.org> Signed-off-by: Bartlomiej Zo

[PATCH] powerpc/86xx: disable IDE subsystem in mpc8610_hpcd_defconfig

This patch disables deprecated IDE subsystem in mpc8610_hpcd_defconfig (no IDE host drivers are selected in this config so there is no valid reason to enable IDE subsystem itself). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- arch/powerpc/config

[PATCH] powerpc/83xx: disable IDE subsystem in mpc834x_itx_defconfig

This patch disables deprecated IDE subsystem in mpc834x_itx_defconfig (no IDE host drivers are selected in this config so there is no valid reason to enable IDE subsystem itself). Cc: Scott Wood <o...@buserror.net> Cc: Kumar Gala <ga...@kernel.crashing.org> Signed-off-by

Re: [PATCH] mpc85xx_defconfig: add IDE support for MPC85xxCDS

On Fri, Jul 20, 2012 at 03:09:00PM +0100, Alan Cox wrote: On Fri, 20 Jul 2012 20:45:25 +0800 Zhao Chenhui chenhui.z...@freescale.com wrote: Add IDE support for MPC85xxCDS. Signed-off-by: Zhao Chenhui chenhui.z...@freescale.com --- arch/powerpc/configs/mpc85xx_defconfig |2

[PATCH] mpc85xx_defconfig: add IDE support for MPC85xxCDS

Add IDE support for MPC85xxCDS. Signed-off-by: Zhao Chenhui chenhui.z...@freescale.com --- arch/powerpc/configs/mpc85xx_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/configs/mpc85xx_defconfig b/arch/powerpc/configs/mpc85xx_defconfig index

Re: [PATCH] mpc85xx_defconfig: add IDE support for MPC85xxCDS

On Fri, 20 Jul 2012 20:45:25 +0800 Zhao Chenhui chenhui.z...@freescale.com wrote: Add IDE support for MPC85xxCDS. Signed-off-by: Zhao Chenhui chenhui.z...@freescale.com --- arch/powerpc/configs/mpc85xx_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

ata/ide driver for MPC512x

Hi, do we have an ata/ide driver for MPC512x internal ATA controller? So something that is compatible to fsl,mpc5121-pata? Matthias ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] libata: Convert LED disk trigger from IDE to libata

Hello. On 03-10-2011 20:07, Jörg Sommer wrote: This patch converts the trigger for the LED at the front of Apple's iBooks to libata. It's merely a replacement of the string ide by disk. The patch is taken from http://dev.gentoo.org/~josejx/ata.patch. I've asked Joseph Jezak if he intends

Re: [PATCH] libata: Convert LED disk trigger from IDE to libata

Hi Jorg, you submitted the patch slightly modified by Acrux (from CruxPPC) [1] Anyway this patch is widely used by any ibook/powerbook owners with great satisfaction. I also use this patch from Jan 2011 and i'd like to see it upstreamed. Btw, guess you should add: Signed-off-by: Joseph Jezak

[PATCH] libata: Convert LED disk trigger from IDE to libata

This patch converts the trigger for the LED at the front of Apple's iBooks to libata. It's merely a replacement of the string ide by disk. The patch is taken from http://dev.gentoo.org/~josejx/ata.patch. I've asked Joseph Jezak if he intends to send this patch upstream, but as he did not reply

mpc8xx IDE hard drive enumeration

Hello list, I'm currently attempting to get Linux running on a custom board and have gotten to the point of trying to get our IDE FlashCard working. I have ported u-boot and have the flash card working as expected (as in being able to read and write sectors) so it looks like it is possible

Re: [PATCH] Add cmd64x IDE driver to default pmac32 config

On Thu, 2010-07-08 at 15:00 +1000, Benjamin Herrenschmidt wrote: On Sat, 2010-07-03 at 20:21 +0200, lawrence rust wrote: The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible IDE disk controller. E.g. lspci shows... 01:01.0 IDE interface: Silicon Image, Inc. PCI0646

Re: [PATCH] Add cmd64x IDE driver to default pmac32 config

On Thu, 2010-07-08 at 08:18 +0200, lawrence rust wrote: Sure. it would be preferable but unfortunately the PowerMac on-board IDE controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE code is removed) to use

Re: [PATCH] Add cmd64x IDE driver to default pmac32 config

On Thu, 2010-07-08 at 16:30 +1000, Benjamin Herrenschmidt wrote: On Thu, 2010-07-08 at 08:18 +0200, lawrence rust wrote: Sure. it would be preferable but unfortunately the PowerMac on-board IDE controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W G3's, doesn't have a PATA

Re: [PATCH] Add cmd64x IDE driver to default pmac32 config

On Thu, 2010-07-08 at 11:01 +0200, lawrence rust wrote: On Thu, 2010-07-08 at 16:30 +1000, Benjamin Herrenschmidt wrote: On Thu, 2010-07-08 at 08:18 +0200, lawrence rust wrote: Sure. it would be preferable but unfortunately the PowerMac on-board IDE controller (CONFIG_BLK_DEV_IDE_PMAC

Re: [PATCH] Add cmd64x IDE driver to default pmac32 config

On Sat, 2010-07-03 at 20:21 +0200, lawrence rust wrote: The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible IDE disk controller. E.g. lspci shows... 01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07) Unfortunately the default pmac32 configuration does

[PATCH] Add cmd64x IDE driver to default pmac32 config

The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible IDE disk controller. E.g. lspci shows... 01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07) Unfortunately the default pmac32 configuration does not include this driver and so PowerMac G3's can't load a root

Re: PATA/legacy IDE subsystem on PowerMac

2010/5/18 Benjamin Herrenschmidt b...@kernel.crashing.org: [cut] Nothing obvious... the disk seem to be detected properly. Do you have the support for mac partitions and the SCSI disk driver (BLK_DEV_SD) enabled ? The PATA modules was built statically, and BLK_DEV_SD as a module (and not

PATA/legacy IDE subsystem on PowerMac

Hello, I hope I've posted to the right list. I'm the maintainer of the linux kernel in ArchlinuxPPC [1]. We actually set statically the support for the PowerMac on-board IDE support (under ATA/ATAPI/MFM/RLL support (DEPRECATED) ), and the disk is recognized correctly (hda*). If we try

Re: PATA/legacy IDE subsystem on PowerMac

On Tue, 2010-05-18 at 21:16 +0200, JJDaNiMoTh wrote: Hello, I hope I've posted to the right list. I'm the maintainer of the linux kernel in ArchlinuxPPC [1]. We actually set statically the support for the PowerMac on-board IDE support (under ATA/ATAPI/MFM/RLL support (DEPRECATED

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote: This is a libata driver for the macio IDE controller used on most Apple PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c It supports all the features of its predecessor, including mediabay hotplug and suspend

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

Benjamin Herrenschmidt writes: This is a libata driver for the macio IDE controller used on most Apple PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c It supports all the features of its predecessor, including mediabay hotplug and suspend/resume. It should

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

On Thu, 2009-12-03 at 03:12 -0500, Jeff Garzik wrote: Looks fine to me. Two minor comments, which might perhaps be ignored if that is your taste: * prefer enums to #define's, for constants yeah well ... I lifted those definitions from the old driver and didn't feel like changing them all

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

Benjamin Herrenschmidt b...@kernel.crashing.org writes: v2. Better tested now, seems to be reasonably solid. Addressed Tejun comments and made remove more robust vs. media-bay, should also fix Andreas problem. Thanks, this works fine now, including suspend *and* resume. :-) Andreas. --

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

(cc'ing Holger Macht, please read the comment below pata_macio_mb_event()) Hello, On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: This is a libata driver for the macio IDE controller used on most Apple PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c Don't know

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

be busted, it will have to be updated I'm afraid as it's more/less hard coded to know about IDE gunk I'll have a look. The new yaboot maintainer (Tony Breeds) happens to sit 2 cubicles away from me at work so it shouldn't be a huge deal. Thanks for reminding me tho ! Cheers, Ben

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

Benjamin Herrenschmidt writes: This is a libata driver for the macio IDE controller used on most Apple PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c It supports all the features of its predecessor, including mediabay hotplug and suspend/resume. It should

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

On 12/01/2009 09:44 PM, Holger Macht wrote: I do not remember any specific reason for using ata_port_schedule_eh(). I guess it's just there because the previous implementation used it. ata_port_freeze()/abort() might as well work properly. However, I would hesitate to change the existing code,

  1   2   3   4   >