[PATCH] powerpc: fixing endianness of flash_block_list in rtas_flash

endian when passed to rtas on little endian hosts. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/kernel/rtas_flash.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c index

Re: [PATCH] powerpc: fixing endianness of flash_block_list in rtas_flash

On 08/01/2014 04:32 AM, Vasant Hegde wrote: On 07/25/2014 11:17 PM, Thomas Falcon wrote: The function rtas_flash_firmware passes the address of a data structure, flash_block_list, when making the update-flash-64-and-reboot rtas call. While the endianness of the address is handled correctly

[PATCH] powerpc/pseries/hvcserver: Fix endian issue in hvcs_get_partner_info

A buffer returned by H_VTERM_PARTNER_INFO contains device information in big endian format, causing problems for little endian architectures. This patch ensures that they are in cpu endian. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/hvcserver.c

[PATCH] powerpc/pseries: Fix endian issues in memory hotplug

Values acquired from Open Firmware are in 32-bit big endian format and need to be handled on little endian architectures. This patch ensures values are in cpu endian when hotplugging memory. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/hotplug

[PATCH] pseries: Fix endianness in cpu hotplug and hotremove

This patch attempts to ensure that all values are in the proper endianness format when both hotadding and hotremoving cpus. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 56 ++-- arch/powerpc/platforms/pseries

Re: [PATCH] pseries: Fix endianness in cpu hotplug and hotremove

02:09 PM, Thomas Falcon wrote: This patch attempts to ensure that all values are in the proper endianness format when both hotadding and hotremoving cpus. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 56

[PATCH 2/2] pseries: Fix endian issues in cpu hot-removal

When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 14 +++--- arch/powerpc/platforms/pseries/hotplug-cpu.c

[PATCH 1/2] pseries: Fix endian issues in onlining cpu threads

The ibm,ppc-interrupt-server#s property is in big endian format. These values need to be converted when used by little endian architectures. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch/powerpc/platforms/pseries/dlpar.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 2/2] pseries: Fix endian issues in cpu hot-removal

On 09/12/2014 03:53 AM, Michael Ellerman wrote: On Wed, 2014-09-10 at 17:41 -0500, Thomas Falcon wrote: When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- arch

[PATCH v2 1/2] pseries: Fix endian issues in onlining cpu threads

The ibm,ppc-interrupt-server#s property is in big endian format. These values need to be converted when used by little endian architectures. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v2: Followed suggestions from Michael Ellerman conversion of intserv values

[PATCH v2 2/2] pseries: Fix endian issues in cpu hot-removal

When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v2: Followed suggestions from Michael Ellerman: Conversion of intserv to cpu endian occurs once

[PATCH 0/3] pseries: Make CPU hotplug and hotremove endian safe

This patchset ensures that cpu hotplugging and hotremoval are compatible with both big and little endian architectures. Bharata B Rao (1): pseries: Make CPU hotplug path endian safe Thomas Falcon (2): pseries: Fix endian issues in onlining cpu threads pseries: Fix endian issues in cpu

[PATCH v2 2/3] pseries: Fix endian issues in onlining cpu threads

The ibm,ppc-interrupt-server#s property is in big endian format. These values need to be converted when used by little endian architectures. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v2: Followed suggestions from Michael Ellerman conversion of intserv values

[PATCH v2 1/3] pseries: Make CPU hotplug path endian safe

From: Bharata B Rao bhar...@linux.vnet.ibm.com - ibm,rtas-configure-connector should treat the RTAS data as big endian. - Treat ibm,ppc-interrupt-server#s as big-endian when setting smp_processor_id during hotplug. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Thomas

[PATCH v3 3/3] pseries: Fix endian issues in cpu hot-removal

When removing a cpu, this patch makes sure that values gotten from or passed to firmware are in the correct endian format. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- Changes in v3: drc_index in dlpar_cpu_release is no longer const to fix compilation error found by Bharata Rao

[PATCHi v2] ibmveth: Add function to enable live MAC address changes

Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v2: If h_change_logical_lan_mac fails, dev-dev_addr will not be changed. drivers/net/ethernet/ibm/ibmveth.c | 25

Re: [PATCHi v2] ibmveth: Add function to enable live MAC address changes

On 02/28/2015 02:59 AM, Jiri Pirko wrote: Sat, Feb 28, 2015 at 06:56:04AM CET, tlfal...@linux.vnet.ibm.com wrote: Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v2

[PATCH v3] ibmveth: Add function to enable live MAC address changes

Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v3: removed text wrapping in error message v2: If h_change_logical_lan_mac fails, dev-dev_addr will not be changed

[PATCH] ibmveth: Add function to enable live MAC address changes

Add a function that will enable changing the MAC address of an ibmveth interface while it is still running. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 4/5] ibmveth: Add support for Large Receive Offload

On 04/14/2015 05:00 PM, Eric Dumazet wrote: On Tue, 2015-04-14 at 15:35 -0500, Thomas Falcon wrote: Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk

Re: [PATCHv2] ibmveth: Fix off-by-one error in ibmveth_change_mtu()

. This is because there is a instead of an = in ibmveth_change_mtu(), which only permits an MTU which is strictly smaller than the buffer size, rather than allowing the buffer to be completely filled. This patch fixes the buglet. Thanks! Acked-by: Thomas Falcon tlfal...@linux.vnet.ibm.com

[PATCH net-next v3 4/4] ibmveth: Add support for Large Receive Offload

Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v3: -Removed code setting network

[PATCH net-next v3 1/4] ibmveth: change rx buffer default allocation for CMO

This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c

[PATCH net-next v3 3/4] ibmveth: Add GRO support

Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 25cfc26

[PATCH net-next v2 1/4] ibmveth: change rx buffer default allocation for CMO

This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c

[PATCH net-next v2 2/4] ibmveth: Add support for TSO

Add support for TSO. TSO is turned off by default and must be enabled and configured by the user. The driver version number is increased so that users can be sure that they are using ibmveth with TSO support. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal

[PATCH net-next v2 4/4] ibmveth: Add support for Large Receive Offload

Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v2: -Included statistics that were

[PATCH net-next v2 3/4] ibmveth: Add GRO support

Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 25cfc26

[PATCH 4/5] ibmveth: Add support for Large Receive Offload

Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 15

[PATCH 2/5] ibmveth: Add support for TSO

Add support for TSO. TSO is turned off by default and must be enabled and configured by the user. The driver version number is increased so that users can be sure that they are using ibmveth with TSO support. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal

[PATCH 3/5] ibmveth: Add GRO support

Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 2911a57

[PATCH 1/5] ibmveth: change rx buffer default allocation for CMO

This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c

[PATCH 5/5] ibmveth: Add ethtool statistics for tx and rx large packets

This patch includes counters for transmitted and received large packets. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 4 drivers/net/ethernet/ibm/ibmveth.h | 2 ++ 2 files changed, 6 insertions

[PATCH net-next] ibmveth: add support for TSO6

This patch adds support for a new method of signalling the firmware that TSO packets are being sent. The new method removes the need to alter the ip and tcp checksums and allows TSO6 support. Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c | 145

Re: [PATCH net-next] Driver for IBM System i/p VNIC protocol

On 12/05/2015 09:25 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Fri, 4 Dec 2015 11:49:46 -0600 > >> +static int ibmvnic_buffs_per_pool = IBMVNIC_BUFFS_PER_POOL; >> +module_param(ibmvnic_buffs_per_pool, int, S_I

Re: [PATCH net-next v2] Driver for IBM System i/p VNIC protocol

On 12/11/2015 06:53 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Tue, 8 Dec 2015 11:52:19 -0600 > >> +static long h_reg_sub_crq(unsigned long unit_address, unsigned long token, >> + unsigned long le

Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items

>errors, list) { > dma_unmap_single(dev, error_buff->dma, >error_buff->len, >DMA_FROM_DEVICE); > Thanks! Acked-by: Thomas Falcon &l

Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items

On 06/20/2016 10:50 AM, Thomas Falcon wrote: > On 06/17/2016 09:53 PM, weiyj...@163.com wrote: >> From: Wei Yongjun <yongjun_...@trendmicro.com.cn> >> >> Since we will remove items off the list using list_del() we need >> to use a safe version of the

[net-next PATCH v2] ibmvnic: map L2/L3/L4 header descriptors to firmware

From: root <r...@ltcalpine2-lp23.aus.stglabs.ibm.com> Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas

[net-next PATCH v3] ibmvnic: map L2/L3/L4 header descriptors to firmware

Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- v2: Fixed typo

[net-next PATCH] ibmvnic: map L2/L3/L4 header descriptors to firmware

Allow the VNIC driver to provide descriptors containing L2/L3/L4 headers to firmware. This feature is needed for greater hardware compatibility and enablement of offloading technologies for some backing hardware. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drive

[net-next PATCH 1/2 v4] ibmvnic: map L2/L3/L4 header descriptors to firmware

-mapped array of SCRQ descriptor elements to be sent to the VNIC server. These additions will help fully enable checksum offloading as well as other features as they are included later. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> Cc: John Allen <jal...@linux.vnet.ibm.com> -

[net-next PATCH 2/2 v4] ibmvnic: enable RX checksum offload

Enable RX Checksum offload feature in the ibmvnic driver. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> Cc: John Allen <jal...@linux.vnet.ibm.com> --- v4: this patch included since it is enabled by the previous patch --- drivers/net/ethernet/ibm/ibmvnic.c | 4 1 fil

Re: [PATCH v2 1/2] powerpc/pseries: Implemented indexed-count hotplug memory add

On 07/18/2016 10:07 AM, Sahil Mehta wrote: > Indexed-count add for memory hotplug guarantees that a contiguous block > of lmbs beginning at a specified will be assigned (NOT > that lmbs will be added). Because of Qemu's per-DIMM memory > management, the addition of a contiguous block of memory

Re: [PATCH] ibmveth: Add a proper check for the availability of the checksum features

On 01/24/2017 12:28 AM, Thomas Huth wrote: > When using the ibmveth driver in a KVM/QEMU based VM, it currently > always prints out a scary error message like this when it is started: > > ibmveth 7103 (unregistered net_device): unable to change > checksum offload settings. 1 rc=-2

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

On 01/25/2017 10:04 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Wed, 25 Jan 2017 15:02:19 -0600 > >> Move most interrupt handler processing into a tasklet, and >> introduce a delay after re-enabling interrupts to fix timing >&g

Re: [PATCH net 2/5] ibmvnic: Fix MTU settings

On 01/25/2017 10:05 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Wed, 25 Jan 2017 15:02:20 -0600 > >> In the current driver, the MTU is set to the maximum value >> capable for the backing device. This patch sets the MTU to the >&

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

On 01/26/2017 11:56 AM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Thu, 26 Jan 2017 10:44:22 -0600 > >> On 01/25/2017 10:04 PM, David Miller wrote: >>> From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> >>> Date:

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

On 01/26/2017 12:28 PM, Stephen Hemminger wrote: > On Wed, 25 Jan 2017 15:02:19 -0600 > Thomas Falcon <tlfal...@linux.vnet.ibm.com> wrote: > >> static irqreturn_t ibmvnic_interrupt(int irq, void *instance) >> { >> struct ibmvnic_adapter *adapter = inst

[PATCH net 3/5] ibmvnic: Fix endian error when requesting device capabilites

-by: John Allen <jal...@linux.vnet.ibm.com> Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c i

[PATCH net 1/5] ibmvnic: harden interrupt handler

Move most interrupt handler processing into a tasklet, and introduce a delay after re-enabling interrupts to fix timing issues encountered in hardware testing. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 21 +++-- d

[PATCH net 2/5] ibmvnic: Fix MTU settings

values. Finally, it removes redundant min/max MTU assignments after device initialization. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethern

[PATCH net 4/5] ibmvnic: Fix endian errors in error reporting output

Error reports received from firmware were not being converted from big endian values, leading to bogus error codes reported on little endian systems. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 8 1 file changed, 4 insertions

[PATCH net 5/5] ibmvnic: init completion struct before requesting long term mapped buffers

t.ibm.com> Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index ec6c5fe..d1ffc61 100644 --- a/driver

[PATCH] ibmvnic: Handle backing device failover and reinitialization

from the backing device before establishing a new connection. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 34 -- drivers/net/ethernet/ibm/ibmvnic.h | 2 ++ 2 files changed, 34 insertions(+), 2 del

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

On 10/27/2016 10:26 AM, Eric Dumazet wrote: > On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >> We recently encountered a bug where a few customers using ibmveth on the >> same LPAR hit an issue where a TCP session hung when large receive was >> enabled. Closer analysis revealed that the

Re: [bug report] Driver for IBM System i/p VNIC protocol

On 11/16/2016 06:25 AM, Dan Carpenter wrote: > Hello Thomas Falcon, > > The patch 032c5e82847a: "Driver for IBM System i/p VNIC protocol" > from Dec 21, 2015, leads to the following static checker warning: > > drivers/net/ethernet/ibm/ibmvnic.c:2957 error_le

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

stomers tests. > > Signed-off-by: Jon Maxwell <jmaxwel...@gmail.com> Thanks, Jon. Acked-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > --- > drivers/net/ethernet/ibm/ibmveth.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/driv

Re: [PATCH FEAT] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

information from the ibmvnic card. > > Co-Authored-By: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > --- Hi, you should include a Signed-off-by tag in the commit message. You should also include the branch the patch is meant for in the PATCH field. In this case, it would be n

Re: [RFC v5 3/6] migration/dlpar: Add device readd queuing function

On 05/21/2018 12:52 PM, Michael Bringmann wrote: > migration/dlpar: This patch adds function dlpar_readd_action() > which will queue a worker function to 'readd' a device in the > system. Such devices must be identified by a 'resource' type > and a drc_index to be readded. The function in the

Re: [RFC v5 6/6] migration/memory: Update memory for assoc changes

On 05/21/2018 12:52 PM, Michael Bringmann wrote: > migration/memory: This patch adds more recognition for changes to > the associativity of memory blocks described by the device-tree > properties and updates local and general kernel data structures to > reflect those changes. These differences

[PATCH net-next 0/8] ibmvnic: Failover hardening

to an operational state. Thomas Falcon (8): ibmvnic: Mark NAPI flag as disabled when released ibmvnic: Introduce active CRQ state ibmvnic: Check CRQ command return codes ibmvnic: Return error code if init interrupted by transport event ibmvnic: Handle error case when setting link state

[PATCH net-next 1/8] ibmvnic: Mark NAPI flag as disabled when released

Set adapter NAPI state as disabled if they are removed. This will allow them to be enabled again if reallocated in case of a hard reset. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH net-next 3/8] ibmvnic: Check CRQ command return codes

Check whether CRQ command is successful before awaiting a response from the management partition. If the command was not successful, the driver may hang waiting for a response that will never come. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibm

[PATCH net-next 2/8] ibmvnic: Introduce active CRQ state

ialization, any further commands other than the initialization handshake with the VIOS management partition will result in an invalid state error. Instead of sending a command that will be returned with an error, print a warning and return an error that will be handled by the caller. Signed-off-

[PATCH net-next 4/8] ibmvnic: Return error code if init interrupted by transport event

If device init is interrupted by a failover, set the init return code so that it can be checked and handled appropriately by the init routine. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 5 - 1 file changed, 4 insertions(+), 1 de

[PATCH net-next 5/8] ibmvnic: Handle error case when setting link state

If setting the link state is not successful, print a warning with the resulting return code and return it to be handled by the caller. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 4 1 file changed, 4 insertions(+) diff --git a/d

[PATCH net-next 6/8] ibmvnic: Create separate initialization routine for resets

function to handle all possible scenarios. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 48 -- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drive

[PATCH net-next 8/8] ibmvnic: Introduce hard reset recovery

a device reset, a flag is set which will trigger a new hard reset following the completionof the current reset event. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 101 +++-- drivers/net/ethernet/ibm/ibmvnic.h

[PATCH net-next 7/8] ibmvnic: Set resetting state at earliest possible point

Set device resetting state at the earliest possible point: as soon as a reset is successfully scheduled. The reset state is toggled off when all resets have been processed to completion. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 3

[PATCH net] ibmvnic: Clean actual number of RX or TX pools

Avoid using value stored in the login response buffer when cleaning TX and RX buffer pools since these could be inconsistent depending on the device state. Instead use the field in the driver's private data that tracks the number of active pools. Signed-off-by: Thomas Falcon <tl

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

On 04/15/2018 06:27 PM, Thomas Falcon wrote: > Due to a firmware bug, the hypervisor can send an interrupt to a > transmit or receive queue just prior to a partition migration, not > allowing the device enough time to handle it and send an EOI. When > the partition migrates, the inter

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

On 04/15/2018 07:55 PM, David Miller wrote: > From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> > Date: Sun, 15 Apr 2018 18:53:36 -0500 > >> Due to a firmware bug, the hypervisor can send an interrupt to a >> transmit or receive queue just prior to a partition migration,

[PATCH] ibmvnic: Clear pending interrupt after device reset

o continue operation. Signed-off-by: Thomas Falcon <tlfal...@linux.vnet.ibm.com> --- drivers/net/ethernet/ibm/ibmvnic.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index f84a920.

Re: [PATCH net-next] ibmvnic: Potential NULL dereference in clean_one_tx_pool()

On 03/23/2018 06:36 AM, Dan Carpenter wrote: > There is an && vs || typo here, which potentially leads to a NULL > dereference. Thanks for catching that! > > Fixes: e9e1e97884b7 ("ibmvnic: Update TX pool cleaning routine") > Signed-off-by: Dan Carpenter > > diff --git

[PATCH net 2/2] ibmvnic: Fix non-atomic memory allocation in IRQ context

] [c01444e8] process_one_work+0x238/0x710 [c003f3967d20] [c0144a48] worker_thread+0x88/0x4e0 [c003f3967db0] [c014e3a8] kthread+0x178/0x1c0 [c003f3967e20] [c000bfd0] ret_from_kernel_thread+0x5c/0x6c Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm

[PATCH net 1/2] ibmvnic: Convert reset work item mutex to spin lock

0] [c0a5e728] linkwatch_event+0x48/0x60 [c003f3f87c50] [c01444e8] process_one_work+0x238/0x710 [c003f3f87d20] [c0144a48] worker_thread+0x88/0x4e0 [c003f3f87db0] [c014e3a8] kthread+0x178/0x1c0 [c003f3f87e20] [c000bfd0] ret_from_kernel_thread+0x5c/0x6c S

[PATCH net 0/2] net/ibmvnic: Fix reset work item locking bugs

This patch set fixes issues with scheduling reset work items in a tasklet context. Since ibmvnic_reset can called in an interrupt, it should not use a mutex or allocate memory non-atomically. Thomas Falcon (2): ibmvnic: Convert reset work item mutex to spin lock ibmvnic: Fix non-atomic memory

[PATCH net 1/2] ibmvnic: Fix RX queue buffer cleanup

The wrong index is used when cleaning up RX buffer objects during release of RX queues. Update to use the correct index counter. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm

[PATCH net 0/2] ibmvnic: Fix queue and buffer accounting errors

This series includes two small fixes. The first resolves a typo bug in the code to clean up unused RX buffers during device queue removal. The second ensures that device queue memory is updated to reflect new supported queue ring sizes after migration to other backing hardware. Thomas Falcon (2

[PATCH net 2/2] ibmvnic: Update driver queues after change in ring size support

During device reset, queue memory is not being updated to accommodate changes in ring buffer sizes supported by backing hardware. Track any differences in ring buffer sizes following the reset and update queue memory when possible. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm

[PATCH net 1/3] ibmvnic: Do not close unopened driver during reset

Check driver state before halting it during a reset. If the driver is not running, do nothing. Otherwise, a request to deactivate a down link can cause an error and the reset will fail. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 3 ++- 1 file changed, 2 insertions

[PATCH net 2/3] ibmvnic: Refresh device multicast list after reset

It was observed that multicast packets were no longer received after a device reset. The fix is to resend the current multicast list to the backing device after recovery. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH net 3/3] ibmvnic: Fix unchecked return codes of memory allocations

The return values for these memory allocations are unchecked, which may cause an oops if the driver does not handle them after a failure. Fix by checking the function's return code. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 13 +++-- 1 file changed, 7

[PATCH net 0/3] ibmvnic: Fixes for device reset handling

reset. The final patch fixes mishandling of memory allocation failures during device initialization, which caused a kernel oops. Thomas Falcon (3): ibmvnic: Do not close unopened driver during reset ibmvnic: Refresh device multicast list after reset ibmvnic: Fix unchecked return codes of memory

Re: [PATCH net] net/ibmvnic: Report last valid speed and duplex values to ethtool

On 6/27/19 12:57 PM, Andrew Lunn wrote: On Thu, Jun 27, 2019 at 12:09:13PM -0500, Thomas Falcon wrote: This patch resolves an issue with sensitive bonding modes that require valid speed and duplex settings to function properly. Currently, the adapter will report that device speed and duplex

[PATCH net] net/ibmvnic: Report last valid speed and duplex values to ethtool

evice has never been activated. In that case or when the hypervisor gives invalid values, continue to report unknown speed or duplex to ethtool. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/etherne

[PATCH net] ibmvnic: Do not process reset during or after device removal

, resulting in an oops. Fix this by checking the device state before processing a queued reset event. Reported-by: Abdul Haleem Tested-by: Abdul Haleem Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next] ibmveth: Allow users to update reported speed and duplex

On 8/6/19 5:25 AM, Michael Ellerman wrote: Thomas Falcon writes: Reported ethtool link settings for the ibmveth driver are currently hardcoded and no longer reflect the actual capabilities of supported hardware. There is no interface designed for retrieving this information from device

[PATCH net-next] ibmveth: Allow users to update reported speed and duplex

, such as LACP. This patch is based on the implementation in virtio_net. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmveth.c | 83 -- drivers/net/ethernet/ibm/ibmveth.h | 3 ++ 2 files changed, 64 insertions(+), 22 deletions(-) diff --git a/drivers

[PATCH net-next v2] ibmveth: Allow users to update reported speed and duplex

, such as LACP. This patch is based on the implementation in virtio_net. Signed-off-by: Thomas Falcon --- v2: Updated default driver speed/duplex settings to avoid breaking existing setups --- drivers/net/ethernet/ibm/ibmveth.c | 83 -- drivers/net/ethernet

[RFC PATCH] powerpc/pseries/mobility: notify network peers after migration

a GARP on all valid, running interfaces as part of the post_mobility_fixup routine. Signed-off-by: Thomas Falcon --- arch/powerpc/platforms/pseries/mobility.c | 20 1 file changed, 20 insertions(+) diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc

Re: [RFC PATCH] powerpc/pseries/mobility: notify network peers after migration

On 11/5/19 10:13 PM, Russell Currey wrote: On Tue, 2019-11-05 at 18:06 -0600, Thomas Falcon wrote: After a migration, it is necessary to send a gratuitous ARP from all running interfaces so that the rest of the network is aware of its new location. However, some supported network devices

Re: [PATCH 0/9] Fixes and Enablement of ibm,drc-info property

On 11/5/19 9:24 AM, Tyrel Datwyler wrote: Hi, just pointing out a few typos... There was a previous effort to add support for the PAPR architected ibm,drc-info property. This property provides a more memory compact representation of a paritions Dynamic Reconfig s/paritions/partition's

Re: [PATCH 3/9] powerpc/pseries: Add cpu DLPAR support for drc-info property

On 11/5/19 9:24 AM, Tyrel Datwyler wrote: From: Tyrel Datwyler Older firmwares provided information about Dynamic Reconfig Connectors (DRC) through several device tree properties, namely ibm,drc-types, ibm,drc-indexes, ibm,drc-names, and ibm,drc-power-domains. New firmwares have the ability

Re: [RFC PATCH] powerpc/pseries/mobility: notify network peers after migration

On 11/6/19 7:33 PM, Michael Ellerman wrote: Hi Thomas, Thomas Falcon writes: After a migration, it is necessary to send a gratuitous ARP from all running interfaces so that the rest of the network is aware of its new location. However, some supported network devices are unaware

Re: [RFC PATCH] powerpc/pseries/mobility: notify network peers after migration

On 11/6/19 4:14 PM, Nathan Lynch wrote: Hi Tom, Thomas Falcon writes: After a migration, it is necessary to send a gratuitous ARP from all running interfaces so that the rest of the network is aware of its new location. However, some supported network devices are unaware that they have been

[RFC PATCH v2] powerpc/pseries/mobility: notify network peers after migration

a GARP on all valid, running interfaces as part of the post_mobility_fixup routine. Signed-off-by: Thomas Falcon --- v2: fix missing brackets caught by Russell Currey --- arch/powerpc/platforms/pseries/mobility.c | 21 + 1 file changed, 21 insertions(+) diff --git a/arch

[PATCH net 4/4] ibmvnic: Serialize device queries

Provide some serialization for device CRQ commands and queries to ensure that the shared variable used for storing return codes is properly synchronized. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 51 ++ drivers/net/ethernet/ibm

[PATCH net 0/4] ibmvnic: Harden device commands and queries

not respond or becomes inoperable. Finally, serialize queries to retain the integrity of device return codes. Thomas Falcon (4): ibmvnic: Fix completion structure initialization ibmvnic: Terminate waiting device threads after loss of service ibmvnic: Bound waits for device queries ibmvnic

  1   2   >