Re: [PATCH slof v2] pci-properties: Remove redundant call to device-type

slof-devudev dup . @ . cr Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH SLOF] pci-properties: Remove redundant call to device-type

On Wed, 11 Mar 2015 17:26:32 +1100 Alexey Kardashevskiy a...@ozlabs.ru wrote: At the moment SLOF adds a device_type property automatically for every single PCI device based on its class even if there is no SLOF driver for such a device. OF1275 says that device_type is for implemented

Re: [PATCH SLOF] pci-properties: Remove redundant call to device-type

On Wed, 11 Mar 2015 19:21:02 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2015-03-11 at 08:50 +0100, Thomas Huth wrote: - Graphic cards should get the display device_type ... I guess that's missing now? At least the code for qemu-vga does it Ah, right, I

Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow

On Fri, 24 Apr 2015 09:22:33 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Hi Thomas, Thomas Huth th...@redhat.com writes: Am Wed, 22 Apr 2015 16:27:19 +0530 schrieb Nikunj A Dadhania nik...@linux.vnet.ibm.com: With the addition of 64-bit BARS and increase in the mmio

Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow

On Fri, 24 Apr 2015 12:56:57 +0200 Thomas Huth th...@redhat.com wrote: On Fri, 24 Apr 2015 09:22:33 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Hi Thomas, Thomas Huth th...@redhat.com writes: Am Wed, 22 Apr 2015 16:27:19 +0530 schrieb Nikunj A Dadhania nik

Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow

Am Wed, 22 Apr 2015 16:27:19 +0530 schrieb Nikunj A Dadhania nik...@linux.vnet.ibm.com: With the addition of 64-bit BARS and increase in the mmio address space, the code was hitting this limit. The memory of pci devices across the bridges were not accessible due to which the drivers failed.

Re: [PATCH 2/2] pci: Use Qemu created PCI device nodes

Hi Nikunj, On Wed, 22 Apr 2015 16:27:20 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: PCI Enumeration has been part of SLOF. Now with hotplug code addition in Qemu, it makes more sense to have this code a one place, i.e. Qemu. s/Qemu/QEMU/ and s/code a one place/code in one

Re: [PATCH v2 2/4] pci: Support 64-bit address translation

On Mon, 27 Apr 2015 19:57:26 +1000 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2015-04-27 at 11:32 +0200, Thomas Huth wrote: Anyway, I think we can fix that up as soon as somebody tries to run the js2x code again (I still have a YDL PowerStation at home somewhere

Re: [PATCH v2 4/4] pci: Use QEMU created PCI device nodes

On Mon, 27 Apr 2015 15:26:00 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Thomas Huth th...@redhat.com writes: On Mon, 27 Apr 2015 13:32:33 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: PCI Enumeration has been part of SLOF. Now with hotplug code addition

Re: [PATCH v2 2/4] pci: Support 64-bit address translation

day). And since your changes itself looks fine to me: Reviewed-by: Thomas Huth th...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 4/4] pci: Use QEMU created PCI device nodes

\ forget the config-addr ; + +' pci-device-props TO func-pci-device-props Apart from the minor nit, looks fine to me now. Reviewed-by: Thomas Huth th...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH v2 1/4] pci: program correct bridge limit registers during probe

problem. Suggested-by: Thomas Huth th...@redhat.com Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com --- slof/fs/pci-scan.fs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/slof/fs/pci-scan.fs b/slof/fs/pci-scan.fs index 15d0c8e..b8b9fe6 100644

Re: [PATCH v2 3/4] usb: support 64-bit pci bars

+ ENDOF +ENDCASE +F not AND ( io-base ) r@ hcdbase ! 08 config-l@ 8 rshift 000F0 AND 4 rshift ( usb-type ) r@ hcdtype ! Looks good to me. Reviewed-by: Thomas Huth th...@redhat.com ___ Linuxppc-dev mailing list Linuxppc

Re: [PATCH kernel v10 05/34] powerpc/iommu: Always release iommu_table in iommu_free_table()

On Wed, 13 May 2015 16:30:16 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 05/13/2015 03:33 PM, Gavin Shan wrote: On Tue, May 12, 2015 at 01:38:54AM +1000, Alexey Kardashevskiy wrote: At the moment iommu_free_table() only releases memory if the table was initialized for the platform

Re: [PATCH kernel v10 23/34] powerpc/iommu/powernv: Release replaced TCE

On Tue, 12 May 2015 01:39:12 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: At the moment writing new TCE value to the IOMMU table fails with EBUSY if there is a valid entry already. However PAPR specification allows the guest to write new TCE value without clearing it first. Another

Re: [PATCH kernel v10 23/34] powerpc/iommu/powernv: Release replaced TCE

On Thu, 14 May 2015 13:53:57 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 05/14/2015 01:00 AM, Thomas Huth wrote: On Tue, 12 May 2015 01:39:12 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: ... -/* - * hwaddr is a kernel virtual address here (0xc... bazillion), - * tce_build

Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition

On Wed, 17 Jun 2015 17:34:13 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Nikunj A Dadhania nik...@linux.vnet.ibm.com writes: Thomas Huth th...@redhat.com writes: +\ Check for GPT MSFT BASIC DATA GUID - vfat based +EBD0A0A2 CONSTANT GPT-BASIC-DATA-PARTITION-1 +B9E5

Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition

On Thu, 18 Jun 2015 11:54:13 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Thomas Huth th...@redhat.com writes: On Thu, 11 Jun 2015 15:48:49 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: + block-size * to seek-pos + block gptpart-entry-size l@-le to gpt-part

Re: [PATCH SLOF 1/5] disk-label: simplify gpt-prep-partition? routine

-PREP-PARTITION-4 IF FALSE EXIT THEN + TRUE ; : load-from-gpt-prep-partition ( addr -- size ) Also change DROP, FALSE and TRUE to lowercase, as Segher suggested with patch 3? Apart from that, looks fine to me. Reviewed-by: Thomas Huth th...@redhat.com

Re: [PATCH SLOF 2/5] introduce 8-byte LE helpers

-entrylast-lba x@ xbflip + block gpt-part-entryfirst-lba x@-le + block gpt-part-entrylast-lba x@-le over - 1+ ( addr offset len ) swap ( addr len offset ) block-size * to part-offset Reviewed-by: Thomas Huth th

Re: [PATCH SLOF 4/5] disk-label: add support for booting from GPT FAT partition

On Mon, 22 Jun 2015 13:29:46 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: For a GPT+LVM combination disk, older bootloader that does not support LVM, cannot load kernel from LVM. The patch add support to read from BASIC_DATA UUID partition. Installer has installed CHRP-BOOT

Re: [PATCH SLOF 5/5] disk-label: make gpt detection code more robust

On Mon, 22 Jun 2015 13:29:47 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: * Check for Protective MBR Magic * Check for valid GPT Signature * Boundary check for allocated block size before reading into the buffer Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com ---

Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition

On Thu, 11 Jun 2015 15:48:49 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: For a GPT+LVM combination disk, older bootloader that does not support LVM, cannot load kernel from LVM. The patch add support to read from BASIC_DATA UUID partition. Installer has installed CHRP-BOOT

Re: [PATCH 2/3] fbuffer: introduce the invert-region helper

current fb8-toggle-cursor - board-qemu: faster hv-logical-memop based With standard graphical settings on board-qemu, we go from 512 hcall invocations per character down to 16. Suggested-by: Thomas Huth th...@redhat.com Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- board-js2x/slof

Re: [PATCH 3/3] fbuffer: introduce the invert-region-x helper

-by: Thomas Huth th...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] fbuffer: improve toggle cursor performance

On Wed, 27 May 2015 02:11:13 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: SLOF currently calls hv-logical-load and hv-logical-store for every pixel when enabling or disabling the cursor. This is suboptimal when writing one char at a time to the console since terminal-write always toggles

Re: [PATCH 1/3] fbuffer: simplify address computations in fb8-toggle-cursor

-by: Thomas Huth th...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] Fix function keys sequence on USB

On Tue, 2 Jun 2015 12:43:16 +0200 Dinar Valeev k...@opensuse.org wrote: On Tue, Jun 2, 2015 at 12:29 PM, Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Dinar Valeev k...@opensuse.org writes: On Tue, Jun 2, 2015 at 11:47 AM, Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Dinar

Re: [PATCH SLOF v2 5/5] disk-label: add support for booting from GPT FAT partition

On Thu, 25 Jun 2015 12:15:29 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: For a GPT+LVM combination disk, older bootloader that does not support LVM, cannot load kernel from LVM. The patch adds support to read from BASIC_DATA UUID partitions for the case that the OS installer

Re: [PATCH slof] README: Update with patch submittion note

On Mon, 6 Jul 2015 14:09:10 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds a maillist and emails to be used when posting a patch for SLOF. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Thomas Huth th...@redhat.com Cc: Nikunj A Dadhania nik...@linux.vnet.ibm.com

Re: [PATCH slof] README: Update with patch submittion note

On Mon, 6 Jul 2015 18:02:00 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 07/06/2015 05:22 PM, Thomas Huth wrote: On Mon, 6 Jul 2015 14:09:10 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds a maillist and emails to be used when posting a patch for SLOF. ... I

Re: [PATCH SLOF v2 4/5] disk-label: introduce helper to check fat filesystem

assembler. - disk-buf c@ e9 IF - disk-buf c@ eb - disk-buf 2+ c@ 90 or - IF false EXIT THEN - THEN + disk-buf fat-bootblock? 0= IF false EXIT THEN s fat-files (interpose-filesystem) true ; Reviewed-by: Thomas Huth th...@redhat.com

Re: [PATCH SLOF v2 3/5] disk-label: rename confusing block word

insertions(+), 37 deletions(-) Reviewed-by: Thomas Huth th...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH SLOF v3 5/5] disk-label: add support for booting from GPT FAT partition

... false This version now looks fine to me. Reviewed-by: Thomas Huth th...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH SLOF v3 5/5] disk-label: add support for booting from GPT FAT partition

Sorry, every time I look at this gpt stuff, my eyes stumble over something new ... On Tue, 30 Jun 2015 16:31:21 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: For a GPT+LVM combination disk, older bootloader that does not support LVM, cannot load kernel from LVM. The patch adds

[SLOF PATCH 0/2] fbuffer: Improve the speed of the cursor drawing

much clue about the grub2 sources yet ... is anybody familiar with this and could give some pointers? Thomas Huth (2): fbuffer: Improve invert-region helper fbuffer: Use a smaller cursor board-js2x/slof/helper.fs | 13 - board-qemu/slof/helper.fs | 14 ++ slof/fs

[SLOF PATCH 1/2] fbuffer: Improve invert-region helper

also make this function to access the memory with half-word, word or long-word accesses. With this additional logic, invert-region-x is also no longer necessary and thus can be removed. Signed-off-by: Thomas Huth th...@redhat.com --- board-js2x/slof/helper.fs | 13 - board-qemu/slof

[SLOF PATCH 2/2] fbuffer: Use a smaller cursor

Drawing the cursor in the frame buffer memory is a very, very slow operation. So let's simply switch to a underscore cursor instead of the full block cursor to save some precious cycles. Signed-off-by: Thomas Huth th...@redhat.com --- slof/fs/fbuffer.fs | 3 ++- 1 file changed, 2 insertions

Re: [SLOF] [SLOF PATCH 2/2] fbuffer: Use a smaller cursor

On 29/07/15 05:42, Segher Boessenkool wrote: On Wed, Jul 29, 2015 at 01:05:48PM +1000, Alexey Kardashevskiy wrote: : fb8-toggle-cursor ( -- ) line# fb8-line2addr column# fb8-columns2bytes + - char-height 0 ?DO + char-height 3 - screen-width screen-depth * * + + 3 0 ?DO Why not

Re: [SLOF PATCH 1/2] fbuffer: Improve invert-region helper

Hi Segher, On 28/07/15 19:04, Segher Boessenkool wrote: On Tue, Jul 28, 2015 at 12:19:54PM +0200, Thomas Huth wrote: : invert-region ( addr len -- ) - 0 ?DO dup dup rb@ -1 xor swap rb! 1+ LOOP drop -; - -: invert-region-x ( addr len -- ) - /x / 0 ?DO dup dup rx@ -1 xor swap rx! xa1

Re: [PATCH] powerpc/rtas: Introduce rtas_get_sensor_fast() for IRQ handlers

this issue by introducing a new rtas_get_sensor_fast() function that does not use rtas_busy_delay() - and thus can only be used for sensors that do not cause a BUSY condition (which should be the case for the sensor that is queried by the EPOW IRQ handler). Signed-off-by: Thomas Huth th

Re: [PATCH] cxl: Fix ambiguous else warnings

On 31/07/15 08:35, Daniel Axtens wrote: Every time I build cxl I see the following warnings: /scratch/dja/linux-capi/drivers/misc/cxl/pci.c: In function ‘sanitise_afu_regs’: /scratch/dja/linux-capi/drivers/misc/cxl/pci.c:712:6: warning: suggest explicit braces to avoid ambiguous ‘else’

[PATCH] powerpc/rtas: Replace magic values with defines

rtas.h already has some nice #defines for RTAS return status codes - let's use them instead of hard-coded magic values! Signed-off-by: Thomas Huth th...@redhat.com --- arch/powerpc/kernel/rtas.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel

Re: powerpc/rtas: Introduce rtas_get_sensor_fast() for IRQ handlers

On 22/07/15 13:25, Michael Ellerman wrote: On Fri, 2015-17-07 at 10:46:58 UTC, Thomas Huth wrote: The EPOW interrupt handler uses rtas_get_sensor(), which in turn uses rtas_busy_delay() to wait for RTAS becoming ready in case it is necessary. But rtas_busy_delay() is annotated with might_sleep

Re: BUG: sleeping function called from ras_epow_interrupt context

On 07/15/2015 09:58 PM, Nathan Fontenot wrote: On 07/15/2015 09:35 AM, Thomas Huth wrote: On 07/14/2015 11:22 PM, Benjamin Herrenschmidt wrote: On Tue, 2015-07-14 at 20:43 +0200, Thomas Huth wrote: Any suggestions how to fix this? Simply revert 587f83e8dd50d? Use mdelay() instead of msleep

Re: [PATCH v3 1/1] KVM: PPC: Book3S: correct width in XER handling

to 64 bits. Signed-off-by: Sam Bobroff sam.bobr...@au1.ibm.com Reviewed-by: Thomas Huth th...@redhat.com Actually this patch also fixes a bug that SLOF sometimes crashes when a vCPU gets kicked out of kernel mode (see the following URL for details: https://bugzilla.redhat.com/show_bug.cgi?id

[PATCH] powerpc/rtas: Introduce rtas_get_sensor_fast() for IRQ handlers

() function that does not use rtas_busy_delay() - and thus can only be used for sensors that do not cause a BUSY condition (which should be the case for the sensor that is queried by the EPOW IRQ handler). Signed-off-by: Thomas Huth th...@redhat.com --- arch/powerpc/include/asm/rtas.h | 1

Re: BUG: sleeping function called from ras_epow_interrupt context

On 07/14/2015 11:22 PM, Benjamin Herrenschmidt wrote: On Tue, 2015-07-14 at 20:43 +0200, Thomas Huth wrote: Any suggestions how to fix this? Simply revert 587f83e8dd50d? Use mdelay() instead of msleep() in rtas_busy_delay()? Something more fancy? A proper fix would be more fancy

BUG: sleeping function called from ras_epow_interrupt context

Hi all! A colleague recently ran into some kernel BUG messages that happen when hot-plugging a virtio disk to a KVM guest on powerpc (with virsh attach-disk), and IIRC CONFIG_DEBUG_ATOMIC_SLEEP enabled. I've tried to re-create the problem with an up-to-date kernel (4.2.0-rc2) and the problem

Re: [PATCH] KVM: PPC: Exit guest upon fatal machine check exception

On 13/11/15 07:26, Aravinda Prasad wrote: > > On Friday 13 November 2015 07:20 AM, David Gibson wrote: >> On Thu, Nov 12, 2015 at 11:22:29PM +0530, Aravinda Prasad wrote: [...] >>> So thinking whether qemu should explicitly enable the new NMI >>> behavior. >> >> So, I think the reasoning above

Re: [PATCH 2/6] powerpc/kconfig: Move sysdev Kconfig later

config" > > source "arch/powerpc/Kconfig.debug" > +source "arch/powerpc/sysdev/Kconfig" > > source "security/Kconfig" > Reviewed-by: Thomas Huth <th...@redhat.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 5/6] powerpc/kconfig: Move cpu options after platform options

t;kernel/Kconfig.freezer" > > source "arch/powerpc/platforms/Kconfig" > +source "arch/powerpc/platforms/Kconfig.cputype" > > menu "Kernel options" > Reviewed-by: Thomas Huth <th...@redhat.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 6/6] powerpc/kconfig: Cell CPU options should depend on PPC_CELL

se the compiler to optimize for the PPE of the Cell Broadband > Engine. This will make the code run considerably faster on Cell Reviewed-by: Thomas Huth <th...@redhat.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Kconfig.cputype: Disallow TUNE_CELL on LE systems

On 06/10/15 12:05, Michael Ellerman wrote: > On Mon, 2015-09-21 at 12:07 +0200, Thomas Huth wrote: >> On 21/09/15 09:18, Michael Ellerman wrote: >>> On Fri, 2015-09-18 at 16:17 +0200, Thomas Huth wrote: >>>> It looks somewhat weird that you can enable TUNE_CELL on

Re: [PATCH v2] Caps in not always shift

Hi! Please CC to s...@lists.ozlabs.org now that we've finally got a SLOF mailing list :-) ! On Wed, 8 Jul 2015 18:47:44 +0200 Dinar valeev k...@opensuse.org wrote: ... /** + * Checks if keypos is a latin key + * @param keypos + * @return - + */ +void check_latin(uint8_t keypos) +

[PATCH] KVM: ppc: Fix size of the PSPB register

The size of the Problem State Priority Boost Register is only 32 bits, so let's change the type of the corresponding variable accordingly to avoid future trouble. Signed-off-by: Thomas Huth <th...@redhat.com> --- arch/powerpc/include/asm/kvm_host.h | 2 +- 1 file changed, 1 insertion

Re: [PATCH] Fix function keys sequence on USB

Hi! May I ask what's the status of this patch? As far as I can see, it has not been included in the repository yet? On 29/05/15 15:30, Dinar valeev wrote: > From: Dinar Valeev > > Original issue is home and end keys are not functional in grub2. > Later I've found other

Re: [PATCH] KVM: ppc: Fix size of the PSPB register

On 02/09/15 00:24, Paul Mackerras wrote: > On Tue, Sep 01, 2015 at 11:41:18PM +0200, Thomas Huth wrote: >> The size of the Problem State Priority Boost Register is only >> 32 bits, so let's change the type of the corresponding variable >> accordingly to avoid future trou

Re: [PATCH] KVM: ppc: Fix size of the PSPB register

On 02/09/15 10:26, Alexander Graf wrote: > >> Am 02.09.2015 um 09:26 schrieb Thomas Huth <th...@redhat.com>: >> >>> On 02/09/15 00:55, Benjamin Herrenschmidt wrote: >>>> On Wed, 2015-09-02 at 08:45 +1000, Paul Mackerras wrote: >>>> On Wed, Se

[PATCH v2] KVM: ppc: Fix size of the PSPB register

t the current code is broken on big endian hosts: kvmppc_get_one_reg_hv() will only return zero for this register since it is using the wrong half of the pspb variable. Let's fix this problem by adjusting the size of the pspb field in the kvm_vcpu_arch structure. Signed-off-by: Thomas Huth <

Re: [PATCH] KVM: ppc: Fix size of the PSPB register

On 02/09/15 00:55, Benjamin Herrenschmidt wrote: > On Wed, 2015-09-02 at 08:45 +1000, Paul Mackerras wrote: >> On Wed, Sep 02, 2015 at 08:25:05AM +1000, Benjamin Herrenschmidt >> wrote: >>> On Tue, 2015-09-01 at 23:41 +0200, Thomas Huth wrote: >>>> The size

Re: [PATCH] Fix function keys sequence on USB

On 01/09/15 16:48, Dinar Valeev wrote: > On Tue, Sep 1, 2015 at 4:13 PM, Thomas Huth <th...@redhat.com> wrote: >> >> Hi! >> >> May I ask what's the status of this patch? As far as I can see, it has >> not been included in the repository yet? > Hi, >

Re: suspicious RCU usage with kvm_pr

On 16/09/15 10:51, Denis Kirjanov wrote: > Hi, > > I see the following trace on qemu startup (ps700 blade): > > v4.2-11169-g64d1def > > > [ 143.369638] === > [ 143.369640] [ INFO: suspicious RCU usage. ] > [ 143.369643] 4.2.0-11169-g64d1def #10 Tainted: G S > [

Re: suspicious RCU usage with kvm_pr

On 16/09/15 12:59, Denis Kirjanov wrote: > On 9/16/15, Thomas Huth <th...@redhat.com> wrote: >> On 16/09/15 10:51, Denis Kirjanov wrote: >>> Hi, >>> >>> I see the following trace on qemu startup (ps700 blade): >>>

[PATCH] powerpc: Kconfig.cputype: Disallow TUNE_CELL on LE systems

It looks somewhat weird that you can enable TUNE_CELL on little endian systems, so let's disable this option with CPU_LITTLE_ENDIAN. Signed-off-by: Thomas Huth <th...@redhat.com> --- I first thought that it might be better to make this option depend on PPC_CELL instead ... but I gues

Re: [PATCH] powerpc: Kconfig.cputype: Disallow TUNE_CELL on LE systems

On 21/09/15 09:18, Michael Ellerman wrote: > On Fri, 2015-09-18 at 16:17 +0200, Thomas Huth wrote: >> It looks somewhat weird that you can enable TUNE_CELL on little >> endian systems, so let's disable this option with CPU_LITTLE_ENDIAN. >> >> Signed-off-by: Th

Re: [PATCH v2] KVM: PPC: Exit guest upon fatal machine check exception

On 16/12/15 06:56, Aravinda Prasad wrote: > This patch modifies KVM to cause a guest exit with > KVM_EXIT_NMI instead of immediately delivering a 0x200 > interrupt to guest upon machine check exception in > guest address. Exiting the guest enables QEMU to build > error log and deliver machine

Re: [PATCH] powerpc/cell: Remove the Cell QPACE code.

On 26/11/15 01:59, Rashmica Gupta wrote: > All users of QPACE have upgraded to QPACE2 so remove the Cell QPACE code. > > Signed-off-by: Rashmica Gupta > --- > arch/powerpc/boot/Makefile| 2 - > arch/powerpc/configs/ppc64_defconfig | 1 - >

Re: [PATCH] powerpc/cell: Remove the Cell QPACE code.

On 26/11/15 13:09, Michael Ellerman wrote: > On Thu, 2015-11-26 at 11:47 +0100, Thomas Huth wrote: > >> On 26/11/15 01:59, Rashmica Gupta wrote: > >>> All users of QPACE have upgraded to QPACE2 so remove the Cell QPACE code. >>> >>> Signed-

Re: [PATCH] powerpc/pseries: Add POWER8NVL support to ibm,client-architecture-support call

On 08.06.2016 03:14, Balbir Singh wrote: > > On 31/05/16 20:32, Michael Ellerman wrote: >> On Tue, 2016-05-31 at 12:19 +0200, Thomas Huth wrote: >>> On 31.05.2016 12:04, Michael Ellerman wrote: >>>> On Tue, 2016-05-31 at 07:51 +0200, Thomas Huth wrote: &

Re: [PATCH] powerpc: Fix IBM_ARCH_VEC_NRCORES_OFFSET value

+" to the patch since the commit 7cc851039d64 did have that as well. And sorry for breaking this! Reviewed-by: Thomas Huth <th...@redhat.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/pseries: Add POWER8NVL support to ibm,client-architecture-support call

On 08.06.2016 12:44, Michael Ellerman wrote: > On Wed, 2016-06-08 at 11:14 +1000, Balbir Singh wrote: >> On 31/05/16 20:32, Michael Ellerman wrote: >>> On Tue, 2016-05-31 at 12:19 +0200, Thomas Huth wrote: >>>> On 31.05.2016 12:04, Michael Ellerman wrote: >>&

[PATCH] powerpc/pseries: Add POWER8NVL support to ibm, client-architecture-support call

ashes when using code compiled explicitly for POWER8 (e.g. with the "-mcpu=power8" option of GCC). Signed-off-by: Thomas Huth <th...@redhat.com> --- arch/powerpc/kernel/prom_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerp

Re: [PATCH] powerpc/pseries: Add POWER8NVL support to ibm,client-architecture-support call

On 31.05.2016 12:04, Michael Ellerman wrote: > On Tue, 2016-05-31 at 07:51 +0200, Thomas Huth wrote: > >> If we do not provide the PVR for POWER8NVL, a guest on this >> system currently ends up in PowerISA 2.06 compatibility mode on >> KVM, since QEMU does not provide a ge

Re: [PATCH] kvm-pr: manage single-step mode

On 08.04.2016 08:58, Laurent Vivier wrote: > > > On 08/04/2016 08:23, Thomas Huth wrote: >> On 22.03.2016 15:53, Laurent Vivier wrote: >>> Until now, when we connect gdb to the QEMU gdb-server, the >>> single-step mode is not managed. >>>

[PATCH] powerpc: Fix definition of SIAR register

tries to write to this register, too (see the mtspr in book3s_hv_rmhandlers.S), the contents of this register sometimes get lost for the guests, e.g. during migration of a VM. To fix this issue, simply switch to the other SPR numer 796 instead. Signed-off-by: Thomas Huth <th...@redhat.com> ---

Re: [PATCH v2] kvm-pr: manage single-step mode

RUPT_MACHINE_CHECK and BOOK3S_INTERRUPT_TRACE > > arch/powerpc/kvm/book3s_pr.c | 32 +++- > 1 file changed, 31 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth <th...@redhat.com> ___ Linuxppc-dev mailing

Re: [PATCH] kvm-pr: manage single-step mode

On 22.03.2016 15:53, Laurent Vivier wrote: > Until now, when we connect gdb to the QEMU gdb-server, the > single-step mode is not managed. > > This patch adds this, only for kvm-pr: > > If KVM_GUESTDBG_SINGLESTEP is set, we enable single-step trace bit in the > MSR (MSR_SE) just before the

Re: [PATCH] powerpc: Fix definition of SIAR register

On 08.04.2016 17:54, Thomas Huth wrote: > The SIAR register is available twice, one time as SPR 780 (unprivileged, > but read-only), and one time as SPR 796 (privileged, but read and write). > The Linux kernel code currently uses SPR 780 - and while this is OK for > read

Re: [PATCH] powerpc: Fix definition of SIAR register

On 25.04.2016 10:15, Alexander Graf wrote: > > >> Am 25.04.2016 um 10:08 schrieb Madhavan Srinivasan >> <ma...@linux.vnet.ibm.com>: >> >> >> >>> On Friday 08 April 2016 09:24 PM, Thomas Huth wrote: >>> The SIAR register is available

Re: powerpc/pseries: start rtasd before PCI probing

/rtasd.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) By the way, same is true for device UNplugging: When unplugging devices in QEMU while the firmware is still running, they are never properly removed from the guest. I've checked it, and you

Re: [PATCH] kvm-pr: manage illegal instructions

On 18.05.2016 12:53, Thomas Huth wrote: > On 18.05.2016 12:18, Thomas Huth wrote: >> On 17.05.2016 19:49, Laurent Vivier wrote: >>> >>> >>> On 17/05/2016 10:37, Alexander Graf wrote: >>>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >&

Re: [PATCH] kvm-pr: manage illegal instructions

On 18.05.2016 12:53, Thomas Huth wrote: > On 18.05.2016 12:18, Thomas Huth wrote: >> On 17.05.2016 19:49, Laurent Vivier wrote: >>> >>> >>> On 17/05/2016 10:37, Alexander Graf wrote: >>>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >&

Re: [PATCH] powerpc: Fix definition of SIAR register

On 12.05.2016 06:57, Paul Mackerras wrote: > On Mon, Apr 25, 2016 at 10:15:47AM +0200, Alexander Graf wrote: >> +#define SPRN_SIAR796 >> >> I'm sure there's a reason (iSeries?) we used the r/o version before. Better >> introduce a new constant that gives us rw access and use that in the

Re: [PATCH] kvm-pr: manage illegal instructions

On 17.05.2016 19:49, Laurent Vivier wrote: > > > On 17/05/2016 10:37, Alexander Graf wrote: >> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>> >>> On 12/05/2016 16:23, Laurent Vivier wrote: On 12/05/2016 11:27, Alexander Graf wrote: > On 05/12/2016 11:10 AM, Laurent Vivier wrote:

Re: [PATCH] kvm-pr: manage illegal instructions

On 18.05.2016 12:18, Thomas Huth wrote: > On 17.05.2016 19:49, Laurent Vivier wrote: >> >> >> On 17/05/2016 10:37, Alexander Graf wrote: >>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>>> >>>> On 12/05/2016 16:23, Laurent Vivier wrote:

[PATCH] powerpc: Fix definition of SIAR and SDAR registers

-by: Thomas Huth <th...@redhat.com> --- arch/powerpc/include/asm/reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h index f5f4c66..ce3e1b7 100644 --- a/arch/powerpc/include/asm/reg.h +++ b/arch/powerpc/i

[PATCH] powerpc: Use privileged SPR number for MMCR2

We are already using the privileged versions of MMCR0, MMCR1 and MMCRA in the kernel, so for MMCR2, we should better use the privileged versions, too, to be consistent. Suggested-by: Paul Mackerras <pau...@ozlabs.org> Signed-off-by: Thomas Huth <th...@redhat.com> --- arch/powerpc

Re: [PATCH] kvm-pr: manage illegal instructions

kvmppc_set_gpr(vcpu, 3, EV_UNIMPLEMENTED); > kvmppc_set_pc(vcpu, kvmppc_get_pc(vcpu) + 4); > emulated = EMULATE_DONE; > + } else { > + kvmppc_core_queue_program(vcpu, SRR1_PROGILL); > +

Re: [PATCH] kvm-pr: manage illegal instructions

On 21.04.2016 11:25, Thomas Huth wrote: > On 15.03.2016 21:18, Laurent Vivier wrote: >> While writing some instruction tests for kvm-unit-tests for powerpc, >> I've found that illegal instructions are not managed correctly with kvm-pr, >> while it is fine with kvm-hv.

[PATCH] ibmveth: Add a proper check for the availability of the checksum features

not occur if the feature is just missing. Signed-off-by: Thomas Huth <th...@redhat.com> --- drivers/net/ethernet/ibm/ibmveth.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index a831f94

[PATCH] KVM: PPC: Book3S PR: Refactor program interrupt related code into separate function

nstruction emulation into a separate function instead. Signed-off-by: Thomas Huth <th...@redhat.com> --- arch/powerpc/kvm/book3s_pr.c | 130 +-- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/b

Re: [PATCH 05/11] KVM: PPC: Book3S HV: Adjust nine checks for null pointers

On 20.01.2017 19:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Jan 2017 11:25:48 +0100 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script "checkpatch.pl" pointed information out like

[PATCH] KVM: PPC: Book3s PR: Allow access to unprivileged MMCR2 register

n, we have to support register 769 in KVM-PR, too. Fixes: 8dd75ccb571f3c92c48014b3dabd3d51a115ab41 Cc: sta...@vger.kernel.org # v3.10+ Signed-off-by: Thomas Huth <th...@redhat.com> --- arch/powerpc/include/asm/reg.h| 1 + arch/powerpc/kvm/book3s_emulate.c | 2 ++ 2 files changed, 3 insertion

Re: [PATCH 05/11] powerpc/kvm: Split HPT allocation from activation

On 15.12.2016 06:53, David Gibson wrote: > Currently, kvmppc_alloc_hpt() both allocates a new hashed page table (HPT) > and sets it up as the active page table for a VM. For the upcoming HPT > resize implementation we're going to want to allocate HPTs separately from > activating them. > > So,

Re: [PATCH 03/11] powerpc/kvm: Gather HPT related variables into sub-structure

On 15.12.2016 06:53, David Gibson wrote: > Currently, the powerpc kvm_arch structure contains a number of variables > tracking the state of the guest's hashed page table (HPT) in KVM HV. This > patch gathers them all together into a single kvm_hpt_info substructure. > This makes life more

Re: [PATCH 02/11] powerpc/kvm: Rename kvm_alloc_hpt() for clarity

_SYMBOL_GPL(kvm_alloc_hpt); > +EXPORT_SYMBOL_GPL(kvm_alloc_hpt_cma); > > -void kvm_release_hpt(struct page *page, unsigned long nr_pages) > +void kvm_free_hpt_cma(struct page *page, unsigned long nr_pages) > { > cma_release(kvm_cma, page, nr_pages); > } > -EXPORT_SYMBOL_GPL(kvm_release_hpt); > +EXPORT_SYMBOL_GPL(kvm_free_hpt_cma); > > /** > * kvm_cma_reserve() - reserve area for kvm hash pagetable Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [PATCH 01/11] powerpc/kvm: Reserve capabilities and ioctls for HPT resizing

On 15.12.2016 06:53, David Gibson wrote: > This adds a new powerpc-specific KVM_CAP_SPAPR_RESIZE_HPT capability to > advertise whether KVM is capable of handling the PAPR extensions for > resizing the hashed page table during guest runtime. > > At present, HPT resizing is possible with KVM PR

Re: [PATCH 06/11] powerpc/kvm: Allow KVM_PPC_ALLOCATE_HTAB ioctl() to change HPT size

On 15.12.2016 06:53, David Gibson wrote: > The KVM_PPC_ALLOCATE_HTAB ioctl() is used to set the size of hashed page > table (HPT) that userspace expects a guest VM to have, and is also used to > clear that HPT when necessary (e.g. guest reboot). > > At present, once the ioctl() is called for the

Re: [PATCH 07/11] powerpc/kvm: Create kvmppc_unmap_hpte_helper()

On 15.12.2016 06:54, David Gibson wrote: > The kvm_unmap_rmapp() function, called from certain MMU notifiers, is used > to force all guest mappings of a particular host page to be set ABSENT, and > removed from the reverse mappings. > > For HPT resizing, we will have some cases where we want to

  1   2   3   >