Re: [Linuxptp-devel] [PATCH v5 2/2] ptp4l man: Add description for setting kthreads priorities

2023-07-25 Thread Richard Cochran
On Tue, Jul 25, 2023 at 09:34:00AM +0200, Lukasz Plachno wrote: > As tx timestamp timeout is something multiple users encounter, > provide information for configuring kthread priorities in manual > for ptp4l where tx_timestamp_timeout is already described. Nice to have an updated man page, but I h

Re: [Linuxptp-devel] [PATCH] raw: Fix PRP trailer detection

2023-07-25 Thread Richard Cochran
On Fri, Jun 30, 2023 at 10:14:06AM +0200, Stephan Wurm wrote: > The PRP trailer detection used a minimum frame size of 70 octets. This > minimum applies to whole ethernet packet frames, consisting of headers, > payload and frame check sequence (FCS). > > Under Linux, VLAN header and FCS are usuall

Re: [Linuxptp-devel] [PATCH v2] remove C99 style loop variable declarations

2023-07-25 Thread Richard Cochran
On Thu, Jun 22, 2023 at 10:47:54PM -0700, Jacob Keller wrote: > When building the tlv.c file, the following warning may occur when > operating in C89 mode: > > $make EXTRA_CFLAGS=-std=gnu89 > tlv.c: In function ‘mgt_post_recv’: > tlv.c:374:17: error: ‘for’ loop initial declarations are only

Re: [Linuxptp-devel] [PATCH v1 0/4] Add multi-domain synchronization to phc2sys

2023-07-25 Thread Richard Cochran
On Thu, Jul 20, 2023 at 04:33:38PM +0200, Miroslav Lichvar wrote: > RFC->v1: > - split into multiple patches > - fixed non-automatic modes > - fixed handling of TAI-UTC offset and leap seconds > - fixed other bugs > - updated man page > > This series improves the automatic mode in phc2sys to suppo

Re: [Linuxptp-devel] [PATCH v2 1/6] Add doubly attached clock support

2023-07-25 Thread Richard Cochran
On Tue, Jul 04, 2023 at 12:30:38PM +0200, Stephan Wurm wrote: > diff --git a/fsm.h b/fsm.h > index 857af05..919e934 100644 > --- a/fsm.h > +++ b/fsm.h > @@ -31,6 +31,7 @@ enum port_state { > PS_PASSIVE, > PS_UNCALIBRATED, > PS_SLAVE, > + PS_PASSIVE_SLAVE, /*according to IEC 6

Re: [Linuxptp-devel] [PATCH v2 0/6] IEC62439-3: Add doubly-attached clock support

2023-07-25 Thread Richard Cochran
On Tue, Jul 04, 2023 at 12:30:37PM +0200, Stephan Wurm wrote: > This patch series adds support for doubly-attached clocks as described > in IEC 62439-3:2016 Appendix A. Without having a copy of that, I'm going to have a hard time swallowing this patch set. Overall, I can't see the reason for this

Re: [Linuxptp-devel] [PATCH v2 0/6] IEC62439-3: Add doubly-attached clock support

2023-07-25 Thread Richard Cochran
On Tue, Jul 04, 2023 at 12:30:37PM +0200, Stephan Wurm wrote: > This patch series adds support for doubly-attached clocks as described > in IEC 62439-3:2016 Appendix A. According to https://webstore.iec.ch/publication/24447 this standard has been "Withdrawn" ? Thanks, Richard ___

Re: [Linuxptp-devel] [PATCH] PHC Index is invalid in phc2sys when ptp4l is in free_running mode.

2023-07-25 Thread Arun Saravanan via Linuxptp-devel
Use case is – ptp4l in free_running mode – PTP syncs the TOD PHC disciplined by other means, say PPS phc2sys source is PHC. With autocfg option phc2sys tries to get the phc_index from ptp4l to determine the source. But since ptp4l is free running mode, pmc_agent_query_port_properties will not gi

Re: [Linuxptp-devel] [PATCH] PHC Index is invalid in phc2sys when ptp4l is in free_running mode.

2023-07-25 Thread Erez
On Sun, 23 Jul 2023 at 21:28, Saravanan Arunachalam via Linuxptp-devel < linuxptp-devel@lists.sourceforge.net> wrote: > The pmc call to ptp4l to get phc_index returns invalid value since in > free_running mode, ptp4l sets phc_index to -1. Adding a socket call in > phc2sys to get the phc_index. >

[Linuxptp-devel] [PATCH v5 2/2] ptp4l man: Add description for setting kthreads priorities

2023-07-25 Thread Lukasz Plachno
As tx timestamp timeout is something multiple users encounter, provide information for configuring kthread priorities in manual for ptp4l where tx_timestamp_timeout is already described. Signed-off-by: Lukasz Plachno --- ptp4l.8 | 32 1 file changed, 32 insertion

[Linuxptp-devel] [PATCH v5 0/2] sk: don't report random errno on timeout

2023-07-25 Thread Lukasz Plachno
Improve error reporting in case of timeout while reading tx timestamp, extend documentation with information about increasing kthread priority. v5: - Use ptp4l man in a subject as the commit does not change code v4: - added generic example for setting priority for PTP kworkers - simplified both

[Linuxptp-devel] [PATCH v5 1/2] sk: don't report random errno on timeout

2023-07-25 Thread Lukasz Plachno
From: Przemek Kitszel With neither caller nor poll() itself zeroing errno value, it will contain result of previous failure, possibly from long time ago. Reporting errno=0 up from sk_receive() would bring confusion, as "%m" is later used in pr_err() (so one would get "error Success"). Use ETIME