Re: [Linuxsampler-devel] Multi-part load and save

2019-02-23 Thread Ivan Maguidhir
On 23/02/2019 15:45, Christian Schoenebeck wrote: Ok, committed the fixes (SVN r3483). I also added test cases against those helper functions: cd src/testcases/ g++ HelperTest.cpp ./a.out Many thanks Christian. CU Christian All the best, Ivan ___

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-23 Thread Christian Schoenebeck
On Samstag, 23. Februar 2019 00:58:46 CET Christian Schoenebeck wrote: > > I've attached a patch containing a few small corrections to the changes > > you made when integrating my patch. > > Oops, sorry and thanks! There are still some issues with the helper > functions with certain paths. I grab

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-22 Thread Christian Schoenebeck
On Freitag, 22. Februar 2019 22:26:18 CET Ivan Maguidhir wrote: > On 21/02/2019 17:23, Christian Schoenebeck wrote: > > I can't say. I just googled "gx99 file" and I see various independent > > source that this file was about "GigaPulse settings". One of them is a > > PDF from> > > Tascam, quote:

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-22 Thread Ivan Maguidhir
On 21/02/2019 17:23, Christian Schoenebeck wrote: I can't say. I just googled "gx99 file" and I see various independent source that this file was about "GigaPulse settings". One of them is a PDF from Tascam, quote: "If convolution encoded instrument is copied onto a GS3 system witho

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-21 Thread Christian Schoenebeck
On Mittwoch, 20. Februar 2019 20:27:53 CET Ivan Maguidhir wrote: > Further to my message earlier, I had a look at two libraries I have > containing .gx99 files again and in both .gig files the 'doxf' chunk's > string contains the filename of the .gx99 file. Which disproves my > theory about it bein

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-20 Thread Ivan Maguidhir
On 20/02/2019 16:57, Christian Schoenebeck wrote: Also note in DLS.cpp, where it is now automatically creating the 'doxf' chunk if missing, I was assuming a chunk size of 148 bytes. Is that correct? And I also figured out now what this ominous ".gx99" file is about: that's for writing convolut

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-20 Thread Ivan Maguidhir
On 20/02/2019 16:57, Christian Schoenebeck wrote: Ok, I just committed the libgig changes for writing gig extension files (SVN r3474). Please review and test them, because most nostably I do not have any gigs with extension files so I cannot test it, and I am also missing some knowledge about t

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-20 Thread Christian Schoenebeck
On Mittwoch, 20. Februar 2019 16:38:31 CET Ivan Maguidhir wrote: > On 20/02/2019 12:36, Christian Schoenebeck wrote: > > Please share your design ideas before implementing anything to avoid > > substantial code rewrites later on. > > Sorry about that. I will in future. Ok, I just committed the li

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-20 Thread Ivan Maguidhir
On 20/02/2019 12:36, Christian Schoenebeck wrote: Please share your design ideas before implementing anything to avoid substantial code rewrites later on. Sorry about that. I will in future. For example looking at your screen shot, I don't think that setting a maximum file size for extension

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-20 Thread Christian Schoenebeck
On Mittwoch, 20. Februar 2019 02:04:19 CET Ivan Maguidhir wrote: > I should have a patch to allow the creation of extension files within a > day or two. I think I have a solution already but I want to test it by > creating a few instruments from scratch and trying them out in LS and > GSt3. I've at

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-19 Thread Ivan Maguidhir
Hi Christian I should have a patch to allow the creation of extension files within a day or two. I think I have a solution already but I want to test it by creating a few instruments from scratch and trying them out in LS and GSt3. I've attached a screen grab of my changes to the gigedit file

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-14 Thread Christian Schoenebeck
On Mittwoch, 13. Februar 2019 18:00:00 CET Ivan Maguidhir wrote: > produce output that GSt3 can open. The string also appears redundant as > changing it or 'zeroing' it has no discernible effect in the GSt3 editor > or main app. Its contents don't appear in the GSt3 editor File Info > dialog either

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-13 Thread Ivan Maguidhir
On 13/02/2019 15:30, Christian Schoenebeck wrote: Ah I see, great! Does that mean you even explored more information/features in those new GSt chunks than currently covered by your patch so far? No. There isn't that much in them. The xfil chunk consists of a 32-bit count, followed by a serie

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-13 Thread Christian Schoenebeck
On Mittwoch, 13. Februar 2019 02:27:22 CET Ivan Maguidhir wrote: > > Are those chunk types also used by GSt or have you introduced them? If you > > have introduced them, what are the precise reasons for introducing them? > > Yes, these chunk types are used by GSt. I figured out their structure by

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-12 Thread Ivan Maguidhir
On 12/02/2019 13:29, Christian Schoenebeck wrote: Hi Ivan, Hi Christian So far I haven't had the time to look at your patch thoroughly yet, but here some questions ... No problem at all. Are those chunk types also used by GSt or have you introduced them? If you have introduced them, what are

Re: [Linuxsampler-devel] Multi-part load and save

2019-02-12 Thread Christian Schoenebeck
On Samstag, 9. Februar 2019 21:59:59 CET Ivan Maguidhir wrote: > Hi all, Hi Ivan, > I'm just writing to submit this patch that I've been working on / > testing for the last while. So far I haven't had the time to look at your patch thoroughly yet, but here some questions ... > The patch provid