Re: [Linuxwacom-devel] [PATCH libwacom] data: add Cintiq 16 .tablet file

2019-01-10 Thread Peter Hutterer
On Thu, Jan 10, 2019 at 10:40:15AM -0800, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Skomra > Reviewed-by: Ping Cheng pushed, thanks Cheers, Peter > --- > data/cintiq-16.tablet | 20 > 1 file changed, 20 insertions(+) > create mode 100644

[Linuxwacom-devel] [PATCH] xsetwacom: error if we're running this under Wayland

2018-12-09 Thread Peter Hutterer
-wacom\fR X server input module. It does not work under a +Wayland compositor as the input module is not active. +.TP +See https://github.com/linuxwacom/xf86-input-wacom/wiki/Wayland for details. + .SH "AUTHORS" Peter Hutterer diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 8b6694

[Linuxwacom-devel] [PATCH 2/4] Reformat a debugging message

2018-10-23 Thread Peter Hutterer
No functional changes but makes grepping for it a lot easier Signed-off-by: Peter Hutterer --- src/wcmUSB.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 8a07368..be9be6e 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -1041,9 +1041,8

[Linuxwacom-devel] [PATCH 3/4] Split EV_MSC handling out of the EV_SYN handling

2018-10-23 Thread Peter Hutterer
The only thing these two had in common was the reset of the event count on failure. Might as well split them up to make the code more readable. Signed-off-by: Peter Hutterer --- src/wcmUSB.c | 68 +++- 1 file changed, 41 insertions(+), 27

[Linuxwacom-devel] [PATCH 4/4] Remember the event types we receive and skip events with no data

2018-10-23 Thread Peter Hutterer
way. Signed-off-by: Peter Hutterer --- src/wcmUSB.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index cf89ff8..2bb6b78 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -38,6 +38,7 @@ typedef struct { int wcmMTChan

[Linuxwacom-devel] [PATCH 1/4] Correct two comments

2018-10-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/wcmUSB.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 8ded958..8a07368 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -980,9 +980,7 @@ static void usbParseEvent(InputInfoPtr pInfo, DBG

Re: [Linuxwacom-devel] [PATCH] Support DTU-1141B on older kernels

2018-10-01 Thread Peter Hutterer
On Fri, Sep 28, 2018 at 03:52:29PM -0700, Ping Cheng wrote: > Signed-off-by: Ping Cheng c091c9e..71b3511 master -> master thanks Cheers, Peter > --- > src/wcmValidateDevice.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c >

Re: [Linuxwacom-devel] [PATCH libwacom] add dtu-1141b .tablet and .svg files

2018-10-01 Thread Peter Hutterer
On Mon, Oct 01, 2018 at 08:45:35AM -0700, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Skomra thanks, applied and pushed f51b89a..3b7693d master -> master Cheers, Peter > --- > data/dtu-1141b.tablet | 35 ++ > data/layouts/dtu-1141b.svg | 88 >

Re: [Linuxwacom-devel] [PATCH 3/3] Overhaul calculation of default scroll, zoom, and spread distances

2018-08-28 Thread Peter Hutterer
CM_BAMBOO3_SCROLL_DISTANCE 80.0 > -#define WCM_BAMBOO3_SCROLL_SPREAD_DISTANCE 350.0 > +/* The values were based on trial and error with a 3rd-gen Bamboo */ > +#define WCM_DEFAULT_MM_XRES (27.8 * 1000) > +#define WCM_DEFAULT_MM_YRES (44.5 * 1000) tbh I got confused

Re: [Linuxwacom-devel] [PATCH] xsetwacom: 'Serial' missing from deprecated parameter list

2018-08-08 Thread Peter Hutterer
On Wed, Aug 08, 2018 at 03:23:27PM -0700, Jason Gerecke wrote: > Reviewed-by: Jason Gerecke > > I'm having some trouble actually applying this patch to my tree, but I > suspect that a recent change to Gmail is probably more the problem > than the patch itself. i think it got mangled in-flight,

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add ISDv4 50fd and 4807

2018-07-24 Thread Peter Hutterer
On Tue, Jul 24, 2018 at 11:11:45AM -0700, Jason Gerecke wrote: > Ref: https://github.com/linuxwacom/libwacom/issues/26 > Ref: https://github.com/linuxwacom/libwacom/issues/28 > Signed-off-by: Jason Gerecke Reviewed-by: Peter Hutterer Cheers, Peter > --- > data/isdv4-4

Re: [Linuxwacom-devel] [PATCH 1/3] Remove unnecessary free() from wcmAllocate

2018-06-27 Thread Peter Hutterer
argument. > > Signed-off-by: Jason Gerecke strange warning because IMO this is still good practise. The whole point of a unified error path is to not have to worry about what has been initialized and whatnot. but Reviewed-by: Peter Hutterer anyway. Cheers, Peter > --- > src/wcmConfig.

Re: [Linuxwacom-devel] [PATCH 3/3] Simplify boolean expression

2018-06-27 Thread Peter Hutterer
alent to the 'bool(A) != bool(B)' expression. proximity is an int, not a bool. So in theory, it could be some other value and the != doesn't work that well then. I suggest including stdbool.h and switching all these to boolean at some point. But until then, *shrug*. Reviewed-by: Peter Hutterer fo

Re: [Linuxwacom-devel] [PATCH libwacom] release.sh: add release.sh to libwacom

2018-05-20 Thread Peter Hutterer
On Fri, May 18, 2018 at 02:18:40PM -0700, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Armstrong Skomra > --- > Apparently the old release.sh in xf86-input-wacom also worked for > libwacom. I missed this fact because the one time I did a libwacom > release, I just

Re: [Linuxwacom-devel] [PATCH] data: Add elan-2537 (HP Envy x360 15m-bq1xx)

2018-04-25 Thread Peter Hutterer
On Wed, Apr 25, 2018 at 06:12:24PM -0700, Jason Gerecke wrote: > Ref: https://github.com/linuxwacom/libwacom/issues/21 > Signed-off-by: Jason Gerecke thanks! 4501ec6..abbea12 master -> master Cheers, Peter > --- > data/elan-2537.tablet | 14 ++ > 1

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add HP Elite x2 1012 G2

2018-04-25 Thread Peter Hutterer
On Wed, Apr 25, 2018 at 08:47:20AM -0700, Jason Gerecke wrote: > Ref: https://github.com/linuxwacom/libwacom/issues/20 > Signed-off-by: Jason Gerecke pushed ase7d4994..1661b7a master -> master thanks Cheers, Peter > --- > data/isdv4-485e.tablet | 14

Re: [Linuxwacom-devel] [PATCH input-wacom] backport: restore touch functionality to SW_MUTE_DEVICE devices

2018-04-23 Thread Peter Hutterer
On Mon, Apr 23, 2018 at 12:44:51PM -0700, Aaron Armstrong Skomra wrote: > Setting the bit for SW_MUTE_DEVICE on kernels which do not have > SW_MUTE_DEVICE declared in input.h (prior to 3.13), causes these > devices' touch interfaces not to work. Why is that? is that switch always enabled or

Re: [Linuxwacom-devel] [PATCH input-wacom 2/2] 2.6.32: Fix abs get/set accessors for 2.6.36/2.6.37

2018-04-23 Thread Peter Hutterer
On Mon, Apr 23, 2018 at 08:18:48AM -0700, Jason Gerecke wrote: > On Sun, Apr 22, 2018 at 4:06 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > On Fri, Apr 20, 2018 at 02:33:21PM -0700, Jason Gerecke wrote: > >> The 2.6.36 kernel removes several members f

Re: [Linuxwacom-devel] [PATCH input-wacom 2/2] 2.6.32: Fix abs get/set accessors for 2.6.36/2.6.37

2018-04-22 Thread Peter Hutterer
On Fri, Apr 20, 2018 at 02:33:21PM -0700, Jason Gerecke wrote: > The 2.6.36 kernel removes several members from `struct input_dev` (e.g. > abs, absres) and replaces them with a structs and accessor functions. > To allow the input-wacom code to compile under both old and new kernels, > commits

Re: [Linuxwacom-devel] [PATCH input-wacom 1/2] Include generated config.h header in all kernels

2018-04-22 Thread Peter Hutterer
On Fri, Apr 20, 2018 at 02:33:20PM -0700, Jason Gerecke wrote: > The config.h header that is generated after running the configure > script should be included by all the kernels to ensure that we are > able to access compiler defines only discovered at config time. > > Signed-off-by: Jason

Re: [Linuxwacom-devel] [PATCH libwacom v2] data: Add ELAN 22E2 (HP Spectre x360)

2018-04-22 Thread Peter Hutterer
On Fri, Apr 20, 2018 at 03:01:09PM -0700, Jason Gerecke wrote: > Ref: https://github.com/linuxwacom/libwacom/issues/15 > Signed-off-by: Jason Gerecke To github.com:linuxwacom/libwacom.git 91a935c..e7d4994 master -> master thanks! Cheers, Peter > --- >

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add ELAN 22E2 (HP Spectre x360)

2018-04-22 Thread Peter Hutterer
On Fri, Apr 20, 2018 at 03:00:10PM -0700, Jason Gerecke wrote: > On Tue, Apr 17, 2018 at 9:17 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > On Tue, Apr 17, 2018 at 10:53:17AM -0700, Jason Gerecke wrote: > >> Ref: https://github.com/linuxwacom/libwaco

Re: [Linuxwacom-devel] [PATCH libwacom] Fix memory leak in error path

2018-04-17 Thread Peter Hutterer
d"); > + g_list_free (devices); > return NULL; > } > > -- > 2.17.0 Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter -- Check out the vibrant t

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add ELAN 22E2 (HP Spectre x360)

2018-04-17 Thread Peter Hutterer
On Tue, Apr 17, 2018 at 10:53:17AM -0700, Jason Gerecke wrote: > Ref: https://github.com/linuxwacom/libwacom/issues/15 > Signed-off-by: Jason Gerecke > --- > data/elan-22e2.tablet | 17 + > 1 file changed, 17 insertions(+) > create mode 100644

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add isdv4-5146 (Lenovo ThinkPad X1 Yoga [3rd-gen])

2018-04-17 Thread Peter Hutterer
On Tue, Apr 17, 2018 at 10:53:18AM -0700, Jason Gerecke wrote: > Ref: https://github.com/linuxwacom/libwacom/issues/17 > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > dat

Re: [Linuxwacom-devel] [PATCH input-wacom] Use `dracut` if available to update RHEL/Fedora initramfs

2018-03-19 Thread Peter Hutterer
ing arguments to the command > every time. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> this is the most I've ever had to do with dracut, so *shrug*. It doesn't look actively wrong though, so a very tentative Acked-by: Peter Hutterer <peter.hutte...@who-t.net>

Re: [Linuxwacom-devel] [PATCH xf86-input-wacom] Update README to reflect the move to Github.

2018-03-14 Thread Peter Hutterer
On Tue, Mar 13, 2018 at 10:47:44AM -0700, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Armstrong Skomra <sko...@gmail.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> thanks! Cheers, Peter > --- > README| 47 ---

Re: [Linuxwacom-devel] [PATCH xf86-input-wacom] Fail the Coverity build if their script cannot be downloaded

2018-03-14 Thread Peter Hutterer
he '-f' option. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > > diff --git a/.travis.yml b/.travis

Re: [Linuxwacom-devel] [PATCH] Check both valid and working state when finding new channels

2018-03-08 Thread Peter Hutterer
ge.net/p/linuxwacom/bugs/339/#f940 > Ref: https://sourceforge.net/p/linuxwacom/bugs/349/ > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > --- Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > src/wcmUSB.c | 3 ++- > 1 file changed, 2 in

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add support for third generation Intuos

2018-03-06 Thread Peter Hutterer
On Tue, Mar 06, 2018 at 10:12:47AM -0800, Aaron Armstrong Skomra wrote: > Also update test to reflect the lack of tilt with its stylus. > > Signed-off-by: Aaron Armstrong Skomra pushed, thanks To github.com:linuxwacom/libwacom.git 9ff640d..e191479 master -> master

Re: [Linuxwacom-devel] [PATCH input-wacom] Update README to reflect the move to Github.

2018-03-06 Thread Peter Hutterer
le.am]) > AC_CONFIG_HEADERS([config.h]) > > -AM_INIT_AUTOMAKE([dist-bzip2 no-dist-gzip]) > +AM_INIT_AUTOMAKE([dist-bzip2 no-dist-gzip foreign]) > AM_MAINTAINER_MODE > > AC_PROG_CC > -- > 2.7.4 Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Though I'd us

Re: [Linuxwacom-devel] [PATCH] Fix tilt-y being overridden with tilt-x

2018-03-06 Thread Peter Hutterer
e following pull request: > https://github.com/linuxwacom/xf86-input-wacom/pull/12 Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > > src/wcmFilter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/wcmFilter.c

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add ISDv4 50b4 tablet

2018-03-04 Thread Peter Hutterer
[re-sending to the list because the first one got rejected] On Fri, Mar 02, 2018 at 07:28:55AM -0800, Jason Gerecke wrote: > Ref: https://github.com/linuxwacom/libwacom/issues/14 > Signed-off-by: Jason Gerecke pushed, thanks! 007c250..c86e738 master -> master

Re: [Linuxwacom-devel] Announcement: Wacom Smartpad support

2018-02-15 Thread Peter Hutterer
On Thu, Feb 01, 2018 at 04:57:51PM +1000, Peter Hutterer wrote: > Just spreading this a bit wider and to a more targeted audience :) > > Benjamin and I started a project called "tuhi" that connects to the Wacom > Smartpad range and downloads the data off those devices. Right

Re: [Linuxwacom-devel] [PATCH libwacom] data: Remove FIXME from Huion H610 Pro

2018-02-15 Thread Peter Hutterer
On Wed, Feb 14, 2018 at 08:55:49AM -0800, Jason Gerecke wrote: > Evdev codes have been verified, so this FIXME is no longer necessary. > > Fixes: https://github.com/linuxwacom/libwacom/issues/13 > Signed-off-by: Jason Gerecke > --- > data/huion-h610-pro.tablet | 1 - >

[Linuxwacom-devel] [PATCH libwacom] data: fix PairedID entry for the DTH-2452

2018-02-12 Thread Peter Hutterer
Missing the 'usb' prefix which wasn't caught by the test suite. Add the entry to libwacom_compare() to make sure this doesn't happen again. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- data/dth-2452.tablet | 2 +- libwacom/libwacom.c | 5 + 2 files changed, 6 inse

Re: [Linuxwacom-devel] [PATCH libwacom] data: Styli shipped with the One by Wacom have two buttons

2018-02-07 Thread Peter Hutterer
On Wed, Feb 07, 2018 at 08:31:47AM -0800, Jason Gerecke wrote: > According to manuals and user reports, both generations of the One by Wacom > had styli with two side-switches, not just one. > > Ref: https://sourceforge.net/p/linuxwacom/mailman/message/36219165/ > Fixes: fc6f5ab8f8 ("data: Add

Re: [Linuxwacom-devel] New definition file for Lenovo's X1 Tablet second generation

2018-02-05 Thread Peter Hutterer
Hi Theo, can you send this as git-formatted patch please, I can merge it directly then. On Sun, Feb 04, 2018 at 02:52:12AM +0100, Theo Kluter wrote: > Hi All, > > All who have a lenovo X1 Tablet and want to use the latest versions of > the current linux distributions (e.g. Ubuntu 17.10, Fedora,

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add 2nd-generation "One by Wacom"

2018-02-01 Thread Peter Hutterer
On Thu, Feb 01, 2018 at 11:15:14AM -0800, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke > --- thanks, pushed as6bac63b..ca44822 master -> master Cheers, Peter > data/one-by-wacom-m-p2.tablet | 23 +++ > data/one-by-wacom-s-p2.tablet |

[Linuxwacom-devel] Announcement: Wacom Smartpad support

2018-01-31 Thread Peter Hutterer
Just spreading this a bit wider and to a more targeted audience :) Benjamin and I started a project called "tuhi" that connects to the Wacom Smartpad range and downloads the data off those devices. Right now we have support for the Spark and the Slate, but we're looking for testers that have a

Re: [Linuxwacom-devel] [PATCH] Support DTK-2451 and DTH-2452 on older kernels

2018-01-31 Thread Peter Hutterer
On Wed, Jan 31, 2018 at 05:39:04PM -0800, Ping Cheng wrote: > On Wed, Jan 31, 2018 at 5:32 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > > On Wed, Jan 31, 2018 at 03:04:34PM -0800, Ping Cheng wrote: > > > From: Ping Cheng <ping.ch...@wacom.com> &

Re: [Linuxwacom-devel] [PATCH xf86-input-wacom] Support DTK-2451 and DTH-2452 on older kernels

2018-01-31 Thread Peter Hutterer
On Wed, Jan 31, 2018 at 05:51:17PM -0800, Ping Cheng wrote: > Signed-off-by: Ping Cheng ffb3925..35047a3 master -> master pushed, thanks Cheers, Peter > --- > src/wcmUSB.c| 3 +++ > src/wcmValidateDevice.c | 3 +++ > 2 files changed, 6 insertions(+) >

Re: [Linuxwacom-devel] [PATCH] Support DTK-2451 and DTH-2452 on older kernels

2018-01-31 Thread Peter Hutterer
On Wed, Jan 31, 2018 at 03:04:34PM -0800, Ping Cheng wrote: > From: Ping Cheng <ping.ch...@wacom.com> > > Signed-off-by: Ping Cheng <ping.ch...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> but alas, it doesn't seem to apply to current master? Che

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add data and SVG files for DTK-2451 and DTH-2452

2018-01-30 Thread Peter Hutterer
On Tue, Jan 30, 2018 at 08:48:24AM -0800, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Armstrong Skomra > --- > data/dth-2452.tablet | 37 > data/dtk-2451.tablet | 36 > data/layouts/dth-2452.svg | 144 >

Re: [Linuxwacom-devel] [PATCH libwacom] Add Coverity integration to .travis.yml

2018-01-08 Thread Peter Hutterer
On Mon, Jan 08, 2018 at 02:57:57PM -0800, Jason Gerecke wrote: > Use the same kind of setup as xf86-input-wacom to run Coverity nightly. > > Signed-off-by: Jason Gerecke looks ok on a quick glance, thanks f50f6af..74a140e master -> master Cheers, Peter > ---

Re: [Linuxwacom-devel] [PATCH libwacom 2/2] data: Change ISDv4 50b6 to use USB bus

2018-01-08 Thread Peter Hutterer
On Mon, Jan 08, 2018 at 09:15:39AM -0800, Jason Gerecke wrote: > Original data from `./Lenovo ThinkPad X1 Yoga 2nd/sysinfo.tkM70wemeh` > in the wacom-hid-descriptors repository indicates that this is a USB > device, not an I2C device. > > Fixes: d8181a95b7 ("data: Add several ISDv4 tablet

Re: [Linuxwacom-devel] [PATCH] Be more strict about linking to already-linked devices

2018-01-07 Thread Peter Hutterer
to use the wcmTouchDevice > variable. > > Fixes: 8bb519ef2b ("Update wcmTouchDevice for touch interface") > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Acked-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > src/wcmConfi

Re: [Linuxwacom-devel] [PATCH] Be more strict about linking to already-linked devices

2018-01-07 Thread Peter Hutterer
to use the wcmTouchDevice > variable. > > Fixes: 8bb519ef2b ("Update wcmTouchDevice for touch interface") > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Acked-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > src/wcmConfi

Re: [Linuxwacom-devel] [PATCH v2 2/3] Add support for Cintiq Pro 24/32

2017-12-18 Thread Peter Hutterer
On Mon, Dec 18, 2017 at 04:53:59PM -0800, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> > --- > Changes from v1: > * Add resolution information to WacomModelDesc table as suggest

Re: [Linuxwacom-devel] [PATCH v2 1/3] conf: Add preprobe fdi config to workaround EV_SW issues in HAL

2017-12-18 Thread Peter Hutterer
On Mon, Dec 18, 2017 at 04:53:58PM -0800, Jason Gerecke wrote: > The HAL daemon used by RHEL6/CentOS6 does not play nicely with input > devices that advertise unsupported EV_SW events. Devices with such > an event will fail in the middle of the probe process, preventing > the X server from being

Re: [Linuxwacom-devel] [PATCH] Pass current WacomDeviceState through to sendAction

2017-12-18 Thread Peter Hutterer
cke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > src/wcmCommon.c | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/src/wcmCommon.c b/src/wcmCommon.c &

Re: [Linuxwacom-devel] [PATCH] Implement "pan" scrolling functionality

2017-12-18 Thread Peter Hutterer
Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Shouldn't this be named drag-scroll? or maybe 'button-scroll'? Aside from 'panscroll' looking weird after about 5 occurances it also doesn't really specify what it does. The code itself here is Reviewed-by: Peter Hutterer <peter.hutte.

Re: [Linuxwacom-devel] [PATCH 2/2] tools: Prevent use of invalid (negative) fd

2017-12-18 Thread Peter Hutterer
gt; we don't actually try to use the fd. > > Coverity-id: 208168 > Fixes: 3546d8ab1b ("tools: add isdv4-serial-debugger test program.") > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter &g

Re: [Linuxwacom-devel] [PATCH 1/4] Detect if HAL fdi configuration needs to be installed

2017-12-17 Thread Peter Hutterer
On Sun, Dec 17, 2017 at 03:54:11PM -0800, Jason Gerecke wrote: > On Sun, Dec 17, 2017 at 3:34 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > On Fri, Dec 15, 2017 at 11:48:50AM -0800, Jason Gerecke wrote: > >> RHEL6/CentOS6 use HAL as an Xorg con

Re: [Linuxwacom-devel] [PATCH 4/4] Add support for Cintiq 27QHDT

2017-12-17 Thread Peter Hutterer
4B:/* MobileStudio Pro 16 Touch */ > case 0x353:/* Cintiq Pro 13 FHD Touch */ > -- > 2.15.1 Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> for both the ID patches Cheers, Peter -

Re: [Linuxwacom-devel] [PATCH 2/4] conf: Add preprobe fdi config to workaround EV_SW issues in HAL

2017-12-17 Thread Peter Hutterer
ered a problem. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> This makes me incredibly sad but given that hal is dead there isn't really another option. I do recommend that distros that ship HAL patch the hal package instead of applying this patch though. Reviewed-by

Re: [Linuxwacom-devel] [PATCH 1/4] Detect if HAL fdi configuration needs to be installed

2017-12-17 Thread Peter Hutterer
On Fri, Dec 15, 2017 at 11:48:50AM -0800, Jason Gerecke wrote: > RHEL6/CentOS6 use HAL as an Xorg configuration database instead of the > more modern xorg.conf.d mechanism. Our driver currently detects that > the X xserver supports xorg.conf.d on these distributions and so prefers > to install the

Re: [Linuxwacom-devel] [PATCH] Build tools with AM_CFLAGS and its warnings

2017-11-29 Thread Peter Hutterer
> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > tools/Makefile.am | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/Makefile.am b/tools/Mak

Re: [Linuxwacom-devel] One by Wacom CTL-672

2017-11-28 Thread Peter Hutterer
xorg-server 2:1.18.4-0ubuntu0.7 (For technical support please see > http://www.ubuntu.com/support) > Current version of pixman: 0.33.6 > Before reporting problems, check http://wiki.x.org > to make sure that you have the latest version. > > Previously trying to install the

Re: [Linuxwacom-devel] [PATCH] Add support for kernel's new BTN_STYLUS3 event

2017-11-09 Thread Peter Hutterer
On Thu, Nov 09, 2017 at 02:12:45PM -0800, Jason Gerecke wrote: > On Wed, Nov 8, 2017 at 5:27 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > On Tue, Nov 07, 2017 at 08:33:34AM -0800, Jason Gerecke wrote: > >> BTN_STYLUS3 was (will be) added to the L

Re: [Linuxwacom-devel] [PATCH] Add support for kernel's new BTN_STYLUS3 event

2017-11-08 Thread Peter Hutterer
gate > back"). Remapping this button to a different function is possible by > using commands like `xsetwacom set button 8 `. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> though I'm wondering w

Re: [Linuxwacom-devel] Adding support fox xp-pen star 03

2017-11-08 Thread Peter Hutterer
On Wed, Nov 08, 2017 at 12:42:53PM -0500, akktor wrote: > Similar to huion h610 pro looks good, thanks. I have one request though: > diff --git a/data/xp-pen-star03.tablet b/data/xp-pen-star03.tablet > new file mode 100644 > index 000..10fe2cd > --- /dev/null > +++

Re: [Linuxwacom-devel] [PATCH libwacom 2/2] Add new stylus type "3D" for the new "Pro Pen 3D"

2017-11-08 Thread Peter Hutterer
On Wed, Nov 08, 2017 at 02:44:12PM -0800, Jason Gerecke wrote: > On Tue, Nov 7, 2017 at 4:15 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > On Tue, Nov 07, 2017 at 08:49:04AM -0800, Jason Gerecke wrote: > >> The new "Pro Pen 3D" is sufficient

Re: [Linuxwacom-devel] [PATCH libwacom v2 1/2] Add Pro Pen 3D

2017-11-08 Thread Peter Hutterer
On Wed, Nov 08, 2017 at 01:24:48PM -0800, Jason Gerecke wrote: > The Wacom Pro Pen 3D includes a third barrel switch which is intended to > be particularly useful in applications where one frequency uses pan, zoom, > and rotate to navigate around a scene or model. The pen is compatible with > the

Re: [Linuxwacom-devel] [PATCH libwacom 2/2] Add new stylus type "3D" for the new "Pro Pen 3D"

2017-11-07 Thread Peter Hutterer
On Tue, Nov 07, 2017 at 08:49:04AM -0800, Jason Gerecke wrote: > The new "Pro Pen 3D" is sufficiently different from the other pen types > that it deserves new type. This makes it easier for userspace to provide > appropriate UI and suggested button assignments. is it really that different

Re: [Linuxwacom-devel] [PATCH libwacom 1/2] Add Pro Pen 3D

2017-11-07 Thread Peter Hutterer
On Tue, Nov 07, 2017 at 08:49:03AM -0800, Jason Gerecke wrote: > The Wacom Pro Pen 3D includes a third barrel switch which is intended to > be particularly useful in applications where one frequency uses pan, zoom, > and rotate to navigate around a scene or model. The pen is compatible with > the

Re: [Linuxwacom-devel] [PATCH libwacom] Add new 'EvdevCodes' key to the Buttons section

2017-11-07 Thread Peter Hutterer
On Wed, Oct 18, 2017 at 11:37:29AM -0700, Jason Gerecke wrote: > Thanks for taking this up, Peter. I'm adding Carlos (I'm not sure if > he's subscribed to the list?) for the heads-up and to ensure its > reasonable from GNOME's POV. Hopefully this gives them exactly what > they need to ensure the

Re: [Linuxwacom-devel] [PATCH libwacom v2] data: Add Dell Canvas 27

2017-11-07 Thread Peter Hutterer
On Tue, Nov 07, 2017 at 02:58:32PM +0100, Benjamin Tissoires wrote: > The touchscreen part is not from Wacom, so we need to > teach libwacom and libinput that both are part of the > same device group for them to do touch arbitration. > > Signed-off-by: Benjamin Tissoires

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add Dell Canvas 27

2017-11-05 Thread Peter Hutterer
On Fri, Nov 03, 2017 at 03:01:36PM +0100, Benjamin Tissoires wrote: > The touchscreen part is not from Wacom, so we need to > teach libwacom and libinput that both are part of the > same device group for them to do touch arbitration. > > Signed-off-by: Benjamin Tissoires

Re: [Linuxwacom-devel] New, One by Wacom, CTL-472

2017-11-05 Thread Peter Hutterer
On Mon, Nov 06, 2017 at 10:02:33AM +1000, Peter Hutterer wrote: > On Fri, Nov 03, 2017 at 11:05:23PM +0800, Cameron Glew wrote: > > Hello everyone, > > > > I just picked up a One by Wacom (small) tablet. > > It's the new CTL-472 model. > > > > I notice

Re: [Linuxwacom-devel] New, One by Wacom, CTL-472

2017-11-05 Thread Peter Hutterer
On Fri, Nov 03, 2017 at 11:05:23PM +0800, Cameron Glew wrote: > Hello everyone, > > I just picked up a One by Wacom (small) tablet. > It's the new CTL-472 model. > > I noticed this tablet was mentioned on the wiki *Device IDs *section: >

Re: [Linuxwacom-devel] [PATCH xf86-input-wacom] conf: add Dell Canvas 27 touch

2017-11-05 Thread Peter Hutterer
On Fri, Nov 03, 2017 at 04:03:38PM -0700, Jason Gerecke wrote: > On November 3, 2017 2:23:10 PM PDT, Benjamin Tissoires > wrote: > >On Fri, Nov 3, 2017 at 9:15 PM, Aaron Armstrong Skomra > > wrote: > >> > >> > >> On Fri, Nov 3, 2017 at 7:19 AM,

Re: [Linuxwacom-devel] wacom slate

2017-10-26 Thread Peter Hutterer
On Wed, Oct 25, 2017 at 11:07:05PM +0100, Luca Tagliacozzo wrote: > Hallo there, sorry to bother, I have recently bought a wacom slate and > following a suggestion by Ping I though I could try to help with making it > usable by the linux community. > > I am very non-expert in kernel module

[Linuxwacom-devel] [PATCH libwacom] Add new 'EvdevCodes' key to the Buttons section

2017-10-17 Thread Peter Hutterer
istics for a specific class. The Huion 610 Pro currently has a list of assumed mappings to avoid having warnings in every single client. This requires someone with that device to fix it. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- data/bamboo-0fg-s-p.tablet | 1 + data/b

Re: [Linuxwacom-devel] [PATCH 3/3] make sourceforge release optional

2017-10-16 Thread Peter Hutterer
On Thu, Oct 12, 2017 at 12:11:05PM -0700, Aaron Armstrong Skomra wrote: > Note that the script checks "origin master" in its "top commit" > checks etc. so that the script itself does not need to be > updated to github for these tests. You need to update your local > remotes instead. this script

Re: [Linuxwacom-devel] [PATCH 2/3] add github to release script

2017-10-16 Thread Peter Hutterer
On Thu, Oct 12, 2017 at 12:11:04PM -0700, Aaron Armstrong Skomra wrote: > Change release download urls to point to Github. > > Signed-off-by: Aaron Armstrong Skomra > --- > > I added the line: > - module_url=`echo "$full_module_url" | $GREP -o -e "/mesa/.*" -e >

Re: [Linuxwacom-devel] [PATCH 1/3] remove release script code from other projects

2017-10-16 Thread Peter Hutterer
On Thu, Oct 12, 2017 at 12:11:03PM -0700, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Armstrong Skomra <sko...@gmail.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- &

Re: [Linuxwacom-devel] [PATCH libwacom] Mark 2nd-gen non-professional "Intuos" devices (CTH-X90) as "Bamboo" class

2017-10-02 Thread Peter Hutterer
On Mon, Oct 02, 2017 at 05:20:26PM -0700, Ping Cheng wrote: > On Mon, Oct 2, 2017 at 3:20 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > On Mon, Oct 02, 2017 at 02:33:05PM -0700, Ping Cheng wrote: > >> On Fri, Sep 29, 2017 at 7:25 AM, Jason Gerecke <kil

Re: [Linuxwacom-devel] [PATCH libwacom] Mark 2nd-gen non-professional "Intuos" devices (CTH-X90) as "Bamboo" class

2017-10-02 Thread Peter Hutterer
On Fri, Sep 29, 2017 at 07:25:30AM -0700, Jason Gerecke wrote: > These devices are much more similar to the Bamboo line of devices than to > the original professional "Intuos" devices (GD-) that are nearly 20 > years old at this point. The 1st-gen non-professional "Intuos" devices > (CTH-X80)

Re: [Linuxwacom-devel] [PATCH libwacom] Mark 2nd-gen non-professional "Intuos" devices (CTH-X90) as "Bamboo" class

2017-10-02 Thread Peter Hutterer
On Mon, Oct 02, 2017 at 02:33:05PM -0700, Ping Cheng wrote: > On Fri, Sep 29, 2017 at 7:25 AM, Jason Gerecke wrote: > > These devices are much more similar to the Bamboo line of devices than to > > the original professional "Intuos" devices (GD-) that are nearly 20 > >

Re: [Linuxwacom-devel] [PATCH] xsetwacom: Recognize 'AltGr' key as synonym for 'ISO_Level3_Shift'

2017-09-14 Thread Peter Hutterer
typically be used. > > https://sourceforge.net/p/linuxwacom/bugs/344/ > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > tools/xsetwacom.c | 2 ++ > 1 file changed, 2 inserti

Re: [Linuxwacom-devel] [PATCH input-wacom] Remove duplicated "Wacom" prefix from some devices

2017-09-13 Thread Peter Hutterer
On Wed, Sep 13, 2017 at 08:05:11AM -0700, Jason Gerecke wrote: > Fixes: 38c795d ("backport: HID: wacom: Improve generic name generation") > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> so simple, even I can add my Reviewed-by: Peter Hutterer <peter.hutte

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add ISDv4 4831 (Dell XPS 13 9365)

2017-09-13 Thread Peter Hutterer
On Wed, Sep 13, 2017 at 08:37:09AM -0700, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke pushed, thanks Cheers, Peter > --- > data/isdv4-4831.tablet | 14 ++ > 1 file changed, 14 insertions(+) > create mode 100644 data/isdv4-4831.tablet > > diff

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add more ISDv4 devices

2017-08-24 Thread Peter Hutterer
On Thu, Aug 24, 2017 at 10:54:13AM -0700, Jason Gerecke wrote: > Dell Venue 8 Pro 5855 (0x4809 and 0x4824) > HP EliteBook x360 1030 G2 (0x481a) > Dell XPS 12 9250 (0x4822) > Dell Latitude 5285 (0x484c) > Lenovo ThinkPad T550 (0x5010) > > Signed-off-by: Jason Gerecke

[Linuxwacom-devel] [PATCH] Remove the device's fd from the select() set when we get ENODEV

2017-07-17 Thread Peter Hutterer
triggered to call read_input on it anymore. https://sourceforge.net/p/linuxwacom/bugs/337/ Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86Wacom.c | 12 +--- src/xf86Wacom.h | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/xf86Wacom.c

Re: [Linuxwacom-devel] [PATCH xf86-input-wacom] Support DTH-1152 on older kernels

2017-07-13 Thread Peter Hutterer
alidateDevice.c > @@ -317,6 +317,8 @@ int wcmDeviceTypeKeys(InputInfoPtr pInfo) > case 0x350:/* Cintiq Pro 16 UHD */ > case 0x353:/* Cintiq Pro 13 FHD Touch */ > case 0x354:/* Cintiq Pro 13

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add .tablet file for DTH-1152

2017-07-13 Thread Peter Hutterer
On Thu, Jul 13, 2017 at 10:03:44AM -0700, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Armstrong Skomra > --- > data/dth-1152.tablet | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100644 data/dth-1152.tablet > > diff --git

Re: [Linuxwacom-devel] [PATCH] test: Update test_normalize_pressure to work with maxCurve

2017-06-19 Thread Peter Hutterer
k as expected. > > Fixes: d958ab79d2 (Introduce "Pressure2K" config option for incompatible > software) > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > test/wacom-t

Re: [Linuxwacom-devel] [PATCH v2 libwacom] data: Add .tablet files for Wireless Intuos Pro second generation

2017-05-31 Thread Peter Hutterer
On Wed, May 31, 2017 at 09:02:19AM -0700, Aaron Armstrong Skomra wrote: > Also correct width and height for intuos-pro-2-l.tablet, > cintiq-pro-13.tablet and cintiq-pro-16.tablet. > > Signed-off-by: Aaron Armstrong Skomra > --- > Peter, > > Good catch, I had just copied

Re: [Linuxwacom-devel] [PATCH libwacom] Add .tablet files for Wireless Intuos Pro second generation

2017-05-28 Thread Peter Hutterer
On Wed, May 24, 2017 at 02:27:26PM -0700, Aaron Armstrong Skomra wrote: > Signed-off-by: Aaron Armstrong Skomra > --- > data/intuos-pro-2-l-wl.tablet | 67 > +++ > data/intuos-pro-2-m-wl.tablet | 67 >

Re: [Linuxwacom-devel] [PATCH v2] Support recent display devices on older kernels

2017-05-15 Thread Peter Hutterer
On Mon, May 15, 2017 at 03:11:34PM -0700, Aaron Armstrong Skomra wrote: > Older kernels like 2.6.30 will end up with touches > interpreted as relative events unless these devices > are explicitly added. > > Signed-off-by: Aaron Armstrong Skomra <aaron.sko...@wacom.com>

Re: [Linuxwacom-devel] [PATCH] Support recent display devices on older kernels

2017-05-14 Thread Peter Hutterer
On Fri, May 12, 2017 at 01:37:53PM -0700, Aaron Armstrong Skomra wrote: > Older kernels like 2.6.30 will end up with touches > interpreted as relative events unless these devices > are explicitly added. > > Signed-off-by: Aaron Armstrong Skomra > --- > src/wcmUSB.c

Re: [Linuxwacom-devel] [PATCH] xsetwacom: use XkbGetMap instead of XkbGetKeyboard

2017-05-10 Thread Peter Hutterer
On Wed, May 10, 2017 at 08:16:07PM +0200, Sebastian Reuße wrote: > XkbGetMap is more robust in cases where certain keyboard description > components > are missing. XkbGetKeyboard will fail when any component cannot be resolved; > since XkbAllComponentsMask is requested, any missing component will

[Linuxwacom-devel] [PATCH libwacom] Fix compiler warning about possibly truncated file name

2017-05-09 Thread Peter Hutterer
rning just up the path to the max size. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- tools/list-local-devices.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/list-local-devices.c b/tools/list-local-devices.c index 6aa7600..2afb1a3 100644 --- a/tools/l

Re: [Linuxwacom-devel] [PATCH linuxwacom 3/5] Fix length parameter to EVIOCGBIT ioctl

2017-04-17 Thread Peter Hutterer
On Tue, Apr 11, 2017 at 01:20:33PM -0700, Jason Gerecke wrote: > Use of 'sizeof(keys)' is incorrect here since we don't care about the > length of the pointer itself, but rather of the array it points to. > Update function definitions to pass around a length parameter as needed. > >

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add USB Graphire tablet

2017-04-17 Thread Peter Hutterer
On Mon, Apr 17, 2017 at 12:02:51PM -0700, Jason Gerecke wrote: > https://github.com/linuxwacom/wacom-hid-descriptors/issues/3 > > Signed-off-by: Jason Gerecke 3b37fe1..79d049a master -> master thanks! Cheers, Peter > --- > data/graphire-usb.tablet | 28

Re: [Linuxwacom-devel] [PATCH input-wacom 3/3] Move tablet definitions of 2nd-gen Intuos Pro

2017-04-02 Thread Peter Hutterer
On Fri, Mar 31, 2017 at 01:27:49PM -0700, Jason Gerecke wrote: > Moves the definition of the 2nd-gen Intuos Pro tablets to occur after the > MobileStudio Pro. Somehow these were misplaced in the 2.6.38 and 3.7 trees > (the 2.6.30 and 2.6.36 trees are already properly ordered). > > Signed-off-by:

Re: [Linuxwacom-devel] [PATCH] xsetwacom: use XkbGetMap instead of XkbGetKeyboard

2017-03-24 Thread Peter Hutterer
On Fri, Mar 24, 2017 at 11:52:22AM -0700, Jason Gerecke wrote: > On Thu, Mar 9, 2017 at 5:53 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > On Thu, Mar 09, 2017 at 07:37:39AM +0100, Sebastian Reuße wrote: > >> Hello Peter, > >> > >> Pet

[Linuxwacom-devel] [PATCH] Fix build with #ifdef DEBUG disabled

2017-03-12 Thread Peter Hutterer
Introduced in de650d6224 Reported-by: Matt Turner <matts...@gmail.com> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86Wacom.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c index 26b4e9c..a511fd2 100644 --- a/src/xf86Wacom

Re: [Linuxwacom-devel] [PATCH] xsetwacom: use XkbGetMap instead of XkbGetKeyboard

2017-03-09 Thread Peter Hutterer
On Thu, Mar 09, 2017 at 07:37:39AM +0100, Sebastian Reuße wrote: > Hello Peter, > > Peter Hutterer <peter.hutte...@who-t.net> writes: > > > On Wed, Mar 08, 2017 at 07:25:53PM +0100, Sebastian Reuße wrote: > >> When running on Wayland or when usin

  1   2   3   4   5   6   7   8   9   10   >