Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-05-23 Thread Jason Gerecke
On Mon, May 21, 2012 at 12:42 PM, Nikolai Kondrashov wrote: > Hi everyone, > > > On 05/19/2012 06:37 PM, Nikolai Kondrashov wrote: >> >> 2. Verify units Wacom uses by asking Wacom engineers and/or measuring it. >> Make kernel driver report it. Make kernel driver report zero-centered >> values. I c

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-05-23 Thread Jason Gerecke
On Sat, May 19, 2012 at 8:37 AM, Nikolai Kondrashov wrote: > Hi Jason, > > Now, this has taken me some time, hasn't it? Sorry for such a huge delay. > > It took me some time, because I wasn't content with my arguments and the way > I was expressing myself and I still am not. So, sorry if I'm hard

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-05-21 Thread Nikolai Kondrashov
Hi everyone, On 05/19/2012 06:37 PM, Nikolai Kondrashov wrote: 2. Verify units Wacom uses by asking Wacom engineers and/or measuring it. Make kernel driver report it. Make kernel driver report zero-centered values. I can make the patches. I've had an opportunity to measure reported tilt values

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-05-19 Thread Nikolai Kondrashov
Hi Jason, Now, this has taken me some time, hasn't it? Sorry for such a huge delay. It took me some time, because I wasn't content with my arguments and the way I was expressing myself and I still am not. So, sorry if I'm hard to understand or I don't provide good enough arguments. On 03/31/2012

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-04-04 Thread Przemo Firszt
Dnia 4 Kwietnia 2012, 10:06 am, Śr, Nikolai Kondrashov napisał(a): [..] Hi Nick, > The thing is, Wacom tablets are not the only ones reporting tilt. The way > they report it is not the most straightforward and is not consistent with > the HID spec. Ok, understand. > At least aiptek driver uses 0-

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-04-04 Thread Nikolai Kondrashov
Hi Przemo, 2012/4/4 Przemo Firszt : >> Do you still object to the FIXME and fixing the kernel driver? > > My thoughts on that "issue": if the device is reporting values in range > 0-127 the kernel driver shouldn't try to "improve" them just because it's > more convinient for the userspace. Changin

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-04-04 Thread Przemo Firszt
Dnia 29 Marca 2012, 8:22 am, Cz, Nikolai Kondrashov napisał(a): > Hi Chris, > > On 03/23/2012 07:20 PM, Nikolai Kondrashov wrote: >> On 03/23/2012 07:00 PM, Chris Bagwell wrote: >>> On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov >>> wrote: + /* Center the reported range on zero */ +

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-30 Thread Jason Gerecke
On Fri, Mar 30, 2012 at 3:11 AM, Nikolai Kondrashov wrote: > Hi Jason, > > On Fri, Mar 30, 2012 at 4:21 AM, Jason Gerecke wrote: >> I've been meaning to get around to reviewing your patch (I'm glad to >> see you taking it on!), but have been pretty busy lately. Sorry for >> the delay... > > No pr

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-30 Thread Nikolai Kondrashov
Hi Jason, On Fri, Mar 30, 2012 at 4:21 AM, Jason Gerecke wrote: > I've been meaning to get around to reviewing your patch (I'm glad to > see you taking it on!), but have been pretty busy lately. Sorry for > the delay... No problem, thanks for reviewing it so extensively! > On Thu, Mar 22, 2012

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-29 Thread Jason Gerecke
I've been meaning to get around to reviewing your patch (I'm glad to see you taking it on!), but have been pretty busy lately. Sorry for the delay... On Thu, Mar 22, 2012 at 12:37 PM, Nikolai Kondrashov wrote: > Use tilt range and, optionally, resolution reported by the kernel for event > devices

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-29 Thread Nikolai Kondrashov
Hi Chris, On Thu, Mar 29, 2012 at 4:49 PM, Chris Bagwell wrote: > I've no objection to the code itself but I would prefer if the FIXME > was reduced to a TODO or left as only a comment on how current kernels > are behaving. > > If you update the kernels great but its not something that *has* to b

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-29 Thread Chris Bagwell
On Thu, Mar 29, 2012 at 2:22 AM, Nikolai Kondrashov wrote: > Hi Chris, > > > On 03/23/2012 07:20 PM, Nikolai Kondrashov wrote: >> >> On 03/23/2012 07:00 PM, Chris Bagwell wrote: >>> >>> On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov >>> wrote: + /* Center the reported range on zero

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-29 Thread Nikolai Kondrashov
Hi Chris, On 03/23/2012 07:20 PM, Nikolai Kondrashov wrote: > On 03/23/2012 07:00 PM, Chris Bagwell wrote: >> On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov wrote: >>> + /* Center the reported range on zero */ >>> + /* FIXME remove once kernel is fixed */ >>> + common->wcmTiltXOff = - (absinf

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-23 Thread Nikolai Kondrashov
On 03/23/2012 07:00 PM, Chris Bagwell wrote: > On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov wrote: >> + /* Center the reported range on zero */ >> + /* FIXME remove once kernel is fixed */ >> + common->wcmTiltXOff = - (absinfo.minimum + absinfo.maxi

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-23 Thread Chris Bagwell
On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov wrote: > Use tilt range and, optionally, resolution reported by the kernel for event > devices. > > Temporarily center the range on zero until kernel is fixed to do this. > > Use resolution, if present, to determine the physical range and clamp/e