Re: [Linuxwacom-devel] [PATCH 4/4] man: document properties

2011-08-16 Thread Jason Gerecke
On Mon, Aug 15, 2011 at 8:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  man/wacom.man |  124 +  1 files changed, 124 insertions(+), 0 deletions(-) diff --git

[Linuxwacom-devel] [PATCH v2 2/9] Move 'set_output' intelligence into helper functions

2011-08-19 Thread Jason Gerecke
Instead of having 'set_output' be responsible for choosing an appropriate helper function, we let the helper functions be autonomous. If they cannot find an appropriate output (or encounter an error), they simply return False to let the caller know that it failed. --- Changes from v1: * Don't

[Linuxwacom-devel] [PATCH v2 1/9] Free RandR resources more-quickly

2011-08-19 Thread Jason Gerecke
We now call XRRFreeScreenResources as soon as practical to allow the now-following logic to return at its leisure. Additionally, we also copy the data from 'crtc_info' locally and free it ASAP. --- Changes from v1: * Free crtc_info tools/xsetwacom.c | 13 + 1 files changed, 9

[Linuxwacom-devel] [PATCH v2 6/9] Add 'set_output_relative' helper for MapToOutput

2011-08-19 Thread Jason Gerecke
At the moment, this helper is only capable of understanding the keyword next. This will cause it to move to the next available output, with the order determined by the underlying list of heads. Its hoped this can be expanded to support other keywords, most notably left and right, which would

[Linuxwacom-devel] [PATCH v2 3/9] Add 'set_output_area' helper function to parse area strings

2011-08-19 Thread Jason Gerecke
This patch adds a function 'set_output_area' which attempts to parse the commandline argument as a tring of the form WIDTHxHEIGHT@X,Y. If it succeeds, the transformation matrix will be set appropriately. --- Changes from v1: * Add man page entry * Document the function man/xsetwacom.man | 18

[Linuxwacom-devel] [PATCH v2 4/9] Suppress most output from 'set_output' helper functions

2011-08-19 Thread Jason Gerecke
Things get confusing when one helper function reports that it couldn't find an output, but the next one doesn't report success. This change moves most of the output from the helper functions into TRACE() calls that can be investigated further if need be, and adds a fallthrough failure message to

[Linuxwacom-devel] [PATCH v2 8/9] Introduce new AspectRatio property

2011-08-19 Thread Jason Gerecke
The AspectRatio property defines the aspect ratio of that portion of the tablet's input Area property which should be considered active. It is defined by two integers which correspond to the width and height of the region. Being a ratio, both simplified (e.g. 4 3) and non- simplified (e.g. 1600

[Linuxwacom-devel] [PATCH v2 9/9] Add ability to match input aspect ratio to the current output ratio

2011-08-19 Thread Jason Gerecke
Adds a boolean match parameter to the MapToOutput command which instructs the utility to (re)set the AspectRatio property appropriately. --- man/xsetwacom.man | 17 --- tools/xsetwacom.c | 152 + 2 files changed, 140 insertions(+), 29

[Linuxwacom-devel] [PATCH v2 0/9]

2011-08-19 Thread Jason Gerecke
Re-submission and expansion of the set of four patches I submitted last week. I could really use some feedback on these -- I've been rebasing, merging, and staring too closely at these for too long to be objective. Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan'

Re: [Linuxwacom-devel] [PATCH v2 1/9] Free RandR resources more-quickly

2011-08-22 Thread Jason Gerecke
, 2011 at 05:23:52PM -0700, Jason Gerecke wrote: We now call XRRFreeScreenResources as soon as practical to allow the now-following logic to return at its leisure. Additionally, we also copy the data from 'crtc_info' locally and free it ASAP. --- Changes from v1:  * Free crtc_info  tools

Re: [Linuxwacom-devel] tablet rotation (was Re: [PATCH 4/4] man: document properties)

2011-08-22 Thread Jason Gerecke
On Sun, Aug 21, 2011 at 4:17 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Aug 16, 2011 at 10:36:17AM -0700, Jason Gerecke wrote: On Mon, Aug 15, 2011 at 8:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  man

Re: [Linuxwacom-devel] [PATCH v2 2/9] Move 'set_output' intelligence into helper functions

2011-08-22 Thread Jason Gerecke
On Sun, Aug 21, 2011 at 11:39 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Aug 19, 2011 at 05:23:53PM -0700, Jason Gerecke wrote: Instead of having 'set_output' be responsible for choosing an appropriate helper function, we let the helper functions be autonomous. If they cannot

Re: [Linuxwacom-devel] [PATCH v2 3/9] Add 'set_output_area' helper function to parse area strings

2011-08-22 Thread Jason Gerecke
On Sun, Aug 21, 2011 at 11:41 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Aug 19, 2011 at 05:23:54PM -0700, Jason Gerecke wrote: This patch adds a function 'set_output_area' which attempts to parse the commandline argument as a tring of the form WIDTHxHEIGHT@X,Y. If it succeeds

Re: [Linuxwacom-devel] [PATCH v2 6/9] Add 'set_output_relative' helper for MapToOutput

2011-08-22 Thread Jason Gerecke
On Mon, Aug 22, 2011 at 12:04 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Aug 19, 2011 at 05:23:57PM -0700, Jason Gerecke wrote: At the moment, this helper is only capable of understanding the keyword next. This will cause it to move to the next available output, with the order

Re: [Linuxwacom-devel] [PATCH] No need to check for pInfo != NULL in PreInit

2011-08-24 Thread Jason Gerecke
@@ -575,7 +575,7 @@ SetupProc_fail:        if (common priv)                common-wcmDevices = priv-next; -       if (pInfo pInfo-fd != -1) +       if (pInfo-fd != -1)        {                close(pInfo-fd);                pInfo-fd = -1; -- 1.7.6 Acked-by: Jason Gerecke killert

Re: [Linuxwacom-devel] [PATCH] Don't compare unsigned values to 0

2011-08-24 Thread Jason Gerecke
) || (values[0] 100)) +               if (values[0] 100)                        return BadValue;                if ((values[1] 1) || (values[1] MAX_SAMPLES)) -- 1.7.6 Acked-by: Jason Gerecke killert...@gmail.com Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it

[Linuxwacom-devel] [PATCH v3 0/7] MapToOutput modifications

2011-09-07 Thread Jason Gerecke
Round three of my modifications to xsetwacom's MapToOutput command. The major change is that helper functions are no longer intelligent, requiring the 'set_output' function to figure out what to do based on the command-line arguments. There are also a lot of small changes in the patches, both

[Linuxwacom-devel] [PATCH v3 2/7] Have 'set_output' check and convert arguments as necessary

2011-09-07 Thread Jason Gerecke
function to improve readability. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2: * Helper functions no longer intelligent like earlier patches tried to make them * Helper functions now take explicit arguments instead of the remaining commandline string * Break

[Linuxwacom-devel] [PATCH v3 7/7] Add ability to match input aspect ratio to the current output ratio

2011-09-07 Thread Jason Gerecke
Adds an optional KeepShape paramater to the MapToOutput command. If provided, the AspectRatio property is updated to match the aspect ratio of the new output. If not provided, the AspectRatio property is reset to allow full use of the tablet's area. Signed-off-by: Jason Gerecke killert

[Linuxwacom-devel] [PATCH v3 5/7] Have 'MapToOutput' require the keyword desktop to do such

2011-09-07 Thread Jason Gerecke
Instead of allowing zero arguments to map the tablet to the entire desktop, we require the use of the keyword desktop to accomplish this. This is to make it easier to figure out the user's intent later on when we introduce KeepShape. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes

[Linuxwacom-devel] [PATCH v3 6/7] Introduce new AspectRatio property

2011-09-07 Thread Jason Gerecke
, a single monitor, or arbitrary portion of the screen the tablet has been mapped to), it should be possible to draw a circle onscreen by drawing a circle on the tablet. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2: * Corresponds to patch v2 8/9 include/wacom-properties.h

Re: [Linuxwacom-devel] [PATCH v3 2/7] Have 'set_output' check and convert arguments as necessary

2011-09-08 Thread Jason Gerecke
On Thu, Sep 8, 2011 at 6:06 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Sep 08, 2011 at 03:42:40PM -0700, Jason Gerecke wrote: On Wed, Sep 7, 2011 at 8:35 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Sep 07, 2011 at 04:36:51PM -0700, Jason Gerecke wrote

[Linuxwacom-devel] [PATCH v4 0/8] MapToOutput modifications

2011-09-20 Thread Jason Gerecke
Fourth round of modifications to xsetwacom's MapToOutput command. This patch set no longer adds an AspectRatio property to the driver, instead relying on xsetwacom to do-the-right-thing with the Area property. This has the potential to break user scripts, but the probability of it actually having

[Linuxwacom-devel] [PATCH v4 1/8] Create wacom-util.h for generally handy defines

2011-09-20 Thread Jason Gerecke
The new wacom-util.h should be the place to store defines which may be handy to use anywhere. At the moment this includes things like ARRAY_SIZE, bit manipulation, and mask manipulation defines. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v3: * Not present in v3 include

[Linuxwacom-devel] [PATCH v4 2/8] Free RandR resources more-quickly

2011-09-20 Thread Jason Gerecke
We now call XRRFreeScreenResources as soon as practical to allow the now-following logic to return at its leisure. Additionally, we also copy the data from 'crtc_info' locally and free it ASAP. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v3: * Corresponds to patch v3 1/7

[Linuxwacom-devel] [PATCH v4 6/8] Have 'MapToOutput' require the keyword desktop to do such

2011-09-20 Thread Jason Gerecke
Instead of allowing zero arguments to map the tablet to the entire desktop, we require the use of the keyword desktop to accomplish this. This is to make it easier to figure out the user's intent later on when we introduce KeepShape. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes

[Linuxwacom-devel] [PATCH v4 3/8] Have 'set_output' check and convert arguments as necessary

2011-09-20 Thread Jason Gerecke
function to improve readability. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v3: * Corresponds to patch v3 2/7 * 'tmp_int' renamed to have more semantic meaning * Braces removed where unnecessary tools/xsetwacom.c | 78

[Linuxwacom-devel] [PATCH v4 5/8] Add 'set_output_next' helper for MapToOutput

2011-09-20 Thread Jason Gerecke
-by: Jason Gerecke killert...@gmail.com --- Changes from v3: * Corresponds to patch v3 4/7 * Updated commit message * Changed from if/else-if to switch statement * Exit loop as soon as matrix is determined invalid man/xsetwacom.man |8 ++- tools/xsetwacom.c | 137

Re: [Linuxwacom-devel] [PATCH v4 0/8] MapToOutput modifications

2011-09-26 Thread Jason Gerecke
On Mon, Sep 26, 2011 at 5:07 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Sep 26, 2011 at 09:29:13AM -0700, Jason Gerecke wrote: On Tue, Sep 20, 2011 at 3:54 PM, Jason Gerecke killert...@gmail.com wrote: Fourth round of modifications to xsetwacom's MapToOutput command

Re: [Linuxwacom-devel] [PATCH v4 0/8] MapToOutput modifications

2011-09-27 Thread Jason Gerecke
On Mon, Sep 26, 2011 at 5:18 PM, Jason Gerecke killert...@gmail.com wrote: On Mon, Sep 26, 2011 at 5:07 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Sep 26, 2011 at 09:29:13AM -0700, Jason Gerecke wrote: On Tue, Sep 20, 2011 at 3:54 PM, Jason Gerecke killert...@gmail.com wrote

[Linuxwacom-devel] RFC: [PATCH 0/4] Framework changes for KeepShape

2011-09-27 Thread Jason Gerecke
Getting KeepShape to work requires yet more calls to XGetDeviceProperty and XChangeDeviceProperty. There are already places in xsetwacom that have nearly-identical blocks of code just to read a property from the server. Rather than simply doing a copy/paste job, I've decided to farm out the calls

[Linuxwacom-devel] RFC: [PATCH 1/4] Extend parameters in preparation of '_get' and '_set' patches

2011-09-27 Thread Jason Gerecke
advantage of them in the meantime. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 64 +--- 1 files changed, 45 insertions(+), 19 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 7670d4d..7202b23 100644

[Linuxwacom-devel] RFC: [PATCH 2/4] Add '_get' function to handle retrieval of property data

2011-09-27 Thread Jason Gerecke
. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 217 - 1 files changed, 147 insertions(+), 70 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 7202b23..392b063 100644 --- a/tools/xsetwacom.c +++ b

[Linuxwacom-devel] RFC: [PATCH 3/4] Add '_set' function to handle setting of property data

2011-09-27 Thread Jason Gerecke
Replaces near-identical calls to XChangeDeviceProperty with a single centralized function to do the same thing. The new '_set' function uses '_get_parameter' to ensure arguments are of the expected type before doing its job. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c

[Linuxwacom-devel] RFC: [PATCH 4/4] Add ability to match input aspect ratio to the current output ratio

2011-09-27 Thread Jason Gerecke
that rely on the Area property for device calibration. It is not expected that this will result in actual problems since calibration utilities do not currently handle multi-head setups properly anyway. Signed-off-by: Jason Gerecke killert...@gmail.com --- man/xsetwacom.man | 21 + tools

Re: [Linuxwacom-devel] The future of xsetwacom the need for a client library

2011-09-29 Thread Jason Gerecke
On Wed, Sep 28, 2011 at 10:52 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This is a heads-up, a brain storming and ideas collection all at the same time. xsetwacom is the previously small utility to tweak random driver functions. This is what this tool should remain as. I'm happy to

Re: [Linuxwacom-devel] The future of xsetwacom the need for a client library

2011-09-30 Thread Jason Gerecke
On Thu, Sep 29, 2011 at 5:18 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Sep 29, 2011 at 04:38:54PM -0700, Jason Gerecke wrote: On Wed, Sep 28, 2011 at 10:52 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This is a heads-up, a brain storming and ideas collection all

[Linuxwacom-devel] Cintiq 24HD

2011-10-04 Thread Jason Gerecke
I'm working on adding support for the recently-announced Cintiq 24HD. It's pretty straightforward, but there are two interesting bits that I'd like some guidance on. Firstly, the 24HD has three hardware control buttons along the top edge which are physically implemented as a touch strip. While it

Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-05 Thread Jason Gerecke
On Tue, Oct 4, 2011 at 7:22 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Oct 4, 2011 at 8:00 PM, Jason Gerecke killert...@gmail.com wrote: I'm working on adding support for the recently-announced Cintiq 24HD. It's pretty straightforward, but there are two interesting bits that I'd

Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-05 Thread Jason Gerecke
On Wed, Oct 5, 2011 at 1:22 AM, Alexia Death alexiade...@gmail.com wrote: On Wed, Oct 5, 2011 at 4:00 AM, Jason Gerecke killert...@gmail.com wrote: For the X driver, we run into a backwards-compatibility problem (...unless we go the lame route with ABS_WHEEL). While XI2 provides up to 36

Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-05 Thread Jason Gerecke
On Wed, Oct 5, 2011 at 12:09 PM, Jason Gerecke killert...@gmail.com wrote: On Wed, Oct 5, 2011 at 1:22 AM, Alexia Death alexiade...@gmail.com wrote: On Wed, Oct 5, 2011 at 4:00 AM, Jason Gerecke killert...@gmail.com wrote: For the X driver, we run into a backwards-compatibility problem

Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-07 Thread Jason Gerecke
On Wed, Oct 5, 2011 at 12:52 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Oct 5, 2011 at 1:17 PM, Jason Gerecke killert...@gmail.com wrote: On Tue, Oct 4, 2011 at 7:22 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Oct 4, 2011 at 8:00 PM, Jason Gerecke killert...@gmail.com wrote

Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-09 Thread Jason Gerecke
Discussion seems to have died down, so I'd like to propose a design. If there are any comments you'd like to make, be sure to get them in. I hope to start start the coding phase on Monday, and the less backpedaling I have to do, the better :) I plan on exposing the three hardware control buttons

Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-09 Thread Jason Gerecke
On Sun, Oct 9, 2011 at 5:36 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Sun, Oct 9, 2011 at 6:08 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Oct 07, 2011 at 06:34:01PM -0700, Jason Gerecke wrote: On Wed, Oct 5, 2011 at 12:52 PM, Chris Bagwell ch...@cnpbagwell.com wrote

[Linuxwacom-devel] [PATCH 1/3] Only convert I4 tilt bits to rotation for the I4 mouse

2011-10-20 Thread Jason Gerecke
The comment claims that the conversion is to be performed for the I4 mouse only, but doesn't actually check to see if the tool is indeed a mouse. This patch adds in the necessary check, allowing the I4 stylus to properly report tilt data. Signed-off-by: Jason Gerecke killert...@gmail.com --- src

[Linuxwacom-devel] [PATCH 2/3] Correct Cintiq 21UX2 features to advertise touch strips, not rings

2011-10-20 Thread Jason Gerecke
Moves the 0xCC case (21UX2) to be in the proper spot. There are touch strips, not rings on this device. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmValidateDevice.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/wcmValidateDevice.c b/src

[Linuxwacom-devel] [PATCH 3/3] Add 0x10804 to recognized Art Pen device IDs

2011-10-20 Thread Jason Gerecke
nybble *too* high. Until a proper fix is made and tested for the kernel, we need to check for an ID of 0x100804 instead of 0x10804. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wcmCommon.c b/src

[Linuxwacom-devel] [PATCH 1/5] Add basic support for Cintiq 24HD

2011-10-21 Thread Jason Gerecke
Adds the Cintiq 24HD (056a:00f4) to the device lists. The 24HD has two features not found on prior tablets: three capacitive buttons, and a second touch ring. Subsuquent patches will address adding support for them. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmUSB.c

[Linuxwacom-devel] [PATCH 2/5] Treat KEY_PROG1, KEY_PROG2, and KEY_PROG3 as buttons

2011-10-21 Thread Jason Gerecke
-off-by: Jason Gerecke killert...@gmail.com --- src/wcmUSB.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index c92ce41..0a9ce9b 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -156,7 +156,8 @@ static unsigned short padkey_codes

[Linuxwacom-devel] [PATCH 3/5] Add 'abswheel2' to device state for dual-ring devices

2011-10-21 Thread Jason Gerecke
This patch adds an 'abswheel2' field to the _WacomDeviceState structure, along with corresponding 'oldWheel2' field to the _WacomDeviceRec structure. These fields store the state of the second touch ring on dual-ring devices such as the Cintiq 24HD. Signed-off-by: Jason Gerecke killert

[Linuxwacom-devel] [PATCH 4/5] Have the second touch ring emulate wheel events by default

2011-10-21 Thread Jason Gerecke
Touch strips as well as the first touch ring are set up to emulate mouse wheel events by default. This patch duplicates this behavior for the second touch ring, so that it behaves in an identical manner. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 29

[Linuxwacom-devel] [PATCH 5/5] Expose the second touch ring's raw value in a new 7th valuator

2011-10-21 Thread Jason Gerecke
This patch expands the number of valuators reported by devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 11 +++ src/wcmConfig.c |2 +- src

Re: [Linuxwacom-devel] [PATCH 4/5] Have the second touch ring emulate wheel events by default

2011-10-26 Thread Jason Gerecke
On Sun, Oct 23, 2011 at 9:13 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Oct 21, 2011 at 06:37:25PM -0700, Jason Gerecke wrote: Touch strips as well as the first touch ring are set up to emulate mouse wheel events by default. This patch duplicates this behavior for the second

[Linuxwacom-devel] [PATCH v2 5/5] Expose the second touch ring's raw value in a new 7th valuator

2011-10-26 Thread Jason Gerecke
This patch expands the number of valuators reported by pad devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v1: * Number of axes back to 6 by default * 7th axis

[Linuxwacom-devel] xf86-input-wacom 0.11.99.1

2011-10-30 Thread Jason Gerecke
Its been 5 months since 0.11.1, which means we're long overdue for our next release. Shortly I'll be uploading a tarball of 0.11.99.1 which will be our first of two or three RCs. The next few weeks should be focused on testing, fixing bugs, and addressing regressions that have snuck in since the

[Linuxwacom-devel] [PATCH] Migrate Tablet(Has|Set)Feature to use the wacom-util macros

2011-11-09 Thread Jason Gerecke
In addition to consolidating code, this happens to fix a bug in the implementation of TabletHasFeature which would return true provided *any* bit of a multi-bit mask was set. Ever since 7c667678 when WCM_TPC was changed to a multi-bit mask, tablets with WCM_LCD set have been (mis-)treated as

[Linuxwacom-devel] [PATCH 1/2] Revert Only convert I4 tilt bits to rotation for the I4 mouse

2011-11-09 Thread Jason Gerecke
This reverts commit 9be9719d78af035c45ea4b191c21fab0ee54f198. Under the right conditions, the 'tool' pointer can be NULL, leading to the X server crashing. An easy way to trigger the crash is to spam pad events (such as button presses) while holding the stylus on the edge of proximity. Rather

[Linuxwacom-devel] [PATCH 2/2] Only convert I4 tilt bits to rotation for the I4 mouse (v2)

2011-11-09 Thread Jason Gerecke
This re-implements commit 9be9719d78af035c45ea4b191c21fab0ee54f198. Ping pointed out the device_type field that I had somehow missed when making the earlier commit. This provides essentially the same information as the IsCursor() macro that the original patch went through so much trouble to use.

Re: [Linuxwacom-devel] [PATCH 2/2] Only convert I4 tilt bits to rotation for the I4 mouse (v2)

2011-11-09 Thread Jason Gerecke
On Wed, Nov 9, 2011 at 2:12 PM, Jason Gerecke killert...@gmail.com wrote: This re-implements commit 9be9719d78af035c45ea4b191c21fab0ee54f198. Ping pointed out the device_type field that I had somehow missed when making the earlier commit. This provides essentially the same information

Re: [Linuxwacom-devel] Higher Point Calibration

2011-11-12 Thread Jason Gerecke
On Sat, Nov 12, 2011 at 2:37 AM, Cedric Sodhi man...@gmx.net wrote: Hello everybody, are there any intentions or just the possibility to calibrate Wacoms with n-point (n+1-th order) maps? I assume there is a good reason why so far we only have 1st-order/2-point mappings? I think this is a

Re: [Linuxwacom-devel] [PATCH 4/4] Default to touch tool for multi-touch devices

2011-11-14 Thread Jason Gerecke
On Sun, Jun 26, 2011 at 5:44 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, Jun 26, 2011 at 07:40:35PM -0500, Chris Bagwell wrote: On Sun, Jun 26, 2011 at 7:31 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Jun 25, 2011 at 01:05:52PM -0500, ch...@cnpbagwell.com wrote:

Re: [Linuxwacom-devel] [PATCH 4/4] Default to touch tool for multi-touch devices

2011-11-14 Thread Jason Gerecke
On Mon, Nov 14, 2011 at 2:40 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Nov 14, 2011 at 3:48 PM, Jason Gerecke killert...@gmail.com wrote: On Sun, Jun 26, 2011 at 5:44 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, Jun 26, 2011 at 07:40:35PM -0500, Chris Bagwell wrote

Re: [Linuxwacom-devel] [PATCH 4/4] Default to touch tool for multi-touch devices

2011-11-14 Thread Jason Gerecke
On Mon, Nov 14, 2011 at 4:28 PM, Jason Gerecke killert...@gmail.com wrote: On Mon, Nov 14, 2011 at 3:08 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Nov 14, 2011 at 4:40 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Nov 14, 2011 at 3:48 PM, Jason Gerecke killert...@gmail.com

Re: [Linuxwacom-devel] wacom panel integrated in hp tablet 2710p crashes x

2011-11-17 Thread Jason Gerecke
On Wed, Nov 16, 2011 at 1:40 PM, Michael Spreng linuxwa...@m.spreng.ch wrote: Hello I already wrote on the discuss mailing list, to get my tablet working again. Now I got a bit further, The device sows up as /dev/ttyS0, but it crashes the X server: Backtrace: 0: X (xorg_backtrace+0x28)

Re: [Linuxwacom-devel] [PATCH 2/3] default gesture distance values based on hw maximums

2011-11-23 Thread Jason Gerecke
, for all three patches: Reviewed-by: Jason Gerecke killert...@gmail.com Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. On Tue, Nov 22, 2011 at 7:39 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com 2 finger

Re: [Linuxwacom-devel] Gesture HW-based fixes on github

2011-11-28 Thread Jason Gerecke
On Sat, Nov 26, 2011 at 4:45 PM, Chris Bagwell ch...@cnpbagwell.com wrote: The following changes since commit 31dbd9fc9fdd3691d9ef43c707ecc780e0c62d24:  xf86-input-wacom 0.12.0 (2011-11-15 11:21:46 -0800) are available in the git repository at:  git://github.com/cbagwell/xf86-input-wacom.git

Re: [Linuxwacom-devel] wacom panel integrated in hp tablet 2710p crashes x

2011-11-29 Thread Jason Gerecke
xf86SetSerialSpeed, for which I do not have debug symbols yet. Also needs more investigation. Michael On 17.11.2011 18:47, Jason Gerecke wrote: On Wed, Nov 16, 2011 at 1:40 PM, Michael Spreng linuxwa...@m.spreng.ch wrote: Hello I already wrote on the discuss mailing list, to get my tablet

Re: [Linuxwacom-devel] [PATCH 2/3] Input: wacom - remove unneeded ABS_MISC events

2011-12-07 Thread Jason Gerecke
This patch breaks puck buttons on the Graphire 3. Motion gets through fine, but clicking (left, middle, or right) is impossible. Interestingly, scrolling still works. Graphire 4 is unaffected. Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu

Re: [Linuxwacom-devel] [PATCH 3/3] Input: wacom - refactor grapire irq handler

2011-12-07 Thread Jason Gerecke
This patch breaks the Graphire 4. The X driver appears to get confused about what buttons are being pressed. This happens with all tools, from what I can tell. Only the right mouse button appears to work correctly, and can be used to get the driver back in sync with reality until you make another

Re: [Linuxwacom-devel] [PATCH 3/3] Input: wacom - refactor grapire irq handler

2011-12-07 Thread Jason Gerecke
On Wed, Dec 7, 2011 at 12:42 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Dec 7, 2011 at 2:16 PM, Jason Gerecke killert...@gmail.com wrote: This patch breaks the Graphire 4. The X driver appears to get confused about what buttons are being pressed. This happens with all tools, from

Re: [Linuxwacom-devel] [PATCH 2/3] Input: wacom - remove unneeded ABS_MISC events

2011-12-07 Thread Jason Gerecke
, Dec 7, 2011 at 2:14 PM, Jason Gerecke killert...@gmail.com wrote: This patch breaks puck buttons on the Graphire 3. Motion gets through fine, but clicking (left, middle, or right) is impossible. Interestingly, scrolling still works. Graphire 4 is unaffected. I see.  Thank you for testing

[Linuxwacom-devel] [PATCH v3 1/5] Add basic support for Cintiq 24HD

2011-12-13 Thread Jason Gerecke
Adds the Cintiq 24HD (056a:00f4) to the device lists. The 24HD has two features not found on prior tablets: three capacitive buttons, and a second touch ring. Subsuquent patches will address adding support for them. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmUSB.c

[Linuxwacom-devel] [PATCH v3 4/5] Expose the second touch ring's raw value in a new 7th valuator

2011-12-13 Thread Jason Gerecke
This patch expands the number of valuators reported by devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 11 +++ src/xf86Wacom.c | 28

[Linuxwacom-devel] [PATCH v3 5/5] De-duplicate code for wheel/strip scrolling

2011-12-13 Thread Jason Gerecke
to returning a single button/action. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 206 --- 1 files changed, 121 insertions(+), 85 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 0e719cf..170d1d0 100644

[Linuxwacom-devel] [PATCH v3 3/5] Have the second touch ring emulate wheel events by default

2011-12-13 Thread Jason Gerecke
Touch strips as well as the first touch ring are set up to emulate mouse wheel events by default. This patch duplicates this behavior for the second touch ring, so that it behaves in an identical manner. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 29

[Linuxwacom-devel] [PATCH v4 2/5] Add 'abswheel2' to device state for dual-ring devices

2011-12-13 Thread Jason Gerecke
This patch adds an 'abswheel2' field to the _WacomDeviceState structure, along with corresponding 'oldWheel2' field to the _WacomDeviceRec structure. These fields store the state of the second touch ring on dual-ring devices such as the Cintiq 24HD. Signed-off-by: Jason Gerecke killert

Re: [Linuxwacom-devel] [PATCH 2/3] test: add more #defines to fix build issues.

2011-12-19 Thread Jason Gerecke
-by: Jason Gerecke killert...@gmail.com Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. -- Learn Windows Azure Live! Tuesday, Dec 13, 2011 Microsoft is holding

Re: [Linuxwacom-devel] [PATCH v3 5/5] De-duplicate code for wheel/strip scrolling

2011-12-19 Thread Jason Gerecke
On Sun, Dec 18, 2011 at 10:06 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Dec 13, 2011 at 01:59:02PM -0800, Jason Gerecke wrote: Replaces sendWheelStripEvents and getWheelButton with several small functions to reduce unnecessary code duplication. As a side-effect, it is now

[Linuxwacom-devel] [PATCH v5 2/5] Add basic support for Cintiq 24HD

2011-12-21 Thread Jason Gerecke
Adds the Cintiq 24HD (056a:00f4) to the device lists. The 24HD has two features not found on prior tablets: three capacitive buttons, and a second touch ring. Subsuquent patches will address adding support for them. Signed-off-by: Jason Gerecke killert...@gmail.com Reviewed-by: Chris Bagwell ch

[Linuxwacom-devel] [PATCH v5 4/5] Have the second touch ring emulate wheel events by default

2011-12-21 Thread Jason Gerecke
Touch strips as well as the first touch ring are set up to emulate mouse wheel events by default. This patch duplicates this behavior for the second touch ring, so that it behaves in an identical manner. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v3: * Move after de

[Linuxwacom-devel] [PATCH v5 1/5] De-duplicate code for wheel/strip scrolling

2011-12-21 Thread Jason Gerecke
to returning a single button/action. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v3: * Move to head of patchset * Add tests for getScrollDelta and getWheelButton * Fix bugs in getScrollDelta doc (wrap is max, not max+1) * Fix bugs in getScrollDelta implementation * log2(0

[Linuxwacom-devel] [PATCH v5 5/5] Expose the second touch ring's raw value in a new 7th valuator

2011-12-21 Thread Jason Gerecke
This patch expands the number of valuators reported by devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke killert...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Chris

[Linuxwacom-devel] [PATCH v5 3/5] Add 'abswheel2' to device state for dual-ring devices

2011-12-21 Thread Jason Gerecke
This patch adds an 'abswheel2' field to the _WacomDeviceState structure, along with corresponding 'oldWheel2' field to the _WacomDeviceRec structure. These fields store the state of the second touch ring on dual-ring devices such as the Cintiq 24HD. Signed-off-by: Jason Gerecke killert

Re: [Linuxwacom-devel] [PATCH v5 1/5] De-duplicate code for wheel/strip scrolling

2011-12-29 Thread Jason Gerecke
On Wed, Dec 21, 2011 at 9:27 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Dec 21, 2011 at 03:28:54PM -0800, Jason Gerecke wrote: Replaces sendWheelStripEvents and getWheelButton with several small functions to reduce unnecessary code duplication. As a side-effect, it is now

[Linuxwacom-devel] Getting Ready for 0.13

2011-12-29 Thread Jason Gerecke
Its been six weeks since 0.12 was released, so I'd like to start looking at getting 0.13 out of the door. There are a few patches in need of review, and a couple bug reports that need further action. I'll be making the RC1 release on Saturday, so now's the time to submit/review/nominate anything

Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Jason Gerecke
I've been meaning to get around to fixing up and submitting the Solaris patches that were submitted a while back (they work fine, but are in need of some editing)... Higher priority projects keep appearing on my plate before I can do much with it, but I'd still like to keep the GNU-isms to a

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-20 Thread Jason Gerecke
Ping's out for a little while, so I'll be taking over the patch. I've got other stuff on my plate though, so it may take some time to fold in the changes. On Thu, Jan 19, 2012 at 8:13 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Thank you, I CC'd Eduard here to, he may have some comments

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-23 Thread Jason Gerecke
On Sun, Jan 22, 2012 at 8:43 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Jan 20, 2012 at 10:56:23AM -0800, Jason Gerecke wrote: Ping's out for a little while, so I'll be taking over the patch. I've got other stuff on my plate though, so it may take some time to fold

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-23 Thread Jason Gerecke
On Sun, Jan 22, 2012 at 8:49 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Jan 20, 2012 at 10:55:59AM -0800, Jason Gerecke wrote: On Thu, Jan 19, 2012 at 8:12 PM, Peter Hutterer peter.hutte...@who-t.net wrote: CC-ing Eduard, since he's been working on this as well On Wed, Jan

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-23 Thread Jason Gerecke
On Mon, Jan 23, 2012 at 3:36 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Jan 23, 2012 at 10:30:34AM -0800, Jason Gerecke wrote: On Sun, Jan 22, 2012 at 8:49 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Jan 20, 2012 at 10:55:59AM -0800, Jason Gerecke wrote

[Linuxwacom-devel] [PATCH v3] Enable LED status change through xsetwacom

2012-01-25 Thread Jason Gerecke
Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2: Deduplicate storing in sysfs Deduplicate fd closing Deduplicate LED setting by looping through all groups Change wording of xsetwacom property description Consolidate led{0,1}_status variables

Re: [Linuxwacom-devel] [PATCH v3] Enable LED status change through xsetwacom

2012-01-25 Thread Jason Gerecke
:54 PM, Jason Gerecke killert...@gmail.com wrote: Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2:    Deduplicate storing in sysfs    Deduplicate fd closing    Deduplicate LED setting by looping through all groups    Change wording of xsetwacom property description

[Linuxwacom-devel] [PATCH 3/4] Introduce Puck type and IDs

2012-01-30 Thread Jason Gerecke
Since I have them handy, it only makes sense to add them as well. Signed-off-by: Jason Gerecke killert...@gmail.com --- data/intuos-12x12.tablet |2 +- data/intuos-12x18.tablet |2 +- data/intuos-4x5.tablet |2 +- data/intuos-6x8.tablet |2 +- data/intuos-9x12

[Linuxwacom-devel] [PATCH 4/4] data: Add additional metadata that isn't yet representable

2012-01-30 Thread Jason Gerecke
Adds in additional metadata that doesn't currently have a way of being formally expressed. All hail ASCII art. Signed-off-by: Jason Gerecke killert...@gmail.com --- data/cintiq-12wx.tablet| 32 data/cintiq-20wsx.tablet | 36

Re: [Linuxwacom-devel] [PATCH 1/4] Update stylus definitions

2012-01-31 Thread Jason Gerecke
On Tue, Jan 31, 2012 at 7:14 AM, Bastien Nocera had...@hadess.net wrote: Jason Gerecke killertofu@... writes: Information compiled from public information cross-referenced with internal Wacom documents. Awesome! Do you have stylus definitions for the Graphire and other consumer products

Re: [Linuxwacom-devel] [PATCH 4/4] data: Add additional metadata that isn't yet representable

2012-01-31 Thread Jason Gerecke
On Tue, Jan 31, 2012 at 7:16 AM, Bastien Nocera had...@hadess.net wrote: Jason Gerecke killertofu@... writes: Adds in additional metadata that doesn't currently have a way of being formally expressed. All hail ASCII art. Very interesting data, I can't imagine how long it took you to do

Re: [Linuxwacom-devel] [PATCH 4/4] data: Add additional metadata that isn't yet representable

2012-02-02 Thread Jason Gerecke
On Thu, Feb 2, 2012 at 7:56 AM, Bastien Nocera had...@hadess.net wrote: Jason Gerecke killertofu@... writes: Thankfully, not too terribly long. I've got representatives of most of the tablets handy, though some with different button layouts (e.g. Intuos4 Small) were guesses. I've updated 2

Re: [Linuxwacom-devel] libwacom

2012-02-02 Thread Jason Gerecke
On Thu, Feb 2, 2012 at 12:09 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Feb 2, 2012 at 12:31 PM, Bastien Nocera had...@hadess.net wrote: On Thu, 2012-02-02 at 11:55 -0600, Favux ... wrote: Hi Bastien, Thanks for reviewing the wiki page. On Thu, Feb 2, 2012 at 10:31 AM, Bastien

[Linuxwacom-devel] [PATCH] Remove redundant redeclaration of 'wcmInitialScreens'

2012-02-09 Thread Jason Gerecke
From GCC: In file included from ../src/xf86Wacom.c:46:0: ../src/xf86Wacom.h:147:13: warning: redundant redeclaration of 'wcmInitialScreens' [-Wredundant-decls] ../src/xf86Wacom.h:146:13: note: previous declaration of 'wcmInitialScreens' was here Signed-off-by: Jason Gerecke killert

[Linuxwacom-devel] [PATCH] Check for appropriate number of properties when setting buttons

2012-02-09 Thread Jason Gerecke
for the proper size. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmXCommand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c index d0963f1..0fd5664 100644 --- a/src/wcmXCommand.c +++ b/src/wcmXCommand.c @@ -849,7 +849,8

<    1   2   3   4   5   6   7   8   9   10   >