Re: [Lldb-commits] [PATCH] D11751: [lldb-mi] Simplify MICmnMIOutOfBandRecord implementation.

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. I'd prefer to declare all static functions as private static methods. Comment at: tools/lldb-mi/MICmnMIOutOfBandRecord.cpp:16 @@ +15,3 @@ +static const char * +Map

Re: [Lldb-commits] [PATCH] D11746: [lldb-mi] Use empty arg lists instead of (void).

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11746 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] r243621 - Clean up test/tools/lldb-mi/variable/main.cpp after r243619

Author: ki.stfu Date: Thu Jul 30 00:39:31 2015 New Revision: 243621 URL: http://llvm.org/viewvc/llvm-project?rev=243621&view=rev Log: Clean up test/tools/lldb-mi/variable/main.cpp after r243619 Modified: lldb/trunk/test/tools/lldb-mi/variable/main.cpp Modified: lldb/trunk/test/tools/lldb-mi/

[Lldb-commits] [lldb] r243619 - Fix bug in expression display when determining if a pointer should be treated as a string

Author: ki.stfu Date: Thu Jul 30 00:32:41 2015 New Revision: 243619 URL: http://llvm.org/viewvc/llvm-project?rev=243619&view=rev Log: Fix bug in expression display when determining if a pointer should be treated as a string Summary: Currently if the "first child" of the pointer is a char type th

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

ki.stfu requested changes to this revision. This revision now requires changes to proceed. Comment at: test/tools/lldb-mi/TestMiLibraryLoaded.py:31 @@ +30,3 @@ + "=library-loaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\",symbols-loaded=\"1\",symbols-path=\"%s\"

Re: [Lldb-commits] [PATCH] D9716: Add 'size' field to module load event.

ki.stfu added inline comments. Comment at: test/tools/lldb-mi/TestMiLibraryLoaded.py:32 @@ -33,1 +31,3 @@ + "=library-loaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\",symbols-loaded=\"0\",loaded_addr=\"-\",size=\"[0-9]+\"" % (path, path, path) +])

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

ki.stfu added a comment. BTW, update MIExtensions.txt file please. http://reviews.llvm.org/D11574 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Why have you opened a new CL? Anyway, close/abandon the http://reviews.llvm.org/D9716 and see my inline comments. Comment at: test/tools/lldb-mi/TestMiLibraryLoad

Re: [Lldb-commits] [PATCH] D11570: Escape variable creation error messages.

ki.stfu requested changes to this revision. This revision now requires changes to proceed. Comment at: tools/lldb-mi/MICmdCmdVar.cpp:258 @@ -257,3 +257,3 @@ strErrMsg = CMIUtilString::Format(MIRSRC(IDS_CMD_ERR_VARIABLE_CREATION_FAILED), m_strExpression.c_str()); -co

Re: [Lldb-commits] [PATCH] D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

ki.stfu added inline comments. Comment at: test/tools/lldb-mi/syntax/TestMiSyntax.py:108 @@ +107,3 @@ +command = "^\r\n" # 5 (it looks like empty line for pexpect) +error = "^.+?\n"# 6 +import pexpect

Re: [Lldb-commits] [PATCH] D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

ki.stfu added a comment. I plan to commit it this week. Does anyone has any objections? http://reviews.llvm.org/D9740 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

ki.stfu updated this revision to Diff 30784. ki.stfu added a comment. Rebase against ToT http://reviews.llvm.org/D9740 Files: test/tools/lldb-mi/syntax/TestMiSyntax.py tools/lldb-mi/MIDriver.cpp Index: tools/lldb-mi/MIDriver.cpp =

Re: [Lldb-commits] [PATCH] D11371: Support escapes and quotes in string and character values.

This revision was automatically updated to reflect the committed changes. Closed by commit rL243383: Support escapes and quotes in string and character values. (authored by ki.stfu). Changed prior to commit: http://reviews.llvm.org/D11371?vs=30782&id=30783#toc Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r243383 - Support escapes and quotes in string and character values.

Author: ki.stfu Date: Tue Jul 28 00:43:47 2015 New Revision: 243383 URL: http://llvm.org/viewvc/llvm-project?rev=243383&view=rev Log: Support escapes and quotes in string and character values. Summary: Escape characters in strings and strings containing quotes were not appearing correctly in exp

Re: [Lldb-commits] [PATCH] D11371: Support escapes and quotes in string and character values.

ki.stfu updated this revision to Diff 30782. ki.stfu added a comment. Rebase against ToT http://reviews.llvm.org/D11371 Files: test/tools/lldb-mi/variable/TestMiGdbSetShowPrint.py test/tools/lldb-mi/variable/main.cpp tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp tools/lldb-mi/MICmnL

Re: [Lldb-commits] [PATCH] D11488: Fix bug in expression display when determining if a pointer should be treated as a string

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. Add a section title and go ahead. Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.h:61 @@ -59,2 +60,3 @@ bool GetCompositeValue(const bool vbPrintFieldNames, CMICmnMIVal

Re: [Lldb-commits] [PATCH] D11488: Fix bug in expression display when determining if a pointer should be treated as a string

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. See my inline comments. Comment at: test/tools/lldb-mi/variable/main.cpp:70-76 @@ -69,1 +69,9 @@ +struct not_str +{ +char c; +int f; +not_str(char _c

Re: [Lldb-commits] [PATCH] D11499: [lldb-mi] Fix setting of breakpoints using file:func syntax.

ki.stfu requested changes to this revision. This revision now requires changes to proceed. Comment at: test/tools/lldb-mi/breakpoint/TestMiBreak.py:91 @@ +90,3 @@ +self.expect("\*stopped,reason=\"breakpoint-hit\".*bkptno=\"5\"") +#self.expect("\*stopped,reason=\"br

Re: [Lldb-commits] [PATCH] D11396: [lldb-mi] Fix breakpoints on functions when C++ namespaces are used.

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. Add a link to the bug please and go ahead. Comment at: test/tools/lldb-mi/breakpoint/TestMiBreak.py:79 @@ +78,3 @@ +# Test that we can set a BP using the global name

Re: [Lldb-commits] [PATCH] D11488: Fix bug in expression display when determining if a pointer should be treated as a string

ki.stfu added a comment. It looks strangely for me. If structure has the first element of type char then GetChildAtIndex(0) will refer to this element and GetType().GetBasicType() will be char. But if we have a pointer to that structure then I suppose GetChildAtIndex(0) will not be equal to the

Re: [Lldb-commits] [PATCH] D11488: Fix bug in expression display when determining if a pointer should be treated as a string

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Add add a test case for this please. http://reviews.llvm.org/D11488 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://li

Re: [Lldb-commits] [PATCH] D11371: Support escapes and quotes in string and character values.

ki.stfu added a comment. In http://reviews.llvm.org/D11371#210778, @paulmaybee wrote: > Can someone please check this in for me. Thanks. Sure, I can do it tomorrow. http://reviews.llvm.org/D11371 ___ lldb-commits mailing list lldb-commits@cs.uiu

Re: [Lldb-commits] [PATCH] D11371: Support escapes and quotes in string and character values.

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. Please remove "###" and go ahead. Comment at: test/tools/lldb-mi/variable/TestMiGdbSetShowPrint.py:70 @@ -69,2 +69,3 @@ -# Test that an char* is expanded to string

Re: [Lldb-commits] [PATCH] D11396: [lldb-mi] Fix breakpoints on functions when C++ namespaces are used.

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D11396#209959, @dawn wrote: > In http://reviews.llvm.org/D11396#209412, @brucem wrote: > > > Could you please add a test for the file: + ::func case? > >

Re: [Lldb-commits] [PATCH] D11371: Support escapes and quotes in string and character values.

ki.stfu added inline comments. Comment at: test/tools/lldb-mi/variable/main.cpp:63-65 @@ -63,3 +63,4 @@ const char16_t u16a[] = u"hello"; const char32_t *u32p = U"hello"; const char32_t u32a[] = U"hello"; + paulmaybee wrote: > ki.stfu wrote: > >

Re: [Lldb-commits] [PATCH] D11049: [lldb-mi] size_t rather than MIuint for arg counts.

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D11049#201815, @brucem wrote: > I don't think other code within LLDB really uses const scalar parameters and > they don't provide much protection against anything.

Re: [Lldb-commits] [PATCH] D11049: [lldb-mi] size_t rather than MIuint for arg counts.

ki.stfu added inline comments. Comment at: tools/lldb-mi/MICmdArgContext.cpp:146 @@ -145,3 +145,3 @@ // Args:vArg- (R) The name of the argument. -// nArgIndex - (R) The word count position to which to remove the vArg word. +// nArgIndex - The wo

Re: [Lldb-commits] [PATCH] D11049: [lldb-mi] size_t rather than MIuint for arg counts.

ki.stfu added a comment. Looks good apart a removed `const`. (the same question in http://reviews.llvm.org/D11052). http://reviews.llvm.org/D11049 ___ lldb-commits mailing list lldb-commits@cs.uiuc.ed

Re: [Lldb-commits] [PATCH] D11052: [lldb-mi] Simplify MICmnMIResultRecord implementation.

ki.stfu requested changes to this revision. This revision now requires changes to proceed. Comment at: tools/lldb-mi/MICmnMIResultRecord.cpp:14-20 @@ -13,9 +13,9 @@ -// Instantiations: -CMICmnMIResultRecord::MapResultClassToResultClassText_t ms_MapResultClassToResultClassText =

Re: [Lldb-commits] [PATCH] D11049: [lldb-mi] size_t rather than MIuint for arg counts.

ki.stfu requested changes to this revision. This revision now requires changes to proceed. Comment at: tools/lldb-mi/MICmdArgContext.cpp:152 @@ -151,3 +151,3 @@ bool -CMICmdArgContext::RemoveArgAtPos(const CMIUtilString &vArg, const MIuint nArgIndex) +CMICmdArgContext::RemoveArg

Re: [Lldb-commits] [PATCH] D10943: Use string::find(char) for single character strings.

ki.stfu accepted this revision. This revision is now accepted and ready to land. Lgtm http://reviews.llvm.org/D10943 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

lldb-commits@cs.uiuc.edu

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm Comment at: tools/lldb-mi/MIUtilString.cpp:489-491 @@ -488,6 +488,5 @@ -MIchar *pPtr = const_cast(&vrText); -for (MIuint i = 0; i < len; i++, pPtr++) +for

lldb-commits@cs.uiuc.edu

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Looks good apart from one renaming. Comment at: tools/lldb-mi/MIUtilString.cpp:478 @@ -477,3 +477,3 @@ // Type:Static method. // Args:vrText - (R) The t

Re: [Lldb-commits] [PATCH] D10912: Typo fixes.

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. Lgtm http://reviews.llvm.org/D10912 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-comm

[Lldb-commits] [PATCH] Expand result with type char* to string in -data-evaluate-expression

Hi abidh, Expand result with type char* to string in -data-evaluate-expression. All tests pass on Linux. http://reviews.llvm.org/D10728 Files: test/tools/lldb-mi/data/TestMiData.py test/tools/lldb-mi/variable/TestMiVar.py tools/lldb-mi/MICmdCmdData.cpp Index: test/tools/lldb-mi/data/Test

Re: [Lldb-commits] [PATCH] Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2

REPOSITORY rL LLVM http://reviews.llvm.org/D10487 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2

I created a new patch for that: http://reviews.llvm.org/D10728. REPOSITORY rL LLVM http://reviews.llvm.org/D10487 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2

REPOSITORY rL LLVM http://reviews.llvm.org/D10487 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r240631 - Expand result with type char* to string in -data-evaluate-expression

Author: ki.stfu Date: Thu Jun 25 06:10:12 2015 New Revision: 240631 URL: http://llvm.org/viewvc/llvm-project?rev=240631&view=rev Log: Expand result with type char* to string in -data-evaluate-expression Summary: Expand result with type char* to string in -data-evaluate-expression. was: ```

Re: [Lldb-commits] [PATCH] Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

Friendly ping. http://reviews.llvm.org/D9740 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Adding some more flakey tests to the XFAIL list

Committed in r240327. http://reviews.llvm.org/D10583 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Enhance lldb-mi arguments test (MI)

lgtm, but probably you should check their real values: self.expect("arg1"); self.expect("2nd arg"); ... REPOSITORY rL LLVM http://reviews.llvm.org/D10523 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb

Re: [Lldb-commits] [PATCH] Fix bug 23326.

@abidh, AFAIK, an another patch has been submitted: http://reviews.llvm.org/D10106. Is this patch still necessary? http://reviews.llvm.org/D9827 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] Adding some more flakey tests to the XFAIL list

Where are snapshots of these builds? Can I get the log? http://reviews.llvm.org/D10583 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailm

Re: [Lldb-commits] [PATCH] Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2

I'm at conference until Monday and will take a look at it later. REPOSITORY rL LLVM http://reviews.llvm.org/D10487 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r237781 - Fix handling of hijacked events in synchronous mode

Author: ki.stfu Date: Wed May 20 05:15:47 2015 New Revision: 237781 URL: http://llvm.org/viewvc/llvm-project?rev=237781&view=rev Log: Fix handling of hijacked events in synchronous mode Summary: This patch includes the following changes: * Fix Target::Launch to handle hijacked event in synchronou

[Lldb-commits] [lldb] r237676 - Don't print =breakpoint-created if BP info was emitted in the result record (MI)

Author: ki.stfu Date: Tue May 19 04:57:56 2015 New Revision: 237676 URL: http://llvm.org/viewvc/llvm-project?rev=237676&view=rev Log: Don't print =breakpoint-created if BP info was emitted in the result record (MI) Modified: lldb/trunk/test/tools/lldb-mi/breakpoint/TestMiBreak.py lldb/tr

Re: [Lldb-commits] [lldb] r237571 - Update TestMiVar with a bug id

Thank you for more explicit description. Thanks, Ilia On Mon, May 18, 2015 at 6:35 PM, Pavel Labath wrote: > Author: labath > Date: Mon May 18 10:35:42 2015 > New Revision: 237571 > > URL: http://llvm.org/viewvc/llvm-project?rev=237571&view=rev > Log: > Update TestMiVar with a bug id > > Modifi

Re: [Lldb-commits] [lldb] r237454 - Improve the MiVarTestCase.test_lldbmi_var_list_children test (MI)

gt; wrote: >> >>> Hi Illia, >>> >>> This appears to have broken Linux i386 gcc 4.9.2 >>> >>> >>> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/2419 >>> >>> Is it a quick fix? >>> >>>

[Lldb-commits] [lldb] r237566 - Add --move-to-nearest-code / target.move-to-nearest-code options (attempt 2)

Author: ki.stfu Date: Mon May 18 08:41:01 2015 New Revision: 237566 URL: http://llvm.org/viewvc/llvm-project?rev=237566&view=rev Log: Add --move-to-nearest-code / target.move-to-nearest-code options (attempt 2) This patch initially was committed in r237460 but later it was reverted (r237479) due

Re: [Lldb-commits] [lldb] r237460 - Add --move-to-nearest-code / target.move-to-nearest-code options

buntu-14.04-cmake/builds/2421 >> >> Is it a quick fix? >> >> If not, can you roll back? >> >> Thanks, >> >> Vince >> >> On Fri, May 15, 2015 at 11:16 AM, Ilia K wrote: >> >>> Author: ki.stfu >>> Date: Fri May 15 13

[Lldb-commits] [lldb] r237460 - Add --move-to-nearest-code / target.move-to-nearest-code options

Author: ki.stfu Date: Fri May 15 13:16:15 2015 New Revision: 237460 URL: http://llvm.org/viewvc/llvm-project?rev=237460&view=rev Log: Add --move-to-nearest-code / target.move-to-nearest-code options Summary: This option forces to only set a source line breakpoint when there is an exact-match Th

[Lldb-commits] [lldb] r237454 - Improve the MiVarTestCase.test_lldbmi_var_list_children test (MI)

Author: ki.stfu Date: Fri May 15 11:13:51 2015 New Revision: 237454 URL: http://llvm.org/viewvc/llvm-project?rev=237454&view=rev Log: Improve the MiVarTestCase.test_lldbmi_var_list_children test (MI) Modified: lldb/trunk/test/tools/lldb-mi/variable/TestMiVar.py lldb/trunk/test/tools/lldb-

[Lldb-commits] [lldb] r237443 - Fix CMICmdArgValPrintValues::Validate & enable 4 tests that were XFAIL'ed in r237437 (MI)

Author: ki.stfu Date: Fri May 15 07:33:04 2015 New Revision: 237443 URL: http://llvm.org/viewvc/llvm-project?rev=237443&view=rev Log: Fix CMICmdArgValPrintValues::Validate & enable 4 tests that were XFAIL'ed in r237437 (MI) Modified: lldb/trunk/test/tools/lldb-mi/stack/TestMiStack.py ll

Re: [Lldb-commits] [lldb] r237429 - Fix parsing of print-values arg (MI)

/builds/2414). > Please fix them if it is a trivial or XFAIL them to get the bot green again. > > Thanks > Tamas > > On Fri, May 15, 2015 at 10:46 AM, Ilia K wrote: > >> Author: ki.stfu >> Date: Fri May 15 04:46:28 2015 >> New Revision: 237429 >> >> URL:

[Lldb-commits] [lldb] r237438 - Set specific values for VariableInfoFormat_e enum and remove kNumVariableInfoFormats (MI)

Author: ki.stfu Date: Fri May 15 06:55:09 2015 New Revision: 237438 URL: http://llvm.org/viewvc/llvm-project?rev=237438&view=rev Log: Set specific values for VariableInfoFormat_e enum and remove kNumVariableInfoFormats (MI) Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.h Mod

[Lldb-commits] [lldb] r237437 - XFAIL 4 lldb-mi tests to get Linux build green back (MI)

Author: ki.stfu Date: Fri May 15 06:51:52 2015 New Revision: 237437 URL: http://llvm.org/viewvc/llvm-project?rev=237437&view=rev Log: XFAIL 4 lldb-mi tests to get Linux build green back (MI) Modified: lldb/trunk/test/tools/lldb-mi/stack/TestMiStack.py lldb/trunk/test/tools/lldb-mi/variab

[Lldb-commits] [lldb] r237429 - Fix parsing of print-values arg (MI)

Author: ki.stfu Date: Fri May 15 04:46:28 2015 New Revision: 237429 URL: http://llvm.org/viewvc/llvm-project?rev=237429&view=rev Log: Fix parsing of print-values arg (MI) # Add CMICmdArgValPrintValues argument # Rework -stack-list-arguments/-stack-list-locals/-stack-list-variables/-var-update/-v

[Lldb-commits] [lldb] r237426 - Fix a reason of *stopped notifications due to SIGINT/SIGSTOP signals (MI)

Author: ki.stfu Date: Fri May 15 04:29:09 2015 New Revision: 237426 URL: http://llvm.org/viewvc/llvm-project?rev=237426&view=rev Log: Fix a reason of *stopped notifications due to SIGINT/SIGSTOP signals (MI) # Add SBProcess::GetInterruptedFromEvent # Add vrEvent arg in CMICmnLLDBDebuggerHandleEv

[Lldb-commits] [lldb] r237425 - Fix a few compile warnings

Author: ki.stfu Date: Fri May 15 04:15:27 2015 New Revision: 237425 URL: http://llvm.org/viewvc/llvm-project?rev=237425&view=rev Log: Fix a few compile warnings Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp lldb/trunk/source/Plugins/Pr

Re: [Lldb-commits] [lldb] r237230 - Darwin - fix intermitent crashes in import crashinfo

After your changes the ./dotest.py leaves crashinfo.lock file in test dir. Could you fix it? Thanks, Ilia On Wed, May 13, 2015 at 8:00 AM, Vince Harron wrote: > Author: vharron > Date: Wed May 13 00:00:23 2015 > New Revision: 237230 > > URL: http://llvm.org/viewvc/llvm-project?rev=237230&view=r

[Lldb-commits] [lldb] r237248 - Refactor lldb-mi's prompt

Author: ki.stfu Date: Wed May 13 07:18:20 2015 New Revision: 237248 URL: http://llvm.org/viewvc/llvm-project?rev=237248&view=rev Log: Refactor lldb-mi's prompt Summary: This patch fixes/cleans code around of (gdb) prompt: # Add CMICmnStreamStdout::WritePrompt # Clean up CMICmnStreamStdout::TextTo

[Lldb-commits] [lldb] r237238 - Fix a few compile warnings

Author: ki.stfu Date: Wed May 13 04:04:59 2015 New Revision: 237238 URL: http://llvm.org/viewvc/llvm-project?rev=237238&view=rev Log: Fix a few compile warnings Modified: lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp lldb/trunk/source/Plugins/SymbolFil

[Lldb-commits] [lldb] r237118 - Disable GCC optimizations for builtin functions in lldb tests

Author: ki.stfu Date: Tue May 12 07:13:12 2015 New Revision: 237118 URL: http://llvm.org/viewvc/llvm-project?rev=237118&view=rev Log: Disable GCC optimizations for builtin functions in lldb tests This patch adds new default flag -fno-builtin which forces gcc to not optimize builtin functions. Fo

[Lldb-commits] [lldb] r237105 - Fix MiDataTestCase.test_lldbmi_data_disassemble test on Linux (bug 23489)

Author: ki.stfu Date: Tue May 12 04:24:24 2015 New Revision: 237105 URL: http://llvm.org/viewvc/llvm-project?rev=237105&view=rev Log: Fix MiDataTestCase.test_lldbmi_data_disassemble test on Linux (bug 23489) Modified: lldb/trunk/test/tools/lldb-mi/data/TestMiData.py Modified: lldb/trunk/test

[Lldb-commits] [lldb] r237098 - Skip MiDataTestCase.test_lldbmi_data_disassemble test to get Linux build green

Author: ki.stfu Date: Tue May 12 02:35:06 2015 New Revision: 237098 URL: http://llvm.org/viewvc/llvm-project?rev=237098&view=rev Log: Skip MiDataTestCase.test_lldbmi_data_disassemble test to get Linux build green Modified: lldb/trunk/test/tools/lldb-mi/data/TestMiData.py Modified: lldb/trunk

[Lldb-commits] [lldb] r237096 - Improve MiStartupOptionsTestCase.test_lldbmi_executable_option_file test (MI)

Author: ki.stfu Date: Tue May 12 01:49:49 2015 New Revision: 237096 URL: http://llvm.org/viewvc/llvm-project?rev=237096&view=rev Log: Improve MiStartupOptionsTestCase.test_lldbmi_executable_option_file test (MI) Modified: lldb/trunk/test/tools/lldb-mi/startup_options/TestMiStartupOptions.py

[Lldb-commits] [lldb] r237094 - Show error message from failed evaluation when doing -var-create

Author: ki.stfu Date: Tue May 12 01:15:16 2015 New Revision: 237094 URL: http://llvm.org/viewvc/llvm-project?rev=237094&view=rev Log: Show error message from failed evaluation when doing -var-create Summary: When -var-create fails, we will now show the error message from the failed evaluation if

[Lldb-commits] [lldb] r237092 - Escape strings in disassembly comments.

Author: ki.stfu Date: Tue May 12 00:55:23 2015 New Revision: 237092 URL: http://llvm.org/viewvc/llvm-project?rev=237092&view=rev Log: Escape strings in disassembly comments. Summary: Patch from chu...@microsoft.com Reviewers: abidh, ChuckR Subscribers: paulmaybee, lldb-commits Differential Rev

Re: [Lldb-commits] [lldb] r236963 - Fixed lldb-mi test failures introduced by r236956

Hello, How does it fix lldb-mi tests? Why you move initialization of self.dbg to Base.SetUp? lldb-mi doesn't use these objects: self.dbg/self.ci and etc. Thanks, Ilia On May 11, 2015 1:06 AM, "Vince Harron" wrote: > Author: vharron > Date: Sun May 10 17:01:59 2015 > New Revision: 236963 > > URL

[Lldb-commits] [lldb] r236840 - Improve MiBreakTestCase.test_lldbmi_break_insert_{function*, file_line*} tests (MI)

Author: ki.stfu Date: Fri May 8 07:35:49 2015 New Revision: 236840 URL: http://llvm.org/viewvc/llvm-project?rev=236840&view=rev Log: Improve MiBreakTestCase.test_lldbmi_break_insert_{function*,file_line*} tests (MI) Modified: lldb/trunk/test/tools/lldb-mi/breakpoint/TestMiBreak.py Modifie

[Lldb-commits] [lldb] r236837 - Fix =breakpoint-created event after creation of BP (MI)

Author: ki.stfu Date: Fri May 8 07:18:11 2015 New Revision: 236837 URL: http://llvm.org/viewvc/llvm-project?rev=236837&view=rev Log: Fix =breakpoint-created event after creation of BP (MI) For example: was: ``` $ bin/lldb-mi ~/p/hello [...] -break-insert main ^done,bkpt={number="1",type="breakpo

[Lldb-commits] [lldb] r236834 - Remove duplicated code in CMICmdCmdBreakInsert::Acknowledge (MI)

Author: ki.stfu Date: Fri May 8 07:11:13 2015 New Revision: 236834 URL: http://llvm.org/viewvc/llvm-project?rev=236834&view=rev Log: Remove duplicated code in CMICmdCmdBreakInsert::Acknowledge (MI) Modified: lldb/trunk/tools/lldb-mi/MICmdCmdBreak.cpp Modified: lldb/trunk/tools/lldb-mi/MICm

[Lldb-commits] [lldb] r236832 - Fix -break-insert without -f to cause an error if BP not resolved (MI)

Author: ki.stfu Date: Fri May 8 07:09:56 2015 New Revision: 236832 URL: http://llvm.org/viewvc/llvm-project?rev=236832&view=rev Log: Fix -break-insert without -f to cause an error if BP not resolved (MI) For example: was: ``` $ bin/lldb-mi ~/p/hello [...] -break-insert main ^done,bkpt={number="1

[Lldb-commits] [lldb] r236830 - Fix BP address for local symbols if target not launched (MI)

Author: ki.stfu Date: Fri May 8 07:06:17 2015 New Revision: 236830 URL: http://llvm.org/viewvc/llvm-project?rev=236830&view=rev Log: Fix BP address for local symbols if target not launched (MI) For example: was: ``` $ bin/lldb-mi ~/p/hello [...] -break-insert -f main ^done,bkpt={number="1",type=

[Lldb-commits] [lldb] r236827 - Add support for Unicode strings in CMICmnLLDBUtilSBValue::GetValue (MI)

Author: ki.stfu Date: Fri May 8 06:21:13 2015 New Revision: 236827 URL: http://llvm.org/viewvc/llvm-project?rev=236827&view=rev Log: Add support for Unicode strings in CMICmnLLDBUtilSBValue::GetValue (MI) This patch includes the following changes: # Add CMIUtilString::ConvertToASCII to convert u

[Lldb-commits] [lldb] r236825 - Fix -var-create for undefined variables (MI)

Author: ki.stfu Date: Fri May 8 05:58:45 2015 New Revision: 236825 URL: http://llvm.org/viewvc/llvm-project?rev=236825&view=rev Log: Fix -var-create for undefined variables (MI) Modified: lldb/trunk/test/tools/lldb-mi/variable/TestMiVar.py lldb/trunk/tools/lldb-mi/MICmdCmdVar.cpp Modif

[Lldb-commits] [lldb] r236824 - Print process's output line by line (MI)

Author: ki.stfu Date: Fri May 8 05:52:50 2015 New Revision: 236824 URL: http://llvm.org/viewvc/llvm-project?rev=236824&view=rev Log: Print process's output line by line (MI) For example: was: ``` @"'\r\n` - it's \\ni=1\r\nj=2\r\nx=3\r\ny=4\r\nargc: /Users/IliaK/p/hello\r\nargc: (null)\r\n" ```

[Lldb-commits] [lldb] r236822 - Add MiExitTestCase.test_lldbmi_q that checks reduction of quit (MI)

Author: ki.stfu Date: Fri May 8 05:42:11 2015 New Revision: 236822 URL: http://llvm.org/viewvc/llvm-project?rev=236822&view=rev Log: Add MiExitTestCase.test_lldbmi_q that checks reduction of quit (MI) Modified: lldb/trunk/test/tools/lldb-mi/TestMiExit.py Modified: lldb/trunk/test/tools/lld

[Lldb-commits] [lldb] r236820 - Fix -var-list-children command (MI)

Author: ki.stfu Date: Fri May 8 05:10:14 2015 New Revision: 236820 URL: http://llvm.org/viewvc/llvm-project?rev=236820&view=rev Log: Fix -var-list-children command (MI) This patch incldues the following: # Add from/to arguments in -var-list-children command (MI) ## Handle from and to args ## Don

Re: [Lldb-commits] [PATCH] Don't call the Process::SyncIOHandler in Target::Launch

>RE: Is change this necessary to ensure correctness, or is it just a matter of saving some lines of code? It was done to ensure correctness because Target::Launch consists of ~4 branches of code where it was needed and it was to difficult to maintain. In addition it is needed only for lldb to ensur

[Lldb-commits] [lldb] r236708 - Skip few MiStartupOptionsTestCase tests to get Linux build green

Author: ki.stfu Date: Thu May 7 03:31:12 2015 New Revision: 236708 URL: http://llvm.org/viewvc/llvm-project?rev=236708&view=rev Log: Skip few MiStartupOptionsTestCase tests to get Linux build green Modified: lldb/trunk/test/tools/lldb-mi/startup_options/TestMiStartupOptions.py Modified: lld

[Lldb-commits] [lldb] r236705 - Implement -target-attach and -target-detach

Author: ki.stfu Date: Thu May 7 02:38:49 2015 New Revision: 236705 URL: http://llvm.org/viewvc/llvm-project?rev=236705&view=rev Log: Implement -target-attach and -target-detach Summary: This changes add -target-attach and -target-detach. -target-attach allows lldb-mi to attach to an existing p

[Lldb-commits] [lldb] r236704 - Minor changes in the MiStartupOptionsTestCase (MI)

Author: ki.stfu Date: Thu May 7 02:16:06 2015 New Revision: 236704 URL: http://llvm.org/viewvc/llvm-project?rev=236704&view=rev Log: Minor changes in the MiStartupOptionsTestCase (MI) Modified: lldb/trunk/test/tools/lldb-mi/startup_options/TestMiStartupOptions.py lldb/trunk/test/tools/l

[Lldb-commits] [lldb] r236703 - Add -s/--source option support (MI)

Author: ki.stfu Date: Thu May 7 01:51:46 2015 New Revision: 236703 URL: http://llvm.org/viewvc/llvm-project?rev=236703&view=rev Log: Add -s/--source option support (MI) Summary: This patch adds -s/--source option to execute source file with prepared command. For example: ``` $ cat start_script

[Lldb-commits] [lldb] r236702 - Remove quit hook in CMIDriver::DoMainLoop (MI)

Author: ki.stfu Date: Thu May 7 01:45:42 2015 New Revision: 236702 URL: http://llvm.org/viewvc/llvm-project?rev=236702&view=rev Log: Remove quit hook in CMIDriver::DoMainLoop (MI) Summary: This patch removes quit hook and fixes 1 bug: # Fix "quit" hook in CMIDriver::DoMainLoop (MI) # Fix bug whe

[Lldb-commits] [lldb] r236700 - Fix ClangUserExpression::Evaluate return code in case of eExpressionParseError

Author: ki.stfu Date: Thu May 7 01:27:43 2015 New Revision: 236700 URL: http://llvm.org/viewvc/llvm-project?rev=236700&view=rev Log: Fix ClangUserExpression::Evaluate return code in case of eExpressionParseError Summary: This patch fixes retvalue of ClangUserExpression::Evaluate in case of eExp

[Lldb-commits] [lldb] r236699 - Don't call the Process::SyncIOHandler in Target::Launch

Author: ki.stfu Date: Thu May 7 01:26:27 2015 New Revision: 236699 URL: http://llvm.org/viewvc/llvm-project?rev=236699&view=rev Log: Don't call the Process::SyncIOHandler in Target::Launch Summary: This patch moves synchronization of iohandler to CommandObjectProcessLaunch::DoExecute like it wa

[Lldb-commits] [lldb] r236231 - Fix Process::ResumeSynchronous which waits a process even in case of error

Author: ki.stfu Date: Thu Apr 30 08:10:32 2015 New Revision: 236231 URL: http://llvm.org/viewvc/llvm-project?rev=236231&view=rev Log: Fix Process::ResumeSynchronous which waits a process even in case of error Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/

[Lldb-commits] [lldb] r236229 - Fix MiLibraryLoadedTestCase.test_lldbmi_library_loaded test on Linux (MI)

Author: ki.stfu Date: Thu Apr 30 07:37:05 2015 New Revision: 236229 URL: http://llvm.org/viewvc/llvm-project?rev=236229&view=rev Log: Fix MiLibraryLoadedTestCase.test_lldbmi_library_loaded test on Linux (MI) Modified: lldb/trunk/test/tools/lldb-mi/TestMiLibraryLoaded.py Modified: lldb/trunk

[Lldb-commits] [lldb] r236228 - Use \d+ pattern instead of hard-coded line number in MiBreakTestCase (MI)

Author: ki.stfu Date: Thu Apr 30 07:28:26 2015 New Revision: 236228 URL: http://llvm.org/viewvc/llvm-project?rev=236228&view=rev Log: Use \d+ pattern instead of hard-coded line number in MiBreakTestCase (MI) Modified: lldb/trunk/test/tools/lldb-mi/breakpoint/TestMiBreak.py Modified: lldb/tr

[Lldb-commits] [lldb] r236225 - Rework =shlibs-added/=shlibs-removed

Author: ki.stfu Date: Thu Apr 30 06:08:31 2015 New Revision: 236225 URL: http://llvm.org/viewvc/llvm-project?rev=236225&view=rev Log: Rework =shlibs-added/=shlibs-removed Summary: This patch includes the following: * Rename =shlibs-added/=shlibs-removed to standard =library-loaded/=library-unloa

[Lldb-commits] [lldb] r236208 - Add -data-info-line command (MI)

Author: ki.stfu Date: Thu Apr 30 02:14:24 2015 New Revision: 236208 URL: http://llvm.org/viewvc/llvm-project?rev=236208&view=rev Log: Add -data-info-line command (MI) Summary: Add -data-info-line command + test Test Plan: ./dotest.py -v --executable $BUILDDIR/bin/lldb tools/lldb-mi/ Reviewers:

Re: [Lldb-commits] [lldb] r235991 - Replace sprintf with snprintf to avoid a crash.

rminated > > Aborted (core dumped) > > > > Casting the cUnescapedChar to unsigned char also fixes the crash. > > > > Regards, > > Abid > > > >> -Original Message- > >> From: Pavel Labath [mailto:lab...@google.com] > >> Sent: 28 Apr

Re: [Lldb-commits] [lldb] r235991 - Replace sprintf with snprintf to avoid a crash.

Hello Abid, I thought it never can happen because cUnescapedChar is less than 255 and "\\x%02hhu" prints something like \x12. Am I wrong? Thanks, Ilia On Tue, Apr 28, 2015 at 5:16 PM, Hafiz Abid Qadeer wrote: > Author: abidh > Date: Tue Apr 28 09:16:00 2015 > New Revision: 235991 > > URL: htt

[Lldb-commits] [lldb] r235983 - Add language option in -gdb-show command (MI)

Author: ki.stfu Date: Tue Apr 28 07:51:16 2015 New Revision: 235983 URL: http://llvm.org/viewvc/llvm-project?rev=235983&view=rev Log: Add language option in -gdb-show command (MI) Summary: Add language option in -gdb-show command + test: ``` $ bin/lldb-mi ~/p/hello [...] b main [...] r [...] (gdb

[Lldb-commits] [lldb] r235982 - Don't print a type of variable in Address::Dump if it's unknown (i.e. nullptr)

Author: ki.stfu Date: Tue Apr 28 07:45:57 2015 New Revision: 235982 URL: http://llvm.org/viewvc/llvm-project?rev=235982&view=rev Log: Don't print a type of variable in Address::Dump if it's unknown (i.e. nullptr) Summary: This patch fixes dereferencing of nullptr in case when GetType() returns t

[Lldb-commits] [lldb] r235857 - Fix double stdout/stderr output from CLI commands in MI mode (MI)

Author: ki.stfu Date: Mon Apr 27 05:07:49 2015 New Revision: 235857 URL: http://llvm.org/viewvc/llvm-project?rev=235857&view=rev Log: Fix double stdout/stderr output from CLI commands in MI mode (MI) Summary: This patch fixes stdout/stderr output that printed twice for CLI commands: was: ``` (gdb

Re: [Lldb-commits] [lldb] r235851 - XFAIL two mi tests on gcc to stabilise build bots

thx! Thanks, Ilia On Mon, Apr 27, 2015 at 12:10 PM, Pavel Labath wrote: > Author: labath > Date: Mon Apr 27 04:10:30 2015 > New Revision: 235851 > > URL: http://llvm.org/viewvc/llvm-project?rev=235851&view=rev > Log: > XFAIL two mi tests on gcc to stabilise build bots > > Modified: > lldb/t

[Lldb-commits] [lldb] r235819 - Add SBLaunchInfo in include/lldb/API/SBDefines.h and fix spacing in scripts/Python/buildSwigPython.py

Author: ki.stfu Date: Sun Apr 26 02:51:14 2015 New Revision: 235819 URL: http://llvm.org/viewvc/llvm-project?rev=235819&view=rev Log: Add SBLaunchInfo in include/lldb/API/SBDefines.h and fix spacing in scripts/Python/buildSwigPython.py Modified: lldb/trunk/include/lldb/API/SBDefines.h l

  1   2   3   4   5   6   7   >