Re: [Lldb-commits] [PATCH] Allow redirection to pts for POSIX process

2014-09-08 Thread Todd Fiala
LGTM. Tested: Ubuntu 14.04 x86_64, clang-3.5-built lldb. http://reviews.llvm.org/D5135 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r217382 - Linux/FreeBSD local debugging: allow redirection to pts for POSIX process.

2014-09-08 Thread Todd Fiala
Author: tfiala Date: Mon Sep 8 10:57:14 2014 New Revision: 217382 URL: http://llvm.org/viewvc/llvm-project?rev=217382view=rev Log: Linux/FreeBSD local debugging: allow redirection to pts for POSIX process. See http://reviews.llvm.org/D5135 for more details. Change by Zephyr Zhao. Modified:

Re: [Lldb-commits] [PATCH] Allow redirection to pts for POSIX process

2014-09-08 Thread Todd Fiala
Submitted here: ``` svn commit Sendingsource/Plugins/Process/POSIX/ProcessPOSIX.cpp Sendingsource/Plugins/Process/POSIX/ProcessPOSIX.h Transmitting file data .. Committed revision 217382. ``` http://reviews.llvm.org/D5135 ___

Re: [Lldb-commits] [PATCH] Allow redirection to pts for POSIX process

2014-09-08 Thread Todd Fiala
No worries, trying this again with patch set 2. http://reviews.llvm.org/D5135 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r217387 - Modify call-function and rdar-12437442 tests to clean up all files produced during test run.

2014-09-08 Thread Todd Fiala
Author: tfiala Date: Mon Sep 8 11:44:17 2014 New Revision: 217387 URL: http://llvm.org/viewvc/llvm-project?rev=217387view=rev Log: Modify call-function and rdar-12437442 tests to clean up all files produced during test run. Modified:

Re: [Lldb-commits] [PATCH] Add an error message when objfile loading fails.

2014-09-05 Thread Todd Fiala
with remote-debug sessions. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180

Re: [Lldb-commits] [PATCH] Check for byte order correctness in GDBRemoteCommunicationClient::GetCurrentProcessInfo.

2014-09-05 Thread Todd Fiala
. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits

Re: [Lldb-commits] [PATCH] Properly handle the DYLD attach step for GDB remotes.

2014-09-05 Thread Todd Fiala
: ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits

Re: [Lldb-commits] [PATCH] Implements a HostThread class.

2014-09-05 Thread Todd Fiala
don't write thread.GetNativeThread(), you're guaranteed to only be using generic methods. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi

Re: [Lldb-commits] [PATCH] Implements a HostThread class.

2014-09-05 Thread Todd Fiala
Trying this out locally now. http://reviews.llvm.org/D5110 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Implements a HostThread class.

2014-09-05 Thread Todd Fiala
(), you're guaranteed to only be using generic methods. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180

Re: [Lldb-commits] [PATCH] Implements a HostThread class.

2014-09-05 Thread Todd Fiala
entirely. Then comments about that review started coming in on this thread. Anyway, look here: http://reviews.llvm.org/D5198 On Fri, Sep 5, 2014 at 4:35 PM, Todd Fiala tfi...@google.com wrote: Hey Zachary - am I looking in the right spot? The top of the thread is talking about this: http

Re: [Lldb-commits] [PATCH] Use the process' ReadCStringFromMemory from DYLDRendezvous::ReadStringFromMemory.

2014-09-04 Thread Todd Fiala
remote debugging over a slow connection. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180

[Lldb-commits] [lldb] r217153 - Use the process' ReadCStringFromMemory from DYLDRendezvous::ReadStringFromMemory.

2014-09-04 Thread Todd Fiala
Author: tfiala Date: Thu Sep 4 09:16:19 2014 New Revision: 217153 URL: http://llvm.org/viewvc/llvm-project?rev=217153view=rev Log: Use the process' ReadCStringFromMemory from DYLDRendezvous::ReadStringFromMemory. Tested: Ubuntu 14.04 x86_64, clang-3.5-built lldb. MacOSX 10.9.4,

Re: [Lldb-commits] [lldb] r217116 - ASan malloc/free history threads

2014-09-04 Thread Todd Fiala
be provided to build* functions above) which contains OS-specific build flags. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi

Re: [Lldb-commits] [PATCH] Properly handle the DYLD attach step for GDB remotes.

2014-09-04 Thread Todd Fiala
has been setup), which means we can’t load any shared object yet. AFAICT, this can only happen during remote debugging, as attaching to a live process with lldb directly would necessarily attach after the entry point. On Sep 4, 2014, at 3:32 PM, Todd Fiala tfi...@google.com wrote: (I've also

Re: [Lldb-commits] [PATCH] lldb more on register context arm64

2014-09-02 Thread Todd Fiala
LGTM, thanks for latest changes. http://reviews.llvm.org/D5089 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r216907 - Linux ARM64: add ProcessMonitor-related RegisterContext support.

2014-09-02 Thread Todd Fiala
Author: tfiala Date: Tue Sep 2 09:50:01 2014 New Revision: 216907 URL: http://llvm.org/viewvc/llvm-project?rev=216907view=rev Log: Linux ARM64: add ProcessMonitor-related RegisterContext support. See http://reviews.llvm.org/D5089 for more details. Change by Paul Osmialowski. Added:

Re: [Lldb-commits] [PATCH] lldb more on register context arm64

2014-09-02 Thread Todd Fiala
Tested: * Ubuntu 14.04 x86_64, clang 3.5-built lldb. * MacOSX 10.9.4, Xcode6-Beta6-built lldb. http://reviews.llvm.org/D5089 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb more on register context arm64

2014-09-02 Thread Todd Fiala
Closed with commit: ``` svn commit Sendingsource/Plugins/Process/POSIX/CMakeLists.txt Sendingsource/Plugins/Process/POSIX/POSIXThread.cpp Adding source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_arm64.cpp Adding

Re: [Lldb-commits] [PATCH] Add macosx/HostInfoMacOSX.mm to source/Host/CMakeLists.txt.

2014-09-02 Thread Todd Fiala
-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add macosx/HostInfoMacOSX.mm to source/Host/CMakeLists.txt.

2014-09-02 Thread Todd Fiala
Ok. In here: svn commit Sendingsource/Host/CMakeLists.txt Transmitting file data . Committed revision 216948. On Tue, Sep 2, 2014 at 2:15 PM, Stephane Sezer s...@fb.com wrote: Nope. I don’t have committer access. On Sep 2, 2014, at 2:12 PM, Todd Fiala tfi...@google.com wrote

Re: [Lldb-commits] Review request on Darwin side of change

2014-08-29 Thread Todd Fiala
must have put the source/Utility directory in the list of include directories? J On Aug 28, 2014, at 7:57 AM, Todd Fiala tfi...@google.com wrote: Attaching the final diff I'm using over here (needed minor rebasing against TOT, r216668). On Thu, Aug 28, 2014 at 7:40 AM, Todd Fiala tfi

Re: [Lldb-commits] [PATCH] lldb - towards AArch64 being recognised as platform architecture

2014-08-29 Thread Todd Fiala
://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r216737 - lldb - Register Context Linux ARM64

2014-08-29 Thread Todd Fiala
Author: tfiala Date: Fri Aug 29 11:01:35 2014 New Revision: 216737 URL: http://llvm.org/viewvc/llvm-project?rev=216737view=rev Log: lldb - Register Context Linux ARM64 Yet another step toward ARM64 support. With this commit, lldb-gdbserver started on ARM64 target can be accessed by lldb running

Re: [Lldb-commits] Review request on Darwin side of change

2014-08-29 Thread Todd Fiala
Committed revision 216737. On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala tfi...@google.com wrote: (And thanks for checking it out!) On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala tfi...@google.com wrote: Is this necessary in RegisterInfos_arm64.h? +#include ../../../Utility

Re: [Lldb-commits] [PATCH] lldb - fix misleading valid target indexes are error message

2014-08-29 Thread Todd Fiala
See comments here, Paul: http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140825/012666.html I'll wait to see how you adjust this per comments, then get it in. http://reviews.llvm.org/D4430 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] lldb more on register context arm64

2014-08-29 Thread Todd Fiala
://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add arbitrary command line flags to llgs/debugserver startup for local debugging

2014-08-29 Thread Todd Fiala
I just put this in here: svn commit Sendingsource/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Transmitting file data . Committed revision 216745. On Thu, Aug 28, 2014 at 10:51 PM, Todd Fiala todd.fi...@gmail.com wrote: I'm going to put this in since I haven't heard any

[Lldb-commits] [lldb] r216745 - Add arbitrary command line flags to llgs/debugserver startup for local debugging.

2014-08-29 Thread Todd Fiala
Author: tfiala Date: Fri Aug 29 12:10:31 2014 New Revision: 216745 URL: http://llvm.org/viewvc/llvm-project?rev=216745view=rev Log: Add arbitrary command line flags to llgs/debugserver startup for local debugging. This patch accepts environment variables of the form:

Re: [Lldb-commits] [PATCH] Consolidate UnixSignals setting/getting in Process.

2014-08-29 Thread Todd Fiala
The modification to source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp is not appropriate in this patch. It already went in as a separate change (llvm.org svn r216745 here: http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140825/012685.html).

[Lldb-commits] [lldb] r216748 - Consolidate UnixSignals setting/getting in Process.

2014-08-29 Thread Todd Fiala
Author: tfiala Date: Fri Aug 29 12:35:57 2014 New Revision: 216748 URL: http://llvm.org/viewvc/llvm-project?rev=216748view=rev Log: Consolidate UnixSignals setting/getting in Process. See http://reviews.llvm.org/D5108 for details. This change does the following: * eliminates the

Re: [Lldb-commits] [PATCH] Consolidate UnixSignals setting/getting in Process.

2014-08-29 Thread Todd Fiala
Put it up here: svn commit Sendinginclude/lldb/Host/Host.h Sendinginclude/lldb/Target/Process.h Sendinginclude/lldb/lldb-private-forward.h Sendinglldb.xcodeproj/project.pbxproj Sendingsource/Host/common/Host.cpp Sendingsource/Host/freebsd/Host.cpp

Re: [Lldb-commits] [PATCH] Implements a HostThread class.

2014-08-29 Thread Todd Fiala
/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r216766 - lldb - fix misleading valid target indexes are error message

2014-08-29 Thread Todd Fiala
Author: tfiala Date: Fri Aug 29 15:14:21 2014 New Revision: 216766 URL: http://llvm.org/viewvc/llvm-project?rev=216766view=rev Log: lldb - fix misleading valid target indexes are error message See http://reviews.llvm.org/D4430 for more details. Change by Paul Osmialowski. Modified:

Re: [Lldb-commits] [PATCH] lldb - fix misleading valid target indexes are error message

2014-08-29 Thread Todd Fiala
svn commit Sendingsource/Commands/CommandObjectTarget.cpp Transmitting file data . Committed revision 216766. http://reviews.llvm.org/D4430 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r216770 - Fix a test broken by r216564.

2014-08-29 Thread Todd Fiala
Author: tfiala Date: Fri Aug 29 15:32:18 2014 New Revision: 216770 URL: http://llvm.org/viewvc/llvm-project?rev=216770view=rev Log: Fix a test broken by r216564. llgs Linux is no longer doing the translation to some gdb fixed signal numbers. This change modifies the test method to take in the

Re: [Lldb-commits] [lldb] r216564 - NativeThreadLinux: remove translation of some Linux signals to gdb signals.

2014-08-28 Thread Todd Fiala
, 2014 at 10:11 AM, Todd Fiala todd.fi...@gmail.com wrote: Author: tfiala Date: Wed Aug 27 12:11:56 2014 New Revision: 216564 URL: http://llvm.org/viewvc/llvm-project?rev=216564view=rev Log: NativeThreadLinux: remove translation of some Linux signals to gdb signals. I copied this originally

Re: [Lldb-commits] [PATCH] lldb - towards AArch64 being recognised as platform architecture

2014-08-28 Thread Todd Fiala
No need to rebase this one. Testing it now. http://reviews.llvm.org/D4381 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb - towards AArch64 being recognised as platform architecture

2014-08-28 Thread Todd Fiala
svn commit Sendinginclude/lldb/Core/ArchSpec.h Sendingsource/Core/ArchSpec.cpp Transmitting file data .. Committed revision 216668. http://reviews.llvm.org/D4381 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Consolidate UnixSignals setting/getting in Process.

2014-08-28 Thread Todd Fiala
Small tweak - a flag from another branch snuck in. Harmless for the change but still not intended to be there. http://reviews.llvm.org/D5108 Files: include/lldb/Host/Host.h include/lldb/Target/Process.h include/lldb/lldb-private-forward.h lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r216686 - Ensure the Host wait4 thread is able to show pid in thread name.

2014-08-28 Thread Todd Fiala
Author: tfiala Date: Thu Aug 28 16:21:39 2014 New Revision: 216686 URL: http://llvm.org/viewvc/llvm-project?rev=216686view=rev Log: Ensure the Host wait4 thread is able to show pid in thread name. For hosts that cannot support long thread names, shrink the host wait4 thread name so that it does

Re: [Lldb-commits] [PATCH] Add arbitrary command line flags to llgs/debugserver startup for local debugging

2014-08-28 Thread Todd Fiala
I'm going to put this in since I haven't heard any feedback on it. On Tue, Jul 29, 2014 at 10:02 AM, Todd Fiala todd.fi...@gmail.com wrote: BTW - I'm using LLDB_DEBUGSERVER_* as the prefix because there are already some more-specialized environment variables for similar tasks that start

[Lldb-commits] [lldb] r216553 - Add Linux support for get thread area on ARM64 using ProcessMonitor debugging.

2014-08-27 Thread Todd Fiala
Author: tfiala Date: Wed Aug 27 11:05:26 2014 New Revision: 216553 URL: http://llvm.org/viewvc/llvm-project?rev=216553view=rev Log: Add Linux support for get thread area on ARM64 using ProcessMonitor debugging. See http://reviews.llvm.org/D5073. Change by Paul Osmialowski. Modified:

Re: [Lldb-commits] [PATCH] lldb get thread area on ARM64

2014-08-27 Thread Todd Fiala
LGTM. Tested: Ubuntu 14.04 x86_64, clang-3.5-built lldb. http://reviews.llvm.org/D5073 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb AArch64 should be listed as yet another 64-bit architecture in HostInfoBase

2014-08-27 Thread Todd Fiala
Testing now. Already reviewed by Greg Clayton. http://reviews.llvm.org/D5070 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb Missing break statement added

2014-08-27 Thread Todd Fiala
As Greg already called out, LGTM. Just giving it a test run on MacOSX, then will check in. http://reviews.llvm.org/D5069 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r216556 - lldb AArch64 should be listed as yet another 64-bit architecture in HostInfoBase.

2014-08-27 Thread Todd Fiala
Author: tfiala Date: Wed Aug 27 11:21:41 2014 New Revision: 216556 URL: http://llvm.org/viewvc/llvm-project?rev=216556view=rev Log: lldb AArch64 should be listed as yet another 64-bit architecture in HostInfoBase. See http://reviews.llvm.org/D5070. Change by Paul Osmialowski. Modified:

Re: [Lldb-commits] [PATCH] lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added

2014-08-27 Thread Todd Fiala
Testing now, change looks good. http://reviews.llvm.org/D5078 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added

2014-08-27 Thread Todd Fiala
Tested: Ubuntu 14.04 x86_64, clang-3.5-built lldb. http://reviews.llvm.org/D5078 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r216559 - lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added.

2014-08-27 Thread Todd Fiala
Author: tfiala Date: Wed Aug 27 11:32:02 2014 New Revision: 216559 URL: http://llvm.org/viewvc/llvm-project?rev=216559view=rev Log: lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added. See http://reviews.llvm.org/D5078. Change by Paul Osmialowski. Modified:

Re: [Lldb-commits] [PATCH] lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added

2014-08-27 Thread Todd Fiala
svn commit Sendingsource/Plugins/Process/POSIX/ProcessPOSIX.cpp Transmitting file data . Committed revision 216559. http://reviews.llvm.org/D5078 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r216564 - NativeThreadLinux: remove translation of some Linux signals to gdb signals.

2014-08-27 Thread Todd Fiala
Author: tfiala Date: Wed Aug 27 12:11:56 2014 New Revision: 216564 URL: http://llvm.org/viewvc/llvm-project?rev=216564view=rev Log: NativeThreadLinux: remove translation of some Linux signals to gdb signals. I copied this originally based on what debugserver was doing. This appears to be

Re: [Lldb-commits] [PATCH] lldb more on register context arm64

2014-08-27 Thread Todd Fiala
source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.h ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd

Re: [Lldb-commits] [PATCH] lldb - towards AArch64 being recognised as platform architecture

2014-08-27 Thread Todd Fiala
Hey Paul, Trying to catch up on the patches that didn't make it in yet. This looks like one of them. Can you shoot me an email with all the changes that are not in yet? Can you also add me as reviewers on them (user tfiala) and rebase them against lldb top of tree? Thanks! -Todd

[Lldb-commits] [lldb] r216630 - Add some logging around Process attaching and inferior exec handling.

2014-08-27 Thread Todd Fiala
Author: tfiala Date: Wed Aug 27 17:58:26 2014 New Revision: 216630 URL: http://llvm.org/viewvc/llvm-project?rev=216630view=rev Log: Add some logging around Process attaching and inferior exec handling. Modified: lldb/trunk/include/lldb/Target/Process.h

[Lldb-commits] [lldb] r216465 - Refactored existing gdb-remote qProcessInfo tests into separate python file.

2014-08-26 Thread Todd Fiala
Author: tfiala Date: Tue Aug 26 12:19:10 2014 New Revision: 216465 URL: http://llvm.org/viewvc/llvm-project?rev=216465view=rev Log: Refactored existing gdb-remote qProcessInfo tests into separate python file. I'm about to add some more qProcessInfo tests so I wanted to first pull them out of the

[Lldb-commits] [lldb] r216470 - Fix llgs to send triple for non-Apple platforms and lldb to interpret correctly.

2014-08-26 Thread Todd Fiala
Author: tfiala Date: Tue Aug 26 13:21:02 2014 New Revision: 216470 URL: http://llvm.org/viewvc/llvm-project?rev=216470view=rev Log: Fix llgs to send triple for non-Apple platforms and lldb to interpret correctly. This change addresses this bug: http://llvm.org/bugs/show_bug.cgi?id=20755 This

Re: [Lldb-commits] [lldb] r216238 - Add missing HostInfo::Initialize() in llgs.

2014-08-26 Thread Todd Fiala
there to be single call to initialize everything and terminate everything and this is done via the Debugger calls. On Aug 21, 2014, at 3:41 PM, Todd Fiala todd.fi...@gmail.com wrote: Author: tfiala Date: Thu Aug 21 17:41:25 2014 New Revision: 216238 URL: http://llvm.org/viewvc/llvm

Re: [Lldb-commits] [lldb] r216238 - Add missing HostInfo::Initialize() in llgs.

2014-08-26 Thread Todd Fiala
There might be an issue there. PluginManager uses the file system initialization. But I think Debugger depends on HostInfo being initialized first. I'll look and see if I can detangle that. On Tue, Aug 26, 2014 at 11:43 AM, Todd Fiala tfi...@google.com wrote: Ah ok. I'll move those

Re: [Lldb-commits] [lldb] r216238 - Add missing HostInfo::Initialize() in llgs.

2014-08-26 Thread Todd Fiala
:52 AM, Todd Fiala tfi...@google.com wrote: Ok - but - are we okay with moving PluginManager::Initialize() within there? If so, we're good. Because HostInfo::Initialize() needs to come *before* PluginManager::Initialize(). Seems reasonable, I just need to peek where we're initializing

Re: [Lldb-commits] [PATCH] Fix configure make build with python disabled

2014-08-25 Thread Todd Fiala
Putting Ed on this :-) http://reviews.llvm.org/D4918 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] 64bit eh_frame support

2014-08-25 Thread Todd Fiala
___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits

Re: [Lldb-commits] 64bit eh_frame support

2014-08-25 Thread Todd Fiala
Great, will do - thanks Jason! On Mon, Aug 25, 2014 at 2:44 PM, Jason Molenda jmole...@apple.com wrote: Ah sorry I missed that patch. Yes, this looks correct, please commit. On Aug 25, 2014, at 1:41 PM, Todd Fiala tfi...@google.com wrote: Bump! On Fri, Aug 15, 2014 at 3:30 PM

Re: [Lldb-commits] 64bit eh_frame support

2014-08-25 Thread Todd Fiala
Submitted. svn commit Sendingsource/Symbol/DWARFCallFrameInfo.cpp Transmitting file data . Committed revision 216409. On Mon, Aug 25, 2014 at 2:46 PM, Todd Fiala tfi...@google.com wrote: Great, will do - thanks Jason! On Mon, Aug 25, 2014 at 2:44 PM, Jason Molenda jmole

Re: [Lldb-commits] [PATCH] Profile Assembly Until Ret Instruction

2014-08-22 Thread Todd Fiala
Er I'll get it in... eek.. On Fri, Aug 22, 2014 at 9:49 AM, Todd Fiala tfi...@google.com wrote: I'm going to test this now. If it all looks good, I'll ge tit in. On Tue, Aug 19, 2014 at 5:01 PM, Tong Shen endlessr...@google.com wrote: Thanks Jason! I will finish this patch and let's

Re: [Lldb-commits] [PATCH] Profile Assembly Until Ret Instruction

2014-08-22 Thread Todd Fiala
0 and write off those .1% cases where it isn't correct instead of trying to get too fancy with the assembly analysis code. On Jul 29, 2014, at 4:17 PM, Todd Fiala tfi...@google.com wrote: Hey Jason, Do you have any feedback on this? Thanks! -Todd On Fri

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-21 Thread Todd Fiala
source/Plugins/Process/Linux/ProcessMonitor.cpp -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-21 Thread Todd Fiala
Hey Paul - I'll be looking to get your patches in today (I was OOO yesterday). http://reviews.llvm.org/D4803 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-21 Thread Todd Fiala
LGTM. Tested: Ubuntu 14.04 x86_64: clang-3.5-built lldb. All local tests passed. http://reviews.llvm.org/D4803 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-21 Thread Todd Fiala
svn commit Sendingsource/Plugins/Process/Linux/NativeProcessLinux.cpp Sendingsource/Plugins/Process/Linux/ProcessMonitor.cpp Transmitting file data .. Committed revision 216185. http://reviews.llvm.org/D4803 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] Fix on Linux for ReadThread lingering after inferior exits

2014-08-21 Thread Todd Fiala
___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits

Re: [Lldb-commits] [PATCH] Fix on Linux for ReadThread lingering after inferior exits

2014-08-21 Thread Todd Fiala
. Submitted here: svn commit Sendingsource/Core/Communication.cpp Transmitting file data . Committed revision 216194. On Thu, Aug 21, 2014 at 9:54 AM, Todd Fiala tfi...@google.com wrote: Giving this a final test now. -Todd On Wed, Aug 20, 2014 at 4:53 PM, Alex Pepper apep

Re: [Lldb-commits] [lldb] r216243 - Two small fixes to get Mac native + debugserver working after the

2014-08-21 Thread Todd Fiala
Awesome - fixes an issue in my branch as well :-) Thanks, Jason! On Thu, Aug 21, 2014 at 4:22 PM, Jason Molenda jmole...@apple.com wrote: Author: jmolenda Date: Thu Aug 21 18:22:33 2014 New Revision: 216243 URL: http://llvm.org/viewvc/llvm-project?rev=216243view=rev Log: Two small fixes

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-19 Thread Todd Fiala
Looking at this now. http://reviews.llvm.org/D4803 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb handle breakpoints on ARM64

2014-08-19 Thread Todd Fiala
Look at this now (in isolation from http://reviews.llvm.org/D4803). http://reviews.llvm.org/D4969 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb - Register Context Linux ARM64

2014-08-19 Thread Todd Fiala
Same with this - did this go in while I was on vacation? Looking to close out some reviews that are still listed as open. http://reviews.llvm.org/D4580 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Adjust process launch --disable-aslr to take true/false value.

2014-08-19 Thread Todd Fiala
Thanks. I'll get that in and be done with it (wipes hands clean...) ;-) On Tue, Aug 19, 2014 at 10:27 AM, jing...@apple.com wrote: That looks right to me. Jim On Aug 18, 2014, at 9:07 PM, Todd Fiala tfi...@google.com wrote: Hey Jim, Does this patch adequately address your

[Lldb-commits] [lldb] r215996 - Adjust process launch --disable-aslr to take true/false value.

2014-08-19 Thread Todd Fiala
Author: tfiala Date: Tue Aug 19 12:40:43 2014 New Revision: 215996 URL: http://llvm.org/viewvc/llvm-project?rev=215996view=rev Log: Adjust process launch --disable-aslr to take true/false value. This change modifies the 'process launch' --disable-aslr option to take a boolean argument. If the

Re: [Lldb-commits] [PATCH] Adjust process launch --disable-aslr to take true/false value.

2014-08-19 Thread Todd Fiala
Submitted: tfiala-macpro2:lldb tfiala$ svn commit Sendinginclude/lldb/Target/Process.h Sendingsource/Commands/CommandObjectProcess.cpp Sendingsource/Target/Process.cpp Transmitting file data ... Committed revision 215996. On Tue, Aug 19, 2014 at 10:28 AM, Todd Fiala tfi

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-19 Thread Todd Fiala
. http://reviews.llvm.org/D4803 -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-19 Thread Todd Fiala
Ok - that sounds good. Would you like to pull those out and put it in this patch, since they seem to be atomically related? http://reviews.llvm.org/D4803 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] lldb - ELF: ARM64 relocation jump slot type

2014-08-19 Thread Todd Fiala
Okay - thanks Paul. Closing out. Listing as accepted with understanding this already went in (albeit slightly differently). http://reviews.llvm.org/D4579 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] lldb - Register Context Linux ARM64

2014-08-19 Thread Todd Fiala
Ok - marking as accepted and closing out (with understanding this functionality already went in via another patch). http://reviews.llvm.org/D4580 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [lldb] r216028 - Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?

2014-08-19 Thread Todd Fiala
+ AppleObjCClassDescriptorV2.cpp + AppleObjCTypeEncodingParser.cpp ) ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650

Re: [Lldb-commits] [lldb] r216028 - Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?

2014-08-19 Thread Todd Fiala
AppleThreadPlanStepThroughObjCTrampoline.cpp + AppleObjCClassDescriptorV2.cpp + AppleObjCTypeEncodingParser.cpp ) ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software

[Lldb-commits] [PATCH] Adjust process launch --disable-aslr to take true/false value.

2014-08-18 Thread Todd Fiala
accordingly. In the event that the setting is not explicitly made on the process launch command line, then the value is retrieved from the target.disable-aslr setting (i.e. settings show target.disable-aslr). -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 Index: include/lldb

Re: [Lldb-commits] [PATCH] Adjust process launch --disable-aslr to take true/false value.

2014-08-18 Thread Todd Fiala
Hey Jim, Does this patch adequately address your comments on the earlier patch? Thanks! -Todd On Mon, Aug 18, 2014 at 4:14 PM, Todd Fiala tfi...@google.com wrote: Adjust process launch --disable-aslr to take true/false value. This change modifies the 'process launch' --disable-aslr option

Re: [Lldb-commits] [PATCH] Fix Linux lldb local and remote debugging to respect the flag to disable ASLR.

2014-08-16 Thread Todd Fiala
This change also adds the Plugins/Process/FreeBSD files to the Xcode project. http://reviews.llvm.org/D4941 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix Linux lldb local and remote debugging to respect the flag to disable ASLR.

2014-08-16 Thread Todd Fiala
Ok cool, I'll get this in after removing the dupe of the system flag. http://reviews.llvm.org/D4941 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix Linux lldb local and remote debugging to respect the flag to disable ASLR.

2014-08-16 Thread Todd Fiala
Thanks Todd - I'm playing around with the Xcode build now and just noticed this today. My pleasure, Ed! http://reviews.llvm.org/D4941 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Get test executables compiling on Windows.

2014-08-13 Thread Todd Fiala
Hey Zachary, LGTM. Tested: Ubuntu 14.04 x86_64 - clang-built lldb. MacOSX 10.9.4 - Xcode 6 Beta 5-built lldb. Test Failures: Unrelated - seeing TestCallStopAndContinue.py fail on both Linux and MacOSX occasionally both without and with the patch. Should not block.

Re: [Lldb-commits] [PATCH] Get test executables compiling on Windows.

2014-08-12 Thread Todd Fiala
Hey Zach, I agree with Ed's comments. If you want to do any minor fixup there, I'll give the final a run on Linux (unless you want to do that part yourself - either way is fine). http://reviews.llvm.org/D4816 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r215458 - llgs: corrected Linux signal reception notification for SIGABRT, SIGSEGV and their ilk.

2014-08-12 Thread Todd Fiala
Author: tfiala Date: Tue Aug 12 12:02:07 2014 New Revision: 215458 URL: http://llvm.org/viewvc/llvm-project?rev=215458view=rev Log: llgs: corrected Linux signal reception notification for SIGABRT, SIGSEGV and their ilk. Added llgs/debugserver gdb-remote tests around SIGABRT and SIGSEGV signal

Re: [Lldb-commits] [PATCH] Register Number in DWARFCallFrameInfo.cpp

2014-08-12 Thread Todd Fiala
Ok caught Jason's response after writing that last one. What state do you see this in, Jason? -Todd On Aug 12, 2014, at 5:05 PM, Todd Fiala tfi...@google.com wrote: Yep, will do later tonight. -Todd On Aug 12, 2014, at 4:32 PM, Tong Shen endlessr...@google.com wrote: Got it. So

Re: [Lldb-commits] [PATCH] Register Number in DWARFCallFrameInfo.cpp

2014-08-12 Thread Todd Fiala
, gcc_eip_i386, On Aug 12, 2014, at 5:05 PM, Todd Fiala tfi...@google.com wrote: Yep, will do later tonight. -Todd On Aug 12, 2014, at 4:32 PM, Tong Shen endlessr...@google.com wrote: Got it. So much magic going on there. +Todd Can you check this in? Thanks! On Tue, Aug 12, 2014

Re: [Lldb-commits] [PATCH] Register Number in DWARFCallFrameInfo.cpp

2014-08-12 Thread Todd Fiala
we’re thinking about it for migration purposes? (Like - we could #ifdef it now correctly for *APPLE* and have it default to the linux style just to be safe?) -Todd ​ On Tue, Aug 12, 2014 at 5:41 PM, Todd Fiala tfi...@google.com wrote: Ok - see you already did it. Thanks! On Tue, Aug 12

Re: [Lldb-commits] [PATCH]race condition calling PushProcessIOHandler

2014-08-11 Thread Todd Fiala
Just coming back to the world of LLDB. Looks like lots of healthy discussion on this one! On Aug 10, 2014 10:30 PM, Matthew Gardiner m...@csr.com wrote: Thanks Shawn, If Greg agrees that we need the SyncIOHandler() invocation in the Command object(s) (not the HandlePrivateEvent code) then

Re: [Lldb-commits] [PATCH] Check if certain stack frame exists before dereferencing it

2014-08-11 Thread Todd Fiala
Shen ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180 ___ lldb-commits

Re: [Lldb-commits] [PATCH] Fix assertion for i386 process on x86_64 linux host

2014-08-11 Thread Todd Fiala
name in different functions are different variables. -- Best Regards, Tong Shen ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits -- Todd Fiala | Software Engineer | tfi

<    1   2   3   4   >