This breaks the windows build. The name of this file suggests that it's
platform specific, but none of the code in particular that it's using is
actually platform specific. Should this file be compiled on Windows or not?
http://reviews.llvm.org/D4221
Thanks. It looks like UnixSignals.cpp is compiled on Windows, therefore
this should too. For whatever reason, the list of files to compile for the
API are maintained in a different CMake location on Windows than on
non-Windows. So when adding a file to API, you need to add it in two
places.
Hi tfiala,
Don't truncate the target triple when initializing clang.
Target triples support an optional 4th component, the environment. Clang on
Windows uses this 4th component to make various decisions when looking for
header file includes, so truncating it leads to crashes on Windows when
.
Please provide an updated patch and I’ll commit if you don’t have that
right.
Sean
On Jun 25, 2014, at 1:09 AM, Zachary Turner ztur...@google.com wrote:
The IRMemoryMap represents a set of disjoint allocations, stored as an
interval map. A bug in its allocation algorithm would cause
Author: zturner
Date: Wed Jun 25 13:37:19 2014
New Revision: 211726
URL: http://llvm.org/viewvc/llvm-project?rev=211726view=rev
Log:
Fix a bug in the IRMemoryMap which generated bogus allocations.
Previously, only the starting locations of the candidate interval
and the existing interval were
Author: zturner
Date: Wed Jun 25 13:40:58 2014
New Revision: 211728
URL: http://llvm.org/viewvc/llvm-project?rev=211728view=rev
Log:
Fix silly compilation error.
Modified:
lldb/trunk/source/Expression/IRMemoryMap.cpp
Modified: lldb/trunk/source/Expression/IRMemoryMap.cpp
URL:
+Greg and Jim, as one of them would probably know.
http://reviews.llvm.org/D4282
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: zturner
Date: Fri Jun 27 18:19:42 2014
New Revision: 211968
URL: http://llvm.org/viewvc/llvm-project?rev=211968view=rev
Log:
Don't truncate the target triple when initializing clang.
Reviewed by: Sean Callanan
Differential Revision: http://reviews.llvm.org/D4282
Modified:
Closed by commit rL211968 (authored by @zturner).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D4282
Files:
lldb/trunk/source/Expression/ClangExpressionParser.cpp
Index: lldb/trunk/source/Expression/ClangExpressionParser.cpp
===
Author: zturner
Date: Mon Jun 30 19:18:46 2014
New Revision: 212076
URL: http://llvm.org/viewvc/llvm-project?rev=212076view=rev
Log:
Fix Windows build after llgs upstream.
With _HAS_EXCEPTIONS=0, Windows' version of thread will fail to
compile because it calls __uncaught_exception(), which is
they are passed in the appropriate environment.
Jim
On Jul 3, 2014, at 2:24 AM, Zachary Turner ztur...@google.com wrote:
This patch implements the core logic to invalidate command options
based on the interpreter state, and uses this to invalidate uid/gid related
options of the platform
Author: zturner
Date: Wed Jul 9 11:42:27 2014
New Revision: 212630
URL: http://llvm.org/viewvc/llvm-project?rev=212630view=rev
Log:
Dont' use a random probe alloc strategy for the IRMemoryMap.
The current strategy for host allocation is to choose a random
address and attempt to allocate there,
Good question, I don't know. But I don't see how it could be correct,
because python module names are case-sensitive, and existing python code is
written against the un-normalized names.
On Thu, Jul 10, 2014 at 2:03 PM, Todd Fiala tfi...@google.com wrote:
Looks fine, I'm giving it a test run
Closed by commit rL212785 (authored by @zturner).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D4441
Files:
lldb/trunk/CMakeLists.txt
lldb/trunk/include/lldb/lldb-python.h
lldb/trunk/scripts/Python/finishSwigPythonLLDB.py
lldb/trunk/source/CMakeLists.txt
Author: zturner
Date: Thu Jul 10 18:47:42 2014
New Revision: 212785
URL: http://llvm.org/viewvc/llvm-project?rev=212785view=rev
Log:
Get the python scripting interface working on Windows.
This patch fixes a number of issues with embedded Python on
Windows. In particular:
1) The script that
Author: zturner
Date: Wed Jul 16 13:53:18 2014
New Revision: 213181
URL: http://llvm.org/viewvc/llvm-project?rev=213181view=rev
Log:
Fix build broken as a result of r213171.
r213171 renames the 'clangRewriteCore' library to 'clangRewrite'.
This change simply updates the makefiles to reference
Author: zturner
Date: Wed Jul 16 15:28:24 2014
New Revision: 213194
URL: http://llvm.org/viewvc/llvm-project?rev=213194view=rev
Log:
Fix some warnings in the Windows build.
Modified:
lldb/trunk/source/API/SBTarget.cpp
lldb/trunk/source/Commands/CommandObjectThread.cpp
Hi tfiala,
This fixes a few issues related to running the test suite on Windows. Most
notably, it makes lldb -P return the expected python path so this can be used
by the test script.
http://reviews.llvm.org/D4548
Files:
source/Host/common/Host.cpp
source/Host/windows/Host.cpp
Adds the builder_win32 module. Test suite runs!
http://reviews.llvm.org/D4573
Files:
test/benchmarks/disassembly/TestDisassembly.py
test/benchmarks/disassembly/TestDoAttachThenDisassembly.py
test/benchmarks/disassembly/TestXcode41Vs42GDBDisassembly.py
I'm going to hold off on submitting this. I had forgotten about it, and I
now have a better idea about how to solve the problem. I want to change
the command line format of dosep.py so that it doesn't take an argument of
the form -o command line for dotest.py and instead take a -- separator,
and
Author: zturner
Date: Thu Jul 17 20:02:02 2014
New Revision: 213343
URL: http://llvm.org/viewvc/llvm-project?rev=213343view=rev
Log:
Fixes a number of issue related to test portability on Windows.
99% of this CL is simply moving calls to import pexpect to a more
narrow scope - i.e. the function
Author: zturner
Date: Fri Jul 18 02:06:13 2014
New Revision: 213354
URL: http://llvm.org/viewvc/llvm-project?rev=213354view=rev
Log:
Use the designated PYTHON_EXECUTABLE during build.
We were hardcoding python as the command to run the swig wrapper
scripts. We should be using PYTHON_EXECUTABLE
Author: zturner
Date: Fri Jul 18 15:36:08 2014
New Revision: 213410
URL: http://llvm.org/viewvc/llvm-project?rev=213410view=rev
Log:
Make lldb -P work on Windows.
lldb -P, which outputs its python path, works by using Host-layer
facilities to get information about the loaded python module. This
Remove i486 and i486sx, only support i386 and i686
http://reviews.llvm.org/D4658
Files:
include/lldb/Core/ArchSpec.h
source/Core/ArchSpec.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
Fixed a few bugs
http://reviews.llvm.org/D4641
Files:
include/lldb/Core/ConnectionFileDescriptor.h
include/lldb/Host/Editline.h
include/lldb/Host/File.h
include/lldb/Host/IoObject.h
include/lldb/Host/Socket.h
source/Core/ConnectionFileDescriptor.cpp
Rebased against tip and fixed some comments.
http://reviews.llvm.org/D4641
Files:
include/lldb/Core/ConnectionFileDescriptor.h
include/lldb/Host/Editline.h
include/lldb/Host/File.h
include/lldb/Host/IoObject.h
include/lldb/Host/Socket.h
source/Core/ConnectionFileDescriptor.cpp
I don't think this works. \ and / are only identical on Windows. On other
platforms \ is a character that can actually appear in a string.
Furthermore, this doesn't address the issue in FileSpec, which also has
issues dealing with Windows paths. Incidentally, I was already working on
a patch
Fixed some issues related to normalization and de-normalization.
http://reviews.llvm.org/D4675
Files:
include/lldb/Host/FileSpec.h
include/lldb/Host/Host.h
source/Host/common/FileSpec.cpp
source/Host/common/Host.cpp
Index: include/lldb/Host/FileSpec.h
Removed dead function.
http://reviews.llvm.org/D4675
Files:
include/lldb/Host/FileSpec.h
include/lldb/Host/Host.h
source/Host/common/FileSpec.cpp
source/Host/common/Host.cpp
Index: include/lldb/Host/FileSpec.h
===
---
Author: zturner
Date: Mon Jul 28 11:44:28 2014
New Revision: 214091
URL: http://llvm.org/viewvc/llvm-project?rev=214091view=rev
Log:
Fix the MSVC build. MSVC does not support constexpr.
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
Modified: lldb/trunk/source/Core/ArchSpec.cpp
URL:
Author: zturner
Date: Mon Jul 28 11:44:49 2014
New Revision: 214092
URL: http://llvm.org/viewvc/llvm-project?rev=214092view=rev
Log:
Fix supported architectures on PlatformWindows.
i386, i486, i486sx, and i686 are all indistinguishable as far as
PE/COFF files are concerned. This patch adds
Closed by commit rL214093 (authored by @zturner).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D4674
Files:
lldb/trunk/include/lldb/Host/Host.h
lldb/trunk/include/lldb/Host/windows/win32.h
lldb/trunk/source/Host/common/Host.cpp
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Index:
Author: zturner
Date: Mon Jul 28 11:45:05 2014
New Revision: 214093
URL: http://llvm.org/viewvc/llvm-project?rev=214093view=rev
Log:
Use llvm Support functions to get the user's home directory.
Assuming that the user's home directory is at ~ is incorrect on
Windows. This patch delegates the
Closed by commit rL214092 (authored by @zturner).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D4658
Files:
lldb/trunk/include/lldb/Core/ArchSpec.h
lldb/trunk/source/Core/ArchSpec.cpp
lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Author: zturner
Date: Mon Jul 28 11:45:18 2014
New Revision: 214094
URL: http://llvm.org/viewvc/llvm-project?rev=214094view=rev
Log:
Teach LLDB about Windows processes.
This patch creates a simple ProcessWindows process plugin.
The only thing it knows how to do currently is create processes.
Even better would be an std::condition_variable
On Mon, Jul 28, 2014 at 10:30 PM, Matthew Gardiner m...@csr.com wrote:
Hi Shawn,
I use 64-bit linux and I see this issue a lot. It usually manifests itself
as the prompt just not being printed (or perhaps it just gets overwritten)
-
Author: zturner
Date: Wed Jul 30 17:08:17 2014
New Revision: 214351
URL: http://llvm.org/viewvc/llvm-project?rev=214351view=rev
Log:
Disable test on Windows. script print deadlocks on Windows.
Modified:
lldb/trunk/test/functionalities/abbreviation/TestAbbreviations.py
Modified:
I fixed up a few more instances of shell-based globbing. Some of these are
MacOSX only, and this only really matters on Windows, but I figured it's
best to just be consistent and adopt a policy of always use $(wildcard)
for globbing.
On Wed, Jul 30, 2014 at 3:31 PM, David Majnemer
Comment at: CMakeLists.txt:22-26
@@ -21,1 +21,7 @@
+# Determine the native architecture.
+string(TOLOWER ${LLVM_TARGET_ARCH} LLDB_TARGET_ARCH)
+if( LLDB_TARGET_ARCH STREQUAL host )
+ string(REGEX MATCH ^[^-]* LLDB_TARGET_ARCH ${LLVM_HOST_TRIPLE})
+endif ()
+
Assuming you created this diff with git, would it be possible to use -U99
in the future? It helps to be able to browse the rest of the file to get more
context.
Comment at: include/lldb/Host/windows/win32.h:57
@@ -53,2 +56,3 @@
#ifdef LLDB_DISABLE_PYTHON
+#ifdef
I put up a separate patch for the mkstemp thing. If Greg doesn't like it
we can go with this instead.
On Wed, Jul 30, 2014 at 11:38 PM, Zachary Turner ztur...@google.com wrote:
Assuming you created this diff with git, would it be possible to use
-U99 in the future? It helps to be able
Author: zturner
Date: Thu Jul 31 16:03:11 2014
New Revision: 214441
URL: http://llvm.org/viewvc/llvm-project?rev=214441view=rev
Log:
Remove shell-globbing from all test makefiles.
Modified:
lldb/trunk/test/functionalities/fat_archives/Makefile
Author: zturner
Date: Thu Jul 31 16:07:41 2014
New Revision: 214443
URL: http://llvm.org/viewvc/llvm-project?rev=214443view=rev
Log:
Make CMake choose the target architecture according to the build.
Previously, CMake was invoking the test runner and not specifying
what architecture to use when
I actually think a better solution is to just stop building PseudoTerminal
stuff on Windows. That's a larger change, but I suspect I'll do it at some
point in the future.
http://reviews.llvm.org/D4737
___
lldb-commits mailing list
Hi Jim,
This patch implements some of the optimizations to FileSpec requested by
Greg. In particular, normalization no longer does its own copy, and does
the operation in place. Changing Normalize this way required some changes
to function signatures, which trickled down a bit and required me
Author: zturner
Date: Mon Aug 4 18:31:21 2014
New Revision: 214816
URL: http://llvm.org/viewvc/llvm-project?rev=214816view=rev
Log:
Teach ProcessWindows plugin to support stdio i/o redirection.
Modified:
lldb/trunk/source/Plugins/Process/Windows/ProcessWindows.cpp
Modified:
Author: zturner
Date: Wed Aug 6 13:16:26 2014
New Revision: 214984
URL: http://llvm.org/viewvc/llvm-project?rev=214984view=rev
Log:
Creates a socket host object.
This patch moves the logic of many common socket operations into
its own class lldb_private::Socket. It then modifies the
Fixed some more places where tests don't compile on Windows.
http://reviews.llvm.org/D4816
Files:
test/api/multiple-debuggers/multi-process-driver.cpp
test/expression_command/call-restarts/TestCallThatRestarts.py
test/expression_command/timeout/Makefile
Author: zturner
Date: Thu Aug 7 12:33:07 2014
New Revision: 215123
URL: http://llvm.org/viewvc/llvm-project?rev=215123view=rev
Log:
Fix FileSpec to be able to understand Windows paths.
This patch adds the notion of a path syntax to FileSpec. There
are two syntaxes (Posix and Windows) and one
Author: zturner
Date: Thu Aug 7 12:33:36 2014
New Revision: 215124
URL: http://llvm.org/viewvc/llvm-project?rev=215124view=rev
Log:
Optimizations for FileSpec.
Modified:
lldb/trunk/include/lldb/Host/FileSpec.h
lldb/trunk/source/API/SBFileSpec.cpp
.
But, again, I am not sure why atexit is giving you woes - that would
probably be worth looking into
On Aug 7, 2014, at 4:03 PM, Zachary Turner ztur...@google.com wrote:
There were a number of issues related to python shutdown. These issues
appear to be present on every platform, but are benign
Author: zturner
Date: Fri Aug 8 18:54:35 2014
New Revision: 215262
URL: http://llvm.org/viewvc/llvm-project?rev=215262view=rev
Log:
Fix bug causing FileSpec::GetPath() to crash with a null dest.
Modified:
lldb/trunk/source/Host/common/FileSpec.cpp
Modified:
Author: zturner
Date: Mon Aug 11 17:59:50 2014
New Revision: 215405
URL: http://llvm.org/viewvc/llvm-project?rev=215405view=rev
Log:
Remove a few uses of LLDB_DISABLE_POSIX.
This all appears to have been dead, unnecessary code.
Modified:
As part of an effort to make Host not be such a monolithic, catch-all class,
this patch moves file system logic out of Host and into a smaller, more
appropriate class, which is also in the Host layer. More specifically, this
patch makes the following changes:
1) Creates an lldbHostPosix
Closed by commit rL215649 (authored by @zturner).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D4877
Files:
lldb/trunk/include/lldb/Host/Host.h
lldb/trunk/include/lldb/Target/FileAction.h
lldb/trunk/include/lldb/Target/ProcessLaunchInfo.h
lldb/trunk/lldb.xcodeproj/project.pbxproj
Closed by commit rL215674 (authored by @zturner).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D4912
Files:
lldb/trunk/.gitignore
Index: lldb/trunk/.gitignore
===
--- lldb/trunk/.gitignore
+++ lldb/trunk/.gitignore
@@ -28,3
Updated the Xcode project and confirmed that all tests pass on MacOSX and Linux.
Will submit this tomorrow unless there's objections.
http://reviews.llvm.org/D4889
Files:
include/lldb/Host/FileCache.h
include/lldb/Host/FileSystem.h
include/lldb/Host/Host.h
Author: zturner
Date: Thu Aug 14 11:29:15 2014
New Revision: 215654
URL: http://llvm.org/viewvc/llvm-project?rev=215654view=rev
Log:
Modification to clang-format style.
Fixes constructor initializer list and function return type style.
Modified:
lldb/trunk/.clang-format
Modified:
Author: zturner
Date: Thu Aug 14 15:19:57 2014
New Revision: 215674
URL: http://llvm.org/viewvc/llvm-project?rev=215674view=rev
Log:
Update .gitignore for MacOSX
Differential Revision: http://reviews.llvm.org/D4912
Modified:
lldb/trunk/.gitignore
Modified: lldb/trunk/.gitignore
URL:
Author: zturner
Date: Thu Aug 14 11:01:25 2014
New Revision: 215649
URL: http://llvm.org/viewvc/llvm-project?rev=215649view=rev
Log:
Refactor FileAction out of ProcessLaunchInfo.
FileAction was previously a nested class in ProcessLaunchInfo.
This led to some unfortunate style consequences, such
Author: zturner
Date: Fri Aug 15 17:04:21 2014
New Revision: 215775
URL: http://llvm.org/viewvc/llvm-project?rev=215775view=rev
Log:
Move FileSystem functions out of Host and into their own classes.
More specifically, this change can be summarized as follows:
1) Makes an lldbHostPosix library
Author: zturner
Date: Fri Aug 15 17:50:48 2014
New Revision: 215782
URL: http://llvm.org/viewvc/llvm-project?rev=215782view=rev
Log:
Try to fix the Make build
Added:
lldb/trunk/source/Host/posix/Makefile
Modified:
lldb/trunk/source/Host/Makefile
Modified: lldb/trunk/source/Host/Makefile
Author: zturner
Date: Fri Aug 15 18:27:37 2014
New Revision: 215788
URL: http://llvm.org/viewvc/llvm-project?rev=215788view=rev
Log:
Still trying to fix the Make build. Link lldbHostPosix to liblldb
Modified:
lldb/trunk/lib/Makefile
Modified: lldb/trunk/lib/Makefile
URL:
Author: zturner
Date: Mon Aug 18 11:47:33 2014
New Revision: 215901
URL: http://llvm.org/viewvc/llvm-project?rev=215901view=rev
Log:
Fix an issue with source file groupings in the CMake build.
Modified:
lldb/trunk/source/Host/CMakeLists.txt
Modified: lldb/trunk/source/Host/CMakeLists.txt
, and should be part of the workspace.
Usually, the Xcode part of my .gitignore file looks like this:
DerivedData/
*xcuserdata
*.xccheckout
Le 14 août 2014 à 20:01, Zachary Turner ztur...@google.com a écrit :
If someone from Apple could take a look at this I would appreciate it.
First time using
This change implements the beginning of the HostInfo class - a class whose
purpose is to answer queries about the host operating system.
This compiles successfully and passes all tests on Linux, MacOSX, and Windows.
I do not have access to a FreeBSD build machine, so would appreciate help
++11 thread for some stuff as we may be able to
use more of the C++11 standard library as the host layer for common base
classes.
Looks good.
On Aug 18, 2014, at 4:05 PM, Zachary Turner ztur...@google.com wrote:
This change implements the beginning of the HostInfo class - a class
whose
Author: zturner
Date: Tue Aug 19 12:18:38 2014
New Revision: 215993
URL: http://llvm.org/viewvc/llvm-project?rev=215993view=rev
Log:
Fix .clang-format file to adhere to LLDB 140 column limit.
Modified:
lldb/trunk/.clang-format
Modified: lldb/trunk/.clang-format
URL:
Author: zturner
Date: Tue Aug 19 12:18:29 2014
New Revision: 215992
URL: http://llvm.org/viewvc/llvm-project?rev=215992view=rev
Log:
Move some Host logic into HostInfo class.
This patch creates a HostInfo class, a static class used to answer
basic queries about the host platform. As part of
Closed by commit rL215992 (authored by @zturner).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D4963
Files:
lldb/trunk/include/lldb/Core/ArchSpec.h
lldb/trunk/include/lldb/Host/Host.h
lldb/trunk/include/lldb/Host/HostInfo.h
lldb/trunk/include/lldb/Host/HostInfoBase.h
Author: zturner
Date: Tue Aug 19 13:38:53 2014
New Revision: 216000
URL: http://llvm.org/viewvc/llvm-project?rev=216000view=rev
Log:
Add includes needed for FreeBSD.
Modified:
lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp
Modified: lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp
Author: zturner
Date: Wed Aug 20 15:53:05 2014
New Revision: 216123
URL: http://llvm.org/viewvc/llvm-project?rev=216123view=rev
Log:
Revert Avoid global contstructors and place static variables
inside classes as static local variables and remove the static
ivars. Subclasses should use the
This CL was submitted.
http://reviews.llvm.org/D4991
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
It's possible I'm misunderstanding how this class works, or is supposed to
work. Either way, its interface is confusing as written, so perhaps it
needs to be re-thought.
But, if you call FileSpec::SetFile(foo), then my understanding is that foo
represents an arbitrary path. It might be a
Author: zturner
Date: Wed Aug 27 15:15:09 2014
New Revision: 216606
URL: http://llvm.org/viewvc/llvm-project?rev=216606view=rev
Log:
Update LLDB to use LLVM's DynamicLibrary.
LLDB had implemented its own DynamicLibrary class for plugin
support. LLVM has an equivalent mechanism, so this patch
Author: zturner
Date: Wed Aug 27 15:44:26 2014
New Revision: 216612
URL: http://llvm.org/viewvc/llvm-project?rev=216612view=rev
Log:
Fix linker error due to missing static variable instantiation.
Modified:
lldb/trunk/source/Host/posix/HostProcessPosix.cpp
Modified:
PM, Zachary Turner ztur...@google.com wrote:
On Thu, Aug 28, 2014 at 9:42 PM, Jason Molenda jmole...@apple.com wrote:
To take one small example, HostInfo::GetOSBuildString is defined for
three out of the four platforms. And so any generic code that might want
to call this has to do
to achieve, because it's already happening with no warning.
On Fri, Aug 29, 2014 at 9:29 AM, Zachary Turner ztur...@google.com wrote:
I actually think we are agreeing on many of the high-level issues.
However, before I write anymore, I want to mention again that there would
never be code
different
concepts (lldb thread and other process thread) in the same class is not
necessarily what you want to do.
Le 29 août 2014 à 22:14, Zachary Turner ztur...@google.com a écrit :
HostThread is going to replace thread_t in the sense that you should be
able to use HostThread
Author: zturner
Date: Tue Sep 9 17:11:10 2014
New Revision: 217462
URL: http://llvm.org/viewvc/llvm-project?rev=217462view=rev
Log:
Try to fix the FreeBSD build.
Modified:
lldb/trunk/source/Host/freebsd/HostThreadFreeBSD.cpp
lldb/trunk/source/Host/freebsd/ThisThread.cpp
Modified:
Author: zturner
Date: Tue Sep 9 17:39:56 2014
New Revision: 217464
URL: http://llvm.org/viewvc/llvm-project?rev=217464view=rev
Log:
Include the correct headers for kinfo_proc on FreeBSD.
Modified:
lldb/trunk/source/Host/freebsd/HostThreadFreeBSD.cpp
Modified:
Author: zturner
Date: Thu Sep 11 15:26:49 2014
New Revision: 217624
URL: http://llvm.org/viewvc/llvm-project?rev=217624view=rev
Log:
Fix Windows build.
* ssize_t isn't defined by default on Windows.
* New public API files need to be defined in a different file for
Windows.
Modified:
Author: zturner
Date: Thu Sep 11 17:22:16 2014
New Revision: 217632
URL: http://llvm.org/viewvc/llvm-project?rev=217632view=rev
Log:
Update HostProcess to use the same facade pattern as HostThread.
Added:
lldb/trunk/include/lldb/Host/HostNativeProcess.h
Author: zturner
Date: Fri Sep 12 17:38:39 2014
New Revision: 217714
URL: http://llvm.org/viewvc/llvm-project?rev=217714view=rev
Log:
Make ProcessLaunchInfo copyable.
Modified:
lldb/trunk/include/lldb/Target/ProcessLaunchInfo.h
lldb/trunk/source/Target/ProcessLaunchInfo.cpp
Modified:
Author: zturner
Date: Fri Sep 12 18:10:33 2014
New Revision: 217721
URL: http://llvm.org/viewvc/llvm-project?rev=217721view=rev
Log:
Fix incorrect initializer list style.
Modified:
lldb/trunk/source/Target/ProcessLaunchInfo.cpp
Modified: lldb/trunk/source/Target/ProcessLaunchInfo.cpp
URL:
Author: zturner
Date: Fri Sep 19 15:12:32 2014
New Revision: 218148
URL: http://llvm.org/viewvc/llvm-project?rev=218148view=rev
Log:
Make sure to #include atomic when using std::atomic.
Modified:
lldb/trunk/include/lldb/Core/Communication.h
+greg. Any chance you guys are willing to create Phabricator accounts?
Even if you don't use it to submit reviews, it's nice to just be able to
type your name into the website and have it include you in the original
email automatically.
On Fri, Sep 19, 2014 at 1:51 PM, Zachary Turner ztur
Author: zturner
Date: Tue Sep 23 13:32:09 2014
New Revision: 218325
URL: http://llvm.org/viewvc/llvm-project?rev=218325view=rev
Log:
Fix up the HostThread interface, making the interface simpler.
Reviewed by: Greg Clayton
Differential Revision: http://reviews.llvm.org/D5417
Modified:
Comment at: source/Host/common/Host.cpp:978-980
@@ -957,2 +977,5 @@
}
+#else
+error.SetErrorString(Host::LaunchProcessPosixSpawn() not supported on
Android);
+#endif
If launching a process via posix_spawn() isn't supported on Android, then how
*do*
I also want to echo all the comments that I really don't like the #ifdefs
everywhere. I've been working for the past 2 months specifically to get rid of
#ifdefs, so this is like a punch in the stomach :(
http://reviews.llvm.org/D5495
___
I'm not seeing the changes to HostInfoPosix and HostThreadPosix that I
suggested. Are those still coming in a followup?
On Fri, Sep 26, 2014 at 11:59 AM, Tong Shen endlessr...@google.com wrote:
http://reviews.llvm.org/D5495
Files:
include/lldb/Core/IOHandler.h
?
On Fri, Sep 26, 2014 at 1:30 PM, Zachary Turner ztur...@google.com
wrote:
It wasn't made a class instance hierarchy for the same reason that Host
wasn't a class instance to begin with. HostInfo only contains method that
are inherently static. You could make it an instance, but it would
! In D5495#29, @endlessroad wrote:
Add Host{Info, Thread}Android. They cannot directly inherit Host{Info,
Thread}Posix, because that would need linking the base classes, which will
cause linker error (some POSIX functions do not exist on Android)
It didn't occur to me that there would be
Will have a look when I get in later this morning.
On Tue, Sep 30, 2014 at 6:00 AM, Ed Maste ema...@freebsd.org wrote:
On 23 September 2014 14:32, Zachary Turner ztur...@google.com wrote:
Author: zturner
Date: Tue Sep 23 13:32:09 2014
New Revision: 218325
URL: http://llvm.org/viewvc
Author: zturner
Date: Tue Sep 30 11:56:40 2014
New Revision: 218684
URL: http://llvm.org/viewvc/llvm-project?rev=218684view=rev
Log:
Fixup some minor issues with HostProcess.
Modified:
lldb/trunk/source/Host/common/HostProcess.cpp
lldb/trunk/source/Host/posix/HostProcessPosix.cpp
Good question. Logically it seems a little too high level for Host to me.
Conceptually speaking, CFD is just a wrapper around one of any number of
host primitives. For example, it's a wrapper around a file, or a socket,
or a pipe, etc. It just allows you to treat all those things using the
same
Ping again since people are back from vacation. This will go in this
afternoon if there's no objections.
On Fri, Oct 3, 2014 at 2:21 PM, Zachary Turner ztur...@google.com wrote:
Add some comments and fix a few bugs on the error path.
http://reviews.llvm.org/D5608
Files:
include/lldb
Author: zturner
Date: Mon Oct 6 16:23:09 2014
New Revision: 219145
URL: http://llvm.org/viewvc/llvm-project?rev=219145view=rev
Log:
Create a ConnectionGenericFile class for Windows.
This is the first step in getting ConnectionFileDescriptor ported
to Windows. It implements a connection against
Author: zturner
Date: Mon Oct 6 16:22:36 2014
New Revision: 219143
URL: http://llvm.org/viewvc/llvm-project?rev=219143view=rev
Log:
Move ConnectionFileDescriptor to platform-specific Host directory.
As part of getting ConnectionFileDescriptor working on Windows,
there is going to be alot of
Author: zturner
Date: Wed Oct 8 15:59:55 2014
New Revision: 219340
URL: http://llvm.org/viewvc/llvm-project?rev=219340view=rev
Log:
Fix compile error on posix.
Modified:
lldb/trunk/include/lldb/Host/Pipe.h
Modified: lldb/trunk/include/lldb/Host/Pipe.h
URL:
1 - 100 of 328 matches
Mail list logo
