ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:280
@@ -291,1 +279,3 @@
+// Before we try to attach, make sure we aren't already monitoring
something else.
+
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1158
@@ +1157,3 @@
+if (error.Fail() log)
+log-Printf(GDBRemoteCommunicationServerLLGS::%s Failed to
ovyalov added a comment.
Thanks for suggestions - will address them shortly.
http://reviews.llvm.org/D11357
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
ovyalov added inline comments.
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:268
@@ +267,3 @@
+ //In case of MIPS64 target, SI_KERENEL is generated for invalid
64bit address.
+ if (info-si_signo == SIGBUS info-si_code == SI_KERNEL)
+
Author: ovyalov
Date: Mon Jul 20 20:28:22 2015
New Revision: 242753
URL: http://llvm.org/viewvc/llvm-project?rev=242753view=rev
Log:
Fix FileSpec::IsSymlink implementation.
http://reviews.llvm.org/D11356
Modified:
lldb/trunk/include/lldb/Host/FileSpec.h
Author: ovyalov
Date: Mon Jul 20 21:09:42 2015
New Revision: 242757
URL: http://llvm.org/viewvc/llvm-project?rev=242757view=rev
Log:
Resolve DW_AT_comp_dir path if it contains a symlink
http://reviews.llvm.org/D11357
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Users:
ovyalov (Author)
http://reviews.llvm.org/rL242757
http://reviews.llvm.org/D11357
___
lldb-commits mailing
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11321
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11264
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
ovyalov accepted this revision.
ovyalov added a reviewer: ovyalov.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D10887
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D11187
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added reviewers: spyffe, clayborg.
ovyalov added a subscriber: lldb-commits.
Mark TestCModules.py as XFAIL on OSX - http://llvm.org/pr24124
http://reviews.llvm.org/D11206
Files:
test/lang/c/modules/TestCModules.py
Index:
ovyalov added inline comments.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:672
@@ -671,1 +671,3 @@
+auto error = platform_sp-ResolveExecutable (
+module_spec, module_sp, executable_search_paths.IsEmpty() ? nullptr :
ovyalov updated this revision to Diff 29694.
ovyalov added a comment.
Review fixes.
http://reviews.llvm.org/D11163
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
source/Plugins/Platform/Linux/PlatformLinux.cpp
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/tools/lldb-server/lldb-platform.cpp
Users:
ovyalov (Author)
http://reviews.llvm.org/rL242182
http://reviews.llvm.org/D11152
___
lldb-commits mailing list
Author: ovyalov
Date: Tue Jul 14 13:54:52 2015
New Revision: 242182
URL: http://llvm.org/viewvc/llvm-project?rev=242182view=rev
Log:
Fix temp port file path generation in lldb-platform.
http://reviews.llvm.org/D11152
Modified:
lldb/trunk/tools/lldb-server/lldb-platform.cpp
Modified:
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Use target.exec-search-paths setting when resolving executable path for remote
target.
Additionally check for valid module's UUID on host side - if module has valid
UUID we
ovyalov added inline comments.
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:19
@@ -18,2 +18,3 @@
#include lldb/Host/Mutex.h
+#include lldb/Host/MainLoop.h
#include llvm/ADT/StringRef.h
Can you use forward declaration here?
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11065
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/test/functionalities/process_attach/TestProcessAttach.py
Users:
ovyalov (Author)
http://reviews.llvm.org/rL241702
http://reviews.llvm.org/D11013
___
lldb-commits
ovyalov added a reviewer: labath.
ovyalov added a subscriber: lldb-commits.
Ran 5K iterations in debug and release configurations - tests didn't stuck.
Let's give it a try to build bot.
http://reviews.llvm.org/D11013
Files:
test/functionalities/process_attach/TestProcessAttach.py
Index:
ovyalov accepted this revision.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D10957
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Comment at: source/Commands/CommandObjectBugreport.cpp:72
@@ +71,3 @@
+
+char command_buffer[256];
+
I'd defined this buffer before the loop to avoid memory allocation per each
frame.
Comment at:
Author: ovyalov
Date: Thu Jun 25 12:41:41 2015
New Revision: 240660
URL: http://llvm.org/viewvc/llvm-project?rev=240660view=rev
Log:
Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.
http://reviews.llvm.org/D10711
Modified:
lldb/trunk/include/lldb/API/SBFrame.h
AFFECTED FILES
/lldb/trunk/include/lldb/API/SBFrame.h
/lldb/trunk/scripts/interface/SBFrame.i
/lldb/trunk/source/API/SBFrame.cpp
USERS
ovyalov (Author)
http://reviews.llvm.org/rL240660
http://reviews.llvm.org/D10711
EMAIL PREFERENCES
Comment at: cmake/modules/LLDBConfig.cmake:258
@@ +257,3 @@
+
+int main() { return process_vm_readv(0, 0, 0, 0, 0, 0); }
+
Do we need to cast from ssize_t to int?
Comment at: cmake/modules/LLDBConfig.cmake:258
@@ +257,3 @@
+
+int main() { return
Author: ovyalov
Date: Tue Jun 9 20:34:25 2015
New Revision: 239450
URL: http://llvm.org/viewvc/llvm-project?rev=239450view=rev
Log:
Mark TestMultithreaded as XTIMEOUT on Linux.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
It was timed out 3 times for last 5 hours.
On Jun 9, 2015 6:46 PM, Vince Harron vi...@nethacker.com wrote:
Any indication of frequency?
On Jun 9, 2015 6:44 PM, Oleksiy Vyalov ovya...@google.com wrote:
Author: ovyalov
Date: Tue Jun 9 20:34:25 2015
New Revision: 239450
URL: http://llvm.org
Author: ovyalov
Date: Fri May 29 17:45:47 2015
New Revision: 238623
URL: http://llvm.org/viewvc/llvm-project?rev=238623view=rev
Log:
Leave OS type and vendor as unspecified unknowns.
http://reviews.llvm.org/D10080
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
Modified:
Author: ovyalov
Date: Thu May 28 12:42:48 2015
New Revision: 238442
URL: http://llvm.org/viewvc/llvm-project?rev=238442view=rev
Log:
Refactor AdbClient and make PlatformAndroid::GetFile to use adb pull.
http://reviews.llvm.org/D10082
Modified:
Author: ovyalov
Date: Fri May 22 18:14:39 2015
New Revision: 238068
URL: http://llvm.org/viewvc/llvm-project?rev=238068view=rev
Log:
Use target's SIGSTOP and SIGINT when making decision about continue after async
packet.
http://reviews.llvm.org/D9857
Modified:
Author: ovyalov
Date: Mon May 11 21:04:26 2015
New Revision: 237084
URL: http://llvm.org/viewvc/llvm-project?rev=237084view=rev
Log:
Apply LLDB_API modifier to SBPlatform and SBPlatformShellCommand.
Modified:
lldb/trunk/include/lldb/API/SBPlatform.h
Modified:
Author: ovyalov
Date: Tue May 5 17:02:56 2015
New Revision: 236549
URL: http://llvm.org/viewvc/llvm-project?rev=236549view=rev
Log:
Mark TestMultithreaded.test_sb_api_listener_resume as XFAIL with gcc 4.8 and
higher.
Modified:
lldb/trunk/test/api/multithreaded/TestMultithreaded.py
Author: ovyalov
Date: Mon May 4 10:20:25 2015
New Revision: 236425
URL: http://llvm.org/viewvc/llvm-project?rev=236425view=rev
Log:
Mark TestTypedefArray as XFAIL with Gcc.
Modified:
lldb/trunk/test/functionalities/data-formatter/typedef_array/TestTypedefArray.py
Modified:
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2135
@@ -2135,8 +2134,3 @@
NotifyThreadCreateStopped (tid);
-m_coordinator_up-RequestThreadResume (tid,
- [=](lldb::tid_t
Author: ovyalov
Date: Tue Mar 31 21:30:17 2015
New Revision: 233780
URL: http://llvm.org/viewvc/llvm-project?rev=233780view=rev
Log:
Fix ForwardPortWithAdb - update device_id variable if Android device has been
found.
Modified:
Please see my comments.
Comment at: source/Plugins/Platform/Android/AdbClient.h:33-37
@@ -31,4 +32,7 @@
+static Error
+CreateByDeviceID (const char* device_id, AdbClient adb);
+
AdbClient () = default;
explicit AdbClient (const std::string device_id);
AFFECTED FILES
/lldb/trunk/include/lldb/Target/Platform.h
/lldb/trunk/source/Target/Platform.cpp
/lldb/trunk/source/Utility/ModuleCache.cpp
/lldb/trunk/source/Utility/ModuleCache.h
USERS
ovyalov (Author)
http://reviews.llvm.org/rL233136
http://reviews.llvm.org/D8557
EMAIL
Author: ovyalov
Date: Mon Mar 23 16:03:02 2015
New Revision: 233021
URL: http://llvm.org/viewvc/llvm-project?rev=233021view=rev
Log:
Move ADB communications to AdbClient class - to make it accessible by other
components.
http://reviews.llvm.org/D8535
Added:
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:71-75
@@ +70,7 @@
+response.split (devices, \n);
+if (devices.empty ())
+{
+error.SetErrorString (Wrong number of devices returned from ADB);
+return error;
+}
+
tberghammer
Fixed accordingly to suggestions.
Please take another look.
Thank you.
http://reviews.llvm.org/D8535
Files:
source/Plugins/Platform/Android/AdbClient.cpp
source/Plugins/Platform/Android/AdbClient.h
source/Plugins/Platform/Android/CMakeLists.txt
Comment at: source/Host/linux/HostInfoLinux.cpp:225
@@ -224,3 +224,3 @@
bool
-HostInfoLinux::ComputeSharedLibraryDirectory(FileSpec file_spec)
{
Do we need to keep this method around since
HostInfoPosix::ComputeSupportExeDirectory uses
Should be fixed in http://reviews.llvm.org/rL233041
USERS
ovyalov (Author)
ki.stfu (Auditor)
http://reviews.llvm.org/rL233021
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lgtm
http://reviews.llvm.org/D8570
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Comment at: source/API/SystemInitializerFull.cpp:1
@@ +1,2 @@
+//===-- SystemInitializerFull.cpp ---*- C++
-*-===//
+//
Could we keep all initializers within source/Initialization folder?
Comment at:
LGTM
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8395
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hi clayborg, vharron,
Make ModuleList::GetSharedModule to use module_search_paths parameter - so,
setting target.exec-search-paths can be used in order to lookup a module.
http://reviews.llvm.org/D8365
Files:
source/Core/ModuleList.cpp
Index: source/Core/ModuleList.cpp
LGTM
http://reviews.llvm.org/D8296
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Comment at: source/Host/common/Host.cpp:194
@@ -176,2 +193,3 @@
// Wait for all child processes
-#if !defined(__ANDROID__) !defined(__ANDROID_NDK__)
+#ifdef __linux__
+if (g_usr1_signal_thread == ::pthread_self())
I'd rather put this snippet into
Hi clayborg, vharron,
Pass a full executable path within name response field for q*ProcessInfo
commands so lldb host can get a full executable path for a process.
Client side already expects this field to be a full path -
process_info.GetExecutableFile().SetFile (value.c_str(), false); -
http://stackoverflow.com/questions/5103443/how-to-check-what-shared-library-is-loaded-at-run-time
Potentially, we may add optional pid request field to qModuleInfo and then try
either to call remotely dlopen(NULL, RTLD_NOW) in a zygote process (it might be
tricky since this requires dl library
AFFECTED FILES
/lldb/trunk/include/lldb/Core/ModuleSpec.h
/lldb/trunk/include/lldb/Host/HostInfoBase.h
/lldb/trunk/include/lldb/Target/Platform.h
/lldb/trunk/include/lldb/lldb-enumerations.h
/lldb/trunk/lldb.xcodeproj/project.pbxproj
/lldb/trunk/source/Core/Debugger.cpp
lgtm
REPOSITORY
rL LLVM
Comment at: test/tools/lldb-server/lldbgdbserverutils.py:89
@@ +88,3 @@
+
+_LOG_LINE_REGEX = re.compile(r'^(lldb-gdbserver|debugserver)\s+\s*(\d+)' +
+'\s+(read|send)\s+packet:\s+(.+)$')
s/lldb-gdbserver/lldb-server
Thank you for comments and suggestions - please see my comments inline:
In http://reviews.llvm.org/D8037#133641, @clayborg wrote:
See my inline comments and let me know what you think. I think it would be
nice if we had a global directory that we used for all locally cached files.
The
Comment at: test/settings/quoting/TestQuoting.py:74
@@ -71,1 +73,3 @@
+dst_file_spec = lldb.SBFileSpec('stdout.txt', False)
+platform.Get(src_file_spec, dst_file_spec);
with open('stdout.txt', 'r') as f:
chaoren wrote:
ovyalov wrote:
Please see my comments.
Comment at: test/functionalities/watchpoint/hello_watchlocation/main.cpp:20
@@ -19,3 +19,3 @@
pthread_t g_thread_3 = NULL;
-
+pthread_barrier_t barrier;
char *g_char_ptr = NULL;
Please follow the existing naming convention here -
In http://reviews.llvm.org/D7893#130145, @zturner wrote:
I think i get it, when you said inferior it made me think you were trying
to return the triple of the remote.
Sorry for confusion - I mentioned inferior here as rather a test case that
allowed me to verify this change works properly
Author: ovyalov
Date: Tue Feb 24 16:23:39 2015
New Revision: 230390
URL: http://llvm.org/viewvc/llvm-project?rev=230390view=rev
Log:
Fix qLaunchGDBServer packet parsing in GDBRemoteCommunicationServerPlatform.
Modified:
- Added file_offset, file_size response fields for qModuleInfo request
- Made MD5 computation functions to take offset, length parameters to get MD%
from a file's slice.
Please take another look.
Thank you.
http://reviews.llvm.org/D7709
Files:
docs/lldb-gdb-remote.txt
Could you rename test/tools/lldb-gdbserver to test/tools/lldb-server as well?
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7545
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
Looks good to me - could you check whether this test passes remotely
Linux-Linux?
http://reviews.llvm.org/D7743
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Author: ovyalov
Date: Thu Feb 19 11:58:04 2015
New Revision: 229875
URL: http://llvm.org/viewvc/llvm-project?rev=229875view=rev
Log:
Prevent LLGS from crashing when exiting - make NativeProcessLinux to wait
until ThreadStateCoordinator is fully stopped before entering
~NativeProcessLinux.
://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Oleksiy Vyalov | Software Engineer | ovya...@google.com
Hi,
please see my comments inline:
In http://reviews.llvm.org/D7692#125375, @labath wrote:
Greetings,
I have been following this discussion, and would like to add my 2 cents. I'll
start with my thoughts on virtual functions.
On 17 February 2015 at 18:44, Oleksiy Vyalov ovya
Hi vharron, tberghammer,
ninja-check-lldb with LLGS_LOCAL on produces plenty of core dumps - SIGSEGVs
happen in llgs by following reasons:
- NativeProcessLinux doesn't join on ThreadStateCoordinator thread;
- NativeProcessLinux initiates ThreadStateCoordinator termination from its own
Author: ovyalov
Date: Sun Feb 15 18:04:19 2015
New Revision: 229346
URL: http://llvm.org/viewvc/llvm-project?rev=229346view=rev
Log:
Extract SBAttachInfo into own set of files - SBAttachInfo.h, SBAttachInfo.cpp
and SBAttachInfo.i.
Added:
lldb/trunk/include/lldb/API/SBAttachInfo.h
Thanks for suggestion - added Target::Attach method and wired it with
SBTarget::Attach* methods and CommandObjectProcessAttach.
Please take another look.
http://reviews.llvm.org/D7471
Files:
include/lldb/Target/Target.h
source/API/SBTarget.cpp
source/Commands/CommandObjectProcess.cpp
Hi vharron, clayborg,
SBTarget::Attach, SBTarget::AttachToProcessWithID and
SBTarget::AttachToProcessWithName use the same core logic - extracted it into
new static method SBTarget::AttachToProcess.
Made SBTarget::AttachToProcess to support remote attach if a platform is
available and can
Author: ovyalov
Date: Thu Feb 5 10:29:12 2015
New Revision: 228307
URL: http://llvm.org/viewvc/llvm-project?rev=228307view=rev
Log:
Fix warning about the use of mktemp and make platform agnostic by adding and
using PipeBase::CreateWithUniqueName - on behalf of flackr.
lgtm
http://reviews.llvm.org/D7440
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Wed Feb 4 17:19:15 2015
New Revision: 228230
URL: http://llvm.org/viewvc/llvm-project?rev=228230view=rev
Log:
Extend SBPlatform with capability to launch/terminate a process remotely.
Integrate this change into test framework in order to spawn processes on a
remote
Please see my comments.
Comment at: include/lldb/API/SBPlatform.h:106-134
@@ -102,2 +105,31 @@
+class SBPlatformLaunchCommand
+{
+public:
+SBPlatformLaunchCommand (const char* command,
+ const char* working_dir,
+
Friendly ping.
http://reviews.llvm.org/D7263
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hi clayborg, vharron,
Make process attach command to support attaching to remote process in case if
selected platform allows.
If selected platform can debug a process use Platform::Attach otherwise
fallback to Process::Attach.
Pass hijack_listener down to Platform::Attach in order to control
I reverted TestProcessAttach changes and merged with
http://reviews.llvm.org/D7358 - no regressions noticed for local test runs on
Ubuntu and OSX, remote Linux-Linux execution of TestProcessAttach works fine.
Please take another look.
Thank you!
http://reviews.llvm.org/D7263
Files:
Hi clayborg,
When running tests on OSX I see a lot of firewall warnings about allowing lldb
and some test binaries to listen for incoming connections - so, I have to turn
firewall off.
With this CL in the test run should be silent with enabled firewall.
Use lldb_codesign certificate to sign
REPOSITORY
rL LLVM
Comment at: source/Target/Platform.cpp:1272
@@ +1271,3 @@
+error = source_file.Read(buffer_sp-GetBytes(), bytes_read);
+if (bytes_read)
+{
Do we need to check for error here?
Comment at:
Author: ovyalov
Date: Tue Jan 13 17:19:40 2015
New Revision: 225849
URL: http://llvm.org/viewvc/llvm-project?rev=225849view=rev
Log:
Extend PipePosix with support for named pipes/timeout-based IO and integrate it
with GDBRemoteCommunication / lldb-gdbserver.
http://reviews.llvm.org/D6954
Hi zturner, clayborg,
Make PipePosix to support next operations:
- Create a named pipe.
- Open reader and writer sides of a named pipe.
- Timeout-based Read and Write operations.
- Added Delete call to PipeBase interface since named pipe removal differs
for POSIX and Windows pipes.
Comment at: include/lldb/Host/PipeBase.h:32
@@ -30,1 +31,3 @@
+Error OpenAsWriter(llvm::StringRef name, bool child_process_inherit);
+virtual Error OpenAsWriterWithTimeout(llvm::StringRef name, bool
child_process_inherit, const std::chrono::microseconds timeout) = 0;
REPOSITORY
rL LLVM
Comment at: /Users/vharron/ll/svn/lldb/source/Utility/UriParser.cpp:42
@@ -42,1 +41,3 @@
+char* end = nullptr;
int port_tmp = strtoul(port_buf, end, 10);
+if (*end != 0 || port_tmp 65535)
You may define port_tmp as auto instead
REPOSITORY
rL LLVM
http://reviews.llvm.org/D6919
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hi zturner, jingham,
OptionValueChar.cpp doesn't exist in LLDB XCode project file that is causing
OSX build to fail.
http://reviews.llvm.org/D6941
Files:
lldb.xcodeproj/project.pbxproj
Index: lldb.xcodeproj/project.pbxproj
===
LGTM
REPOSITORY
rL LLVM
Comment at: source/Utility/UriParser.cpp:36
@@ +35,3 @@
+bool ok = false;
+ if (4==sscanf(uri, %99[^:/]://%255[^/:]:%[^/]/%2047s, scheme_buf,
hostname_buf, port_buf, path_buf+1)) { ok = true; }
+else if (3==sscanf(uri,
Author: ovyalov
Date: Tue Jan 6 19:28:37 2015
New Revision: 225332
URL: http://llvm.org/viewvc/llvm-project?rev=225332view=rev
Log:
Make DynamicLoaderPOSIXDYLD::DidAttach to deduce a target executable by pid if
no executable hasn't been assigned to a target so far.
Looks good - I ran your patch on Ubuntu, no regression.
Just minor things.
Comment at: include/lldb/Host/posix/PipePosix.h:34
@@ -49,10 +33,3 @@
-int
-GetReadFileDescriptor() const;
-
-int
-GetWriteFileDescriptor() const;
-
-// Close both
Author: ovyalov
Date: Tue Dec 9 19:27:28 2014
New Revision: 223901
URL: http://llvm.org/viewvc/llvm-project?rev=223901view=rev
Log:
Add D request handler to GDBRemoteCommunicationServer in order to support
detach from inferior.
Modified:
! In D6538#8, @zturner wrote:
I thought about something like that too, but then I wondered if it's really
necessary. In Windows we need to open a named pipe internally even when
the user requests anonymous pipe, because a named pipe is the only way to
achieve something like select. So that
Author: ovyalov
Date: Mon Dec 1 17:21:18 2014
New Revision: 223091
URL: http://llvm.org/viewvc/llvm-project?rev=223091view=rev
Log:
Fix several test failures on Linux/FreeBSD caused by compiler configuration and
invalid environment - make lldbtest.registerSharedLibrariesWithTarget to
support
Author: ovyalov
Date: Wed Nov 26 18:32:54 2014
New Revision: 222862
URL: http://llvm.org/viewvc/llvm-project?rev=222862view=rev
Log:
Refactor SocketAddress::getaddrinfo - avoid calling IsValid if ::getaddrinfo
has failed.
Otherwise, IsValid crashes on assertation in GetFamilyLength.
Modified:
Author: ovyalov
Date: Fri Nov 21 10:18:57 2014
New Revision: 222541
URL: http://llvm.org/viewvc/llvm-project?rev=222541view=rev
Log:
Extend PipePosix with child_processes_inherit support - to control whether pipe
handles should be inherited by a child process.
http://reviews.llvm.org/D6348
Author: ovyalov
Date: Wed Nov 19 12:27:45 2014
New Revision: 222372
URL: http://llvm.org/viewvc/llvm-project?rev=222372view=rev
Log:
Add test for denied process attach by pid and fix found bugs in
Process/ProcessPOSIX.cpp
and FreeBSD/ProcessMonitor.
http://reviews.llvm.org/D6240
Added:
Removed unneeded file from patch.
http://reviews.llvm.org/D6240
Files:
source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
source/Plugins/Process/FreeBSD/ProcessMonitor.h
source/Plugins/Process/POSIX/ProcessPOSIX.cpp
source/Target/Process.cpp
Fixed according to your suggestions.
Thank you for the review!
http://reviews.llvm.org/D6240
Files:
source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
source/Plugins/Process/FreeBSD/ProcessMonitor.h
source/Plugins/Process/POSIX/ProcessPOSIX.cpp
source/Target/Process.cpp
Author: ovyalov
Date: Mon Nov 17 16:16:42 2014
New Revision: 222182
URL: http://llvm.org/viewvc/llvm-project?rev=222182view=rev
Log:
Fix broken Linux build after signature change of ResolveExecutable.
Modified:
lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp
Author: ovyalov
Date: Mon Nov 17 16:42:28 2014
New Revision: 222184
URL: http://llvm.org/viewvc/llvm-project?rev=222184view=rev
Log:
Fix broken NativeProcessLinux.cpp after signature change of ResolveExecutable.
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp
Friendly ping.
http://reviews.llvm.org/D6158
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Thank you for the review!
Shawn, could you help with submitting this CL if it looks good to you?
http://reviews.llvm.org/D6158
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
in 5.050s
As I can see it might be due test/lldbtest.py modification at r221402.
Thank you.
--
Oleksiy Vyalov | Software Engineer | ovya...@google.com
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb
Greg, please let me know whether it's okay to leave combination of close and
suppress file actions here.
Thank you.
http://reviews.llvm.org/D6105
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
1 - 100 of 103 matches
Mail list logo
