Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

nitesh.jain added a comment. In https://reviews.llvm.org/D23802#528804, @labath wrote: > Thanks for the heads up. I'll need to give this some thought. I've pulled the > change out until I can figure out what to do. > > BTW, have you guys considered putting up a mips buildbot to detect these > k

Re: [Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

Ahh right, in that case I can commit it in the morning unless someone else beats me to it. On Tue, Aug 30, 2016 at 6:55 PM Taras Tsugrii wrote: > Thanks for the review Zachary, but I don’t have commit privileges, so I > hope that someone can commit the change for me. > > > > *From: *Zachary Turn

Re: [Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

Thanks for the review Zachary, but I don’t have commit privileges, so I hope that someone can commit the change for me. From: Zachary Turner Date: Tuesday, August 30, 2016 at 6:52 PM To: "reviews+d24064+public+13175c1cba5ef...@reviews.llvm.org" , Taras Tsugrii Cc: "lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

Looks good, feel free to commit without review when you're fixing a build On Tue, Aug 30, 2016 at 4:57 PM Taras Tsugrii wrote: > wttsugrii created this revision. > wttsugrii added a reviewer: zturner. > wttsugrii added a subscriber: lldb-commits. > > > https://github.com/llvm-mirror/lldb/commit/e

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24062: Removed warnOnFailure flag for the step for running NDK update script.

jesikmin created this revision. jesikmin added reviewers: chying, gkistanova. jesikmin added a subscriber: lldb-commits. Removed warnOnFailure flag for the step for running NDK update script. https://reviews.llvm.org/D24062 Files: zorg/buildbot/builders/LLDBBuilder.py Index: zorg/buildbot/bui

Re: [Lldb-commits] [PATCH] D24062: Removed warnOnFailure flag for the step for running NDK update script.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280177: Removed warnOnFailure flag for the step for running NDK update script. (authored by jesikmin). Changed prior to commit: https://reviews.llvm.org/D24062?vs=69780&id=69782#toc Repository: rL LL

Re: [Lldb-commits] [PATCH] D24062: Removed warnOnFailure flag for the step for running NDK update script.

jesikmin updated this revision to Diff 69780. jesikmin added a comment. Added haltOnFaulure=False flag. https://reviews.llvm.org/D24062 Files: zorg/buildbot/builders/LLDBBuilder.py Index: zorg/buildbot/builders/LLDBBuilder.py ==

[Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

wttsugrii created this revision. wttsugrii added a reviewer: zturner. wttsugrii added a subscriber: lldb-commits. https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308 greatly improved an API, but missed one more occurence of legacy usage. This leads to: if (extrac

Re: [Lldb-commits] [PATCH] D24062: Removed warnOnFailure flag for the step for running NDK update script.

chying accepted this revision. chying added a comment. This revision is now accepted and ready to land. looks good. https://reviews.llvm.org/D24062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

You can breathe again :-) > On Aug 30, 2016, at 2:41 PM, Zachary Turner wrote: > > Ok, I've already started. Don't let me down, my life is on the line here :) > > On Tue, Aug 30, 2016 at 2:40 PM Enrico Granata > wrote: > The plan is definitely to have one > > I am

Re: [Lldb-commits] [PATCH] D24062: Removed warnOnFailure flag for the step for running NDK update script.

chying added a comment. Could you also set haltOnFailure=False, so that build continues if this step fails? https://reviews.llvm.org/D24062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] r280173 - Rename the test class

Author: enrico Date: Tue Aug 30 18:00:52 2016 New Revision: 280173 URL: http://llvm.org/viewvc/llvm-project?rev=280173&view=rev Log: Rename the test class Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py Modified

[Lldb-commits] [lldb] r280172 - Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider

Author: enrico Date: Tue Aug 30 18:00:02 2016 New Revision: 280172 URL: http://llvm.org/viewvc/llvm-project?rev=280172&view=rev Log: Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider This class enables one to easily write a synthetic child provider by writing a class t

[Lldb-commits] [lldb] r280166 - Teach ValueObject::ReadPointedString how to read char[] in host memory

Author: enrico Date: Tue Aug 30 16:33:47 2016 New Revision: 280166 URL: http://llvm.org/viewvc/llvm-project?rev=280166&view=rev Log: Teach ValueObject::ReadPointedString how to read char[] in host memory Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/Value

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

Ok, I've already started. Don't let me down, my life is on the line here :) On Tue, Aug 30, 2016 at 2:40 PM Enrico Granata wrote: > The plan is definitely to have one > > I am not done yet with being ready to use this though; the wait should be > short enough that you can hold your breath throu

[Lldb-commits] [lldb] r280164 - Fix a typo/thinko - this was generating the wrong kind of array

Author: enrico Date: Tue Aug 30 16:33:29 2016 New Revision: 280164 URL: http://llvm.org/viewvc/llvm-project?rev=280164&view=rev Log: Fix a typo/thinko - this was generating the wrong kind of array Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/Clan

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

The plan is definitely to have one I am not done yet with being ready to use this though; the wait should be short enough that you can hold your breath through it :-) > On Aug 30, 2016, at 2:29 PM, Zachary Turner wrote: > > Is there going to be a test for this? > > On Tue, Aug 30, 2016 at 1:4

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

Is there going to be a test for this? On Tue, Aug 30, 2016 at 1:48 PM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: enrico > Date: Tue Aug 30 15:39:58 2016 > New Revision: 280151 > > URL: http://llvm.org/viewvc/llvm-project?rev=280151&view=rev > Log: > Add SBType

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner updated this revision to Diff 69750. zturner added a comment. Fixed a few build errors on Linux. Test suite is running right now, but it's taking a long time so it may be hung (on the other hand, I actually don't remember the last time I had a successful test run on Linux, even without

[Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

Author: enrico Date: Tue Aug 30 15:39:58 2016 New Revision: 280151 URL: http://llvm.org/viewvc/llvm-project?rev=280151&view=rev Log: Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type This is currently only implemented for the clang-based T

[Lldb-commits] [lldb] r280139 - A few minor stylistic cleanups in StringExtractor.

Author: zturner Date: Tue Aug 30 14:47:05 2016 New Revision: 280139 URL: http://llvm.org/viewvc/llvm-project?rev=280139&view=rev Log: A few minor stylistic cleanups in StringExtractor. Makes Peek() return a StringRef instead of a const char*. This leads to a few callers of Peek() being able to b

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner updated this revision to Diff 69741. zturner added a comment. Rebased after submitting all local changes. This should apply cleanly on top of LLDB r280139. https://reviews.llvm.org/D24013 Files: include/lldb/Core/Event.h include/lldb/Core/RegularExpression.h include/lldb/Utility

[Lldb-commits] [lldb] r280137 - Use llvm to do endian conversions.

Author: zturner Date: Tue Aug 30 14:28:01 2016 New Revision: 280137 URL: http://llvm.org/viewvc/llvm-project?rev=280137&view=rev Log: Use llvm to do endian conversions. LLDB was rolling its own endian conversion code, but functions to do this already exist in LLVM. While the code was probably co

[Lldb-commits] [lldb] r280124 - Add a few more unit tests for StringExtractor.

Author: zturner Date: Tue Aug 30 13:12:18 2016 New Revision: 280124 URL: http://llvm.org/viewvc/llvm-project?rev=280124&view=rev Log: Add a few more unit tests for StringExtractor. This is a NFC that adds more unit test coverage of the GetHex*** functions as well as the functions to extract numbe

[Lldb-commits] [lldb] r280123 - Convert some StringExtractor functions to accept MutableArrayRefs.

Author: zturner Date: Tue Aug 30 13:12:11 2016 New Revision: 280123 URL: http://llvm.org/viewvc/llvm-project?rev=280123&view=rev Log: Convert some StringExtractor functions to accept MutableArrayRefs. MutableArrayRef is essentially a safer version of passing around (T*, length) pairs and provides

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

> On Aug 30, 2016, at 6:32 AM, Pavel Labath wrote: > > I think we should move the new file away from source/Utility. If it's > supposed to be used by debugserver only, we probably should move it to > tools/debugserver/source ? Right now, debugservers cmake file contains > a hack to be able to in

Re: [Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rL280102: Remove mention of autoconf from the build instructions (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D24025?vs=69668&id=69701#toc Repository: rL LLVM https://r

[Lldb-commits] [lldb] r280102 - Remove mention of autoconf from the build instructions

Author: tberghammer Date: Tue Aug 30 10:32:52 2016 New Revision: 280102 URL: http://llvm.org/viewvc/llvm-project?rev=280102&view=rev Log: Remove mention of autoconf from the build instructions autoconf+make have been removed from LLVM and LLDB ~6month ago. We shouldn't advertise it on the website

Re: [Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! https://reviews.llvm.org/D24025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

labath added a comment. Thanks for the heads up. I'll need to give this some thought. I've pulled the change out until I can figure out what to do. BTW, have you guys considered putting up a mips buildbot to detect these kinds of things? Repository: rL LLVM https://reviews.llvm.org/D23802

[Lldb-commits] [lldb] r280088 - Revert "gdb-remote: Make the sequence mutex non-recursive"

Author: labath Date: Tue Aug 30 08:56:11 2016 New Revision: 280088 URL: http://llvm.org/viewvc/llvm-project?rev=280088&view=rev Log: Revert "gdb-remote: Make the sequence mutex non-recursive" This reverts commit r279725 as it breaks "dynamic register size" feature of mips. Modified: lldb/tr

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

I've seen that one. What kind of changes do you have in mind? I am not sure how these things are related, as the StdString version is already being used only by debugserver (*), and you don't plan to make changes to it (afaik). (*) $ git grep -l -w StdStringExtractor include/lldb/Utility/StdString

Re: [Lldb-commits] [lldb] r280074 - Fix fallout from the GetNameColonValue() refactor (r280000)

Thanks, sorry about that On Tue, Aug 30, 2016 at 4:25 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Tue Aug 30 06:17:00 2016 > New Revision: 280074 > > URL: http://llvm.org/viewvc/llvm-project?rev=280074&view=rev > Log: > Fix fallout from the GetNa

Re: [Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

Looks good On Tue, Aug 30, 2016 at 5:38 AM Tamas Berghammer wrote: > tberghammer created this revision. > tberghammer added reviewers: jingham, zturner. > tberghammer added a subscriber: lldb-commits. > > Remove mention of autoconf from the build instructions > > autoconf+make have been removed f

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

Yes, there was a thread on lldb dev about it. After i get all the changes in to the newer one we can move the old one out On Tue, Aug 30, 2016 at 6:32 AM Pavel Labath wrote: > I think we should move the new file away from source/Utility. If it's > supposed to be used by debugserver only, we proba

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

I think we should move the new file away from source/Utility. If it's supposed to be used by debugserver only, we probably should move it to tools/debugserver/source ? Right now, debugservers cmake file contains a hack to be able to include these, so by doing that we will remove that as well. Thou

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

Sorry, it's based on a few patches i have locally that I didn't put up for review but can't commit yet On Tue, Aug 30, 2016 at 6:13 AM Pavel Labath wrote: > labath added a comment. > > Which revision is this patch against? It does not seem to apply cleanly to > trunk for me. Could you try running

[Lldb-commits] [lldb] r280087 - Fix darwin cmake build for r279997

Author: labath Date: Tue Aug 30 08:18:46 2016 New Revision: 280087 URL: http://llvm.org/viewvc/llvm-project?rev=280087&view=rev Log: Fix darwin cmake build for r279997 Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt UR

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

labath added a comment. Which revision is this patch against? It does not seem to apply cleanly to trunk for me. Could you try running the test suite on linux or mac as well, as the last StringRef change left things in a pretty broken state there (you are changing code which is pretty-much unus

[Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

tberghammer created this revision. tberghammer added reviewers: jingham, zturner. tberghammer added a subscriber: lldb-commits. Remove mention of autoconf from the build instructions autoconf+make have been removed from LLVM and LLDB ~6month ago. We shouldn't advertise it on the website as a val

Re: [Lldb-commits] [PATCH] D23948: Remove unused variable

hhellyer accepted this revision. hhellyer added a comment. This revision is now accepted and ready to land. Looks good, thanks. https://reviews.llvm.org/D23948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] r280074 - Fix fallout from the GetNameColonValue() refactor (r280000)

Author: labath Date: Tue Aug 30 06:17:00 2016 New Revision: 280074 URL: http://llvm.org/viewvc/llvm-project?rev=280074&view=rev Log: Fix fallout from the GetNameColonValue() refactor (r28) This fixes the linux test suite. Modified: lldb/trunk/source/Interpreter/Args.cpp lldb/trunk/s

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

nitesh.jain added a comment. Forgot to mention that this case has been observed for MIPS architecture. Since for MIPS, the floating point register size is calculated at runtime. -NJ Repository: rL LLVM https://reviews.llvm.org/D23802 ___ lldb-c

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

nitesh.jain added inline comments. Comment at: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:131 @@ +130,3 @@ + +GDBRemoteClientBase::Lock lock(gdb_comm, false); +if (!lock) Hi labath, This patch cause deadlock when we try to