[Lldb-commits] [lldb] r300810 - Add extra logging for when lldb is looking for kernels and kexts.

Author: jmolenda Date: Wed Apr 19 21:02:25 2017 New Revision: 300810 URL: http://llvm.org/viewvc/llvm-project?rev=300810=rev Log: Add extra logging for when lldb is looking for kernels and kexts. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp Modified:

[Lldb-commits] [PATCH] D32137: [Utility] Placate another GCC warning

sas accepted this revision. sas added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp:59 + assert(m_num_registers == + static_cast(m_registers_count[gpr_registers_count] + +

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

krytarowski added a comment. Demo: http://netbsd.org/~kamil/lldb/firefox-core.typescript Replay: script -p ./firefox-core.typescript BSD `script`(1) is incompatible with the GNU one, so I prepared a quick port to Linux: http://netbsd.org/~kamil/lldb/nbscript.c `gcc nbscript.c -lutil -o

[Lldb-commits] [lldb] r300785 - Fix !N and !-N commands and add a test case.

Author: jingham Date: Wed Apr 19 18:21:04 2017 New Revision: 300785 URL: http://llvm.org/viewvc/llvm-project?rev=300785=rev Log: Fix !N and !-N commands and add a test case. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/history/

[Lldb-commits] [PATCH] D32137: [Utility] Placate another GCC warning

davide added a comment. Reference for the future (http://www.open-std.org/jtc1/sc22/open/n2356/conv.html [conv.prom1]) https://reviews.llvm.org/D32137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32137: [Utility] Placate another GCC warning

davide added a subscriber: nlewycky. davide added a comment. And I was wrong. @nlewycky explained on IRC: 14:23 < nlewycky> gcc is correct, in 'char + char' each char gets promoted to 'int' first then summed, then you've got an unsigned int == int comparison 14:23 < nlewycky> uint8_t and

[Lldb-commits] [PATCH] D32137: [Utility] Placate another GCC warning

davide added a comment. I reduced it: https://gist.github.com/dcci/01c10b405041fa8d139a4f71aec102f7 https://reviews.llvm.org/D32137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r300733 - Add CopyDiagnostic to the DiagnosticManager.

Author: jingham Date: Wed Apr 19 13:56:44 2017 New Revision: 300733 URL: http://llvm.org/viewvc/llvm-project?rev=300733=rev Log: Add CopyDiagnostic to the DiagnosticManager. From Gregor Milos (gmi...@apple.com), for: https://reviews.llvm.org/D32078 Modified:

Re: [Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

On Wed, Apr 19, 2017 at 11:10 AM, Jim Ingham wrote: > We've had a couple of cases of "dead" code which turned out to be the > llvm.org side of generic behavior for which Swift was the only current > specific implementation. So while I agree, little single functions that >

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300729: [Utility/StringLexer] Remove dead code. (authored by davide). Changed prior to commit: https://reviews.llvm.org/D32148?vs=95519=95788#toc Repository: rL LLVM https://reviews.llvm.org/D32148

[Lldb-commits] [lldb] r300729 - [Utility/StringLexer] Remove dead code.

Author: davide Date: Wed Apr 19 13:18:25 2017 New Revision: 300729 URL: http://llvm.org/viewvc/llvm-project?rev=300729=rev Log: [Utility/StringLexer] Remove dead code. Differential Revision: https://reviews.llvm.org/D32148 Modified: lldb/trunk/include/lldb/Utility/StringLexer.h

[Lldb-commits] [PATCH] D32184: Teach RenderScriptRuntime about changed context representation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300727: Teach RenderScriptRuntime about changed context representation. (authored by dgross). Changed prior to commit: https://reviews.llvm.org/D32184?vs=95609=95787#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

We've had a couple of cases of "dead" code which turned out to be the llvm.org side of generic behavior for which Swift was the only current specific implementation. So while I agree, little single functions that aren't used anywhere are fine to cull, anything that looks like it might be the

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

davide added a comment. Thanks! https://reviews.llvm.org/D32148 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. No need to request review when removing dead code. https://reviews.llvm.org/D32148 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32184: Teach RenderScriptRuntime about changed context representation.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm. You might consider using llvm::formatv instead of the raw snprintf -- it would make the `PRIx64` macros more readable. https://reviews.llvm.org/D32184

[Lldb-commits] [PATCH] D32221: Recompute ArchSpec core after MergeFrom

labath updated this revision to Diff 95722. labath added a comment. Also remove the skipIfDarwin decorators, as they should work now -- there was nothing darwin-specific about them, just our bots don't run assert builds at the moment. https://reviews.llvm.org/D32221 Files:

[Lldb-commits] [PATCH] D32221: Recompute ArchSpec core after MergeFrom

labath created this revision. MergeFrom was updating the architecture if the target triple did not have it set. However, it was leaving the core field as invalid. This resulted in assertion failures in core file tests as a missing core meant we were unable to compute the address byte size

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

krytarowski added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:435 find_package(Backtrace) +check_symbol_exists(ppoll poll.h HAVE_PPOLL) labath wrote: > This needs `set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)` to detect ppoll on >

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

krytarowski added a comment. Fix from pkgsrc-wip to resurrect LLDB Standalone build in SVN r. 300654. From 3371648af049cb4b40427ef87dcafb4745f10e8d Mon Sep 17 00:00:00 2001 From: Kamil Rytarowski Date: Wed, 19 Apr 2017 06:17:30 +0200 Subject: [PATCH] lldb-netbsd: Upgrade

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This is the list I am getting when using ToT clang targetting x86_64 linux. Note that there are a couple of non-type-units test broken by this. This needs to be addressed first.

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

labath added a comment. It looks like you had a fun day yesterday. :) Unfortunately, I have to add to your problems, as I've had to revert your commit due to a fairly big problem. The problem that it can happen that the create-a-bunch-of-listening-sockets loop can sometimes only create an

[Lldb-commits] [lldb] r300670 - Fix TestRegisterVariables for clang/arm

Author: labath Date: Wed Apr 19 05:13:29 2017 New Revision: 300670 URL: http://llvm.org/viewvc/llvm-project?rev=300670=rev Log: Fix TestRegisterVariables for clang/arm Clang rejects __attribute__((regparm)) when targetting arm. The default calling convention passes arguments in registers anyway,

[Lldb-commits] [lldb] r300669 - Revert yesterdays IPv6 patches

Author: labath Date: Wed Apr 19 05:13:22 2017 New Revision: 300669 URL: http://llvm.org/viewvc/llvm-project?rev=300669=rev Log: Revert yesterdays IPv6 patches The break the linux bots (and probably any other machine which would run the test suite in a massively parallel way). The problem is that