kubamracek updated this revision to Diff 170809.
kubamracek added a comment.
Adding class comments, adding IDs to recognizers.
https://reviews.llvm.org/D44603
Files:
include/lldb/API/SBVariablesOptions.h
include/lldb/Interpreter/OptionGroupVariable.h
kubamracek added a reviewer: aprantl.
kubamracek added a comment.
Ping.
https://reviews.llvm.org/D48226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Tue Oct 23 16:45:56 2018
New Revision: 345106
URL: http://llvm.org/viewvc/llvm-project?rev=345106=rev
Log:
Support nwere versions of the Segger J-Link jtag board software.
Add support in ProcessGDBRemote::GetGDBServerRegisterInfo
for recognizing a generic "arm" architecture
zturner added a comment.
In https://reviews.llvm.org/D53094#1273556, @asmith wrote:
> I think this addresses all the previous comments.
Still didn't get a clear answer if the mutex being used needs to be recursive.
If it doesn't, perhaps `std::mutex` can be used instead of
asmith updated this revision to Diff 170781.
https://reviews.llvm.org/D53094
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
unittests/ObjectFile/CMakeLists.txt
unittests/ObjectFile/PECOFF/CMakeLists.txt
asmith added a comment.
I think this addresses all the previous comments.
https://reviews.llvm.org/D53094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: zturner
Date: Tue Oct 23 15:15:27 2018
New Revision: 345092
URL: http://llvm.org/viewvc/llvm-project?rev=345092=rev
Log:
Remove unused private methods.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
Modified:
Author: zturner
Date: Tue Oct 23 15:15:05 2018
New Revision: 345091
URL: http://llvm.org/viewvc/llvm-project?rev=345091=rev
Log:
Fix some comments pointed out by Leonard Mosescu.
These were originally pointed out in D53511 but I forgot
to incorporate them in my patch.
Modified:
zturner created this revision.
zturner added reviewers: davide, jingham, clayborg.
Herald added a subscriber: JDevlieghere.
This is a followup to https://reviews.llvm.org/D53597, with 2 more enums.
Assuming that patch is good, I see no reason why this wasn't isn't good as
well, but I'm
Author: echristo
Date: Tue Oct 23 14:55:41 2018
New Revision: 345086
URL: http://llvm.org/viewvc/llvm-project?rev=345086=rev
Log:
Remove unused variable.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
Modified:
jingham added a comment.
This is good. The addition of the "info" command will be helpful for people
trying to debug their recognizers. It's okay to add multiple -s and -n's later
- though the fact that you don't allow "apply to all frames" may make us want
the ability to provide more than
jingham added a comment.
That looks good to me, though you should wait for Greg to weigh in. He might
notice something I missed.
https://reviews.llvm.org/D53597
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
aprantl added inline comments.
Comment at: include/lldb/Target/StackFrameRecognizer.h:25
+
+class RecognizedStackFrame
+: std::enable_shared_from_this {
Would you mind adding doxygen comments to each of the new classes to explain
what they are good for?
zturner updated this revision to Diff 170737.
zturner added a comment.
Remove the reference to `llvm/ADT/BitmaskEnu.h` and define the operators
ourselves. Also, removed a few casts that got left in.
https://reviews.llvm.org/D53597
Files:
lldb/include/lldb/Core/Address.h
zturner added inline comments.
Comment at:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3273-3274
+ is_virtual, is_base_of_class);
+ if (!result)
+break;
+
zturner wrote:
> If the result is a `nullptr`, then
zturner added inline comments.
Comment at:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3273-3274
+ is_virtual, is_base_of_class);
+ if (!result)
+break;
+
If the result is a `nullptr`, then there is no base
jingham added a comment.
That would be great!
https://reviews.llvm.org/D53597
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
In https://reviews.llvm.org/D53597#1273087, @jingham wrote:
> It would be great not to have to use comments to express what these values
> mean. OTOH, having to put in static casts whenever you want to or values
> together would be a pain, so if there's no way to do
shafik added a comment.
+1 for modernizing code!
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2262
+ // assertion in the call to clang_type.TransferBaseClasses()
+ for (auto _class : bases) {
clang::TypeSourceInfo
jingham added a comment.
It would be great not to have to use comments to express what these values
mean. OTOH, having to put in static casts whenever you want to or values
together would be a pain, so if there's no way to do it without magic, I'm a
little less enthused...
But on the magic:
kubamracek updated this revision to Diff 170724.
kubamracek added a comment.
Updating patch, addressing most comments. Changed '-m' to '-s'. Added 'frame
recognizer info' subcommand. Improved wording in documentation.
I didn't add the possibility to specify multiple '-s' and '-n' args. Do you
Author: jmolenda
Date: Tue Oct 23 12:03:52 2018
New Revision: 345069
URL: http://llvm.org/viewvc/llvm-project?rev=345069=rev
Log:
Add UdtRecordCompleter.cpp.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
zturner created this revision.
zturner added reviewers: clayborg, jingham, labath.
Herald added subscribers: atanasyan, JDevlieghere, sdardis.
When we get the `resolve_scope` parameter from the SB API, it's a `uint32_t`.
We then pass it through all of LLDB this way, as a uint32. This is
labath added a comment.
Back when the FileSystem class was introduced, the idea was that *it* would
eventually become the gateway to the real filesystem, and FileSpec would just
deal with abstract path manipulation.
I still think that is a good idea, particularly in light of this patch. So I
zturner created this revision.
zturner added reviewers: labath, davide, clayborg.
Herald added a subscriber: JDevlieghere.
[NFC] Refactor SetBaseClasses and DeleteBaseClasses.
We currently had a 2-step process where we had to call
SetBaseClassesForType and DeleteBaseClasses. Every
Author: jdevlieghere
Date: Tue Oct 23 10:49:51 2018
New Revision: 345061
URL: http://llvm.org/viewvc/llvm-project?rev=345061=rev
Log:
Skip test with older versions of clang
This was failing for the bots that build with older clangs:
Author: zturner
Date: Tue Oct 23 10:22:02 2018
New Revision: 345055
URL: http://llvm.org/viewvc/llvm-project?rev=345055=rev
Log:
Change two methods from const char* to StringRef [NFC].
Modified:
lldb/trunk/include/lldb/Symbol/ClangASTContext.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345047: [NativePDB] Add basic support for tag types to
the native pdb plugin. (authored by zturner, committed by ).
Herald added subscribers: teemperor, abidh.
Changed prior to commit:
Author: zturner
Date: Tue Oct 23 09:37:53 2018
New Revision: 345047
URL: http://llvm.org/viewvc/llvm-project?rev=345047=rev
Log:
[NativePDB] Add basic support for tag types to the native pdb plugin.
This adds support to LLDB for named types (class, struct, union, and
enum). This is true cross
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Parsing a type shouldn't need an execution context and we shouldn't be
re-parsing a type over and over for each frame. We should be encoding the array
expression somewhere that
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
Looks good to me, thank you!
https://reviews.llvm.org/D53511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This is a little different. It's not an empty structural type, it's a
children with zero size, that has an implicit representation (swift
uses tagged bits to represent cases in an enumeration, hence IRGen
says the size of the type is zero). I don't think there's any
equivalent of this in C++, but
grimar added a comment.
Ping.
https://reviews.llvm.org/D53140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a reviewer: zturner.
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53506#1270933, @zturner wrote:
> So, the point is, just because we don't have access to the info via DIA
> doesn't mean we won't have access to the info once the native pdb plugin is
>
aleksandr.urakov added a comment.
Ok, I'll reimplement this, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a comment.
Ok, I'll do it, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345016: [LLDB] - Implement the support for the
.debug_loclists section. (authored by grimar, committed by ).
Herald added a subscriber: abidh.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53436
You maybe able to add a test for that in C++: Clang types can have 0
size, the padding from 0 to 1 happens in the CodeGen IIRC. See also
this bug: https://bugs.llvm.org/show_bug.cgi?id=31612
- Raphael
Am Di., 23. Okt. 2018 um 02:33 Uhr schrieb Davide Italiano via
lldb-commits :
>
> Author: davide
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345013: [PDB] Improve performance of the PDB DIA plugin
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: aleksandr.urakov
Date: Tue Oct 23 01:29:17 2018
New Revision: 345013
URL: http://llvm.org/viewvc/llvm-project?rev=345013=rev
Log:
[PDB] Improve performance of the PDB DIA plugin
Summary:
This patch improves performance of `SymbolFilePDB` on huge executables
in two ways:
- cache names of
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53375#1271336, @Hui wrote:
> I think parsing types e.g. SymbolFilePDB::ParseTypes also has speed bumps.
> Will be good to have them cached too.
We are already caching them, see `m_types` field.
Repository:
rLLDB LLDB
41 matches
Mail list logo
