[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb created this revision. Herald added subscribers: lldb-commits, mstorsjo. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Host/windows/FileSystem.cpp

[Lldb-commits] [PATCH] D65682: Give a little more info when "run_to_x_breakpoint" fails

jingham created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We failure was a little bit terse. Say whether we exited, hit another breakpoint/crashed, etc. Repository: rLLDB LLDB https://reviews.llvm.org/D65682 Files:

[Lldb-commits] [PATCH] D61090: [SBHostOS] Remove getting the python script interpreter path

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We can't change functionality in our API. Fine to add something to SBDebugger, but we can't just disable a call that used to work in SBHostOS. Comment at:

[Lldb-commits] [PATCH] D65647: Fix line table resolution near the end of a section

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I vote to not add any API calls with allow_section_end and just take care of this in source/Symbol/LineTable.cpp. All of my inline comments will reflect this notion.

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

clayborg added a comment. Also be careful if the user uses a symlink to not resolve the link. If a user tries to debug clang++: $ ls -AFlG /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang* -rwxr-xr-x 1 root wheel 8156 Jul 12 21:48

Re: [Lldb-commits] [lldb] r367726 - Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

On Fri, Aug 2, 2019 at 2:40 PM Shafik Yaghmour via lldb-commits wrote: > > Author: shafik > Date: Fri Aug 2 14:41:50 2019 > New Revision: 367726 > > URL: http://llvm.org/viewvc/llvm-project?rev=367726=rev > Log: > Fix ClangASTContext::CreateParameterDeclaration to not call addDecl > > Summary: >

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL367726: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r367726 - Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

Author: shafik Date: Fri Aug 2 14:41:50 2019 New Revision: 367726 URL: http://llvm.org/viewvc/llvm-project?rev=367726=rev Log: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl Summary: The change https://reviews.llvm.org/D55575 modified

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere added a comment. In D65611#1611724 , @labath wrote: > The details of how our FS capture works have unfortunately, swapped out of my > memory, but... isn't this the sort of thing that should already be handled by > the filesystem

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

JDevlieghere created this revision. JDevlieghere added reviewers: bkramer, bruno, vsapsai, sammccall. Herald added subscribers: lldb-commits, dexonsmith, hiraditya. Herald added projects: LLDB, LLVM. For reproducers it is useful to encode the notion of the current working directory in the VFS

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

jingham added a comment. That would be fine. In the swift REPL, we increment the line number so that it appears that all the expressions are one contiguous source file. But I think for the expression parser treating each expression as a separate file is a better fiction. Repository:

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JDevlieghere added a comment. In D64993#1612825 , @JosephTremoulet wrote: > In D64993#1612746 , @JDevlieghere > wrote: > > > Hey Joseph, > > > > The test `trap_frame_sym_ctx` is failing on GreenDragon. Can you

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

teemperor added a comment. > Is this orthogonal or do we now have to ways of pretending there is a source > file backing up the expression? Jim already answered this, but this patch only changes the file names of our expression and pretends for the sake of diagnostics that we are in a separate

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet added a comment. In D64993#1612746 , @JDevlieghere wrote: > Hey Joseph, > > The test `trap_frame_sym_ctx` is failing on GreenDragon. Can you please have > a look? > >

[Lldb-commits] [lldb] r367706 - Use rip-relative addressing in asm test

Author: josepht Date: Fri Aug 2 12:06:15 2019 New Revision: 367706 URL: http://llvm.org/viewvc/llvm-project?rev=367706=rev Log: Use rip-relative addressing in asm test The absolute form is an error when targeting Darwin. Modified: lldb/trunk/lit/Unwind/Inputs/trap_frame_sym_ctx.s

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JDevlieghere added a comment. Hey Joseph, The test `trap_frame_sym_ctx` is failing on GreenDragon. Can you please have a look? http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/32449/testReport/junit/LLDB/Unwind/trap_frame_sym_ctx_test/ Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65666: Temporarily disable libc++ std::function formatter due to performance issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL367701: [Formatters] Temporarily disable libc++ std::function formatter due to… (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r367701 - [Formatters] Temporarily disable libc++ std::function formatter due to performance issue

Author: shafik Date: Fri Aug 2 11:16:04 2019 New Revision: 367701 URL: http://llvm.org/viewvc/llvm-project?rev=367701=rev Log: [Formatters] Temporarily disable libc++ std::function formatter due to performance issue Summary: We have been seeing increased reports of performance issue around

[Lldb-commits] [PATCH] D65666: Temporarily disable libc++ std::function formatter due to performance issue

JDevlieghere added a comment. Please also add a comment to `formatters::LibcxxFunctionSummaryProvider` saying that it's currently not being registered. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65666/new/ https://reviews.llvm.org/D65666

[Lldb-commits] [PATCH] D65666: Temporarily disable libc++ std::function formatter due to performance issue

shafik added a comment. @aprantl I did not know either until I looked at decorators.py and it says: # @skipIf, skip for all platform/compiler/arch, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65666/new/ https://reviews.llvm.org/D65666

[Lldb-commits] [PATCH] D65666: Temporarily disable libc++ std::function formatter due to performance issue

shafik updated this revision to Diff 213090. shafik added a comment. Adding as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65666/new/ https://reviews.llvm.org/D65666 Files:

[Lldb-commits] [PATCH] D65666: Temporarily disable libc++ std::function formatter due to performance issue

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py:26 +@skipIf

[Lldb-commits] [PATCH] D65666: Temporarily disable libc++ std::function formatter due to performance issue

shafik created this revision. shafik added reviewers: aprantl, jasonmolenda, JDevlieghere. Herald added a reviewer: EricWF. Herald added a subscriber: christof. We have been seeing increased reports of performance issue around large project and formatting std::function variables especially in

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

jingham added a comment. In D65646#1612436 , @aprantl wrote: > I have a question based on my half-knowledge about the expression evaluator: > I thought that we already wrote out a temporary file for the expression in > order to support `expr -g`? Is

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jfb added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); jingham wrote:

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jingham added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); mgorny

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { +

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367691: Fix PC adjustment in StackFrame::GetSymbolContext (authored by josepht, committed by ). Herald added a project:

[Lldb-commits] [lldb] r367691 - Fix PC adjustment in StackFrame::GetSymbolContext

Author: josepht Date: Fri Aug 2 09:53:42 2019 New Revision: 367691 URL: http://llvm.org/viewvc/llvm-project?rev=367691=rev Log: Fix PC adjustment in StackFrame::GetSymbolContext Summary: Update StackFrame::GetSymbolContext to mirror the logic in RegisterContextLLDB::InitializeNonZerothFrame

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. Yes, it was! Thanks for catching that :) The tests pass with the latest update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet updated this revision to Diff 213067. JosephTremoulet added a comment. - Expand comment about return trampolines - rename PropagateTrapHandlerFlag -> PropagateTrapHandlerFlagFromUnwindPlan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jfb requested changes to this revision. jfb added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it &&

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

aprantl added a comment. I have a question based on my half-knowledge about the expression evaluator: I thought that we already wrote out a temporary file for the expression in order to support `expr -g`? Is this orthogonal or do we now have to ways of pretending there is a source file backing

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { +

[Lldb-commits] [PATCH] D65647: Fix line table resolution near the end of a section

labath created this revision. labath added reviewers: clayborg, jingham. Herald added a subscriber: mgorny. lld r367537 changed the way the linker organizes sections and segments. This exposed an lldb bug and caused some tests to fail. In all of the failing tests the root cause was the same --

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

sgraenitz added a comment. In D65566#1611007 , @JDevlieghere wrote: > Is there a way to use the debugserver in the framework instead? This patch is about the debugserver in the framework. It must be signed, because the lldb driver uses it implicitly

[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, kadircet, arphaman, aprantl. Herald added a project: LLDB. Currently our expression evaluators only prints very basic errors that are not very useful when writing complex expressions. For

[Lldb-commits] [PATCH] D65571: [lldb][NFC] Remove unused imports from Python tests

teemperor closed this revision. teemperor added a comment. This has landed in sv as 367663 but it seems Phabricator struggles with this huge patch (as did git-llvm...). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65571/new/ https://reviews.llvm.org/D65571

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added a comment. In D63165#1611924 , @asmith wrote: > I can make the one simplification but Im not sure what you are asking as far > as the refactoring. Provide an example and I will try to accommodate your > request. I'm not going to be able to

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith added a comment. I can make the one simplification but Im not sure what you are asking as far as the refactoring. Provide an example and I will try to accommodate your request. I'm not going to be able to spend much more time on lldb patches though. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5)

ikudrin created this revision. ikudrin added reviewers: dblaikie, probinson, aprantl, clayborg, labath. ikudrin added a project: LLDB. Herald added a subscriber: arphaman. ikudrin added a parent revision: D65638: Switch LLVM to use 64-bit offsets (2/5). Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL367664: SymbolVendor: Introduce Module::GetSymbolFile (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[Lldb-commits] [lldb] r367664 - SymbolVendor: Introduce Module::GetSymbolFile

Author: labath Date: Fri Aug 2 01:16:35 2019 New Revision: 367664 URL: http://llvm.org/viewvc/llvm-project?rev=367664=rev Log: SymbolVendor: Introduce Module::GetSymbolFile Summary: This is the next step in avoiding funneling all SymbolFile calls through the SymbolVendor. Right now, it is just

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

labath added a comment. In D65414#1610923 , @shafik wrote: > @labath @stella.stamenova I updated the diff with a fix that I believe should > address the test failure. > > This is an unfortunate difference in how DWARF and PDB works. After spending >

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added a comment. > Are you accepting this review? No I would still like to see the two comments I made in https://reviews.llvm.org/D63165#1607877>> to be addressed. The last comment was just acknowledging the fact that you (or is it @Hui? I'm not sure who actually writes these

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked an inline comment as done. asmith added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec ) { + // A WoW64 register info is the same as the i386's. +

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. The details of how our FS capture works have unfortunately, swapped out of my memory, but... isn't this the sort of thing that should already be handled by the filesystem capture/replay machinery? It sounds to me like it could/should remember what the CWD at the time of

Re: [Lldb-commits] [lldb] r367549 - [lit] Use ld.lld -z separate-code to work around a debug_line parsing bug

On 02/08/2019 06:58, Fāng-ruì Sòng wrote: Hi Raphael, you need lld built from top of trunk to run the lldb tests. -z separate-code is added by rLLD367537, not included in lld 9. We may need to somehow tweak the detection logic in our lit scripts so that it does not pick up ambient lld (nor