[Lldb-commits] [PATCH] D91742: [lldb] Add examples and reword source-map help string

aprantl added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91742/new/ https://reviews.llvm.org/D91742 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 33c79f7 - Revert "[lldb] add a missing dependency on intrinsics_gen"

Author: Nathan Lanza Date: 2020-11-20T16:02:16-05:00 New Revision: 33c79f76af75ea4e64cc252fe9d6527a0352e6e7 URL: https://github.com/llvm/llvm-project/commit/33c79f76af75ea4e64cc252fe9d6527a0352e6e7 DIFF: https://github.com/llvm/llvm-project/commit/33c79f76af75ea4e64cc252fe9d6527a0352e6e7.diff

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny updated this revision to Diff 306751. mgorny edited the summary of this revision. mgorny added a comment. Added aliases to all regsets, not just the first ones. Updated test status. amd64 tests still fail due to missing `fip`/`fdp`. I wonder how hard would it be to port it to Darwin.

[Lldb-commits] [PATCH] D91742: [lldb] Add examples and reword source-map help string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbcc69217a3f: [lldb] Add examples and reword source-map help string (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] dbcc692 - [lldb] Add examples and reword source-map help string

Author: Dave Lee Date: 2020-11-20T10:01:36-08:00 New Revision: dbcc69217a3f6b41cbf6e5b30c9a0ee9d3dfe0b4 URL: https://github.com/llvm/llvm-project/commit/dbcc69217a3f6b41cbf6e5b30c9a0ee9d3dfe0b4 DIFF: https://github.com/llvm/llvm-project/commit/dbcc69217a3f6b41cbf6e5b30c9a0ee9d3dfe0b4.diff

[Lldb-commits] [PATCH] D91742: [lldb] Add examples and reword source-map help string

kastiglione updated this revision to Diff 306723. kastiglione added a comment. Minor rewording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91742/new/ https://reviews.llvm.org/D91742 Files: lldb/source/Target/TargetProperties.td Index:

[Lldb-commits] [PATCH] D91810: [lldb] Prevent 'process connect' from using local-only plugins

mgorny updated this revision to Diff 306699. mgorny retitled this revision from "[lldb] [Process/FreeBSD] Fix 'process connect' plugin choice" to "[lldb] Prevent 'process connect' from using local-only plugins". mgorny edited the summary of this revision. mgorny added a comment. Updated to pass

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

labath added a subscriber: stella.stamenova. labath added a comment. You can ask the bot owner (@stella.stamenova) if you have problems reproducing/understanding the failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87173/new/

[Lldb-commits] [lldb] ffb3fd8 - Partially revert '[MachO] Update embedded part of ObjectFileMachO for Mangled API change'

Author: Raphael Isemann Date: 2020-11-20T13:31:36+01:00 New Revision: ffb3fd8f1846de97d10cfca249567eb282cec980 URL: https://github.com/llvm/llvm-project/commit/ffb3fd8f1846de97d10cfca249567eb282cec980 DIFF:

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

DavidSpickett added a comment. FYI my change to add the memory tagging flag (https://reviews.llvm.org/D87442) has landed so you will have some conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88387/new/ https://reviews.llvm.org/D88387

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306647. mgorny added a comment. Skipped python test on non-Darwin, xfailed shell test on Darwin, added respective comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files:

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32541685b2a9: [lldb][AArch64/Linux] Show memory tagged memory regions (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 3254168 - [lldb][AArch64/Linux] Show memory tagged memory regions

Author: David Spickett Date: 2020-11-20T11:21:59Z New Revision: 32541685b2a980290c320adb289b56395a88d4c3 URL: https://github.com/llvm/llvm-project/commit/32541685b2a980290c320adb289b56395a88d4c3 DIFF: https://github.com/llvm/llvm-project/commit/32541685b2a980290c320adb289b56395a88d4c3.diff

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

DavidSpickett added a comment. I'm going to stick with the test format as it is. No doubt I'll need to clean it up based on what future MTE tests look like. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D87442#2405681 , @DavidSpickett wrote: > - Use assertIn > - Cleanup Status/Error handling > - Refactor test so it runs once and we skip based on

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

labath added a comment. In D91835#2407060 , @rupprecht wrote: > I ran manual tests for this, but I did so by introducing an intentional crash > in a place that obviously can't be checked in. Does LLDB have any kind of > intentional-crash-for-test

[Lldb-commits] [PATCH] D91810: [lldb] [Process/FreeBSD] Fix 'process connect' plugin choice

labath added a comment. In D91810#2407483 , @mgorny wrote: > In D91810#2407461 , @labath wrote: > >> I think that the real fix here would be to change the plugin selection logic >> (Target::CreateProcess) to

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny added a comment. In D91504#2407397 , @labath wrote: > Well... I think that will make the test fail on mac, as debugserver hasn't > been updated. > > This test comes from D12592 , and is > actually serves a very

[Lldb-commits] [PATCH] D91810: [lldb] [Process/FreeBSD] Fix 'process connect' plugin choice

mgorny added a comment. In D91810#2407461 , @labath wrote: > I think that the real fix here would be to change the plugin selection logic > (Target::CreateProcess) to convey the fact that we're looking for a > connectable plugin. The method already

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

labath added a reviewer: jasonmolenda. labath added a comment. Thanks for doing this. The changes look pretty straight-forward. The main thing I think is missing here is the shelltest equivalent of `@skipIfOutOfTreeDebugserver` -- most people build/test lldb with the system debug server

[Lldb-commits] [PATCH] D91810: [lldb] [Process/FreeBSD] Fix 'process connect' plugin choice

labath added a comment. This is all weird (not in a "your fault" way). ProcessFreeBSD is decidedly a local-only plugin. It could never successfully complete the "process connect" command, regardless of whether we have some other remote plugin or not. I think that the real fix here would be to

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, JDevlieghere. Herald added a subscriber: pengfei. mgorny requested review of this revision. Add stN aliases for the FPU (stmmN) registers on MacOSX. This should improve compatibility between MacOSX and other

[Lldb-commits] [lldb] f0e2c51 - [lldb] [test/Register] XFAIL x86-fp-write on Darwin

Author: Michał Górny Date: 2020-11-20T09:43:08+01:00 New Revision: f0e2c5131eda0cb77a1ab0e3f1a666a3b8860591 URL: https://github.com/llvm/llvm-project/commit/f0e2c5131eda0cb77a1ab0e3f1a666a3b8860591 DIFF: https://github.com/llvm/llvm-project/commit/f0e2c5131eda0cb77a1ab0e3f1a666a3b8860591.diff

[Lldb-commits] [lldb] 3a23010 - Revert "[LLDB] Fixing lldb/test/Shell/Register/x86-fp-write.test"

Author: Michał Górny Date: 2020-11-20T09:42:13+01:00 New Revision: 3a230101fee6bb1d6ddc1aa094f2a35d57912a15 URL: https://github.com/llvm/llvm-project/commit/3a230101fee6bb1d6ddc1aa094f2a35d57912a15 DIFF: https://github.com/llvm/llvm-project/commit/3a230101fee6bb1d6ddc1aa094f2a35d57912a15.diff

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny added inline comments. Comment at: lldb/test/Shell/Register/x86-fp-write.test:2 # XFAIL: system-windows -# REQUIRES: native && target-x86 +# REQUIRES: native && (target-x86 || target-x86_64) # RUN: %clangxx_host %p/Inputs/x86-fp-write.cpp -o %t shafik