[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedc77353daa7: [lldb/crashlog] Improve exception reporting for interactive mode (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG300e393092e3: [lldb/crashlog] Adapt raw text crashlog exception to json format (authored by mib). Changed prior to commit:

[Lldb-commits] [lldb] 6c58f12 - [lldb/Symbol] Fix null-deref in TypeList::Dump

Author: Med Ismail Bennani Date: 2022-08-11T22:29:06-07:00 New Revision: 6c58f12d07612a4d2bc9abdc5bb545cbb4810f0e URL: https://github.com/llvm/llvm-project/commit/6c58f12d07612a4d2bc9abdc5bb545cbb4810f0e DIFF:

[Lldb-commits] [lldb] edc7735 - [lldb/crashlog] Improve exception reporting for interactive mode

Author: Med Ismail Bennani Date: 2022-08-11T22:29:06-07:00 New Revision: edc77353daa707712fc92a31edb5b27ad103ba30 URL: https://github.com/llvm/llvm-project/commit/edc77353daa707712fc92a31edb5b27ad103ba30 DIFF:

[Lldb-commits] [lldb] 603f44a - [lldb/test] Fix interactive crashlog test failure (NFC)

Author: Med Ismail Bennani Date: 2022-08-11T22:29:06-07:00 New Revision: 603f44acc6ec31a274c554f0647630c10a114a6b URL: https://github.com/llvm/llvm-project/commit/603f44acc6ec31a274c554f0647630c10a114a6b DIFF:

[Lldb-commits] [lldb] 300e393 - [lldb/crashlog] Adapt raw text crashlog exception to json format

Author: Med Ismail Bennani Date: 2022-08-11T22:29:06-07:00 New Revision: 300e393092e39c8efc76f807671b11309fb4b98e URL: https://github.com/llvm/llvm-project/commit/300e393092e39c8efc76f807671b11309fb4b98e DIFF:

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib updated this revision to Diff 452078. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131086/new/ https://reviews.llvm.org/D131086 Files: lldb/examples/python/scripted_process/crashlog_scripted_process.py lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere updated this revision to Diff 452077. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 Files: lldb/test/API/commands/target/basic/TestTargetCommand.py lldb/test/API/lang/c/global_variables/TestGlobalVariables.py

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. In D131741#3717992 , @JDevlieghere wrote: > In D131741#3717974 , @jasonmolenda > wrote: > >> We already skip these tests for arm64 & arm64e because of the chained fixups >> and

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

This revision was automatically updated to reflect the committed changes. fixathon marked an inline comment as done. Closed by commit rG3934a31cfa02: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3934a31 - [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

Author: Slava Gurevich Date: 2022-08-11T21:10:53-07:00 New Revision: 3934a31cfa024edfaa406c3706dc943e59f9049c URL: https://github.com/llvm/llvm-project/commit/3934a31cfa024edfaa406c3706dc943e59f9049c DIFF:

[Lldb-commits] [PATCH] D131743: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2cb417ed9a6: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2) (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b2cb417 - [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2)

Author: Slava Gurevich Date: 2022-08-11T21:08:18-07:00 New Revision: b2cb417ed9a69528ddd9abac704ba12ef5b8f932 URL: https://github.com/llvm/llvm-project/commit/b2cb417ed9a69528ddd9abac704ba12ef5b8f932 DIFF:

[Lldb-commits] [lldb] 95367da - [lldb] Remove unused "import unittest2" statements

Author: Dave Lee Date: 2022-08-11T19:11:01-07:00 New Revision: 95367da43ddd16fc9c4cbe06a1823119f7841f48 URL: https://github.com/llvm/llvm-project/commit/95367da43ddd16fc9c4cbe06a1823119f7841f48 DIFF: https://github.com/llvm/llvm-project/commit/95367da43ddd16fc9c4cbe06a1823119f7841f48.diff

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56f9cfe30c44: [lldb] Remove uses of six module (NFC) (authored by kastiglione). Changed prior to commit:

[Lldb-commits] [lldb] 56f9cfe - [lldb] Remove uses of six module (NFC)

Author: Dave Lee Date: 2022-08-11T19:06:15-07:00 New Revision: 56f9cfe30c4488aade888905bb6280ecb952a613 URL: https://github.com/llvm/llvm-project/commit/56f9cfe30c4488aade888905bb6280ecb952a613 DIFF: https://github.com/llvm/llvm-project/commit/56f9cfe30c4488aade888905bb6280ecb952a613.diff

[Lldb-commits] [PATCH] D131743: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2)

fixathon added a comment. Herald added a subscriber: JDevlieghere. Implemented most fixes suggested in https://reviews.llvm.org/D131554 post-push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131743/new/ https://reviews.llvm.org/D131743

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon marked 3 inline comments as done. fixathon added a comment. Replied to comments, and adding the suggested modifications in https://reviews.llvm.org/D131743 because this diff has already been pushed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131743: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp (part 2)

fixathon created this revision. fixathon added a reviewer: clayborg. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add the fixes suggested post-push in D131554

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon marked 3 inline comments as done. fixathon added a comment. Addressed the comments. Will deal with the signed/unsigned issue in a separate diff if still needed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2582 surface.MoveCursor(0, 1);

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

clayborg added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { JDevlieghere wrote: > clayborg wrote: > > fixathon wrote: > > > JDevlieghere wrote: > >

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

This revision was automatically updated to reflect the committed changes. Closed by commit rG256ba7738ea8: [LLDB][NFC] Fix the style issue in TCPSocket (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131543/new/

[Lldb-commits] [lldb] 256ba77 - [LLDB][NFC] Fix the style issue in TCPSocket

Author: Slava Gurevich Date: 2022-08-11T18:02:01-07:00 New Revision: 256ba7738ea8a07372a82cadd29e9c08fdf9145c URL: https://github.com/llvm/llvm-project/commit/256ba7738ea8a07372a82cadd29e9c08fdf9145c DIFF:

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. In D131741#3717974 , @jasonmolenda wrote: > We already skip these tests for arm64 & arm64e because of the chained fixups > and arm64e fixups before that -- and now we're going to skip them on x86_64 > if the deployment

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere updated this revision to Diff 452045. JDevlieghere added a comment. Check the darwin OS version as a proxy for the deployment target CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 Files:

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

jasonmolenda added a comment. I don't know if I support bothering with checking ld's version, I think these tests should be skipped on Darwin. Before macOS 12, if you built these tests arm64e, the address for something like `my_global_str` in lldb/test/API/commands/target/basic/globals.c would

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM assuming this compiles on non-apple hosts Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542 + case EXC_BAD_ACCESS: +

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

mib updated this revision to Diff 452042. mib marked an inline comment as done. mib added a comment. Fixing typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131719/new/ https://reviews.llvm.org/D131719 Files: lldb/examples/python/crashlog.py Index:

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib updated this revision to Diff 452040. mib marked an inline comment as done. mib added a comment. Reflect changes from D131719 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131086/new/ https://reviews.llvm.org/D131086 Files:

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. With this patch applied the test suite should be clean on an Intel mac running macOS Ventura beta + Xcode 14 beta. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 ___

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jasonmolenda. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Starting with Xcode 14, ld64 is using authenticated fixups for x86_64 as well as

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { clayborg wrote: > fixathon wrote: >

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. one typo to fix, but otherwise looks good Comment at: lldb/examples/python/crashlog.py:690-691 +self.crashlog.thread_exception_subtype =

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

mib updated this revision to Diff 452032. mib marked 2 inline comments as done. mib added a comment. - Make `CrashLog.exception` a dictionary at initialization - Update exception_type regex to use a non-capture group CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131719/new/

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu updated this revision to Diff 452031. zequanwu added a comment. - Add missing test case for simple type because subfield_register_simple_type.s is deleted, forgot to add it before. - Address rnk's comment by only accepting subfield locations that are on register, because we don't have

[Lldb-commits] [lldb] ce075df - [lldb] Fix output for unconditionally decorated tests

Author: Jonas Devlieghere Date: 2022-08-11T16:20:15-07:00 New Revision: ce075dfa190454f6f85920ad4ffe6928980868af URL: https://github.com/llvm/llvm-project/commit/ce075dfa190454f6f85920ad4ffe6928980868af DIFF:

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:343 self.errors = list() +self.exception = None self.crashed_thread_idx = -1 should this be initialized to `{}`? Comment at:

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

clayborg added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { fixathon wrote: > JDevlieghere wrote: > > fixathon wrote: > > > This will default to

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

mib updated this revision to Diff 452016. mib added a comment. Address @kastiglione comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131719/new/ https://reviews.llvm.org/D131719 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 452007. kastiglione added a comment. Restore LLDB_USE_SYSTEM_SIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files: lldb/bindings/interface/SBData.i

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:708-709 +if exception_extra_match: +if not self.crashlog.exception['type']: +return +self.crashlog.exception['message'] =

[Lldb-commits] [PATCH] D131305: [lldb] Tidy some regex in crashlog.py (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28d0c0c2c8e8: [lldb] Tidy some regex in crashlog.py (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 28d0c0c - [lldb] Tidy some regex in crashlog.py (NFC)

Author: Dave Lee Date: 2022-08-11T15:24:57-07:00 New Revision: 28d0c0c2c8e88d2b6599ee34c84eb58eed43a626 URL: https://github.com/llvm/llvm-project/commit/28d0c0c2c8e88d2b6599ee34c84eb58eed43a626 DIFF: https://github.com/llvm/llvm-project/commit/28d0c0c2c8e88d2b6599ee34c84eb58eed43a626.diff

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:628 ) +exception_type_regex = re.compile(r'^Exception Type:\s+(EXC_.*) \s*\((.*)\)') +exception_codes_regex = re.compile(r'^Exception

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:708-709 +if exception_extra_match: +if not self.crashlog.exception['type']: +return +self.crashlog.exception['message'] =

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:628 ) +exception_type_regex = re.compile(r'^Exception Type:\s+(EXC_.*) \s*\((.*)\)') +exception_codes_regex = re.compile(r'^Exception

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

mib updated this revision to Diff 451998. mib added a comment. Change regex to support **actual** hex addresses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131719/new/ https://reviews.llvm.org/D131719 Files: lldb/examples/python/crashlog.py Index:

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

mib added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoint.GetQueueName())) +self.assertEqual(queue1_thread.GetStopReason(), 3, +

[Lldb-commits] [lldb] a5881e8 - [lldb] Silence a GCC warning about missing returns after a fully covered switch. NFC.

Author: Martin Storsjö Date: 2022-08-12T00:35:32+03:00 New Revision: a5881e8a810bac74af2efcdcf12c741d52a1970a URL: https://github.com/llvm/llvm-project/commit/a5881e8a810bac74af2efcdcf12c741d52a1970a DIFF:

[Lldb-commits] [PATCH] D131305: [lldb] Tidy some regex in crashlog.py (NFC)

kastiglione updated this revision to Diff 451983. kastiglione added a comment. Fix one crashlog test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131305/new/ https://reviews.llvm.org/D131305 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D131719: [lldb/crashlog] Adapt raw text crashlog exception to json format

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch parses CrashLog exception data from the raw text format and adapts it to

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon updated this revision to Diff 451957. fixathon added a comment. Address review comments about the signed/unsigned issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131615/new/ https://reviews.llvm.org/D131615 Files:

[Lldb-commits] [lldb] a8bc9b6 - [lldb] Simplify TestExec's source code (2/2)

Author: Jonas Devlieghere Date: 2022-08-11T12:44:38-07:00 New Revision: a8bc9b627ea143b84253fc911902cf2c8e429630 URL: https://github.com/llvm/llvm-project/commit/a8bc9b627ea143b84253fc911902cf2c8e429630 DIFF:

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

fixathon updated this revision to Diff 451952. fixathon added a comment. Fix the style in the entire file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131543/new/ https://reviews.llvm.org/D131543 Files: lldb/source/Host/common/TCPSocket.cpp

[Lldb-commits] [lldb] 181c037 - [lldb] Simplify TestExec's source code

Author: Jonas Devlieghere Date: 2022-08-11T12:36:54-07:00 New Revision: 181c0373d2832afbb62ca50c6c59d9759d17edf7 URL: https://github.com/llvm/llvm-project/commit/181c0373d2832afbb62ca50c6c59d9759d17edf7 DIFF:

[Lldb-commits] [PATCH] D131693: [lldb][Breakpoint] Prevent crash when resolving regex breakpoint on functions with asm declaration

Michael137 updated this revision to Diff 451946. Michael137 added a comment. - Tweak test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131693/new/ https://reviews.llvm.org/D131693 Files:

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:164-166 + /// \param[in] decoder + /// A decoder configured to start and end within

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added a comment. In D112374#3716944 , @alexfh wrote: > One more problem related to this patch: it changes the behavior of > __PRETTY_FUNCTION__: https://gcc.godbolt.org/z/Mvnj9j74E. There may be >

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

alexfh added a comment. One more problem related to this patch: it changes the behavior of __PRETTY_FUNCTION__: https://gcc.godbolt.org/z/Mvnj9j74E. There may be dependencies upon the specific format of expansions of this macro: tests, log processing tools, libraries like ctti, and probably

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. if we are going to fix the coding conventions we should do it for all of the locations if possible. All of them should be super simple. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, yinghuitan. Herald added a subscriber: emaste. Herald added a project: All. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. Symbols

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

fixathon marked 2 inline comments as done. fixathon added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:540 +for (uint32_t i = 0; + count > 0 && count <= sizeof(gpr.r) && i < count - 1; ++i) { gpr.r[i] =

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:391-394 + uint32_t GetMaxX() const { return getmaxx(m_window); } + uint32_t GetMaxY() const { return getmaxy(m_window); } + uint32_t GetWidth() const { return GetMaxX(); } + uint32_t

[Lldb-commits] [lldb] c4fb631 - [NFC][lldb][trace] Fix formatting of tracing files

Author: Walter Erquinigo Date: 2022-08-11T11:00:26-07:00 New Revision: c4fb631ceeeff2a292cc9cf5232b491afe09744d URL: https://github.com/llvm/llvm-project/commit/c4fb631ceeeff2a292cc9cf5232b491afe09744d DIFF:

[Lldb-commits] [PATCH] D131693: [lldb][Breakpoint] Prevent crash when resolving regex breakpoint on functions with asm declaration

Michael137 created this revision. Michael137 added a reviewer: jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, a function whose mangled name got changed using an `asm()` statement

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6c5944d05e8: [lldb] Allow DataFileCache to be constructed with a different policy (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c6c5944 - [lldb] Allow DataFileCache to be constructed with a different policy

Author: Augusto Noronha Date: 2022-08-11T09:28:30-07:00 New Revision: c6c5944d05e81b5c7f48abea22a98389b1204a33 URL: https://github.com/llvm/llvm-project/commit/c6c5944d05e81b5c7f48abea22a98389b1204a33 DIFF:

[Lldb-commits] [PATCH] D131332: [lldb][unittests] Add more test cases to CPlusPlusNameParser unit-tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4cdfe13605: [lldb][unittests] Add more test cases to CPlusPlusNameParser unit-tests (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] af4cdfe - [lldb][unittests] Add more test cases to CPlusPlusNameParser unit-tests

Author: Michael Buch Date: 2022-08-11T15:05:48+01:00 New Revision: af4cdfe136056426eaf63a113067791dad3820c3 URL: https://github.com/llvm/llvm-project/commit/af4cdfe136056426eaf63a113067791dad3820c3 DIFF: https://github.com/llvm/llvm-project/commit/af4cdfe136056426eaf63a113067791dad3820c3.diff

[Lldb-commits] [PATCH] D131667: [LLDB][RISCV] Fix risc-v target build

thakis added a comment. Herald added a subscriber: JDevlieghere. This helped, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131667/new/ https://reviews.llvm.org/D131667 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D131667: [LLDB][RISCV] Fix risc-v target build

This revision was automatically updated to reflect the committed changes. Closed by commit rG55e511f9f619: [LLDB][RISCV] Fix risc-v target build (authored by Emmmer). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 55e511f - [LLDB][RISCV] Fix risc-v target build

Author: Emmmer Date: 2022-08-11T21:42:44+08:00 New Revision: 55e511f9f61992ff57741148a92cd2f6b6a21337 URL: https://github.com/llvm/llvm-project/commit/55e511f9f61992ff57741148a92cd2f6b6a21337 DIFF: https://github.com/llvm/llvm-project/commit/55e511f9f61992ff57741148a92cd2f6b6a21337.diff LOG:

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

DavidSpickett added a comment. The error appears to be: ../../lldb/source/Plugins/Process/Utility/RegisterInfos_riscv64.h(67,5): error: constant expression evaluates to -1 which cannot be narrowed to type 'uint32_t' (aka 'unsigned int') [-Wc++11-narrowing] DEFINE_GPR64(pc,

[Lldb-commits] [lldb] be98d93 - [LLDB] Disable FP test for arm 32 bit

Author: Pavel Kosov Date: 2021-09-14T18:57:03+03:00 New Revision: be98d938794fb531db6f04e55775e4096e4c7ab1 URL: https://github.com/llvm/llvm-project/commit/be98d938794fb531db6f04e55775e4096e4c7ab1 DIFF: https://github.com/llvm/llvm-project/commit/be98d938794fb531db6f04e55775e4096e4c7ab1.diff

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

Emmmer added a comment. In D130342#3715622 , @thakis wrote: > This breaks building on windows: http://45.33.8.238/win/64255/step_4.txt > > Please take a look and revert for now if it takes a while to fix. Should be fixed after D131667

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

Emmmer added a comment. In D130342#3715622 , @thakis wrote: > This breaks building on windows: http://45.33.8.238/win/64255/step_4.txt > > Please take a look and revert for now if it takes a while to fix. Yes. This is probably because we don't have a CI

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

thakis added a comment. This breaks building on windows: http://45.33.8.238/win/64255/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:57 + +* GCC >= 7.1 +* Clang >= 5.0 xbolva00 wrote: > Do we have bots which uses last supported compiler versions? GCC 7.1, Clang > 5.0 and MSVC 16.7. > > It is bad to promise something and

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

xbolva00 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:57 + +* GCC >= 7.1 +* Clang >= 5.0 Do we have bots which uses last supported compiler versions? GCC 7.1, Clang 5.0 and MSVC 16.7. It is bad to promise something and then breakages here and

[Lldb-commits] [PATCH] D131663: [LLDB][ARM] Extend testing for vpush emulation

This revision was automatically updated to reflect the committed changes. Closed by commit rG14913fa5d050: [LLDB][ARM] Extend testing for vpush emulation (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131663/new/

[Lldb-commits] [lldb] 14913fa - [LLDB][ARM] Extend testing for vpush emulation

Author: David Spickett Date: 2022-08-11T10:02:37Z New Revision: 14913fa5d0508c3e29ae69552ef0710c82913a75 URL: https://github.com/llvm/llvm-project/commit/14913fa5d0508c3e29ae69552ef0710c82913a75 DIFF: https://github.com/llvm/llvm-project/commit/14913fa5d0508c3e29ae69552ef0710c82913a75.diff

[Lldb-commits] [PATCH] D131663: [LLDB][ARM] Extend testing for vpush emulation

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. Thank you for adding this test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131663/new/ https://reviews.llvm.org/D131663

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett added reviewers: fixathon, JDevlieghere. DavidSpickett added a subscriber: JDevlieghere. DavidSpickett added a comment. @JDevlieghere Unless this is still used in your downstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D131658 identified a bug in this and turns

[Lldb-commits] [PATCH] D131663: [LLDB][ARM] Extend testing for vpush emulation

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D131658 found a bug in

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

DavidSpickett added a comment. "LLDB’s code style differs from LLVM’s coding style. Unfortunately there is no document describing the differences. Please be consistent with the existing code." Well I don't remember seeing any Yoda conditions elsewhere so LGTM. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

This revision was automatically updated to reflect the committed changes. Closed by commit rGab6a0823afc7: [LLDB] Fix out-of-bounds memory access in EmulationStateArm (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131658/new/

[Lldb-commits] [lldb] ab6a082 - [LLDB] Fix out-of-bounds memory access in EmulationStateArm

Author: Slava Gurevich Date: 2022-08-11T01:34:18-07:00 New Revision: ab6a0823afc7e4cc660f0fd3bd07f791fe9e103f URL: https://github.com/llvm/llvm-project/commit/ab6a0823afc7e4cc660f0fd3bd07f791fe9e103f DIFF:

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

fixathon added a comment. Thank you. Yes, this does need a unit test Comment at: lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp:54 uint32_t idx = i - dwarf_d0; - if (i < 16) { + if (idx < 16) { m_vfp_regs.s_regs[idx * 2] = (uint32_t)value;

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM and I'll add a test later that would break without this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131658/new/

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

DavidSpickett added a comment. Please include more context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) in future patches. Thanks for the tests regardless! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a subscriber: kristof.beyls. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon added a comment. Responded to comments Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:391-394 + uint32_t GetMaxX() const { return getmaxx(m_window); } + uint32_t GetMaxY() const { return getmaxy(m_window); } + uint32_t GetWidth() const { return GetMaxX(); } +

[Lldb-commits] [PATCH] D131615: [LLDB][NFC] Reliability fixes for IOHandlerCursesGUI

fixathon added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:391-394 + uint32_t GetMaxX() const { return getmaxx(m_window); } + uint32_t GetMaxY() const { return getmaxy(m_window); } + uint32_t GetWidth() const { return GetMaxX(); } + uint32_t

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer abandoned this revision. Emmmer added a comment. Done in D130342 and D131566 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128250/new/ https://reviews.llvm.org/D128250

[Lldb-commits] [lldb] 0247b5a - [LLDB][RISCV] Add riscv software breakpoint trap code

Author: Emmmer Date: 2022-08-11T14:26:22+08:00 New Revision: 0247b5aaae7ae02f140ca9509dc68078cfe55898 URL: https://github.com/llvm/llvm-project/commit/0247b5aaae7ae02f140ca9509dc68078cfe55898 DIFF: https://github.com/llvm/llvm-project/commit/0247b5aaae7ae02f140ca9509dc68078cfe55898.diff LOG:

[Lldb-commits] [PATCH] D131566: [LLDB][RISCV] Add riscv software breakpoint trap code

This revision was automatically updated to reflect the committed changes. Closed by commit rG0247b5aaae7a: [LLDB][RISCV] Add riscv software breakpoint trap code (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bece0f03bf6: [LLDB][RISCV] Add riscv register definition and read/write (authored by Emmmer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/

[Lldb-commits] [lldb] 7bece0f - [LLDB][RISCV] Add riscv register definition and read/write

Author: Emmmer Date: 2022-08-11T14:24:06+08:00 New Revision: 7bece0f03bf6cbf7f98812b7cff0e789709c9982 URL: https://github.com/llvm/llvm-project/commit/7bece0f03bf6cbf7f98812b7cff0e789709c9982 DIFF: https://github.com/llvm/llvm-project/commit/7bece0f03bf6cbf7f98812b7cff0e789709c9982.diff LOG:

  1   2   >