[Lldb-commits] [lldb] [lldb] Fix a test if hardware breakpoints are not supported (PR #168813)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes If `HardwareBreakpointTestBase.supports_hw_breakpoints()` returns False, `SimpleHWBreakpointTest.does_not_support_hw_breakpoints()` returns None, so the test runs and fails. However, it should be skipped in

[Lldb-commits] [lldb] [lldb] Fix a test if hardware breakpoints are not supported (PR #168813)

https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/168813 If `HardwareBreakpointTestBase.supports_hw_breakpoints()` returns False, `SimpleHWBreakpointTest.does_not_support_hw_breakpoints()` returns None, so the test runs and fails. However, it should be skipped ins

[Lldb-commits] [lldb] [lldb] Add VirtualDataExtractor abstraction (PR #168802)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/168802 None >From a2258029c741f357d0f45c656839492c7411898c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 19 Nov 2025 17:07:47 -0800 Subject: [PATCH] [lldb] Add VirtualDataExtractor abstraction ---

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -232,4 +232,19 @@ void RenderDiagnosticDetails(Stream &stream, } } +bool TerminalSupportsUnicode() { + static std::optional result; + if (result) +return result.value(); +#ifndef _WIN32 + if (const char *lang_var = std::getenv("LANG")) +result = std::string(l

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -879,11 +881,43 @@ StackFrameList::GetStackFrameSPForStackFramePtr(StackFrame *stack_frame_ptr) { return ret_sp; } +bool StackFrameList::IsNextFrameHidden(lldb_private::StackFrame &frame) { + uint32_t frame_idx = frame.GetFrameIndex(); + StackFrameSP frame_sp = GetFram

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -354,7 +354,7 @@ class StackFrame : public ExecutionContextScope, /// \param [in] frame_marker /// Optional string that will be prepended to the frame output description. void DumpUsingSettingsFormat(Stream *strm, bool show_unique = false, -

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -232,4 +232,19 @@ void RenderDiagnosticDetails(Stream &stream, } } +bool TerminalSupportsUnicode() { + static std::optional result; + if (result) +return result.value(); +#ifndef _WIN32 + if (const char *lang_var = std::getenv("LANG")) +result = std::string(l

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -64,6 +64,17 @@ void RenderDiagnosticDetails(Stream &stream, bool show_inline, llvm::ArrayRef details); +/// Returns whether or not the current terminal supports Unicode rendering. +/// +/// The value is cached after

[Lldb-commits] [lldb] [lldb] Make sure that the "TypeSystemClang::GetBuiltinTypeByName" method returns the correct value also for "_BitInt(...)" types. (PR #165857)

https://github.com/sedymrak updated https://github.com/llvm/llvm-project/pull/165857 From f9750d0fedc41532ffe7d5048c419cb91d223601 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matej=20Ko=C5=A1=C3=ADk?= Date: Fri, 31 Oct 2025 10:37:26 +0100 Subject: [PATCH 1/5] [lldb] add more tests --- .../sbtype

[Lldb-commits] [lldb] Make result variables obey their dynamic values in subsequent expressions (PR #168611)

@@ -250,8 +250,14 @@ LLVMUserExpression::DoExecute(DiagnosticManager &diagnostic_manager, } } - if (FinalizeJITExecution(diagnostic_manager, exe_ctx, result, + if (FinalizeJITExecution(diagnostic_manager, exe_ctx, result_sp, function_stack_

[Lldb-commits] [lldb] Make result variables obey their dynamic values in subsequent expressions (PR #168611)

@@ -289,8 +295,14 @@ bool LLVMUserExpression::FinalizeJITExecution( result = GetResultAfterDematerialization(exe_ctx.GetBestExecutionContextScope()); - if (result) + if (result) { +EvaluateExpressionOptions *options = GetOptions(); +// TransferAddress also do

[Lldb-commits] [lldb] Make result variables obey their dynamic values in subsequent expressions (PR #168611)

@@ -76,10 +76,11 @@ class EntityPersistentVariable : public Materializer::Entity { const bool zero_memory = false; IRMemoryMap::AllocationPolicy used_policy; -auto address_or_error = map.Malloc( +uint64_t malloc_size = JDevlieghere wrote: ```

[Lldb-commits] [lldb] [lldb] Make sure that the "TypeSystemClang::GetBuiltinTypeByName" method returns the correct value also for "_BitInt(...)" types. (PR #165857)

Matej =?utf-8?q?Košík?= , Matej =?utf-8?q?Košík?= Message-ID: In-Reply-To: @@ -5495,6 +5498,17 @@ TypeSystemClang::GetNumChildren(lldb::opaque_compiler_type_t type, } CompilerType TypeSystemClang::GetBuiltinTypeByName(ConstString name) { + StringRef name_ref = name.GetStr

[Lldb-commits] [lldb] [lldb][windows] make PseudoTerminal::GetPTY return a shared pointer (PR #168730)

@@ -399,18 +399,18 @@ static Status HandleFileAction(ProcessLaunchInfo &launch_info, case FileAction::eFileActionOpen: { FileSpec file_spec = file_action->GetFileSpec(); if (file_spec) { -const int primary_fd = launch_info.GetPTY().GetPrimaryFileDescrip

[Lldb-commits] [lldb] [lldb] add libstdcpp span formatter (PR #168705)

@@ -1501,6 +1505,11 @@ static void LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { lldb_private::formatters::StdlibCoroutineHandleSummaryProvider, "libstdc++ std::coroutine_handle summary provider", libstdcpp_

[Lldb-commits] [lldb] [lldb] add libstdcpp span formatter (PR #168705)

@@ -0,0 +1,112 @@ +//===-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] add libstdcpp span formatter (PR #168705)

@@ -0,0 +1,112 @@ +//===-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

@@ -339,6 +464,40 @@ std::string DILParser::ParseUnqualifiedId() { return identifier; } +CompilerType +DILParser::ResolveTypeDeclarators(CompilerType type, + const std::vector &ptr_operators) { + CompilerType bad_type; cmtic

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

@@ -339,6 +464,40 @@ std::string DILParser::ParseUnqualifiedId() { return identifier; } +CompilerType +DILParser::ResolveTypeDeclarators(CompilerType type, + const std::vector &ptr_operators) { + CompilerType bad_type; + // Resolve pointers

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/165199 >From 44cf7ad579403456a169ea47608c0e2553076bcc Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 26 Oct 2025 21:14:38 -0700 Subject: [PATCH 1/3] [LLDB] Add type casting to DIL, part 1 of 3. This is an alte

[Lldb-commits] [clang] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [LV] Vectorize maxnum/minnum w/o fast-math flags. (PR #148239)

tuliom wrote: @fhahn this PR caused a regression on x86_64. Could you take a look at #167376 , please? https://github.com/llvm/llvm-project/pull/148239 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/168696 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0c7d826 - [NFC][lldb] move DiagnosticsRendering to Host (#168696)

Author: Charles Zablit Date: 2025-11-19T18:52:59+01:00 New Revision: 0c7d826129209972741dda3bd8bc40e500d5cda8 URL: https://github.com/llvm/llvm-project/commit/0c7d826129209972741dda3bd8bc40e500d5cda8 DIFF: https://github.com/llvm/llvm-project/commit/0c7d826129209972741dda3bd8bc40e500d5cda8.diff

[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

@@ -97,12 +99,8 @@ void RenderDiagnosticDetails(Stream &stream, return; } - // Since there is no other way to find this out, use the color - // attribute as a proxy for whether the terminal supports Unicode - // characters. In the future it might make sense to move t

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/168696 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -64,6 +64,17 @@ void RenderDiagnosticDetails(Stream &stream, bool show_inline, llvm::ArrayRef details); +/// Returns whether or not the current terminal supports Unicode rendering. +/// +/// The value is cached after

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -102,7 +102,7 @@ void RenderDiagnosticDetails(Stream &stream, // characters. In the future it might make sense to move this into // Host so it can be customized for a specific platform. llvm::StringRef cursor, underline, vbar, joint, hbar, spacer; - if (stream.AsRawO

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

@@ -1935,7 +1935,7 @@ bool StackFrame::DumpUsingFormat(Stream &strm, } void StackFrame::DumpUsingSettingsFormat(Stream *strm, bool show_unique, - const char *frame_marker) { + const std::string &fr

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

https://github.com/adrian-prantl commented: LGTM with one minor comment inside https://github.com/llvm/llvm-project/pull/167550 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/167550 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a child property to compliment the existing parent property (PR #168619)

https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/168619 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Check function type before casting (PR #166090)

github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33164 tests passed * 494 tests skipped https://github.com/llvm/llvm-project/pull/166090 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [llvm] [lldb][NativePDB] Fix crash in debugger when PDB has bad type index value (PR #166455)

Nerixyz wrote: Should work now. You can do something similar to this: https://github.com/llvm/llvm-project/pull/166090/files#diff-d4185e28c08f72d5ae39d59054bcd6cea460ff7a95706bbc0809c37cc5409a2e If you change the `FunctionType` back to `0x1001` but change the `Inlinee` in `S_INLINESITE`. http

[Lldb-commits] [lldb] [LLDB][NativePDB] Check function type before casting (PR #166090)

https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/166090 >From 51316c3a3a87cdc425dba02704c7930d7d374416 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 2 Nov 2025 20:20:03 +0100 Subject: [PATCH 1/3] [LLDB][NativePDB] Check function type before casting --- lldb/sou

[Lldb-commits] [lldb] [LLDB][NativePDB] Check function type before casting (PR #166090)

https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/166090 >From 51316c3a3a87cdc425dba02704c7930d7d374416 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 2 Nov 2025 20:20:03 +0100 Subject: [PATCH 1/3] [LLDB][NativePDB] Check function type before casting --- lldb/sou

[Lldb-commits] [lldb] [LLDB][NativePDB] Check function type before casting (PR #166090)

https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/166090 >From 51316c3a3a87cdc425dba02704c7930d7d374416 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sun, 2 Nov 2025 20:20:03 +0100 Subject: [PATCH 1/2] [LLDB][NativePDB] Check function type before casting --- lldb/sou

[Lldb-commits] [lldb] c9e22d3 - [lldb][windows] add color to the Python.dll not found error (#168718)

Author: Charles Zablit Date: 2025-11-19T17:30:31+01:00 New Revision: c9e22d3751299fe31eeefbfb646bef7a78bcde8a URL: https://github.com/llvm/llvm-project/commit/c9e22d3751299fe31eeefbfb646bef7a78bcde8a DIFF: https://github.com/llvm/llvm-project/commit/c9e22d3751299fe31eeefbfb646bef7a78bcde8a.diff

[Lldb-commits] [lldb] [lldb][windows] refactor CreateProcessW setup (PR #168733)

github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33163 tests passed * 494 tests skipped https://github.com/llvm/llvm-project/pull/168733 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb][windows] add color to the Python.dll not found error (PR #168718)

https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/168718 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] add color to the Python.dll not found error (PR #168718)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/168718 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] refactor CreateProcessW setup (PR #168733)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This patch refactors and documents the setup of the `CreateProcessW` invocation in `ProcessLauncherWindows`. It's a dependency of https://github.com/llvm/llvm-project/pull/168729. `CreateEnvironment

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

https://github.com/charles-zablit converted_to_draft https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] refactor CreateProcessW setup (PR #168733)

https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/168733 This patch refactors and documents the setup of the `CreateProcessW` invocation in `ProcessLauncherWindows`. It's a dependency of https://github.com/llvm/llvm-project/pull/168729. `CreateEnvironmentBuff

[Lldb-commits] [lldb] [lldb][windows] make PseudoTerminal::GetPTY return a shared pointer (PR #168730)

github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33163 tests passed * 494 tests skipped https://github.com/llvm/llvm-project/pull/168730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

github-actions[bot] wrote: # :penguin: Linux x64 Test Results The build failed before running any tests. Click on a failure below to see the details. tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/PseudoTerminal.cpp.o ``` FAILED: tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common

[Lldb-commits] [lldb] [lldb][windows] make PseudoTerminal::GetPTY return a shared pointer (PR #168730)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This patch refactors the `PseudoTerminal::GetPTY` to return an `std::shared_ptr`. This is effectively an NFC patch and is needed for https://github.com/llvm/llvm-project/pull/168729. --- Full diff:

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] make PseudoTerminal::GetPTY return a shared pointer (PR #168730)

https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/168730 This patch refactors the `PseudoTerminal::GetPTY` to return an `std::shared_ptr`. This is effectively an NFC patch and is needed for https://github.com/llvm/llvm-project/pull/168729. >From 7fb9d80faf5e0

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes --- Patch is 59.24 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/168729.diff 33 Files Affected: - (modified) lldb/include/lldb/Host/ProcessLaunchInfo

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/168729 None >From 8792764ad14dba22c4817a6b463d504c429b0d11 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 19 Nov 2025 16:03:17 + Subject: [PATCH] [lldb][windows] add Windows Virtual Console suppor

[Lldb-commits] [lldb] [lldb][windows] add color to the Python.dll not found error (PR #168718)

https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168718 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] add color to the Python.dll not found error (PR #168718)

github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33167 tests passed * 490 tests skipped https://github.com/llvm/llvm-project/pull/168718 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb][windows] add color to the Python.dll not found error (PR #168718)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes Make the `Python.dll not found` error message stand out more by using the `llvm::WithColor::error()` method. --- ### Example Before [Lldb-commits] [lldb] [lldb][windows] add color to the Python.dll not found error (PR #168718)

2025-11-19 Thread Charles Zablit via lldb-commits

https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/168718 Make the `Python.dll not found` error message stand out more by using the `llvm::WithColor::error()` method. --- ### Example Before https://github.com/user-attachments/assets/93960c50-cbf2-41f7-a

[Lldb-commits] [lldb] [lldb] Make sure that the "TypeSystemClang::GetBuiltinTypeByName" method returns the correct value also for "_BitInt(...)" types. (PR #165857)

2025-11-19 Thread via lldb-commits

Matej =?utf-8?q?Ko=C5=A1=C3=ADk?= , Matej =?utf-8?q?Ko=C5=A1=C3=ADk?= Message-ID: In-Reply-To: github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33167 tests passed * 490 tests skipped https://github.com/llvm/llvm-project/pull/165857

[Lldb-commits] [lldb] [lldb] Make sure that the "TypeSystemClang::GetBuiltinTypeByName" method returns the correct value also for "_BitInt(...)" types. (PR #165857)

2025-11-19 Thread Matej Košík via lldb-commits

https://github.com/sedymrak updated https://github.com/llvm/llvm-project/pull/165857 From f9750d0fedc41532ffe7d5048c419cb91d223601 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matej=20Ko=C5=A1=C3=ADk?= Date: Fri, 31 Oct 2025 10:37:26 +0100 Subject: [PATCH 1/3] [lldb] add more tests --- .../sbtype

[Lldb-commits] [lldb] [lldb] Add test showing UnwindAssemblyInstEmulation can't handle backwards branches (PR #168398)

2025-11-19 Thread via lldb-commits

github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33168 tests passed * 490 tests skipped https://github.com/llvm/llvm-project/pull/168398 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb] Add test showing UnwindAssemblyInstEmulation can't handle backwards branches (PR #168398)

2025-11-19 Thread Felipe de Azevedo Piovezan via lldb-commits

felipepiovezan wrote: Rebased to resolve conflicts with newly added test in another PR. https://github.com/llvm/llvm-project/pull/168398 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb] Add test showing UnwindAssemblyInstEmulation can't handle backwards branches (PR #168398)

2025-11-19 Thread Felipe de Azevedo Piovezan via lldb-commits

https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/168398 >From 2f8150509976273c0d4da6f1f68a613e11e68b61 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 19 Nov 2025 14:40:08 + Subject: [PATCH] [lldb] Add test showing UnwindAssemblyInstEm

[Lldb-commits] [lldb] 93a1327 - [lldb] Skip TestLibcxxInternalsRecognizer on asan + MacOS

2025-11-19 Thread Felipe de Azevedo Piovezan via lldb-commits

Author: Felipe de Azevedo Piovezan Date: 2025-11-19T14:27:13Z New Revision: 93a1327deaef7abd5c2bf5caf4c4ef40d34460f6 URL: https://github.com/llvm/llvm-project/commit/93a1327deaef7abd5c2bf5caf4c4ef40d34460f6 DIFF: https://github.com/llvm/llvm-project/commit/93a1327deaef7abd5c2bf5caf4c4ef40d34460

[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread David Spickett via lldb-commits

DavidSpickett wrote: My questions/comments were answered, I leave it to @bulbazord to approve or not. https://github.com/llvm/llvm-project/pull/168603 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread Charles Zablit via lldb-commits

https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168603 >From 2cc2c6b71bd9074464f3a979a1327f0d61ecdb5e Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 19 Nov 2025 12:10:08 +0100 Subject: [PATCH 1/4] [NFC][lldb] move DiagnosticsRendering to Host ---

[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread Charles Zablit via lldb-commits

charles-zablit wrote: > If you feel confident enough in your testing, sure. > > This PR is fine as is though. Worst case it's too cautious and it can be > changed later. I suspect the majority of people will be using Windows > Terminal by now and if they're not, their first instinct would prob

[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread Charles Zablit via lldb-commits

https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168603 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add libstdcpp span formatter (PR #168705)

2025-11-19 Thread via lldb-commits

github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33163 tests passed * 494 tests skipped https://github.com/llvm/llvm-project/pull/168705 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb] add libstdcpp span formatter (PR #168705)

2025-11-19 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/168705.diff 5 Files Affected: - (modified) lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt (+1) - (modified) lldb/source/Plugins/Language/CPl

[Lldb-commits] [lldb] [lldb] add libstdcpp span formatter (PR #168705)

2025-11-19 Thread Ebuka Ezike via lldb-commits

https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/168705 None >From 24cf7b3359beba96c5079d406ebc124e17bb0288 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 18 Nov 2025 19:35:00 + Subject: [PATCH] [lldb] add libstdcpp span formatter --- .../Plugins/Langu

[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread David Spickett via lldb-commits

DavidSpickett wrote: > I used what > [is-unicode-supported](https://www.npmjs.com/package/is-unicode-supported) > uses, which is a very (50M weekly downloads/week) popular NPM package: Good enough for me :+1: > We use WriteConsoleW since https://github.com/llvm/llvm-project/pull/156469, > s

[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread Charles Zablit via lldb-commits

https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168603 >From 2cc2c6b71bd9074464f3a979a1327f0d61ecdb5e Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 19 Nov 2025 12:10:08 +0100 Subject: [PATCH 1/3] [NFC][lldb] move DiagnosticsRendering to Host ---

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread Charles Zablit via lldb-commits

charles-zablit wrote: > I'd like a citation for the WT_SESSION variable. > > And it is a bit worrying that one of the top results for that name is one of > the Windows Terminal devs (I'm pretty sure they are) telling a project not to > use it [Textualize/rich#140](https://github.com/Textualize

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

2025-11-19 Thread Charles Zablit via lldb-commits

@@ -10,7 +10,7 @@ #define LLDB_INTERPRETER_COMMANDRETURNOBJECT_H #include "lldb/Host/StreamFile.h" -#include "lldb/Utility/DiagnosticsRendering.h" +#include "lldb/Host/common/DiagnosticsRendering.h" charles-zablit wrote: Not sure what's the reason (if there i

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

2025-11-19 Thread Charles Zablit via lldb-commits

https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168696 >From 68d063893a74bd93f3bfbec72ffd22ffa35bafc2 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 19 Nov 2025 12:10:08 +0100 Subject: [PATCH 1/2] [NFC][lldb] move DiagnosticsRendering to Host ---

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

2025-11-19 Thread Michael Buch via lldb-commits

@@ -10,7 +10,7 @@ #define LLDB_INTERPRETER_COMMANDRETURNOBJECT_H #include "lldb/Host/StreamFile.h" -#include "lldb/Utility/DiagnosticsRendering.h" +#include "lldb/Host/common/DiagnosticsRendering.h" Michael137 wrote: Unrelated to this PR, but I'm surprised to

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

2025-11-19 Thread via lldb-commits

github-actions[bot] wrote: # :penguin: Linux x64 Test Results The build failed before running any tests. Click on a failure below to see the details. tools/lldb/unittests/Utility/UtilityTests ``` FAILED: tools/lldb/unittests/Utility/UtilityTests : && /opt/llvm/bin/clang++ -gmlt -fPIC -fno-s

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread Charles Zablit via lldb-commits

@@ -7,6 +7,8 @@ //===--===// #include "lldb/Utility/DiagnosticsRendering.h" +#include "lldb/Host/Terminal.h" + #include charles-zablit wrote: Got it, opened https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

2025-11-19 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes NFC patch which moves `DiagnosticsRendering` from `Utility` to `Host`. This refactoring is needed for https://github.com/llvm/llvm-project/pull/168603. It adds a method to check whether the current

[Lldb-commits] [lldb] [llvm] [NFC][lldb] move DiagnosticsRendering to Host (PR #168696)

2025-11-19 Thread Charles Zablit via lldb-commits

https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/168696 NFC patch which moves `DiagnosticsRendering` from `Utility` to `Host`. This refactoring is needed for https://github.com/llvm/llvm-project/pull/168603. It adds a method to check whether the current term

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett commented: I'd like a citation for the WT_SESSION variable. And it is a bit worrying that one of the top results for that name is one of the Windows Terminal devs (I'm pretty sure it is) telling a project not to use it https://github.com/Textualize/rich/issues/

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread David Spickett via lldb-commits

@@ -472,3 +472,18 @@ bool TerminalState::TTYStateIsValid() const { return bool(m_data); } bool TerminalState::ProcessGroupIsValid() const { return static_cast(m_process_group) != -1; } + +bool TerminalSupportsUnicode() { + static std::optional result; + if (result) +re

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/168603 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread David Spickett via lldb-commits

@@ -472,3 +472,18 @@ bool TerminalState::TTYStateIsValid() const { return bool(m_data); } bool TerminalState::ProcessGroupIsValid() const { return static_cast(m_process_group) != -1; } + +bool TerminalSupportsUnicode() { + static std::optional result; + if (result) +re

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

2025-11-19 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/168603 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Correctly skip a test on a 32-bit target (PR #168631)

2025-11-19 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett approved this pull request. LGTM. We didn't catch this on the Arm 32-bit bot because we're not including libcxx there: ``` UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py

[Lldb-commits] [lldb] [lldb][RISCV] Implement trap handler unwind plan (PR #166531)

2025-11-19 Thread Georgiy Samoylov via lldb-commits

https://github.com/sga-sc updated https://github.com/llvm/llvm-project/pull/166531 >From 5cf5867fe73e607f6202153b8ad9039fda5c8592 Mon Sep 17 00:00:00 2001 From: Georgiy Samoylov Date: Thu, 23 Oct 2025 13:12:32 +0300 Subject: [PATCH 1/3] [lldb][RISCV] Implement trap handler unwind plan --- lld

[Lldb-commits] [lldb] [lldb][RISCV] Implement trap handler unwind plan (PR #166531)

2025-11-19 Thread Georgiy Samoylov via lldb-commits

@@ -302,12 +305,90 @@ static lldb::UnwindPlanSP GetAArch64TrapHandlerUnwindPlan(ConstString name) { return unwind_plan_sp; } -lldb::UnwindPlanSP -PlatformLinux::GetTrapHandlerUnwindPlan(const llvm::Triple &triple, -ConstString name) {

[Lldb-commits] [lldb] [lldb][RISCV] Implement trap handler unwind plan (PR #166531)

2025-11-19 Thread Sam Elliott via lldb-commits

@@ -302,12 +305,90 @@ static lldb::UnwindPlanSP GetAArch64TrapHandlerUnwindPlan(ConstString name) { return unwind_plan_sp; } -lldb::UnwindPlanSP -PlatformLinux::GetTrapHandlerUnwindPlan(const llvm::Triple &triple, -ConstString name) {

[Lldb-commits] [lldb] [lldb] [scripting bridge] 167388 chore: add api to return arch name for target (PR #168273)

2025-11-19 Thread via lldb-commits

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r origin/main...HEAD lldb/examples/python/templates/scripted_process.py lldb/test/API/pytho

[Lldb-commits] [lldb] [lldb] [scripting bridge] 167388 chore: add api to return arch name for target (PR #168273)

2025-11-19 Thread via lldb-commits

https://github.com/n2h9 updated https://github.com/llvm/llvm-project/pull/168273 >From d98da7c2df181f89560cc382208a9b4c6cff88f7 Mon Sep 17 00:00:00 2001 From: Nikita B Date: Sun, 16 Nov 2025 15:46:12 +0100 Subject: [PATCH 1/5] [lldb] 167388 chore: add api to return arch name for target Signed-

[Lldb-commits] [lldb] [lldb][RISCV] Fix float load and stores in RISC-V emulator (PR #167490)

2025-11-19 Thread David Spickett via lldb-commits

@@ -1328,32 +1328,36 @@ class Executor { m_emu, inst, 8, ZextD, [](uint64_t a, uint64_t b) { return std::max(a, b); }); } - template - bool F_Load(T inst, const fltSemantics &(*semantics)(), - unsigned int numBits) { + template + bool F_Load

[Lldb-commits] [lldb] [lldb] [scripting bridge] 167388 chore: add api to return arch name for target (PR #168273)

2025-11-19 Thread via lldb-commits

https://github.com/n2h9 edited https://github.com/llvm/llvm-project/pull/168273 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [scripting bridge] 167388 chore: add api to return arch name for target (PR #168273)

2025-11-19 Thread Jonas Devlieghere via lldb-commits

@@ -1614,6 +1614,19 @@ const char *SBTarget::GetTriple() { return nullptr; } +const char *SBTarget::GetArchName() { + LLDB_INSTRUMENT_VA(this); + + if (TargetSP target_sp = GetSP()) { +std::string arch_name = +target_sp->GetArchitecture().GetTriple().getArchNam

[Lldb-commits] [lldb] [lldb] Push down the SWIG module to avoid an import cycle (PR #166265)

2025-11-19 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/166265 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [scripting bridge] 167388 chore: add api to return arch name for target (PR #168273)

2025-11-19 Thread Jonas Devlieghere via lldb-commits

@@ -105,6 +105,20 @@ def test_resolve_file_address(self): self.assertIsNotNone(data_section2) self.assertEqual(data_section.name, data_section2.name) +def test_get_arch_name(self): +d = {"EXE": "b.out"} +self.build(dictionary=d) +sel

[Lldb-commits] [lldb] [LLDB][Docs] List available settings (PR #168245)

2025-11-19 Thread Med Ismail Bennani via lldb-commits

https://github.com/medismailben approved this pull request. Pretty cool! I was a bit skeptical to put the generator command in `lldb-test`. Why not use the main `lldb` binary for this ? https://github.com/llvm/llvm-project/pull/168245 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Avoid duplicate calls to GetInstructionCondition in UnwindAssemblyInstEmulation (PR #168340)

2025-11-19 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/168340.diff 1 Files Affected: - (modified) lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp (

[Lldb-commits] [lldb] [lldb] [disassembler] chore: update VariableAnnotator::Annotate to except only Instruction as param and drop module and target (PR #168276)

2025-11-19 Thread via lldb-commits

https://github.com/n2h9 edited https://github.com/llvm/llvm-project/pull/168276 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [scripting bridge] 167388 chore: add api to return arch name for target (PR #168273)

2025-11-19 Thread via lldb-commits

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] [disassembler] chore: update VariableAnnotator::Annotate to except only Instruction as param and drop module and target (PR #168276)

2025-11-19 Thread via lldb-commits

https://github.com/n2h9 edited https://github.com/llvm/llvm-project/pull/168276 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [scripting bridge] 167388 chore: add api to return arch name for target (PR #168273)

2025-11-19 Thread via lldb-commits

@@ -105,6 +105,20 @@ def test_resolve_file_address(self): self.assertIsNotNone(data_section2) self.assertEqual(data_section.name, data_section2.name) +def test_get_arch_name(self): +d = {"EXE": "b.out"} +self.build(dictionary=d) +sel

  1   2   3   4   >