[Lldb-commits] [PATCH] D104627: [lldb] Add support for escaping zsh arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc197cddb16b3: [lldb] Add support for escaping zsh arguments (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

teemperor added a comment. In D104437#2825559 , @nealsid wrote: > Ah, my grep/find skills clearly failed me :) > > Yeah, those tests are exactly the same scenarios. However, if I understand > correctly, don't they use the API? I wanted to add some

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a2d4f3f24a3: [lldb] Enable Rust v0 symbol demangling (authored by Alexander Mols a...@fb.com, committed by teemperor). Repository: rG LLVM

[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f20e6ae3229: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D104067#2825199 , @bulbazord wrote: > ping! Sorry, feel free to me directly sooner :) I ran some benchmarks and this changed

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Could you move this function into the `Debugger` class and just make `SBDebugger` forward to that function? We usually keep the `SB*` classes as thin wrappers that only

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

teemperor added a comment. In D104525#2830025 , @DavidSpickett wrote: > Yeah good point, I can do that. I'm gonna go over the remaining SetStatus > calls first, then I'll look at it. Thank you, really appreciated! Repository: rG LLVM Github

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

teemperor added a comment. LGTM, thanks for cleaning this up. If we're anyway signing up @DavidSpickett for refactoring duty: `CommandReturnObject::SetError(llvm::StringRef error_str)` is clearly the same method as `CommandReturnObject::AppendError`, so one of those probably should go the way

[Lldb-commits] [PATCH] D104448: [lldb] Remove redundant calls to set eReturnStatusFailed

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM now, just a small nit about the redundant "error: " string. Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:879 if (command.GetArgumentCount()

[Lldb-commits] [PATCH] D104448: [lldb] Remove redundant calls to set eReturnStatusFailed

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. There are two places where this isn't redundant (see inline comments) but otherwise this LGTM. Thanks! Comment at:

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.h:117 +// (CU, (DIE)nullptr) == (nullptr, nullptr) -> true +if (!m_die.IsValid() && !it.m_die.IsValid()) + return true; shafik wrote: > I think: > > ``` >

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor updated this revision to Diff 352666. teemperor added a comment. Herald added a subscriber: mgorny. - Added a unit test (thanks Shafik!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103172/new/ https://reviews.llvm.org/D103172 Files:

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for writing tests, it's really appreciated! FWIW, I think that you can just check in new tests without having to go through a full review (unless you do want feedback

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM and passes on macOS and Linux for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104379/new/

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. At least on the test suite on Linux that branch is anyway never taken, so LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8567559cf38: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect… (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

teemperor added a comment. > In fact, the same idea also occurred to me before. I think it's also > achievable by a plugin sphinx-code-tabs. I like that idea! We do have to give the peopler running the docs bot a heads up though that they need to install that plugin, but I can take care of

[Lldb-commits] [PATCH] D104307: [lldb] Remove SBHostOS threading functionality

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: krytarowski. teemperor requested review of this revision. Follow up patch for D104231 which deprecates this in the SB API. This removes the threading functionality

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. > Personally I think if there is the pointer (and sizeof(std::unique_ptr YYY> == 16) there should be the "deleter =" specified even if it is default > deleter. I don't think that it can

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the way the provider is supposed to work is that there is always `deleter` child as long as it's not `default_delete`, so I think we have to check for the name to

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

teemperor added a comment. Instead of copying the text from the Python page, I was actually thinking whether we should make the 'scripting' page more generic and just add the language-specific examples for Python and Lua there. I am not sure what's the best way to do that visually though with

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Not sure what happened to my accept, but I'll LGTM this again. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104041/new/ https://reviews.llvm.org/D104041

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

teemperor added a comment. Not sure what else we should do to properly deprecate an API. LLVM's approach would be to put `[[deprecated("bla")]]` the C++ APIs (which would mean you need a C++14 compiler to use the SB API) and there is also the `lldb-versioning.h` header (which seems to be

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

teemperor updated this revision to Diff 351882. teemperor added a comment. Herald added a subscriber: JDevlieghere. - Remove the deprecation attribute that got inserted by accident. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104231/new/ https://reviews.llvm.org/D104231 Files:

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SBHostOS implements a threading framework that allows creating and manipulating OS threads in the current process.

[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. HostInfoBase has a deleted dtor/ctor so there is no need to do the

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11e2922bb7ad: [lldb][docs] Document SBType (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

teemperor updated this revision to Diff 351819. teemperor added a comment. - Make language more uniform - Point out anonymous struct is a GNU extension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103454/new/ https://reviews.llvm.org/D103454 Files: lldb/bindings/interface/SBType.i

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

teemperor added a comment. In D103675#2800653 , @brucem wrote: > Not sure why this failed. Is it perhaps a difference where some processes > have args including the executable and some do not? Do you have the bot failures around for that? (Or, the

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! (And congrats on your first patch) I'll land this for you next week just to give the others another chance to take a look. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D81550: [lldb] Add support for evaluating expressions in static member functions

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Reopen because of the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81550/new/ https://reviews.llvm.org/D81550

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D104067#2811834 , @jingham wrote: > This looks pretty good to me. > > It's a little awkward in InitNameIndexes that we look up the

[Lldb-commits] [PATCH] D104091: [lldb] Fix leak in test

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, big thanks for the patch & quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104091/new/

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632cbcac7906: [lldb] Move once_flags in HostInfoLinux so the internal state struct (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D104091: [NFC][lldb] Fix leak in test

teemperor added inline comments. Comment at: lldb/unittests/Host/HostInfoTest.cpp:64 + +TEST(HostInfoTest2, InitTwice) { + llvm::VersionTuple Version; `HostInfoTestInitialization` maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104091: [NFC][lldb] Fix leak in test

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think we should instead implement the `Terminate` function that the plugin system provides to tear down our state. I made a patch in D104093

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

teemperor created this revision. teemperor added reviewers: vitalybuka, LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. The HostInfoLinuxFields struct is supposed to be set up/torn down on Initialize/Terminate and

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor added inline comments. Comment at: lldb/unittests/Core/MangledTest.cpp:72 + + EXPECT_STREQ("", TheDemangled.GetCString()); +} asm wrote: > teemperor wrote: > > Could you do me a favour and change your test functions to LLDB's code > > style, so

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor added a comment. This seems reasonable to me, but I'll leave this open for a while in case someone that knows more about Rust mangling shows up. Otherwise I'll accept this next week. Comment at: lldb/source/Core/Mangled.cpp:213 +else + LLDB_LOGF(log,

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

teemperor added a comment. Sure I can take a look, but I don't see the immediate problem when looking at the backtrace. I assume it takes some time to reduce the bug in Chrome? If you could get me the `dump()` output for the Decls `D`, `(Decl*)ToDC`, `FromRD`, `ToD`,

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

teemperor added a comment. LGTM beside some minor formatting bugs that got exacerbated by the clang-tidy run. I got bored of writing 'format' everywhere so I translated every comment into a different language via Google translate. I'll already accept this as this is easy to fix.

[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers

teemperor accepted this revision. teemperor added a comment. This doesn't compile for me (on Linux): In file included from /home/teemperor/work/ci/llvm-project/lldb/unittests/Platform/PlatformAppleSimulatorTest.cpp:11: In file included from

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

teemperor added a comment. In D103701#2804840 , @DavidSpickett wrote: > I've gone ahead and landed it, will revert on failures. > > Got patches to remove the reundant calls locally so I'll put those up for > review once this has had time to go through.

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Some small rename I forgot to point out, but LGTM modulo that rename. Thanks for cleaning this up! Comment at: lldb/include/lldb/Symbol/Symtab.h:186 private: +

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

teemperor added a comment. Oh I see, you're not just concerned about just having every command in the test suite covered before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103701/new/ https://reviews.llvm.org/D103701

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

teemperor added a comment. I can run this for you on macOS and Linux x86 which I think should cover every test. FWIW, there is even more redundancy from what I remember as we IIRC return false within `bool DoExecute` everywhere. I can't recall why I didn't remove this yet (beside that it's a

[Lldb-commits] [PATCH] D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a655c62eca8: [lldb][NFC] Remove a redundant call to weak_ptr::expired (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Only have some comments about the way `FindFunctionSymbols` is now implemented, but otherwise this LGTM. Comment at: lldb/include/lldb/Symbol/Symtab.h:177

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

teemperor added inline comments. Comment at: lldb/bindings/interface/SBProcessInfo.i:78 + +%feature("docstring", +"Return the specified argument given to the described process." Can you add this line here? ``` %feature("autodoc", "GetArgumentAtIndex(int

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

teemperor added a comment. Sorry for the delay! > We have a method called `Language::GetMethodNameVariants`, that could be > extended/modified to be more suitable. Unless you had something else in mind? > Maybe something more specific to Symtab mapping like >

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

teemperor added a comment. In D103454#2793219 , @werat wrote: > Is this code used for auto-generated docs? Could be have this documentation > in C++ definitions (lldb/API/SBType.h) as well? I usually just read the C++ > source code, but I can imagine

[Lldb-commits] [PATCH] D103532: [lldb] Preserve type sugar when using SBValue::Dereference on C++ references

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ec761c3fc2a: [lldb] Preserve type sugar when using SBValue::Dereference on C++ references (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D103483: [lldb] Convert the default constructor’s member initializers into default member initializers

teemperor added a comment. +1. I'm anyway doing the same whenever I have to touching constructors, so we might as well pull out the big hammer. I'm also glad you volunteer to resolve all the downstream conflicts :) Comment at:

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

teemperor added a comment. In D103439#2791298 , @JDevlieghere wrote: > LGTM. Are there other places where we check this, either in `lldbutil` or > maybe more generally a pattern in the tests that could be extracted into a > helper? From what I can

[Lldb-commits] [PATCH] D103158: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecfca427f960: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01fb14e17763: [lldb] Remove SBCommandReturnObject::ref (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

teemperor added a comment. The language here might shift between functions and needs to be synced up (that patch was written over a few weeks during some build/test idle time). But the patch seems good enough for a draft. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. This documents the behaviour of the different SBType functions with

[Lldb-commits] [PATCH] D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. The `lock` call directly will check for us if the `weak_ptr` is

[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit

teemperor created this revision. teemperor added a reviewer: JDevlieghere. teemperor added a project: LLDB. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. At the moment if a test fails to hits the breakpoint we set in `run_to_source_breakpoint` the test

[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

teemperor created this revision. teemperor added a reviewer: JDevlieghere. teemperor added a project: LLDB. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. I noticed that there might be some missing instrumentation after a related change popped up in D103381

[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

teemperor added a comment. IIUC this was originally public but then we made the other users friends (but the public remained). But still putting this up for review in case I missed something Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

teemperor created this revision. teemperor added a reviewer: jankratochvil. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. This function was added in D67589

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

teemperor added a comment. I assume you don't have requested commit access yet (?) so I'm going to land this for you. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM but could you split out the non-NFC change (and then you can also mark this whole commit as NFC). I'm just going to accept this module that change. Comment at:

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

teemperor added inline comments. Comment at: lldb/source/API/SBProcessInfo.cpp:191 + // the string + triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString(); +} brucem wrote: > teemperor wrote: > > You need to 'instrument' these

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

teemperor added inline comments. Comment at: lldb/source/API/SBProcessInfo.cpp:191 + // the string + triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString(); +} You need to 'instrument' these functions. there is a tool called

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

teemperor added a comment. +1 to not add any language-specific terms to the Language API. Looking over the code, it seems what the code is doing its: - Going over the symbol names. - Creating a search index from the symbol names that is optionally grouped via the `FunctionNameType` cases (and

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd28bc54ff44a: [lldb] Remove cache in get_demangled_name_without_arguments (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. teemperor requested review of this revision. This patch adds the ability to get a DWARFDIE's children as an LLVM range.

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

teemperor added a comment. In D103107#2780769 , @shafik wrote: > was there a bug that inspired this? Nope, the code just looked bogus when I scrolled over it while looking for something else. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

teemperor added inline comments. Comment at: lldb/source/Core/Mangled.cpp:38 -static ConstString -get_demangled_name_without_arguments(ConstString mangled, - ConstString demangled) { - // This pair is - static std::pair -

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. This function has a single-value caching based on function local static variables. This causes two problems:

[Lldb-commits] [PATCH] D102845: [lldb] Fix that LLDB doesn't print NaN's sign on Darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae58cf5f45a9: [lldb] Fix that LLDB doesnt print NaNs sign on Darwin (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D102677: [lldb][NFC] Remove misleading ModulePass base class for IRForTarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dee479ff632: [lldb][NFC] Remove misleading ModulePass base class for IRForTarget (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bf96b0329be: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba51da820e4d: [lldb] Add missing mutex guards to TargetList::CreateTarget (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D102771: [lldb] Introduce createTestTarget for creating a valid target in API tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c2687292da: [lldb] Introduce createTestTarget for creating a valid target in API tests (authored by teemperor). Herald added subscribers:

[Lldb-commits] [PATCH] D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. TestMultipleTargets is randomly failing on the bots. The reason for that is that the test is calling

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

teemperor accepted this revision. teemperor added a comment. `ABISysV_ppc.cpp` feels a bit like this should be used to calculate some offset, but I don't think that's for this review to figure out what is wrong there. The other LLDB changes LGTM. Comment at:

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

teemperor added reviewers: stella.stamenova, amccarth. teemperor added a comment. No idea about how/if this is used, but I think Stella or Adrian are the ones that might be able to answer this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Soon LLDB will be as nicely layered (and maybe as tasty) as some good Schichttorte Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

teemperor added a comment. Herald added a subscriber: JDevlieghere. First and foremost: Cool new username. +1 from me. Otherwise I think Shafik's comment in D79752 still applies here. Could you make a short utility function for that chunk of code and put in

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

teemperor commandeered this revision. teemperor edited reviewers, added: xiaobai; removed: teemperor. teemperor added a comment. Replaced by D102811 and Alex has apparently a new account, so closing this. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Sorry, I meant you can just commit this without review :) (also you probably want to actually remove the skipIf) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Nice, and it's not even my birthday. Just some nits that don't need another round of review. Comment at:

[Lldb-commits] [PATCH] D102597: [lldb][NFC] Remove all uses of StringRef::withNullAsEmpty in LLDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbea361039c1: [lldb][NFC] Remove all uses of StringRef::withNullAsEmpty in LLDB (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:409 + // static MyClass *__lldb_expr_result_ptr = // Points to stack. + // __lldb_expr_result_ptr(__lldb_expr_result_ptr); + // } // End of

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:2026 + i = call->eraseFromParent(); + continue; +} I do wish we had a better way to do the iterate-while-erase algorithm

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. At the moment we codegen or interpret the IR in exactly the way as it is generated by Clang. This patch runs

[Lldb-commits] [PATCH] D101056: [lldb] Let dotest check for the `cassert` header instead of `algorithm` for libc++ check

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b614eb4ea6c: [lldb] Let dotest check for the `cassert` header instead of `algorithm` for… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG4112f5ef69a1: [lldb][NFC] Specify guidelines for API tests (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102597: [lldb][NFC] Remove all uses of StringRef::withNullAsEmpty in LLDB

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. A long time ago LLDB wanted to start using StringRef instead of C-Strings/ConstString but was blocked by the

[Lldb-commits] [PATCH] D102544: [lldb] Document ctrl-f for completing show-autosuggestion

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think fish shell (where I got that idea from) calls this "*accepting* a suggestion" which seems clearer than "completing a suggestion". Otherwise this LGTM, thanks! Repository: rG

[Lldb-commits] [PATCH] D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember

teemperor accepted this revision. teemperor added a comment. I think this can just land as an optimisation. If we can read the size from DWARF (e.g., just returning the stored size int) then that's much better than computing the layout for some type. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

teemperor accepted this revision. teemperor added a comment. LGTM, just some nits and please address the clang-format issue. Comment at: lldb/unittests/Symbol/TestTypeSystemClang.cpp:747 +TEST_F(TestTypeSystemClang, GetExeModuleWhenMissingSymbolFile) { + auto compiler_type =

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

teemperor added a comment. I think some people are already building with this warning + -Werror so this should be fine (Apparently that list of people includes me and Stella as I fixed a warning that broke the build in https://reviews.llvm.org/D99694#2671667 ) Repository: rG LLVM Github

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

teemperor added a comment. FWIW, I think the idea was for LLVM to actually move to LLDB's function naming, so our life will soon(TM) be easier when/if that happens. I also agree that the CapitalizedVariableNames in Clang have some difficulties (especially when they conflict with class names),

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

teemperor added a comment. Jepp, they are capitalized :) FWIW, maybe we should see if we can fix this at the next US dev meeting (which hopefully happens). git has by now a filter for mass-refactors so the only problem is getting everyone to on board with breaking the whole code base and make

[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

teemperor added inline comments. Comment at: lldb/unittests/Core/DumpDataExtractorTest.cpp:40 +} + +static void testDumpWithOffset(offset_t start_offset, I think you missed the capitalisation here and in the function above :) Repository: rG LLVM Github

<    1   2   3   4   5   6   7   8   9   10   >