[Lldb-commits] [PATCH] D89698: [lldb] Fix TestTargetAPI.py on Apple simulators

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d5590d171c: [lldb] Fix TestTargetAPI.py on Apple simulators (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89056: [lldb] Explicitly use the configuration architecture when building test executables

This revision was automatically updated to reflect the committed changes. Closed by commit rG41185226f6d8: [lldb] Explicitly use the configuration architecture when building test… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

teemperor added a comment. Thanks for refactoring this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89428/new/ https://reviews.llvm.org/D89428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1525 + // If the SDK type is for the host OS, use its version number. + auto

[Lldb-commits] [PATCH] D89310: [lldb] Reject redefinitions of persistent variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb81e662a589: [lldb] Reject redefinitions of persistent variables (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

teemperor added a comment. In D89295#2327751 , @kastiglione wrote: > For lldbinit files, and any file that gets `command source`'d, I think it > would be useful if they could perform `command script import > some/path/to/command.py`, where `some` is

[Lldb-commits] [PATCH] D88950: [lldb][cmake] Remove custom logic for finding VCS file to fix LLDB's VCSVersion.inc generation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6733b2544794: [lldb][cmake] Remove custom logic for finding VCS file to fix LLDBs VCSVersion. (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D88889: [lldb] Allow limiting the number of error diagnostics when parsing an expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG02114e15daad: [lldb] Allow limiting the number of error diagnostics when parsing an expression (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D88490: [lldb] Remove all the RegisterInfo name constification code

This revision was automatically updated to reflect the committed changes. Closed by commit rG24e07570cc92: [lldb] Remove all the RegisterInfo name constification code (authored by teemperor). Herald added subscribers: lldb-commits, jrtc27. Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D88910: [lldb][NFC] Remove property predicate matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cd873c4bd7f: [lldb][NFC] Remove property predicate matcher (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D89224: [lldb] Add targets for running test suite against Watch/TV/iPhone simulators

This revision was automatically updated to reflect the committed changes. Closed by commit rGef733d9df486: [lldb] Add targets for running test suite against Watch/TV/iPhone simulators (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to

[Lldb-commits] [PATCH] D89052: [lldb] Don't add no-sandbox entitlement when running tests on simulator

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfc72439529c: [lldb] Dont add no-sandbox entitlement when running tests on simulator (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D89053: [lldb] Don't let dotest silently fall back to default SDK if the specified one can't be found

This revision was automatically updated to reflect the committed changes. Closed by commit rG480c440f9a3c: [lldb] Dont let dotest silently fall back to default SDK if the specified one… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D89106: [lldb] Fill Watch/AppleTV simulator gaps in PlatformDarwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4f4d54ae0d8: [lldb] Fill Watch/AppleTV simulator gaps in PlatformDarwin (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

teemperor added a comment. In D89295#2327367 , @labath wrote: > What exactly is the use case for this? Xcode running a project-specific lldbinit file but users can't specify a `command script import relative/path/script.py` as the CWD for the

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yeah there isn't a lot of unused code left here. If you want you can make a follow up replacing all the C-string logic with `std::string` (and removing the static local result var as

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

teemperor added a reviewer: JDevlieghere. teemperor added a comment. LLDB_REVISION and LLDB_REPOSITORY are coming from VCSVersion.inc where it should be defined as a string. However the generation of that file seems to be broken since the monorepo migration. I put up a patch here that gets this

[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rGce4d15fe142e: [lldb] Symlink the Clang resource directory to the LLDB build directory in… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for fixing all of this! Beside the assertion this LGTM. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must

[Lldb-commits] [PATCH] D88704: [lldb] Fix bug in fallback logic for finding the resource directory.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88704/new/ https://reviews.llvm.org/D88704 ___

[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.

teemperor added a comment. Yeah, this is just to prevent the MIPS backend from hitting the assert (well, and get the related code to actually do what it's supposed to do). This whole code on my "to refactor" list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88302: [lldb] Remove nothreadallow from SWIG's __str__ wrappers to work around a Python>=3.7 crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG070a1d562b30: [lldb] Remove nothreadallow from SWIGs __str__ wrappers to work around a… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

teemperor added a comment. This also doesn't work on my macOS system: FAIL: LLDB (/Users/teemperor/1llvm/rel/bin/clang-x86_64) :: test_stop_hooks_scripted_return_false (TestStopHookScripted.TestStopHooks) == FAIL:

[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe779427757f2: Fix MIPS and MIPS64 ABI to use ConstString in their register info arrays. (authored by tatsuo, committed by teemperor). Repository:

[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.

teemperor added a comment. Done. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88375/new/ https://reviews.llvm.org/D88375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. To clarify the description a bit: `RegInfoBasedABI::GetRegisterInfoByName` is comparing the name/alt_name by doing a `const char *` pointer value comparison. That only works if both

[Lldb-commits] [PATCH] D87481: [lldb] Ignore certain Clang type sugar when creating the type name

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e49e91cb90: [lldb] Ignore certain Clang type sugar when creating the type name (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

teemperor added a comment. In D87327#2263971 , @kastiglione wrote: > @teemperor I'm not sure what these build errors mean, for example > https://reviews.llvm.org/B70998. Also there's the linux build failure, but > that's not relevant for debugserver,

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:41 focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false), - stop_at_entry(false),

[Lldb-commits] [PATCH] D85141: [lldb] Enable std::pair in CxxModuleHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rGb85222520f86: [lldb] Enable std::pair in CxxModuleHandler (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D85648: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG7866b9140569: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D87289: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when trying to complete a forward decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG32c8da41dc0c: [lldb] Dont infinite loop in SemaSourceWithPriorities::CompleteType when… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

teemperor added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87345/new/ https://reviews.llvm.org/D87345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! (And also having the second list of comments no longer always stating 'SpringBoard' is even better). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

teemperor added a comment. I have to agree with @kastiglione that this isn't very intuitive. I doubt that more than a handful of users are aware that "raw commands" are a thing, so I think this inconsistency is for once in favor of the user. LLDB commands are anyway not meant to be stable, so

[Lldb-commits] [PATCH] D87076: [lldb/Interpreter] Fix language detection for the REPL InitFile

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This patch sparks joy, but the fact that this all is dead code without Swift doesn't spark joy. But as it's up to me to revive this code and the downstream Swift test looks fine, I'll

[Lldb-commits] [PATCH] D87036: [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b354d204d09: [lldb] Make symbol list output from `image dump symtab` not depend on internal… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D86336: [debugserver] Fix that debugserver's stop reply packets always return signal code 0

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0699d910914: [debugserver] Fix that debugservers stop reply packets always return signal… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

teemperor added a comment. In D85993#2253465 , @amccarth wrote: > In D85993#2220724 , @labath wrote: > >> Dwarf parser uses `TypeSystemClang::AddMethodToCXXRecordType` instead of >> this function to create methods

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86996/new/ https://reviews.llvm.org/D86996 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

teemperor requested changes to this revision. teemperor added a comment. So CommandObjectRaw does support arguments, but they way it works is that you need to have a delimiter for the 'raw' part which is `--`. If you have that, then you can just use invoke the normal option parsing like

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Don't see an obvious fix, so I reverted for Jonas in 7c80f2da812e45bbdfa3c8f9ab24440f8ef3362a Repository: rG

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. One nit about naming and another small thing, but otherwise this LGTM. Comment at: lldb/include/lldb/Utility/Reproducer.h:242 +struct ReplayOptions { + bool

[Lldb-commits] [PATCH] D84142: [lldb] tab completion for class `CommandObjectTypeFormatterDelete`

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cd99fe9d416: [lldb] tab completion for class `CommandObjectTypeFormatterDelete` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D86593: [lldb] Don't crash when LLDB can't extract the tsan report

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c5a0cb1c3bf: [lldb] Dont crash when LLDB cant extract the tsan report (authored by teemperor). Herald added subscribers: lldb-commits, danielkiss. Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. As discussed offline, I think the warnings here seem also useful when just replaying. I guess we should make it clear that things like missing files are fine when replaying a

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

teemperor accepted this revision. teemperor added a comment. LGTM too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86616/new/ https://reviews.llvm.org/D86616 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D86603: [lldb] Correct wording of EXP_MSG

teemperor added a comment. That's true, `EXP_MSG` is not used like the other messages so the only problem with it is the confusing error message. IMHO this is still good to land as it improves the error message. If you want to implement Pavel's much nicer error message in a follow-up patch,

[Lldb-commits] [PATCH] D86603: [lldb] Correct wording of EXP_MSG

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. FWIW, I actually think this patch itself is perfectly fine. As these messages are only displayed when an assert failed they should be worded with the assumption that the assert did

[Lldb-commits] [PATCH] D86603: [lldb] Correct wording of EXP_MSG

teemperor added a reviewer: LLDB. teemperor added a comment. If you look at the other "assert messages" above and below your patch you'll see that all (most?) of them use this very confusing "Say the opposite of what actually happened" style. Weirdly enough only around 70% of the "assertion

[Lldb-commits] [PATCH] D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID

teemperor added a comment. Seems like this were just some missing calls to initialize/terminate. I added them in an ugly hotfix commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86389/new/ https://reviews.llvm.org/D86389

[Lldb-commits] [PATCH] D86211: [lldb] Don't ask for QOS_CLASS_UNSPECIFIED queue in TestQueues

This revision was automatically updated to reflect the committed changes. Closed by commit rG7de7fe5d0e3f: [lldb] Dont ask for QOS_CLASS_UNSPECIFIED queue in TestQueues (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID

teemperor added a comment. Pretty sure this broke some tests http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/23476/ Note: Google Test filter = SymbolsTest.LocateExecutableSymbolFileForUnknownExecutableAndMissingSymbolFile [==] Running 1 test from 1 test case.

[Lldb-commits] [PATCH] D84124: [lldb] type category name common completion

This revision was automatically updated to reflect the committed changes. Closed by commit rG188f1ac301c5: [lldb] type category name common completion (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D85284: [lldb] Remote disk file/directory completion for platform commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cd8d7b1727f: [lldb] Remote disk file/directory completion for platform commands (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D80700: [lldb] common completion for process pids and process names

This revision was automatically updated to reflect the committed changes. Closed by commit rG19311f5c3e9a: [lldb] common completion for process pids and process names (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

teemperor added a reviewer: JDevlieghere. teemperor added a comment. Thanks for working on this! This looks good to me, but I wonder if doing this with a dedicated flag instead of an environment variable would be better. But I'll leave that to the others who have a better idea how the dotest

[Lldb-commits] [PATCH] D79887: [lldb] Tab completion for process load/unload

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1cd7cac8a36: [lldb] Tab completion for process load/unload (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D80693: [lldb] tab completion for breakpoint names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG22e63cba17e5: [lldb] tab completion for breakpoint names (authored by MrHate, committed by teemperor). Herald added a

[Lldb-commits] [PATCH] D86216: [lldb] Forcefully complete a type when adding typedefs

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86216/new/ https://reviews.llvm.org/D86216

[Lldb-commits] [PATCH] D85970: [lldb] Fix that log enable's -f parameter causes LLDB to crash when it can't open the log file

teemperor added a comment. In D85970#2221899 , @max-kudr wrote: > @teemperor LLDB Windows buildbot > is failing after last > commit: Build 18298 >

[Lldb-commits] [PATCH] D83933: [lldb] Don't delete orphaned shared modules in SBDebugger::DeleteTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rG24c74f5e8c2c: [lldb] Dont delete orphaned shared modules in SBDebugger::DeleteTarget (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. +1 for AddMethodToCXXRecordType. Calling CreateFunctionDeclaration creates a FunctionDecl which can't be inside a record. All (static/non-static) member functions in a record

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::GarbageCollectAllocatedModules and clear modules after each test run

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f9454a16e4: [lldb] Add SBModule::GarbageCollectAllocatedModules and clear modules after… (authored by teemperor).

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::GarbageCollectAllocatedModules and clear modules after each test run

teemperor updated this revision to Diff 285938. teemperor retitled this revision from "[lldb] Add SBModule::ClearCachedModules and clear modules after each test run" to "[lldb] Add SBModule::GarbageCollectAllocatedModules and clear modules after each test run". teemperor edited the summary of

[Lldb-commits] [PATCH] D85970: [lldb] Fix that log enable's -f parameter causes LLDB to crash when it can't open the log file

This revision was automatically updated to reflect the committed changes. Closed by commit rG867c347c32e2: [lldb] Fix that log enables -f parameter causes LLDB to crash when it cant… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D85890: [lldb] Get lldb-server platform's --socket-file working again

This revision was automatically updated to reflect the committed changes. Closed by commit rGc57ea1b48f26: [lldb] Get lldb-server platforms --socket-file working again (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D84299: [lldb][NFC] Remove stride parameter from GetArrayElementType

This revision was automatically updated to reflect the committed changes. Closed by commit rG5913f2591c45: [lldb][NFC] Remove stride parameter from GetArrayElementType (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D83874: [lldb] Print the exception traceback when hitting cleanup errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG24fc3177c176: [lldb] Print the exception traceback when hitting cleanup errors (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D85968: [lldb] Forcefully complete a type when adding nested classes

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:233 -static void CompleteExternalTagDeclType(TypeSystemClang , -

[Lldb-commits] [PATCH] D82537: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rGf974d64b372c: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D85903: [lldb] Fix a crash when tab-completion an empty line in a function with only one local variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbe3c479a6ad: [lldb] Fix a crash when tab-completion an empty line in a function with only… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D85915: [lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilename

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This fills my heart with joy. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85915/new/ https://reviews.llvm.org/D85915

[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Is it too late to claim that I did this on purpose to see if anyone noticed the bug? It probably is :/ Comment at:

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

teemperor added a comment. I'll leave the test review to Pavel who knows that much better, but I have two last nits about the test. Comment at: lldb/test/Shell/SymbolFile/DWARF/valueobject-pass-by-reg.s:59 +# +# 86dea1f39bd127776b999e10dff212003068d30a +# I

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

This revision was automatically updated to reflect the committed changes. Closed by commit rG246afe0cd17f: [lldb] Display autosuggestion part in gray if there is one possible suggestion (authored by gedatsu217, committed by teemperor). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D83792: [lldb] Add support for checking children in expect_expr

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd0fdf80301e: [lldb] Add support for checking children in expect_expr (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D82537: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage

teemperor added reviewers: JDevlieghere, davide. teemperor added a comment. Ping Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82537/new/ https://reviews.llvm.org/D82537 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D85132: [lldb] Add SubstTemplateTypeParm to RemoveWrappingTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rG950f1bf976b3: [lldb] Add SubstTemplateTypeParm to RemoveWrappingTypes (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D84104: [lldb] watchpoint ID common completion for commands `watchpoint delete/enable/disable/modify/ignore`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f3559db1f31: [lldb] watchpoint ID common completion for commands `watchpoint… (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D84088: [lldb] thread index common completion for commands like `thread select/step-over`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa952fe236f99: [lldb] thread index common completion for commands like `thread select/step… (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D84123: [lldb] stop-hook ID common completion for commands `target stop-hook enable/disable/delete'

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2b7dbb47aa9: [lldb] stop-hook ID common completion for commands `target stop-hook… (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D85719: Initialize static const fields in the AST for expression evaluation

teemperor added a comment. There is actually https://reviews.llvm.org/D81471 that makes this fully work, but it's still waiting on someone to review it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85719/new/ https://reviews.llvm.org/D85719

[Lldb-commits] [PATCH] D83309: [lldb] tab completion for `target modules search-paths insert​`

This revision was automatically updated to reflect the committed changes. Closed by commit rG24bc8afd4baf: [lldb] tab completion for `target modules search-paths insert​` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D81128: [lldb] tab completion for 'command delete/unalias'

This revision was automatically updated to reflect the committed changes. Closed by commit rG31fd64ac57a2: [lldb] tab completion for command delete/unalias (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D83234: [lldb] tab completion for `thread plan discard`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf99a18bbaa02: [lldb] tab completion for `thread plan discard` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D85633: [lldb][NFC] Remove unused custom reimplementation of realpath for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG51117e3c5175: [lldb][NFC] Remove unused custom reimplementation of realpath for Windows (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D84177: [lldb] tab completion for `watchpoint set variable`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e653327e364: [lldb] tab completion for `watchpoint set variable` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Also signing this off as I think this is in a good enough state to land. The remaining issues can all be follow-up patches. Also you might want to change your editor to remove trailing

[Lldb-commits] [PATCH] D84179: [lldb] tab completion for `platform target-install`

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3820570d406: [lldb] tab completion for `platform target-install` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

teemperor added a comment. I just have a small comment about the test. If you build the test with an llvm.org version of clang (best if it contains the git hash it was build from) and you don't include headers (they don't seem to be required for the test), then the file would be much easier to

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. Alright, let's see if the others see any other issues, otherwise I think this is finally good to go. Comment at: lldb/source/Host/common/Editline.cpp:1011 el_insertstr(m_editline, to_add.c_str()); - break; + if (to_add == " ") +

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2199450 , @gedatsu217 wrote: >> So, if I would type "b" and then press tab, the autosuggestion would briefly >> disappear until I type the next character? > > Yes. Indeed, it may not be good. I'll think of other

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2199205 , @gedatsu217 wrote: >> So the way the issue with the single space is now solved is by doing >> CC_REDISPLAY when we're only adding the single space? Isn't that also >> deleting the whole autosuggestion? > >

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor added a comment. Same on Arch Linux. Should be fixed in 45f9fc890705a8272e5253602f5506fdef4586e2 (I just removed the scope operator). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85145/new/ https://reviews.llvm.org/D85145

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. So the way the issue with the single space is now solved is by doing CC_REDISPLAY when we're only adding the single space? Isn't that also deleting the whole autosuggestion? In D81001#2190864 , @gedatsu217 wrote: I don't

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Sorry was OOO. The source code is user input, so you can have anything in it. LLDB will happily read and return any file contents as long as it matches the source path. Like, create a

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D85145#2191658 , @llunak wrote: > In D85145#2191421 , @teemperor wrote: > >> Btw, the

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor added a reviewer: teemperor. teemperor added a comment. Btw, the highlighter supports any kind of delimiter string when 'highlighting' source. So you could add a parameter for a custom highlighter too and then pass a more convenient highlighter 'style' in to make the parsing simpler.

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2190646 , @gedatsu217 wrote: > @skipIfAsan > @skipIfEditlineSupportMissing > def test_hidden_autosuggestion(self): > @skipIfAsan > @skipIfEditlineSupportMissing > def test_autosuggestion(self): >

<    1   2   3   4   5   6   7   8   9   10   >