[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. > add a way to make an SBTypeSynthetic from the appropriate C++ class That's a great idea. Once we implement a couple of providers for our plugin I'll revisit the idea. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

This revision was automatically updated to reflect the committed changes. Closed by commit rG79d5d9a0824d: [lldb] Allow synthetic providers in C++ and fix linking problems (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. For the sake of unblocking this diff, I'm accepting it because there's no clear actionable feedback at the moment. @electriclilies, please follow up any feedback that is submitted

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace marked an inline comment as done. wallace added a comment. @aprantl , it turns out that there are no tests for this. I also don't know how easy it'd be to test this very specific feature, because it relies on the terminal not being affected by stuff like test runners. CHANGES SINCE

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace updated this revision to Diff 554712. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159031/new/ https://reviews.llvm.org/D159031 Files: lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Host/Editline.h lldb/source/Core/IOHandler.cpp lldb/source/Expression/REPL.cpp

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace added inline comments. Comment at: lldb/source/Expression/REPL.cpp:535 + if (current_line_idx < current_lines.GetSize()) { +for (uint32_t i = 0; i < current_line_idx; ++i) { + const char *line_cstr = current_lines.GetStringAtIndex(i); aprantl

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace created this revision. wallace added reviewers: bulbazord, aprantl, JDevlieghere. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method was working as expected if `LLDB_ENABLE_LIBEDIT` is

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

wallace added a comment. @aprantl, how should I proceed with the swift branch? Should I create a new branch in https://github.com/apple/swift and share it here so it's available for whoever does the merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

wallace updated this revision to Diff 553804. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158958/new/ https://reviews.llvm.org/D158958 Files: lldb/source/Core/CoreProperties.td Index: lldb/source/Core/CoreProperties.td

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

wallace created this revision. wallace added reviewers: bulbazord, JDevlieghere. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The REPL has a default tab size of 4 spaces, which seems to be a bit too

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Awesome!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158893/new/ https://reviews.llvm.org/D158893 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. In D158010#4617611 , @electriclilies wrote: > @wallace The type synthetic add command already disables itself if python is > not enabled (the check is at CommandObjectType::1564), so I think there > aren't any changes I need

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Awesome! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158801/new/ https://reviews.llvm.org/D158801 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158788/new/ https://reviews.llvm.org/D158788 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - wallace wrote: > electriclilies wrote: > > jingham wrote: > > > electriclilies wrote: > > > > rriddle wrote: > > > > > Why is this dropped? > >

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace added a comment. @JDevlieghere , that worked. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace added a comment. @jasonmolenda , yep. I have already reverted this patch. I'll figure out how to make that work nicely with these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - electriclilies wrote: > jingham wrote: > > electriclilies wrote: > > > rriddle wrote: > > > > Why is this dropped? > > > Walter and I want to

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4dbdf474993: [LLDB] Allow expression evaluators to set arbitrary timeouts (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace added a comment. Btw, the SBAPI expects the old behavior. // Set the timeout for the expression, 0 means wait forever. void SetTimeoutInMicroSeconds(uint32_t timeout = 0); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace created this revision. wallace added a reviewer: bulbazord. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://github.com/llvm/llvm-project/commit/59237bb52c9483fce395428bfab5996eabe54ed0

[Lldb-commits] [PATCH] D156979: [lldb][lldb-vscode] Pretty print JSON to log files

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice improvement for sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156979/new/ https://reviews.llvm.org/D156979

[Lldb-commits] [PATCH] D156977: [lldb][lldb-vscode] Fix nullptr dereference when JSON is not an object

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156977/new/ https://reviews.llvm.org/D156977

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

wallace added a comment. Greg hasn't been working for a while. You can go ahead and land this, and when he gets back he can share some feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. fancy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156465/new/ https://reviews.llvm.org/D156465

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. you are my hero Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

wallace added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. fingers crossed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ https://reviews.llvm.org/D155248

[Lldb-commits] [PATCH] D154990: [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. wooo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154990/new/ https://reviews.llvm.org/D154990

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace added a comment. Could you split the changes to the selected thread out of this? I'm seeing two features being implemented in this patch. Other than that, it looks pretty good! Comment at: lldb/tools/lldb-vscode/Options.td:20-38 +def port: S<"port">,

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154029/new/ https://reviews.llvm.org/D154029

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. THANKS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154028/new/ https://reviews.llvm.org/D154028

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. pretty nice. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154026/new/ https://reviews.llvm.org/D154026

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG582582fb474b: [LLDB] Add DWARF definitions for the new Mojo language (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Please write an entry about this in the documentation of lldb-vscode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. pretty nice! Just a few nits, but other than that it's good to go Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1475 + auto cmd =

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

wallace created this revision. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. wallace requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. The new language Mojo recently

[Lldb-commits] [PATCH] D152326: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152326/new/ https://reviews.llvm.org/D152326

[Lldb-commits] [PATCH] D151962: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. LGTM. It also works with the mojo REPL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151962/new/ https://reviews.llvm.org/D151962

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

wallace accepted this revision. wallace added a comment. This seems reasonable to me and I'm accepting it to unblock this feature. When Greg gets back he should be able to provide some additional comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151501: [LLDB] Explicitly declare constructor in `PersistentExpressionState`

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added subscribers: Michael137, JDevlieghere. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151501/new/

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

This revision was automatically updated to reflect the committed changes. Closed by commit rGf237513cda8e: [LLDB] Add some declarations related to REPL support for mojo (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524449. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524448. wallace added a comment. Use RTTIExtends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace added a comment. Sure, I can use it. I just didn't know it exists :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace updated this revision to Diff 524398. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 Files: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150470/new/ https://reviews.llvm.org/D150470

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This simple diff declares some enum values needed to create a REPL for the mojo language. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

wallace added a comment. The alias still works because it still holds a reference to it. I could add that as a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149379/new/ https://reviews.llvm.org/D149379

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb7c99f3aea: [LLDB] Add a hook to notify REPLs that an expression was evaluated (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5f745a2bfc: [lldb] Make some functions useful to REPLs public (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:124 +const lldb::ValueObjectSP _valobj_sp, +const Status ) { +return llvm::Error::success(); bulbazord wrote: > Do you still need

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace updated this revision to Diff 519542. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://reviews.llvm.org/D149717 Files: lldb/include/lldb/Core/Debugger.h Index:

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace updated this revision to Diff 519338. wallace added a comment. add the language as a vendor extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ https://reviews.llvm.org/D149702 Files: lldb/docs/python_api_enums.rst

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace added a comment. In D149702#4316747 , @aprantl wrote: > You can also use a constant in the Vendor extension space, which might be > more appropriate until the languages sees adoption by a wider audience. That sounds like a better idea. Thanks!

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace updated this revision to Diff 519163. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149719/new/ https://reviews.llvm.org/D149719 Files: lldb/include/lldb/Expression/REPL.h

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace updated this revision to Diff 519141. wallace added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://reviews.llvm.org/D149717 Files: lldb/include/lldb/Core/Debugger.h Index:

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:503-504 + /// Manually start the global event handler thread. It should be used by + /// programs that use LLDB as a library. + bool StartEventHandlerThread(); bulbazord wrote: >

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:115-120 + virtual void + OnExpressionEvaluated(const ExecutionContext _ctx, llvm::StringRef code, +const EvaluateExpressionOptions _options, +

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. REPL implementations don't have an easy way to know that an expression has been evaluated, so I'm adding a simple function

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `StartEventHandlerThread` and `StopEventHandlerThread` are available to the SwiftREPL even though they are protected

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, aprantl wrote: > bulbazord wrote: > > These values correspond to DWARF5's official language codes and `0x0030`

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace created this revision. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. Herald added a project: All. wallace requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Modular just announced a new

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm! Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1983 + g_vsc.debugger.SetAsync(true); + LaunchProcess(*g_vsc.last_launch_or_attach_request); +

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

wallace added inline comments. Comment at: lldb/source/API/SBProcess.cpp:772 - return (event.GetBroadcasterClass() == SBProcess::GetBroadcasterClass()) && - !EventIsStructuredDataEvent(event); + return Process::ProcessEventData::GetEventDataFromEvent(event.get()) !=

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. @jingham, in my use case, I'm exposing a minified LLDB client remotely, so the user won't have access to script command nor the SB API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. -> https://reviews.llvm.org/D149379 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

wallace created this revision. wallace added a reviewer: jingham. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds some tests for removing lldb commands, user command and aliases. I've done in

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. Sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1465cd49efc: [lldb] Create a way to force remove commands (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace updated this revision to Diff 517399. wallace added a comment. remove whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 Files:

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some LLDB set ups need to hide certain commands for security reasons, so I'm adding a flag that allows removing non-user

[Lldb-commits] [PATCH] D149180: [LLDB][REPL] Destroy the repl instances correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59a39c2fc91e: [LLDB][REPL] Destroy the repl instances correctly (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D149180: [LLDB][REPL] Destroy the repl instances correctly

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change ensures that the REPL map inside Target is destroyed correctly when `Target::Destroy()` is invoked. Not doing

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

wallace added a comment. wow, nice improvement. I don't have anything else to add besides what @rupprecht said Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147805/new/ https://reviews.llvm.org/D147805

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe538c6fc3048: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided. (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510588. wallace added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:175 +CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") +endif() JDevlieghere wrote: > Rather than changing the

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510557. wallace added a comment. gate the target OS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:173 + if (LLDB_EXPORT_ALL_SYMBOLS) +if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") rriddle wrote: > Other

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510551. wallace added a comment. another nit... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510550. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace created this revision. wallace added a reviewer: rriddle. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we need to use

[Lldb-commits] [PATCH] D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147252/new/ https://reviews.llvm.org/D147252

[Lldb-commits] [PATCH] D139969: Add a json dumper for call graph reconstructor

wallace added a comment. I'll take a look at this later tonight or tomorrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139969/new/ https://reviews.llvm.org/D139969 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D138345: [test][lldb-vscode] Un-realpath coreFile test.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. yep, there's no need for the realpath Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138345/new/ https://reviews.llvm.org/D138345

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/API/SBTraceCursor.cpp:127-131 +double SBTraceCursor::GetWallClockTime() const { + LLDB_INSTRUMENT_VA(this); + + const auto _wall_clock_time =

[Lldb-commits] [PATCH] D137614: [trace] Add a new call graph reconstructor

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:296 std::vector m_item_data; + std::vector m_insn_extra_info; /// The TraceItemKind for each trace item encoded as uint8_t. We don't include jj10306 wrote: > do

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/API/SBTraceCursor.h:175 + /// if not available. + double GetWallClockTime() const; + /// \} mention

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if the trace will be created not using the CLI or on a machine other than where

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if the trace will be consumed using `SBTraceCursor`. "threads": [

[Lldb-commits] [PATCH] D136801: [intelpt] Update Python tests to account for new errrors

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136801/new/ https://reviews.llvm.org/D136801

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks. Your explanation of why the verbose error is useful was good :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136610/new/

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace updated this revision to Diff 470343. wallace added a comment. address issues and comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136557/new/ https://reviews.llvm.org/D136557 Files: lldb/include/lldb/Core/PluginManager.h

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:123 /// of a DenseMap because DenseMap can't understand enums. -std::unordered_map events_counts; -size_t total_count = 0; +std::unordered_map events_counts; +

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty good! I just left cosmetic requests Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:285-312 + if (event.has_tsc) { +if

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace updated this revision to Diff 470047. wallace edited the summary of this revision. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136557/new/ https://reviews.llvm.org/D136557 Files:

  1   2   3   4   5   6   7   8   9   10   >