jingham added a subscriber: jingham.
jingham added a comment.
This patch is not acceptable as is. It enshrines an incorrect usage of the
function cstring_is_mangled which we shouldn’t do. As I said in the previous
comment, it’s okay to come up with a short term fix, and check the mangled
This patch is not acceptable as is. It enshrines an incorrect usage of the
function cstring_is_mangled which we shouldn’t do. As I said in the previous
comment, it’s okay to come up with a short term fix, and check the mangled
flavor against Itanium and MSVC. So it shouldn’t be hard to
dawn added a comment.
ping?
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
"cstring_is_mangled" does NOT mean that the string is a C++ mangled string, it
means it is ANY kind of mangled string - you can tell because it is used to
determine whether to populate the m_mangled and m_demangled components of the
Mangled structure, which it should
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The part of this fix which is using info in the SymbolContext to make the
language detection more accurate is fine.
We have to do something better about how we detect the language
dawn added a reviewer: clayborg.
dawn added a comment.
(Added Greg - he wrote Mangled::GetLanguage - now GuessLanguage).
This patch removes the dependence on determining language from the name
mangling for 99% of cases (there's still the much less common problem for
symbols since Symbol 's
dawn marked an inline comment as done.
dawn added a comment.
Thanks Greg. Will fix comment in commit.
@Jim, can you accept please?
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn requested a review of this revision.
dawn added a comment.
Please reconsider. Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn created this revision.
dawn added a reviewer: jingham.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch reworks the breakpoint filter-by-language patch to use the symbol
context instead of trying to guess the language solely from the
