[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

This revision was automatically updated to reflect the committed changes. Closed by commit rL324368: Build each testcase variant in its own subdirectory and remove the srcdir lock… (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks much better. Thanks. https://reviews.llvm.org/D42763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl updated this revision to Diff 132888. aprantl marked 17 inline comments as done. aprantl added a comment. Cleanup and address outstanding review feedback. https://reviews.llvm.org/D42763 Files: packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl updated this revision to Diff 132875. aprantl added a comment. Updated to query self.getDebugInfo() in getBuildDir(). https://reviews.llvm.org/D42763 Files: packages/Python/lldbsuite/test/api/listeners/TestListener.py

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added inline comments. Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26 TestBase.setUp(self) -self.build() aprantl wrote: > labath wrote: > > I'm confused by these changes. I was under the impression that

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:96-98 +return "-N dwarf %s" % (testdir) else: +return "-N dsym %s" % (testdir) labath wrote: > aprantl wrote: > > labath wrote: > > >

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26 TestBase.setUp(self) -self.build() labath wrote: > I'm confused by these changes. I was under the impression that setUp() runs > before

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added inline comments. Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26 TestBase.setUp(self) -self.build() I'm confused by these changes. I was under the impression that setUp() runs before each test method

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl updated this revision to Diff 132456. aprantl added a comment. Fix broken testcases. https://reviews.llvm.org/D42763 Files: packages/Python/lldbsuite/test/api/listeners/TestListener.py packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py

Re: [Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

Yeah, no reason to pile on this patch, mostly I was making sure I understood what we could do... Jim > On Feb 1, 2018, at 11:24 AM, Adrian Prantl via Phabricator > wrote: > > aprantl added a comment. > > @jingham wrote: > >> Now that we aren't mixing variants,

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl added a comment. @jingham wrote: > Now that we aren't mixing variants, would it be possible to have a test class > claim that all the tests use the same binary file? At present to get > self-contained tests you often need to do roughly the same thing many times, > on the same binary.

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl updated this revision to Diff 132433. aprantl added a comment. Update the diff with Pavel's awesome suggestion of using self.testMethodName. Note that that I haven't fixed all the resulting test error yet, I'm working through those now. https://reviews.llvm.org/D42763 Files:

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl added a comment. lib/IR -> test/IR https://reviews.llvm.org/D42763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:96-98 +return "-N dwarf %s" % (testdir) else: +return "-N dsym %s" % (testdir) aprantl wrote: > labath wrote: > > xiaobai wrote: > > > Good

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl added a comment. > I am not sure this actually creates enough separation. That's a good point. If I manage to extract the testname somehow via Python reflection magic, I could also get rid of the unintuitive self.mydir tuple. I'll give that a try. Comment at:

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl updated this revision to Diff 132417. aprantl added a comment. Address review feedback from Alex. https://reviews.llvm.org/D42763 Files: packages/Python/lldbsuite/test/api/listeners/TestListener.py

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath added a comment. I am not sure this actually creates enough separation. Plenty of tests have more then one test method per file: TestFoo.py: class FooTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True def test_bar(self): ... def test_baz(self): ... If I

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

xiaobai added a comment. Oh, FWIW I tested this on Linux (specifically CentOS) and the test result summary showed no difference in Success/Failure rate. https://reviews.llvm.org/D42763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

xiaobai added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py:39-40 (_COMP_DIR_SYM_LINK_PROP, pwd_symlink)) -lldbutil.run_break_set_by_file_and_line(self, self.src_path,

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl created this revision. aprantl added reviewers: labath, zturner, jingham. Herald added subscribers: JDevlieghere, eraman. This patch creates a .dwarf, .dwo, etc., build directory for each testcase variant. Most importantly, this eliminates the need for the per-test lock file in the